Re: [PATCH] i2c-qoriq: modified compatibility for correct prescaler

2014-12-26 Thread Scott Wood
On Tue, 2014-12-23 at 14:49 +0100, Wolfram Sang wrote: > On Tue, Dec 23, 2014 at 02:23:01PM +0100, Valentin Longchamp wrote: > > Wolfgang, Scott, > > Wolfram, please. > > > > What is then the agreement here ? Add a clock-div to the device trees ? > > > Or do > > > something similar to mpc_i2c_g

Re: [PATCH] i2c-qoriq: modified compatibility for correct prescaler

2014-12-23 Thread Wolfram Sang
On Tue, Dec 23, 2014 at 02:23:01PM +0100, Valentin Longchamp wrote: > Wolfgang, Scott, Wolfram, please. > > What is then the agreement here ? Add a clock-div to the device trees ? Or > > do > > something similar to mpc_i2c_get_sec_cfg_8xxx() ? > > > > I think the clock-div property is better a

Re: [PATCH] i2c-qoriq: modified compatibility for correct prescaler

2014-12-23 Thread Valentin Longchamp
Wolfgang, Scott, On 12/11/2014 02:44 PM, Valentin Longchamp wrote: > Hi all, > > Picking up this issue again. > > On 11/26/2014 02:41 AM, Scott Wood wrote: >> On Tue, 2014-11-25 at 19:13 +0100, Wolfram Sang wrote: >>> On Mon, Nov 17, 2014 at 07:28:03PM -0600, Scott Wood wrote: On Fri, 2014-

Re: [PATCH] i2c-qoriq: modified compatibility for correct prescaler

2014-12-11 Thread Valentin Longchamp
Hi all, Picking up this issue again. On 11/26/2014 02:41 AM, Scott Wood wrote: > On Tue, 2014-11-25 at 19:13 +0100, Wolfram Sang wrote: >> On Mon, Nov 17, 2014 at 07:28:03PM -0600, Scott Wood wrote: >>> On Fri, 2014-11-14 at 09:28 +0100, Wolfram Sang wrote: >> >> If we're going to change

Re: [PATCH] i2c-qoriq: modified compatibility for correct prescaler

2014-12-01 Thread Wolfram Sang
> I saw that this patch was marked as not applicable, but on most qoriq > devices the pre-scaler is 2 especially for p2020/p2010 devices > arch/powerpc/boot/dts/fsl/p2020si-post.dtsi Just for completeness: "Not applicable" given from patchwork of the i2c subsystem means this patch is not for the

Re: [PATCH] i2c-qoriq: modified compatibility for correct prescaler

2014-11-29 Thread Danielle Costantino
I saw that this patch was marked as not applicable, but on most qoriq devices the pre-scaler is 2 especially for p2020/p2010 devices arch/powerpc/boot/dts/fsl/p2020si-post.dtsi from the P2020 RM: p. 477 "Frequency divider ratio. Used to prescale the clock for bit rate selection. The serial bit clo

Re: [PATCH] i2c-qoriq: modified compatibility for correct prescaler

2014-11-25 Thread Scott Wood
On Tue, 2014-11-25 at 19:13 +0100, Wolfram Sang wrote: > On Mon, Nov 17, 2014 at 07:28:03PM -0600, Scott Wood wrote: > > On Fri, 2014-11-14 at 09:28 +0100, Wolfram Sang wrote: > > > > > > > > > > If we're going to change the device tree I'd rather just add a > > > > > property > > > > > to say wh

Re: [PATCH] i2c-qoriq: modified compatibility for correct prescaler

2014-11-25 Thread Wolfram Sang
On Mon, Nov 17, 2014 at 07:28:03PM -0600, Scott Wood wrote: > On Fri, 2014-11-14 at 09:28 +0100, Wolfram Sang wrote: > > > > > > > > If we're going to change the device tree I'd rather just add a property > > > > to say what the prescaler is. > > > > > > We would however, leave the boards' devic

Re: [PATCH] i2c-qoriq: modified compatibility for correct prescaler

2014-11-17 Thread Scott Wood
On Fri, 2014-11-14 at 09:28 +0100, Wolfram Sang wrote: > > > > > > If we're going to change the device tree I'd rather just add a property > > > to say what the prescaler is. > > > > We would however, leave the boards' device trees that use things like > > "fsl,mpc8543-i2c" as is and introduce t

Re: [PATCH] i2c-qoriq: modified compatibility for correct prescaler

2014-11-14 Thread Wolfram Sang
> > > > If we're going to change the device tree I'd rather just add a property > > to say what the prescaler is. > > We would however, leave the boards' device trees that use things like > "fsl,mpc8543-i2c" as is and introduce the prescaler for the others requiring > it. > > > Now the drawb

Re: [PATCH] i2c-qoriq: modified compatibility for correct prescaler

2014-11-13 Thread Valentin Longchamp
On 11/13/2014 01:34 AM, Wolfram Sang wrote: > >> If we wanted to be on the safe side and strict (since we are not sure that >> the >> hardware is 100% compatible), we maybe should add a fsl,qoriq-i2c compatible >> to >> the driver that does the same as mpc8543-i2c. > > Or you leave the driver a

Re: [PATCH] i2c-qoriq: modified compatibility for correct prescaler

2014-11-12 Thread Wolfram Sang
> If we wanted to be on the safe side and strict (since we are not sure that the > hardware is 100% compatible), we maybe should add a fsl,qoriq-i2c compatible > to > the driver that does the same as mpc8543-i2c. Or you leave the driver as is and use both compatibles: compatible = "fsl,qoriq-i2

Re: [PATCH] i2c-qoriq: modified compatibility for correct prescaler

2014-11-06 Thread Scott Wood
On Wed, 2014-10-29 at 09:59 +0100, Valentin Longchamp wrote: > On 10/29/2014 12:08 AM, Scott Wood wrote: > > On Fri, 2014-10-17 at 11:27 +0200, Valentin Longchamp wrote: > >> With "fsl-i2c" compatibility the i2c frequency is not set > >> correctly, because it sets no prescaler. According to the AN2

Re: [PATCH] i2c-qoriq: modified compatibility for correct prescaler

2014-10-29 Thread Valentin Longchamp
On 10/29/2014 12:08 AM, Scott Wood wrote: > On Fri, 2014-10-17 at 11:27 +0200, Valentin Longchamp wrote: >> With "fsl-i2c" compatibility the i2c frequency is not set >> correctly, because it sets no prescaler. According to the AN2919 from >> Freescale and the QorIQ (P2041) documentation, the source

Re: [PATCH] i2c-qoriq: modified compatibility for correct prescaler

2014-10-28 Thread Scott Wood
On Fri, 2014-10-17 at 11:27 +0200, Valentin Longchamp wrote: > With "fsl-i2c" compatibility the i2c frequency is not set > correctly, because it sets no prescaler. According to the AN2919 from > Freescale and the QorIQ (P2041) documentation, the source clock is 1/2 > the platform clock. This implie

[PATCH] i2c-qoriq: modified compatibility for correct prescaler

2014-10-17 Thread Valentin Longchamp
With "fsl-i2c" compatibility the i2c frequency is not set correctly, because it sets no prescaler. According to the AN2919 from Freescale and the QorIQ (P2041) documentation, the source clock is 1/2 the platform clock. This implies that a prescaler of 2 must be used. This changes the compatibility