...@alsa-project.org;
broo...@sirena.org.uk
Subject: Re: [PATCH] alsa/soc: add locking to mpc5200-psc-ac97 driver
On Wed, Jul 1, 2009 at 7:55 AM, Wolfram Sang
wrote:
>
>> > Sorry, I didn't get it: Shall I test something specific?
>>
>> I don't own a touchscreen.
>
On Wed, Jul 1, 2009 at 7:55 AM, Wolfram Sang wrote:
>
>> > Sorry, I didn't get it: Shall I test something specific?
>>
>> I don't own a touchscreen.
>>
>> AFAIK no one has ever plugged a touchscreen into the PCM-973 to see if
>> works since there hasn't been a driver previously.
>> Just do a genera
> > Sorry, I didn't get it: Shall I test something specific?
>
> I don't own a touchscreen.
>
> AFAIK no one has ever plugged a touchscreen into the PCM-973 to see if
> works since there hasn't been a driver previously. Just do a general
> test so that you can tell customers that it works.
I am
On Wed, Jul 1, 2009 at 4:56 AM, Wolfram Sang wrote:
> Hi Jon,
>
>> Wolfram, do you have any way to test the on the Phytec hardware? The
>> WM9712 on the baseboard supports a touchscreen, is it brought out to a
>> header?
>
> Sorry, I didn't get it: Shall I test something specific?
I don't own a to
Hi Jon,
> Wolfram, do you have any way to test the on the Phytec hardware? The
> WM9712 on the baseboard supports a touchscreen, is it brought out to a
> header?
Sorry, I didn't get it: Shall I test something specific?
The touchscreen connector is X19 BTW (assuming a PCM-973 baseboard).
Regards
On Tue, Jun 30, 2009 at 2:59 AM, Mark
Brown wrote:
> On Mon, Jun 29, 2009 at 08:26:12PM -0400, Jon Smirl wrote:
>
>> Does your touchscreen driver use this mutex? Or was this mutex needed
>> just for the AC97 driver?
>
> It's in the register accesses so everything accessing the chip registers
> will
On Tue, Jun 30, 2009 at 2:18 AM, Wolfram Sang wrote:
Wolfram, do you have any way to test the on the Phytec hardware? The
WM9712 on the baseboard supports a touchscreen, is it brought out to a
header?
> Hi Grant,
>
> On Mon, Jun 29, 2009 at 05:42:21PM -0600, Grant Likely wrote:
>> From: Grant Li
On Tue, Jun 30, 2009 at 09:42:06AM -0400, Jon Smirl wrote:
> Wolfram, do you have any way to test the on the Phytec hardware? The
> WM9712 on the baseboard supports a touchscreen, is it brought out to a
> header?
You can probably test adequately by writing a dummy AC97 driver that
sits in a threa
On Tue, Jun 30, 2009 at 12:50 PM, Grant Likely wrote:
> On Tue, Jun 30, 2009 at 12:18 AM, Wolfram Sang wrote:
>>> +
>>> + /* Force clear the data valid bit */
>>> + in_be32(&psc_dma->psc_regs->ac97_data);
>>> +
>>
>> No mutex involved here. I think this is either a separate patch or it need
On Tue, Jun 30, 2009 at 12:33 PM, Jon Smirl wrote:
> On Tue, Jun 30, 2009 at 12:50 PM, Grant Likely
> wrote:
>> On Tue, Jun 30, 2009 at 12:18 AM, Wolfram Sang wrote:
+
+ /* Force clear the data valid bit */
+ in_be32(&psc_dma->psc_regs->ac97_data);
+
>>>
>>> No mutex in
On Tue, Jun 30, 2009 at 12:18 AM, Wolfram Sang wrote:
>> +
>> + /* Force clear the data valid bit */
>> + in_be32(&psc_dma->psc_regs->ac97_data);
>> +
>
> No mutex involved here. I think this is either a seperate patch or it needs at
> least to be mentioned in the patch description.
Oops,
On Mon, Jun 29, 2009 at 08:26:12PM -0400, Jon Smirl wrote:
> Does your touchscreen driver use this mutex? Or was this mutex needed
> just for the AC97 driver?
It's in the register accesses so everything accessing the chip registers
will use it.
___
Linu
Hi Grant,
On Mon, Jun 29, 2009 at 05:42:21PM -0600, Grant Likely wrote:
> From: Grant Likely
>
> AC97 bus register read/write hooks need to provide locking, but the
> mpc5200-psc-ac97 driver does not. This patch adds a mutex around
> the register access routines.
>
> Signed-off-by: Grant Likel
On Mon, Jun 29, 2009 at 7:42 PM, Grant Likely wrote:
> From: Grant Likely
>
> AC97 bus register read/write hooks need to provide locking, but the
> mpc5200-psc-ac97 driver does not. This patch adds a mutex around
> the register access routines.
Does your touchscreen driver use this mutex? Or was
From: Grant Likely
AC97 bus register read/write hooks need to provide locking, but the
mpc5200-psc-ac97 driver does not. This patch adds a mutex around
the register access routines.
Signed-off-by: Grant Likely
---
sound/soc/fsl/mpc5200_dma.c |1 +
sound/soc/fsl/mpc5200_dma.h |
15 matches
Mail list logo
