On Tue, Jun 30, 2009 at 12:33 PM, Jon Smirl<jonsm...@gmail.com> wrote: > On Tue, Jun 30, 2009 at 12:50 PM, Grant Likely<grant.lik...@secretlab.ca> > wrote: >> On Tue, Jun 30, 2009 at 12:18 AM, Wolfram Sang<w.s...@pengutronix.de> wrote: >>>> + >>>> + /* Force clear the data valid bit */ >>>> + in_be32(&psc_dma->psc_regs->ac97_data); >>>> + >>> >>> No mutex involved here. I think this is either a separate patch or it needs >>> at >>> least to be mentioned in the patch description. >> >> Oops, that was sloppy. Yes, I'll put this into a separate patch. Thanks. > > Now that you have added the mutexes, do you ever need to force clear > the valid bit? > Maybe log an error if this happens so that we can track down why.
I know exactly why it happened. spin_event_timeout() had a bug that would cause it to report a false positive timeout. The bug is fixed and queued for merging. However, I still think this explicit clear should be applied. It is just a cheap register read and it prevents the driver from getting wedged after a timeout does event, for whatever reason. g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
