Re: [PATCH] Make PCIe hotplug work with Freescale PCIe controllers

2013-03-13 Thread Kumar Gala
On Mar 13, 2013, at 5:06 AM, Rojhalat Ibrahim wrote: > On Tuesday 12 March 2013 15:48:01 Kumar Gala wrote: >>> I'd rather we just export indirect_read_config() & indirect_write_config() >>> from indirect_pci.c and call the functions directly. Adding a global and >>> call them via a function poin

Re: [PATCH] Make PCIe hotplug work with Freescale PCIe controllers

2013-03-13 Thread Rojhalat Ibrahim
On Tuesday 12 March 2013 15:48:01 Kumar Gala wrote: > > I'd rather we just export indirect_read_config() & indirect_write_config() > > from indirect_pci.c and call the functions directly. Adding a global and > > call them via a function pointer seems wrong to me. > > > > - k > > Also, can you ba

Re: [PATCH] Make PCIe hotplug work with Freescale PCIe controllers

2013-03-12 Thread Kumar Gala
On Mar 12, 2013, at 3:44 PM, Kumar Gala wrote: > > On Mar 12, 2013, at 4:23 AM, Rojhalat Ibrahim wrote: > >> On Monday 11 March 2013 12:17:42 Kumar Gala wrote: >>> >>> Rather than do it this way, we should do something like: >>> >>> fsl_indirect_read_config() { >>> link check >>> if (

Re: [PATCH] Make PCIe hotplug work with Freescale PCIe controllers

2013-03-12 Thread Kumar Gala
On Mar 12, 2013, at 4:23 AM, Rojhalat Ibrahim wrote: > On Monday 11 March 2013 12:17:42 Kumar Gala wrote: >> >> Rather than do it this way, we should do something like: >> >> fsl_indirect_read_config() { >> link check >> if (link) >> indirect_read_config() >> } >> >> and

Re: [PATCH] Make PCIe hotplug work with Freescale PCIe controllers

2013-03-12 Thread Rojhalat Ibrahim
-bounces+tie- > >>>> fei.zang=freescale@lists.ozlabs.org] On Behalf Of Rojhalat Ibrahim > >>>> Sent: Tuesday, March 12, 2013 5:23 PM > >>>> To: Kumar Gala > >>>> Cc: linuxppc-dev@lists.ozlabs.org > >>>> Subject: Re: [PA

Re: [PATCH] Make PCIe hotplug work with Freescale PCIe controllers

2013-03-12 Thread Chen Yuanquan-B41889
PM To: Kumar Gala Cc: linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH] Make PCIe hotplug work with Freescale PCIe controllers On Monday 11 March 2013 12:17:42 Kumar Gala wrote: Rather than do it this way, we should do something like: fsl_indirect_read_config() { link check if

Re: [PATCH] Make PCIe hotplug work with Freescale PCIe controllers

2013-03-12 Thread Rojhalat Ibrahim
5:23 PM > >> To: Kumar Gala > >> Cc: linuxppc-dev@lists.ozlabs.org > >> Subject: Re: [PATCH] Make PCIe hotplug work with Freescale PCIe > >> controllers > >> > >> On Monday 11 March 2013 12:17:42 Kumar Gala wrote: > >&

[PATCH] Make PCIe hotplug work with Freescale PCIe controllers

2013-03-12 Thread Chen Yuanquan-B41889
-Original Message- From: Linuxppc-dev [mailto:linuxppc-dev-bounces+tie- fei.zang=freescale@lists.ozlabs.org] On Behalf Of Rojhalat Ibrahim Sent: Tuesday, March 12, 2013 5:23 PM To: Kumar Gala Cc: linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH] Make PCIe hotplug work with

Re: [PATCH] Make PCIe hotplug work with Freescale PCIe controllers

2013-03-12 Thread Rojhalat Ibrahim
On Monday 11 March 2013 12:17:42 Kumar Gala wrote: > > Rather than do it this way, we should do something like: > > fsl_indirect_read_config() { > link check > if (link) > indirect_read_config() > } > > and just add fsl_indirect_{r,w}_config into fsl_pci.c > > - k >

Re: [PATCH] Make PCIe hotplug work with Freescale PCIe controllers

2013-03-11 Thread Kumar Gala
On Mar 11, 2013, at 9:47 AM, Rojhalat Ibrahim wrote: > Hi, > > this issue was brought up before. > See this thread: > https://lists.ozlabs.org/pipermail/linuxppc-dev/2012-July/099529.html > > The following patch works for me. > Hot-added devices appear after "echo 1 > /sys/bus/pci/rescan". >

Re: [PATCH] Make PCIe hotplug work with Freescale PCIe controllers

2013-03-11 Thread Joakim Tjernlund
Rojhalat Ibrahim wrote on 2013/03/11 15:47:30: > > Hi, > > this issue was brought up before. > See this thread: https://lists.ozlabs.org/pipermail/linuxppc-dev/2012-July/099529.html > > The following patch works for me. > Hot-added devices appear after "echo 1 > /sys/bus/pci/rescan". > I test

[PATCH] Make PCIe hotplug work with Freescale PCIe controllers

2013-03-11 Thread Rojhalat Ibrahim
Hi, this issue was brought up before. See this thread: https://lists.ozlabs.org/pipermail/linuxppc-dev/2012-July/099529.html The following patch works for me. Hot-added devices appear after "echo 1 > /sys/bus/pci/rescan". I tested it with a P5020DS development system. Signed-off-by: Rojhalat I