On Mar 13, 2013, at 5:06 AM, Rojhalat Ibrahim wrote:
> On Tuesday 12 March 2013 15:48:01 Kumar Gala wrote:
>>> I'd rather we just export indirect_read_config() & indirect_write_config()
>>> from indirect_pci.c and call the functions directly. Adding a global and
>>> call them via a function pointer seems wrong to me.
>>>
>>> - k
>>
>> Also, can you base this patch on my powerpc.git next branch as fsl_pci.{c,h}
>> have some changes in them.
>>
>> - k
>>
>
> Hi Kumar,
>
> here's the patch with direct calls to indirect_{r,w}_config based on your
> powerpc.git next branch.
>
> This does not work for PCIe IP rev 3.0 as I'm not sure how to handle "struct
> resource" aside from making it global or changing "struct pci_controller".
>
> Rojhalat
I'll send a reworked version that hopefully deals with that issue that you can
test and make sure things work ok. As well as some other minor style code
cleanups.
- k
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
