On Fri, 2008-11-21 at 17:02 +0100, Johannes Berg wrote:
> On Fri, 2008-11-21 at 16:37 +0100, Joachim Fenkes wrote:
>
> > + u64 flags;
>
> > - spin_lock(&shca_list_lock);
> > + spin_lock_irqsave(&shca_list_lock, flags);
>
> That's wrong and I think will give a warning on all machines where
On Fri, 2008-11-21 at 16:37 +0100, Joachim Fenkes wrote:
> + u64 flags;
> - spin_lock(&shca_list_lock);
> + spin_lock_irqsave(&shca_list_lock, flags);
That's wrong and I think will give a warning on all machines where
u64 != unsigned long. Might not particularly matter in this case.
From: Michael Ellerman <[EMAIL PROTECTED]>
shca_list_lock is taken from softirq context in ehca_poll_eqs, so we need to
lock IRQ safe elsewhere.
Signed-off-by: Michael Ellerman <[EMAIL PROTECTED]>
Acked-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
drivers/infiniband/hw/ehca/ehca_main.c | 17
