On Fri, 2008-11-21 at 17:02 +0100, Johannes Berg wrote: > On Fri, 2008-11-21 at 16:37 +0100, Joachim Fenkes wrote: > > > + u64 flags; > > > - spin_lock(&shca_list_lock); > > + spin_lock_irqsave(&shca_list_lock, flags); > > That's wrong and I think will give a warning on all machines where > u64 != unsigned long. Might not particularly matter in this case.
Crud, sorry. > Also, generally it seems wrong to say "fix lockdep failure" when the > patch really fixes a bug that lockdep happened to find. True. I guess it should be "fix locking error found with lockdep", to make it clear no one has actually hit the bug. cheers -- Michael Ellerman OzLabs, IBM Australia Development Lab wwweb: http://michael.ellerman.id.au phone: +61 2 6212 1183 (tie line 70 21183) We do not inherit the earth from our ancestors, we borrow it from our children. - S.M.A.R.T Person
signature.asc
Description: This is a digitally signed message part
_______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
