Re: [PATCH] Add support for binary includes.

2008-06-04 Thread Josh Boyer
On Wed, 04 Jun 2008 09:26:23 -0500 Jon Loeliger <[EMAIL PROTECTED]> wrote: > David Gibson wrote: > > > But as I said that can be dealt with in the future without breaking > > compatibility. Objection withdrawn. > > > > And on that note, I officially implore Scott to > re-submit his binary incl

Re: [PATCH] Add support for binary includes.

2008-06-04 Thread Jon Loeliger
David Gibson wrote: But as I said that can be dealt with in the future without breaking compatibility. Objection withdrawn. And on that note, I officially implore Scott to re-submit his binary include patch! Sorry it's taken this long :(. No problem; no apology needed. [*1*] jdl [*1*]

Re: [PATCH] Add support for binary includes.

2008-06-04 Thread Bartlomiej Sieka
dealt with in the future without breaking compatibility. Objection withdrawn. Hi, To add one more point to the discussion: the /incbin/ syntax is being used in the new image format of U-Boot (we're using dtc with original patch by Scott Wood, i.e., http://www.nabble.com/-PATCH--Add-support-for-

Re: [PATCH] Add support for binary includes.

2008-06-03 Thread David Gibson
On Fri, May 30, 2008 at 01:54:59PM -0500, Scott Wood wrote: > David Gibson wrote: >> What I don't like is the combination of the two. Using the /word/ >> form in (1) suggests that each /word/ is a lexically distinct symbol >> with functions in different contexts: consider /dts-v1/, /include/, >> /

Re: [PATCH] Add support for binary includes.

2008-06-02 Thread Jon Loeliger
> On Thu, May 29, 2008 at 09:04:29AM -0500, Jon Loeliger wrote: > > > > I believe I am fully caught up at this point. > > Not quite, this one slipped through the cracks: Rats. > dtc: Fix some printf() format warnings when compiling 64-bit > > Currently, dtc generates a few gcc build warnings if

Re: [PATCH] Add support for binary includes.

2008-05-30 Thread Scott Wood
David Gibson wrote: What I don't like is the combination of the two. Using the /word/ form in (1) suggests that each /word/ is a lexically distinct symbol with functions in different contexts: consider /dts-v1/, /include/, /memreserve/ - they're all used only in their own distinct context. Use o

Re: [PATCH] Add support for binary includes.

2008-05-29 Thread David Gibson
On Thu, May 29, 2008 at 09:04:29AM -0500, Jon Loeliger wrote: > David Gibson wrote: > >> A while back I sent out a spiel explaining more clearly why I didn't >> like it, and where I thought we should go with this, but I don't think >> anyone noticed it at the time. I'll resend. > > Thanks. Actual

Re: [PATCH] Add support for binary includes.

2008-05-29 Thread Jon Loeliger
David Gibson wrote: A while back I sent out a spiel explaining more clearly why I didn't like it, and where I thought we should go with this, but I don't think anyone noticed it at the time. I'll resend. Thanks. I started working towards a version of this I liked, but was sidetracked by a c

Re: [PATCH] Add support for binary includes.

2008-05-28 Thread David Gibson
hile I discuss the syntax with Jon, here's some comments on the > >>> implementation. > >> > >> have we made any progress on the syntax? > > > > My last suggestions garnered a "I like that even less." response, > > so as far as I know, we

Re: [PATCH] Add support for binary includes.

2008-05-28 Thread David Gibson
On Tue, May 27, 2008 at 12:59:32PM -0500, Jon Loeliger wrote: > Kumar Gala wrote: >> >> On Feb 25, 2008, at 6:39 PM, David Gibson wrote: >> >>> On Wed, Feb 20, 2008 at 01:19:41PM -0600, Scott Wood wrote: A property's data can be populated with a file's contents as follows: node

Re: [PATCH] Add support for binary includes.

2008-05-27 Thread Jon Loeliger
Kumar Gala wrote: On Feb 25, 2008, at 6:39 PM, David Gibson wrote: On Wed, Feb 20, 2008 at 01:19:41PM -0600, Scott Wood wrote: A property's data can be populated with a file's contents as follows: node { prop = /incbin/("path/to/data"); }; A subset of a file can be included by passing s

Re: [PATCH] Add support for binary includes.

2008-02-26 Thread Scott Wood
On Tue, Feb 26, 2008 at 11:39:55AM +1100, David Gibson wrote: > > diff --git a/Makefile b/Makefile > > index 8a47c34..d4d935c 100644 > > --- a/Makefile > > +++ b/Makefile > > @@ -16,7 +16,7 @@ LOCAL_VERSION = > > CONFIG_LOCALVERSION = > > > > CPPFLAGS = -I libfdt > > -CFLAGS = -Wall -g -Os > >

Re: [PATCH] Add support for binary includes.

2008-02-25 Thread David Gibson
On Wed, Feb 20, 2008 at 01:19:41PM -0600, Scott Wood wrote: > A property's data can be populated with a file's contents > as follows: > > node { > prop = /incbin/("path/to/data"); > }; > > A subset of a file can be included by passing start and size parameters. > For example, to include byt

Re: [PATCH] Add support for binary includes.

2008-02-24 Thread David Gibson
On Fri, Feb 22, 2008 at 12:12:25PM -0600, Jon Loeliger wrote: > David Gibson wrote: > > >> node { > >>prop = /incbin/("path/to/data"); > >> }; > >> > >> node { > >>prop = /incbin/("path/to/data", 8, 16); > >> }; > > > > I still dislike the syntax, but haven't thought of a better one yet. >

Re: [PATCH] Add support for binary includes.

2008-02-24 Thread Jon Loeliger
David Gibson wrote: >> node { >> prop = /incbin/("path/to/data"); >> }; >> >> node { >> prop = /incbin/("path/to/data", 8, 16); >> }; > > I still dislike the syntax, but haven't thought of a better one yet. > There are some issues with the implementation too, but I've been a bit > too bu

Re: [PATCH] Add support for binary includes.

2008-02-22 Thread Jon Loeliger
So, like, the other day Scott Wood mumbled: > > > > Can I ask; what is the intended usage of such a thing? How large > > would a typical binary blob be? > > I use it for embedding guest device trees in a hypervisor's device tree. Why wouldn't we instead, say, extend the source sytax to allow a

Re: [PATCH] Add support for binary includes.

2008-02-22 Thread Scott Wood
On Fri, Feb 22, 2008 at 10:24:56AM -0600, Jon Loeliger wrote: > So, like, the other day Scott Wood mumbled: > > > > > > Can I ask; what is the intended usage of such a thing? How large > > > would a typical binary blob be? > > > > I use it for embedding guest device trees in a hypervisor's devic

Re: [PATCH] Add support for binary includes.

2008-02-22 Thread Scott Wood
On Thu, Feb 21, 2008 at 11:05:58PM -0700, Grant Likely wrote: > On Wed, Feb 20, 2008 at 12:19 PM, Scott Wood <[EMAIL PROTECTED]> wrote: > > A property's data can be populated with a file's contents > > as follows: > > > > node { > > prop = /incbin/("path/to/data"); > > }; > > > > A subs

Re: [PATCH] Add support for binary includes.

2008-02-22 Thread Grant Likely
On Fri, Feb 22, 2008 at 2:02 AM, David Woodhouse <[EMAIL PROTECTED]> wrote: > > On Thu, 2008-02-21 at 23:05 -0700, Grant Likely wrote: > > Can I ask; what is the intended usage of such a thing? How large > > would a typical binary blob be? > > Device firmware? That's what I was wondering abou

Re: [PATCH] Add support for binary includes.

2008-02-22 Thread Bartlomiej Sieka
Grant Likely wrote: > On Wed, Feb 20, 2008 at 12:19 PM, Scott Wood <[EMAIL PROTECTED]> wrote: >> A property's data can be populated with a file's contents >> as follows: >> >> node { >> prop = /incbin/("path/to/data"); >> }; >> >> A subset of a file can be included by passing start and

Re: [PATCH] Add support for binary includes.

2008-02-22 Thread David Woodhouse
On Thu, 2008-02-21 at 23:05 -0700, Grant Likely wrote: > Can I ask; what is the intended usage of such a thing? How large > would a typical binary blob be? Device firmware? -- dwmw2 ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlab

Re: [PATCH] Add support for binary includes.

2008-02-21 Thread Grant Likely
On Wed, Feb 20, 2008 at 12:19 PM, Scott Wood <[EMAIL PROTECTED]> wrote: > A property's data can be populated with a file's contents > as follows: > > node { > prop = /incbin/("path/to/data"); > }; > > A subset of a file can be included by passing start and size parameters. > For exampl

Re: [PATCH] Add support for binary includes.

2008-02-21 Thread David Gibson
On Wed, Feb 20, 2008 at 01:19:41PM -0600, Scott Wood wrote: > A property's data can be populated with a file's contents > as follows: > > node { > prop = /incbin/("path/to/data"); > }; > > A subset of a file can be included by passing start and size parameters. > For example, to include byt

[PATCH] Add support for binary includes.

2008-02-20 Thread Scott Wood
A property's data can be populated with a file's contents as follows: node { prop = /incbin/("path/to/data"); }; A subset of a file can be included by passing start and size parameters. For example, to include bytes 8 through 23: node { prop = /incbin/("path/to/data", 8, 16); };