Re: [alsa-devel] [PATCH] ASoC: fsl_dma: Pass the proper device for dma mapping routines

2009-04-06 Thread Mark Brown
On Mon, Apr 06, 2009 at 04:06:22PM -0500, Timur Tabi wrote: > Acked-by: Timur Tabi > Mark and Takashi: this patch is a must-fix for 2.6.30 Applied, thanks. ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxp

Re: [PATCH] ASoC: fsl_dma: Pass the proper device for dma mapping routines

2009-04-06 Thread Timur Tabi
Anton Vorontsov wrote: > The driver should pass a device that specifies internal DMA ops, but > substream->pcm is just a logical device, and thus doesn't have arch- > specific dma callbacks, therefore following bug appears: > > Freescale Synchronous Serial Interface (SSI) ASoC Driver > ---

Re: [PATCH] ASoC: fsl_dma: Pass the proper device for dma mapping routines

2009-04-05 Thread Timur Tabi
On Sun, Apr 5, 2009 at 9:59 AM, Kumar Gala wrote: > No, I think we should just fix drivers.  There aren't that many SoC drivers > and once they are fixed this will resolve itself. I agree. The only reason I passed NULL when I wrote the drivers was because I was too lazy to figure out what the r

Re: [PATCH] ASoC: fsl_dma: Pass the proper device for dma mapping routines

2009-04-05 Thread Kumar Gala
On Apr 5, 2009, at 9:39 AM, Grant Likely wrote: On Sun, Apr 5, 2009 at 2:52 AM, Anton Vorontsov wrote: On Sat, Apr 04, 2009 at 11:59:39PM -0600, Grant Likely wrote: Becky & Kumar, Considering these fixups, would it be advisable for the dma functions to climb up the dev->parent linkage wh

Re: [PATCH] ASoC: fsl_dma: Pass the proper device for dma mapping routines

2009-04-05 Thread Grant Likely
On Sun, Apr 5, 2009 at 2:52 AM, Anton Vorontsov wrote: > On Sat, Apr 04, 2009 at 11:59:39PM -0600, Grant Likely wrote: >> Becky & Kumar, >> >> Considering these fixups, would it be advisable for the dma functions >> to climb up the dev->parent linkage when dma_ops are NULL? > > pcm->dev->parent do

Re: [PATCH] ASoC: fsl_dma: Pass the proper device for dma mapping routines

2009-04-05 Thread Anton Vorontsov
On Sat, Apr 04, 2009 at 11:59:39PM -0600, Grant Likely wrote: > Becky & Kumar, > > Considering these fixups, would it be advisable for the dma functions > to climb up the dev->parent linkage when dma_ops are NULL? pcm->dev->parent doesn't point to the proper device, so this won't work. > On Sat,

Re: [PATCH] ASoC: fsl_dma: Pass the proper device for dma mapping routines

2009-04-04 Thread Grant Likely
Becky & Kumar, Considering these fixups, would it be advisable for the dma functions to climb up the dev->parent linkage when dma_ops are NULL? g. On Sat, Apr 4, 2009 at 12:33 PM, Anton Vorontsov wrote: > The driver should pass a device that specifies internal DMA ops, but > substream->pcm is j

[PATCH] ASoC: fsl_dma: Pass the proper device for dma mapping routines

2009-04-04 Thread Anton Vorontsov
The driver should pass a device that specifies internal DMA ops, but substream->pcm is just a logical device, and thus doesn't have arch- specific dma callbacks, therefore following bug appears: Freescale Synchronous Serial Interface (SSI) ASoC Driver [ cut here ] ker