Re: tqm5200s phy link toggles between up and down

2012-12-18 Thread Wolfgang Grandegger
On 12/18/2012 10:44 AM, Johannes Braun wrote: > Hello, > > I hope someone could help me with my problem. Currently I am porting > a new kernel (3.3.8) for a tqm5200s based board. This is not really a new kernel. > The previous kernel was 2.6.23. The new kernel version is needed because > of supp

Re: tqm5200s phy link toggles between up and down

2012-12-18 Thread Wolfgang Grandegger
On 12/18/2012 10:57 AM, Wolfgang Grandegger wrote: > On 12/18/2012 10:44 AM, Johannes Braun wrote: >> Hello, >> >> I hope someone could help me with my problem. Currently I am porting >> a new kernel (3.3.8) for a tqm5200s based board. > > This is not really

Re: [PATCH net-next v6 4/4] powerpc: tqm8548/tqm8xx: add and update CAN device nodes

2011-12-07 Thread Wolfgang Grandegger
On 12/07/2011 08:34 AM, Benjamin Herrenschmidt wrote: > On Thu, 2011-12-01 at 10:41 +0100, Wolfgang Grandegger wrote: >> This patch enables or updates support for the CC770 and AN82527 >> CAN controller on the TQM8548 and TQM8xx boards. > > I'm a bit confused by the n

[PATCH net-next v6 3/4] can: cc770: add platform bus driver for the CC770 and AN82527

2011-12-01 Thread Wolfgang Grandegger
This driver works with both, static platform data and device tree bindings. It has been tested on a TQM855L board with two AN82527 CAN controllers on the local bus. CC: devicetree-disc...@lists.ozlabs.org CC: linuxppc-...@ozlabs.org CC: Kumar Gala Signed-off-by: Wolfgang Grandegger Acked-by

[PATCH net-next v6 4/4] powerpc: tqm8548/tqm8xx: add and update CAN device nodes

2011-12-01 Thread Wolfgang Grandegger
This patch enables or updates support for the CC770 and AN82527 CAN controller on the TQM8548 and TQM8xx boards. CC: devicetree-disc...@lists.ozlabs.org CC: linuxppc-...@ozlabs.org CC: Kumar Gala Signed-off-by: Wolfgang Grandegger --- arch/powerpc/boot/dts/tqm8548-bigflash.dts | 19

[PATCH net-next v5 3/4] can: cc770: add platform bus driver for the CC770 and AN82527

2011-11-30 Thread Wolfgang Grandegger
This driver works with both, static platform data and device tree bindings. It has been tested on a TQM855L board with two AN82527 CAN controllers on the local bus. CC: devicetree-disc...@lists.ozlabs.org CC: linuxppc-...@ozlabs.org CC: Kumar Gala Signed-off-by: Wolfgang Grandegger Acked-by

[PATCH net-next v5 4/4] powerpc: tqm8548/tqm8xx: add and update CAN device nodes

2011-11-30 Thread Wolfgang Grandegger
This patch enables or updates support for the CC770 and AN82527 CAN controller on the TQM8548 and TQM8xx boards. CC: devicetree-disc...@lists.ozlabs.org CC: linuxppc-...@ozlabs.org CC: Kumar Gala Signed-off-by: Wolfgang Grandegger --- arch/powerpc/boot/dts/tqm8548-bigflash.dts | 19

[PATCH net-next v5 3/4] can: cc770: add platform bus driver for the CC770 and AN82527

2011-11-30 Thread Wolfgang Grandegger
This driver works with both, static platform data and device tree bindings. It has been tested on a TQM855L board with two AN82527 CAN controllers on the local bus. CC: devicetree-disc...@lists.ozlabs.org CC: linuxppc-...@ozlabs.org CC: Kumar Gala Signed-off-by: Wolfgang Grandegger Acked-by

[PATCH net-next v5 4/4] powerpc: tqm8548/tqm8xx: add and update CAN device nodes

2011-11-30 Thread Wolfgang Grandegger
This patch enables or updates support for the CC770 and AN82527 CAN controller on the TQM8548 and TQM8xx boards. CC: devicetree-disc...@lists.ozlabs.org CC: linuxppc-...@ozlabs.org CC: Kumar Gala Signed-off-by: Wolfgang Grandegger --- arch/powerpc/boot/dts/tqm8548-bigflash.dts | 19

[PATCH net-next v4 3/4] can: cc770: add platform bus driver for the CC770 and AN82527

2011-11-29 Thread Wolfgang Grandegger
This driver works with both, static platform data and device tree bindings. It has been tested on a TQM855L board with two AN82527 CAN controllers on the local bus. CC: devicetree-disc...@lists.ozlabs.org CC: linuxppc-...@ozlabs.org CC: Kumar Gala Signed-off-by: Wolfgang Grandegger Acked-by

[PATCH net-next v4 4/4] powerpc: tqm8548/tqm8xx: add and update CAN device nodes

2011-11-29 Thread Wolfgang Grandegger
This patch enables or updates support for the CC770 and AN82527 CAN controller on the TQM8548 and TQM8xx boards. CC: devicetree-disc...@lists.ozlabs.org CC: linuxppc-...@ozlabs.org CC: Kumar Gala Signed-off-by: Wolfgang Grandegger --- arch/powerpc/boot/dts/tqm8548-bigflash.dts | 19

[PATCH net-next v3 3/4] can: cc770: add platform bus driver for the CC770 and AN82527

2011-11-28 Thread Wolfgang Grandegger
This driver works with both, static platform data and device tree bindings. It has been tested on a TQM855L board with two AN82527 CAN controllers on the local bus. CC: devicetree-disc...@lists.ozlabs.org CC: linuxppc-...@ozlabs.org CC: Kumar Gala Signed-off-by: Wolfgang Grandegger

[PATCH net-next v3 4/4] powerpc: tqm8548/tqm8xx: add and update CAN device nodes

2011-11-28 Thread Wolfgang Grandegger
This patch enables or updates support for the CC770 and AN82527 CAN controller on the TQM8548 and TQM8xx boards. CC: devicetree-disc...@lists.ozlabs.org CC: linuxppc-...@ozlabs.org CC: Kumar Gala Signed-off-by: Wolfgang Grandegger --- arch/powerpc/boot/dts/tqm8548-bigflash.dts | 19

[PATCH net-next v2 4/4] powerpc: tqm8548/tqm8xx: add and update CAN device nodes

2011-11-25 Thread Wolfgang Grandegger
This patch enables or updates support for the CC770 and AN82527 CAN controller on the TQM8548 and TQM8xx boards. CC: devicetree-disc...@lists.ozlabs.org CC: linuxppc-...@ozlabs.org CC: Kumar Gala Signed-off-by: Wolfgang Grandegger --- arch/powerpc/boot/dts/tqm8548-bigflash.dts | 19

[PATCH net-next v2 3/4] can: cc770: add platform bus driver for the CC770 and AN82527

2011-11-25 Thread Wolfgang Grandegger
This driver works with both, static platform data and device tree bindings. It has been tested on a TQM855L board with two AN82527 CAN controllers on the local bus. CC: devicetree-disc...@lists.ozlabs.org CC: linuxppc-...@ozlabs.org CC: Kumar Gala Signed-off-by: Wolfgang Grandegger

[PATCH net-next] ibm/emac: fix improper cleanup when device is removed to allow re-bind

2011-11-17 Thread Wolfgang Grandegger
The re-binding (unbind..bind) of an EMAC device fails because the static variable "busy_phy_map" is not updated when the device is removed. Signed-off-by: Wolfgang Grandegger --- drivers/net/ethernet/ibm/emac/core.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) di

Re: [PATCH v13 0/6] flexcan: Add support for powerpc flexcan (freescale p1010)

2011-10-18 Thread Wolfgang Grandegger
Hi Kumar, On 10/18/2011 07:44 AM, Kumar Gala wrote: > > On Aug 16, 2011, at 10:32 PM, Robin Holt wrote: > >> David, >> >> The following set of patches have been reviewed by the above parties and >> all comments have been integrated. Although the patches stray from the >> drivers/net/can directo

Re: [PATCH v12 5/6] flexcan: Prefer device tree clock frequency if available.

2011-08-12 Thread Wolfgang Grandegger
he flexcan device. > > Signed-off-by: Robin Holt > To: Kumar Gala > To: Wolfgang Grandegger , > To: Marc Kleine-Budde , > To: U Bhaskar-B22300 > To: Scott Wood > To: Grant Likely > Cc: socketcan-c...@lists.berlios.de, > Cc: net...@vger.kernel.org, > Cc: PPC list &

Re: [PATCH v11 5/6] flexcan: Prefer device tree clock frequency if available.

2011-08-11 Thread Wolfgang Grandegger
he flexcan device. > > Signed-off-by: Robin Holt > To: Kumar Gala > To: Wolfgang Grandegger , > To: Marc Kleine-Budde , > To: U Bhaskar-B22300 > To: Scott Wood > To: Grant Likely > Cc: socketcan-c...@lists.berlios.de, > Cc: net...@vger.kernel.org, > Cc: P

Re: [PATCH v11 6/6] powerpc: Add flexcan device support for p1010rdb.

2011-08-11 Thread Wolfgang Grandegger
On 08/11/2011 06:07 PM, Robin Holt wrote: > Allow the p1010 processor to select the flexcan network driver. > > Signed-off-by: Robin Holt > Acked-by: Marc Kleine-Budde , > Acked-by: Wolfgang Grandegger , > Cc: U Bhaskar-B22300 > Cc: socketcan-c...@lists.berlios.de, > Cc

Re: [PATCH v11 4/5] powerpc: Add flexcan device support for p1010rdb.

2011-08-11 Thread Wolfgang Grandegger
On 08/11/2011 05:56 AM, Robin Holt wrote: > On Wed, Aug 10, 2011 at 08:16:33PM +0200, Wolfgang Grandegger wrote: >> On 08/10/2011 07:01 PM, Kumar Gala wrote: >>> >>> On Aug 10, 2011, at 11:27 AM, Robin Holt wrote: >>> >>>> I added a simple clo

Re: [PATCH v11 4/5] powerpc: Add flexcan device support for p1010rdb.

2011-08-11 Thread Wolfgang Grandegger
On 08/11/2011 06:46 AM, Kumar Gala wrote: > > On Aug 10, 2011, at 1:16 PM, Wolfgang Grandegger wrote: > >> On 08/10/2011 07:01 PM, Kumar Gala wrote: >>> >>> On Aug 10, 2011, at 11:27 AM, Robin Holt wrote: >>> >>>> I added a simple clock so

Re: [PATCH v10 5/5] [powerpc] Fix up fsl-flexcan device tree binding.

2011-08-10 Thread Wolfgang Grandegger
On 08/10/2011 06:00 PM, Robin Holt wrote: > On Wed, Aug 10, 2011 at 02:36:20PM +, U Bhaskar-B22300 wrote: ... > It looks like the way to do that is to assign a label to those devices > and then associate the label with an alias. I have no idea how that > works under the hood, but it is the way

Re: [PATCH v11 4/5] powerpc: Add flexcan device support for p1010rdb.

2011-08-10 Thread Wolfgang Grandegger
bus frequency divided by 2. >> >> Signed-off-by: Robin Holt >> Acked-by: Marc Kleine-Budde , >> Acked-by: Wolfgang Grandegger , >> Cc: U Bhaskar-B22300 >> Cc: socketcan-c...@lists.berlios.de, >> Cc: net...@vger.kernel.org, >> Cc: PPC list >>

Re: [PATCH v10 5/5] [powerpc] Fix up fsl-flexcan device tree binding.

2011-08-10 Thread Wolfgang Grandegger
On 08/10/2011 04:15 PM, Robin Holt wrote: > On Wed, Aug 10, 2011 at 03:47:43PM +0200, Wolfgang Grandegger wrote: ... > Done, except the >> compatible = "fsl,p1010-flexcan", "fsl,flexcan"; > > line is > compatible = "fsl,flexcan",

Re: [PATCH v10 5/5] [powerpc] Fix up fsl-flexcan device tree binding.

2011-08-10 Thread Wolfgang Grandegger
k is fixed..." and so on. > than the required properties so we are removing the file. Additionally, > the p1010*dts* files are not following the standard for node naming in > that they have a trailing -v1.0. > Signed-off-by: Robin Holt > To: Marc Kleine-Budde , > To: Wo

Re: [PATCH 5/5] [powerpc] Fix up fsl-flexcan device tree binding.

2011-08-09 Thread Wolfgang Grandegger
ra_ps2.txt, > Documentation/devicetree/bindings/arm/sirf.txt, > Documentation/devicetree/bindings/powerpc/nintendo/wii.txt, etc. > >> I assume we are talking about the fsl-flexcan.txt file when we say >> binding. Is that correct? > > Yes, although devicetree.or

Re: [PATCH 5/5] [powerpc] Fix up fsl-flexcan device tree binding.

2011-08-09 Thread Wolfgang Grandegger
On 08/09/2011 08:17 PM, Scott Wood wrote: > On 08/09/2011 09:43 AM, Robin Holt wrote: >> In working with the socketcan developers, we have come to the conclusion >> the fsl-flexcan device tree bindings need to be cleaned up. >> The driver does not depend upon any properties other than the required

Re: [PATCH 4/4] [powerpc] Add flexcan device support for p1010rdb.

2011-08-09 Thread Wolfgang Grandegger
On 08/09/2011 04:55 PM, Robin Holt wrote: > On Tue, Aug 09, 2011 at 02:45:58PM +, U Bhaskar-B22300 wrote: >> Hi Robin, >> Where are you doing the irq handling ie request_irq() for the powerpc >> based P1010. >> Or the existing code of ARM based FlexCAN will work for P1010 ?? > > It

Re: [PATCH 4/4] [powerpc] Add flexcan device support for p1010rdb.

2011-08-09 Thread Wolfgang Grandegger
t; To: Marc Kleine-Budde , > To: Wolfgang Grandegger , > To: U Bhaskar-B22300 > Cc: socketcan-c...@lists.berlios.de, > Cc: net...@vger.kernel.org, > Cc: PPC list > --- > arch/powerpc/platforms/85xx/Kconfig|2 + > arch/powerpc/platforms/85xx/Makefile |2 + >

Re: [RFC 4/4] [powerpc] Add flexcan device support for p1010rdb.

2011-08-09 Thread Wolfgang Grandegger
[PATCH nfsl_get_sys_freq() et-next-2.6 v2] would be perfect. > I added a clock source for the p1010rdb so the flexcan driver > could find its clock frequency. > > Signed-off-by: Robin Holt > To: Marc Kleine-Budde , > To: Wolfgang Grandegger , > To: U Bhaskar-B22300 > Cc: socketc

Re: [RFC 4/4] [powerpc] Implement a p1010rdb clock source.

2011-08-08 Thread Wolfgang Grandegger
06:05 AM, Robin Holt wrote: >>>>> flexcan driver needs the clk_get, clk_get_rate, etc functions >>>>> to work. This patch provides the minimum functionality. >>>> >>>> This patch has to go via the powerpc git tree. Added >>>> li

Re: GPIO IRQ on P1022

2011-07-31 Thread Wolfgang Grandegger
Hi Felix, On 07/31/2011 05:51 PM, Felix Radensky wrote: > Hi Wolfgang, > > On 07/31/2011 06:19 PM, Wolfgang Grandegger wrote: >> On 07/31/2011 12:38 PM, Felix Radensky wrote: >>> Hi, >>> >>> I'm running kernel 3.0 on a custom board based on Free

Re: GPIO IRQ on P1022

2011-07-31 Thread Wolfgang Grandegger
On 07/31/2011 12:38 PM, Felix Radensky wrote: > Hi, > > I'm running kernel 3.0 on a custom board based on Freescale P1022. > The interrupt line of on-board FPGA is connected to GPIO2_9. FPGA > IRQ is level, active low. The GPIOs are mapped like this: > > GPIOs 160-191, /soc@ffe0/gpio-controll

Re: [PATCH][upstream] powerpc: Adding bindings for flexcan controller

2011-06-26 Thread Wolfgang Grandegger
On 04/19/2011 03:58 PM, Bhaskar Upadhaya wrote: > From: Bhaskar Upadhaya > > Signed-off-by: Bhaskar Upadhaya > Acked-By: Scott Wood > --- > Based upon > git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git (branch > -> master) > > .../devicetree/bindings/net/can/fsl-flexcan.

High process latencies due to MPC5200 FEC hard- soft-irq processing

2010-07-13 Thread Wolfgang Grandegger
Hello, we realized, that multiple ping floods (ping -f) can cause very large high-priority process latencies (up to a many seconds) on a MPC5200 PowerPC system with FEC NAPI support. The latencies are measured with # cyclictest -p 80 -n The problem is that processing of the ICMP pakets in the

Re: CAN Subsystem and MPC52xx onboard controller

2010-06-10 Thread Wolfgang Grandegger
On 06/10/2010 11:29 AM, Roman Fietze wrote: > Hello Wolfram, > > On Thursday 10 June 2010 10:59:23 Wolfram Sang wrote: > >> The mainline kernel works fine here with Phytec based MPC5xxx-boards. > > Reading your answer made me hope again, and I just pulled the newest > HEAD from the mainline kern

Re: CAN Subsystem and MPC52xx onboard controller

2010-06-10 Thread Wolfgang Grandegger
On 06/10/2010 10:41 AM, Roman Fietze wrote: > Hello List Members, > > I have tried multiple versions/branches and git repos (torvalds, > benh/{next,master}, denx, pengutronix, ...) to get a 2.6.34 or HEAD > version of that repos that compiles w/o errors when the CAN subsystem > is enabled and the

Re: [PATCH v3 3/3] ptp: Added a clock that uses the eTSEC found on the MPC85xx.

2010-05-17 Thread Wolfgang Grandegger
On 05/14/2010 06:46 PM, Richard Cochran wrote: > The eTSEC includes a PTP clock with quite a few features. This patch adds > support for the basic clock adjustment functions, plus two external time > stamps and one alarm. > > Signed-off-by: Richard Cochran Tested-by: Wolfgang Gra

Re: [PATCH v3 1/3] ptp: Added a brand new class driver for ptp clocks.

2010-05-17 Thread Wolfgang Grandegger
r space as a character device with ioctls that allow tuning > of the PTP clock. > > Signed-off-by: Richard Cochran Tested-by: Wolfgang Grandegger on my Freescale MPC8313 setup with ptpd and ptpv2d. Wolfgang. ___ Linuxppc-dev mailing list Linuxppc

Re: MPC5200B, many FEC_IEVENT_RFIFO_ERRORs until link down

2010-04-05 Thread Wolfgang Grandegger
Hallo Roman, Roman Fietze wrote: > Hallo Wolfgang, > > On Wednesday 31 March 2010 12:15:47 Wolfgang Grandegger wrote: > >> I just sent out the patch. > > Thanks a lot. > >> Would be nice if you, or somebody else, could do some testing and >> provide s

Re: MPC5200B, many FEC_IEVENT_RFIFO_ERRORs until link down

2010-03-31 Thread Wolfgang Grandegger
Hi Roman, Wolfgang Grandegger wrote: > Roman Fietze wrote: >> Hello, >> >> I think this is a never ending story. This error still happens under >> higher load every few seconds, until I get a "PHY: f0003000:00 - Link >> is Down", on my box easiliy repr

[RFC-PATCH] fec_mpc52xx: add NAPI support

2010-03-31 Thread Wolfgang Grandegger
e the packets can not be digested (processed) by the system at that rate anyhow. NAPI can be enabled via Kconfig parameter CONFIG_FEC_MPC52xx_NAPI. Throughput measurements with netperf showed almost the same results with and without NAPI. Signed-off-by: Wolfgang Grandegger --- drivers/net/Kc

Re: MPC5200B, many FEC_IEVENT_RFIFO_ERRORs until link down

2010-03-30 Thread Wolfgang Grandegger
Roman Fietze wrote: > Hello, > > I think this is a never ending story. This error still happens under > higher load every few seconds, until I get a "PHY: f0003000:00 - Link > is Down", on my box easiliy reproducable after maybe 15 to 30 seconds. > I can recover using "ip link set down/up dev eth0

Re: Linux patches for XIP on MPC8xx?

2010-03-23 Thread Wolfgang Grandegger
Németh Márton wrote: > Hi Wolfgang, > > I found your homepage at > http://www.denx.de/wiki/bin/view/DULG/ConfigureLinuxForXIP back > from 2003. Was there any follow up of your patch for kernel 2.4.4? Not that I remember. Wolfgang. ___ Linuxppc-dev mai

[PATCH v8 3/4] i2c-mpc: add support for the MPC512x processors from Freescale

2010-02-17 Thread Wolfgang Grandegger
From: Wolfgang Grandegger As I2C interrupts must be enabled for the MPC512x by the setup function as well, "fsl,preserve-clocking" is handled in a slighly different way. Also, the old settings are now reported calling dev_dbg(). For the MPC512x the clock setup function of the MPC52xx

[PATCH v8 4/4] powerpc: doc/dts-bindings: update doc of FSL I2C bindings

2010-02-17 Thread Wolfgang Grandegger
From: Wolfgang Grandegger This patch adds the MPC5121 to the list of supported devices, enhances the doc of the "clock-frequency" property and removes the obsolete "cell-index", "device_type" and "fsl-i2c" property. Furthermore an example for the MPC5121

[PATCH v8 2/4] i2c-mpc: rename "setclock" initialization functions to "setup"

2010-02-17 Thread Wolfgang Grandegger
From: Wolfgang Grandegger To prepare support for the MPC512x processors from Freescale the "setclock" initialization functions have been renamed to "setup" because I2C interrupts must be enabled for the MPC512x by this function as well. Signed-off-by: Wolfgang Grandegge

[PATCH v8 1/4] i2c-mpc: use __devinit[data] for initialization functions and data

2010-02-17 Thread Wolfgang Grandegger
From: Wolfgang Grandegger "__devinit[data]" has not yet been used for all initialization functions and data. To avoid truncating lines, the struct "mpc_i2c_match_data" has been renamed to "mpc_i2c_data", which is even the better name. Signed-off-by: Wolfgang Grand

[PATCH v8 0/4] i2c-mpc: add support for the Freescale MPC512x and other fixes

2010-02-17 Thread Wolfgang Grandegger
__devinitconst for const data as suggested by Stephen Rothwell. Changes since v7: - fix non-bisectable patch 1 as pointed out by Grant Likely. Wolfgang Wolfgang Grandegger (4): i2c-mpc: use __devinit[data] for initialization functions and data i2c-mpc: rename "setclock" initializa

Re: [PATCH v7 1/4] i2c-mpc: use __devinit[data] for initialization functions and data

2010-02-16 Thread Wolfgang Grandegger
Grant Likely wrote: > On Wed, Feb 10, 2010 at 7:55 AM, Wolfgang Grandegger > wrote: >> From: Wolfgang Grandegger >> >> "__devinit[data]" has not yet been used for all initialization functions >> and data. To avoid truncating lines, the struct &qu

[PATCH v7 4/4] powerpc: doc/dts-bindings: update doc of FSL I2C bindings

2010-02-10 Thread Wolfgang Grandegger
From: Wolfgang Grandegger This patch adds the MPC5121 to the list of supported devices, enhances the doc of the "clock-frequency" property and removes the obsolete "cell-index", "device_type" and "fsl-i2c" property. Furthermore an example for the MPC5121

[PATCH v7 1/4] i2c-mpc: use __devinit[data] for initialization functions and data

2010-02-10 Thread Wolfgang Grandegger
From: Wolfgang Grandegger "__devinit[data]" has not yet been used for all initialization functions and data. To avoid truncating lines, the struct "mpc_i2c_match_data" has been renamed to "mpc_i2c_data", which is even the better name. Signed-off-by: Wolfgang Grand

[PATCH v7 3/4] i2c-mpc: add support for the MPC512x processors from Freescale

2010-02-10 Thread Wolfgang Grandegger
From: Wolfgang Grandegger As I2C interrupts must be enabled for the MPC512x by the setup function as well, "fsl,preserve-clocking" is handled in a slighly different way. Also, the old settings are now reported calling dev_dbg(). For the MPC512x the clock setup function of the MPC52xx

[PATCH v7 0/4] i2c-mpc: add support for the Freescale MPC512x and other fixes

2010-02-10 Thread Wolfgang Grandegger
From: Wolfgang Grandegger This patch series adds support for the MPC512x from Freescale to the i2c-mpc driver. At that occasion, issues with __devinit[data] have been fixed and the doc of the FSL I2C dts bindings updated. It has been tested on a MPC5121ADS, TQM5200 and TQM8560 board Changes

[PATCH v7 2/4] i2c-mpc: rename "setclock" initialization functions to "setup"

2010-02-10 Thread Wolfgang Grandegger
From: Wolfgang Grandegger To prepare support for the MPC512x processors from Freescale the "setclock" initialization functions have been renamed to "setup" because I2C interrupts must be enabled for the MPC512x by this function as well. Signed-off-by: Wolfgang Grandegg

Re: [PATCH v4 1/3] i2c-mpc: use __devinit[data] for initialization functions and data

2010-02-10 Thread Wolfgang Grandegger
Grant Likely wrote: > On Wed, Feb 10, 2010 at 3:53 AM, Wolfgang Grandegger > wrote: >> Stephen Rothwell wrote: >>> Hi Wolfgang, >>> >>> On Wed, 10 Feb 2010 11:09:25 +0100 Wolfgang Grandegger >>> wrote: >>>>> __devinitdata goes at t

Re: [PATCH v4 1/3] i2c-mpc: use __devinit[data] for initialization functions and data

2010-02-10 Thread Wolfgang Grandegger
Stephen Rothwell wrote: > Hi Wolfgang, > > On Wed, 10 Feb 2010 11:09:25 +0100 Wolfgang Grandegger > wrote: >>> __devinitdata goes at the end, immediately before the '='. Ditto >>> throughout the file. >> This made a difference and revea

Re: [net-next-2.6 PATCH 2/3] fs_enet: Add support for MPC512x to fs_enet driver

2010-02-10 Thread Wolfgang Grandegger
Wolfgang Grandegger wrote: > Hi David, > > David Miller wrote: >> From: Anatolij Gustschin >> Date: Tue, 9 Feb 2010 15:23:17 +0100 >> >>> In my understanding, in the ESP scsi driver the set of defines for >>> the register offsets is common for all

Re: [PATCH v4 1/3] i2c-mpc: use __devinit[data] for initialization functions and data

2010-02-10 Thread Wolfgang Grandegger
Grant Likely wrote: > On Thu, Jan 28, 2010 at 6:25 AM, Wolfgang Grandegger > wrote: >> From: Wolfgang Grandegger >> >> "__devinit[data]" has not yet been used for all initialization functions >> and data. To avoid truncating lines, the struct &qu

[PATCH v6 0/4] i2c-mpc: add support for the Freescale MPC512x and other fixes

2010-02-10 Thread Wolfgang Grandegger
From: Wolfgang Grandegger This patch series adds support for the MPC512x from Freescale to the i2c-mpc driver. At that occasion, issues with __devinit[data] have been fixed and the doc of the FSL I2C dts bindings updated. It has been tested on a MPC5121ADS, TQM5200 and TQM8560 board Changes

[PATCH v6 3/4] i2c-mpc: add support for the MPC512x processors from Freescale

2010-02-10 Thread Wolfgang Grandegger
From: Wolfgang Grandegger As I2C interrupts must be enabled for the MPC512x by the setup function as well, "fsl,preserve-clocking" is handled in a slighly different way. Also, the old settings are now reported calling dev_dbg(). For the MPC512x the clock setup function of the MPC52xx

[PATCH v6 1/4] i2c-mpc: use __devinit[data] for initialization functions and data

2010-02-10 Thread Wolfgang Grandegger
From: Wolfgang Grandegger "__devinit[data]" has not yet been used for all initialization functions and data. To avoid truncating lines, the struct "mpc_i2c_match_data" has been renamed to "mpc_i2c_data", which is even the better name. Signed-off-by: Wolfgang Grand

[PATCH v6 2/4] i2c-mpc: rename "setclock" initialization functions to "setup"

2010-02-10 Thread Wolfgang Grandegger
From: Wolfgang Grandegger To prepare support for the MPC512x processors from Freescale the "setclock" initialization functions have been renamed to "setup" because I2C interrupts must be enabled for the MPC512x by this function as well. Signed-off-by: Wolfgang Grandegg

[PATCH v6 4/4] powerpc: doc/dts-bindings: update doc of FSL I2C bindings

2010-02-10 Thread Wolfgang Grandegger
From: Wolfgang Grandegger This patch adds the MPC5121 to the list of supported devices, enhances the doc of the "clock-frequency" property and removes the obsolete "cell-index", "device_type" and "fsl-i2c" property. Furthermore an example for the MPC5121

Re: [net-next-2.6 PATCH 2/3] fs_enet: Add support for MPC512x to fs_enet driver

2010-02-10 Thread Wolfgang Grandegger
Hi David, David Miller wrote: > From: Anatolij Gustschin > Date: Tue, 9 Feb 2010 15:23:17 +0100 > >> In my understanding, in the ESP scsi driver the set of defines for >> the register offsets is common for all chip drivers. The chip driver >> methods for register access translate the offsets bec

Re: [PATCH v4 3/3] powerpc: doc/dts-bindings: update doc of FSL I2C bindings

2010-02-09 Thread Wolfgang Grandegger
Wolfgang Grandegger wrote: > Hi Grant, > > Grant Likely wrote: >> On Thu, Jan 28, 2010 at 6:25 AM, Wolfgang Grandegger >> wrote: >>> From: Wolfgang Grandegger >>> >>> This patch adds the MPC5121 to the list of supported devices, >>&g

Re: [PATCH v4 3/3] powerpc: doc/dts-bindings: update doc of FSL I2C bindings

2010-02-09 Thread Wolfgang Grandegger
Hi Grant, Grant Likely wrote: > On Thu, Jan 28, 2010 at 6:25 AM, Wolfgang Grandegger > wrote: >> From: Wolfgang Grandegger >> >> This patch adds the MPC5121 to the list of supported devices, >> enhances the doc of the "clock-frequency" property and remov

[PATCH v5 3/3] powerpc: doc/dts-bindings: update doc of FSL I2C bindings

2010-01-31 Thread Wolfgang Grandegger
From: Wolfgang Grandegger This patch adds the MPC5121 to the list of supported devices, enhances the doc of the "clock-frequency" property and removes the obsolete "cell-index" property from the example nodes. Furthermore and example for the MPC5121 has been added. Sig

[PATCH v5 0/3] i2c-mpc: add support for the Freescale MPC512x and other fixes

2010-01-31 Thread Wolfgang Grandegger
s since v3: - switch back to __devinit[data] as pointed out by Ben. Changes since v4: - check MPC_I2C_CLOCK_SAFE instead of "!clock" as suggested by Wolfram. - update MODULE_DESCRIPTION(). Wolfgang Wolfgang Grandegger (3): i2c-mpc: use __devinit[data] for initialization functions and

[PATCH v5 2/3] i2c-mpc: add support for the MPC512x processors from Freescale

2010-01-31 Thread Wolfgang Grandegger
From: Wolfgang Grandegger The "setclock" initialization functions have been renamed to "setup" because I2C interrupts must be enabled for the MPC512x. This requires to handle "fsl,preserve-clocking" in a slighly different way. Also, the old settings are now repor

[PATCH v5 1/3] i2c-mpc: use __devinit[data] for initialization functions and data

2010-01-31 Thread Wolfgang Grandegger
From: Wolfgang Grandegger "__devinit[data]" has not yet been used for all initialization functions and data. To avoid truncating lines, the struct "mpc_i2c_match_data" has been renamed to "mpc_i2c_data", which is even the better name. Signed-off-by: Wolfgang Grand

[PATCH v4 1/3] i2c-mpc: use __devinit[data] for initialization functions and data

2010-01-28 Thread Wolfgang Grandegger
From: Wolfgang Grandegger "__devinit[data]" has not yet been used for all initialization functions and data. To avoid truncating lines, the struct "mpc_i2c_match_data" has been renamed to "mpc_i2c_data", which is even the better name. Signed-off-by: Wolfgang Grand

[PATCH v4 2/3] i2c-mpc: add support for the MPC512x processors from Freescale

2010-01-28 Thread Wolfgang Grandegger
From: Wolfgang Grandegger The "setclock" initialization functions have been renamed to "setup" because I2C interrupts must be enabled for the MPC512x. This requires to handle "fsl,preserve-clocking" in a slighly different way. Also, the old settings are now repor

[PATCH v4 0/3] i2c-mpc: add support for the Freescale MPC512x and other fixes

2010-01-28 Thread Wolfgang Grandegger
s since v3: - switch back to __devinit[data] as pointed out by Ben. Wolfgang Wolfgang Grandegger (3): i2c-mpc: use __devinit[data] for initialization functions and data i2c-mpc: add support for the MPC512x processors from Freescale powerpc: doc/dts-bindings: update doc of FSL I2

[PATCH v4 3/3] powerpc: doc/dts-bindings: update doc of FSL I2C bindings

2010-01-28 Thread Wolfgang Grandegger
From: Wolfgang Grandegger This patch adds the MPC5121 to the list of supported devices, enhances the doc of the "clock-frequency" property and removes the obsolete "cell-index" property from the example nodes. Furthermore and example for the MPC5121 has been added. Sig

Re: [PATCH v2 1/3] i2c-mpc: use __devinit[data] for initialization functions and data

2010-01-27 Thread Wolfgang Grandegger
Ben Dooks wrote: > On Tue, Jan 26, 2010 at 07:44:10PM +0100, Wolfgang Grandegger wrote: >> Ben Dooks wrote: >>> On Mon, Jan 25, 2010 at 09:55:04PM +0100, Wolfgang Grandegger wrote: [snip] >>> Any particular reason you decided to move this all about? >> This was n

Re: [net-next-2.6 PATCH 2/3] fs_enet: Add support for MPC512x to fs_enet driver

2010-01-27 Thread Wolfgang Grandegger
Arnd Bergmann wrote: > On Sunday 24 January 2010, Wolfgang Denk wrote: >> In message <4b5c5bdf.6020...@grandegger.com> you wrote: >>> You are probably right and your proposal would likely result in more >>> transparent (less ugly) code. There has been some discussion about >>> unifying FEC drivers

[PATCH v3 1/3] i2c-mpc: use __init[data] for initialization functions and data

2010-01-26 Thread Wolfgang Grandegger
From: Wolfgang Grandegger "__devinit[data]" has been renamed to "__init[data]" as this is not a hotplugable device. Futhermore, all initialization functions and data are now marked properly. To avoid truncating lines, the struct "mpc_i2c_match_data" has been renam

[PATCH v3 2/3] i2c-mpc: add support for the MPC512x processors from Freescale

2010-01-26 Thread Wolfgang Grandegger
From: Wolfgang Grandegger The "setclock" initialization functions have been renamed to "setup" because I2C interrupts must be enabled for the MPC512x. This requires to handle "fsl,preserve-clocking" in a slighly different way. Also, the old settings are now repor

[PATCH v3 3/3] powerpc: doc/dts-bindings: update doc of FSL I2C bindings

2010-01-26 Thread Wolfgang Grandegger
From: Wolfgang Grandegger This patch adds the MPC5121 to the list of supported devices, enhances the doc of the "clock-frequency" property and removes the obsolete "cell-index" property from the example nodes. Furthermore and example for the MPC5121 has been added. Sig

[PATCH v3 0/3] i2c-mpc: add support for the Freescale MPC512x and other fixes

2010-01-26 Thread Wolfgang Grandegger
From: Wolfgang Grandegger This patch series adds support for the MPC512x from Freescale to the i2c-mpc driver. At that occasion, issues with __devinit[data] have been fixed and the doc of the FSL I2C dts bindings updated. It has been tested on a MPC5121ADS, TQM5200 and TQM8560 board Changes

Re: [PATCH 2/3] i2c-mpc: add support for the MPC512x processors from Freescale

2010-01-26 Thread Wolfgang Grandegger
Ben Dooks wrote: > On Mon, Jan 25, 2010 at 04:15:09PM +0100, Wolfram Sang wrote: > > -static void __devinit mpc_i2c_setclock_52xx(struct device_node *node, > - struct mpc_i2c *i2c, > - u32 clock, u32 prescaler

Re: [PATCH v2 1/3] i2c-mpc: use __devinit[data] for initialization functions and data

2010-01-26 Thread Wolfgang Grandegger
Ben Dooks wrote: > On Mon, Jan 25, 2010 at 09:55:04PM +0100, Wolfgang Grandegger wrote: >> From: Wolfgang Grandegger >> >> "__devinit[data]" has not yet been used for all initialization functions >> and data. To avoid truncating lines, the struct mpc_

Re: [PATCH/RFC 2/2] 5200: improve i2c bus error recovery

2010-01-25 Thread Wolfgang Grandegger
Albrecht Dreß wrote: > Am 25.01.10 08:55 schrieb(en) Wolfgang Grandegger: >> Albrecht Dreß wrote: >>> Make the I2C adapter timeout configurable through a Device Tree >>> property which gives the timeout in microseconds. >> >> My understanding is that softwa

Re: [PATCH 2/3] i2c-mpc: add support for the MPC512x processors from Freescale

2010-01-25 Thread Wolfgang Grandegger
Wolfram Sang wrote: >> overkill to me. I will have a closer look, though. At a minimum I will >> replace "-1" with "MPC_I2C_PRESERVE_CLOCK". > > Might be also an idea to define it with ~0 (clock is still unsigned). If > possible, the code checking for those two cases (0 and "-1") should be close >

[PATCH v2 2/3] i2c-mpc: add support for the MPC512x processors from Freescale

2010-01-25 Thread Wolfgang Grandegger
From: Wolfgang Grandegger The "setclock" initialization functions have been renamed to "setup" because I2C interrupts must be enabled for the MPC512x. This requires to handle "fsl,preserve-clocking" in a slighly different way. Also, the old settings are now repor

[PATCH v2 1/3] i2c-mpc: use __devinit[data] for initialization functions and data

2010-01-25 Thread Wolfgang Grandegger
From: Wolfgang Grandegger "__devinit[data]" has not yet been used for all initialization functions and data. To avoid truncating lines, the struct mpc_i2c_match_data has been renamed to mpc_i2c_data, which is even the better name. Signed-off-by: Wolfgang Grandegger --- drivers/i2c/

[PATCH v2 3/3] powerpc: doc/dts-bindings: update doc of FSL I2C bindings

2010-01-25 Thread Wolfgang Grandegger
From: Wolfgang Grandegger This patch adds the MPC5121 to the list of supported devices, enhances the doc of the "clock-frequency" property and removes the obsolete "cell-index" property from the example nodes. Furthermore and example for the MPC5121 has been added. Sig

[PATCH v2 0/3] i2c-mpc: add support for the Freescale MPC512x and other fixes

2010-01-25 Thread Wolfgang Grandegger
From: Wolfgang Grandegger This patch series adds support for the MPC512x from Freescale to the i2c-mpc driver. At that occasion, issues with __devinit[data] have been fixed and the doc of the FSL I2C dts bindings updated. It has been tested on a MPC5121ADS, TQM5200 and TQM8560 board Changes

Re: [PATCH 2/3] i2c-mpc: add support for the MPC512x processors from Freescale

2010-01-25 Thread Wolfgang Grandegger
Wolfram Sang wrote: -static void __devinit mpc_i2c_setclock_52xx(struct device_node *node, - struct mpc_i2c *i2c, - u32 clock, u32 prescaler) +static void __devinit mpc_i2c_setup_52xx(struct device_

Re: [PATCH 2/3] i2c-mpc: add support for the MPC512x processors from Freescale

2010-01-25 Thread Wolfgang Grandegger
Hi Wolfram, Wolfram Sang wrote: > Hi Wolfgang, > > On Mon, Jan 25, 2010 at 09:27:08AM +0100, Wolfgang Grandegger wrote: >> From: Wolfgang Grandegger >> >> The "setclock" initialization functions have been renamed to "setup" >> because

Re: [PATCH 3/3] powerpc: doc/dts-bindings: update doc of FSL I2C bindings

2010-01-25 Thread Wolfgang Grandegger
Wolfram Sang wrote: > On Mon, Jan 25, 2010 at 09:27:09AM +0100, Wolfgang Grandegger wrote: >> From: Wolfgang Grandegger >> >> This patch adds the MPC5121 to the list of supported devices, >> enhances the doc of the "clock-frequency" property and removes >&

[PATCH 3/3] powerpc: doc/dts-bindings: update doc of FSL I2C bindings

2010-01-25 Thread Wolfgang Grandegger
From: Wolfgang Grandegger This patch adds the MPC5121 to the list of supported devices, enhances the doc of the "clock-frequency" property and removes the obsolete "cell-index" property from the example nodes. Signed-off-by: Wolfgang Grandegger --- Documentation/powe

[PATCH 2/3] i2c-mpc: add support for the MPC512x processors from Freescale

2010-01-25 Thread Wolfgang Grandegger
From: Wolfgang Grandegger The "setclock" initialization functions have been renamed to "setup" because I2C interrupts must be enabled for the MPC512x. This requires to handle "fsl,preserve-clocking" in a slighly different way. Also, the old settings are now repor

[PATCH 1/3] i2c-mpc: use __devinit[data] for initialization functions and data

2010-01-25 Thread Wolfgang Grandegger
From: Wolfgang Grandegger "__devinit[data]" has not yet been used for all initialization functions and data. To avoid truncating lines, the struct mpc_i2c_match_data has been renamed to mpc_i2c_data, which is even the better name. Signed-off-by: Wolfgang Grandegger --- drivers/i2c/

[PATCH 0/3] i2c-mpc: add support for the Freescale MPC512x and other fixes

2010-01-25 Thread Wolfgang Grandegger
This patch series adds support for the MPC512x from Freescale to the i2c-mpc driver. At that occasion, issues with __devinit[data] have been fixed and the doc of the FSL I2C dts bindings updated. It has been tested on a MPC5121ADS, TQM5200 and TQM8560 board Wolfgang Wolfgang Grandegger (3

Re: [PATCH/RFC 2/2] 5200: improve i2c bus error recovery

2010-01-24 Thread Wolfgang Grandegger
Albrecht Dreß wrote: > Make the I2C adapter timeout configurable through a Device Tree property > which gives the timeout in microseconds. My understanding is that software properties should not be defined via the device tree. I think a sysfs entry is more appropriate. Wolfgang.

Re: [net-next-2.6 PATCH 2/3] fs_enet: Add support for MPC512x to fs_enet driver

2010-01-24 Thread Wolfgang Grandegger
Arnd Bergmann wrote: > On Thursday 21 January 2010, Wolfgang Grandegger wrote: >> The major problem that Anatolij tries to solve are the different >> register layouts of the supported SOCs, MPC52xx and MPC8xx. They use the >> same registers but at different offsets. There

Re: [PATCH 04/11] i2c-mpc: Add MPC5121 I2C bus support

2010-01-22 Thread Wolfgang Grandegger
Grant Likely wrote: > On Tue, Jan 19, 2010 at 1:24 PM, Anatolij Gustschin wrote: >> From: Piotr Ziecik >> >>- Update Kconfig for i2c-mpc driver. >>- Enable I2C interrupts on MPC5121. >> >> diff --git a/drivers/i2c/busses/i2c-mpc.c b/drivers/i2c/busses/i2c-mpc.c >> index f627001..84eeb25 1

  1   2   3   4   >