Hi
Am 22.12.24 um 07:31 schrieb Helge Deller:
On 12/16/24 08:42, Thomas Zimmermann wrote:
Do not select BACKLIGHT_CLASS_DEVICE from FB_BACKLIGHT. The latter
only controls backlight support within fbdev core code and data
structures.
Make fbdev drivers depend on BACKLIGHT_CLASS_DEVICE and let
Select FB_CORE if GEM's DMA and TTM implementations support fbdev
emulation. Fixes linker errors about missing symbols from the fbdev
subsystem.
Also see [1] for a related SHMEM fix.
Fixes: dadd28d4142f ("drm/client: Add client-lib module")
Signed-off-by: Thomas Zimmerma
: Thomas Zimmermann
---
arch/powerpc/configs/pmac32_defconfig | 1 +
arch/powerpc/configs/ppc6xx_defconfig | 1 +
drivers/auxdisplay/Kconfig| 2 +-
drivers/macintosh/Kconfig | 1 +
drivers/staging/fbtft/Kconfig | 1 +
drivers/video/fbdev/Kconfig | 18
user-
controlled.
v3:
- Fix PMAC_BACKLIGHT case (Christophe)
v2:
- s/BACKLIGHT_DEVICE_CLASS/BACKLIGHT_CLASS_DEVICE (Helge)
- Fix fbdev driver-dependency corner case (Arnd)
[1] https://patchwork.freedesktop.org/series/141411/
Arnd Bergmann (1):
drm: rework FB_CORE dependency
Thomas Zimmermann (2
ddition to DRM_CLIENT_LIB, the 'select' needs to be at least in
DRM_KMS_HELPER and DRM_GEM_SHMEM_HELPER, so add it here.
This patch is the KMS_HELPER part of [1].
Fixes: dadd28d4142f ("drm/client: Add client-lib module")
Signed-off-by: Arnd Bergmann
Reviewed-by: Thomas Zimmerma
Hi
Am 13.12.24 um 11:15 schrieb Christophe Leroy:
Le 13/12/2024 à 09:41, Thomas Zimmermann a écrit :
Hi
Am 13.12.24 um 09:33 schrieb Christophe Leroy:
The attached patch selects backlight support in the defconfigs that
also have PMAC_BACKLIGHT=y. Can you please apply it on top of the
CONFIG_BACKLIGHT_CLASS_DEVICE manually.
If it is necessary for PMAC_BACKLIGHT then it shouldn't be possible to
deselect it.
Here's another patch that make it depend on BACKLIGHT_CLASS_DEVICE=y.
Can you please try this as well?
Best regards
Thomas
--
--
Thomas Zimmermann
Graph
Hi
Am 13.12.24 um 09:33 schrieb Christophe Leroy:
Le 13/12/2024 à 09:05, Thomas Zimmermann a écrit :
Hi
Am 13.12.24 um 08:44 schrieb Christophe Leroy:
Le 12/12/2024 à 11:04, Thomas Zimmermann a écrit :
Do not select BACKLIGHT_CLASS_DEVICE from FB_BACKLIGHT. The latter
only controls
Hi
Am 13.12.24 um 08:44 schrieb Christophe Leroy:
Le 12/12/2024 à 11:04, Thomas Zimmermann a écrit :
Do not select BACKLIGHT_CLASS_DEVICE from FB_BACKLIGHT. The latter
only controls backlight support within fbdev core code and data
structures.
Make fbdev drivers depend on
Hi
Am 13.12.24 um 00:56 schrieb Helge Deller:
On 12/13/24 00:24, Jani Nikula wrote:
On Thu, 12 Dec 2024, "Arnd Bergmann" wrote:
On Thu, Dec 12, 2024, at 19:44, Helge Deller wrote:
On 12/12/24 11:04, Thomas Zimmermann wrote:
Do not select BACKLIGHT_CLASS_DEVICE from FB_BACK
Hi
Am 12.12.24 um 22:04 schrieb Arnd Bergmann:
On Thu, Dec 12, 2024, at 19:44, Helge Deller wrote:
On 12/12/24 11:04, Thomas Zimmermann wrote:
Do not select BACKLIGHT_CLASS_DEVICE from FB_BACKLIGHT. The latter
only controls backlight support within fbdev core code and data
structures.
Make
user-
controlled.
v2:
- s/BACKLIGHT_DEVICE_CLASS/BACKLIGHT_CLASS_DEVICE (Helge)
- Fix fbdev driver-dependency corner case (Arnd)
[1] https://patchwork.freedesktop.org/series/141411/
Arnd Bergmann (1):
drm: rework FB_CORE dependency
Thomas Zimmermann (2):
fbdev: Fix recursive dependencies wrt
ddition to DRM_CLIENT_LIB, the 'select' needs to be at least in
DRM_KMS_HELPER and DRM_GEM_SHMEM_HELPER, so add it here.
This patch is the KMS_HELPER part of [1].
Fixes: dadd28d4142f ("drm/client: Add client-lib module")
Signed-off-by: Arnd Bergmann
Reviewed-by: Thomas Zimmerma
support is also configurable separately.
v2:
- s/BACKLIGHT_DEVICE_CLASS/BACKLIGHT_CLASS_DEVICE (Helge)
- Fix fbdev driver-dependency corner case (Arnd)
Signed-off-by: Thomas Zimmermann
---
drivers/auxdisplay/Kconfig | 2 +-
drivers/macintosh/Kconfig| 1 +
drivers/staging/fbtft/Kconfig
Select FB_CORE if GEM's DMA and TTM implementations support fbdev
emulation. Fixes linker errors about missing symbols from the fbdev
subsystem.
Also see [1] for a related SHMEM fix.
Fixes: dadd28d4142f ("drm/client: Add client-lib module")
Signed-off-by: Thomas Zimmerma
Hi
Am 11.12.24 um 00:37 schrieb Helge Deller:
On 12/10/24 16:41, Thomas Zimmermann wrote:
Hi
Am 10.12.24 um 15:34 schrieb Helge Deller:
On 12/10/24 15:29, Helge Deller wrote:
On 12/10/24 15:09, Thomas Zimmermann wrote:
diff --git a/drivers/staging/fbtft/Kconfig
b/drivers/staging/fbtft
Hi
Am 10.12.24 um 15:30 schrieb Arnd Bergmann:
On Tue, Dec 10, 2024, at 15:09, Thomas Zimmermann wrote:
Do not select BACKLIGHT_CLASS_DEVICE from FB_BACKLIGHT. The latter
only controls backlight support within fbdev core code and data
structures.
Make fbdev drivers depend on
Hi
Am 10.12.24 um 15:34 schrieb Helge Deller:
On 12/10/24 15:29, Helge Deller wrote:
On 12/10/24 15:09, Thomas Zimmermann wrote:
diff --git a/drivers/staging/fbtft/Kconfig
b/drivers/staging/fbtft/Kconfig
index 77ab44362f16..577e91ff7bf6 100644
--- a/drivers/staging/fbtft/Kconfig
+++ b
support is also configurable separately.
Signed-off-by: Thomas Zimmermann
---
drivers/auxdisplay/Kconfig | 2 +-
drivers/macintosh/Kconfig| 1 +
drivers/staging/fbtft/Kconfig| 1 +
drivers/video/fbdev/Kconfig | 18 +-
drivers/video/fbdev/core/Kconfig | 3
ddition to DRM_CLIENT_LIB, the 'select' needs to be at least in
DRM_KMS_HELPER and DRM_GEM_SHMEM_HELPER, so add it here.
This patch is the KMS_HELPER part of [1].
Fixes: dadd28d4142f ("drm/client: Add client-lib module")
Signed-off-by: Arnd Bergmann
Reviewed-by: Thomas Zimmerma
user-
controlled.
[1] https://patchwork.freedesktop.org/series/141411/
Arnd Bergmann (1):
drm: rework FB_CORE dependency
Thomas Zimmermann (2):
fbdev: Fix recursive dependencies wrt BACKLIGHT_CLASS_DEVICE
drm/fbdev: Select FB_CORE dependency for fbdev on DMA and TTM
drivers/auxdisplay
Select FB_CORE if GEM's DMA and TTM implementations support fbdev
emulation. Fixes linker errors about missing symbols from the fbdev
subsystem.
Also see [1] for a related SHMEM fix.
Fixes: dadd28d4142f ("drm/client: Add client-lib module")
Signed-off-by: Thomas Zimmerma
Replace FB_BLANK_ constants with their counterparts from the
backlight subsystem. The values are identical, so there's no
change in functionality or semantics.
Signed-off-by: Thomas Zimmermann
---
drivers/macintosh/via-pmu-backlight.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
stems more independent from fbdev code and
headers.
Thomas Zimmermann (2):
arch: powerpc: Use backlight power constants
macintosh/pmubl: Use backlight power constants
arch/powerpc/kernel/traps.c | 2 +-
drivers/macintosh/via-pmu-backlight.c | 2 +-
2 files changed, 2 insertions(+), 2
Replace FB_BLANK_ constants with their counterparts from the
backlight subsystem. The values are identical, so there's no
change in functionality or semantics.
Signed-off-by: Thomas Zimmermann
---
arch/powerpc/kernel/traps.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --
Am 03.05.24 um 17:29 schrieb Arnd Bergmann:
On Fri, Apr 5, 2024, at 11:04, Thomas Zimmermann wrote:
Hi,
if there are no further comments, can this series be merged through
asm-generic?
Sorry for the delay, I've merged these for asm-generic now.
Thank you so much!
Hi,
if there are no further comments, can this series be merged through
asm-generic?
Best regards
Thomas
Am 29.03.24 um 21:32 schrieb Thomas Zimmermann:
Make architecture helpers for display functionality depend on general
video functionality instead of fbdev. This avoids the dependency on
s for the use of more fine-grained control for each directory's
files, such as the use of CONFIG_STI_CORE on parisc.
v2:
- sparc: rebased onto Makefile changes
Signed-off-by: Thomas Zimmermann
Reviewed-by: Sam Ravnborg
Cc: "James E.J. Bottomley"
Cc: Helge Deller
Cc: "Davi
include guards, and Makefiles.
Also update a few strings and comments to refer to video instead of
fbdev.
v3:
- arc, arm, arm64, sh: generate asm header via build system (Sam,
Helge, Arnd)
- um: rename fb.h to video.h
- fix typo in commit message (Sam)
Signed-off-by: Thomas Zimmermann
Reviewed-b
The per-architecture video helpers do not depend on struct fb_info
or anything else from fbdev. Remove it from the interface and replace
fb_is_primary_device() with video_is_primary_device(). The new helper
is similar in functionality, but can operate on non-fbdev devices.
Signed-off-by: Thomas
s one minor change in fbcon, which is
the only caller of fb_is_primary_device().
Patch 3 renames the source and header files from fbdev to video.
v3:
- arc, arm, arm64, sh, um: generate asm/video.h (Sam, Helge, Arnd)
- fix typos (Sam)
v2:
- improve cover letter
- rebase onto v6.9-rc1
Thomas Zimmerma
Hi
Am 28.03.24 um 12:04 schrieb Helge Deller:
On 3/27/24 21:41, Thomas Zimmermann wrote:
The per-architecture video helpers do not depend on struct fb_info
or anything else from fbdev. Remove it from the interface and replace
fb_is_primary_device() with video_is_primary_device(). The new
Hi
Am 28.03.24 um 13:51 schrieb Arnd Bergmann:
On Thu, Mar 28, 2024, at 13:46, Helge Deller wrote:
On 3/27/24 21:41, Thomas Zimmermann wrote:
+++ b/arch/arc/include/asm/video.h
@@ -0,0 +1,8 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+
+#ifndef _ASM_VIDEO_H_
+#define _ASM_VIDEO_H_
+
+#include
Hi
Am 28.03.24 um 13:39 schrieb Helge Deller:
On 3/27/24 21:41, Thomas Zimmermann wrote:
Various Kconfig options selected the per-architecture helpers for
fbdev. But none of the contained code depends on fbdev. Standardize
on CONFIG_VIDEO, which will allow to add more general helpers for
video
o update a few strings and comments to refer to video instead of
fbdev.
Signed-off-by: Thomas Zimmermann
Cc: Vineet Gupta
Cc: Catalin Marinas
Cc: Will Deacon
Cc: Huacai Chen
Cc: WANG Xuerui
Cc: Geert Uytterhoeven
Cc: Thomas Bogendoerfer
Cc: "James E.J. Bottomley"
Cc: Helge Deller
s for the use of more fine-grained control for each directory's
files, such as the use of CONFIG_STI_CORE on parisc.
v2:
- sparc: rebased onto Makefile changes
Signed-off-by: Thomas Zimmermann
Cc: "James E.J. Bottomley"
Cc: Helge Deller
Cc: "David S. Miller"
Cc: Andrea
The per-architecture video helpers do not depend on struct fb_info
or anything else from fbdev. Remove it from the interface and replace
fb_is_primary_device() with video_is_primary_device(). The new helper
is similar in functionality, but can operate on non-fbdev devices.
Signed-off-by: Thomas
s one minor change in fbcon, which is
the only caller of fb_is_primary_device().
Patch 3 renames the source and files from fbdev to video.
v2:
- improve cover letter
- rebase onto v6.9-rc1
Thomas Zimmermann (3):
arch: Select fbdev helpers with CONFIG_VIDEO
arch: Remove struct fb_info from
If there are no further comments, I'm going to merge this patchset in
time for today's PR of drm-misc-next-fixes.
Am 06.03.24 um 13:28 schrieb Thomas Zimmermann:
After cleaning up in commit 11b4eedfc87d ("fbdev: Do
not include in header"), building with
CONFIG_PMAC_BACKLI
Fix builds with CONFIG_PMAC_BACKLIGHT=y. The include statement for
the backlight header has recently been removed from .
Reported-by: Naresh Kamboju
Closes:
https://lore.kernel.org/dri-devel/ca+g9fysak5tbqqxfc2w4ohlga0cbthmxbeq8qayfxtu75yi...@mail.gmail.com/
Signed-off-by: Thomas Zimmermann
typos in commit message (Jani)
Signed-off-by: Thomas Zimmermann
Fixes: d565dd3b0824 ("[PATCH] powerpc: More via-pmu backlight fixes")
Reviewed-by: Jani Nikula
---
arch/powerpc/include/asm/backlight.h| 5 ++--
arch/powerpc/platforms/powermac/backlight.c | 26
+g9fysak5tbqqxfc2w4ohlga0cbthmxbeq8qayfxtu75yi...@mail.gmail.com/
Signed-off-by: Thomas Zimmermann
Fixes: 11b4eedfc87d ("fbdev: Do not include in header")
Reviewed-by: Jani Nikula
Cc: Thomas Zimmermann
Cc: Jani Nikula
Cc: Helge Deller
Cc: linux-fb...@vger.kernel.org
Cc: dri-de...@lists.freedesktop.org
---
drivers/macinto
fbdev code.
Compile tested with ppc6xx_defconfig.
v3:
* add Fixes tag and fix typos in patch 3
v2:
* via-pmu-backlight: fix build errors
* powerpc: resolve dependency between fbdev and backlight
[1] https://patchwork.freedesktop.org/series/130661/
Thomas Zimmermann (3
Hi
Am 05.03.24 um 10:25 schrieb Christophe Leroy:
Le 05/03/2024 à 10:01, Thomas Zimmermann a écrit :
Replace with a forward declaration in to
resolves an unnecessary dependency. Remove pmac_backlight_curve_lookup()
and struct fb_info from source and header files. The function and the
+g9fysak5tbqqxfc2w4ohlga0cbthmxbeq8qayfxtu75yi...@mail.gmail.com/
Signed-off-by: Thomas Zimmermann
Fixes: 11b4eedfc87d ("fbdev: Do not include in header")
Cc: Thomas Zimmermann
Cc: Jani Nikula
Cc: Helge Deller
Cc: linux-fb...@vger.kernel.org
Cc: dri-de...@lists.freedesktop.org
---
drivers/macintosh/via-pmu-backlight.c | 1
Replace with a forward declaration in to
resolves an unnecessary dependency. Remove pmac_backlight_curve_lookup()
and struct fb_info from source and header files. The function and the
framebuffer struct is unused. No functional changes.
Signed-off-by: Thomas Zimmermann
---
arch/powerpc
Fix builds with CONFIG_PMAC_BACKLIGHT=y. The include statement for
the backlight header has recently been removed from .
Reported-by: Naresh Kamboju
Closes:
https://lore.kernel.org/dri-devel/ca+g9fysak5tbqqxfc2w4ohlga0cbthmxbeq8qayfxtu75yi...@mail.gmail.com/
Signed-off-by: Thomas Zimmermann
fbdev code.
Compile tested with ppc6xx_defconfig.
v2:
* via-pmu-backlight: fix build errors
* powerpc: resolve dependency between fbdev and backlight
[1] https://patchwork.freedesktop.org/series/130661/
Thomas Zimmermann (3):
fbdev/chipsfb: Include
macintosh/via-pmu-backligh
Hi
Am 05.03.24 um 01:36 schrieb Michael Ellerman:
Christophe Leroy writes:
Le 04/03/2024 à 11:32, Thomas Zimmermann a écrit :
Hi
Am 04.03.24 um 10:55 schrieb Jani Nikula:
Removal of the backlight include from fb.h uncovered an implicit
dependency in powerpc asm/backlight.h. Add the
Am 04.03.24 um 11:32 schrieb Thomas Zimmermann:
[...]
---
arch/powerpc/include/asm/backlight.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/powerpc/include/asm/backlight.h
b/arch/powerpc/include/asm/backlight.h
index 1b5eab62ed04..275d5bb9aa04 100644
--- a/arch/powerpc
...@mail.gmail.com
Fixes: 11b4eedfc87d ("fbdev: Do not include in header")
Cc: Thomas Zimmermann
Cc: Helge Deller
Cc: linux-fb...@vger.kernel.org
Signed-off-by: Jani Nikula
---
Not even compile tested!
That's one of the cases that's hard to catch unless you get the config
o update a few strings and comments to refer to video instead of
fbdev.
Signed-off-by: Thomas Zimmermann
Cc: Vineet Gupta
Cc: Catalin Marinas
Cc: Will Deacon
Cc: Huacai Chen
Cc: WANG Xuerui
Cc: Geert Uytterhoeven
Cc: Thomas Bogendoerfer
Cc: "James E.J. Bottomley"
Cc: Helge Deller
s for the use of more fine-grained control for each directory's
files, such as the use of CONFIG_STI_CORE on parisc.
Signed-off-by: Thomas Zimmermann
Cc: "James E.J. Bottomley"
Cc: Helge Deller
Cc: "David S. Miller"
Cc: Andreas Larsson
Cc: Thomas Gleixner
Cc: Ingo M
The per-architecture video helpers do not depend on struct fb_info
or anything else from fbdev. Remove it from the interface and replace
fb_is_primary_device() with video_is_primary_device(). The new helper
is similar in functionality, but can operate on non-fbdev devices.
Signed-off-by: Thomas
minor change in fbcon, which is
the only caller of fb_is_primary_device().
Patch 3 renames the source and files from fbdev to video.
Thomas Zimmermann (3):
arch: Select fbdev helpers with CONFIG_VIDEO
arch: Remove struct fb_info from video helpers
arch: Rename fbdev header and source files
Hi
Am 09.02.24 um 06:15 schrieb Michael Ellerman:
Thomas Zimmermann writes:
Am 07.02.24 um 17:13 schrieb Randy Dunlap:
When VIDEO is not set, there is a build error. Fix that by selecting
VIDEO for PS3_PS3AV.
ERROR: modpost: ".video_get_options" [drivers/ps3/ps3av_mod.ko] undefin
Fixes: a3b6792e990d ("video/cmdline: Introduce CONFIG_VIDEO for video=
parameter")
Cc: Michael Ellerman
Cc: Nicholas Piggin
Cc: Christophe Leroy
Cc: Aneesh Kumar K.V
Cc: Naveen N. Rao
Cc: linuxppc-dev@lists.ozlabs.org
Cc: Thomas Zimmermann
Cc: Geoff Levand
Acked-by: Geoff Levand
C
ked.
Signed-off-by: Randy Dunlap
Cc: Michael Ellerman
Cc: Nicholas Piggin
Cc: Christophe Leroy
Cc: Aneesh Kumar K.V
Cc: Naveen N. Rao
Cc: linuxppc-dev@lists.ozlabs.org
Cc: Thomas Zimmermann
Cc: Geoff Levand
Reviewed-by: Thomas Zimmermann
---
arch/powerpc/platforms/ps3/Kconfig |
-by: Thomas Zimmermann
Cc: Michael Ellerman
Cc: Nicholas Piggin
Cc: Christophe Leroy
Cc: linuxppc-dev@lists.ozlabs.org
Reviewed-by: Javier Martinez Canillas
---
drivers/video/fbdev/Kconfig | 5 +
drivers/video/fbdev/ps3fb.c | 7 ++-
2 files changed, 3 insertions(+), 9 deletions
The ps3fb driver operates on system memory. Mark the framebuffer
accordingly. Helpers operating on the framebuffer memory will test
for the presence of this flag.
Signed-off-by: Thomas Zimmermann
Cc: Michael Ellerman
Cc: Nicholas Piggin
Cc: Christophe Leroy
Cc: linuxppc-dev@lists.ozlabs.org
The ps3fb driver operates on system memory. Mark the framebuffer
accordingly. Helpers operating on the framebuffer memory will test
for the presence of this flag.
Signed-off-by: Thomas Zimmermann
Cc: Michael Ellerman
Cc: Nicholas Piggin
Cc: Christophe Leroy
Cc: linuxppc-dev@lists.ozlabs.org
-by: Thomas Zimmermann
Cc: Michael Ellerman
Cc: Nicholas Piggin
Cc: Christophe Leroy
Cc: linuxppc-dev@lists.ozlabs.org
---
drivers/video/fbdev/Kconfig | 5 +
drivers/video/fbdev/ps3fb.c | 7 ++-
2 files changed, 3 insertions(+), 9 deletions(-)
diff --git a/drivers/video/fbdev/Kconfig b
Am 13.11.23 um 03:45 schrieb Michael Ellerman:
On Fri, 22 Sep 2023 10:04:54 +0200, Thomas Zimmermann wrote:
Clean up and rename fb_pgprotect() to work without struct file. Then
refactor the implementation for PowerPC. This change has been discussed
at [1] in the context of refactoring fbdev&#
FYI, I intent to merge patches 1 and 2 of this patchset into
drm-misc-next. The updates for PowerPC can be merged through PPC trees
later. Let me know if this does not work for you.
Best regards
Thomas
Am 22.09.23 um 10:04 schrieb Thomas Zimmermann:
Clean up and rename fb_pgprotect() to work
Remove 'file' parameter from struct machdep_calls.phys_mem_access_prot
and its implementation in pci_phys_mem_access_prot(). The file is not
used on PowerPC. By removing it, a later patch can simplify fbdev's
mmap code, which uses phys_mem_access_prot() on PowerPC.
Signed
Call __phys_mem_access_prot() from the fbdev mmap helper
pgprot_framebuffer(). Allows to avoid the file argument of NULL.
Signed-off-by: Thomas Zimmermann
Reviewed-by: Arnd Bergmann
---
arch/powerpc/include/asm/fb.h | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/arch
https://lore.kernel.org/linuxppc-dev/5501ba80-bdb0-6344-16b0-0466a950f...@suse.com/
Thomas Zimmermann (5):
fbdev: Avoid file argument in fb_pgprotect()
fbdev: Replace fb_pgprotect() with pgprot_framebuffer()
arch/powerpc: Remove trailing whitespaces
arch/powerpc: Remove file parameter from
Fix coding style. No functional changes.
Signed-off-by: Thomas Zimmermann
Reviewed-by: Arnd Bergmann
Reviewed-by: Philippe Mathieu-Daudé
---
arch/powerpc/include/asm/machdep.h | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/arch/powerpc/include/asm/machdep.h
b
() to pgprot_framebuffer() (Arnd)
Signed-off-by: Thomas Zimmermann
Reviewed-by: Arnd Bergmann
Acked-by: Geert Uytterhoeven # m68k
---
arch/ia64/include/asm/fb.h | 15 +++
arch/m68k/include/asm/fb.h | 19 ++-
arch/mips/include/asm/fb.h
otect().
While at it, replace the shift operation with PHYS_PFN().
v5:
* state function names in commit description (Javier)
Suggested-by: Christophe Leroy
Signed-off-by: Thomas Zimmermann
Reviewed-by: Arnd Bergmann
Reviewed-by: Javier Martinez Canillas
---
arch/powerpc/include/asm/fb.
Hi Javier
Am 20.09.23 um 10:01 schrieb Javier Martinez Canillas:
Thomas Zimmermann writes:
Hello Thomas,
Only PowerPC's fb_pgprotect() needs the file argument, although
the implementation does not use it. Pass NULL to the internal
Can you please mention the function that&
Ping for a review.
I'd like to get at least the first two patches into the DRM git tree.
The PPC patches could later be merged through another tree.
Best regards
Thomas
Am 12.09.23 um 15:48 schrieb Thomas Zimmermann:
Clean up and rename fb_pgprotect() to work without struct file.
Remove 'file' parameter from struct machdep_calls.phys_mem_access_prot
and its implementation in pci_phys_mem_access_prot(). The file is not
used on PowerPC. By removing it, a later patch can simplify fbdev's
mmap code, which uses phys_mem_access_prot() on PowerPC.
Signed
Call __phys_mem_access_prot() from the fbdev mmap helper
pgprot_framebuffer(). Allows to avoid the file argument of NULL.
Signed-off-by: Thomas Zimmermann
---
arch/powerpc/include/asm/fb.h | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/arch/powerpc/include/asm/fb.h b
or fbdev helpers need the parameter.
v4:
* fix commit message (Christophe)
v3:
* rename fb_pgrotect() to pgprot_framebuffer() (Arnd)
v2:
* reorder patches to simplify merging (Michael)
[1]
https://lore.kernel.org/linuxppc-dev/5501ba80-bdb0-6344-16b0-0466a950f...@suse.com/
Thoma
S_PFN().
Suggested-by: Christophe Leroy
Signed-off-by: Thomas Zimmermann
---
arch/powerpc/include/asm/fb.h | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/arch/powerpc/include/asm/fb.h b/arch/powerpc/include/asm/fb.h
index 5f1a2e5f76548..61e3b8806db69 100644
--- a/arch/po
() to pgprot_framebuffer() (Arnd)
Signed-off-by: Thomas Zimmermann
---
arch/ia64/include/asm/fb.h | 15 +++
arch/m68k/include/asm/fb.h | 19 ++-
arch/mips/include/asm/fb.h | 11 +--
arch/powerpc/include/asm/fb.h| 13 +
arch/
Fix coding style. No functional changes.
Signed-off-by: Thomas Zimmermann
---
arch/powerpc/include/asm/machdep.h | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/arch/powerpc/include/asm/machdep.h
b/arch/powerpc/include/asm/machdep.h
index 4f6e7d7ee3883
Am 11.09.23 um 16:19 schrieb Christophe Leroy:
Le 11/09/2023 à 15:08, Thomas Zimmermann a écrit :
Rename the fbdev mmap helper fb_pgprotect() to pgprot_framebuffer().
The helper sets VMA page-access flags for framebuffers in device I/O
memory.
Also clean up the helper's parameter
ccess flags, the VMAs start and end addresses and the offset
in the underlying device memory rsp file. Return the new page-access
flags. These changes align pgprot_framebuffer() with other pgprot_()
functions.
v3:
* rename fb_pgprotect() to pgprot_framebuffer() (Arnd)
Signed-off-by: T
Remove 'file' parameter from struct machdep_calls.phys_mem_access_prot
and its implementation in pci_phys_mem_access_prot(). The file is not
used on PowerPC. By removing it, a later patch can simplify fbdev's
mmap code, which uses phys_mem_access_prot() on PowerPC.
Signed
or fbdev helpers need the parameter.
v3:
* rename fb_pgrotect() to pgprot_framebuffer() (Arnd)
v2:
* reorder patches to simplify merging (Michael)
[1]
https://lore.kernel.org/linuxppc-dev/5501ba80-bdb0-6344-16b0-0466a950f...@suse.com/
Thomas Zimmermann (5):
fbdev: Avoid file argument
Fix coding style. No functional changes.
Signed-off-by: Thomas Zimmermann
---
arch/powerpc/include/asm/machdep.h | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/arch/powerpc/include/asm/machdep.h
b/arch/powerpc/include/asm/machdep.h
index 4f6e7d7ee3883
Call __phys_mem_access_prot() from the fbdev mmap helper
pgprot_framebuffer(). Allows to avoid the file argument of NULL.
Signed-off-by: Thomas Zimmermann
---
arch/powerpc/include/asm/fb.h | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/arch/powerpc/include/asm/fb.h b
S_PFN().
Suggested-by: Christophe Leroy
Signed-off-by: Thomas Zimmermann
---
arch/powerpc/include/asm/fb.h | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/arch/powerpc/include/asm/fb.h b/arch/powerpc/include/asm/fb.h
index 5f1a2e5f76548..61e3b8806db69 100644
--- a/arch/po
Hi Arnd
Am 06.09.23 um 21:53 schrieb Arnd Bergmann:
On Wed, Sep 6, 2023, at 10:35, Thomas Zimmermann wrote:
Rename the fbdev mmap helper fb_pgprotect() to fb_pgprot_device().
The helper sets VMA page-access flags for framebuffers in device I/O
memory. The new name follows pgprot_device
Fix coding style. No functional changes.
Signed-off-by: Thomas Zimmermann
---
arch/powerpc/include/asm/machdep.h | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/arch/powerpc/include/asm/machdep.h
b/arch/powerpc/include/asm/machdep.h
index 4f6e7d7ee388
f
the VMA instance, pass the individial parameters separately: existing
page-access flags, the VMAs start and end addresses and the offset
in the underlying device memory rsp file. Return the new page-access
flags. These changes align fb_pgprot_device() closer with pgprot_device.
Signed-off-by: T
S_PFN().
Suggested-by: Christophe Leroy
Signed-off-by: Thomas Zimmermann
---
arch/powerpc/include/asm/fb.h | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/arch/powerpc/include/asm/fb.h b/arch/powerpc/include/asm/fb.h
index 5f1a2e5f7654..61e3b8806db6 100644
--- a/arch/powerpc/in
or fbdev helpers need the parameter.
v2:
* reorder patches to simplify merging (Michael)
[1]
https://lore.kernel.org/linuxppc-dev/5501ba80-bdb0-6344-16b0-0466a950f...@suse.com/
Thomas Zimmermann (5):
fbdev: Avoid file argument in fb_pgprotect()
fbdev: Replace fb_pgprotect() with fb_pgpro
Call __phys_mem_access_prot() from the fbdev mmap helper
fb_pgprot_device(). Allows to avoid the file argument of
NULL.
Signed-off-by: Thomas Zimmermann
---
arch/powerpc/include/asm/fb.h | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/arch/powerpc/include/asm/fb.h b
Remove 'file' parameter from struct machdep_calls.phys_mem_access_prot
and its implementation in pci_phys_mem_access_prot(). The file is not
used on PowerPC. By removing it, a later patch can simplify fbdev's
mmap code, which uses phys_mem_access_prot() on PowerPC.
Signed
Hi
Am 05.09.23 um 04:47 schrieb Michael Ellerman:
Thomas Zimmermann writes:
Refactor fb_pgprotect() in PowerPC to work without struct file. Then
clean up and rename fb_pgprotect(). This change has been discussed at
[1] in the context of refactoring fbdev's mmap code.
The first three pa
f
the VMA instance, pass the individial parameters separately: existing
page-access flags, the VMAs start and end addresses and the offset
in the underlying device memory rsp file. Return the new page-access
flags. These changes align fb_pgprot_device() closer with pgprot_device.
Signed-off-by: T
ntation.
[1]
https://lore.kernel.org/linuxppc-dev/5501ba80-bdb0-6344-16b0-0466a950f...@suse.com/
Thomas Zimmermann (4):
arch/powerpc: Remove trailing whitespaces
arch/powerpc: Remove file parameter from phys_mem_access_prot code
arch/powerpc: Call internal __phys_mem_access_prot() in fbdev c
Remove 'file' parameter from struct machdep_calls.phys_mem_access_prot
and its implementation in pci_phys_mem_access_prot(). The file is not
used on PowerPC. By removing it, a later patch can simplify fbdev's
mmap code, which uses phys_mem_access_prot() on PowerPC.
Signed
Call __phys_mem_access_prot() from the fbdev mmap helper fb_pgprotect().
Allows us to avoid the file argument, which can then be removed from
fB_pgprotect() entirely. No other architecture uses the parameter.
Signed-off-by: Thomas Zimmermann
---
arch/powerpc/include/asm/fb.h | 6 +++---
1 file
Fix coding style. No functional changes.
Signed-off-by: Thomas Zimmermann
---
arch/powerpc/include/asm/machdep.h | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/arch/powerpc/include/asm/machdep.h
b/arch/powerpc/include/asm/machdep.h
index 4f6e7d7ee388
Hi
Am 31.08.23 um 19:38 schrieb Christophe Leroy:
Le 31/08/2023 à 16:41, Thomas Zimmermann a écrit :
Hi,
there's a per-architecture function called fb_pgprotect() that sets
VMA's vm_page_prot for mmaped framebuffers. Most architectures use a
simple implementation based on pgprot_w
nux/v6.5/source/drivers/video/fbdev/core/fbmem.c#L1299
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)
OpenPGP_signature
Descr
1 - 100 of 372 matches
Mail list logo
