Re: [PATCH 1/3] powerpc/book3e: load critical/machine/debug exception stack

2012-12-18 Thread Tabi Timur-B04825
On Thu, Oct 25, 2012 at 1:43 AM, Tiejun Chen wrote: > We always alloc critical/machine/debug check exceptions. This is > different from the normal exception. So we should load these exception > stack properly like we did for booke. Tiejun, I'm a little confused by these patches, because the actu

Re: [RFC PATCH] powerpc/fsl: add timer wakeup source

2012-12-13 Thread Tabi Timur-B04825
On Wed, Oct 3, 2012 at 5:42 AM, Wang Dongsheng wrote: > > > Signed-off-by: Wang Dongsheng Wang, Your patches must always have a From: line of your Freescale email address. Do not use your gmail.com address to send patches. This needs to be fixed when this patch is applied. -- Timur Tabi Lin

Re: [PATCH] powerpc/mpic: add global timer support

2012-12-13 Thread Tabi Timur-B04825
On Wed, Oct 3, 2012 at 5:38 AM, Wang Dongsheng wrote: > diff --git a/arch/powerpc/include/asm/mpic_timer.h > b/arch/powerpc/include/asm/mpic_timer.h > new file mode 100644 > index 000..2428972 > --- /dev/null > +++ b/arch/powerpc/include/asm/mpic_timer.h > @@ -0,0 +1,39 @@ > +/* > + * arch/p

Re: [PATCH 4/4 v6] iommu/fsl: Freescale PAMU driver and IOMMU API implementation.

2012-12-04 Thread Tabi Timur-B04825
Sethi Varun-B16395 wrote: > This would in any case change with the new LIODN allocation scheme. I > intend on introducing the new scheme as a separate patch. At the very least, you should detect when an LIODN is too large and print an error message. -- Timur Tabi Linux kernel developer at Free

Re: [PATCH 3/4 v5] iommu/fsl: Add iommu domain attributes required by fsl PAMU driver.

2012-12-02 Thread Tabi Timur-B04825
Joerg Roedel wrote: > When you add implementation specific attributes please add some > indication to the names that it is only for PAMU. DOMAIN_ATTR_STASH > sounds too generic. We were thinking that maybe this attribute could be useful to other IOMMUs in the future. Stashing is not a concept th

Re: [PATCH 4/4 v6] iommu/fsl: Freescale PAMU driver and IOMMU API implementation.

2012-12-01 Thread Tabi Timur-B04825
Varun Sethi wrote: > Following is a brief description of the PAMU hardware: > PAMU determines what action to take and whether to authorize the action on > the basis of the memory address, a Logical IO Device Number (LIODN), and > PAACT table (logically) indexed by LIODN and address. Hardware device

Re: [PATCH] powerpc: Fix typos in Freescale copyright claims

2012-11-04 Thread Tabi Timur-B04825
On Thu, Nov 1, 2012 at 11:53 PM, Li Yang wrote: > There are many cases that Semiconductor is misspelled. The patch > fix these typos. > > Signed-off-by: Li Yang Acked-by: Timur Tabi I can't believe I've been staring at these files for all these years and never noticed the misspelligs. -- Ti

Re: [PATCH 3/3 v3] iommu/fsl: Freescale PAMU driver and IOMMU API implementation.

2012-10-22 Thread Tabi Timur-B04825
On Wed, Oct 17, 2012 at 12:32 PM, Varun Sethi wrote: > + * Copyright (C) 2012 Freescale Semiconductor, Inc. Copyright 2012 Freescale Semiconductor, Inc. > + * > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#incl

Re: [PATCH 15/25] powerpc/fsl_msi: add a const qualifier

2012-10-15 Thread Tabi Timur-B04825
On Mon, Jul 23, 2012 at 4:13 AM, Uwe Kleine-König wrote: > This prepares *of_device_id.data becoming const. Without this change > the following warning would occur: > > arch/powerpc/sysdev/fsl_msi.c: In function 'fsl_of_msi_probe': > arch/powerpc/sysdev/fsl_msi.c:379:11: error: ass

Re: linux-next: manual merge of the kvm-ppc tree with the powerpc-merge tree

2012-10-10 Thread Tabi Timur-B04825
On Wed, Oct 10, 2012 at 9:47 PM, Stephen Rothwell wrote: > Commit 549d62d889b4 ("KVM: PPC: use definitions in epapr header > for hcalls") from the kvm-ppc tree added an include of asm/epapr_hcall.h > to the user visible part of asm/kvm_para.h so asm/epapr_hcall.h became a > user visible header fi

Re: linux-next: manual merge of the kvm-ppc tree with the powerpc-merge tree

2012-10-10 Thread Tabi Timur-B04825
On Wed, Oct 10, 2012 at 8:18 PM, Stephen Rothwell wrote: > arch/powerpc/include/asm/epapr_hcalls.h | 511 > -- > arch/powerpc/include/uapi/asm/Kbuild |1 + > arch/powerpc/include/uapi/asm/epapr_hcalls.h | 511 > ++ What is incl

Re: [PATCH v3 1/2] mmc: Move mmc_delay() to include/linux/mmc/core.h

2012-09-24 Thread Tabi Timur-B04825
On Mon, Sep 24, 2012 at 8:17 AM, Arnd Bergmann wrote: > >> static inline void mmc_delay(unsigned int ms) >> { >> msleep(ms); >> } > > That would be my preferred choice, unless someone has specific issues with > this. If we're going to do that, then just get rid of mmc_delay and replace

Re: PPC64 & DMA zone

2012-09-01 Thread Tabi Timur-B04825
On Fri, Aug 17, 2012 at 3:40 PM, Benjamin Herrenschmidt wrote: > On Fri, 2012-08-17 at 23:04 +0300, Aaro Koskinen wrote: >> Hi, >> >> Is there a way to reduce/limit DMA zone with PPC64 kernel (3.6-rcX) >> on G5 Mac? I have tried to search Kconfig or command line options, >> but can't find anything

Re: [PATCH] QE USB host fix for mpc832x

2012-09-01 Thread Tabi Timur-B04825
On Wed, Aug 22, 2012 at 10:54 PM, Ben Dubb wrote: > This patch should be used to get QE USB host mode working on mpc832x and > mpc8360 > based devices. It fixes the following issues: > > - BRG divisor shall not be an add number greater than 3. > - USB param block in multi-user ram can't be accesse

Re: [PATCH] i2c-mpc: Wait for STOP to hit the bus

2012-09-01 Thread Tabi Timur-B04825
On Thu, Aug 30, 2012 at 5:40 AM, Joakim Tjernlund wrote: > - mpc_i2c_stop(i2c); > + mpc_i2c_stop(i2c); /* Initiate STOP */ > + orig_jiffies = jiffies; > + /* Wait until STOP is seen, allow up to 1 s */ > + while (readb(i2c->base + MPC_I2C_SR) & CSR_MBB) { > +

Re: [PATCH 2/3] powerpc: Bail out of KGDB when we've been triggered

2012-08-22 Thread Tabi Timur-B04825
On Wed, Aug 22, 2012 at 5:43 AM, Tiejun Chen wrote: > +int kgdb_skipexception(int exception, struct pt_regs *regs) > +{ > + if (kgdb_isremovedbreak(regs->nip)) > + return 1; > + > + return 0; > +} int kgdb_skipexception(int exception, struct pt_regs *regs) { ret

Re: [PATCH 2/2] powerpc/usb: fix bug of CPU hang when missing USB PHY clock

2012-08-20 Thread Tabi Timur-B04825
On Fri, Aug 10, 2012 at 5:48 AM, Shengzhou Liu wrote: > + for (timeout = 1000; timeout > 0; timeout--) { > + /* check PHY_CLK_VALID to get phy clk valid */ > + if (in_be32(non_ehci + FSL_SOC_USB_CTRL) > +

Re: [PATCH V6 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-15 Thread Tabi Timur-B04825
On Aug 14, 2012, at 10:56 PM, "Jia Hongtao-B38951" wrote: >> >>> >>> +EXPORT_SYMBOL_GPL(mpc85xx_pci_err_probe); >> >> Make this EXPORT_SYMBOL. >> > > Hi Timur and Kumar: > > I'm a little confused. > Should we remove _GPL for upstream version too? Yes. > > -Hongtao. ___

Re: [PATCH 2/4] fsl_pmc: Add API to enable device as wakeup event source

2012-08-14 Thread Tabi Timur-B04825
Zhao Chenhui wrote: >>> > >+#ifdef CONFIG_FSL_PMC >>> > >+extern int mpc85xx_pmc_set_wake(struct device *dev, bool enable); >>> > >+extern void mpc85xx_pmc_set_lossless_ethernet(int enable); >> > >> >Don't use 'extern' for functions. >> > > Why? I think there is no difference. It's unnecessary, an

Re: [PATCH 2/4] fsl_pmc: Add API to enable device as wakeup event source

2012-08-11 Thread Tabi Timur-B04825
On Tue, Aug 7, 2012 at 3:43 AM, Zhao Chenhui wrote: > +int mpc85xx_pmc_set_wake(struct device *dev, bool enable) > +{ > + int ret = 0; > + struct device_node *clk_np; > + const u32 *prop; > + u32 pmcdr_mask; > + > + if (!pmc_regs) { > + pr_err("%s: PMC

Re: [PATCH V6 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-11 Thread Tabi Timur-B04825
On Fri, Aug 10, 2012 at 3:19 AM, Jia Hongtao wrote: > > +EXPORT_SYMBOL_GPL(mpc85xx_pci_err_probe); Make this EXPORT_SYMBOL. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozl

Re: [PATCH v2 2/2] powerpc/mpic: add global timer support

2012-08-11 Thread Tabi Timur-B04825
On Fri, Aug 10, 2012 at 12:54 AM, wrote: > From: Wang Dongsheng > +EXPORT_SYMBOL_GPL(mpic_request_timer); Make these EXPORT_SYMBOL. No need for a GPL restriction. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linu

Re: [PATCH] powerpc/epapr: export epapr_hypercall_start

2012-08-11 Thread Tabi Timur-B04825
On Sat, Aug 11, 2012 at 2:01 AM, Geert Uytterhoeven wrote: > On Sat, Aug 11, 2012 at 12:21 AM, Scott Wood wrote: >> +EXPORT_SYMBOL(epapr_hypercall_start); > > EXPORT_SYMBOL_GPL? We prefer EXPORT_SYMBOL. We don't want to restrict our customers from having to use GPL code. -- Timur Tabi Linux k

Re: [PATCH 1/3] powerpc/e500v2: Add power isa properties to comply with ePAPR 1.1

2012-08-08 Thread Tabi Timur-B04825
On Wed, Aug 8, 2012 at 1:53 AM, Olivia Yin wrote: > The patch update all e500v2 platforms. Could you provide some more information about the ePAPR requirement? > + * e500v2 power isa Device Tree Source (include) Power ISA > + * > + * Copyright 2012 Freescale Semiconductor Inc. > + * > + * Redi

Re: [v2 PATCH 1/1] booke/wdt: some ioctls do not return values properly

2012-08-06 Thread Tabi Timur-B04825
On Mon, Aug 6, 2012 at 8:59 PM, Tiejun Chen wrote: > Fix some booke wdt ioctls return value error. > > Signed-off-by: Tiejun Chen It's not the greatest patch description, but it'll do. Acked-by: Timur Tabi -- Timur Tabi Linux kernel developer at Freescale

Re: [PATCH 1/1] booke/wdt: fix incorrect WDIOC_GETSUPPORT return path

2012-08-06 Thread Tabi Timur-B04825
On Mon, Aug 6, 2012 at 2:12 PM, Tabi Timur-B04825 wrote: > On Mon, Jul 30, 2012 at 3:15 AM, Tiejun Chen > wrote: >> We miss that correct WDIOC_GETSUPPORT return path when perform >> copy_to_user() properly. > > Thanks for catching this. I'm amazed that this drive

Re: [PATCH 1/1] booke/wdt: fix incorrect WDIOC_GETSUPPORT return path

2012-08-06 Thread Tabi Timur-B04825
On Mon, Jul 30, 2012 at 3:15 AM, Tiejun Chen wrote: > We miss that correct WDIOC_GETSUPPORT return path when perform > copy_to_user() properly. Thanks for catching this. I'm amazed that this driver still has bugs like this. > diff --git a/drivers/watchdog/booke_wdt.c b/drivers/watchdog/booke_wd

Re: [PATCH V4 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-05 Thread Tabi Timur-B04825
On Fri, Aug 3, 2012 at 11:09 AM, Scott Wood wrote: > p1022ds OTOH is weird enough that it deserves its own board file. What's so weird about the P1022DS? Also, why do we need a default PCI bus if one isn't specified in the device tree? -- Timur Tabi Linux kernel developer at Freescale ___

Re: [PATCH 2/3] powerpc/85xx: add Freescale P5040 SOC and SEC v5.2 device trees

2012-07-25 Thread Tabi Timur-B04825
On Jul 25, 2012, at 5:38 PM, "Phillips Kim-R1AAHA" wrote: > On Wed, 25 Jul 2012 16:59:49 -0500 > Timur Tabi wrote: > >> Add device tree (dtsi) files for the Freescale P5040 SOC. Since this >> SOC introduces SEC v5.2, add the dtsi file for that also. >> >> Signed-off-by: Timur Tabi >> --- >

Re: [2/3][PATCH][upstream] TDM Framework

2012-07-24 Thread Tabi Timur-B04825
Michael Ellerman wrote: > I agree these values are odd. But there's no rule that you can only use > an enum if the values are monotonically increasing. > > It can still serve as helpful documentation, and reduce the number of > places you pass a bare int around. IMHO, an enum should only be used i

Re: [PATCH] powerpc/mm: add ZONE_NORMAL zone for 64 bit kernel

2012-07-23 Thread Tabi Timur-B04825
Benjamin Herrenschmidt wrote: > Sure but I don't want to create the zones in the first place (and thus > introduce the added pressure on the memory management) on machines that > don't need it. One thing that does confuse me -- by default, we don't create a ZONE_NORMAL. We only create a ZONE_DMA

Re: [PATCH] powerpc/mm: add ZONE_NORMAL zone for 64 bit kernel

2012-07-23 Thread Tabi Timur-B04825
Benjamin Herrenschmidt wrote: > Sure but I don't want to create the zones in the first place (and thus > introduce the added pressure on the memory management) on machines that > don't need it. Ah yes, I forgot about memory pressure. -- Timur Tabi Linux kernel developer at Freescale

Re: [PATCH] powerpc/mm: add ZONE_NORMAL zone for 64 bit kernel

2012-07-23 Thread Tabi Timur-B04825
On Mon, Jul 23, 2012 at 5:20 PM, Benjamin Herrenschmidt wrote: > And ? Who cares ? Drivers who know about a 32-bit limitations use > GFP_DMA32, that's what is expected, don't mess around with ZONE_DMA. I thought drivers are supposed to set a dma_mask, and dma_alloc_coherent() is supposed to use

Re: [2/3][PATCH][upstream] TDM Framework

2012-07-23 Thread Tabi Timur-B04825
On Mon, Jul 23, 2012 at 5:49 AM, wrote: > From: Sandeep Singh Please fix your git configuration so that the From: line in your emails contains your full name. This patch was sent with this From: line: From: It should say: From: Sandeep Singh Three more things: 1) You don't need to add

Re: [PATCH] of: require a match on all fields of of_device_id

2012-07-17 Thread Tabi Timur-B04825
On Tue, Jul 17, 2012 at 8:11 PM, Scott Wood wrote: > Commit 107a84e61cdd3406c842a0e4be7efffd3a05dba6 ("of: match by compatible > property first") breaks the gianfar ethernet driver found on various > Freescale PPC chips. > > There are, for unfortunate historical reasons, two nodes with a > compati

Re: [PATCH] ppc44x/watchdog: Select WATCHDOG_NOWAYOUT option

2012-07-16 Thread Tabi Timur-B04825
On Sun, Jul 15, 2012 at 9:07 PM, Lu.Jiang wrote: > > Since the ppc44x's watch dog can not reset by software, such operation only > set the timeout value(WDTP) to minimum, and cause the system reboot > immediately. It's supposed to set it to the maximum. That's what WDTP_MASK is supposed to do.

Re: [PATCH] ppc44x/watchdog: Select WATCHDOG_NOWAYOUT option

2012-07-16 Thread Tabi Timur-B04825
On Fri, Jul 13, 2012 at 7:25 AM, Josh Boyer wrote: > Right now, if the option is not set we call booke_wdt_disable which > indeed does not actually _disable_ the WDT, but it does set the timer > period to the maxium value. We could go one step further and implement > a simple timer that pops and

Re: [linuxppc-release] [PATCH v3 4/4] fsl-dma: use spin_lock_bh to instead of spin_lock_irqsave

2012-07-16 Thread Tabi Timur-B04825
Qiang Liu wrote: > Use spin_lock_bh to instead of spin_lock_irqsave for improving performance. You forgot to include the evidence that performance has improved, as well as an explanation why it's okay to use spin_lock_bh, and why it's faster. I told you to respin the patch with that informatio

Re: [PATCH 2/2] powerpc/85xx: Create dts of each core in CAMP mode for P1021RDB-PC

2012-07-11 Thread Tabi Timur-B04825
Kumar Gala wrote: >> > >> >./p2020rdb_camp_core1.dts >> >./p1020rdb-pc_camp_core1.dts >> >./mpc8572ds_camp_core1.dts >> >./p2020rdb_camp_core0.dts >> >./p1020rdb-pc_camp_core0.dts >> >./mpc8572ds_camp_core0.dts >> >./p1020rdb_camp_core1.dts >> >./p1020rdb_camp_core0.dts >> > > I'd be ok if we want

Re: [PATCH 2/2] powerpc/85xx: Create dts of each core in CAMP mode for P1021RDB-PC

2012-07-10 Thread Tabi Timur-B04825
On Tue, Jul 10, 2012 at 3:39 AM, Xu Jiucheng wrote: > Create the dts files for each core and splits the devices between > the two cores for P1021RDB-PC. > > Core0 has l2, serial0, i2c, spi, gpio, tdm,dma, usb, eth0, eth1, > sdhc, crypto, global-util, message, pci0, pci1, msi, crypto. > Core1 has l

Re: 3.4.0-rc1: No init found

2012-07-05 Thread Tabi Timur-B04825
On Wed, Apr 4, 2012 at 7:36 AM, Suzuki K. Poulose wrote: >> Not sure if this is related, but at the end of each kernel compilation, >> the following messages are printed: >> >> >>SYSMAP System.map >>SYSMAP .tmp_System.map >>WRAParch/powerpc/boot/zImage.pmac >> INFO:

Re: [PATCH v7 1/5] powerpc/85xx: implement hardware timebase sync

2012-07-05 Thread Tabi Timur-B04825
On Tue, Jul 3, 2012 at 5:21 AM, Zhao Chenhui wrote: > Do hardware timebase sync. Firstly, stop all timebases, and transfer > the timebase value of the boot core to the other core. Finally, > start all timebases. > > Only apply to dual-core chips, such as MPC8572, P2020, etc. > > Signed-off-by: Zha

Re: [PATCH v7 1/5] powerpc/85xx: implement hardware timebase sync

2012-07-04 Thread Tabi Timur-B04825
Zhao Chenhui wrote: > On Tue, Jul 03, 2012 at 10:17:12PM -0500, Tabi Timur-B04825 wrote: >> Zhao Chenhui wrote: >>> If the guts variable is NULL, it indicates there is error in dts or kernel. >>> We should fix the error, rather than ignore it. >> >> A

Re: [PATCH v7 1/5] powerpc/85xx: implement hardware timebase sync

2012-07-03 Thread Tabi Timur-B04825
Zhao Chenhui wrote: > If the guts variable is NULL, it indicates there is error in dts or kernel. > We should fix the error, rather than ignore it. And that's why there's a warning message. Crashing the kernel is not going to fix anything. > Moreover, if smp_85xx_ops.give/take_timebase is NULL,

Re: [PATCH v7 1/5] powerpc/85xx: implement hardware timebase sync

2012-07-03 Thread Tabi Timur-B04825
On Tue, Jul 3, 2012 at 5:21 AM, Zhao Chenhui wrote: > + np = of_find_matching_node(NULL, mpc85xx_smp_guts_ids); > + if (np) { > + guts = of_iomap(np, 0); > + of_node_put(np); > + if (!guts) { > + pr_err("%s: Could not map

Re: [PATCH v6 1/5] powerpc/85xx: implement hardware timebase sync

2012-06-29 Thread Tabi Timur-B04825
On Tue, Jun 26, 2012 at 5:25 AM, Zhao Chenhui wrote: > Do hardware timebase sync. Firstly, stop all timebases, and transfer > the timebase value of the boot core to the other core. Finally, > start all timebases. > > Only apply to dual-core chips, such as MPC8572, P2020, etc. > > Signed-off-by: Zh

Re: [PATCH v6 0/3] netdev/of/phy: MDIO bus multiplexer support.

2012-05-18 Thread Tabi Timur-B04825
On Wed, May 2, 2012 at 8:16 PM, David Daney wrote: > From: David Daney > > This code has been working well for about six months on a couple of > different configurations (boards), so I thought it would be a good > time to send it out again, and I hope get it on the path towards > merging. David,

Re: Re: Build regressions/improvements in v3.4-rc7

2012-05-17 Thread Tabi Timur-B04825
On Thu, May 17, 2012 at 12:30 PM, Timur Tabi wrote: > Anyway, I think I see what the problem is, but it does appear when I use > the normal defconfigs.  What .config was being used? I meant to say that it does NOT appear. -- Timur Tabi Linux kernel developer at Freescale __

Re: [PATCH 1/2] powerpc/mpc85xx: p1022ds support the MTD for NOR and NAND flash

2012-05-10 Thread Tabi Timur-B04825
On Mon, Apr 16, 2012 at 8:42 PM, wrote: > From: Jerry Huang > > The compatilbe 'simple-bus' is removed from the latest DTS for NAND and > NOR flash partition, so we must add the new compatilbe support for p1022ds, > otherwise, the kernel can't parse the partition of NOR and NAND flash. > > Signe

Re: [PATCH 2/2] powerpc/p1022ds/DTS: Add RTC support

2012-05-10 Thread Tabi Timur-B04825
On Mon, Apr 16, 2012 at 8:42 PM, wrote: > From: Jerry Huang > > Add the RTC support for p1022ds > > Signed-off-by: Jerry Huang > --- Acked-by: Timur Tabi Kumar, please apply for 3.5. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-

Re: [PATCH v2 1/2] powerpc/mpc85xx: support the MTD for p1022ds flash

2012-04-17 Thread Tabi Timur-B04825
On Tue, Apr 17, 2012 at 4:15 AM, wrote: > diff --git a/arch/powerpc/platforms/85xx/p1022_ds.c > b/arch/powerpc/platforms/85xx/p1022_ds.c > index e74b7cd..0db3a7e 100644 > --- a/arch/powerpc/platforms/85xx/p1022_ds.c > +++ b/arch/powerpc/platforms/85xx/p1022_ds.c > @@ -463,6 +463,7 @@ static voi

Re: [git pull] Please pull powerpc.git next branch

2012-04-02 Thread Tabi Timur-B04825
Ping! Kumar, you forgot to deal with this patch for 3.3. The window for 3.4 is closing rapidly. There are no objections to my patch. Could you please apply it and get it merged into 3.4? I'm tired of waiting. On Thu, Mar 29, 2012 at 4:47 PM, Tabi Timur-B04825 wrote: > On Thu, Mar

Re: [git pull] Please pull powerpc.git next branch

2012-03-29 Thread Tabi Timur-B04825
On Thu, Mar 29, 2012 at 3:44 PM, Kumar Gala wrote: > > A few minor bug fixes and missing dts updates for 3.4.  There got lost in > the mix.  Sorry for the delay What about my "don't call of_platform_bus_probe() twice" patch? That's still an important fix for the P1022DS. -- Timur Tabi Linux ker

Re: why use 'raw_spin_lock_irqsave' inf function 'of_find_node_with_property'

2012-03-29 Thread Tabi Timur-B04825
On Thu, Mar 29, 2012 at 5:01 AM, Huang Changming-R66093 wrote: > Hi, all > > In function “of_find_node_with_property”, why use “raw_spin_lock_irqsave” to > disable preemption and disable interrupt? Where do you see raw_spin_lock_irqsave? struct device_node *of_find_node_with_property(struct devi

Re: issues calling of_platform_bus_probe() twice

2012-03-18 Thread Tabi Timur-B04825
Grant Likely wrote: > That's because you're using it wrong. of_platform_bus_probe() creates > platform devices at the starting level and every level below it as > described by the bus ids. It is illegal to call of_platform_bus_probe() > twice at the same level in the DT. Well, *I* am not using i

Re: issues calling of_platform_bus_probe() twice

2012-03-17 Thread Tabi Timur-B04825
Benjamin Herrenschmidt wrote: > Why don't you track down the actual bug instead ? I was hoping that someone who is very familiar with the code would take a look. I don't know the OF layer that well. -- Timur Tabi Linux kernel developer at Freescale _

Re: [PATCH] Device Tree Bindings for Freescale TDM controller

2012-03-17 Thread Tabi Timur-B04825
On Sat, Mar 17, 2012 at 2:33 AM, Aggrwal Poonam-B10812 wrote: > >> > +           compatible = "fsl,p1010-tdm", "fsl,mpc8315-tdm"; >> > +           reg = <0x16000 0x200 0x2c000 0x2000>; >> > +           clock-frequency = <0>; >> >> Show a real clock-frequency, perhaps with a comment saying it's typ

Re: [PATCH] Device Tree Bindings for Freescale TDM controller

2012-03-17 Thread Tabi Timur-B04825
On Sat, Mar 17, 2012 at 2:33 AM, Aggrwal Poonam-B10812 wrote: > >> > +  - clock-frequency >> > +      Usage: optional >> > +      Value type: >> > +      Definition: The frequency at which the TDM block is operating. >> >> Will this frequency ever need to be > 4GHz? > Don't think so, at max this

Re: [PATCH] mpc85xx_defconfig:Added I2C_CHARDEV option in defconfig to have compiled I2C device interface

2012-03-17 Thread Tabi Timur-B04825
On Sat, Mar 17, 2012 at 4:00 AM, Shaveta Leekha wrote: > Signed-off-by: Shaveta Leekha > --- Where's the patch description? You need to explain WHY this change is a good idea. And you should change all defconfigs in one patch. -- Timur Tabi Linux kernel developer at Freescale ___

Re: issues calling of_platform_bus_probe() twice

2012-03-17 Thread Tabi Timur-B04825
Grant Likely wrote: >>> > > Are you aware of any reason that we can't call of_platform_bus_probe() >>> > > or multiple times. Timur's run into an issue in which all devices >>> > > don't get registered properly if we call of_platform_bus_probe() times >>> > > with different of_device_id st

Re: [PATCH 6/9] powerpc/mpc8548cds: Add FPGA node to dts

2012-03-07 Thread Tabi Timur-B04825
On Tue, Mar 6, 2012 at 3:06 AM, Zhao Chenhui wrote: > From: chenhui zhao > > Remove FPGA(CADMUS) macros in code. Move it to dts. > > Signed-off-by: Zhao Chenhui > Signed-off-by: Li Yang > --- Acked-by: Timur Tabi -- Timur Tabi Linux kernel developer at Freescale ___

Re: [PATCH 1/2] powerpc/e500: make load_up_spe a normal fuction

2012-02-27 Thread Tabi Timur-B04825
On Mon, Feb 27, 2012 at 4:59 AM, Olivia Yin wrote: > So that we can call it in kernel. And why would we want that? -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/l

Re: [PATCH] powerpc/85xx: allow CONFIG_PHYS_64BIT to be selectable

2012-02-23 Thread Tabi Timur-B04825
Li Yang-R58472 wrote: > It's a good point. Why can't we decide to use 32-bit/36-bit TLB at runtime > even for e500v2? That's not what PHYS_64BIT does. PHYS_64BIT determines whether phys_addr_t is a u64 or a u32. This is something that must be determined at compilation time. >> Please remem

Re: [PATCH] powerpc/85xx: allow CONFIG_PHYS_64BIT to be selectable

2012-02-23 Thread Tabi Timur-B04825
Li Yang-R58472 wrote: > The mpc85xx_defconfig does include silicons with e500v1 core which > doesn't have the 36-bit support. Won't enabling 36-bit support by > default break the support for them? No. The kernel will detect at runtime that that it's an e500v1 core and it won't try to create 36

Re: [PATCH] powerpc/85xx: allow CONFIG_PHYS_64BIT to be selectable

2012-02-23 Thread Tabi Timur-B04825
Huang Changming-R66093 wrote: > I want to know if you have the other codes for different address? > > The current U-boot just detect the base address of DTS and the CCSR address. > If they are different, u-boot will print the warning and return 0, > so the kernel can't been booted. I had a patch t

Re: [PATCH] powerpc/85xx: allow CONFIG_PHYS_64BIT to be selectable

2012-02-23 Thread Tabi Timur-B04825
Li Yang-R58472 wrote: > Even though the user still need to know the addressing mode that u-boot > is using. It won't work if the addressing mode of u-boot and device > tree are different. U-Boot will tell the user if the DT does not match. I added code to U-Boot to do that. So if you have a 3

Re: [PATCH] powerpc/85xx: allow CONFIG_PHYS_64BIT to be selectable

2012-02-23 Thread Tabi Timur-B04825
Li Yang-R58472 wrote: > I agree with Changming that we shouldn't setting PHYS_64BIT by default. The default kernel should always be the compatible with as much as possible. Disabling PHYS_64BIT by default means that the default kernel will not work with a 36-bit DTS. If you attempt to boot su

Re: [PATCH] powerpc/85xx: allow CONFIG_PHYS_64BIT to be selectable

2012-02-23 Thread Tabi Timur-B04825
Huang Changming-R66093 wrote: > I have one similar patch to remove the "select PHYS_64BIT". > http://patchwork.ozlabs.org/patch/132351/ That one doesn't update the defconfigs, which means that the default kernel will not have PHYS_64BIT enabled. -- Timur Tabi Linux kernel developer at Freescale

Re: warnings from drivers/tty/ehv_bytechan.c

2012-02-20 Thread Tabi Timur-B04825
Stephen Rothwell wrote: > console_initcall() is not defined for modules. Hmmm... the patch you posted is a good short-term fix, but I wonder if makes sense for the driver to support modules at all. I have this in the driver: #include ... module_init(ehv_bc_init); module_exit(ehv_bc_exit); al

Re: [PATCH 21/30] KVM: PPC: make e500v2 and e500mc mutually exclusive

2012-02-17 Thread Tabi Timur-B04825
On Fri, Feb 17, 2012 at 10:56 AM, Alexander Graf wrote: >  config KVM_E500MC >        bool "KVM support for PowerPC E500MC/E5500 processors" > -       depends on EXPERIMENTAL && PPC_E500MC > +       depends on EXPERIMENTAL && PPC_E500MC && !KVM_E500V2 There was a patch floating around that made

Re: [PATCH] powerpc/85xx:Add PSC9131 RDB Support

2012-02-17 Thread Tabi Timur-B04825
On Tue, Feb 14, 2012 at 2:37 AM, Prabhakar Kushwaha wrote: > >  Applied on git://git.kernel.org/pub/scm/linux/kernel/git/galak/powerpc.git > branch next This is actually a false statement. "Applied" is past tense, so you are saying that this patch has *already* been applied to Kumar's powerpc.g

Re: [PATCH 2/2 v5] powerpc/85xx: Abstract common define of signal multiplex control for qe

2012-02-17 Thread Tabi Timur-B04825
On Wed, Feb 15, 2012 at 12:58 AM, Zhicheng Fan wrote: > @@ -114,6 +114,24 @@ struct ccsr_guts_86xx { >        __be32  srds2cr1;       /* 0x.0f44 - SerDes2 Control Register 0 */ >  } __attribute__ ((packed)); > > +#ifdef CONFIG_PPC_85xx > + Remove this #ifdef. It doesn't really help, and it make

Re: [PATCH 1/2] powerpc/85xx: fix problem that prevents PHYS_64BIT from configurable

2012-02-17 Thread Tabi Timur-B04825
On Thu, Feb 16, 2012 at 7:27 PM, Kumar Gala wrote: > For some of these platforms like P2041RDB, P3041DS, P3060QDS, P4080DS, & > P5020DS only a 36-bit physical address map is supported by u-boot and the > device tree.  This was a decision that was made to NOT support 32-bit address > map for th

Re: [PATCH 1/2 v4] powerpc/85xx: Add p1025rdb platform support

2012-02-16 Thread Tabi Timur-B04825
On Tue, Feb 14, 2012 at 2:06 AM, Zhicheng Fan wrote: > From: Zhicheng Fan > > Signed-off-by: Zhicheng Fan > --- Acked-by: Timur Tabi -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https

Re: [PATCH 2/2 v4] powerpc/dts: Add dts for p1025rdb board

2012-02-16 Thread Tabi Timur-B04825
On Tue, Feb 14, 2012 at 2:06 AM, Zhicheng Fan wrote: > From: Zhicheng Fan > > P1025RDB Overview > -- > 1Gbyte DDR3 SDRAM > 32 Mbyte NAND flash > 16Mbyte NOR flash > 16 Mbyte SPI flash > SD connector to interface with the SD memory card > Real-time clock on I2C bus > > PCIe: > - x1

Re: [PATCH 1/2 v5] powerpc/85xx: Add Quicc Engine support for p1025rdb

2012-02-16 Thread Tabi Timur-B04825
On Wed, Feb 15, 2012 at 12:58 AM, Zhicheng Fan wrote: > From: Zhicheng Fan > > Signed-off-by: Zhicheng Fan > --- Acked-by: Timur Tabi -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org http

Re: [PATCH 1/1] fsldma: ignore end of segments interrupt

2012-02-16 Thread Tabi Timur-B04825
On Thu, Jan 26, 2012 at 2:58 PM, Ira W. Snyder wrote: > The mpc8349ea has been observed to generate spurious end of segments > interrupts despite the fact that they are not enabled by this driver. > Check for them and ignore them to avoid a kernel error message. When this happens, are there any o

Re: [PATCH 1/2] powerpc/85xx: fix problem that prevents PHYS_64BIT from configurable

2012-02-16 Thread Tabi Timur-B04825
On Thu, Feb 16, 2012 at 6:10 AM, Li Yang wrote: > > The reason why we need to keep PHYS_64BIT option configurable is > that enabling it cause negative performance impact on various > aspects like TLB miss and physical address manipulating.  We should > not enable it unless really needed, e.g. use

Re: [PATCH 1/2] powerpc/85xx: fix problem that prevents PHYS_64BIT from configurable

2012-02-16 Thread Tabi Timur-B04825
On Thu, Feb 16, 2012 at 9:56 AM, Tabi Timur-B04825 wrote: > I think we should make 36-bit the only option for the upstream > defconfigs, and if we want a 32-bit "optimized" kernel for the SDK, > then we provide that on the SDK only. Oops, I meant to post this as a reply to &

Re: [PATCH 2/2 v3] powerpc/dts: Add dts for p1025rdb board

2012-02-13 Thread Tabi Timur-B04825
On Fri, Feb 10, 2012 at 4:18 AM, Zhicheng Fan wrote: > > +                       local-mac-address = [ 00 00 00 00 00 00 ]; This doesn't belong in the DTS. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@li

Re: [PATCH 2/2 v3] powerpc/85xx: Abstract common define of signal multiplex control for qe

2012-02-13 Thread Tabi Timur-B04825
On Sun, Feb 12, 2012 at 11:33 PM, Zhicheng Fan wrote: >                if (np) { > -                       pmuxcr = of_iomap(np, 0) + MPC85xx_PMUXCR_OFFSET; > +                       guts = of_iomap(np, 0); > > -                       if (!pmuxcr) > -                               printk(KERN_EME

Re: [PATCH 1/2 v3] powerpc/85xx: Add Quicc Engine support for p1025rdb

2012-02-13 Thread Tabi Timur-B04825
On Sun, Feb 12, 2012 at 11:33 PM, Zhicheng Fan wrote: > From: Zhicheng Fan > > Signed-off-by: Zhicheng Fan > --- >  arch/powerpc/platforms/85xx/mpc85xx_rdb.c |   78 > - >  1 files changed, 77 insertions(+), 1 deletions(-) > > diff --git a/arch/powerpc/platforms/85xx/

Re: [PATCH 1/2 v2] P1025RDB: Add Quicc Engine support

2012-02-09 Thread Tabi Timur-B04825
> +#ifdef CONFIG_QUICC_ENGINE > +       np = of_find_compatible_node(NULL, NULL, "fsl,qe-ic"); > +       if (np) { > +               qe_ic_init(np, 0, qe_ic_cascade_low_mpic, > +                               qe_ic_cascade_high_mpic); > +               of_node_put(np); > + > +       } else > +    

Re: [PATCH 1/2 v4] powerpc/85xx: Add p1020rdb-pc platform support

2012-02-09 Thread Tabi Timur-B04825
On Wed, Feb 8, 2012 at 11:40 PM, Zhicheng Fan wrote: > +static int __init p1020_rdb_pc_probe(void) > +{ > +       unsigned long root = of_get_flat_dt_root(); > + > +       if (of_flat_dt_is_compatible(root, "fsl,P1020RDB-PC")) > +               return 1; > +       return 0; > +} static int __ini

Re: [PATCH 2/2 v4] powerpc/dts: Add dts for p1020rdb-pc board

2012-02-09 Thread Tabi Timur-B04825
On Wed, Feb 8, 2012 at 11:40 PM, Zhicheng Fan wrote: > >  arch/powerpc/boot/dts/p1020rdb-pc.dts            |   90 >  arch/powerpc/boot/dts/p1020rdb-pc.dtsi           |  247 > ++ >  arch/powerpc/boot/dts/p1020rdb-pc_36b.dts        |   90 If we're going to sup

Re: [PATCH] powerpc/dts: Removed fsl,msi property from dts.

2012-02-09 Thread Tabi Timur-B04825
On Thu, Feb 9, 2012 at 7:41 AM, Diana Craciun wrote: > From: Diana CRACIUN > > The association in the decice tree between PCI and MSI > using fsl,msi property was an artificial one and it does > not reflect the actual hardware. > > Signed-off-by: Diana CRACIUN Acked-by: Timur Tabi -- Timur T

Re: Efika (mpc5200b): sound doesn't build/work from linux-2.6.38.x

2012-02-05 Thread Tabi Timur-B04825
On Fri, Feb 3, 2012 at 8:02 PM, acrux wrote: > as i said [1] it seems to be fixed only in 3.x instead the last working one > is the obsolete 2.6.36.x . > Anyway, alog the sound/soc/fsl/mpc5200_dma.c now builds the sound is still > broken. Ok, I missed that part in your email. The Efika sound

Re: Efika (mpc5200b): sound doesn't build/work from linux-2.6.38.x

2012-02-02 Thread Tabi Timur-B04825
On Thu, Feb 2, 2012 at 10:57 AM, acrux wrote: > well, i got the same error with also linux-2.6.37. Btw, this was already > reported about a year ago: > http://lists.ozlabs.org/pipermail/linuxppc-dev/2011-February/088415.html I think this was fixed already. You're using an obsolete kernel. --

Re: [PATCH 2/2] powerpc: Abstract common define of signal multiplex control for qe

2012-01-30 Thread Tabi Timur-B04825
fanzc wrote: >> >>> Signed-off-by: Fanzc >> Please fix this. There are only two e's in freescale. In addition, >> please use your full name. >> > Hi Timur, > >You mean that need to remove the define to other file or create new > file? No, I mean you're signed-off-by should be this: Sign

Re: [PATCH 2/2] powerpc: Abstract common define of signal multiplex control for qe

2012-01-25 Thread Tabi Timur-B04825
On Thu, Jan 19, 2012 at 11:00 PM, Zhicheng Fan wrote: > Signed-off-by: Fanzc Please fix this. There are only two e's in freescale. In addition, please use your full name. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing l

Re: [PATCH 1/2] P1025RDB: add Quicc Engine support

2012-01-20 Thread Tabi Timur-B04825
On Thu, Jan 19, 2012 at 11:00 PM, Zhicheng Fan wrote: > From: Fanzc > > Signed-off-by: Fanzc Please use your full name (first and last name) > --- >  arch/powerpc/platforms/85xx/mpc85xx_rdb.c |   79 > - >  1 files changed, 78 insertions(+), 1 deletions(-) > > diff

Re: [PATCH] drivers/video: compile fixes for fsl-diu-fb.c

2012-01-15 Thread Tabi Timur-B04825
Michael Neuling wrote: > In message<4f1370c9.9010...@freescale.com> you wrote: >> Michael Neuling wrote: >>> Fix a bunch of compiler errors and warnings introduced in: >>> commit ddd3d905436b572ebadc09dcf2d12ca5b37020a0 >>> Author: Timur Tabi >>> drivers/video: fsl-diu-fb: merge all al

Re: [PATCH] drivers/video: compile fixes for fsl-diu-fb.c

2012-01-15 Thread Tabi Timur-B04825
Michael Neuling wrote: > Fix a bunch of compiler errors and warnings introduced in: >commit ddd3d905436b572ebadc09dcf2d12ca5b37020a0 >Author: Timur Tabi >drivers/video: fsl-diu-fb: merge all allocated data into one block > > Signed-off-by: Michael Neuling > --- > Timur: you do compile t

Re: [PATCH] DTS: fix the bug and add the chip compatible for eSDHC

2012-01-02 Thread Tabi Timur-B04825
On Fri, Dec 23, 2011 at 12:10 AM, wrote: > > Accordint to latest kernel, the auto-cmd12 property should be > "sdhci,auto-cmd12", and according to the SDHC binding and the workaround for > the special chip, add the chip compatible for eSDHC: "fsl,p1022-esdhc", > "fsl,mpc8536-esdhc", "fsl,p2020-esd

Re: Linux port availability for p5010 processor

2011-12-15 Thread Tabi Timur-B04825
On Thu, Dec 15, 2011 at 5:45 AM, Vineeth wrote: > > why is it a part of 85xx directory ? the core of P5020 is E5500 where the > core of 85xx is e500; e5500 is very similar to e500, so it's all part of the same family of cores. -- Timur Tabi Linux kernel developer at Freescale __

Re: [PATCH] powerpc: fix compile error with 85xx/p1022_ds.c

2011-12-13 Thread Tabi Timur-B04825
On Sun, Dec 11, 2011 at 4:49 PM, Michael Neuling wrote: > Current linux-next compiled with mpc85xx_defconfig causes this: >  arch/powerpc/platforms/85xx/p1022_ds.c:341:14: error: 'udbg_progress' > undeclared here (not in a function) > > Add include to fix this. > > Signed-off-by: Michael Neuling

Re: [PATCH] powerpc/fsl: add MSI support for the Freescale hypervisor

2011-12-12 Thread Tabi Timur-B04825
Scott Wood wrote: > How's the hypervisor even going to know if the mem= kernel command line > argument is used to change the end of main memory (assuming that's been > taken into account by this point in the boot sequence)? > > What if the user put a shared memory region immediately after the main

Re: [PATCH] powerpc/fsl: add MSI support for the Freescale hypervisor

2011-12-12 Thread Tabi Timur-B04825
Scott Wood wrote: > Technically, it's up to the hv config file where MSIIR gets mapped. > After main memory is just a common way of configuring it, but won't work > if we're limiting the partition's memory to end at an unusual address. I'll change the comment to reflect this. Why can't we have th

Re: [PATCH 10/13] powerpc: Update mpc85xx/corenet 32-bit defconfigs

2011-12-09 Thread Tabi Timur-B04825
On Mon, Oct 10, 2011 at 3:50 PM, Becky Bruce wrote: > From: Becky Bruce > > Results from updates via make savedefconfig. > > Signed-off-by: Becky Bruce > --- ... > -CONFIG_PPC_EPAPR_HV_BYTECHAN=y I guess no one noticed that this patch removes byte channel support, thereby preventing this kern

Re: [PATCH] powerpc: Fix compiliation with hugetlbfs enabled

2011-12-09 Thread Tabi Timur-B04825
On Thu, Nov 24, 2011 at 1:40 PM, Kumar Gala wrote: > arch/powerpc/mm/hugetlbpage.c: In function 'reserve_hugetlb_gpages': > arch/powerpc/mm/hugetlbpage.c:312:2: error: implicit declaration of function > 'parse_args' > > Signed-off-by: Kumar Gala Acked-by: Timur Tabi Would you please apply thi

  1   2   >