On Thu, Aug 30, 2012 at 5:40 AM, Joakim Tjernlund
<joakim.tjernl...@transmode.se> wrote:
> - mpc_i2c_stop(i2c);
> + mpc_i2c_stop(i2c); /* Initiate STOP */
> + orig_jiffies = jiffies;
> + /* Wait until STOP is seen, allow up to 1 s */
> + while (readb(i2c->base + MPC_I2C_SR) & CSR_MBB) {
> + if (time_after(jiffies, orig_jiffies + HZ)) {
> + u8 status = readb(i2c->base + MPC_I2C_SR);
> +
> + dev_dbg(i2c->dev, "timeout\n");
> + if ((status & (CSR_MCF | CSR_MBB | CSR_RXAK)) != 0) {
> + writeb(status & ~CSR_MAL,
> + i2c->base + MPC_I2C_SR);
> + mpc_i2c_fixup(i2c);
> + }
> + return -EIO;
> + }
> + cond_resched();
> + }
Shouldn't the while-loop be inside mpc_i2c_stop() itself?
--
Timur Tabi
Linux kernel developer at Freescale
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
