Re: [PATCH] powerpc/xive: Update comment referencing magic loads from an ESB

2019-08-01 Thread Stewart Smith
ce the new location of the > description in xive-regs.h > > Signed-off-by: Jordan Niethe Acked-by: Stewart Smith -- Stewart Smith OPAL Architect, IBM.

Re: [PATCH] crypto: nx: nx-842-powernv: Add of_node_put() before return

2019-07-24 Thread Stewart Smith
Nishka Dasgupta writes: > Each iteration of for_each_child_of_node puts the previous node, but This is for_each_compatible_node. otherwise looks okay, Acked-by: Stewart Smith -- Stewart Smith OPAL Architect, IBM.

Re: [PATCH v3 01/16] powerpc/fadump: move internal fadump code to a new file

2019-06-27 Thread Stewart Smith
ation; either version > + * 2 of the License, or (at your option) any later version. > + */ This file takes a bunch of code from fadump.c, which has the (C) header showing (C) 2011, and author of Mahesh. We should probably preserve that -- Stewart Smith OPAL Architect, IBM.

Re: [PATCH] powerpc: Document xive=off option

2019-06-24 Thread Stewart Smith
-by: Michael Neuling Acked-by: Stewart Smith -- Stewart Smith OPAL Architect, IBM.

Re: crash after NX error

2019-06-05 Thread Stewart Smith
Michael Ellerman writes: > Stewart Smith writes: >> On my two socket POWER9 system (powernv) with 842 zwap set up, I >> recently got a crash with the Ubuntu kernel (I haven't tried with >> upstream, and this is the first time the system has died like this, so >> I

crash after NX error

2019-06-03 Thread Stewart Smith
assuming my above crash looks like this failure)? -- Stewart Smith OPAL Architect, IBM.

Re: [TRIVIAL] [PATCH] powerpc/powernv-eeh: Consisely desribe what this file does

2019-05-27 Thread Stewart Smith
Oliver writes: > On Tue, May 28, 2019 at 1:29 PM Stewart Smith wrote: >> >> If the previous comment made sense, continue debugging or call your >> doctor immediately. >> >> Signed-off-by: Stewart Smith >> --- >> arch/powerpc/platforms/powernv

[TRIVIAL] [PATCH] powerpc/powernv-eeh: Consisely desribe what this file does

2019-05-27 Thread Stewart Smith
If the previous comment made sense, continue debugging or call your doctor immediately. Signed-off-by: Stewart Smith --- arch/powerpc/platforms/powernv/eeh-powernv.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/arch/powerpc/platforms/powernv/eeh-powernv.c b/arch

[PATCH] powerpc/powernv: Update firmware archaeology around OPAL_HANDLE_HMI

2019-05-23 Thread Stewart Smith
-off-by: Stewart Smith --- arch/powerpc/platforms/powernv/opal.c | 23 +++ 1 file changed, 15 insertions(+), 8 deletions(-) diff --git a/arch/powerpc/platforms/powernv/opal.c b/arch/powerpc/platforms/powernv/opal.c index f2b063b027f0..89b6ddc3ed38 100644 --- a/arch/powerpc

Re: [PATCH kernel] prom_init: Fetch flatten device tree from the system firmware

2019-05-02 Thread Stewart Smith
ough I guess that many PCI devices is still a little uncommon. A 4 socket POWER8 or POWER9 can easily be that large, and a small test kernel/userspace will boot in ~2.5-4 seconds. So it's possible that the device tree fetch could be surprisingly non-trivial percentage of boot time at least on some machines. -- Stewart Smith OPAL Architect, IBM.

Re: [PATCH] powerpc: config: skiroot: Add (back) MLX5 ethernet support

2019-04-03 Thread Stewart Smith
Carol L Soto >> Suggested-by: Carol L Soto >> Signed-off-by: Stewart Smith >> Signed-off-by: Joel Stanley > > Fixes: cbc39809a398 ("powerpc/configs: Update skiroot defconfig") > > ? Yes. -- Stewart Smith OPAL Architect, IBM.

Re: [PATCH] powerpc/powernv: Make opal log only readable by root

2019-02-26 Thread Stewart Smith
. > > Signed-off-by: Jordan Niethe Yeah, this is a really good idea. Reviewed-by: Stewart Smith -- Stewart Smith OPAL Architect, IBM.

Re: [PATCH] powerpc/powernv: move OPAL call wrapper tracing and interrupt handling to C

2019-02-26 Thread Stewart Smith
is more costly after this, (410ns->430ns on POWER9), but > OPAL calls are generally not performance critical at this scale. At least with this patch we can start to better measure things, and that's a big plus. Also, When I get to start worrying about <1ms OPAL calls, I think we can revisit optimising this path :) -- Stewart Smith OPAL Architect, IBM.

Re: [PATCH] mtd: powernv: SPDX and comment fixups

2019-02-05 Thread Stewart Smith
I kind of wish it'd die rather than spread further. Reviewed-by: Stewart Smith -- Stewart Smith OPAL Architect, IBM.

Re: [PATCH v2] powerpc/perf: Quiet IMC PMU registration message

2018-10-09 Thread Stewart Smith
nitor hardware support registered > > Signed-off-by: Joel Stanley Oh goodness yes. Reviewed-by: Stewart Smith -- Stewart Smith OPAL Architect, IBM.

Re: [PATCH] powerpc/powernv: Make possible for user to force a full ipl cec reboot

2018-09-09 Thread Stewart Smith
l_cec_reboot2(OPAL_REBOOT_FULL_IPL, NULL); > + else > + rc = opal_cec_reboot(); > + If the reboot type isn't supported, what should be the behvaiour? Reboot the default way or don't reboot at all? -- Stewart Smith OPAL Architect, IBM.

Re: [PATCH v6 2/2] hwmon: ibmpowernv: Add attributes to enable/disable sensor groups

2018-07-18 Thread Stewart Smith
r-groups"); > + if (!groups) > + return ret; Why not look for the compatible property? -- Stewart Smith OPAL Architect, IBM.

Re: [PATCH v2 2/2] powerpc: Document issues with TM on POWER9

2018-06-24 Thread Stewart Smith
Michael Neuling writes: > Signed-off-by: Michael Neuling Acked-by: Stewart Smith -- Stewart Smith OPAL Architect, IBM.

Re: [PATCH 2/2] powerpc: Document issues with TM on POWER9

2018-06-22 Thread Stewart Smith
Michael Neuling writes: > +POWER9C DD1.2 and above are only avaliable with POWERNV and hence PowerVM, not POWERNV -- Stewart Smith OPAL Architect, IBM.

Re: [PATCH 1/2] powerpc: Document issues with the DAWR on POWER9

2018-06-22 Thread Stewart Smith
Michael Neuling writes: > Signed-off-by: Michael Neuling > --- > Documentation/powerpc/DAWR-POWER9.txt | 58 +++ > 1 file changed, 58 insertions(+) > create mode 100644 Documentation/powerpc/DAWR-POWER9.txt Acked-by: Stewart Smith -- Stewart Smith

Re: [PATCH] cpuidle:powernv: Make the snooze timeout dynamic.

2018-06-04 Thread Stewart Smith
gt; Fixes: 78eaa10f027c ("cpuidle: powernv/pseries: Auto-promotion of snooze to > deeper idle state") > Cc: sta...@vger.kernel.org # v4.2+ Yes, it's a bug - we had a customer bug because we lacked this that meant we had to do firmware changes rather than just tweaking what stop states were used. -- Stewart Smith OPAL Architect, IBM.

Re: [PATCH] crypto/nx: Initialize 842 high and normal RxFIFO control registers

2018-06-03 Thread Stewart Smith
Haren Myneni writes: > On 06/03/2018 05:41 PM, Stewart Smith wrote: >> Haren Myneni writes: >>> On 06/01/2018 12:41 AM, Stewart Smith wrote: >>>> Haren Myneni writes: >>>>> NX increments readOffset by FIFO size in receive FIFO control register >&g

Re: [PATCH] crypto/nx: Initialize 842 high and normal RxFIFO control registers

2018-06-03 Thread Stewart Smith
Haren Myneni writes: > On 06/01/2018 12:41 AM, Stewart Smith wrote: >> Haren Myneni writes: >>> NX increments readOffset by FIFO size in receive FIFO control register >>> when CRB is read. But the index in RxFIFO has to match with the >>> corresponding entry

Re: [PATCH] crypto/nx: Initialize 842 high and normal RxFIFO control registers

2018-06-01 Thread Stewart Smith
chip_id, pid); > + if (ret) { > + pr_err("Failed to initialize NX coproc: %d\n", ret); > + ret = opal_error_code(ret); > + goto err_out; > + } > + > coproc->ct = VAS_COP_TYPE_842_HIPRI; I think this should be called for all priority queues as it would be at least theoretically possible to only have Normal priority queues, in which case this patch wouldn't fix the problem. -- Stewart Smith OPAL Architect, IBM.

Re: [PATCH] crypto/nx: Initialize 842 high and normal RxFIFO control registers

2018-05-31 Thread Stewart Smith
"rmmod ; insmod" will crash, and possibly even issues over kexec? -- Stewart Smith OPAL Architect, IBM.

Re: [PATCH] cpuidle/powernv : Add Description for cpuidle state

2018-05-28 Thread Stewart Smith
ontinuing on is okay, as we have to keep compatibility with that firmware. > --- a/include/linux/cpuidle.h > +++ b/include/linux/cpuidle.h > @@ -17,7 +17,7 @@ > > #define CPUIDLE_STATE_MAX10 > #define CPUIDLE_NAME_LEN 16 > -#define CPUIDLE_DESC_LEN 32 > +#define CPUIDLE_DESC_LEN 60 Do we really get that long? -- Stewart Smith OPAL Architect, IBM.

Re: [PATCH] powerpc-opal: fix spelling mistake "Uniterrupted" -> "Uninterrupted"

2018-05-27 Thread Stewart Smith
Colin King writes: > From: Colin Ian King > > Trivial fix to spelling mistake in hmi_error_types text > > Signed-off-by: Colin Ian King Reviewed-by: Stewart Smith -- Stewart Smith OPAL Architect, IBM.

Re: [PATCH] cpuidle/powernv : init all present cpus for deep states

2018-05-27 Thread Stewart Smith
that you can answer "where did all my CPUs go?" by looking at the device tree rather than having to know the platform specific way of how guards are stored. -- Stewart Smith OPAL Architect, IBM.

Re: [PATCH] cpuidle/powernv : init all present cpus for deep states

2018-05-16 Thread Stewart Smith
d workloads, if you guard out a CPU core you'll not get WoF, which means that performance goes down when you wouldn't expect it to. Right? -- Stewart Smith OPAL Architect, IBM.

Re: administrivia: mails containing HTML attachments

2018-05-16 Thread Stewart Smith
ment) and, I presume, anyone on > this list is capable of sending no HTML email. certainly one way to get those pesky IBM Verse users off. To be fair, Documentation/process/email-clients.rst also warns them appropriately. I fully support ditching HTML mail. -- Stewart Smith OPAL Architect, IBM.

Re: [Skiboot] [PATCH 1/2] SLW: Remove stop1_lite and stop0 stop states

2018-05-06 Thread Stewart Smith
Michael Ellerman writes: > Stewart Smith writes: > ... >> >> Slightly stupid question: should we be disabling these here or should >> Linux be better and deciding what states to use? >> >> I'm inclined to say this is a Linux problem as it should make th

Re: [Skiboot] [PATCH 1/2] SLW: Remove stop1_lite and stop0 stop states

2018-05-03 Thread Stewart Smith
way around. Replace stop0_lite with snooze. > > So we would have snooze, stop0, stop2, and stop4 and/or 5. Slightly stupid question: should we be disabling these here or should Linux be better and deciding what states to use? I'm inclined to say this is a Linux problem as it should make the decision of what hardware feature to used based on the ones OPAL says *can* be used. I'm also open to be being convinced otherwise though... -- Stewart Smith OPAL Architect, IBM.

Re: [PATCH] cpufreq: powernv: Fix the hardlockup by synchronus smp_call in timer interrupt

2018-04-23 Thread Stewart Smith
uct timer_list *t) > spin_unlock(&gpstates->gpstate_lock); > > /* Timer may get migrated to a different cpu on cpu hot unplug */ > - smp_call_function_any(policy->cpus, set_pstate, &freq_data, 1); > + smp_call_function_any(policy->cpus, set_pstate, &freq_data, 0); > } Should this have: Fixes: eaa2c3aeef83f and CC stable v4.7+ ? -- Stewart Smith OPAL Architect, IBM.

[PATCH] hvc_opal: don't set tb_ticks_per_usec in udbg_init_opal_common()

2018-03-28 Thread Stewart Smith
earlier than we otherwise would have. The "sane default" seems to be adequate for our purposes between udbg_init_opal_common() and time_init() being called, and if it isn't, then we should probably be setting it somewhere that isn't hvc_opal.c! Signed-off-by: Stewart Smith ---

Re: [PATCH] powerpc/powernv/nvram: opal_nvram_write handle unknown OPAL errors

2018-03-28 Thread Stewart Smith
am.c | 2 ++ > 1 file changed, 2 insertions(+) Acked-by: Stewart Smith -- Stewart Smith OPAL Architect, IBM.

Re: [PATCH] powerpc/powernv/mce: Don't silently restart the machine

2018-03-07 Thread Stewart Smith
n the panic() here is the right thing to do no matter what. Reviewed-by: Stewart Smith -- Stewart Smith OPAL Architect, IBM.

Re: [PATCH] cpuidle/powernv : Restore different PSSCR for idle and hotplug

2018-02-25 Thread Stewart Smith
owerpc/powernv/idle: Restore SPRs for deep idle > states via stop API.") This should CC stable ? We'll need this to enable stop11 in firmware and not break things, right? -- Stewart Smith OPAL Architect, IBM.

Re: [PATCH] powerpc/powernv: Turn on SCSI_AACRAID in powernv_defconfig

2018-02-22 Thread Stewart Smith
Michael Ellerman writes: > Brian King writes: >> On 09/03/2017 06:19 PM, Stewart Smith wrote: >>> Michael Ellerman writes: >>>>> 2. On a bare metal machine, if you set ipr.fast_reboot=1 on the skiboot >>>>>kernel, then we should also avoid re

Re: [PATCH v9 1/2] powerpc/powernv: Enable tunneled operations

2018-02-20 Thread Stewart Smith
_PCI_SET_PBCQ_TUNNEL_BAR 163 > +#define OPAL_LAST163 These numbers will change as other calls have gone in with those OPAL API ids. Feel free to send a tiny patch to skiboot reserving some though. I should probably encourage people to do that when they start worki

Re: [RFC] powerpc/powernv/mce: Don't silently restart the machine

2018-02-20 Thread Stewart Smith
e promise though, it's slightly less reliable than one from a politician. I'd say that in this case deferring to policy on what to do in event of panic() is the right thing. -- Stewart Smith OPAL Architect, IBM.

Re: [PATCH v2 (skiboot)] dt: add /cpus/ibm, powerpc-cpu-features device tree bindings

2018-02-20 Thread Stewart Smith
s.c > create mode 100644 doc/device-tree/ibm,powerpc-cpu-features/binding.txt > create mode 100644 > doc/device-tree/ibm,powerpc-cpu-features/design.txt Merged to master as of 7f4c8e8ce0b78ca046643d7f4f63d81f4fd11746 and has made it into -rc4 -- Stewart Smith OPAL Architect, IBM.

Re: rtc-opal: Fix handling of firmware error codes, prevent busy loops

2018-02-05 Thread Stewart Smith
Alexandre Belloni writes: > On 02/08/2016 at 11:50:16 +1000, Stewart Smith wrote: >> According to the OPAL docs: >> https://github.com/open-power/skiboot/blob/skiboot-5.2.5/doc/opal-api/opal-rtc-read-3.txt >> https://github.com/open-power/skiboot/blob/skiboot-5.2.5/doc/opal

Re: [PATCH 3/5] powerpc: Reduce log level of "OPAL detected !" message

2018-01-15 Thread Stewart Smith
Benjamin Herrenschmidt writes: > This message isn't terribly useful. > > Signed-off-by: Benjamin Herrenschmidt Acked-by: Stewart Smith > --- a/arch/powerpc/platforms/powernv/opal.c > +++ b/arch/powerpc/platforms/powernv/opal.c > @@ -127,7 +127,7 @@ int __init early_ini

Re: [PATCH] powerpc/powernv : Add support to enable sensor groups

2017-12-03 Thread Stewart Smith
eneric > sensors > API. And also we dont export all type of sensors in HWMON as not all of them > are > environment sensors (like performance). Are there barriers to adding such concepts to the generic sensors API? -- Stewart Smith OPAL Architect, IBM.

Re: [PATCH] powerpc/powernv: Add kernel cmdline parameter to disable imc

2017-10-12 Thread Stewart Smith
Anju T Sudhakar writes: > On Wednesday 11 October 2017 01:55 AM, Stewart Smith wrote: >> Michael Ellerman writes: >>> Anju T Sudhakar writes: >>> >>>> Add a kernel command line parameter option to disable In-Memory Collection >>>> (IMC)

Re: [PATCH] powerpc/powernv: Add kernel cmdline parameter to disable imc

2017-10-10 Thread Stewart Smith
.ozlabs.org/patch/823249/ would fix the firmware implementation where the counters were already running before the INIT/START calls, which are likely the cause of the problems that this patch is trying to work around. I propose we have the firmware do the right thing and nothing special in kernel.

Re: [PATCH] powernv: Add OCC driver to mmap sensor area

2017-10-01 Thread Stewart Smith
sensors to Linux: the OPAL_SENSOR API and the IMC API. Why this method and not use the existing ones? -- Stewart Smith OPAL Architect, IBM.

[PATCH] drivers: of: increase MAX_RESERVED_REGIONS to 32

2017-09-26 Thread Stewart Smith
devices with "memory-region" properties. A more future-proof fix is likely possible, although more invasive and this simple fix is perfectly suitable in the meantime while a more future-proof fix is developed. Signed-off-by: Stewart Smith --- drivers/of/of_reserved_mem.c | 2 +- 1 f

Re: [PATCH] drivers: of: static DT reservations incorrectly added to dynamic list

2017-09-26 Thread Stewart Smith
Rob Herring writes: > On Thu, Sep 14, 2017 at 5:24 AM, Stewart Smith > wrote: >> There are two types of memory reservations firmware can ask the kernel >> to make in the device tree: static and dynamic. >> See Documentation/devicetree/bindings/reserved-memory/reserved

[PATCH] drivers: of: static DT reservations incorrectly added to dynamic list

2017-09-14 Thread Stewart Smith
is a perfectly valid thing to do (although I have not checked every real world device tree on the planet for this condition) Fixes: 3f0c8206644836e4f10a6b9fc47cda6a9a372f9b Signed-off-by: Stewart Smith --- NOTE: I've done only fairly limited testing of this on POWER, I certainly haven't

Re: [PATCH] powerpc/powernv: Turn on SCSI_AACRAID in powernv_defconfig

2017-09-03 Thread Stewart Smith
h booting bare metal is where I see it (not using ipr.fast_reboot). Hrm... We should probably enable that by default for petitboot then. It'd at least cut some time off booting straight through to OS. -- Stewart Smith OPAL Architect, IBM.

Re: [PATCH] powerpc/powernv: Turn on SCSI_AACRAID in powernv_defconfig

2017-08-31 Thread Stewart Smith
. > I think the majority of machines that have one of these adapters will be > using it for their root disk, so I think the slow initialisation is just > something we have to suffer. It does seem that way currently. -- Stewart Smith OPAL Architect, IBM.

Re: [PATCH V8 1/3] powernv: powercap: Add support for powercap framework

2017-07-28 Thread Stewart Smith
thing, you *could* go and set a differnt powercap 180 times concurrently and we should do the right thing in skiboot... but then you're sitting in skiboot rather than sitting in linux being able to go run some other task on the thread. -- Stewart Smith OPAL Architect, IBM.

Re: [PATCH 2/2] mtd: powernv_flash: Lock around concurrent access to OPAL

2017-07-17 Thread Stewart Smith
get back to the work you're meant to be doing" :) -- Stewart Smith OPAL Architect, IBM.

Re: [Skiboot] [RFC PATCH] powerpc/powernv: report error messages from opal

2017-07-06 Thread Stewart Smith
Michael Ellerman writes: > Stewart Smith writes: >> Oliver O'Halloran writes: >>> diff --git a/arch/powerpc/include/asm/opal-api.h >>> b/arch/powerpc/include/asm/opal-api.h >>> index 0e2e57bcab50..cb9c0e6afb33 100644 >>> --- a/arch/powerpc/inc

Re: [RFC PATCH] powerpc/powernv: report error messages from opal

2017-07-05 Thread Stewart Smith
along with the skiboot thoughts), I don't like the SCRAPE_LOG name so much, as it's more of a "hey linux, here's some log messages from firmware, possibly before you were involved"... OPAL_FETCH_LOG ? -- Stewart Smith OPAL Architect, IBM.

Re: [PATCH] powerpc: Invalidate ERAT on powersave wakeup for POWER9

2017-06-22 Thread Stewart Smith
causing a problem. > > Signed-off-by: Michael Neuling CC: stable? -- Stewart Smith OPAL Architect, IBM.

Re: [PATCH v8 07/10] powerpc/perf: PMU functions for Core IMC and hotplugging

2017-05-17 Thread Stewart Smith
detect that and we'd fail silently by overwriting memory. -- Stewart Smith OPAL Architect, IBM.

Re: [PATCH v8 05/10] powerpc/perf: IMC pmu cpumask and cpuhotplug support

2017-05-11 Thread Stewart Smith
n OPAL_IMC_COUNTERS_INIT should return OPAL_SUCCESS and just do nothing. This future proofs everything, and the API is that one *must* call _INIT before start. -- Stewart Smith OPAL Architect, IBM.

Re: [PATCH v8 02/10] powerpc/powernv: Autoload IMC device driver module

2017-05-11 Thread Stewart Smith
ame(rm_node, "ibm,homer-image"); dn; > + dn = of_find_node_by_name(dn, "ibm,homer-image")) { > + > + /* Get the chip id to which the above homer region belongs to */ > + if (of_property_read_u32(dn, "ibm,chip-id", &chip_id)) > + goto err; So, I was thinking on this (and should probably comment on the firmware side as well). I'd prefer an OPAL interface where instead of looking up where ibm,homer-image is, we provide the kernel with a base address and then have offsets into it. That way, we don't tie the kernel code to counters that are only in the HOMER region. -- Stewart Smith OPAL Architect, IBM.

Re: [PATCH v6 01/11] powerpc/powernv: Data structure and macros definitions

2017-04-06 Thread Stewart Smith
unplug CPUs, but we're not doing that from a hardware level, what CPUs you get in the DT on PowerNV on boot is all you're getting. -- Stewart Smith OPAL Architect, IBM.

Re: [PATCH v6 03/11] powerpc/powernv: Detect supported IMC units and its events

2017-04-06 Thread Stewart Smith
ible node under the top level ibm,opal-in-memory-counters node? (i'm not convinced that having ibm,ibmc-counters-nest versus ibm,imc-counters-core and ibm,imc-counters-thread as I see in the dts is correct though, as they're all accessed exactly the same way?) -- Stewart Smith OPAL Architect, IBM.

Re: [PATCH v6 01/11] powerpc/powernv: Data structure and macros definitions

2017-04-06 Thread Stewart Smith
256 Why do we need a max length? We get the actual lengths from the device tree, so we know at each point in time what the length of any new string should be, right? Otherwise you appear to be, in the general case, using 10x the memory than you could. -- Stewart Smith OPAL Architect, IBM.

Re: [PATCH v6 02/11] powerpc/powernv: Autoload IMC device driver module

2017-04-06 Thread Stewart Smith
if (of_property_read_string_index(child, "name", 0, > + &node_name)) > + continue; > + if (strncmp("ibm,homer-image", node_name, > + strlen("ibm,homer-image"))) > + continue; A better way to do this would be to reference the memory region, like what's shown in Documentation/devicetree/bindings/reserved-memory/reserved-memory.txt just reference the phandle of the memory region. seeing as these are per chip, why not just have something linking together chip-id and the IMC layout node? -- Stewart Smith OPAL Architect, IBM.

Re: [PATCH 4/5] crypto/nx: Add P9 NX support for 842 compression engine.

2017-04-02 Thread Stewart Smith
e should provide a 'ibm,vas' compatible node, rather than simply searching through all the ibm,xscom nodes. XSCOMs aren't something that Linux should really know about, it's a debug interface, and one we use through PRD to do PRD-things, XSCOMs aren't part of the architecture. -- Stewart Smith OPAL Architect, IBM.

Re: [Skiboot] [PATCH][OPAL] cpufeatures: add base and POWER8, POWER9 /cpus/features dt

2017-03-23 Thread Stewart Smith
Nicholas Piggin writes: > On Tue, 21 Mar 2017 15:42:22 +1100 > Stewart Smith wrote: > >> Nicholas Piggin writes: >> > With this patch and the Linux one, I can boot (in mambo) a POWER8 or >> > POWER9 without looking up any cpu tables, and mainly lo

Re: [Skiboot] [PATCH][OPAL] cpufeatures: add base and POWER8, POWER9 /cpus/features dt

2017-03-20 Thread Stewart Smith
0644 > --- a/hdata/cpu-common.c > +++ b/hdata/cpu-common.c > + { "vector-crypto", > + CPU_ALL, > + ISA_BASE, USABLE_HV|USABLE_OS|USABLE_PR, > + HV_SUPPORT_NONE, OS_SUPPORT_NONE, > + -1, -1, 38, > + "vector", }, Did we want to break this down at all? Specifically maybe just the AES instructions? AFAIK it's been the only set where there was some amount of discussion about somebody possibly not wanting to include. -- Stewart Smith OPAL Architect, IBM.

Re: [PATCH v2] powernv/opal: Handle OPAL_WRONG_STATE error from OPAL fails

2017-02-28 Thread Stewart Smith
d\n", __func__, rc); > + pr_err("%s: Unexpected OPAL error %d\n", __func__, rc); Do we need this? -- Stewart Smith OPAL Architect, IBM.

Re: [Patch v4] powerpc/powernv: add hdat attribute to sysfs

2017-02-28 Thread Stewart Smith
; +{ > + if (!hdat_info.base) > + return -ENODEV; > + > + return memory_read_from_buffer(to, count, &pos, hdat_info.base, > + hdat_info.size); > +} > + > +/* HDAT attribute for sysfs */ > +static struct bin_attribute hdat_attr = { > + .attr = {.name = "hdat", .mode = 0400}, > + .read = hdat_read > +}; Why not BIN_ATTR_RO (like opal_export_symmap() does) ? (I have comments/thoughts on the OPAL side as well) -- Stewart Smith OPAL Architect, IBM.

Re: [PATCH] powernv/opal: Handle OPAL_WRONG_STATE error from OPAL fails

2017-02-22 Thread Stewart Smith
Michael Ellerman writes: > Stewart Smith writes: > >> Vipin K Parashar writes: >>> On Monday 13 February 2017 06:13 AM, Michael Ellerman wrote: >>>> Vipin K Parashar writes: >>>> >>>>> OPAL returns OPAL_WRONG_STATE for XSCOM operat

Re: [RFC] Remove memory from nodes for memtrace.

2017-02-22 Thread Stewart Smith
Rashmica Gupta writes: > +} > +machine_device_initcall(powernv, memtrace_init); > + > + > + > +/* XXX FIXME DEBUG CRAP */ > +machine_device_initcall(pseries, memtrace_init); Should the fixme be there? -- Stewart Smith OPAL Architect, IBM.

Re: [PATCH] powernv/opal: Handle OPAL_WRONG_STATE error from OPAL fails

2017-02-15 Thread Stewart Smith
WARE if they didn't. This doesn't provide information about >> why >> the operation failed, such as if the CPU happens to be asleep. >> >> This is specifically useful in error scanning, so if every CPU is being >> scanned for errors,

Re: [PATCHv3 4/4] MAINTAINERS: Remove powerpc's opal match

2017-02-15 Thread Stewart Smith
missing some code, what about this instead: Remove OPAL regex in powerpc to avoid false match Signed-off-by: Stewart Smith --- MAINTAINERS |8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 3960e7f..25ed25a 100644 --- a/MAINTAINERS +++

Re: [PATCH 2/2] powerpc/powernv/opal-dump : Use IRQ_HANDLED instead of numbers in interrupt handler

2017-02-14 Thread Stewart Smith
9 +++-- > 1 file changed, 3 insertions(+), 6 deletions(-) Should also have: Fixes: 8034f715f ("powernv/opal-dump: Convert to irq domain") ? -- Stewart Smith OPAL Architect, IBM.

Re: [PATCH 1/2] powerpc/powernv/opal-dump : Handles opal_dump_info properly

2017-02-14 Thread Stewart Smith
--- > 1 file changed, 6 insertions(+), 3 deletions(-) Acked-by: Stewart Smith -- Stewart Smith OPAL Architect, IBM.

Re: [PATCH] powernv/opal: Handle OPAL_WRONG_STATE error from OPAL fails

2017-02-14 Thread Stewart Smith
ren't the cause of failures. > > So, return OPAL_WRONG_STATE in xscom_read and xscom_write if the CPU is > sleeping. > > Signed-off-by: Russell Currey > Reviewed-by: Alistair Popple > Signed-off-by: Stewart Smith > > > > So I'm still not

Re: [PATCH RFC] powerpc/powernv: sysfs entry to force full IPL reboot

2016-12-22 Thread Stewart Smith
/firmware/opal/force_full_ipl_reboot. On versions of skiboot that > implement the OPAL_REBOOT_FULL_IPL reboot type, this will force an IPL. On > versions that do not, print an error message on reboot and proceed with a > regular reboot (which could be a full IPL or a fast reboot). > > Cc

Re: [PATCH RFC] powerpc/powernv: sysfs entry to force full IPL reboot

2016-12-22 Thread Stewart Smith
; broken" workaround, so you're going to want to set it permanently until > you update your firmware. The only real world application I can see wanting to do that is perhaps HTX - where it chooses what kind of bootme run it wants. So, well, for certain definitions of "real world". -- Stewart Smith OPAL Architect, IBM.

Re: [PATCH 2/2] powernv: Pass PSSCR value and mask to power9_idle_stop

2016-10-11 Thread Stewart Smith
; > } > } > > > > Is this approach ok ? What if we just treat the 0xF state from firmware as special and set it to DEFAULT_PSSCR_MASK in that case? That deals with old skiboot, new kernel, and sets a pretty small special case that's easy to track into the future as something we should watch out for. Additionally, if we make skiboot set sane values in ~DEFAULT_PSSCR_MASK for valid fields in PSSCR on boot/(also kexec?), then we should end up in a situation where everything works with everything (even if you don't get the best power saving). Specifically, new skiboot, old kernel... but it looks like there's nothing currently missing there Should this patch also have Fixes: 3005c597ba4 and CC to stable? -- Stewart Smith OPAL Architect, IBM.

Re: [PATCH] powernv: Search for new flash DT node location

2016-09-26 Thread Stewart Smith
t; Quite :) > >> If we really just want to find compatible nodes anywhere, let's simplify i2c >> and pdev_init into one function and make that behavior consistent with this >> new patch. > > That seems OK to me. > > We should get an ack from Stewart though for t

Re: [PATCH 1/4] dt-bindings: add doc for ibm,hotplug-aperture

2016-08-10 Thread Stewart Smith
ocumentation/devicetree/bindings/powerpc/opal/hotplug-aperture.txt Forgive me for being absent on the whole discussion here, but is this an OPAL specific binding? If so, shouldn't the docs also appear in the skiboot tree? -- Stewart Smith OPAL Architect, IBM.

Re: [PATCH v2 3/3] powernv: Fix MCE handler to avoid trashing CR0/CR1 registers.

2016-08-03 Thread Stewart Smith
eport) it seems as though in a test where one injects continuous SLB Multi Hit errors, this bug could lead to rebooting "due to to Platform error" rather than continuing to recover successfully. It might be a good idea to mention that in commit message here. Also, should this go to sta

[PATCH] rtc-opal: Fix handling of firmware error codes, prevent busy loops

2016-08-01 Thread Stewart Smith
cold" to the BMC, the result of that being that we'd get stuck in an infinite loop in opal_get_rtc_time. We now retry a few times before returning the error higher up the stack. Cc: sta...@vger.kernel.org Signed-off-by: Stewart Smith --- drivers/rtc/rtc-opal.c | 12 ++-- 1 f

Re: [RFC 0/3] extend kexec_file_load system call

2016-07-13 Thread Stewart Smith
e an additional step of signing it, since the running kernel already > trusts it. - using current view of the hardware, flattened into a new dtb. This should already be trusted, as it's what we're running now (boot + runtime changes) -- Stewart Smith OPAL Architect, IBM. ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [RFC 0/3] extend kexec_file_load system call

2016-07-13 Thread Stewart Smith
Ard Biesheuvel writes: > On 13 July 2016 at 09:36, Russell King - ARM Linux > wrote: >> On Wed, Jul 13, 2016 at 02:59:51PM +1000, Stewart Smith wrote: >>> Russell King - ARM Linux writes: >>> > On Tue, Jul 12, 2016 at 10:58:05PM +0200, Petr Tesarik wrote: >

Re: [RFC 0/3] extend kexec_file_load system call

2016-07-13 Thread Stewart Smith
Russell King - ARM Linux writes: > On Wed, Jul 13, 2016 at 02:59:51PM +1000, Stewart Smith wrote: >> Russell King - ARM Linux writes: >> > On Tue, Jul 12, 2016 at 10:58:05PM +0200, Petr Tesarik wrote: >> >> I'm not an expert on DTB, so I can't provide an

Re: [RFC 0/3] extend kexec_file_load system call

2016-07-12 Thread Stewart Smith
Our bootloader is a linux kernel and initramfs with a UI (petitboot) - this means we never have to write a device driver twice: write a kernel one and you're done (for booting from the device and using it in your OS). -- Stewart Smith OPAL Architect, IBM.

Re: [PATCH 1/2] crypto: vmx - Adding asm subroutines for XTS

2016-07-12 Thread Stewart Smith
ps://people.gnome.org/~markmc/openssl-and-the-gpl.html has an explanation and points to: https://www.openssl.org/docs/faq.html#LEGAL2 which makes it anything but clearer. it appears the answer is "probably not, unless you have an explicit exemption in your license" -- Stewart Smith OPA

Re: [RFC 0/3] extend kexec_file_load system call

2016-07-12 Thread Stewart Smith
tboot was configured to use (i.e., set the /chosen/linux,stdout-path >> property). It also modifies the device tree to allow the kernel to inherit >> Petitboot's Openfirmware framebuffer. > > Can some of this be done with the help of kernel command line options for > second kernel? how would this be any more secure? Passing in an address for a framebuffer via command line option means you could scribble over any bit of memory, which is the same kind of damage you could do by modifying the device tree. -- Stewart Smith OPAL Architect, IBM. ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [RFC 0/3] extend kexec_file_load system call

2016-07-12 Thread Stewart Smith
eeds to work out which console is being interacted with in order to set up /chosen/linux,stdout-path correctly. This specific option could be passed as a kernel command line to the next kernel, yes. However, isn't the kernel command line also an attack vector? Is *every* command line o

Re: [PATCH 01/14] powerpc/powernv: Add XICS emulation APIs

2016-07-11 Thread Stewart Smith
> Signed-off-by: Benjamin Herrenschmidt These OPAL calls have the correct OPAL API numbers and they've been assigned upstream in skiboot. Acked-by: Stewart Smith -- Stewart Smith OPAL Architect, IBM. ___ Linuxppc-dev mailing list Li

Re: [PATCH V5 2/3] powerpc/opal: Add inline function to get rc from an ASYNC_COMP opal_msg

2016-06-29 Thread Stewart Smith
ise (including if above change is made) Acked-by: Stewart Smith -- Stewart Smith OPAL Architect, IBM. ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH v2] powerpc/boot: Add OPAL console to epapr wrappers

2016-06-26 Thread Stewart Smith
"raw" type of > OPAL console is supported, however machines that provide a hvsi console > also provide a raw console so this is not an issue in practice. > > Actually-written-by: Benjamin Herrenschmidt > Signed-off-by: Oliver O'Halloran > Cc: Stewart Smith > Cc: s

Re: [PATCH, RFC] cxl: Add support for CAPP DMA mode

2016-06-08 Thread Stewart Smith
ch was submitted here: > http://patchwork.ozlabs.org/patch/625582/ Merged to skiboot as of 5477148a439fda9fb55ea4a828c958fcdcc10f2e - which will make it into skiboot 5.3.x -- Stewart Smith OPAL Architect, IBM. ___ Linuxppc-dev mailing list Linux

Re: [PATCH, RFC] cxl: Add support for CAPP DMA mode

2016-06-08 Thread Stewart Smith
igher. This could be something we start doing - there's enough random bits of functionality we could tell the user exactly what they have to upgrade to to have work. -- Stewart Smith OPAL Architect, IBM. ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: powerpc/nvram: Fix an incorrect partition merge

2016-06-06 Thread Stewart Smith
mat NVRAM when it's corrupted. This is also true for NVRAM for PowerNV (not just pseries guest). -- Stewart Smith OPAL Architect, IBM. ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

[PATCH] Clarify that adde is an instruction and we mean plural

2016-05-22 Thread Stewart Smith
Signed-off-by: Stewart Smith --- arch/powerpc/lib/checksum_64.S | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/arch/powerpc/lib/checksum_64.S b/arch/powerpc/lib/checksum_64.S index 8e6e510..fdec6e6 100644 --- a/arch/powerpc/lib/checksum_64.S +++ b/arch/powerpc

Re: [PATCH 0030/1529] Fix typo

2016-05-22 Thread Stewart Smith
> -- comapatible: Should be "ibm,opal-rtc" > +- compatible: Should be "ibm,opal-rtc" > > Optional properties: > - wakeup-source: Decides if the wakeup is supported or not Acked-by: Stewart Smith -- Stewart Smith OPAL Architect, IBM.

Re: [PATCH V2 1/2] devicetree/bindings: Add binding for operator panel on FSP machines

2016-04-26 Thread Stewart Smith
PAL. With a slight change to the commit message, Acked-by: Stewart Smith -- Stewart Smith OPAL Architect, IBM. ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH v2 2/2] cpufreq: powernv: Ramp-down global pstate slower than local-pstate

2016-04-20 Thread Stewart Smith
e that this is computed from? > +/* Interval after which the timer is queued to bring down global pstate */ > +#define GPSTATE_TIMER_INTERVAL 2000 in ms? -- Stewart Smith OPAL Architect, IBM. ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

  1   2   3   >