Re: [PATCH v4 4/8] KVM: PPC: Ultravisor: Use UV_WRITE_PATE ucall to register a PATE

2019-07-17 Thread Ryan Grimm
gt; > Both partition tables will have PATE entries for HV and normal > > virtual > > Can you expand novel acronyms on their first usage please, ie. PATE. > Agreed. This confused me a while ago. It is "Partition Table Entry", correct? > > machines. > >

[PATCH] CXL: Fix device_node reference counting

2015-01-28 Thread Ryan Grimm
] [c0009258] syscall_exit+0x0/0x98 We are missing a call to of_node_get. pnv_pci_to_phb_node should call of_node_get otherwise np's reference count isn't incremented and it might go away. Rename pnv_pci_to_phb_node to pnv_pci_get_phb_node so it's clear it calls of_node_get. Signed-off

Re: [PATCH] CXL: Fix device_node reference counting

2015-01-28 Thread Ryan Grimm
On 01/28/2015 12:53 AM, Ian Munsie wrote: Excerpts from Michael Ellerman's message of 2015-01-28 16:04:40 +1100: I just wanted to check the status of this one? I can't see it in your tree and wanted to make sure you didn't simply miss it. It looked fishy, but I never got around to replying. T

[PATCH 3/4] CXL: Enable CAPP recovery

2015-01-19 Thread Ryan Grimm
Turning snoops on is the last step in CAPP recovery. Sapphire is expected to have reinitialized the PHB and done the previous recovery steps. Add mode argument to opal call to do this. Driver can turn snoops off although it does not currently. Signed-off-by: Ryan Grimm --- arch/powerpc

[PATCH 4/4] CXL: Add ability to reset the card

2015-01-19 Thread Ryan Grimm
ays are preserved which then can be read through debugfs. PERST also triggers CAPP recovery. An HMI comes in, which is handled by EEH. EEH unbinds the driver, calls into Sapphire to reinitialize the PHB, then rebinds the driver. Signed-off-by: Ryan Grimm --- Documentation/ABI/testing/sysfs-class

[PATCH 2/4] CXL: Add image control to sysfs

2015-01-19 Thread Ryan Grimm
to the pcie slot is required to load the image. "user" loads the user provided image and "factory" loads the factory image upon PERST. sysfs updates the cxl struct in the driver then calls cxl_update_image_control to write the vals in the VSEC. Signed-off-by: Rya

[PATCH 1/4] CXL: Use image state defaults for reloading FPGA

2015-01-19 Thread Ryan Grimm
. cxl_update_image_control writes these bits into the VSEC. Signed-off-by: Ryan Grimm --- Please consider this patch for stable. Without these defaults, the card could get in a bad state and require a power cycle to the box. drivers/misc/cxl/cxl.h | 1 + drivers/misc/cxl/pci.c | 42

Re: [PATCH 1/4] CXL: Use image state defaults for reloading FPGA

2015-01-19 Thread Ryan Grimm
On 01/19/2015 12:03 AM, Ian Munsie wrote: Acked-by: Ian Munsie Looks like you forgot your Signed-off-by line - mpe, do you want Ryan to resend the whole patch (maybe with the below explanation included), or just reply with a Signed-off-by? OK resending. -Ryan This would also be good to CC

[PATCH 4/4] CXL: Add ability to reset the card

2015-01-16 Thread Ryan Grimm
ays are preserved which then can be read through debugfs. PERST also triggers CAPP recovery. An HMI comes in, which is handled by EEH. EEH unbinds the driver, calls into Sapphire to reinitialize the PHB, then rebinds the driver. Signed-off-by: Ryan Grimm --- Documentation/ABI/testing/sysfs-class

[PATCH 3/4] CXL: Enable CAPP recovery

2015-01-16 Thread Ryan Grimm
Turning snoops on is the last step in CAPP recovery. Sapphire is expected to have reinitialized the PHB and done the previous recovery steps. Add mode argument to opal call to do this. Driver can turn snoops off although it does not currently. Signed-off-by: Ryan Grimm --- arch/powerpc

[PATCH 2/4] CXL: Add image control to sysfs

2015-01-16 Thread Ryan Grimm
load_image_on_perst identifies whether a PERST will cause the image to be flashed to the card. And if so, which image. Valid entries are: "none", "user" and "factory". A value of "none" means PERST will not cause the image to be flashed. A power cycle to the pcie slot is required to load the im

[PATCH 1/4] CXL: Use image state defaults for reloading FPGA

2015-01-16 Thread Ryan Grimm
Select defaults such that a PERST causes flash image reload. Select which image based on what the card is set up to load. CXL_VSEC_PERST_LOADS_IMAGE selects whether PERST assertion causes flash image load. CXL_VSEC_PERST_SELECT_USER selects which image is loaded on the next PERST. cxl_update_im

Re: [PATCH 3/3] CXL: Add ability to reset the card

2015-01-16 Thread Ryan Grimm
On 01/15/2015 11:27 PM, Ian Munsie wrote: Hi Ryan, Excerpts from Ryan Grimm's message of 2015-01-16 09:27:17 +1100: Adds reset to sysfs which will PERST the card. If load_image_on_perst is set to "user" or "factory", the PERST will cause that image to be loaded. load_image_on_perst is set to

Re: [PATCH 1/3] CXL: Add image control to sysfs

2015-01-16 Thread Ryan Grimm
On 01/15/2015 11:15 PM, Ian Munsie wrote: Hi Ryan, Excerpts from Ryan Grimm's message of 2015-01-16 09:27:15 +1100: reset_image_select identifies whether a PERST will cause the image to be s/reset_image_select/load_image_on_perst/ Ah, thanks, fixed. +What: /sys/class/cxl//load_

[PATCH 3/3] CXL: Add ability to reset the card

2015-01-15 Thread Ryan Grimm
ays are preserved which then can be read through debugfs. PERST also triggers CAPP recovery. An HMI comes in, which is handled by EEH. EEH unbinds the driver, calls into Sapphire to reinitialize the PHB, then rebinds the driver. Signed-off-by: Ryan Grimm --- Documentation/ABI/testing/sysfs-cla

[PATCH 2/3] CXL: Enable CAPP recovery

2015-01-15 Thread Ryan Grimm
Turning snoops on is the last step in CAPP recovery. Sapphire is expected to have reinitialized the PHB and done the previous recovery steps. Add mode argument to opal call to do this. Driver can turn snoops off although it does not currently. Signed-off-by: Ryan Grimm --- arch/powerpc

[PATCH 1/3] CXL: Add image control to sysfs

2015-01-15 Thread Ryan Grimm
to the pcie slot is required to load the image. "user" loads the user provided image and "factory" loads the factory image upon PERST. sysfs updates the cxl struct in the driver then calls cxl_update_image_control to write the vals in the VSEC. Signed-off-by: Ryan Grimm --- Doc

Re: [PATCH 3/3] CXL: Add reset to sysfs

2015-01-15 Thread Ryan Grimm
On 01/15/2015 12:42 AM, Ian Munsie wrote: Excerpts from Ryan Grimm's message of 2015-01-15 13:56:41 +1100: This allows an image to be downloaded to the flash without rebooting the machine. The driver perform a PERST, which results in FPGA image downloaded to flash and the CAPP unit enters recov

Re: [PATCH 2/3] CXL: Snoop control

2015-01-15 Thread Ryan Grimm
On 01/15/2015 12:16 AM, Ian Munsie wrote: Excerpts from Ryan Grimm's message of 2015-01-15 13:56:40 +1100: Add mode to opal call. SNOOP control turns CAPP unit snooping on/off. This is needed for the following reset patch, which turns snoops off in the CAPP recovery path. Looking at patch 3

Re: [PATCH 1/3] CXL: Add image control to sysfs

2015-01-15 Thread Ryan Grimm
Ian, Thanks for reviewing! On 01/14/2015 11:41 PM, Ian Munsie wrote: Excerpts from Ryan Grimm's message of 2015-01-15 13:56:39 +1100: Add reset_loads_image and reset_image_select to sysfs. reset_image_select identifies which image will be loaded to the card on the next PERST. Valid entries a

[PATCH 3/3] CXL: Add reset to sysfs

2015-01-14 Thread Ryan Grimm
be used by hand for debugging purposes. Signed-off-by: Ryan Grimm --- Documentation/ABI/testing/sysfs-class-cxl | 6 + drivers/misc/cxl/cxl.h| 1 + drivers/misc/cxl/pci.c| 38 +-- drivers/misc/cxl/sysfs.c

[PATCH 2/3] CXL: Snoop control

2015-01-14 Thread Ryan Grimm
Add mode to opal call. SNOOP control turns CAPP unit snooping on/off. This is needed for the following reset patch, which turns snoops off in the CAPP recovery path. Signed-off-by: Ryan Grimm --- arch/powerpc/include/asm/opal.h | 12 arch/powerpc/include/asm/pnv-pci.h

[PATCH 1/3] CXL: Add image control to sysfs

2015-01-14 Thread Ryan Grimm
image load. A power cycle is required to load the image. Value of 1 means PERST will cause image load. sysfs updates the cxl struct in the driver then calls cxl_update_image_control to write the vals in the VSEC. Signed-off-by: Ryan Grimm --- Documentation/ABI/testing/sysfs-class-cxl | 15 ++