Re: [PATCH 10/12] lguest: Only descend into lguest directory when CONFIG_LGUEST is set

2016-06-20 Thread Rusty Russell
"Andrew F. Davis" writes: > When CONFIG_LGUEST is not set make will still descend into the lguest > directory but nothing will be built. This produces unneeded build > artifacts and messages in addition to slowing the build. Fix this here. > > Signed-off-by: Andrew F. Davis > --- > drivers/Makef

Re: [PATCH 0/4] support for text-relative kallsyms table

2016-01-26 Thread Rusty Russell
Ard Biesheuvel writes: > On 21 January 2016 at 07:45, Ard Biesheuvel wrote: >> On 21 January 2016 at 06:10, Rusty Russell wrote: >>> Ard Biesheuvel writes: >>>> This implements text-relative kallsyms address tables. This was developed >>>&g

Re: [PATCH 0/4] support for text-relative kallsyms table

2016-01-20 Thread Rusty Russell
Ard Biesheuvel writes: > This implements text-relative kallsyms address tables. This was developed > as part of my series to implement KASLR/CONFIG_RELOCATABLE for arm64, but > I think it may be beneficial to other architectures as well, so I am > presenting it as a separate series. Nice work! A

Re: [PATCH v2 0/6] kernel/cpu.c: eliminate some indirection

2015-10-17 Thread Rusty Russell
Rasmus Villemoes writes: > On Tue, Oct 06 2015, Rasmus Villemoes wrote: > >> v2: fix build failure on ppc, add acks. > > Does anyone want to take these through their tree? I think the x86 tree is the least illogical place, unless akpm wants it? Cheers, Rusty. ___

Re: Build regressions/improvements in v4.1-rc1

2015-04-28 Thread Rusty Russell
Geert Uytterhoeven writes: >> Can't see that one with a simple grep: can you post warning? > > /home/kisskb/slave/src/arch/tile/kernel/setup.c: In function > 'zone_sizes_init': > /home/kisskb/slave/src/arch/tile/kernel/setup.c:777:3: warning: > passing argument 2 of 'cpumask_test_cpu' from incomp

Re: Build regressions/improvements in v4.1-rc1

2015-04-27 Thread Rusty Russell
Geert Uytterhoeven writes: > On Mon, Apr 27, 2015 at 11:51 AM, Geert Uytterhoeven > wrote: >> Below is the list of build error/warning regressions/improvements in >> v4.1-rc1[1] compared to v4.0[2]. >> >> Summarized: >> - build errors: +34/-11 >> - build warnings: +135/-163 >> >> As I haven't

Re: [PATCH] mm: kill kmemcheck

2015-03-11 Thread Rusty Russell
Sasha Levin writes: > As discussed on LSF/MM, kill kmemcheck. Damn: I literally added CONFIG_KMEMCHECK support to virtio yesterday! Will try Kasan now. Thanks for the heads-up, Rusty. ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https:/

[PATCH 2/2] cxl: allow example memcpy driver to be compiled as a module.

2015-02-09 Thread Rusty Russell
Requires fixing one typo. Signed-off-by: Rusty Russell --- drivers/misc/Kconfig | 2 +- drivers/misc/cxl-memcpy.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig index 5262514..f778497 100644 --- a/drivers/misc/Kconfig

[PATCH 1/2] cxl: export symbols required for modules to use the API.

2015-02-09 Thread Rusty Russell
Signed-off-by: Rusty Russell --- drivers/misc/cxl/api.c | 11 ++- drivers/misc/cxl/vphb.c | 1 + 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/misc/cxl/api.c b/drivers/misc/cxl/api.c index c7263ed..95d7b67 100644 --- a/drivers/misc/cxl/api.c +++ b/drivers/misc

[PATCH 2/3] module: remove mod arg from module_free, rename module_memfree().

2015-01-07 Thread Rusty Russell
Nothing needs the module pointer any more, and the next patch will call it from RCU, where the module itself might no longer exist. Removing the arg is the safest approach. This just codifies the use of the module_alloc/module_free pattern which ftrace and bpf use. Signed-off-by: Rusty Russell

RE: [RFC PATCH 0/2] powerpc: CR based local atomic operation implementation

2014-12-18 Thread Rusty Russell
David Laight writes: > From: Rusty Russell >> David Laight writes: >> > From: Madhavan Srinivasan [mailto:ma...@linux.vnet.ibm.com] >> > ... >> >> >>> I also wonder if it is possible to inspect the interrupted >> >> >>> code t

RE: [RFC PATCH 0/2] powerpc: CR based local atomic operation implementation

2014-12-17 Thread Rusty Russell
David Laight writes: > From: Madhavan Srinivasan [mailto:ma...@linux.vnet.ibm.com] > ... >> >>> I also wonder if it is possible to inspect the interrupted >> >>> code to determine the start/end of the RAS block. >> >>> (Easiest if you assume that there is a single 'write' instruction >> >>> as the

Re: [PATCH V4 0/2] mm: FAULT_AROUND_ORDER patchset performance data for powerpc

2014-05-20 Thread Rusty Russell
"Kirill A. Shutemov" writes: > Andrew Morton wrote: >> On Mon, 19 May 2014 16:23:07 -0700 (PDT) Hugh Dickins >> wrote: >> >> > Shouldn't FAULT_AROUND_ORDER and fault_around_order be changed to be >> > the order of the fault-around size in bytes, and fault_around_pages() >> > use 1UL << (fault_a

Re: [PATCH V4 0/2] mm: FAULT_AROUND_ORDER patchset performance data for powerpc

2014-05-19 Thread Rusty Russell
Hugh Dickins writes: > On Mon, 19 May 2014, Madhavan Srinivasan wrote: >> On Monday 19 May 2014 05:42 AM, Rusty Russell wrote: >> > Hugh Dickins writes: >> >> On Thu, 15 May 2014, Madhavan Srinivasan wrote: >> >>> >> >>> Hi Ingo, >&

Re: [PATCH V4 0/2] mm: FAULT_AROUND_ORDER patchset performance data for powerpc

2014-05-18 Thread Rusty Russell
Hugh Dickins writes: > On Thu, 15 May 2014, Madhavan Srinivasan wrote: >> >> Hi Ingo, >> >> Do you have any comments for the latest version of the patchset. If >> not, kindly can you pick it up as is. >> >> >> With regards >> Maddy >> >> > Kirill A. Shutemov with 8c6e50b029 commit introd

[PATCH] powerpc: module: fix stubs for BE

2014-05-12 Thread Rusty Russell
A simple patch which was supposed to swap r12 and r11 also inexplicably changed the offset by two bytes. This instruction (to load r2) isn't used in LE, so it wasn't noticed. Fixes: b1ce369e82 ("powerpc: modules: use r12 for stub jump address.) Reported-by: Alistair Popple Signe

Re: [PATCH V3 2/2] powerpc/pseries: init fault_around_order for pseries

2014-04-30 Thread Rusty Russell
Ingo Molnar writes: > * Madhavan Srinivasan wrote: > >> Performance data for different FAULT_AROUND_ORDER values from 4 socket >> Power7 system (128 Threads and 128GB memory). perf stat with repeat of 5 >> is used to get the stddev values. Test ran in v3.14 kernel (Baseline) and >> v3.15-rc1 for

Re: [PATCH V3 2/2] powerpc/pseries: init fault_around_order for pseries

2014-04-28 Thread Rusty Russell
Madhavan Srinivasan writes: > diff --git a/arch/powerpc/platforms/pseries/setup.c > b/arch/powerpc/platforms/pseries/setup.c > index 2db8cc6..c87e6b6 100644 > --- a/arch/powerpc/platforms/pseries/setup.c > +++ b/arch/powerpc/platforms/pseries/setup.c > @@ -74,6 +74,8 @@ int CMO_SecPSP = -1; > un

Re: [git pull] Please pull abiv2 branch

2014-04-28 Thread Rusty Russell
Philippe Bergheaud writes: > Anton Blanchard wrote: >> Here are the ABIv2 patches rebased against 3.15-rc2. > > After recompiling 3.15-rc2 with the ABIv2 patches, > I see the following line in Modules.symvers: > > 0x TOC. vmlinux EXPORT_SYMBOL > > Kernel will not load modules because

Re: [PATCH 6/7] powerpc/ftrace: Use module loader helpers to parse trampolines

2014-04-22 Thread Rusty Russell
Anton Blanchard writes: > Now we have is_module_trampoline() and module_trampoline_target() > we can remove a bunch of intimate kernel module trampoline > knowledge from ftrace. > > Signed-off-by: Anton Blanchard Oh god, I had no idea this code existed. I really wanted to implement the R_PPC64_

Re: [PATCH V2 1/2] mm: move FAULT_AROUND_ORDER to arch/

2014-04-22 Thread Rusty Russell
Dave Hansen writes: > On 04/08/2014 06:32 PM, Madhavan Srinivasan wrote: >>> > In mm/Kconfig, put >>> > >>> > config FAULT_AROUND_ORDER >>> > int >>> > default 1234 if POWERPC >>> > default 4 >>> > >>> > The way you have it now, every single architecture that need

Re: [PATCH 3/9] powerpc: Add TIF_ELF2ABI flag.

2013-12-01 Thread Rusty Russell
Michael Ellerman writes: > On Wed, Nov 20, 2013 at 10:15:00PM +1100, Anton Blanchard wrote: >> From: Rusty Russell >> >> Little endian ppc64 is getting an exciting new ABI. This is reflected >> by the bottom two bits of e_flags in the ELF header: >> >

[PATCH 2/4] powerpc: Set eflags correctly for ELF ABIv2 core dumps.

2013-11-06 Thread Rusty Russell
We leave it at zero (though it could be 1) for old tasks. Signed-off-by: Rusty Russell --- arch/powerpc/include/asm/elf.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/powerpc/include/asm/elf.h b/arch/powerpc/include/asm/elf.h index 54c7445..8b89268 100644 --- a/arch/powerpc

[PATCH 1/4] powerpc: Add TIF_ELF2ABI flag.

2013-11-06 Thread Rusty Russell
thread flag, because we need to set it in core dumps and for signal delivery. Our chief concern is that it doesn't use function descriptors. Signed-off-by: Rusty Russell --- arch/powerpc/include/asm/elf.h | 4 arch/powerpc/include/asm/thread_info.h | 9 + 2 files change

[PATCH 3/4] powerpc: ELF2 binaries launched directly.

2013-11-06 Thread Rusty Russell
No function descriptor, but we set r12 up and set TIF_RESTOREALL as it normally isn't restored on return from syscall. Signed-off-by: Rusty Russell --- arch/powerpc/kernel/process.c | 50 ++- 1 file changed, 35 insertions(+), 15 deletions(-) diff --

[PATCH 4/4] powerpc: ELF2 binaries signal handling

2013-11-06 Thread Rusty Russell
For the ELFv2 ABI, the hander is the entry point, not a function descriptor. We also need to set up r12, and fortunately the fast_exception_return exit path restores r12 for us so nothing else is required. Signed-off-by: Rusty Russell --- arch/powerpc/kernel/signal_64.c | 25

Re: [PATCH] module: ppc64 module CRC relocation fix causes perf issues

2013-07-14 Thread Rusty Russell
also need to wrap it with > CONFIG_PPC64 because the ppc32 kernel can set a non zero > PHYSICAL_START at compile time and we wouldn't want to subtract > it from the CRCs in that case. > > Signed-off-by: Anton Blanchard > Cc: Acked-by: Rusty Russell Ben? Cheers, Rusty. _

Re: [PATCH 3/4] KVM: PPC: Add support for IOMMU in-kernel handling

2013-06-18 Thread Rusty Russell
Alex Williamson writes: > On Mon, 2013-06-17 at 13:56 +1000, Benjamin Herrenschmidt wrote: >> On Sun, 2013-06-16 at 21:13 -0600, Alex Williamson wrote: >> >> > IOMMU groups themselves don't provide security, they're accessed by >> > interfaces like VFIO, which provide the security. Given a brief

[PATCH 2/9] PTR_RET is now PTR_ERR_OR_ZERO(): Replace most.

2013-06-15 Thread Rusty Russell
Sweep of the simple cases. Cc: net...@vger.kernel.org Cc: linuxppc-dev@lists.ozlabs.org Cc: linux-arm-ker...@lists.infradead.org Cc: Julia Lawall Signed-off-by: Rusty Russell --- arch/arm/mach-omap2/i2c.c | 2 +- arch/m68k/amiga/platform.c| 2

Re: [PATCH v6 00/46] CPU hotplug: stop_machine()-free CPU hotplug

2013-02-25 Thread Rusty Russell
"Srivatsa S. Bhat" writes: > Hi, > > This patchset removes CPU hotplug's dependence on stop_machine() from the CPU > offline path and provides an alternative (set of APIs) to preempt_disable() to > prevent CPUs from going offline, which can be invoked from atomic context. > The motivation behind t

Re: [PATCH v5 00/45] CPU hotplug: stop_machine()-free CPU hotplug

2013-02-06 Thread Rusty Russell
"Srivatsa S. Bhat" writes: > On 01/22/2013 01:03 PM, Srivatsa S. Bhat wrote: > Avg. latency of 1 CPU offline (ms) [stop-cpu/stop-m/c > latency] > > # online CPUsMainline (with stop-m/c) This patchset (no stop-m/c) > > 8 17.04

[PATCH] powerpc: add finit_module syscall.

2012-10-31 Thread Rusty Russell
(This is just for Acks: this won't work without the actual syscall patches, sitting in my tree for -next at the moment). Signed-off-by: Rusty Russell --- arch/powerpc/include/asm/systbl.h |1 + arch/powerpc/include/asm/unistd.h |2 +- arch/powerpc/include/uapi/asm/uni

Re: [PATCH] powerpc: fix compile fail in hugetlb cmdline parsing

2012-05-07 Thread Rusty Russell
r *, const char *)' but argument is of type >'int (*)(char *, char *)' > > This function has no need to printk out the "doing" value, so > just add the arg as an "unused". > > Cc: Rusty Russell > Cc: Jim Cromie > Cc: Jason Baron

Re: [PATCH] params: Fix parse_args() use in PowerPC's reserve_hugetlb_gpages()

2012-02-19 Thread Rusty Russell
On Fri, 17 Feb 2012 16:08:36 +, Pawel Moll wrote: > Commit b8076966e8e1 ("params: _initcall-like kernel parameters") > changed the parse_args() API without fixing all the callers. Done now. > > Signed-off-by: Pawel Moll Thanks Stephen, Pawel. Applied, Rusty. ___

Re: [PATCH 6/12] arch/powerpc: remove references to cpu_*_map.

2012-02-19 Thread Rusty Russell
On Thu, 16 Feb 2012 14:29:04 +1100, Benjamin Herrenschmidt wrote: > On Wed, 2012-02-15 at 14:51 +0530, Srivatsa S. Bhat wrote: > > On 02/15/2012 10:28 AM, Rusty Russell wrote: > > > > > From: Rusty Russell > > > > > > This has been obsole

[PATCH 1/5] remove references to cpu_*_map in arch/

2012-02-15 Thread Rusty Russell
From: Rusty Russell This has been obsolescent for a while; time for the final push. In adjacent context, replaced old cpus_* with cpumask_*. Signed-off-by: Rusty Russell Acked-by: David S. Miller (arch/sparc) Acked-by: Chris Metcalf (arch/tile) Cc: user-mode-linux-de

[PATCH 6/12] arch/powerpc: remove references to cpu_*_map.

2012-02-14 Thread Rusty Russell
From: Rusty Russell This has been obsolescent for a while; time for the final push. Signed-off-by: Rusty Russell Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: linuxppc-dev@lists.ozlabs.org --- arch/powerpc/platforms/wsp/smp.c |2 +- 1 file changed, 1 insertion(+), 1 deletion

Re: [PATCH v3 2/3] hvc_init(): Enforce one-time initialization.

2011-11-21 Thread Rusty Russell
On Mon, 21 Nov 2011 14:16:38 -0800, Miche Baker-Harvey wrote: > Thanks, Rusty. I'm not using QEMU though, just KVM. I create the device, > wait > for the message from the guest that the device is ready, and then add ports. > > Miche OK, since Amit was the one who implemented multi-port conso

Re: [PATCH v3 2/3] hvc_init(): Enforce one-time initialization.

2011-11-20 Thread Rusty Russell
On Thu, 17 Nov 2011 10:57:37 -0800, Miche Baker-Harvey wrote: > Rusty, Michael, Stephen, et al, > > Thanks for your comments on these patches. > > For what I'm trying to do, all three patches are necessary, but maybe > I'm going about it the wrong way. Your input would be appreciated. > I'm in n

Re: [PATCH v3 2/3] hvc_init(): Enforce one-time initialization.

2011-11-13 Thread Rusty Russell
On Tue, 08 Nov 2011 13:45:04 -0800, Miche Baker-Harvey wrote: > hvc_init() must only be called once, and no thread should continue with > hvc_alloc() > until after initialization is complete. The original code does not enforce > either > of these requirements. A new mutex limits entry to hvc_i

Re: [PATCH v3 1/3] virtio_console: Fix locking of vtermno.

2011-11-10 Thread Rusty Russell
On Tue, 08 Nov 2011 13:44:58 -0800, Miche Baker-Harvey wrote: > Some modifications of vtermno were not done under the spinlock. > > Moved assignment from vtermno and increment of vtermno together, > putting both under the spinlock. Revert vtermno on failure. > > Signed-off-by: Miche Baker-Harve

Re: hvc_console: Don't access hvc_task if not initialised

2011-04-26 Thread Rusty Russell
On Wed, 20 Apr 2011 22:36:10 +0530, Amit Shah wrote: > On (Wed) 20 Apr 2011 [07:34:35], Greg KH wrote: > > Care to either create this patch, or resend your original one, if you > > want it applied? > > Rusty has the other one queued. I pinged him about status. It's merged, but I don't think it

Re: [PATCH 4/7] hvc_console: Fix race between hvc_close and hvc_remove

2010-04-07 Thread Rusty Russell
On Tue, 6 Apr 2010 09:12:38 pm Anton Blanchard wrote: > The patch below changes things to call tty_kref_put once for every > hvc_close call, and with that my machine boots fine. Thanks, applied. Cheers, Rusty. ___ Linuxppc-dev mailing list Linuxppc-dev@

Re: [PATCH 03/31] hvc_console: make the ops pointer const.

2010-01-12 Thread Rusty Russell
On Tue, 12 Jan 2010 12:51:46 pm Benjamin Herrenschmidt wrote: > On Tue, 2009-12-22 at 20:04 +0530, Amit Shah wrote: > > From: Rusty Russell > > > > This is nicer for modern R/O protection. And noone needs it non-const, so > > constify the callers as well. > &

Re: [PATCH] ppc64: re-enable kexec to allow module loads with CONFIG_MODVERSIONS and CONFIG_RELOCATABLE turned on

2009-12-03 Thread Rusty Russell
On Fri, 4 Dec 2009 01:34:17 am Neil Horman wrote: > Just finished testing your patch Rusty, it all works quite well, Thanks! > Will this be going in via your tree, or the ppc tree? It's in my tree now. Since I didn't really alter the ppc parts, I kept Paul's ack attached too. Thanks, Rusty.

Re: [PATCH] ppc64: re-enable kexec to allow module loads with CONFIG_MODVERSIONS and CONFIG_RELOCATABLE turned on

2009-11-30 Thread Rusty Russell
= 0" is necessary. 4) ARCH_USES_RELOC_ENTRIES isn't clear enough for me; I prefer ARCH_RELOCATE_KCRCTAB. module: handle ppc64 relocating kcrctabs when CONFIG_RELOCATABLE=y http://lists.ozlabs.org/pipermail/linuxppc-dev/2009-November/077972.html Inspired-by: Neil Horman Signed-off-by

Re: [PATCH] BUILD_BUG_ON: make it handle more cases

2009-11-05 Thread Rusty Russell
On Thu, 5 Nov 2009 05:08:42 pm Stephen Rothwell wrote: > Hi Rusty, > > On Thu, 5 Nov 2009 16:58:36 +1030 Rusty Russell wrote: > > > > Huh? virtio_has_feature does: > > > > if (__builtin_constant_p(fbit)) > > BUILD_BUG_ON(fbit >= 32)

[PATCH] BUILD_BUG_ON: make it handle more cases

2009-10-19 Thread Rusty Russell
inker output is not usually as informative as a compiler error. If we use the negative-array-size method *and* the link time trick, we get the ability to use BUILD_BUG_ON() under __builtin_constant_p() branches, and maximal ability for the compiler to detect errors at build time. Signed-off-by: Rusty

Re: linux-next: tree build failure

2009-10-19 Thread Rusty Russell
On Tue, 20 Oct 2009 04:49:29 am Hollis Blanchard wrote: > On Thu, 2009-10-15 at 08:27 +0100, Jan Beulich wrote: > > My perspective is that it just uncovered already existing brokenness. > > Sorry, I thought it was clear, but to be more explicit: I propose the > following patch, which replaces the

Re: [PATCH] cpumask: use mm_cpumask() wrapper: powerpc

2009-03-22 Thread Rusty Russell
On Friday 20 March 2009 17:06:17 Benjamin Herrenschmidt wrote: > On Mon, 2009-03-16 at 14:46 +1030, Rusty Russell wrote: > > Makes code futureproof against the impending change to mm->cpu_vm_mask. > > > > It's also a chance to use the new cpumask_ ops which take a po

Re: linux-next: cpus4096 tree build failure

2009-03-19 Thread Rusty Russell
t; numa_node_id default implementation to topology.h") removed the include > of linux/topology.h from linux/mmzone.h which exposed this lack. > > Signed-off-by: Stephen Rothwell Acked-by: Rusty Russell Ingo, please apply. Apparently sparc is similarly broken :( Rusty. ___

[PATCH] cpumask: use mm_cpumask() wrapper: powerpc

2009-03-15 Thread Rusty Russell
Makes code futureproof against the impending change to mm->cpu_vm_mask. It's also a chance to use the new cpumask_ ops which take a pointer (the older ones are deprecated, but there's no hurry for arch code). Signed-off-by: Rusty Russell --- arch/powerpc/include/asm/mmu_con

[PATCH] powerpc: make sysfs code use smp_call_function_single

2009-03-11 Thread Rusty Russell
Impact: performance improvement This fixes 'powerpc: avoid cpumask games in arch/powerpc/kernel/sysfs.c' which talked about using smp_call_function_single, but actually used work_on_cpu (an older version of the patch). Signed-off-by: Rusty Russell --- arch/powerpc/kernel/sysf

Re: [RFC v1] virtio: add virtio-over-PCI driver

2009-02-19 Thread Rusty Russell
On Thursday 19 February 2009 03:08:35 Ira Snyder wrote: > On Wed, Feb 18, 2009 at 05:13:03PM +1030, Rusty Russell wrote: > > don't restrict yourself to 32 feature bits (only PCI does this, and they're > > going to have to hack when we reach feature 32). > > Ther

[PATCH] cpumask: avoid cast-away-const for deprecated cpu_*_map.

2009-02-17 Thread Rusty Russell
hout comments in 92ab78315c638515d0e81b0c70b2082f713582d9) Signed-off-by: Rusty Russell Cc: linuxppc-dev@ozlabs.org Cc: Ivan Kokshaysky Cc: james.bottom...@hansenpartnership.com Cc: Mike Travis --- include/linux/cpumask.h | 14 +- kernel/cpu.c| 10 ++ 2 files changed, 19 insertions(+), 5 deletion

Re: [RFC v1] virtio: add virtio-over-PCI driver

2009-02-17 Thread Rusty Russell
On Wednesday 18 February 2009 08:54:25 Ira Snyder wrote: > This adds support to Linux for using virtio between two computers linked by > a PCI interface. This allows the use of virtio_net to create a familiar, > fast interface for communication. It should be possible to use other virtio > devices i

Re: [PATCH RFC v5] net: add PCINet driver

2009-01-12 Thread Rusty Russell
On Friday 09 January 2009 08:21:27 Ira Snyder wrote: > Rusty, since you wrote the virtio code, can you point me at the things I > would need to implement to use virtio over the PCI bus. > > The guests (PowerPC computers running Linux) are PCI cards in the host > system (an Intel Pentium3-M system)

Re: linux-next: rr tree build failure

2008-10-23 Thread Rusty Russell
On Thursday 23 October 2008 15:52:28 Stephen Rothwell wrote: > Hi Rusty, > > Today's linux-next build (powerpc ppc64_defconfig) failed like this: > > arch/powerpc/platforms/cell/spu_base.c: In function > 'mm_needs_global_tlbie': arch/powerpc/platforms/cell/spu_base.c:117: error: > implicit declarat

Re: [PATCH 18/35] cpumask: add nr_cpumask_bits

2008-10-21 Thread Rusty Russell
On Tuesday 21 October 2008 04:03:37 Mike Travis wrote: > When nr_cpu_ids is set to CONFIG_NR_CPUS then references to nr_cpu_ids > will return the maximum index of the configured NR_CPUS (+1) instead > of the maximum index of the possible number of cpus (+1). This results > in extra unused memory b

Re: [RFC PATCH 4/5] hvc_console: Add tty window resizing

2008-10-16 Thread Rusty Russell
On Tuesday 14 October 2008 20:12:51 Hendrik Brueckner wrote: > From: Hendrik Brueckner <[EMAIL PROTECTED]> > > The patch provides the hvc_resize() function to update the terminal > window dimensions (struct winsize) for a specified hvc console. > The function stores the new window size and schedule

Re: [RFC 1/3] add support for exporting symbols from .S files

2008-08-11 Thread Rusty Russell
ITS_PER_LONG-32 > + .align 3 > +\symtab: > + .long \sym > + .long \strtab > + .else > + .align 4 Good work! Hmm, you can .balign BITS_PER_LONG/8 outside the ifeq. Unfortunately .long doesn't do the Right Thing on 64 bit, so getting rid of the if is ha

Re: [PATCH -next-20080709] fixup stop_machine use cpu mask vs ftrace

2008-07-11 Thread Rusty Russell
On Friday 11 July 2008 17:46:03 Ingo Molnar wrote: > * Milton Miller <[EMAIL PROTECTED]> wrote: > > Hi Rusty, Ingo. > > > > Rusty's patch [PATCH 3/3] stop_machine: use cpu mask rather than magic > > numbers didn't find kernel/trace/ftrace.c in -next, causing an > > immediate almost NULL pointer der

Re: [PATCH -next-20080709] fixup stop_machine use cpu mask vs ftrace

2008-07-10 Thread Rusty Russell
On Friday 11 July 2008 07:07:57 Milton Miller wrote: > Hi Rusty, Ingo. > > Rusty's patch [PATCH 3/3] stop_machine: use cpu mask rather than magic > numbers didn't find kernel/trace/ftrace.c in -next, causing an immediate > almost NULL pointer dereference in ftrace_dynamic_init. Yes, I'm switching

Re: [RFC 1/3 v2] hvc_console: rework setup to replace irq functions with callbacks

2008-06-26 Thread Rusty Russell
config that I tried: drivers/char/hvc_console.h:59: error: field ‘kref’ has incomplete type So move the include of kref.h too. Signed-off-by: Rusty Russell <[EMAIL PROTECTED]> diff -r f382d8f562a8 drivers/char/hvc_console.c --- a/drivers/char/hvc_console.cFri Jun 27 15:17:49 2008

Re: [RFC 3/3 v2] s390: use virtio_console for KVM on s390

2008-06-22 Thread Rusty Russell
On Friday 20 June 2008 23:24:18 Christian Borntraeger wrote: > This patch enables virtio_console as the default console on kvm for > s390. We currently use the same notify hack as lguest for early > console output. I will try to address this for lguest and s390 later. > > Signed-off-by: Christian B

Re: [RFC 1/3] hvc_console: rework setup to replace irq functions with callbacks

2008-06-03 Thread Rusty Russell
On Tuesday 03 June 2008 22:45:22 Christian Borntraeger wrote: > This patch tries to change hvc_console to not use request_irq/free_irq if > the backend does not use irqs. This allows virtio_console to use > hvc_console without having a linker reference to request_irq/free_irq. Two questions. Is i

Re: [PATCH] [POWERPC] Optimize counting distinct entries in therelocation sections

2007-11-12 Thread Rusty Russell
On Tuesday 13 November 2007 13:49:15 Paul Mackerras wrote: > Medve Emilian writes: > > Seems like there are R_PPC_REL24 with r_addend != 0. Within a set of 41 > > modules (featuring 5457 R_PPC_REL24 relocations) already included within > > the kernel tree I found 37 such relocations (R_PPC_REL24) w

Re: [PATCH] [POWERPC] Optimize counting distinct entries in the relocation sections

2007-11-12 Thread Rusty Russell
On Monday 12 November 2007 17:00:43 Paul Mackerras wrote: > Emil Medve writes: > > (Not sure why the relocation tables could contain lots of duplicates and > > why they are not trimmed at compile time by the linker. In some test > > cases, out of 35K relocation entries only 1.5K were distinct/uniqu