On Mon,  7 May 2012 10:32:22 -0400, Paul Gortmaker 
<paul.gortma...@windriver.com> wrote:
> Commit 9fb48c744ba6a4bf58b666f4e6fdac3008ea1bd4
> 
>     "params: add 3rd arg to option handler callback signature"
> 
> added an extra arg to the function, but didn't catch all the use
> cases needing it, causing this compile fail in mpc85xx_defconfig:
> 
>  arch/powerpc/mm/hugetlbpage.c:316:4: error: passing argument 7 of
>  'parse_args' from incompatible pointer type [-Werror]
> 
>  include/linux/moduleparam.h:317:12: note: expected
>        'int (*)(char *, char *, const char *)' but argument is of type
>        'int (*)(char *, char *)'
> 
> This function has no need to printk out the "doing" value, so
> just add the arg as an "unused".
> 
> Cc: Rusty Russell <ru...@rustcorp.com.au>
> Cc: Jim Cromie <jim.cro...@gmail.com>
> Cc: Jason Baron <jba...@redhat.com>
> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org>
> Cc: Becky Bruce <bec...@kernel.crashing.org>
> Cc: Benjamin Herrenschmidt <b...@kernel.crashing.org>
> Signed-off-by: Paul Gortmaker <paul.gortma...@windriver.com>

Acked-by: Rusty Russell <ru...@rustcorp.com.au>

Thanks,
Rusty.
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

Reply via email to