Signed-off-by: Rosen Penev
(for CAN)
Reviewed-by: Marc Kleine-Budde
---
v3: fix coccinelle bad return and error message checks. Also reword
commit title and message
v2: fixed compilation errors. Also removed non devm transformations.
drivers/net/can/grcan.c | 5 ++--
dri
On Mon, Nov 11, 2024 at 7:32 PM Jakub Kicinski wrote:
>
> On Mon, 11 Nov 2024 13:03:16 -0800 Rosen Penev wrote:
> > --- a/drivers/net/ethernet/samsung/sxgbe/sxgbe_platform.c
> > +++ b/drivers/net/ethernet/samsung/sxgbe/sxgbe_platform.c
> > @@ -111,7 +111,7 @@ static
np here is the node coming from platform_device. No children are used.
I changed irq_of_parse_and_map to platform_get_irq to pass it directly.
I changed of_address_to_resource to platform_get_resource for the same
reason.
It ends up being the same.
Signed-off-by: Rosen Penev
---
v2: fixed
On Mon, Nov 11, 2024 at 8:21 AM Rob Herring wrote:
>
> On Sat, Nov 9, 2024 at 5:40 PM Rosen Penev wrote:
> >
> > np here is ofdev->dev.of_node. Better to use the proper functions as
> > there's no use of children or anything else.
>
> Your commit messag
np here is ofdev->dev.of_node. Better to use the proper functions as
there's no use of children or anything else.
Signed-off-by: Rosen Penev
---
drivers/net/can/grcan.c | 2 +-
drivers/net/can/mscan/mpc5xxx_can.c | 2 +-
drivers/net/dsa/b
On Mon, Nov 4, 2024 at 1:01 PM Rosen Penev wrote:
>
> Also added a small fix for NVMEM mac addresses.
>
> This was tested as working on a Watchguard T10 device.
>
> Rosen Penev (4):
> net: ucc_geth: use devm for kmemdup
> net: ucc_geth: use devm for alloc_etherdev
>
When nvmem is not ready, of_get_ethdev_address returns -EPROBE_DEFER. In
such a case, return -EPROBE_DEFER to avoid not having a proper MAC
address.
Signed-off-by: Rosen Penev
---
drivers/net/ethernet/freescale/ucc_geth.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a
Avoids having to unregister manually.
Signed-off-by: Rosen Penev
---
drivers/net/ethernet/freescale/ucc_geth.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/freescale/ucc_geth.c
b/drivers/net/ethernet/freescale/ucc_geth.c
index 00b868a47fd2
Avoids manual frees. Removes one goto.
Signed-off-by: Rosen Penev
---
drivers/net/ethernet/freescale/ucc_geth.c | 10 +++---
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/drivers/net/ethernet/freescale/ucc_geth.c
b/drivers/net/ethernet/freescale/ucc_geth.c
index
Avoids manual frees for it. Funny enough the free in _remove should be
the last thing done.
Signed-off-by: Rosen Penev
---
drivers/net/ethernet/freescale/ucc_geth.c | 17 +++--
1 file changed, 7 insertions(+), 10 deletions(-)
diff --git a/drivers/net/ethernet/freescale/ucc_geth.c
Also added a small fix for NVMEM mac addresses.
This was tested as working on a Watchguard T10 device.
Rosen Penev (4):
net: ucc_geth: use devm for kmemdup
net: ucc_geth: use devm for alloc_etherdev
net: ucc_geth: use devm for register_netdev
net: ucc_geth: fix usage with NVMEM MAC
On Sun, Oct 27, 2024 at 7:32 PM Michael Ellerman wrote:
>
> Rosen Penev writes:
> > On Fri, Oct 25, 2024 at 5:57 AM Simon Horman wrote:
> >>
> >> On Thu, Oct 24, 2024 at 01:52:57PM -0700, Rosen Penev wrote:
> >> > The latter is the preferred way to
On Fri, Oct 25, 2024 at 5:57 AM Simon Horman wrote:
>
> On Thu, Oct 24, 2024 at 01:52:57PM -0700, Rosen Penev wrote:
> > The latter is the preferred way to copy ethtool strings.
> >
> > Avoids manually incrementing the pointer. Cleans up the code quite well.
> >
The latter is the preferred way to copy ethtool strings.
Avoids manually incrementing the pointer. Cleans up the code quite well.
Signed-off-by: Rosen Penev
---
.../ethernet/freescale/dpaa/dpaa_ethtool.c| 40 ++-
.../ethernet/freescale/dpaa2/dpaa2-ethtool.c | 15
They are the prefered way to copy ethtool strings.
Avoids manually incrementing the data pointer.
Signed-off-by: Rosen Penev
---
drivers/net/ethernet/ibm/ibmvnic.c | 30 +-
1 file changed, 9 insertions(+), 21 deletions(-)
diff --git a/drivers/net/ethernet/ibm
15 matches
Mail list logo
