Re: linux-next: kbuild tree build failure

2008-07-12 Thread Roman Zippel
Hi, On Sat, 12 Jul 2008, Milton Miller wrote: > (1) #define PAGE_OFFSET(ASM_CONST(CONFIG_PAGE_OFFSET) << 32) > > It creates unreadable code, where two defines with almost the same name (the > only difference being > the CONFIG_ prefix, which is often ignored when scanning) contains radically

Re: linux-next: kbuild tree build failure

2008-07-10 Thread Roman Zippel
Hi, On Thu, 10 Jul 2008, Michael Ellerman wrote: > Well yes :) But I think that's because you're thinking of > "end-users" and I'm thinking of "users" like myself - ie. _I_ use > Kconfig and I do expect myself to be able to type a 64-bit address. That doesn't really answer my question, why you

Re: linux-next: kbuild tree build failure

2008-07-10 Thread Roman Zippel
Hi, On Tue, 8 Jul 2008, Sam Ravnborg wrote: > We use Kconfig for a mixture of user editable values and fixed > configuration values. > And I agree that asking the user to input a 64 bit number is not usefull. > > But keeping support for 64 bit values is what I would consider > expected functiona

Re: linux-next: kbuild tree build failure

2008-07-07 Thread Roman Zippel
Hi, On Tue, 8 Jul 2008, Michael Ellerman wrote: > I don't really see why it "doesn't make sense" for users to input 64-bit > values, they're configuring addresses for a 64-bit kernel, so some of > the values are going to be 64 bit. Do you really expect users to insert random 64bit addresses with

Re: linux-next: kbuild tree build failure

2008-07-07 Thread Roman Zippel
r). Below is a patch that fixes this for all archs (generated against the git tree). The powerpc parts need a more careful review, the rest isn't really critical. bye, Roman Fix remaining warnings generated kconfig to normalize all constant values. Generate powerpc 64bit page offset via