Re: [PATCH v3] dt-bindings: powerpc: Convert fsl/pmc.txt to YAML

2025-04-22 Thread Rob Herring (Arm)
On Thu, 17 Apr 2025 16:21:14 +0200, J. Neuschäfer wrote: > This patch rewrites pmc.txt into YAML format. Descriptive texts are > expanded or shortened in a few places to better fit today's conventions. > > The list of compatible strings (and combinations of them) is based on > existing device tr

Re: [PATCH v2] dt-bindings: powerpc: Convert fsl/pmc.txt to YAML

2025-04-12 Thread Rob Herring
On Sat, Apr 12, 2025 at 02:49:38PM +0200, J. Neuschäfer wrote: > This patch rewrites pmc.txt into YAML format. Descriptive texts are > expanded or shortened in a few places to better fit today's conventions. > > The list of compatible strings (and combinations of them) is based on > existing devic

Re: [PATCH v2] dt-bindings: powerpc: Convert fsl/pmc.txt to YAML

2025-04-12 Thread Rob Herring (Arm)
On Sat, 12 Apr 2025 14:49:38 +0200, J. Neuschäfer wrote: > This patch rewrites pmc.txt into YAML format. Descriptive texts are > expanded or shortened in a few places to better fit today's conventions. > > The list of compatible strings (and combinations of them) is based on > existing device tr

Re: [PATCH v5 4/4] dt-bindings: memory-controllers: Convert fsl,elbc to YAML

2025-04-12 Thread Rob Herring (Arm)
isplay/ssd1289fb.txt > > V4: > - no changes > > V3: > - move this patch after the GPCM/FCM patches to dtschema/dtc warnings > due to missing bindings for fsl,elbc-gpcm-uio and fsl,elbc-fcm-nand > - add "simple-bus" again, for compatibility with existing DTs/

Re: [PATCH] dt-bindings: soc: fsl: fsl,ls1028a-reset: Fix maintainer entry

2025-04-11 Thread Rob Herring (Arm)
On Thu, 10 Apr 2025 18:11:12 +0200, Geert Uytterhoeven wrote: > make dt_binding_check: > > Documentation/devicetree/bindings/soc/fsl/fsl,ls1028a-reset.yaml: > maintainers:0: 'Frank Li' does not match '@' > from schema $id: http://devicetree.org/meta-schemas/base.yaml# > > Fix thi

[PATCH] powerpc/prom_init: Fixup missing powermac #size-cells on i2s nodes

2025-03-18 Thread Rob Herring (Arm)
vice_type to the existing fixup. Reported-by: Christoph Biedl Signed-off-by: Rob Herring (Arm) --- arch/powerpc/kernel/prom_init.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/kernel/prom_init.c b/arch/powerpc/kernel/prom_init.c index 57082fac4668..69018

Re: [PATCH v4 3/4] dt-bindings: nand: Add fsl,elbc-fcm-nand

2025-03-17 Thread Rob Herring (Arm)
gt; - constrain #address-cells and #size-cells > - add a general description > - use unevaluatedProperties=false instead of additionalProperties=false > - fix property order to comply with dts coding style > - include raw-nand-chip.yaml instead of nand-chip.yaml > --- > .../devicetree/bindings/mtd/fsl,elbc-fcm-nand.yaml | 68 > ++ > 1 file changed, 68 insertions(+) > Reviewed-by: Rob Herring (Arm)

Re: [PATCH v4 1/4] dt-bindings: mtd: raw-nand-chip: Relax node name pattern

2025-03-17 Thread Rob Herring (Arm)
tch to silence dtc validation error, after discussion > with Rob Herring and Miquèl Raynal > - add some more detail to the commit message > - remove unit address format rather than extending it > (old pattern: "^nand@[a-f0-9](,[0-9a-f]*)?$") > > V3: >

Re: [PATCH] dt-bindings: powerpc: Convert fsl/pmc.txt to YAML

2025-03-15 Thread Rob Herring (Arm)
On Sat, 15 Mar 2025 18:27:05 +0100, J. Neuschäfer wrote: > This patch rewrites pmc.txt into YAML format. Descriptive texts are > expanded or shortened in a few places to better fit today's conventions. > > The list of compatible strings (and combinations of them) is based on > existing device tr

Re: [PATCH v4 4/4] dt-bindings: memory-controllers: Convert fsl,elbc to YAML

2025-03-14 Thread Rob Herring (Arm)
es to dtschema/dtc warnings > due to missing bindings for fsl,elbc-gpcm-uio and fsl,elbc-fcm-nand > - add "simple-bus" again, for compatibility with existing DTs/drivers > based on discussion with Crystal Wood and Rob Herring > - fix fsl,pq2-localbus compatible properti

Re: [PATCH v4] dt-bindings: dma: Convert fsl,elo*-dma to YAML

2025-03-11 Thread Rob Herring (Arm)
l,elo3-dma.yaml | 125 + > .../devicetree/bindings/dma/fsl,eloplus-dma.yaml | 132 +++++ > .../devicetree/bindings/powerpc/fsl/dma.txt| 204 > - > 4 files changed, 394 insertions(+), 204 deletions(-) > Reviewed-by: Rob Herring (Arm)

Re: [PATCH v3] dt-bindings: dma: Convert fsl,elo*-dma to YAML

2025-03-03 Thread Rob Herring
On Wed, Feb 26, 2025 at 11:29:54AM -0600, Rob Herring (Arm) wrote: > > On Wed, 26 Feb 2025 16:57:17 +0100, J. Neuschäfer wrote: > > The devicetree bindings for Freescale DMA engines have so far existed as > > a text file. This patch converts them to YAML, and specifies all

Re: [PATCH v3 2/3] dt-bindings: nand: Add fsl,elbc-fcm-nand

2025-03-03 Thread Rob Herring
On Wed, Feb 26, 2025 at 12:45:17PM -0600, Rob Herring (Arm) wrote: > > On Wed, 26 Feb 2025 18:01:41 +0100, J. Neuschäfer wrote: > > Formalize the binding already supported by the fsl_elbc_nand.c driver > > and used in several device trees in arch/powerpc/boot/dts/. > > &

Re: [PATCH 3/4] ASoC: dt-bindings: fsl,audmix: make 'dais' property to be optional

2025-03-03 Thread Rob Herring (Arm)
y: Shengjiu Wang > --- > Documentation/devicetree/bindings/sound/fsl,audmix.yaml | 1 - > 1 file changed, 1 deletion(-) > Reviewed-by: Rob Herring (Arm)

Re: [PATCH 2/4] ASoC: dt-bindings: fsl,audmix: Document audio graph port

2025-03-03 Thread Rob Herring (Arm)
l,audmix.yaml | 60 +++ > 1 file changed, 60 insertions(+) > Reviewed-by: Rob Herring (Arm)

Re: [PATCH 1/4] ASoC: dt-bindings: fsl,sai: Document audio graph port

2025-03-03 Thread Rob Herring (Arm)
l,sai.yaml| 51 +++ > 1 file changed, 51 insertions(+) > Reviewed-by: Rob Herring (Arm)

Re: [PATCH v3 3/3] dt-bindings: memory-controllers: Convert fsl,elbc to YAML

2025-02-26 Thread Rob Herring (Arm)
due to missing bindings for fsl,elbc-gpcm-uio and fsl,elbc-fcm-nand > - add "simple-bus" again, for compatibility with existing DTs/drivers > based on discussion with Crystal Wood and Rob Herring > - fix fsl,pq2-localbus compatible properties based on mgcoge.dts / ep8248e.dts &g

Re: [PATCH v3 2/3] dt-bindings: nand: Add fsl,elbc-fcm-nand

2025-02-26 Thread Rob Herring (Arm)
On Wed, 26 Feb 2025 18:01:41 +0100, J. Neuschäfer wrote: > Formalize the binding already supported by the fsl_elbc_nand.c driver > and used in several device trees in arch/powerpc/boot/dts/. > > raw-nand-chip.yaml is referenced in order to accommodate situations in > which the ECC parameters set

Re: [PATCH v3] dt-bindings: dma: Convert fsl,elo*-dma to YAML

2025-02-26 Thread Rob Herring (Arm)
On Wed, 26 Feb 2025 16:57:17 +0100, J. Neuschäfer wrote: > The devicetree bindings for Freescale DMA engines have so far existed as > a text file. This patch converts them to YAML, and specifies all the > compatible strings currently in use in arch/powerpc/boot/dts. > > Signed-off-by: J. Neuschä

Re: [PATCH v3 1/2] ASoC: dt-bindings: imx-card: Add playback-only and capture-only property

2025-02-19 Thread Rob Herring (Arm)
uta > Reviewed-by: Iuliana Prodan > --- > .../devicetree/bindings/sound/imx-audio-card.yaml | 14 ++ > 1 file changed, 14 insertions(+) > Acked-by: Rob Herring (Arm)

Re: [PATCH v2 05/12] dt-bindings: dma: Convert fsl,elo*-dma to YAML

2025-02-12 Thread Rob Herring
On Fri, Feb 07, 2025 at 10:30:22PM +0100, J. Neuschäfer wrote: > The devicetree bindings for Freescale DMA engines have so far existed as > a text file. This patch converts them to YAML, and specifies all the > compatible strings currently in use in arch/powerpc/boot/dts. > > Signed-off-by: J. Neu

Re: [PATCH v2 10/12] dt-bindings: memory-controllers: Add fsl,elbc-gpcm-uio

2025-02-12 Thread Rob Herring (Arm)
type" property > - move to bindings/memory-controllers > --- > .../memory-controllers/fsl,elbc-gpcm-uio.yaml | 59 > ++ > 1 file changed, 59 insertions(+) > Reviewed-by: Rob Herring (Arm)

Re: [PATCH v2 08/12] dt-bindings: spi: Convert Freescale SPI bindings to YAML

2025-02-12 Thread Rob Herring
- interrupts > + - fsl,espi-num-chipselects > + > +allOf: > + - $ref: spi-controller.yaml# > + > +unevaluatedProperties: false > + > +examples: > + - | > +spi@11 { > +compatible = "fsl,mpc8536-espi"; > +reg = <0x11 0x1000>; >

Re: [PATCH v2 03/12] dt-bindings: crypto: Convert fsl,sec-2.0 to YAML

2025-02-12 Thread Rob Herring
devicetrees. > > Signed-off-by: J. Neuschäfer > --- > > V2: > - several improvements suggested by Rob Herring: > - remove unnecessary multiline markers > - constrain fsl,num-channels to enum: [1,4] > - constrain fsl,channel-fifo-len to plausible limits > - cons

Re: [PATCH 1/9] of: Add warpper function of_find_node_by_name_balanced()

2025-02-11 Thread Rob Herring
On Fri, Feb 7, 2025 at 9:37 AM Laurent Pinchart wrote: > > Hi Zekun, > > On Fri, Feb 07, 2025 at 07:28:23PM +0800, zhangzekun (A) wrote: > > 在 2025/2/7 16:24, Oleksij Rempel 写道: > > > On Fri, Feb 07, 2025 at 09:31:09AM +0800, Zhang Zekun wrote: > > >> There are many drivers use of_find_node_by_nam

Re: [PATCH v2 11/12] dt-bindings: nand: Add fsl,elbc-fcm-nand

2025-02-10 Thread Rob Herring
On Fri, Feb 07, 2025 at 10:30:28PM +0100, J. Neuschäfer wrote: > Formalize the binding already supported by the fsl_elbc_nand.c driver > and used in several device trees in arch/powerpc/boot/dts/. > > Signed-off-by: J. Neuschäfer > --- > > V2: > - split out from fsl,elbc binding patch > - constr

Re: [PATCH v2 09/12] dt-bindings: memory-controllers: Convert fsl,elbc to YAML

2025-02-10 Thread Rob Herring
On Sun, Feb 09, 2025 at 02:31:34PM -0600, Crystal Wood wrote: > On Fri, Feb 07, 2025 at 10:30:26PM +0100, J. Neuschäfer via B4 Relay wrote: > > From: "J. Neuschäfer" > > > > Convert the Freescale localbus controller bindings from text form to > > YAML. The updated list of compatible strings refle

Re: [PATCH v2 06/12] dt-bindings: pci: Convert fsl,mpc83xx-pcie to YAML

2025-02-10 Thread Rob Herring
On Sun, Feb 09, 2025 at 12:06:59AM +, J. Neuschäfer wrote: > On Fri, Feb 07, 2025 at 10:30:23PM +0100, J. Neuschäfer via B4 Relay wrote: > > From: "J. Neuschäfer" > > > > Formalise the binding for the PCI controllers in the Freescale MPC8xxx > > chip family. Information about PCI-X-specific p

Re: [PATCH v2 11/12] dt-bindings: nand: Add fsl,elbc-fcm-nand

2025-02-07 Thread Rob Herring (Arm)
On Fri, 07 Feb 2025 22:30:28 +0100, J. Neuschäfer wrote: > Formalize the binding already supported by the fsl_elbc_nand.c driver > and used in several device trees in arch/powerpc/boot/dts/. > > Signed-off-by: J. Neuschäfer > --- > > V2: > - split out from fsl,elbc binding patch > - constrain

Re: [PATCH v2 09/12] dt-bindings: memory-controllers: Convert fsl,elbc to YAML

2025-02-07 Thread Rob Herring (Arm)
On Fri, 07 Feb 2025 22:30:26 +0100, J. Neuschäfer wrote: > Convert the Freescale localbus controller bindings from text form to > YAML. The updated list of compatible strings reflects current usage > in arch/powerpc/boot/dts/, except that many existing device trees > erroneously specify "simple-b

Re: [PATCH v2 06/12] dt-bindings: pci: Convert fsl,mpc83xx-pcie to YAML

2025-02-07 Thread Rob Herring (Arm)
On Fri, 07 Feb 2025 22:30:23 +0100, J. Neuschäfer wrote: > Formalise the binding for the PCI controllers in the Freescale MPC8xxx > chip family. Information about PCI-X-specific properties was taken from > fsl,pci.txt. The examples were taken from mpc8315erdb.dts and > xpedite5200_xmon.dts. > >

Re: [PATCH 5/9] dt-bindings: dma: Convert fsl,elo*-dma bindings to YAML

2025-01-31 Thread Rob Herring
On Fri, Jan 31, 2025 at 8:03 AM J. Neuschäfer wrote: > > On Sun, Jan 26, 2025 at 10:47:35PM -0600, Rob Herring wrote: > > On Sun, Jan 26, 2025 at 07:59:00PM +0100, J. Neuschäfer wrote: > > > The devicetree bindings for Freescale DMA engines have so far existed as > >

Re: [PATCH 8/9] dt-bindings: spi: Convert Freescale SPI bindings to YAML

2025-01-26 Thread Rob Herring
On Sun, Jan 26, 2025 at 07:59:03PM +0100, J. Neuschäfer wrote: > fsl-spi.txt contains the bindings for the fsl,spi and fsl,espi > contollers. Convert them to YAML. > > Signed-off-by: J. Neuschäfer > --- > .../devicetree/bindings/spi/fsl,espi.yaml | 56 + > Documentation/

Re: [PATCH 7/9] dt-bindings: watchdog: Convert mpc8xxx-wdt binding to YAML

2025-01-26 Thread Rob Herring
g/mpc8xxx-wdt.yaml | 64 > ++ > 2 files changed, 64 insertions(+), 25 deletions(-) Reviewed-by: Rob Herring (Arm)

Re: [PATCH 6/9] dt-bindings: pci: Add fsl,mpc83xx-pcie bindings

2025-01-26 Thread Rob Herring
On Sun, Jan 26, 2025 at 07:59:01PM +0100, J. Neuschäfer wrote: > Supplement Documentation/devicetree/bindings/pci/fsl,pci.txt with a more > formal binding in YAML format. > > Signed-off-by: J. Neuschäfer > --- > .../devicetree/bindings/pci/fsl,mpc8xxx-pci.yaml | 83 > ++ >

Re: [PATCH 5/9] dt-bindings: dma: Convert fsl,elo*-dma bindings to YAML

2025-01-26 Thread Rob Herring
On Sun, Jan 26, 2025 at 07:59:00PM +0100, J. Neuschäfer wrote: > The devicetree bindings for Freescale DMA engines have so far existed as > a text file. This patch converts them to YAML, and specifies all the > compatible strings currently in use in arch/powerpc/boot/dts. > > Signed-off-by: J. Neu

Re: [PATCH 4/9] dt-bindings: mfd: Convert fsl,mcu-mpc8349emitx binding to YAML

2025-01-26 Thread Rob Herring
+ > .../bindings/powerpc/fsl/mcu-mpc8349emitx.txt | 17 --- > 2 files changed, 53 insertions(+), 17 deletions(-) Reviewed-by: Rob Herring (Arm)

Re: [PATCH 3/9] dt-bindings: crypto: Convert fsl,sec-2.0 binding to YAML

2025-01-26 Thread Rob Herring
On Sun, Jan 26, 2025 at 07:58:58PM +0100, J. Neuschäfer wrote: > Convert the Freescale security engine (crypto accelerator) binding from > text form to YAML. The list of compatible strings reflects what was > previously described in prose; not all combinations occur in existing > devicetrees. > >

Re: [PATCH 2/9] dt-bindings: ata: Convert fsl,pq-sata binding to YAML

2025-01-26 Thread Rob Herring
.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/ata/fsl,pq-sata.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Freescale 8xxx/3.0 Gb/s SATA nodes > + > +maintainers: > + - J. Neuschäfer > + > +descri

Re: [PATCH 1/9] dt-bindings: powerpc: Add binding for Freescale/NXP MPC83xx SoCs

2025-01-26 Thread Rob Herring (Arm)
the simple-bus binding. > > Signed-off-by: J. Neuschäfer > --- > .../bindings/powerpc/fsl/fsl,mpc83xx.yaml | 67 > ++ > 1 file changed, 67 insertions(+) > Reviewed-by: Rob Herring (Arm)

Re: [PATCH RFC 9/9] dt-bindings: nand: Convert fsl,elbc bindings to YAML

2025-01-26 Thread Rob Herring
On Sun, Jan 26, 2025 at 07:59:04PM +0100, J. Neuschäfer wrote: > Convert the Freescale localbus controller bindings from text form to > YAML. The list of compatible strings reflects current usage. > > Changes compared to the txt version: > - removed the board-control (fsl,mpc8272ads-bcsr) node be

Re: [PATCH] powerpc/prom_init: Fixup missing #size-cells on PowerBook6,7

2025-01-17 Thread Rob Herring
; Signed-off-by: Andreas Schwab > --- > arch/powerpc/kernel/prom_init.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Acked-by: Rob Herring (Arm)

[PATCH 1/2] of/unittest: Add test that of_address_to_resource() fails on non-translatable address

2025-01-10 Thread Rob Herring (Arm)
of_address_to_resource() on a non-translatable address should return an error. Additionally, this case also triggers a spurious WARN for missing #address-cells/#size-cells. Signed-off-by: Rob Herring (Arm) --- drivers/of/unittest-data/tests-platform.dtsi | 13 + drivers/of

[PATCH 2/2] of/address: Fix WARN when attempting translating non-translatable addresses

2025-01-10 Thread Rob Herring (Arm)
make the default require an #address-cells property. That should be safe to do as any platform missing #address-cells would have a warning already. Fixes: 045b14ca5c36 ("of: WARN on deprecated #address-cells/#size-cells handling") Signed-off-by: Rob Herring (Arm) --- drivers/of/addr

[PATCH] ASoC: Use of_property_present() for non-boolean properties

2025-01-09 Thread Rob Herring (Arm)
The use of of_property_read_bool() for non-boolean properties is deprecated in favor of of_property_present() when testing for property presence. Signed-off-by: Rob Herring (Arm) --- sound/soc/fsl/fsl-asoc-card.c| 2 +- sound/soc/fsl/imx-audmux.c | 2

Re: [PATCH] of: address: Unify resource bounds overflow checking

2025-01-08 Thread Rob Herring
On Wed, Jan 8, 2025 at 8:04 AM Basharath Hussain Khaja wrote: > > Hi, > > >> Thomas Weißschuh writes: > >> > The members "start" and "end" of struct resource are of type > >> > "resource_size_t" which can be 32bit wide. > >> > Values read from OF however are always 64bit wide. > >> > > >> > Refac

Re: [PATCH 14/19] powerpc: mpc83xx: Switch to of_platform_populate

2025-01-05 Thread Rob Herring
On Sat, Jan 4, 2025 at 8:50 AM J. Neuschäfer wrote: > > On Thu, Jan 02, 2025 at 12:51:47PM -0600, Rob Herring wrote: > > On Thu, Jan 2, 2025 at 12:32 PM J. Neuschäfer via B4 Relay > > wrote: > > > > > > From: "J. Neuschäfer"

Re: [PATCH 00/19] powerpc: MPC83xx cleanup and LANCOM NWAPP2 board

2025-01-03 Thread Rob Herring (Arm)
On Thu, 02 Jan 2025 19:31:41 +0100, J. Neuschäfer wrote: > This patchset adds a devicetree for the LANCOM NWAPP2 board based on the > MPC8314E platform, and slightly modernizes the MPC83xx platform support > in the process. > > This board is nominally end-of-life, but available to hobbyists. > A

Re: [PATCH 14/19] powerpc: mpc83xx: Switch to of_platform_populate

2025-01-02 Thread Rob Herring
On Thu, Jan 2, 2025 at 12:32 PM J. Neuschäfer via B4 Relay wrote: > > From: "J. Neuschäfer" > > Quoting from drivers/of/platform.c: > > > of_platform_populate() - [...] > > Similar to of_platform_bus_probe(), this function walks the device > > tree and creates devices from nodes. It differs in t

Re: [PATCH] dt-bindings: soc: fsl: cpm_qe: Limit matching to nodes with "fsl,qe"

2024-12-03 Thread Rob Herring
On Mon, Dec 02, 2024 at 12:57:55PM +0800, Chen-Yu Tsai wrote: > Otherwise the binding matches against random nodes with "simple-bus" > giving out all kinds of invalid warnings: > > $ make CHECK_DTBS=y mediatek/mt8188-evb.dtb > SYNCinclude/config/auto.conf.cmd > UPD include/

Re: [PATCH v2] of: WARN on deprecated #address-cells/#size-cells handling

2024-12-02 Thread Rob Herring
On Mon, Dec 2, 2024 at 4:09 PM Segher Boessenkool wrote: > > On Mon, Dec 02, 2024 at 08:18:22AM -0600, Rob Herring wrote: > > On Wed, Nov 27, 2024 at 3:47 PM Segher Boessenkool > > wrote: > > > On Tue, Nov 26, 2024 at 02:36:32PM +1100, Michael Ellerman wrote: >

Re: [PATCH v2] of: WARN on deprecated #address-cells/#size-cells handling

2024-12-02 Thread Rob Herring
On Wed, Nov 27, 2024 at 3:47 PM Segher Boessenkool wrote: > > On Tue, Nov 26, 2024 at 02:36:32PM +1100, Michael Ellerman wrote: > > Michael Ellerman writes: > > > "Rob Herring (Arm)" writes: > > >> While OpenFirmware originally allowed walking pare

Re: [PATCH] powerpc/prom_init: Fixup missing powermac #size-cells

2024-11-26 Thread Rob Herring
it fixup_device_tree_pmac(void) > +{ > + __be32 val = 1; > + char type[8]; > + phandle node; I suppose you are keeping the existing style, but you could use IS_ENABLED() here instead of #ifdef. Either way, Reviewed-by: Rob Herring

Re: [PATCH v2] of: WARN on deprecated #address-cells/#size-cells handling

2024-11-15 Thread Rob Herring
On Thu, Nov 14, 2024 at 6:59 AM Segher Boessenkool wrote: > > On Thu, Nov 07, 2024 at 10:35:58PM +1100, Michael Ellerman wrote: > > "Rob Herring (Arm)" writes: > > > While OpenFirmware originally allowed walking parent nodes and default > > > root values

[PATCH] dt-bindings: Unify "fsl,liodn" type definitions

2024-11-13 Thread Rob Herring (Arm)
The type definition of "fsl,liodn" is defined as uint32 in crypto/fsl,sec-v4.0.yaml and uint32-array in soc/fsl/fsl,bman.yaml, soc/fsl/fsl,qman-portal.yaml, and soc/fsl/fsl,qman.yaml. Unify the type to be uint32-array and constraint the single entry cases. Signed-off-by: Rob He

Re: [PATCH net-next] net: use pdev instead of OF funcs

2024-11-11 Thread Rob Herring
On Sat, Nov 9, 2024 at 5:40 PM Rosen Penev wrote: > > np here is ofdev->dev.of_node. Better to use the proper functions as > there's no use of children or anything else. Your commit message needs some work. > Signed-off-by: Rosen Penev > --- > drivers/net/can/grcan.c | 2

Re: [PATCH v2] of: WARN on deprecated #address-cells/#size-cells handling

2024-11-08 Thread Rob Herring
On Fri, Nov 8, 2024 at 8:33 AM Steven Price wrote: > > On 08/11/2024 14:04, Rob Herring wrote: > > On Fri, Nov 8, 2024 at 7:26 AM Steven Price wrote: > >> > >> On 08/11/2024 11:04, Marek Szyprowski wrote: > >>> Hi Rob, > >>> > >&

Re: [PATCH v2] of: WARN on deprecated #address-cells/#size-cells handling

2024-11-08 Thread Rob Herring
On Fri, Nov 8, 2024 at 7:26 AM Steven Price wrote: > > On 08/11/2024 11:04, Marek Szyprowski wrote: > > Hi Rob, > > > > On 06.11.2024 18:10, Rob Herring (Arm) wrote: > >> While OpenFirmware originally allowed walking parent nodes and default > >> root

Re: [PATCH v2] of: WARN on deprecated #address-cells/#size-cells handling

2024-11-08 Thread Rob Herring
On Fri, Nov 8, 2024 at 5:04 AM Marek Szyprowski wrote: > > Hi Rob, > > On 06.11.2024 18:10, Rob Herring (Arm) wrote: > > While OpenFirmware originally allowed walking parent nodes and default > > root values for #address-cells and #size-cells, FDT has long required > &

Re: [PATCH 1/2] Documentation: dt-bindings: Fix repeated words

2024-11-07 Thread Rob Herring
On Wed, Nov 06, 2024 at 11:11:23PM -0700, Abhinav Saxena wrote: > Fix unintentional word repetitions in devicetree binding documentation: > - usb.txt: Fix repeated "two" > - mvebu-devbus.txt: Fix repeated "from" > - gpio.txt: Fix repeated "Both" > - pinctrl-bindings.txt: Fix repeated "device" > - c

Re: [PATCH 2/2] Documentation: dt-bindings: Remove trailing whitespace

2024-11-07 Thread Rob Herring
On Thu, Nov 07, 2024 at 12:07:46PM +0100, Krzysztof Kozlowski wrote: > On Wed, Nov 06, 2024 at 11:11:24PM -0700, Abhinav Saxena wrote: > > Remove trailing whitespace from devicetree binding documentation files: > > - regulator/regulator-max77620.txt > > - interrupt-controller/nvidia,tegra20-ictlr.t

[PATCH] powerpc: cell: Use for_each_of_range() iterator

2024-11-06 Thread Rob Herring (Arm)
Simplify the cell_iommu_get_fixed_address() dma-ranges parsing to use the for_each_of_range() iterator. Signed-off-by: Rob Herring (Arm) --- arch/powerpc/platforms/cell/iommu.c | 49 ++--- 1 file changed, 16 insertions(+), 33 deletions(-) diff --git a/arch/powerpc

[PATCH] powerpc: 44x: Use for_each_of_range() iterator

2024-11-06 Thread Rob Herring (Arm)
Simplify the ppc44x PCI dma-ranges parsing to use the for_each_of_range() iterator. Signed-off-by: Rob Herring (Arm) --- arch/powerpc/platforms/44x/pci.c | 23 +-- 1 file changed, 9 insertions(+), 14 deletions(-) diff --git a/arch/powerpc/platforms/44x/pci.c b/arch/powerpc

Re: [PATCH] tpm: atmel: Drop PPC64 specific MMIO setup

2024-11-06 Thread Rob Herring
On Wed, Nov 6, 2024 at 12:19 PM Jarkko Sakkinen wrote: > > On Wed Nov 6, 2024 at 8:17 PM EET, Jarkko Sakkinen wrote: > > > Whatever happened to this? Can you please apply my patch if you don't > > > have the time for further rework. > > > > Sorry unintentional. > > > > I applied with > > > > -stat

[PATCH v2] of: WARN on deprecated #address-cells/#size-cells handling

2024-11-06 Thread Rob Herring (Arm)
ff-by: Rob Herring (Arm) --- v2: - Add a define for excluded platforms to help clarify the intent is to have an exclude list and make adding platforms easier. - Also warn when walking parent nodes. --- drivers/of/base.c | 28 ++-- drivers/of/fdt.c | 4 ++-- 2

Re: [PATCH] tpm: atmel: Drop PPC64 specific MMIO setup

2024-11-06 Thread Rob Herring
On Thu, Jul 18, 2024 at 11:01 AM Jarkko Sakkinen wrote: > > On Thu Jul 18, 2024 at 5:57 PM EEST, Rob Herring wrote: > > On Wed, Jul 17, 2024 at 6:14 AM Jarkko Sakkinen > > wrote: > > > > > > On Wed Jul 17, 2024 at 3:08 PM EEST, Jarkko Sakkinen wrote: > &

Re: [PATCH v2] of/fdt: add dt_phys arg to early_init_dt_scan and early_init_dt_verify

2024-10-28 Thread Rob Herring
Mark Rutland > > Signed-off-by: Usama Arif > > Fixes: ac10be5cdbfa ("arm64: Use common of_kexec_alloc_and_setup_fdt()") > > --- > > v1 -> 2: > > - pass dt_phys in early_init_dt_scan instead of creating > > anorther arch->dt function (Rob Herring) &g

Re: [PATCH v2] of/fdt: add dt_phys arg to early_init_dt_scan and early_init_dt_verify

2024-10-25 Thread Rob Herring
On Wed, Oct 23, 2024 at 12:14 PM Usama Arif wrote: > > __pa() is only intended to be used for linear map addresses and using > it for initial_boot_params which is in fixmap for arm64 will give an > incorrect value. Hence save the physical address when it is known at > boot time when calling early

Re: [PATCH] of: address: Unify resource bounds overflow checking

2024-09-13 Thread Rob Herring
On Fri, Sep 13, 2024 at 8:15 AM Michael Ellerman wrote: > > Thomas Weißschuh writes: > > The members "start" and "end" of struct resource are of type > > "resource_size_t" which can be 32bit wide. > > Values read from OF however are always 64bit wide. > > > > Refactor the diff overflow checks int

Re: [Patch v5 02/12] dt-bindings: dma: Add lpc32xx DMA mux binding

2024-09-10 Thread Rob Herring (Arm)
On Thu, 27 Jun 2024 17:00:20 +0200, Piotr Wojtaszczyk wrote: > LPC32XX SoCs use pl080 dma controller which have few request signals > multiplexed between peripherals. This binding describes how devices can > use the multiplexed request signals. > > Signed-off-by: Piotr Wojtaszczyk > --- > Changes

Re: [PATCH 1/1] dt-bindings: soc: fsl: cpm_qe: convert network.txt to yaml

2024-08-15 Thread Rob Herring (Arm)
On Mon, 12 Aug 2024 12:50:35 -0400, Frank Li wrote: > Convert binding doc newwork.txt to yaml format. > > HDLC part: > - Convert to "fsl,ucc-hdlc.yaml". > - Add missed reg and interrupt property. > - Update example to pass build. > > ethernet part: > - Convert to net/fsl,cpm-enet.yaml > - Add 0

Re: [PATCH v2 23/36] dt-bindings: soc: fsl: cpm_qe: Add QUICC Engine (QE) QMC controller

2024-08-13 Thread Rob Herring
On Thu, Aug 08, 2024 at 09:11:16AM +0200, Herve Codina wrote: > Add support for the QMC (QUICC Multichannel Controller) available in > some PowerQUICC SoC that uses a QUICC Engine (QE) block such as MPC8321. > > This QE QMC is similar to the CPM QMC except that it uses UCCs (Unified > Communicatio

Re: [PATCH v2 07/36] dt-bindings: soc: fsl: cpm_qe: Add QUICC Engine (QE) TSA controller

2024-08-13 Thread Rob Herring (Arm)
c/fsl/cpm_qe/fsl,qe-tsa.yaml | 210 ++ > include/dt-bindings/soc/qe-fsl,tsa.h | 13 ++ > 2 files changed, 223 insertions(+) > create mode 100644 > Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,qe-tsa.yaml > create mode 100644 include/dt-bindings/soc/qe-fsl,tsa.h > Reviewed-by: Rob Herring (Arm)

Re: [PATCH v3] PCI: Fix crash during pci_dev hot-unplug on pseries KVM guest

2024-08-13 Thread Rob Herring (Arm)
out_destroy_cset’ defined but > not used [-Wunused-label] > 696 | out_destroy_cset: > | ^~~~ > * V1: > https://lore.kernel.org/all/20240703141634.2974589-1-amach...@linux.ibm.com/ > > drivers/pci/of.c | 3 ++- > include/linux/of.h | 1 + > 2 files changed, 3 insertions(+), 1 deletion(-) > Reviewed-by: Rob Herring (Arm)

Re: [PATCH v3] PCI: Fix crash during pci_dev hot-unplug on pseries KVM guest

2024-08-13 Thread Rob Herring
On Tue, Aug 06, 2024 at 03:00:59PM -0500, Bjorn Helgaas wrote: > On Sat, Aug 03, 2024 at 12:03:25AM +0530, Amit Machhiwal wrote: > > With CONFIG_PCI_DYNAMIC_OF_NODES [1], a hot-plug and hot-unplug sequence > > of a PCI device attached to a PCI-bridge causes following kernel Oops on > > a pseries KV

Re: [PATCH] dt-bindings: fsl: fsl,rcpm: fix unevaluated fsl,rcpm-wakeup property

2024-08-12 Thread Rob Herring (Arm)
On Sun, 11 Aug 2024 17:35:07 +0200, Krzysztof Kozlowski wrote: > Drop the RCPM consumer example from the binding (LPUART device node), > because: > 1. Using phandles is typical syntax, thus explaining it is not needed in >the provider binding, > 2. It has 'fsl,rcpm-wakeup' property which is n

Re: [PATCH v2 1/1] dt-bindings: soc: fsl: add missed compatible string fsl,ls*-isc

2024-08-06 Thread Rob Herring (Arm)
On Tue, 06 Aug 2024 12:21:21 -0400, Frank Li wrote: > Add compatible string, fsl,ls1088a-isc, fsl,ls2080a-isc, fsl,lx2160a-isc. > Fix the below warning: > arch/arm64/boot/dts/freescale/fsl-ls2080a-qds.dtb: /soc/syscon@1f7: > failed to match any schema with compatible: ['fsl,ls2080a-isc', 'sy

Re: [PATCH v4 1/1] dt-bindings: soc: fsl: Convert rcpm to yaml format

2024-08-06 Thread Rob Herring (Arm)
On Fri, 02 Aug 2024 11:22:19 -0400, Frank Li wrote: > Convert dt-binding rcpm from txt to yaml format. > Add fsl,ls1028a-rcpm compatible string. > > Additional changes: > - Add missed compatible string fsl,-rcpm. > - Remove map fsl,-rcpm to fsl,qoriq-rcpm-. > > Signed-off-by: Frank Li > --- >

Re: [PATCH] powerpc: dtc: update P2020RDB dts

2024-08-01 Thread Rob Herring
On Wed, Jul 31, 2024 at 11:14 PM Pawel Dembicki wrote: > On the subject, every patch is an 'update'. Please make it more specific. If you have a hard time coming up with something specific, that's a sign your patch is making too many separate changes. > P2020RDB contains multiple peripherals, wh

Re: [PATCH] powerpc: dtc: update P2020RDB dts

2024-08-01 Thread Rob Herring (Arm)
On Thu, 01 Aug 2024 07:14:01 +0200, Pawel Dembicki wrote: > P2020RDB contains multiple peripherals, which isn't added to > devicetree: > - Switch: Microchip VSC7385 > - PMIC: Renesas ZL2006 > - Temperature sensor: Analog Devices ADT7461 > - Two eeproms: 24C256 and 24C01 > - GPIO expande

Re: [PATCH v2 1/1] dt-bindings: soc: fsl: Convert rcpm to yaml format

2024-07-31 Thread Rob Herring
On Wed, Jul 31, 2024 at 11:04:20AM -0400, Frank Li wrote: > Convert dt-binding rcpm from txt to yaml format. > Add fsl,ls1028a-rcpm compatible string. > > Additional changes: > - Add missed compatible string fsl,-rcpm. > - Remove map fsl,-rcpm to fsl,qoriq-rcpm-. > > Signed-off-by: Frank Li > --

[PATCH] powerpc: Use of_property_present()

2024-07-31 Thread Rob Herring (Arm)
freed. Signed-off-by: Rob Herring (Arm) --- arch/powerpc/platforms/powernv/eeh-powernv.c | 2 +- arch/powerpc/platforms/powernv/opal-lpc.c| 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/platforms/powernv/eeh-powernv.c b/arch/powerpc/platforms/powernv/eeh

[PATCH] cpufreq: Use of_property_present()

2024-07-31 Thread Rob Herring (Arm)
allocated nodes which may be freed. Signed-off-by: Rob Herring (Arm) --- drivers/cpufreq/cpufreq-dt.c | 11 +++ drivers/cpufreq/pmac64-cpufreq.c | 2 +- drivers/cpufreq/sti-cpufreq.c | 2 +- drivers/cpufreq/sun50i-cpufreq-nvmem.c | 2 +- 4 files changed, 6 insertions

Re: [PATCH 1/1] dt-bindings: soc: fsl: Convert rcpm to yaml format

2024-07-30 Thread Rob Herring
On Mon, Jul 29, 2024 at 03:11:42PM -0400, Frank Li wrote: > Convert dt-binding rcpm from txt to yaml format. > Add fsl,ls1028a-rcpm compatible string. > > Signed-off-by: Frank Li > --- > .../bindings/rtc/fsl,ls-ftm-alarm.yaml| 2 +- > .../devicetree/bindings/soc/fsl/fsl,rcpm.yaml | 91 +

Re: [PATCH v1 23/36] dt-bindings: soc: fsl: cpm_qe: Add QUICC Engine (QE) QMC controller

2024-07-30 Thread Rob Herring
On Mon, Jul 29, 2024 at 04:20:52PM +0200, Herve Codina wrote: > Add support for the QMC (QUICC Multichannel Controller) available in > some PowerQUICC SoC that uses a QUICC Engine (QE) block such as MPC8321. > > This QE QMC is similar to the CPM QMC except that it uses UCCs (Unified > Communicatio

Re: [PATCH v1 07/36] dt-bindings: soc: fsl: cpm_qe: Add QUICC Engine (QE) TSA controller

2024-07-30 Thread Rob Herring
On Mon, Jul 29, 2024 at 04:20:36PM +0200, Herve Codina wrote: > Add support for the time slot assigner (TSA) available in some > PowerQUICC SoC that uses a QUICC Engine (QE) block such as MPC8321. > > This QE TSA is similar to the CPM TSA except that it uses UCCs (Unified > Communication Controlle

[PATCH 2/2] cxl: Use of_property_ accessor functions

2024-07-29 Thread Rob Herring (Arm)
property data. Signed-off-by: Rob Herring (Arm) --- drivers/misc/cxl/of.c | 106 ++--- drivers/misc/cxl/pci.c | 32 ++- 2 files changed, 33 insertions(+), 105 deletions(-) diff --git a/drivers/misc/cxl/of.c b/drivers/misc/cxl/of.c index

[PATCH 0/2] cxl: DT property accessor cleanups

2024-07-29 Thread Rob Herring (Arm)
remove DT functions leaking DT data (e.g. of_get_property()). Signed-off-by: Rob Herring (Arm) --- Rob Herring (Arm) (2): cxl: Drop printing of DT properties cxl: Use of_property_ accessor functions drivers/misc/cxl/of.c | 207

[PATCH 1/2] cxl: Drop printing of DT properties

2024-07-29 Thread Rob Herring (Arm)
There's little reason to dump DT property values when they can be read at any time from the DT in /proc/device-tree. If such a feature is needed, then it really should be implemented in the DT core such that any module/driver can use it. Signed-off-by: Rob Herring (Arm) --- drivers/mis

Re: [PATCH v2] PCI: Fix crash during pci_dev hot-unplug on pseries KVM guest

2024-07-26 Thread Rob Herring
On Thu, Jul 25, 2024 at 6:06 PM Lizhi Hou wrote: > > Hi Amit, > > > I try to follow the option which add a OF flag. If Rob is ok with this, > I would suggest to use it instead of V1 patch > > diff --git a/drivers/of/dynamic.c b/drivers/of/dynamic.c > index dda6092e6d3a..a401ed0463d9 100644 > --- a

Re: [PATCH v2] PCI: Fix crash during pci_dev hot-unplug on pseries KVM guest

2024-07-26 Thread Rob Herring
+ Ubuntu kernel list, again On Thu, Jul 25, 2024 at 11:15:39PM +0530, Amit Machhiwal wrote: > Hi Lizhi, Rob, > > Sorry for responding late. I got busy with some other things. > > On 2024/07/23 02:08 PM, Lizhi Hou wrote: > > > > On 7/23/24 12:54, Rob Herring wrote: &g

Re: [PATCH v2] of: remove internal arguments from of_property_for_each_u32()

2024-07-24 Thread Rob Herring
On Thu, Jul 18, 2024 at 1:57 AM Luca Ceresoli wrote: > > Hello Stephen, > > On Wed, 17 Jul 2024 16:33:34 -0700 > Stephen Boyd wrote: > > > > @@ -1191,20 +1191,24 @@ static int si5351_dt_parse(struct i2c_client > > > *client, > > > * property silabs,pll-source : , [<..>] > > > *

Re: [PATCH v2] PCI: Fix crash during pci_dev hot-unplug on pseries KVM guest

2024-07-23 Thread Rob Herring
On Tue, Jul 23, 2024 at 12:21 PM Lizhi Hou wrote: > > > On 7/23/24 09:21, Rob Herring wrote: > > On Mon, Jul 15, 2024 at 01:52:30PM -0700, Lizhi Hou wrote: > >> On 7/15/24 11:55, Rob Herring wrote: > >>> On Mon, Jul 15, 2024 at 2:08 AM Amit

Re: [PATCH v2] PCI: Fix crash during pci_dev hot-unplug on pseries KVM guest

2024-07-23 Thread Rob Herring
On Mon, Jul 15, 2024 at 01:52:30PM -0700, Lizhi Hou wrote: > > On 7/15/24 11:55, Rob Herring wrote: > > On Mon, Jul 15, 2024 at 2:08 AM Amit Machhiwal > > wrote: > > > With CONFIG_PCI_DYNAMIC_OF_NODES [1], a hot-plug and hot-unplug sequence > > > of a PCI de

Re: [PATCH] tpm: atmel: Drop PPC64 specific MMIO setup

2024-07-18 Thread Rob Herring
On Wed, Jul 17, 2024 at 6:14 AM Jarkko Sakkinen wrote: > > On Wed Jul 17, 2024 at 3:08 PM EEST, Jarkko Sakkinen wrote: > > On Tue Jul 2, 2024 at 7:10 PM EEST, Rob Herring (Arm) wrote: > > > The PPC64 specific MMIO setup open codes DT address functions rather > > &g

Re: [PATCH v2] PCI: Fix crash during pci_dev hot-unplug on pseries KVM guest

2024-07-15 Thread Rob Herring
On Mon, Jul 15, 2024 at 2:08 AM Amit Machhiwal wrote: > > With CONFIG_PCI_DYNAMIC_OF_NODES [1], a hot-plug and hot-unplug sequence > of a PCI device attached to a PCI-bridge causes following kernel Oops on > a pseries KVM guest: > > RTAS: event: 2, Type: Hotplug Event (229), Severity: 1 > Kernel

Re: [PATCH] PCI: Fix crash during pci_dev hot-unplug on pseries KVM guest

2024-07-11 Thread Rob Herring
+Ubuntu kernel team On Thu, Jul 11, 2024 at 8:21 AM Amit Machhiwal wrote: > > Hi Rob, > > On 2024/07/11 06:20 AM, Rob Herring wrote: > > On Wed, Jul 3, 2024 at 8:17 AM Amit Machhiwal > > wrote: > > > > > > With CONFIG_PCI_DYNAMIC_OF_NODES [1], a hot-p

Re: [PATCH] PCI: Fix crash during pci_dev hot-unplug on pseries KVM guest

2024-07-11 Thread Rob Herring
On Wed, Jul 3, 2024 at 8:17 AM Amit Machhiwal wrote: > > With CONFIG_PCI_DYNAMIC_OF_NODES [1], a hot-plug and hot-unplug sequence > of a PCI device attached to a PCI-bridge causes following kernel Oops on > a pseries KVM guest: Can I ask why you have this option on in the first place? Do you have

Re: [PowerPC] [PASEMI] Issue with the identification of ATA drives after the of/irq updates 2024-05-29

2024-07-10 Thread Rob Herring
On Tue, Jul 9, 2024 at 9:53 PM Christian Zigotzky wrote: > > Hi All, > > The RC7 of kernel 6.10 boots without any problems [1] if we use the > second irq patch [2]. Is it possible to add this patch to the mainline > kernel? Yes, sent it to Linus yesterday. Rob

Re: [PATCH 1/2] dt-bindings: soc: fsl: Add fsl,ls1028a-reset for reset syscon node

2024-07-08 Thread Rob Herring (Arm)
On Wed, 03 Jul 2024 14:08:11 -0400, Frank Li wrote: > ls1028a has a reset module that includes reboot, reset control word, and > service processor control. > > Add platform specific compatible string to fix the below warning. > > syscon@1e6: compatible: 'anyOf' conditional failed, one must

  1   2   3   4   5   6   7   8   9   10   >