Re: [PATCH 20/33] docs: ABI: testing: make the files compatible with ReST output

2020-10-28 Thread Richard Cochran
On Wed, Oct 28, 2020 at 03:23:18PM +0100, Mauro Carvalho Chehab wrote: > diff --git a/Documentation/ABI/testing/sysfs-uevent > b/Documentation/ABI/testing/sysfs-uevent > index aa39f8d7bcdf..d0893dad3f38 100644 > --- a/Documentation/ABI/testing/sysfs-uevent > +++ b/Documentation/ABI/testing/sysfs-

Re: [EXT] Re: [PATCH v1] timer:clock:ptp: add support the dynamic posix clock alarm set for ptp

2019-05-08 Thread Richard Cochran
On Wed, May 08, 2019 at 07:36:54AM -0700, Richard Cochran wrote: > No the alarm functionality has been removed. It will not be coming > back, unless there are really strong arguments to support it. Here is some more background: commit 3a06c7ac24f9f24ec059cd77c2dbdf7fbfd0aaaf

Re: [EXT] Re: [PATCH v1] timer:clock:ptp: add support the dynamic posix clock alarm set for ptp

2019-05-08 Thread Richard Cochran
On Wed, May 08, 2019 at 03:30:01AM +, Po Liu wrote: > > Sorry, NAK, since we decided some time ago not to support timer_* operations > > on dynamic clocks. You get much better application level timer performance > > by synchronizing CLOCK_REALTIME to your PHC and using clock_nanosleep() > > wi

Re: [PATCH v1] timer:clock:ptp: add support the dynamic posix clock alarm set for ptp

2019-05-07 Thread Richard Cochran
On Sun, May 05, 2019 at 05:02:05AM +, Po Liu wrote: > Current kernel code do not support the dynamic posix clock alarm set. > This code would support it by the posix timer structure. > > 319 const struct k_clock clock_posix_dynamic = { > > 320 .clock_getres = pc_clock_getres, > 321

Re: [PATCH 3/3] ptp_qoriq: convert to use module parameters for initialization

2018-07-31 Thread Richard Cochran
On Wed, Aug 01, 2018 at 04:36:40AM +, Y.b. Lu wrote: > Could I add a function to calculate a set of default register values > to initialize ptp timer when dts method failed to get required > properties in driver? Yes, it would be ideal if the driver can pick correct values automatically. How

Re: [PATCH 3/3] ptp_qoriq: convert to use module parameters for initialization

2018-07-30 Thread Richard Cochran
On Mon, Jul 30, 2018 at 06:01:54PM +0800, Yangbo Lu wrote: > The ptp_qoriq driver initialized the 1588 timer with the > configurations provided by the properties of device tree > node. For example, > > fsl,tclk-period = <5>; > fsl,tmr-prsc= <2>; > fsl,tmr-add = <0xaaab>; > fsl,

Re: [v3, 00/10] Support DPAA PTP clock and timestamping

2018-06-07 Thread Richard Cochran
hen you do re-post, you can add my: Acked-by: Richard Cochran

Re: [PATCH 09/10] dpaa_eth: add support for hardware timestamping

2018-06-05 Thread Richard Cochran
On Tue, Jun 05, 2018 at 03:35:28AM +, Y.b. Lu wrote: > [Y.b. Lu] Actually these timestamping codes affected DPAA networking > performance in our previous performance test. > That's why we used ifdef for it. How much does time stamping hurt performance? If the time stamping is compiled in but

Re: [PATCH 09/10] dpaa_eth: add support for hardware timestamping

2018-06-04 Thread Richard Cochran
On Mon, Jun 04, 2018 at 03:08:36PM +0800, Yangbo Lu wrote: > +if FSL_DPAA_ETH > +config FSL_DPAA_ETH_TS > + bool "DPAA hardware timestamping support" > + select PTP_1588_CLOCK_QORIQ > + default n > + help > + Enable DPAA hardware timestamping support. > + This option is

Re: [Y2038] [PATCH 04/11] posix timers:Introduce the 64bit methods with timespec64 type for k_clock structure

2015-04-22 Thread Richard Cochran
On Wed, Apr 22, 2015 at 03:50:45PM +0200, Arnd Bergmann wrote: > time, stime, gettimeofday, settimeofday, adjtimex, nanosleep, > getitimer, setitimer: > all deprecated => wontfix If adjtimex is deprecated, what will replace it? It is really important for ntp. Thanks, Richard __

Re: [Y2038] [PATCH 04/11] posix timers:Introduce the 64bit methods with timespec64 type for k_clock structure

2015-04-22 Thread Richard Cochran
On Wed, Apr 22, 2015 at 10:45:23AM +0200, Thomas Gleixner wrote: > So we could save one translation step if we implement new syscalls > which have a scalar nsec interface instead of the timespec/timeval > cruft and let user space do the translation to whatever it wants. +1 > I personally would we

Re: [PATCH 11/11] k_clock:Remove the 32bit methods with timespec type

2015-04-20 Thread Richard Cochran
On Mon, Apr 20, 2015 at 01:57:39PM +0800, Baolin Wang wrote: > @@ -911,18 +907,14 @@ retry: > return -EINVAL; > > kc = clockid_to_kclock(timr->it_clock); > - if (WARN_ON_ONCE(!kc || (!kc->timer_set && !kc->timer_set64))) { > + if (WARN_ON_ONCE(!kc || !kc->timer_set64)

Re: [PATCH V3] tick/broadcast: Make movement of broadcast hrtimer robust against hotplug

2015-01-28 Thread Richard Cochran
On Wed, Jan 28, 2015 at 03:32:58PM +0530, Preeti U Murthy wrote: > Thomas ping. Would you be posting this patch? FYI, Thomas is temporarily out of action, in bed with the flu. Thanks, Richard ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org h

Re: [PATCH v2] powerpc/83xx: gianfar_ptp: select 1588 clock source through dts file

2013-09-25 Thread Richard Cochran
Acked-by: Richard Cochran ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH] powerpc/83xx: gianfar_ptp: select 1588 clock source through dts file

2013-09-24 Thread Richard Cochran
On Tue, Sep 24, 2013 at 11:39:57AM +0400, Aida Mynzhasova wrote: > Currently IEEE 1588 timer reference clock source is determined through > hard-coded value in gianfar_ptp driver. This patch allows to select ptp > clock source by means of device tree file node. > > For instance: > > fsl,cks

Re: [PATCH] gianfar: add missing include

2012-04-09 Thread Richard Cochran
for the fix. Acked-by: Richard Cochran ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [git pull] Please pull powerpc.git merge branch

2011-05-20 Thread Richard Cochran
On Fri, May 20, 2011 at 09:58:45AM -0400, Josh Boyer wrote: > On Fri, May 20, 2011 at 03:23:29PM +0200, Richard Cochran wrote: > >When I try to build 'next' (now at 208b3a4c), it does not compile due > >to a change from the following commit. > > > >> Benjam

Re: [git pull] Please pull powerpc.git merge branch

2011-05-20 Thread Richard Cochran
On Thu, May 19, 2011 at 02:06:18PM +1000, Benjamin Herrenschmidt wrote: > are available in the git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/benh/powerpc.git merge When I try to build 'next' (now at 208b3a4c), it does not compile due to a change from the following commit.

Re: powerpc: mpc85xx regression since 2.6.39-rc2, one cpu core lame

2011-05-18 Thread Richard Cochran
On Wed, May 18, 2011 at 07:40:16AM +1000, Benjamin Herrenschmidt wrote: > On Tue, 2011-05-17 at 18:28 +0200, Richard Cochran wrote: > > Ben, > > > > Recent 2.6.39-rc kernels behave strangely on the Freescale dual core > > mpc8572 and p2020. There is a long pause (

powerpc: mpc85xx regression since 2.6.39-rc2, one cpu core lame

2011-05-17 Thread Richard Cochran
Ben, Recent 2.6.39-rc kernels behave strangely on the Freescale dual core mpc8572 and p2020. There is a long pause (like 2 seconds) in the boot sequence after "mpic: requesting IPIs..." When the system comes up, only one core shows in /proc/cpuinfo. Later on, lots of messages appear like the foll

[PATCH V15 4/4] ptp: Added a clock driver for the National Semiconductor PHYTER.

2011-04-22 Thread Richard Cochran
This patch adds support for the PTP clock found on the DP83640. The basic clock operations and one external time stamp have been implemented. Signed-off-by: Richard Cochran --- drivers/net/phy/Makefile |1 + drivers/net/phy/dp83640.c | 1100

[PATCH V15 3/4] ptp: Added a clock driver for the IXP46x.

2011-04-22 Thread Richard Cochran
This patch adds a driver for the hardware time stamping unit found on the IXP465. The basic clock operations and an external trigger are implemented. Signed-off-by: Richard Cochran Acked-by: Arnd Bergmann Acked-by: David S. Miller Acked-by: John Stultz Acked-by: Krzysztof Halasa --- arch

[PATCH V15 2/4] ptp: Added a clock that uses the eTSEC found on the MPC85xx.

2011-04-22 Thread Richard Cochran
The eTSEC includes a PTP clock with quite a few features. This patch adds support for the basic clock adjustment functions, plus two external time stamps, one alarm, and the PPS callback. Signed-off-by: Richard Cochran Acked-by: David S. Miller Acked-by: John Stultz --- .../devicetree

[PATCH V15 1/4] ptp: Added a brand new class driver for ptp clocks.

2011-04-22 Thread Richard Cochran
different ways, via the sysfs and by a character device. Signed-off-by: Richard Cochran Acked-by: Arnd Bergmann Acked-by: David S. Miller --- Documentation/ABI/testing/sysfs-ptp | 98 + Documentation/ptp/ptp.txt | 89 Documentation/ptp/testptp.c | 381

[PATCH V15 0/4] ptp: IEEE 1588 hardware clock support

2011-04-22 Thread Richard Cochran
lkml/2010/9/3/119 - POSIX clock tuning syscall with static clock ids http://lkml.org/lkml/2010/8/23/49 - Versions 1-4 appeared on the netdev list. Richard Cochran (4): ptp: Added a brand new class driver for ptp clocks. ptp: Added a clock that uses the eTSEC found on the MPC85xx. ptp: A

Re: [PATCH V14 4/4] ptp: Added a clock driver for the National Semiconductor PHYTER.

2011-04-22 Thread Richard Cochran
On Mon, Apr 18, 2011 at 09:57:25PM +0100, Ben Hutchings wrote: > Would be better without the magic numbers. Yes, of course, you are right, and also about patch #3. Please take a look at v15 and see if it improves things. Thanks, Richard ___ Linuxppc-de

Re: [PATCH V14 3/4] ptp: Added a clock driver for the IXP46x.

2011-04-18 Thread Richard Cochran
Also, I forgot to add Krzysztof's ack to the commit message, but he did ack V12. Thanks, Richard ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH V14 3/4] ptp: Added a clock driver for the IXP46x.

2011-04-18 Thread Richard Cochran
On Mon, Apr 18, 2011 at 08:56:03AM +0200, Arnd Bergmann wrote: > On Monday 18 April 2011, Richard Cochran wrote: > > + > > + lo = __raw_readl(®s->channel[ch].src_uuid_lo); > > + hi = __raw_readl(®s->channel[ch].src_uuid_hi); > > + > > I guess

[PATCH V14 4/4] ptp: Added a clock driver for the National Semiconductor PHYTER.

2011-04-17 Thread Richard Cochran
This patch adds support for the PTP clock found on the DP83640. The basic clock operations and one external time stamp have been implemented. Signed-off-by: Richard Cochran --- drivers/net/phy/Makefile |1 + drivers/net/phy/dp83640.c | 1100

[PATCH V14 3/4] ptp: Added a clock driver for the IXP46x.

2011-04-17 Thread Richard Cochran
This patch adds a driver for the hardware time stamping unit found on the IXP465. The basic clock operations and an external trigger are implemented. Signed-off-by: Richard Cochran Acked-by: John Stultz --- arch/arm/mach-ixp4xx/include/mach/ixp46x_ts.h | 78 ++ drivers/net/arm

[PATCH V14 2/4] ptp: Added a clock that uses the eTSEC found on the MPC85xx.

2011-04-17 Thread Richard Cochran
The eTSEC includes a PTP clock with quite a few features. This patch adds support for the basic clock adjustment functions, plus two external time stamps, one alarm, and the PPS callback. Signed-off-by: Richard Cochran Acked-by: John Stultz --- .../devicetree/bindings/net/fsl-tsec-phy.txt

[PATCH V14 1/4] ptp: Added a brand new class driver for ptp clocks.

2011-04-17 Thread Richard Cochran
different ways, via the sysfs and by a character device. Signed-off-by: Richard Cochran --- Documentation/ABI/testing/sysfs-ptp | 98 + Documentation/ptp/ptp.txt | 89 + Documentation/ptp/testptp.c | 368 +++ Documentation/ptp

[PATCH V14 0/4] ptp: IEEE 1588 hardware clock support

2011-04-17 Thread Richard Cochran
lkml/2010/8/23/49 - Versions 1-4 appeared on the netdev list. Richard Cochran (4): ptp: Added a brand new class driver for ptp clocks. ptp: Added a clock that uses the eTSEC found on the MPC85xx. ptp: Added a clock driver for the IXP46x. ptp: Added a clock driver for the National Semicondu

regression: 2.6.39-rc2,3 compile failure on p2020 (repost)

2011-04-16 Thread Richard Cochran
When compiling mpc85xx_smp_defconfig, the kernel fails to link with: arch/powerpc/kernel/built-in.o: In function `cpu_die': arch/powerpc/kernel/smp.c:702: undefined reference to `start_secondary_resume' I suspect: commit fa3f82c8bb7acbe049ea71f258b3ae0a33d9d40b powerpc/smp: soft-replu

regression: 2.6.39-rc2,3 compile failure on p2020

2011-04-16 Thread Richard Cochran
When compiling mpc85xx_smp_defconfig, the kernel fails to link with: arch/powerpc/kernel/built-in.o: In function `cpu_die': arch/powerpc/kernel/smp.c:702: undefined reference to `start_secondary_resume' I suspect: commit fa3f82c8bb7acbe049ea71f258b3ae0a33d9d40b powerpc/smp: soft-replu

[PATCH] powerpc: rename get_irq_desc_data and get_irq_desc_chip

2011-03-30 Thread Richard Cochran
These two functions disappeared in commit 0c6f8a8b917ad361319c8ace3e9f28e69bfdb4c1 "genirq: Remove compat code" but they still exist in qe_ic.h. This patch renames the function to their new names. Signed-off-by: Richard Cochran --- arch/powerpc/include/asm/qe_i

[PATCH V13 4/4] ptp: Added a clock driver for the National Semiconductor PHYTER.

2011-03-26 Thread Richard Cochran
This patch adds support for the PTP clock found on the DP83640. The basic clock operations and one external time stamp have been implemented. Signed-off-by: Richard Cochran --- drivers/net/phy/Makefile |1 + drivers/net/phy/dp83640.c | 1015

[PATCH V13 3/4] ptp: Added a clock driver for the IXP46x.

2011-03-26 Thread Richard Cochran
This patch adds a driver for the hardware time stamping unit found on the IXP465. The basic clock operations and an external trigger are implemented. Signed-off-by: Richard Cochran Acked-by: John Stultz --- arch/arm/mach-ixp4xx/include/mach/ixp46x_ts.h | 78 ++ drivers/net/arm

[PATCH V13 2/4] ptp: Added a clock that uses the eTSEC found on the MPC85xx.

2011-03-26 Thread Richard Cochran
The eTSEC includes a PTP clock with quite a few features. This patch adds support for the basic clock adjustment functions, plus two external time stamps, one alarm, and the PPS callback. Signed-off-by: Richard Cochran --- .../devicetree/bindings/net/fsl-tsec-phy.txt | 54 ++ arch

[PATCH V13 1/4] ptp: Added a brand new class driver for ptp clocks.

2011-03-26 Thread Richard Cochran
different ways, via the sysfs and by a character device. Signed-off-by: Richard Cochran --- Documentation/ABI/testing/sysfs-ptp | 98 + Documentation/ptp/ptp.txt | 89 + Documentation/ptp/testptp.c | 368 +++ Documentation/ptp

[PATCH V13 0/4] ptp: IEEE 1588 hardware clock support

2011-03-26 Thread Richard Cochran
28/53 - [V11] http://lkml.org/lkml/2011/2/23/107 - [V10] http://lkml.org/lkml/2011/1/27/71 Richard Cochran (4): ptp: Added a brand new class driver for ptp clocks. ptp: Added a clock that uses the eTSEC found on the MPC85xx. ptp: Added a clock driver for the IXP46x. ptp: Added a

Re: [PATCH V12 4/4] ptp: Added a clock driver for the National Semiconductor PHYTER.

2011-03-26 Thread Richard Cochran
On Wed, Mar 23, 2011 at 02:46:25PM -0700, John Stultz wrote: > On Mon, 2011-02-28 at 08:58 +0100, Richard Cochran wrote: > > +static int tdr_write(int bc, struct phy_device *dev, > > +const struct timespec *ts, u16 cmd) > > +{ > > + ext_write(bc, dev,

Re: [PATCH V12 2/4] ptp: Added a clock that uses the eTSEC found on the MPC85xx.

2011-03-26 Thread Richard Cochran
On Wed, Mar 23, 2011 at 02:30:04PM -0700, John Stultz wrote: > On Mon, 2011-02-28 at 08:57 +0100, Richard Cochran wrote: > > +/* > > + * Register access functions > > + */ > > So what are the locking rules on the functions below? I assume the > etsects->lock need

Re: [PATCH V12 1/4] ptp: Added a brand new class driver for ptp clocks.

2011-03-26 Thread Richard Cochran
On Wed, Mar 23, 2011 at 02:19:20PM -0700, John Stultz wrote: > On Mon, 2011-02-28 at 08:57 +0100, Richard Cochran wrote: > > +++ b/drivers/ptp/ptp_clock.c > > @@ -0,0 +1,320 @@ > [snip] > > +static void enqueue_external_timestamp(struct time

Re: [PATCH] powerpc: add clock_adjtime for powerpc

2011-03-24 Thread Richard Cochran
On Thu, Mar 24, 2011 at 04:05:17PM +0100, Richard Cochran wrote: > This patch adds the clock_adjtime system call to the powerpc architecture. Never mind this patch. Stephen Rothwell already posted a patch on linuxppc-dev adding this syscall eariler today. Thanks, Rich

[PATCH] powerpc: add clock_adjtime for powerpc

2011-03-24 Thread Richard Cochran
This patch adds the clock_adjtime system call to the powerpc architecture. The call was introduced in f1f1d5ebd10ffa4242bce7a90a56a222d6b7bc77 Signed-off-by: Richard Cochran --- arch/powerpc/include/asm/systbl.h |1 + arch/powerpc/include/asm/unistd.h |3 ++- 2 files changed, 3

Re: [PATCH V12 0/4] ptp: IEEE 1588 hardware clock support

2011-03-19 Thread Richard Cochran
For all those interested in the user space aspect, I have posted some patches to ptpd project showing how the API works. https://sourceforge.net/tracker/?group_id=139814&atid=744634 3225599 [PATCH 1/3] Convert to POSIX clock API. 3225603 [PATCH 2/3] Adapted to use the Linux PTP Hardware Clock API

Re: [PATCH V12 0/4] ptp: IEEE 1588 hardware clock support

2011-03-16 Thread Richard Cochran
On Mon, Feb 28, 2011 at 08:57:03AM +0100, Richard Cochran wrote: > * PHC Patch ChangeLog > ** v12 > *** gianfar_ptp >- fixed up device tree >- inlined the header file >- use platform_ calls instead of deprecated of_ calls >- removed static global single instanc

[PATCH V12 4/4] ptp: Added a clock driver for the National Semiconductor PHYTER.

2011-02-27 Thread Richard Cochran
This patch adds support for the PTP clock found on the DP83640. The basic clock operations and one external time stamp have been implemented. Signed-off-by: Richard Cochran --- drivers/net/phy/Makefile |1 + drivers/net/phy/dp83640.c | 1012

[PATCH V12 3/4] ptp: Added a clock driver for the IXP46x.

2011-02-27 Thread Richard Cochran
This patch adds a driver for the hardware time stamping unit found on the IXP465. The basic clock operations and an external trigger are implemented. Signed-off-by: Richard Cochran Acked-by: John Stultz --- arch/arm/mach-ixp4xx/include/mach/ixp46x_ts.h | 78 ++ drivers/net/arm

[PATCH V12 2/4] ptp: Added a clock that uses the eTSEC found on the MPC85xx.

2011-02-27 Thread Richard Cochran
The eTSEC includes a PTP clock with quite a few features. This patch adds support for the basic clock adjustment functions, plus two external time stamps, one alarm, and the PPS callback. Signed-off-by: Richard Cochran --- .../devicetree/bindings/net/fsl-tsec-phy.txt | 54 ++ arch

[PATCH V12 1/4] ptp: Added a brand new class driver for ptp clocks.

2011-02-27 Thread Richard Cochran
different ways, via the sysfs and by a character device. Signed-off-by: Richard Cochran --- Documentation/ABI/testing/sysfs-ptp | 98 ++ Documentation/ptp/ptp.txt | 89 + Documentation/ptp/testptp.c | 352 +++ Documentation/ptp

[PATCH V12 0/4] ptp: IEEE 1588 hardware clock support

2011-02-27 Thread Richard Cochran
http://lkml.org/lkml/2010/8/23/49 - Versions 1-4 appeared on the netdev list. Richard Cochran (4): ptp: Added a brand new class driver for ptp clocks. ptp: Added a clock that uses the eTSEC found on the MPC85xx. ptp: Added a clock driver for the IXP46x. ptp: Added a clock driver for the Nat

Re: [PATCH V11 2/4] ptp: Added a clock that uses the eTSEC found on the MPC85xx.

2011-02-24 Thread Richard Cochran
On Thu, Feb 24, 2011 at 11:27:31AM -0600, Scott Wood wrote: > My vote, if it goes in a separate node at all, is "fsl,etsec-ptp", So, that is what the patch does. > and let the driver use SVR. What is SVR? Thanks, Richard ___ Linuxppc-dev mailing list

Re: [PATCH V11 2/4] ptp: Added a clock that uses the eTSEC found on the MPC85xx.

2011-02-24 Thread Richard Cochran
On Wed, Feb 23, 2011 at 09:50:58AM -0700, Grant Likely wrote: > On Wed, Feb 23, 2011 at 11:38:17AM +0100, Richard Cochran wrote: > > +Clock Properties: > > + > > + - tclk-period Timer reference clock period in nanoseconds. > > + - tmr-prsc Prescaler, divides the

Re: [PATCH V11 2/4] ptp: Added a clock that uses the eTSEC found on the MPC85xx.

2011-02-24 Thread Richard Cochran
On Wed, Feb 23, 2011 at 01:24:44PM -0600, Scott Wood wrote: > Whatever string is used should be written into a binding document. > > fsl,etsec-v1.6-ptp seems like it would be just as good for that purpose. > > Even just fsl,etsec-ptp will identify the binding, though it's lacking in > identifying

Re: [PATCH V11 2/4] ptp: Added a clock that uses the eTSEC found on the MPC85xx.

2011-02-24 Thread Richard Cochran
On Wed, Feb 23, 2011 at 10:54:59AM -0700, Grant Likely wrote: > On Wed, Feb 23, 2011 at 11:26:12AM -0600, Scott Wood wrote: > > The eTSEC revision is probeable as well, but due the way PTP is described as > > a separate node, the driver doesn't have straightforward access to those > > registers. >

Re: [PATCH V11 0/4] ptp: IEEE 1588 hardware clock support

2011-02-23 Thread Richard Cochran
* Previous Discussions This patch set previously appeared on the netdev list. Since V5 of the character device patch set, the discussion has moved to the lkml. - IEEE 1588 hardware clock support [V5] http://lkml.org/lkml/2010/8/16/90 - POSIX clock tuning syscall with static clock i

[PATCH V11 3/4] ptp: Added a clock driver for the IXP46x.

2011-02-23 Thread Richard Cochran
This patch adds a driver for the hardware time stamping unit found on the IXP465. The basic clock operations and an external trigger are implemented. Signed-off-by: Richard Cochran Acked-by: John Stultz --- arch/arm/mach-ixp4xx/include/mach/ixp46x_ts.h | 78 ++ drivers/net/arm

[PATCH V11 4/4] ptp: Added a clock driver for the National Semiconductor PHYTER.

2011-02-23 Thread Richard Cochran
This patch adds support for the PTP clock found on the DP83640. The basic clock operations and one external time stamp have been implemented. Signed-off-by: Richard Cochran --- drivers/net/phy/Makefile |1 + drivers/net/phy/dp83640.c | 1012

[PATCH V11 2/4] ptp: Added a clock that uses the eTSEC found on the MPC85xx.

2011-02-23 Thread Richard Cochran
The eTSEC includes a PTP clock with quite a few features. This patch adds support for the basic clock adjustment functions, plus two external time stamps, one alarm, and the PPS callback. Signed-off-by: Richard Cochran Acked-by: John Stultz --- .../devicetree/bindings/net/fsl-tsec-phy.txt

[PATCH V11 1/4] ptp: Added a brand new class driver for ptp clocks.

2011-02-23 Thread Richard Cochran
different ways, via the sysfs and by a character device. Signed-off-by: Richard Cochran --- Documentation/ABI/testing/sysfs-ptp | 98 ++ Documentation/ptp/ptp.txt | 89 + Documentation/ptp/testptp.c | 352 +++ Documentation/ptp

[PATCH V11 0/4] ptp: IEEE 1588 hardware clock support

2011-02-23 Thread Richard Cochran
river handles multiple PHYs Richard Cochran (4): ptp: Added a brand new class driver for ptp clocks. ptp: Added a clock that uses the eTSEC found on the MPC85xx. ptp: Added a clock driver for the IXP46x. ptp: Added a clock driver for the National Semiconductor PHYTER. Documentation/ABI/te

Re: [PATCH v6 0/8] ptp: IEEE 1588 hardware clock support

2010-09-27 Thread Richard Cochran
On Mon, Sep 27, 2010 at 06:05:58PM +0100, Alan Cox wrote: > On Mon, 27 Sep 2010 10:56:09 -0500 (CDT) > Christoph Lameter wrote: > > > > > On Fri, 24 Sep 2010, Alan Cox wrote: > > > > > Whether you add new syscalls or do the fd passing using flags and hide > > > the ugly bits in glibc is another

Re: [PATCH v6 0/8] ptp: IEEE 1588 hardware clock support

2010-09-27 Thread Richard Cochran
On Mon, Sep 27, 2010 at 10:14:23AM -0600, M. Warner Losh wrote: > > This is a common error that I've seen repeated in this thread. The > only reason that it has historically been important is because when > you are doing timestamping in software based on an interrupt, that > stuff does matter. Y

Re: [PATCH v6 0/8] ptp: IEEE 1588 hardware clock support

2010-09-24 Thread Richard Cochran
On Thu, Sep 23, 2010 at 12:38:53PM -0700, john stultz wrote: > On Thu, 2010-09-23 at 19:30 +0200, Richard Cochran wrote: > > /sys/class/timesource//id > > /sys/class/ptp/ptp_clock_X/id > > > So yea, I'm not a fan of the "timesource" sysfs int

Re: [PATCH v6 0/8] ptp: IEEE 1588 hardware clock support

2010-09-24 Thread Richard Cochran
On Thu, Sep 23, 2010 at 09:36:54PM +0100, Alan Cox wrote: > Drop the clockid_t and swap it for a file handle like a proper Unix or > Linux interface. The rest is much the same > > fd = open /sys/class/timesource/[whatever] > > various queries you may want to do to check the name etc >

Re: [PATCH 6/8] ptp: Added a clock that uses the eTSEC found on the MPC85xx.

2010-09-24 Thread Richard Cochran
On Thu, Sep 23, 2010 at 02:17:36PM -0500, Christoph Lameter wrote: > On Thu, 23 Sep 2010, Richard Cochran wrote: > > + These properties set the operational parameters for the PTP > > + clock. You must choose these carefully for the clock to work right. > > + Here is how

Re: [PATCH v6 0/8] ptp: IEEE 1588 hardware clock support

2010-09-24 Thread Richard Cochran
On Thu, Sep 23, 2010 at 12:53:20PM -0500, Christoph Lameter wrote: > On Thu, 23 Sep 2010, Richard Cochran wrote: > > 3.3 Synchronizing the Linux System Time > > > > > >One could offer a PHC as a combined clock source and clo

Re: [PATCH 1/8] posix clocks: introduce a syscall for clock tuning.

2010-09-24 Thread Richard Cochran
On Fri, Sep 24, 2010 at 08:03:43AM +1000, Benjamin Herrenschmidt wrote: > On Thu, 2010-09-23 at 19:31 +0200, Richard Cochran wrote: > > A new syscall is introduced that allows tuning of a POSIX clock. The > > syscall is implemented for four architectures: arm, blackfin, power

Re: [PATCH 1/8] posix clocks: introduce a syscall for clock tuning.

2010-09-24 Thread Richard Cochran
On Thu, Sep 23, 2010 at 12:48:51PM -0700, john stultz wrote: > On Thu, 2010-09-23 at 19:31 +0200, Richard Cochran wrote: > > A new syscall is introduced that allows tuning of a POSIX clock. The > > syscall is implemented for four architectures: arm, blackfin, powerpc, > > and

[PATCH 8/8] ptp: Added a clock driver for the National Semiconductor PHYTER.

2010-09-23 Thread Richard Cochran
This patch adds support for the PTP clock found on the DP83640. The basic clock operations and one external time stamp have been implemented. Signed-off-by: Richard Cochran --- drivers/net/phy/Kconfig | 29 ++ drivers/net/phy/Makefile |1 + drivers/net/phy/dp83640.c | 887

[PATCH 7/8] ptp: Added a clock driver for the IXP46x.

2010-09-23 Thread Richard Cochran
This patch adds a driver for the hardware time stamping unit found on the IXP465. The basic clock operations and an external trigger are implemented. Signed-off-by: Richard Cochran --- arch/arm/mach-ixp4xx/include/mach/ixp46x_ts.h | 78 ++ drivers/net/arm/ixp4xx_eth.c

[PATCH 6/8] ptp: Added a clock that uses the eTSEC found on the MPC85xx.

2010-09-23 Thread Richard Cochran
The eTSEC includes a PTP clock with quite a few features. This patch adds support for the basic clock adjustment functions, plus two external time stamps, one alarm, and the PPS callback. Signed-off-by: Richard Cochran --- Documentation/powerpc/dts-bindings/fsl/tsec.txt | 57 +++ arch/powerpc

[PATCH 5/8] ptp: Added a simulated PTP hardware clock.

2010-09-23 Thread Richard Cochran
. Signed-off-by: Richard Cochran --- drivers/ptp/Kconfig | 14 drivers/ptp/Makefile|1 + drivers/ptp/ptp_linux.c | 165 +++ kernel/time/ntp.c |2 + 4 files changed, 182 insertions(+), 0 deletions(-) create mode 100644 drivers

[PATCH 4/8] ptp: Added a brand new class driver for ptp clocks.

2010-09-23 Thread Richard Cochran
different ways, via the sysfs and by a character device. Signed-off-by: Richard Cochran --- Documentation/ABI/testing/sysfs-ptp | 107 ++ Documentation/ptp/ptp.txt | 94 + Documentation/ptp/testptp.c | 358 Documentation/ptp

[PATCH 3/8] posix clocks: introduce a sysfs presence.

2010-09-23 Thread Richard Cochran
This patch adds a 'timesource' class into sysfs. Each registered POSIX clock appears by name under /sys/class/timesource. The idea is to expose to user space the dynamic mapping between clock devices and clock IDs. Signed-off-by: Richard Cochran --- Documentation/ABI/testing/sysfs-

[PATCH 1/8] posix clocks: introduce a syscall for clock tuning.

2010-09-23 Thread Richard Cochran
expanded by one additional mode flag, which allows an absolute offset correction. When specificied, the clock offset is immediately corrected by adding the given time value to the current time value. Signed-off-by: Richard Cochran --- arch/arm/include/asm/unistd.h |1 + arch/arm/kernel

[PATCH 2/8] posix clocks: dynamic clock ids.

2010-09-23 Thread Richard Cochran
This patch augments the POSIX clock code to offer a dynamic clock creation method. Instead of registering a hard coded clock ID, modules may call create_posix_clock(), which returns a new clock ID. Signed-off-by: Richard Cochran --- include/linux/posix-timers.h |7 ++- include/linux

[PATCH v6 0/8] ptp: IEEE 1588 hardware clock support

2010-09-23 Thread Richard Cochran
1 +/* + * PHYSICAL_ID(p->id) ? + * TODO - Figure out correct mapping. + */ Krzysztof, can you help? Richard Cochran (8): posix clocks: introduce a syscall for clock tuning. posix clocks: dynamic clock ids. posix clocks: introduce a sysfs presence. ptp: Added a brand new clas

Re: [PATCH 1/5] ptp: Added a brand new class driver for ptp clocks.

2010-09-22 Thread Richard Cochran
On Tue, Sep 21, 2010 at 04:47:45PM -0400, Kyle Moffett wrote: > Well how about something much more straightforward: I am about to post another patch set for discussion, so please comment on it when it appears. Thanks, Richard ___ Linuxppc-dev mailing li

Re: [PATCH 1/5] ptp: Added a brand new class driver for ptp clocks.

2010-09-05 Thread Richard Cochran
On Fri, Aug 27, 2010 at 03:30:39PM -0700, John Stultz wrote: > On Fri, 2010-08-27 at 14:38 +0200, Richard Cochran wrote: > > We have not introduced new PPS interface. We use existing PPS subsystem. > > Doesn't the pps subsystem have its own way to control the pps signal

Re: [PATCH 1/5] ptp: Added a brand new class driver for ptp clocks.

2010-08-27 Thread Richard Cochran
On Fri, Aug 27, 2010 at 02:38:44PM +0100, Alan Cox wrote: > > 2007. If we can justify adding a clock id in this case, surely we can > > add one for PTP as well! > > But PTP isn't really a clock - its a time sync protocol. You can (and may > need to) have multiple clocks of this form on the same ho

Re: [PATCH 1/5] ptp: Added a brand new class driver for ptp clocks.

2010-08-27 Thread Richard Cochran
On Fri, Aug 27, 2010 at 01:41:54PM +0100, Alan Cox wrote: > > The master node in a PTP network probably takes its time from a > > precise external time source, like GPS. The GPS provides a 1 PPS > > directly to the PTP clock hardware, which latches the PTP hardware > > clock time on the PPS edge. T

Re: [PATCH 1/5] ptp: Added a brand new class driver for ptp clocks.

2010-08-27 Thread Richard Cochran
On Mon, Aug 23, 2010 at 01:08:45PM -0700, john stultz wrote: > On Thu, 2010-08-19 at 07:55 +0200, Richard Cochran wrote: > > The clockid_t CLOCK_PTP will be arch-neutral. > > Sure, but are they conceptually neutral? There are other clock > synchronization algorithms out the

Re: [PATCH 1/5] ptp: Added a brand new class driver for ptp clocks.

2010-08-27 Thread Richard Cochran
On Mon, Aug 23, 2010 at 01:21:39PM -0700, john stultz wrote: > On Thu, 2010-08-19 at 17:38 +0200, Richard Cochran wrote: > > On Thu, Aug 19, 2010 at 02:28:04PM +0200, Arnd Bergmann wrote: > > > My point was that a syscall is better than an ioctl based interface here, > > &g

Re: [PATCH 1/5] ptp: Added a brand new class driver for ptp clocks.

2010-08-27 Thread Richard Cochran
On Thu, Aug 26, 2010 at 06:57:49PM -0700, john stultz wrote: > On Wed, 2010-08-25 at 11:40 +0200, Christian Riesch wrote: > > 2) Master clock: > > We have one or more network ports. Our system has a really good clock > > (ovenized quartz crystal, an atomic clock, a GPS timing receiver...) > > and i

Re: [PATCH 1/5] ptp: Added a brand new class driver for ptp clocks.

2010-08-19 Thread Richard Cochran
On Thu, Aug 19, 2010 at 02:28:04PM +0200, Arnd Bergmann wrote: > My point was that a syscall is better than an ioctl based interface here, > which I definitely still think. Given that John knows much more about > clocks than I do, we still need to get agreement on the question that > he raised, whi

Re: [PATCH 1/5] ptp: Added a brand new class driver for ptp clocks.

2010-08-19 Thread Richard Cochran
On Wed, Aug 18, 2010 at 05:02:03PM +0200, Arnd Bergmann wrote: > You might want to use callbacks for these system calls that you > can register to at module load time, like it is done for the > existing syscalls. Can you point me to a specific example? > The simpler way (e.g. for testing) is usin

Re: [PATCH 1/5] ptp: Added a brand new class driver for ptp clocks.

2010-08-18 Thread Richard Cochran
On Wed, Aug 18, 2010 at 05:12:56PM -0700, john stultz wrote: > On Wed, 2010-08-18 at 09:19 +0200, Richard Cochran wrote: > > The timer/alarm stuff is "ancillary" and is not at all necessary. It > > is just a "nice to have." I will happily remove it, if it is to

Re: [PATCH 1/5] ptp: Added a brand new class driver for ptp clocks.

2010-08-18 Thread Richard Cochran
On Tue, Aug 17, 2010 at 01:36:29PM +0200, Arnd Bergmann wrote: > On Tuesday 17 August 2010, Richard Cochran wrote: > > I've been looking at offering the PTP clock as a posix clock, and it > > is not as hard as I first thought. The PTP clock or clocks just have > > to b

Re: [PATCH 1/5] ptp: Added a brand new class driver for ptp clocks.

2010-08-18 Thread Richard Cochran
On Tue, Aug 17, 2010 at 05:22:43PM -0700, john stultz wrote: > Why would system time not be adjusted to the PTP time? > > This is my main concern, that we're presenting a fractured API to > userland. Suddenly there isn't just system time, but ptp time as well, > and possibly multiple different ptp

Re: [PATCH 1/5] ptp: Added a brand new class driver for ptp clocks.

2010-08-17 Thread Richard Cochran
On Tue, Aug 17, 2010 at 09:25:55AM +, Arnd Bergmann wrote: > Another difference is that we generally use ioctl for devices that can > be enumerated, while syscalls are for system services that are not tied to > a specific device. This argument works both ways for PTP IMHO: On the one > hand you

Re: [PATCH 1/5] ptp: Added a brand new class driver for ptp clocks.

2010-08-17 Thread Richard Cochran
On Mon, Aug 16, 2010 at 12:24:48PM -0700, john stultz wrote: > 3) I'm not sure I see the benefit of being able to have multiple > frequency corrected time domains. In other words, what benefit would > you get from adjusting a PTP clock's frequency instead of just > adjusting the system's time freq

Re: [PATCH 1/5] ptp: Added a brand new class driver for ptp clocks.

2010-08-17 Thread Richard Cochran
On Mon, Aug 16, 2010 at 09:59:39PM +0200, Arnd Bergmann wrote: > Why does it matter how long it takes to read the clock? I wasn't thinking > of replacing the system clock with this, just exposing the additional > clock as a new clockid_t value that can be accessed using the existing > syscalls. Ok

Re: [PATCH 1/5] ptp: Added a brand new class driver for ptp clocks.

2010-08-16 Thread Richard Cochran
On Mon, Aug 16, 2010 at 04:26:23PM +0200, Arnd Bergmann wrote: > Have you considered integrating the subsystem into the Posix clock/timer > framework? Yes, but see below. > I can't really tell from reading the source if this is possible or > not, but my feeling is that if it can be done, that wo

[PATCH 5/5] ptp: Added a clock driver for the National Semiconductor PHYTER.

2010-08-16 Thread Richard Cochran
This patch adds support for the PTP clock found on the DP83640. The basic clock operations and one external time stamp have been implemented. Signed-off-by: Richard Cochran --- drivers/net/phy/Kconfig | 29 ++ drivers/net/phy/Makefile |1 + drivers/net/phy/dp83640.c | 904

[PATCH 4/5] ptp: Added a clock driver for the IXP46x.

2010-08-16 Thread Richard Cochran
This patch adds a driver for the hardware time stamping unit found on the IXP465. The basic clock operations and an external trigger are implemented. Signed-off-by: Richard Cochran --- arch/arm/mach-ixp4xx/include/mach/ixp46x_ts.h | 78 ++ drivers/net/arm/ixp4xx_eth.c

[PATCH 3/5] ptp: Added a clock that uses the eTSEC found on the MPC85xx.

2010-08-16 Thread Richard Cochran
The eTSEC includes a PTP clock with quite a few features. This patch adds support for the basic clock adjustment functions, plus two external time stamps and one alarm. Signed-off-by: Richard Cochran --- Documentation/powerpc/dts-bindings/fsl/tsec.txt | 57 +++ arch/powerpc/boot/dts

[PATCH 2/5] ptp: Added a clock that uses the Linux system time.

2010-08-16 Thread Richard Cochran
This PTP clock simply uses the NTP time adjustment system calls. The driver can be used in systems that lack a special hardware PTP clock. Signed-off-by: Richard Cochran --- drivers/ptp/Kconfig | 12 drivers/ptp/Makefile|1 + drivers/ptp/ptp_linux.c | 136

  1   2   >