Re: [PATCH v7 05/16] module: make module_memory_{alloc,free} more self-contained

2024-04-30 Thread Philippe Mathieu-Daudé
ain.c | 64 +++- 1 file changed, 39 insertions(+), 25 deletions(-) Nice code simplification. Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v5 11/15] arch: make execmem setup available regardless of CONFIG_MODULES

2024-04-22 Thread Philippe Mathieu-Daudé
| 29 +++ 23 files changed, 463 insertions(+), 445 deletions(-) create mode 100644 arch/sparc/mm/execmem.c Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH 2/4] KVM: remove unused argument of kvm_handle_hva_range()

2024-04-07 Thread Philippe Mathieu-Daudé
On 5/4/24 13:58, Paolo Bonzini wrote: The only user was kvm_mmu_notifier_change_pte(), which is now gone. Signed-off-by: Paolo Bonzini --- virt/kvm/kvm_main.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH 4/4] mm: replace set_pte_at_notify() with just set_pte_at()

2024-04-07 Thread Philippe Mathieu-Daudé
-- kernel/events/uprobes.c | 5 ++--- mm/ksm.c | 4 ++-- mm/memory.c | 7 +-- mm/migrate_device.c | 8 ++-- 5 files changed, 7 insertions(+), 19 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v4 3/5] arch/powerpc: Remove trailing whitespaces

2023-09-12 Thread Philippe Mathieu-Daudé
On 12/9/23 15:49, Thomas Zimmermann wrote: Fix coding style. No functional changes. Signed-off-by: Thomas Zimmermann --- arch/powerpc/include/asm/machdep.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v2 1/3] kconfig: add dependencies of POWER_RESET for mips malta

2023-09-04 Thread Philippe Mathieu-Daudé
On 4/9/23 19:40, Yuan Tan wrote: On 9/4/2023 6:58 PM, Christophe Leroy wrote: Le 04/09/2023 à 12:51, Philippe Mathieu-Daudé a écrit : On 4/9/23 11:24, Yuan Tan wrote: Hi, On 9/4/2023 3:40 PM, Philippe Mathieu-Daudé wrote: Hi, On 1/9/23 04:42, Yuan Tan wrote: MIPS Malta's powe

Re: [PATCH v2 1/3] kconfig: add dependencies of POWER_RESET for mips malta

2023-09-04 Thread Philippe Mathieu-Daudé
On 4/9/23 11:24, Yuan Tan wrote: Hi, On 9/4/2023 3:40 PM, Philippe Mathieu-Daudé wrote: Hi, On 1/9/23 04:42, Yuan Tan wrote: MIPS Malta's power off depends on PCI, PCI_QUIRKS, and POWER_RESET_PIIX4_POWEROFF to work. Enable them when POWER_RESET is set for convenience. Suggested-by: Zha

Re: [PATCH v2 1/3] kconfig: add dependencies of POWER_RESET for mips malta

2023-09-04 Thread Philippe Mathieu-Daudé
Hi, On 1/9/23 04:42, Yuan Tan wrote: MIPS Malta's power off depends on PCI, PCI_QUIRKS, and POWER_RESET_PIIX4_POWEROFF to work. Enable them when POWER_RESET is set for convenience. Suggested-by: Zhangjin Wu Signed-off-by: Yuan Tan --- arch/mips/Kconfig | 3 +++ 1 file changed, 3 insertions

Re: [PATCH v3 3/4] arch/mips/configs/*_defconfig cleanup

2023-08-17 Thread Philippe Mathieu-Daudé
1 - arch/mips/configs/malta_defconfig | 1 - arch/mips/configs/malta_kvm_defconfig | 1 - arch/mips/configs/maltaup_xpa_defconfig | 1 - arch/mips/configs/rm200_defconfig | 1 - 5 files changed, 5 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v2 3/4] arch/mips/configs/*_defconfig cleanup

2023-08-17 Thread Philippe Mathieu-Daudé
Hi Trevor, On 17/8/23 04:59, Trevor Woerner wrote: Drop CONFIG_IP_NF_TARGET_CLUSTERIP from any remaining mips defconfigs as it was removed in commit 57f8e00d8a82 ("usb: 71 musb: Drop old unused am35x glue layer"). How 57f8e00d8a82 is related? Do you mean commit 9db5d918e2c0 ("netfilter: ip_tab

Re: [PATCH v2 5/9] vgacon: remove screen_info dependency

2023-07-19 Thread Philippe Mathieu-Daudé
Hi Arnd, On 19/7/23 14:39, Arnd Bergmann wrote: From: Arnd Bergmann The vga console driver is fairly self-contained, and only used by architectures that explicitly initialize the screen_info settings. Chance every instance that picks the vga console by setting conswitchp to call a function in

Re: [PATCH v2 4/9] vgacon, arch/*: remove unused screen_info definitions

2023-07-19 Thread Philippe Mathieu-Daudé
(-) delete mode 100644 arch/hexagon/kernel/screen_info.c Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v7 6/6] PCI: Make use of pci_resource_n()

2023-03-24 Thread Philippe Mathieu-Daudé
urce_n((dev), (bar))) : 0) Seems (to me) more logical to have this patch as "PCI: Introduce pci_resource_n()" ordered before your patch #2 "PCI: Introduce pci_dev_for_each_resource()". Here as #6 or as #2: Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v7 4/6] EISA: Convert to use less arguments in pci_bus_for_each_resource()

2023-03-24 Thread Philippe Mathieu-Daudé
++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/eisa/pci_eisa.c b/drivers/eisa/pci_eisa.c Since this is *PCI* EISA, could be squashed into previous patch. Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v7 3/6] PCI: Allow pci_bus_for_each_resource() to take less arguments

2023-03-24 Thread Philippe Mathieu-Daudé
inux/pci.h| 17 + 6 files changed, 26 insertions(+), 21 deletions(-) Nice. Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v5 00/26] Remove COMMAND_LINE_SIZE from uapi

2023-03-06 Thread Philippe Mathieu-Daudé
D_LINE_SIZE really shouldn't be part of uapi, so this now touches all the ports. I've tried to split this all out and leave it bisectable, but I haven't tested it all that aggressively. Series: Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v2.1 04/24] arm64/cpu: Mark cpu_die() __noreturn

2023-03-02 Thread Philippe Mathieu-Daudé
files changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v2.1 09/24] mips/cpu: Expose play_dead()'s prototype definition

2023-03-02 Thread Philippe Mathieu-Daudé
/* Map from cpu id to sequential logical cpu number. This will only not be idempotent when cpus failed to come on-line.*/ Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v2 09/24] mips/cpu: Expose play_dead()'s prototype definition

2023-02-15 Thread Philippe Mathieu-Daudé
On 14/2/23 19:11, Josh Poimboeuf wrote: On Tue, Feb 14, 2023 at 08:46:41AM +0100, Philippe Mathieu-Daudé wrote: Hi Josh, On 14/2/23 08:05, Josh Poimboeuf wrote: Include to make sure play_dead() matches its prototype going forward. Acked-by: Florian Fainelli Signed-off-by: Josh Poimboeuf

Re: [PATCH v2 00/24] cpu,sched: Mark arch_cpu_idle_dead() __noreturn

2023-02-14 Thread Philippe Mathieu-Daudé
On 14/2/23 08:05, Josh Poimboeuf wrote: v2: - make arch_call_rest_init() and rest_init() __noreturn - make objtool 'global_returns' work for weak functions - rebase on tip/objtool/core with dependencies merged in (mingo) - add acks v1.1: - add __noreturn to all arch_cpu_idle_dead() implementatio

Re: [PATCH v3 19/24] parisc: Remove empty

2023-02-14 Thread Philippe Mathieu-Daudé
On 14/2/23 08:49, Alexandre Ghiti wrote: From: Palmer Dabbelt Signed-off-by: Palmer Dabbelt --- arch/parisc/include/uapi/asm/setup.h | 5 - 1 file changed, 5 deletions(-) delete mode 100644 arch/parisc/include/uapi/asm/setup.h Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v3 08/24] parisc: Remove COMMAND_LINE_SIZE from uapi

2023-02-14 Thread Philippe Mathieu-Daudé
| 2 -- 2 files changed, 7 insertions(+), 2 deletions(-) create mode 100644 arch/parisc/include/asm/setup.h Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v3 01/24] alpha: Remove COMMAND_LINE_SIZE from uapi

2023-02-14 Thread Philippe Mathieu-Daudé
-- 2 files changed, 2 insertions(+), 4 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v3 07/24] mips: Remove COMMAND_LINE_SIZE from uapi

2023-02-14 Thread Philippe Mathieu-Daudé
--- 2 files changed, 2 insertions(+), 4 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v3 14/24] arc: Remove empty

2023-02-14 Thread Philippe Mathieu-Daudé
: Philippe Mathieu-Daudé

Re: [PATCH v3 24/24] s390: Remove empty

2023-02-14 Thread Philippe Mathieu-Daudé
: Philippe Mathieu-Daudé

Re: [PATCH v3 20/24] x86: Remove empty

2023-02-14 Thread Philippe Mathieu-Daudé
Mathieu-Daudé

Re: [PATCH v2 04/24] arm64/cpu: Mark cpu_die() __noreturn

2023-02-14 Thread Philippe Mathieu-Daudé
On 14/2/23 08:05, Josh Poimboeuf wrote: cpu_die() doesn't return. Annotate it as such. By extension this also makes arch_cpu_idle_dead() noreturn. Signed-off-by: Josh Poimboeuf --- arch/arm64/include/asm/smp.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/i

Re: [PATCH v2 06/24] ia64/cpu: Mark play_dead() __noreturn

2023-02-14 Thread Philippe Mathieu-Daudé
ed-by: Philippe Mathieu-Daudé

Re: [PATCH v2 08/24] loongarch/cpu: Mark play_dead() __noreturn

2023-02-14 Thread Philippe Mathieu-Daudé
ed-by: Philippe Mathieu-Daudé

Re: [PATCH v2 17/24] x86/cpu: Make sure play_dead() doesn't return

2023-02-14 Thread Philippe Mathieu-Daudé
On 14/2/23 08:05, Josh Poimboeuf wrote: After commit 076cbf5d2163 ("x86/xen: don't let xen_pv_play_dead() return"), play_dead() never returns. Make that more explicit with a BUG(). BUG() is preferable to unreachable() because BUG() is a more explicit failure mode and avoids undefined behavior l

Re: [PATCH v2 13/24] sh/cpu: Make sure play_dead() doesn't return

2023-02-13 Thread Philippe Mathieu-Daudé
On 14/2/23 08:05, Josh Poimboeuf wrote: play_dead() doesn't return. Make that more explicit with a BUG(). BUG() is preferable to unreachable() because BUG() is a more explicit failure mode and avoids undefined behavior like falling off the edge of the function into whatever code happens to be n

Re: [PATCH v2 19/24] xtensa/cpu: Make sure cpu_die() doesn't return

2023-02-13 Thread Philippe Mathieu-Daudé
Hi Josh, On 14/2/23 08:05, Josh Poimboeuf wrote: cpu_die() doesn't return. Make that more explicit with a BUG(). BUG() is preferable to unreachable() because BUG() is a more explicit failure mode and avoids undefined behavior like falling off the edge of the function into whatever code happens

Re: [PATCH v2 16/24] sparc/cpu: Mark cpu_play_dead() __noreturn

2023-02-13 Thread Philippe Mathieu-Daudé
ed-by: Philippe Mathieu-Daudé

Re: [PATCH v2 11/24] mips/cpu: Mark play_dead() __noreturn

2023-02-13 Thread Philippe Mathieu-Daudé
etion(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v2 10/24] mips/cpu: Make sure play_dead() doesn't return

2023-02-13 Thread Philippe Mathieu-Daudé
to be next. Acked-by: Florian Fainelli Signed-off-by: Josh Poimboeuf --- arch/mips/kernel/smp-bmips.c | 2 ++ arch/mips/loongson64/smp.c | 1 + 2 files changed, 3 insertions(+) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v2 09/24] mips/cpu: Expose play_dead()'s prototype definition

2023-02-13 Thread Philippe Mathieu-Daudé
Hi Josh, On 14/2/23 08:05, Josh Poimboeuf wrote: Include to make sure play_dead() matches its prototype going forward. Acked-by: Florian Fainelli Signed-off-by: Josh Poimboeuf --- arch/mips/kernel/smp-bmips.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/mips/kernel/smp-bmips.c

Re: [PATCH 00/11] Fix pca954x i2c-mux node names

2022-12-03 Thread Philippe Mathieu-Daudé
c-mux node names MIPS: mscc: jaguar2: Fix pca9545 i2c-mux node names powerpc: dts: fsl: Fix pca954x i2c-mux node names Series: Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v2 21/50] KVM: MIPS: Hardcode callbacks to hardware virtualization extensions

2022-12-01 Thread Philippe Mathieu-Daudé
struct kvm_mips_callbacks { void (*vcpu_reenter)(struct kvm_vcpu *vcpu); }; extern struct kvm_mips_callbacks *kvm_mips_callbacks; IIUC we could even constify this pointer. Anyway, Reviewed-by: Philippe Mathieu-Daudé diff --git a/arch/mips/kvm/mips.c b/arch/mips/kvm/mips.c index a

Re: [PATCH 17/44] KVM: arm64: Do arm/arch initialiation without bouncing through kvm_init()

2022-11-03 Thread Philippe Mathieu-Daudé
Hi Sean, On 3/11/22 00:18, Sean Christopherson wrote: Move arm/arch specific initialization directly in arm's module_init(), now called kvm_arm_init(), instead of bouncing through kvm_init() to reach kvm_arch_init(). Invoking kvm_arch_init() is the very first action performed by kvm_init(), i.e

Re: [PATCH 30/44] KVM: Drop kvm_arch_check_processor_compat() hook

2022-11-03 Thread Philippe Mathieu-Daudé
++-- arch/x86/kvm/x86.c | 5 - include/linux/kvm_host.h | 4 +--- virt/kvm/kvm_main.c| 24 +--- 13 files changed, 13 insertions(+), 67 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH 27/44] KVM: Drop kvm_arch_{init,exit}() hooks

2022-11-03 Thread Philippe Mathieu-Daudé
| 3 --- virt/kvm/kvm_main.c | 19 ++- 9 files changed, 2 insertions(+), 76 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH 25/44] KVM: s390: Do s390 specific init without bouncing through kvm_init()

2022-11-03 Thread Philippe Mathieu-Daudé
/s390/kvm/kvm-s390.c | 29 + 1 file changed, 25 insertions(+), 4 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH 22/44] KVM: RISC-V: Do arch init directly in riscv_kvm_init()

2022-11-03 Thread Philippe Mathieu-Daudé
son --- arch/riscv/kvm/main.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH 21/44] KVM: MIPS: Register die notifier prior to kvm_init()

2022-11-03 Thread Philippe Mathieu-Daudé
changed, 5 insertions(+), 4 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH 20/44] KVM: MIPS: Setup VZ emulation? directly from kvm_mips_init()

2022-11-03 Thread Philippe Mathieu-Daudé
ing kvm_arch_init() will allow dropping the hook entirely once all architecture implementations are nops. No functional change intended. Signed-off-by: Sean Christopherson --- arch/mips/kvm/mips.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v1 1/2] stackprotector: move CANARY_MASK and get_random_canary() into stackprotector.h

2022-10-24 Thread Philippe Mathieu-Daudé
| 19 --- include/linux/stackprotector.h | 19 +++ kernel/fork.c | 2 +- 7 files changed, 24 insertions(+), 24 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v4 11/12] KVM: mips, x86: do not rely on KVM_REQ_UNHALT

2022-09-22 Thread Philippe Mathieu-Daudé
Signed-off-by: Paolo Bonzini > Signed-off-by: Sean Christopherson > --- > arch/mips/kvm/emulate.c | 7 +++ > arch/x86/kvm/x86.c | 9 - > 2 files changed, 11 insertions(+), 5 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH 2/5] KVM: mips: Use kvm_get_vcpu() instead of open-coded access

2021-11-06 Thread Philippe Mathieu-Daudé
s/kvm/mips.c | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH 21/20] signal: Replace force_sigsegv(SIGSEGV) with force_fatal_sig(SIGSEGV)

2021-10-21 Thread Philippe Mathieu-Daudé
um/kernel/trap.c | 2 +- > arch/x86/kernel/vm86_32.c | 2 +- > fs/exec.c | 2 +- > 8 files changed, 9 insertions(+), 9 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH] kvm_host: unify VM_STAT and VCPU_STAT definitions in a single place

2020-04-13 Thread Philippe Mathieu-Daudé
Hi Emanuele, On 4/13/20 4:03 PM, Emanuele Giuseppe Esposito wrote: > The macros VM_STAT and VCPU_STAT are redundantly implemented in multiple > files, each used by a different architecure to initialize the debugfs > entries for statistics. Since they all have the same purpose, they can be > unifie