Re: [PATCH] docs: move powerpc under arch

2023-10-03 Thread Linas Vepstas
Hi Jon, Got the message; I'm not an active maintainer, haven't been for over a decade, and cannot comment on style issues. But if all the other arches are doing this, I see no reason why not. Feel free to interpret this as an Acked-by: if that's appropriate. -- linas On Tue, Oct 3, 2023 at 11:05

Re: [PATCH 0/5] s390/pci: automatic error recovery

2021-09-06 Thread Linas Vepstas
On Mon, Sep 6, 2021 at 4:49 AM Niklas Schnelle wrote: > I believe we might be the first > implementation of PCI device recovery in a virtualized setting requiring > us to > coordinate the device reset with the hypervisor platform by issuing a > disable > and re-enable to the platform as well as

Re: [PATCH] Documentation PCI: Fix typo in pci-error-recovery.rst

2021-05-31 Thread Linas Vepstas
Signed-off-by: Linas Vepstas On Mon, May 31, 2021 at 3:12 AM Wesley Sheng wrote: > Replace "It" with "If", since it is a conditional statement. > > Signed-off-by: Wesley Sheng > --- > Documentation/PCI/pci-error-recovery.rst | 2 +- > 1 file changed,

Re: [PATCH] powerpc/eeh: Update MAINTAINERS

2013-06-28 Thread Linas Vepstas
Hi, On 27 June 2013 21:11, Benjamin Herrenschmidt wrote: > On Fri, 2013-06-28 at 09:59 +0800, Gavin Shan wrote: >> Update MAINTAINERS to reflect recent changes. >> >> Signed-off-by: Gavin Shan >> --- >> MAINTAINERS |4 >> 1 files changed, 4 insertions(+), 0 deletions(-) >> >> diff --gi

Re: [PATCH RFC] Simplify the Linux kernel by reducing its state space

2012-03-31 Thread Linas Vepstas
ustworthy programmer. Thus, please add my ack Ack'ed by: Linas Vepstas On 31 March 2012 11:33, Paul E. McKenney wrote: > Although there have been numerous complaints about the complexity of > parallel programming (especially over the past 5-10 years), the plain > truth is

Re: [PATCH RFC] Simplify the Linux kernel by reducing its state space

2012-03-31 Thread Linas Vepstas
I've heard of Thomas Gleixner. Thus, please add my ack -- Ack'ed by: Linas Vepstas On Sun, Apr 01, 2012 at 12:33:21AM +0800, Paul E. McKenney was heard to remark: > Although there have been numerous complaints about the complexity of > parallel programming (especially over the pa

Re: [PATCH v2] pseries: don't override CONFIG_PPC_PSERIES_DEBUG

2010-10-14 Thread Linas Vepstas
as it produces so much output as to make the kernel unusable. > Update the Kconfig text to indicate this particular quirk :) > > Signed-off-by: Nishanth Aravamudan OK, ignore my last email. Acked by: Linas Vepstas > --- a/arch/powerpc/platforms/pseries/Kconfig > +++ b/arch/p

Re: [RFC PATCH] ppc: don't override CONFIG_PPC_PSERIES_DEBUG

2010-10-14 Thread Linas Vepstas
On 14 October 2010 12:48, Nishanth Aravamudan wrote: > These files undef DEBUG, but I think they were added before the ability > to control this from Kconfig. Right. > It's really annoying to only get some of > the debug messages! I don't get the big picture. Will there be some CONFIG_DEBUG_EE

Re: [PATCH 01/15] ppc: fix return type of BUID_{HI,LO} macros

2010-09-16 Thread Linas Vepstas
Acked-by: Linas Vepstas I'm guessing this worked up til now because the rtas_call function prototype was telling compiler to cast these to 32-bit before passing them as args. (and since these would still get passed as one arg per 64-bit reg, it still wouldn't go wrong.) What I'm

Re: [PATCH] powerpc: eeh: Fix oops when probing in early boot

2010-05-11 Thread Linas Vepstas
n created. Since we only need the pcidev to work > out the type of reset and that only gets set after the module for the > device loads, lets just do a hot reset if the pcidev is NULL. > > Signed-off-by: Anton Blanchard > --- Acked-by: Linas Vepstas I'm cc'ing Brian King

Re: [PATCH] eeh: Fixing a bug when pci structure is null

2010-02-19 Thread Linas Vepstas
Hi Paul, Breno, Some confusion -- I've been out of the loop for a while -- I assume its still Paul who is pushing these patches upstream, and not Ben? So Breno, maybe you should resend the patch to Paul? --linas On 19 February 2010 10:43, Breno Leitao wrote: > Hi Ben, > > I'd like to ask about

Re: [PATCH 2/2] eeh: fixing pci_dev dependency

2010-01-29 Thread Linas Vepstas
On 28 January 2010 18:04, Benjamin Herrenschmidt wrote: > On Wed, 2010-01-27 at 12:43 -0600, lei...@linux.vnet.ibm.com wrote: >> Currently pci_dev can be null when EEH is in action. This patch >> just assure that we pci_dev is not NULL before calling pci_dev_put. > > Like all variants of *_put(),

Re: [PATCH 1/2] eeh: Fixing a bug when pci structure is null

2010-01-27 Thread Linas Vepstas
g the OF device node, instead of mmio/dma access), before the kernel has created a pci_dev structure for the device. Oddly enough, either this slipped through the cracks all this time, or maybe pci_name() used to protect against nulls? Not sure. -- Linas

Re: [PATCH 3/3] Support for PCI Express reset type

2009-08-01 Thread Linas Vepstas
o utilize the new bit field. > > These patches supersede the previously submitted patch that implemented a > fundamental reset bit field. > > Please review and let me know of any concerns. > > Signed-off-by: Mike Mason > Signed-off-by: Richard Lary Signed

Re: [PATCH 2/3] Support for PCI Express reset type

2009-08-01 Thread Linas Vepstas
; Signed-off-by: Mike Mason > Signed-off-by: Richard Lary FWIW, Signed-off-by: Linas Vepstas ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH 1/3] Support for PCI Express reset type

2009-08-01 Thread Linas Vepstas
d Lary) adds a bit field to pci_dev > that indicates whether the device requires a fundamental reset during > recovery. > > These patches supersede the previously submitted patch that implemented a > fundamental reset bit field. > Please review and let me know of any concerns. > &

Re: [PATCH 1/3] Support for PCI Express reset type

2009-08-01 Thread Linas Vepstas
Hi Andi, 2009/7/31 Andi Kleen : > Mike Mason writes: >> >> These patches supersede the previously submitted patch that >> implemented a fundamental reset bit field. >> >> Please review and let me know of any concerns. > > Any plans to implement that for x86 too? Right now it seems to be a PPC > s

Re: [PATCH] Support for PCI Express reset type in EEH

2009-07-24 Thread Linas Vepstas
2009/7/24 Richard Lary : > Linas Vepstas wrote on 07/23/2009 07:44:33 AM: > >> 2009/7/15 Mike Mason : >> > By default, EEH does what's known as a "hot reset" during error recovery >> > of >> > a PCI Express device.  We've found a case w

Re: [PATCH] Support for PCI Express reset type in EEH

2009-07-23 Thread Linas Vepstas
2009/7/15 Mike Mason : > By default, EEH does what's known as a "hot reset" during error recovery of > a PCI Express device.  We've found a case where the device needs a > "fundamental reset" to recover properly.  The current PCI error recovery and > EEH frameworks do not support this distinction.

Re: [PATCH] Hold reference to device_node during EEH event handling

2009-07-23 Thread Linas Vepstas
2009/7/16 Michael Ellerman : > On Thu, 2009-07-16 at 09:33 -0700, Mike Mason wrote: >> Michael Ellerman wrote: >> > On Wed, 2009-07-15 at 14:43 -0700, Mike Mason wrote: >> >> This patch increments the device_node reference counter when an EEH >> >> error occurs and decrements the counter when the e

Re: [PATCH] Set error_state to pci_channel_io_normal in eeh_report_reset()

2009-04-14 Thread Linas Vepstas
analysis sounds correct; this looks like the right thing to do. I'm rather surprised, as this is an "obvious" bug, and should have been long gone. I thought that Emulex, QLogic were not the only ones that were using pci_channel_offline(dev) in this fashion. I thought that the symbios scs

Re: [PATCH] Only disable/enable LSI interrupts in EEH

2009-02-10 Thread Linas Vepstas
2009/2/10 Michael Ellerman : > On Tue, 2009-02-10 at 11:14 -0600, Linas Vepstas wrote: >> On a somewhat-related note: there was an issue (I forget >> the details) where the kernel needed to shadow some sort >> of MSI state so that it could be correctly, um, kept-track-of, >

Re: [PATCH] Only disable/enable LSI interrupts in EEH

2009-02-10 Thread Linas Vepstas
Signed-off-by: Mike Mason Looks good to me. Acked-by: Linas Vepstas On a somewhat-related note: there was an issue (I forget the details) where the kernel needed to shadow some sort of MSI state so that it could be correctly, um, kept-track-of, after an EEH reset (it didn't need to be res

Re: [PATCH] Don't panic when EEH_MAX_FAILS is exceeded

2008-07-20 Thread Linas Vepstas
't know that there was a lot of ifdef DEBUG in there. Yes, we don't need an ifdef DEBUG for this. Pending these changes, I'd happily add: Acked-by: Linas Vepstas <[EMAIL PROTECTED]> --linas ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH] Restore PERR/SERR bit settings during EEH device recovery

2008-07-08 Thread Linas Vepstas
gt;config_space[1] & PCI_COMMAND_PARITY) > + cmd |= PCI_COMMAND_PARITY; else cmd &= ~PCI_COMMAND_PARITY; > + if (pdn->config_space[1] & PCI_COMMAND_SERR) > + cmd |= PCI_COMMAND_SERR; else cmd &am

Re: [PATCH] pseries: phyp dump: Variable size reserve space.

2008-04-16 Thread Linas Vepstas
On 07/04/2008, Manish Ahuja <[EMAIL PROTECTED]> wrote: > A small proposed change in the amount of reserve space we allocate during > boot. > Currently we reserve 256MB only. > The proposed change does one of the 3 things. > > A. It checks to see if there is cmdline variable set and if found set

Re: [PATCH 2/8] pseries: phyp dump: reserve-release proof-of-concept

2008-03-12 Thread Linas Vepstas
On 10/03/2008, Michael Ellerman <[EMAIL PROTECTED]> wrote: > On Thu, 2008-02-28 at 18:24 -0600, Manish Ahuja wrote: > > + > > +/* Global, used to communicate data between early boot and late boot */ > > +static struct phyp_dump phyp_dump_global; > > +struct phyp_dump *phyp_dump_info = &phyp_du

Re: [PATCH 3/8] pseries: phyp dump: use sysfs to release reserved mem

2008-03-12 Thread Linas Vepstas
On 11/03/2008, Paul Mackerras <[EMAIL PROTECTED]> wrote: > > > -- > > This line needs to be exactly 3 dashes, because otherwise the tools > include the diffstat into the commit message. Putting 4 or more > dashes was an annoying habit Linas had, and it means I have to fix it > manually (us

Re: [PATCH 3/8] pseries: phyp dump: use sysfs to release reserved mem

2008-02-15 Thread Linas Vepstas
On 14/02/2008, Tony Breeds <[EMAIL PROTECTED]> wrote: > On Tue, Feb 12, 2008 at 01:11:58AM -0600, Manish Ahuja wrote: > > +static ssize_t > > +show_release_region(struct kset * kset, char *buf) > > +{ > > + return sprintf(buf, "ola\n"); > > +} > > + > > +static struct subsys_attribute r

Re: [PATCH 1/8] pseries: phyp dump: Docmentation

2008-01-14 Thread Linas Vepstas
On 13/01/2008, Olof Johansson <[EMAIL PROTECTED]> wrote: > > How do you expect to have it in full production if you don't have all > resources available for it? It's not until the dump has finished that you > can return all memory to the production environment and use it. With the PHYP dump, each

Re: [PATCH 1/8] pseries: phyp dump: Docmentation

2008-01-11 Thread Linas Vepstas
On 10/01/2008, Nathan Lynch <[EMAIL PROTECTED]> wrote: > Mike Strosaker wrote: > > > > At the risk of repeating what others have already said, the PHYP-assistance > > method provides some advantages that the kexec method cannot: > > - Availability of the system for production use before the dump d

Re: [PATCH 1/8] pseries: phyp dump: Docmentation

2008-01-10 Thread Linas Vepstas
On 10/01/2008, Olof Johansson <[EMAIL PROTECTED]> wrote: > On Wed, Jan 09, 2008 at 10:12:13PM -0600, Linas Vepstas wrote: > > On 09/01/2008, Olof Johansson <[EMAIL PROTECTED]> wrote: > > > On Wed, Jan 09, 2008 at 08:33:53PM -0600, Linas Vepstas wrote: > > >

Re: [PATCH 1/8] pseries: phyp dump: Docmentation

2008-01-09 Thread Linas Vepstas
On 09/01/2008, Olof Johansson <[EMAIL PROTECTED]> wrote: > On Wed, Jan 09, 2008 at 08:33:53PM -0600, Linas Vepstas wrote: > > > Heh. That's the elbow-grease of this thing. The easy part is to get > > the core function working. The hard part is to test these vario

Re: [PATCH 1/8] pseries: phyp dump: Docmentation

2008-01-09 Thread Linas Vepstas
On 09/01/2008, Michael Ellerman <[EMAIL PROTECTED]> wrote: > > > > Only if you can get at rtas, but you can't get at rtas at that point. > > AFAICT you don't need to get at RTAS, you just need to look at the > device tree to see if the property is present, and that is trivial. > > You probably just

Re: [PATCH 1/8] pseries: phyp dump: Docmentation

2008-01-09 Thread Linas Vepstas
On 09/01/2008, Nathan Lynch <[EMAIL PROTECTED]> wrote: > Hi Linas, > > Linas Vepstas wrote: > > > > As a side effect, the system is in > > production *while* the dump is being taken; > > A dubious feature IMO. Hmm. Take it up with Ken Rozendal, this is sup

Re: [PATCH 1/8] pseries: phyp dump: Docmentation

2008-01-09 Thread Linas Vepstas
Hi Nathan, Thank you for looking at this. On 08/01/2008, Nathan Lynch <[EMAIL PROTECTED]> wrote: > Manish Ahuja wrote: > > + > > + Hypervisor-Assisted Dump > > + > > + November 2007 > > Date is unneeded (and, uhm,

Re: [PATCH 4/8] pseries: phyp dump: use sysfs to release reserved mem

2008-01-08 Thread Linas Vepstas
On 07/01/2008, Stephen Rothwell <[EMAIL PROTECTED]> wrote: > On Mon, 07 Jan 2008 18:21:57 -0600 Manish Ahuja <[EMAIL PROTECTED]> wrote: > > > > +static int __init phyp_dump_setup(void) > > +{ > > > > + /* Is there dump data waiting for us? */ > > + rtas = of_find_node_by_path("/rtas"); > >

Re: [PATCH 3/8] pseries: phyp dump: reserve-release proof-of-concept

2008-01-07 Thread Linas Vepstas
tain > > a copy of the crashed kernel data. > > > > Signed-off-by: Manish Ahuja <[EMAIL PROTECTED]> > > Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]> > > I think the signed-off-by chain needs to be modified. The way it appears, > you handled the patc

Re: [PATCH] powerpc: fix os-term usage on kernel panic

2007-12-03 Thread Linas Vepstas
On Thu, Nov 29, 2007 at 11:41:47AM +0100, Olaf Hering wrote: > On Wed, Nov 28, Linas Vepstas wrote: > > > On Wed, Nov 28, 2007 at 12:00:37PM +0100, Olaf Hering wrote: > > > On Tue, Nov 27, Will Schmidt wrote: > > > > > > - if (panic_timeout) > >

Re: [PATCH] powerpc: fix os-term usage on kernel panic

2007-11-28 Thread Linas Vepstas
On Tue, Nov 27, 2007 at 06:15:59PM -0600, Will Schmidt wrote: > (resending with the proper "from" addr this time). > > > I'm seeing some funky behavior on power5/power6 partitions with this > patch.A "/sbin/reboot" is now behaving much more like a > "/sbin/halt". > > Anybody else seeing thi

Re: [PATCH] powerpc: fix os-term usage on kernel panic

2007-11-28 Thread Linas Vepstas
On Wed, Nov 28, 2007 at 12:00:37PM +0100, Olaf Hering wrote: > On Tue, Nov 27, Will Schmidt wrote: > > > > -void rtas_os_term(char *str) > > > +void rtas_panic_msg(char *str) > > > > - if (panic_timeout) > > > - return; > > This change is wrong. Booting with panic=123 really means the sy

Re: [PATCH] ehea: Add kdump support

2007-11-26 Thread Linas Vepstas
Hi, On Mon, Nov 26, 2007 at 01:41:37PM -0200, Luke Browning wrote: > On Mon, 2007-11-26 at 19:16 +1100, Michael Ellerman wrote: > > > For kdump we have to assume that the kernel is fundamentally broken, If I may so humbly suggest: since ehea is a power6 thing only, we should refocus our energie

[PATCH/RFC 6/6]: phyp dump: debugging print routines.

2007-11-21 Thread Linas Vepstas
Provide some basic debugging support. Signed-off-by: Manish Ahuja <[EMAIL PROTECTED]> Signed-off-by: Linas Vepsts <[EMAIL PROTECTED]> - arch/powerpc/platforms/pseries/phyp_dump.c | 51 + 1 file changed, 51 insertions(+) Index: linux-2.6.24-rc3-git1/arch/powerp

[PATCH/RFC 5/6]: phyp dump: register the dump area

2007-11-21 Thread Linas Vepstas
Set up the actual dump header, register it with the hypervisor. Signed-off-by: Manish Ahuja <[EMAIL PROTECTED]> Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]> -- arch/powerpc/platforms/pseries/phyp_dump.c | 169 +++-- 1 file changed, 163 inse

[PATCH/RFC 4/6]: phyp dump: use sysfs to release reserved mem

2007-11-21 Thread Linas Vepstas
0" > /sys/kernel/release_region will release 256MB starting at the 1GB. The released memory becomes free for general use. Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]> Signed-off-by: Manish Ahuja <[EMAIL PROTECTED]> -- arch/powerpc/platforms/p

[PATCH/RFC 3/6]: phyp dump: reserve-release proof-of-concept

2007-11-21 Thread Linas Vepstas
Initial rough-in/proof of concept of reserving memory in early boot, and freeing it later. If the previous boot had ended with a crash, the reserved memory would contain a copy of the crashed kernel data. Signed-off-by: Manish Ahuja <[EMAIL PROTECTED]> Signed-off-by: Linas Vepstas &

[PATCH/RFC 2/6]: phyp dump: config file

2007-11-21 Thread Linas Vepstas
Add hypervisor-assisted dump to kernel config Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]> - arch/powerpc/Kconfig | 11 +++ 1 file changed, 11 insertions(+) Index: linux-2.6.24-rc2-git4/arch/powerpc/K

[PATCH/RFC 1/6]: phyp dump: Documentation

2007-11-21 Thread Linas Vepstas
Basic documentation for hypervisor-assisted dump. Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]> Documentation/powerpc/phyp-assisted-dump.txt | 126 +++ 1 file changed, 126 insertions(+) Index: linux-2.6.24-rc3-git1/Documentation/powerpc/phyp-assisted-du

[PATCH/RFC 0/6]: phyp dump: hypervisor-assisted dump

2007-11-21 Thread Linas Vepstas
The following series of patches implement a basic framework for hypervisor-assisted dump. The very first patch provides documentation explaining what this is :-). Yes, its supposed to be an improvement over kdump. The patches mostly sort-of work; a list of open issues is inculded in the document

[PATCH] powerpc/pseries: tell phyp to auto-restart

2007-11-20 Thread Linas Vepstas
The pseries hypervisor attempts to detect and prevent an infinite loop of kernel crashes and auto-reboots. It does so by refusing to auto-reboot unless we indicate that the current boot was sucessful. So, indicate success late in the boot sequence. Signed-off-by: Linas Vepstas <[EM

[PATCH] powerpc: fix os-term usage on kernel panic

2007-11-19 Thread Linas Vepstas
o keep the hypervisor happy to avoid service, dump and error reporting problems. Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]> One could make a strong argument to move all of this code from kernel/rtas.c to platforms/pseries/setup.c I did not do this, just so as to make the changes minimal

Re: hangs after "Freeing unused kernel memory"

2007-11-19 Thread Linas Vepstas
On Thu, Nov 15, 2007 at 04:00:09PM -0800, Siva Prasad wrote: > Hi, > > This sounds like a familiar problem, but could not get answers in posts > that came up in google search. > > My system hangs after printing the message "Freeing unused kernel > memory". It should execute init after that, but n

[PATCH 1/3] powerpc: EEH: work with device endpoint, always

2007-11-15 Thread Linas Vepstas
Perform all error checking at the "partitonable endpoint" of the device. Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]> arch/powerpc/platforms/pseries/eeh.c |1 + 1 file changed, 1 insertion(+) Index: linux-2.6.23-rc8-mm1/arch/powerpc/platfor

[PATCH 3/3]: powerpc/eeh: report errors as soon as possible.

2007-11-15 Thread Linas Vepstas
Do not wait for the pci slot status before reporting an error to the device driver. Some systems may take many seconds to report the slot status, and this can confuse unsuspecting device drivers. Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]> arch/powerpc/platforms/pseries/eeh_dr

[PATCH 2/3] powerpc: EEH: careful when identifying "empty" slots.

2007-11-15 Thread Linas Vepstas
If an "empty" slot is failing, make sure its a permanent failure; else process the error normally. Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]> arch/powerpc/platforms/pseries/eeh.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux-2.6.23-rc8-

[PATCH 1/3 v2] powerpc: EEH: work with device endpoint, always

2007-11-15 Thread Linas Vepstas
Perform all error checking at the "partitonable endpoint" of the device. Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]> version 2: I still can't get whitespace right the first time ... arch/powerpc/platforms/pseries/eeh.c |1 + 1 file changed, 1 insertion(+)

[PATCH v2] pci hotplug: fix rpaphp directory naming

2007-11-14 Thread Linas Vepstas
Fix presentation of the slot number in the /sys/bus/pci/slots directory to match that used in the majority of other drivers. Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]> -- On Tue, Nov 13, 2007 at 07:26:07PM -0800, Greg KH wrote: > We need a signed-off-by: to be able to a

Re: [PATCH] [POWERPC] pSeries: make pseries_defconfig minus PCI build again

2007-11-14 Thread Linas Vepstas
On Wed, Nov 14, 2007 at 03:07:39PM +1100, Stephen Rothwell wrote: > > Signed-off-by: Stephen Rothwell <[EMAIL PROTECTED]> Acked-by: Linas Vepstas <[EMAIL PROTECTED]> > --- > arch/powerpc/platforms/pseries/Kconfig |2 +- > 1 files changed, 1 insertions(+), 1 del

[PATCH] pci hotplug: rm bogus item in rpaphp struct

2007-11-13 Thread Linas Vepstas
Remove unused struct element. Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]> drivers/pci/hotplug/rpaphp.h |1 - drivers/pci/hotplug/rpaphp_pci.c |1 - 2 files changed, 2 deletions(-) Index: linux-2.6.23-rc8-mm1/drivers/pci/hotplug/rp

[PATCH] pci hotplug: fix rpaphp directory naming

2007-11-13 Thread Linas Vepstas
Fix presentation of the slot number in the /sys/bus/pci/slots directory to match that used in the majority of other drivers. -- On Tue, Nov 13, 2007 at 02:58:30PM -0700, Matthew Wilcox wrote: > On Tue, Nov 13, 2007 at 03:41:21PM -0600, Linas Vepstas wrote: > > /sys/bus/pci/slots

Re: [PATCH] Read back MSI message in rtas_setup_msi_irqs() so restore works

2007-11-07 Thread Linas Vepstas
- > > Linas, can you test this on your setup with your EEH stuff? I haven't got > any MSI supporting hardware/firmware combination. Acked-by: Linas Vepstas <[EMAIL PROTECTED]> I *finally* was able to get onto some hardware long enough to run this. And that took a lot of

[PATCH] powerpc/eeh: make sure warning message is printed.

2007-11-07 Thread Linas Vepstas
Fix old buglet; a warning message should have been printed when a hardware reset takes too long. Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]> arch/powerpc/platforms/pseries/eeh.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux-2.6.23-rc8-mm1/arch/p

Re: [PATCH 11/16] Use of_get_next_child() in eeh_restore_bars()

2007-11-05 Thread Linas Vepstas
On Mon, Oct 29, 2007 at 02:46:13PM +1100, Michael Ellerman wrote: > > On Fri, 2007-10-26 at 17:29 +1000, Stephen Rothwell wrote: > > On Fri, 26 Oct 2007 16:54:43 +1000 (EST) Michael Ellerman <[EMAIL > > PROTECTED]> wrote: > > > > > > - dn = pdn->node->child; > > > - while (dn) { > > > + for (dn =

[PATCH 3/3]: powerpc eeh: avoid crash on null device.

2007-11-02 Thread Linas Vepstas
Bugfix: avoid crash if there's no pci device for a given openfirmware node. Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]> arch/powerpc/platforms/pseries/eeh.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) Index: linux-2.6.23-rc8-mm1/arch/powerpc/platfo

[PATCH 2/3]: powerpc eeh: drivers that need reset trump others

2007-11-02 Thread Linas Vepstas
Bugfix: if a driver controlling one part of a multi-function pci card has asked for a reset, honor that request above all othres. Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]> arch/powerpc/platforms/pseries/eeh_driver.c | 10 ++ 1 file changed, 6 insertions(+), 4 del

[PATCH 1/3] powerpc eeh: cleanup comments

2007-11-02 Thread Linas Vepstas
Clean up commentary, remove dead code. Signed-off-by Linas Vepstas <[EMAIL PROTECTED]> arch/powerpc/platforms/pseries/eeh_driver.c |8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) Index: linux-2.6.23-rc8-mm1/arch/powerpc/platforms/pseries/eeh_dr

[PATCH 0/3] powerpc eeh: bug fixes for crashes, bad handling

2007-11-02 Thread Linas Vepstas
Hi Paul, Please forward upstream the following three tiny patches for EEH bugs, including on crash, and one failure to reset correctly. (I was planning on blasting you many many more patches, involving MSI, but have had nothing but broken hardware for the last few weeks, and so have nothing to

Re: [PATCH 5/7] pci: Export the pci_restore_msi_state() function

2007-10-22 Thread Linas Vepstas
On Tue, Oct 23, 2007 at 07:24:27AM +1000, Benjamin Herrenschmidt wrote: > > On Mon, 2007-10-22 at 13:13 -0500, Linas Vepstas wrote: > > On Mon, Oct 22, 2007 at 11:49:24AM +1000, Michael Ellerman wrote: > > > > > > On pseries there's a chance it will work for

Re: [BUG] powerpc does not save msi state [was Re: [PATCH 5/7] pci: Export the pci_restore_msi_state() function

2007-10-22 Thread Linas Vepstas
On Fri, Oct 19, 2007 at 05:53:08PM -0700, David Miller wrote: > From: [EMAIL PROTECTED] (Linas Vepstas) > Date: Fri, 19 Oct 2007 19:46:10 -0500 > > > FWIW, it looks like not all that many arches do this; the output > > for grep -r address_hi * is pretty thin. Then, looki

Re: [PATCH 5/7] pci: Export the pci_restore_msi_state() function

2007-10-22 Thread Linas Vepstas
On Mon, Oct 22, 2007 at 11:49:24AM +1000, Michael Ellerman wrote: > > On pseries there's a chance it will work for PCI error recovery, but if > so it's just lucky that firmware has left everything configured the same > way. ? The papr is quite clear that i is up to the OS to restore the msi stat

[BUG] powerpc does not save msi state [was Re: [PATCH 5/7] pci: Export the pci_restore_msi_state() function

2007-10-19 Thread Linas Vepstas
Hi, On Fri, Oct 19, 2007 at 05:27:06PM -0700, David Miller wrote: > From: [EMAIL PROTECTED] (Linas Vepstas) > Date: Fri, 19 Oct 2007 19:04:21 -0500 > > > I'm working in linux-2.6.23-rc8-mm1 at the moment, and I don't see > > that happening. viz. read_msi_msg() is

Re: [PATCH 2/2] Use of_get_pci_dev_node() in axon_msi.c

2007-10-18 Thread Linas Vepstas
well, of course, then. Excellent reason. I didn't get that from the patch commit comments. So, FWIW: Ack'ed-by: Linas Vepstas <[EMAIL PROTECTED]> --linas ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH 2/2] Use of_get_pci_dev_node() in axon_msi.c

2007-10-17 Thread Linas Vepstas
On Wed, Oct 17, 2007 at 05:12:27PM +1000, Michael Ellerman wrote: > +struct device_node *of_get_pci_dev_node(struct pci_dev *pdev) > +{ > + return of_node_get(pci_device_to_OF_node(pdev)); > +} [...] > - dn = of_node_get(pci_device_to_OF_node(dev)); > + dn = of_get_pci_dev_node(dev

Re: Merge dtc

2007-10-17 Thread Linas Vepstas
On Wed, Oct 17, 2007 at 02:59:04PM -0500, Timur Tabi wrote: > Kumar Gala wrote: > > > Just out of interest who's complaining? We don't include mkimage for > > u-boot related builds and I haven't seen any gripes related to that. > > I think we should include mkimage *and* dtc. But then, I'm no

Re: Hard hang in hypervisor!?

2007-10-11 Thread Linas Vepstas
On Thu, Oct 11, 2007 at 10:04:40AM +1000, Paul Mackerras wrote: > Linas Vepstas writes: > > > Err .. it was cpu 0 that was spinlocked. Are interrupts not > > distributed? > > We have some bogosities in the xics code that I noticed a couple of > days ago. Basica

Re: [PATCH v4 or so] Use 1TB segments

2007-10-11 Thread Linas Vepstas
On Thu, Oct 11, 2007 at 08:37:10PM +1000, Paul Mackerras wrote: > This makes the kernel use 1TB segments for all kernel mappings and for > user addresses of 1TB and above, on machines which support them > (currently POWER5+, POWER6 and PA6T). Gack. A system dump might take a while on these machine

never mind .. [was Re: Hard hang in hypervisor!?

2007-10-09 Thread Linas Vepstas
On Tue, Oct 09, 2007 at 04:28:10PM -0500, Linas Vepstas wrote: > > Perhaps I should IRC this ... yeah. I guess I'd forgotten how funky things can get. So never mind ... --linas ___ Linuxppc-dev mailing list Linuxppc-dev@ozlab

Re: Hard hang in hypervisor!?

2007-10-09 Thread Linas Vepstas
On Tue, Oct 09, 2007 at 04:18:19PM -0500, Nathan Lynch wrote: > Linas Vepstas wrote: > > > > I was futzing with linux-2.6.23-rc8-mm1 in a power6 lpar when, > > for whatever reason, a spinlock locked up. The bizarre thing > > was that the rest of system locked up as wel

Hard hang in hypervisor!?

2007-10-09 Thread Linas Vepstas
I was futzing with linux-2.6.23-rc8-mm1 in a power6 lpar when, for whatever reason, a spinlock locked up. The bizarre thing was that the rest of system locked up as well: an ssh terminal, and also an hvc console. Breaking into the debugger showed 4 cpus, 1 of which was deadlocked in the spinloc

Re: [patch v2] PS3: Add os-area database routines

2007-10-09 Thread Linas Vepstas
On Mon, Oct 08, 2007 at 06:07:24PM -0700, Geoff Levand wrote: > Subject: PS3: Add os-area database routines > > Add support for a simple tagged database in the PS3 flash rom > os-area. The database allows the flash rom os-area to be shared > between a bootloader and installed operating systems.

Re: [PATCH] Eval boards should not need to mess with ROOT_DEV

2007-10-08 Thread Linas Vepstas
On Mon, Oct 08, 2007 at 03:42:21PM -0500, Linas Vepstas wrote: > On Mon, Oct 08, 2007 at 02:41:54PM -0500, Kumar Gala wrote: > > > > On Oct 8, 2007, at 2:03 PM, Grant Likely wrote: > > > > >>> I can't see a good reason for eval board platform code to mes

Re: [PATCH] Eval boards should not need to mess with ROOT_DEV

2007-10-08 Thread Linas Vepstas
On Mon, Oct 08, 2007 at 02:41:54PM -0500, Kumar Gala wrote: > > On Oct 8, 2007, at 2:03 PM, Grant Likely wrote: > > >>> I can't see a good reason for eval board platform code to mess with > >>> the > >>> ROOT_DEV value instead of using the default behaviour (so I'm > > > > Powermac and pseries

Re: 2.6.23-rc7-mm1 -- powerpc rtas panic

2007-10-05 Thread Linas Vepstas
On Thu, Oct 04, 2007 at 05:01:47PM -0700, Nish Aravamudan wrote: > On 10/2/07, Tony Breeds <[EMAIL PROTECTED]> wrote: > > On Wed, Oct 03, 2007 at 10:30:16AM +1000, Michael Ellerman wrote: > > > > > I realise it'll make the patch bigger, but this doesn't seem like a > > > particularly good name for

Re: [PATCH 2/2]: PCI Error Recovery: Symbios SCSI First Failure

2007-10-04 Thread Linas Vepstas
On Mon, Oct 01, 2007 at 07:27:30PM -0600, Matthew Wilcox wrote: > > The thing to remember is that sym2 is in transition from being a dual > BSD/Linux driver to being a purely Linux driver. I was wondering about that; couldn't tell if the split in the code was historical, or being intentionally m

Re: Stdout console clogging => 300ms blocked

2007-10-04 Thread Linas Vepstas
Hi Bernard, On Wed, Oct 03, 2007 at 08:49:12PM +, Hollis Blanchard wrote: > On Tue, 02 Oct 2007 09:41:28 +0200, Willaert, Bernard wrote: > > > Problem: > > When we log debug output via the serial console on a multithreaded > > application, the console throughput may get clogged and then we >

Re: 2.6.23-rc7-mm1 -- powerpc rtas panic

2007-10-03 Thread Linas Vepstas
On Wed, Oct 03, 2007 at 02:09:46PM +1000, Michael Ellerman wrote: > > Until we initialise what exactly? Until we allocate the error log buffer. The original crash was for a null-pointer deref of the unallocated buffer. I just sent out a patch to fix this; its a bit simpler than the below. In t

[PATCH] powerpc: fix crash in rtas during early boot.

2007-10-03 Thread Linas Vepstas
RTAS messages can occur very early during boot, before the error message buffer has been allocated. The current code will lead to a null-pointer deref. Explicitly protect against this. Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]> Cc: Andy Whitcroft <[EMAIL PROTECTED]> Andy

Re: 2.6.23-rc7-mm1 -- powerpc rtas panic

2007-10-02 Thread Linas Vepstas
On Mon, Sep 24, 2007 at 01:35:31PM +0100, Andy Whitcroft wrote: > Seeing the following from an older power LPAR, pretty sure we had > this in the previous -mm also: I haven't forgetten about this ... and am looking at it now. Seems that whenever I go to reserve the machine pSeries-102, someone els

Re: [PATCH 2/2]: PCI Error Recovery: Symbios SCSI First Failure

2007-10-02 Thread Linas Vepstas
On Mon, Oct 01, 2007 at 07:27:30PM -0600, Matthew Wilcox wrote: > > Fine by me. Do you have the ability to produce failures on a whim on > your platforms? Yes, although it is very platform specific -- there are actually transistors in the pci bridge chip, which actually short out lines, and so

[PATCH] powerpc: another use of zalloc_maybe_bootmem()

2007-10-02 Thread Linas Vepstas
Use alloc_maybe_bootmem() which wraps the if(mem_init_done) malloc clause. Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]> On Tue, Oct 02, 2007 at 01:37:53PM +1000, Stephen Rothwell wrote: > This patch introduces zalloc_maybe_bootmem and uses it so that we don;t > have to

Re: [PATCH 2/2]: PCI Error Recovery: Symbios SCSI First Failure

2007-10-01 Thread Linas Vepstas
On Mon, Oct 01, 2007 at 02:12:47PM -0600, Matthew Wilcox wrote: > > I think the fundamental problem is that completions aren't really > supposed to be used like this. Here's one attempt at using completions > perhaps a little more the way they're supposed to be used, Yes, that looks very good t

Re: [PATCH 2/2]: PCI Error Recovery: Symbios SCSI First Failure

2007-09-27 Thread Linas Vepstas
On Thu, Sep 27, 2007 at 04:10:31PM -0600, Matthew Wilcox wrote: > In the error handler, we wait_for_completion(io_reset_wait). > In sym2_io_error_detected, we init_completion(io_reset_wait). > Isn't it possible that we hit the error handler before we hit the > io_error_detected path, and thus the c

Re: 2.6.23-rc8 dies somewhere during boot!?

2007-09-27 Thread Linas Vepstas
On Thu, Sep 27, 2007 at 11:57:35PM +0200, Gerhard Pircher wrote: > > > Based on your boot messages, it looks like you are failing somewhere in > > pci probe. My olde-fashioned, slow, but-usually-works method is to > > sprinkle enough printk's into the code to catch it in the act. > I guess the co

Re: [PATCH 2/2]: PCI Error Recovery: Symbios SCSI First Failure

2007-09-27 Thread Linas Vepstas
On Wed, Sep 26, 2007 at 09:02:16AM -0600, Matthew Wilcox wrote: > On Fri, Apr 20, 2007 at 03:47:20PM -0500, Linas Vepstas wrote: > > Implement the so-called "first failure data capture" (FFDC) for the > > symbios PCI error recovery. After a PCI error event is reported

Re: 2.6.23-rc8 dies somewhere during boot!?

2007-09-27 Thread Linas Vepstas
On Thu, Sep 27, 2007 at 11:17:00PM +0200, Gerhard Pircher wrote: > > Betreff: Re: 2.6.23-rc8 dies somewhere during boot!? > > Do you have an idea how to debug it? Not particularly. What caught my eye was the failure right near the PCI quirk stuff, as I was having problems there as well (but apear

Re: 2.6.23-rc8 dies somewhere during boot!?

2007-09-27 Thread Linas Vepstas
On Thu, Sep 27, 2007 at 09:31:31PM +0200, Gerhard Pircher wrote: > > > Betreff: Re: 2.6.23-rc8 dies somewhere during boot!? > > > > > > I'm working on a 2.6.23 kernel for the AmigaOne. Have you tried 2.6.22, or does that fail also? --linas ___ Linuxpp

Re: 2.6.23-rc8 dies somewhere during boot!?

2007-09-27 Thread Linas Vepstas
On Thu, Sep 27, 2007 at 09:12:33PM +0200, Gerhard Pircher wrote: > Hi, > > I'm working on a 2.6.23 kernel for the AmigaOne. [...] > <6>PCI: Probing PCI hardware. > <7>PCI: Scanning bus 0... > ...00:00:07.0. > <7>PCI: Calling quirk... > ...CI: Found :00:07.2 [1106/303... Any chance that thi

Re: tg3: PCI error recovery

2007-09-27 Thread Linas Vepstas
During a private conversation about how to save and restore device state after a pci error is detected, and the device is reset, the following came up: On Wed, Sep 26, 2007 at 04:48:38PM -0700, Michael Chan wrote: > > > > > 1b) If so, is it safe to call pci_save_state() in > > > tg3_io_error_de

Re: [PATCH 5/7] Celleb: Supports VFD on Celleb 2

2007-09-27 Thread Linas Vepstas
On Thu, Sep 27, 2007 at 11:07:33AM +0200, Arnd Bergmann wrote: > On Thursday 27 September 2007, Ishizaki Kou wrote: > > This is a patch to support VFD on Celleb 2. > > VFD is a small LCD to show miscellaneous messages. > > > > Signed-off-by: Kou Ishizaki <[EMAIL PROTECTED]> > > My feeling is th

Re: Help! Debian ppc64

2007-09-27 Thread Linas Vepstas
for $$$, which debian/ubuntu do not -- AIX on pSeries? +++ AIX has various "enterprise" features that Debian does not. You might try talking to RedHat/SuSE product support, and also to IBM pSeries sales. Linas Vepstas ___ Linuxppc-dev m

  1   2   >