2008/7/20 Nathan Lynch <[EMAIL PROTECTED]>: > Mike Mason wrote: >> >> This patch changes the EEH_MAX_FAILS action from panic to printing >> an error message. Panicking under under this condition is too >> harsh.
>> /* re-read the slot reset state */ >> if (read_slot_reset_state(pdn, rets) != 0) >> rets[0] = -1; /* reset state unknown */ > > While I tend to agree that panic() is unnecessary, don't we want a > stack dump unconditionally (i.e. not bracketed in #ifdef DEBUG)? Probably. This stack trace would reveal a point inside the inf loop, which can then be analyzed and fixed. > I'd prefer just removing the code instead of adding #ifdef's in the > middle of this function. eeh.c needs less #ifdef DEBUG, not more :) I didn't know that there was a lot of ifdef DEBUG in there. Yes, we don't need an ifdef DEBUG for this. Pending these changes, I'd happily add: Acked-by: Linas Vepstas <[EMAIL PROTECTED]> --linas _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
