Re: [PATCH v2 1/1] dt-bindings: fsl: fsl,rcpm: Add #power-domain-cells

2025-07-30 Thread Krzysztof Kozlowski
On Thu, Jul 31, 2025 at 07:58:04AM +0200, Alexander Stein wrote: > dtbs_check for ls1021.dtsi warns about unsupported property: > power-controller@1ee2140 (fsl,ls1021a-rcpm): '#power-domain-cells' does not > match any of the regexes: '^pinctrl-[0-9]+$' > > But if removed the check warns about mi

Re: [PATCH v2] dt-bindings: gpio: Create a trivial GPIO schema

2025-07-15 Thread Krzysztof Kozlowski
ring (Arm) > --- > We could also do this for ones with interrupts, but that seems a bit > more varied. > > v2: Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH RFC 7/9] powerpc/pseries: Enable HVPIPE event message interrupt

2025-07-07 Thread Krzysztof Kozlowski
On 07/07/2025 09:35, Krzysztof Kozlowski wrote: > On 07/07/2025 09:02, Haren Myneni wrote: >> On Thu, 2025-07-03 at 09:00 +0200, Krzysztof Kozlowski wrote: >>> On 03/07/2025 00:14, Haren Myneni wrote: >>>> +static int __init enable_hvpipe_IRQ(void) >>

Re: [PATCH RFC 7/9] powerpc/pseries: Enable HVPIPE event message interrupt

2025-07-07 Thread Krzysztof Kozlowski
On 07/07/2025 09:02, Haren Myneni wrote: > On Thu, 2025-07-03 at 09:00 +0200, Krzysztof Kozlowski wrote: >> On 03/07/2025 00:14, Haren Myneni wrote: >>> +static int __init enable_hvpipe_IRQ(void) >>> +{ >>> + struct device_node *np; >&g

Re: [PATCH RFC 3/9] powerpc/pseries: Add papr-hvpipe char driver for HVPIPE interfaces

2025-07-07 Thread Krzysztof Kozlowski
On 07/07/2025 08:53, Haren Myneni wrote: > On Thu, 2025-07-03 at 08:58 +0200, Krzysztof Kozlowski wrote: >> On 03/07/2025 00:14, Haren Myneni wrote: >>> +static struct miscdevice papr_hvpipe_dev = { >>> + .minor = MISC_DYNAMIC_MINOR, >>> + .name

Re: [PATCH RFC 7/9] powerpc/pseries: Enable HVPIPE event message interrupt

2025-07-03 Thread Krzysztof Kozlowski
On 03/07/2025 00:14, Haren Myneni wrote: > +static int __init enable_hvpipe_IRQ(void) > +{ > + struct device_node *np; > + > + hvpipe_check_exception_token = > rtas_function_token(RTAS_FN_CHECK_EXCEPTION); > + if (hvpipe_check_exception_token == RTAS_UNKNOWN_SERVICE) > + r

Re: [PATCH RFC 3/9] powerpc/pseries: Add papr-hvpipe char driver for HVPIPE interfaces

2025-07-02 Thread Krzysztof Kozlowski
On 03/07/2025 00:14, Haren Myneni wrote: > +static struct miscdevice papr_hvpipe_dev = { > + .minor = MISC_DYNAMIC_MINOR, > + .name = "papr-hvpipe", > + .fops = &papr_hvpipe_ops, > +}; > + > +static int __init papr_hvpipe_init(void) > +{ > + int ret; > + > +

Re: [PATCH] soc: Use dev_fwnode()

2025-06-12 Thread Krzysztof Kozlowski
On 11/06/2025 12:43, Jiri Slaby (SUSE) wrote: > irq_domain_create_simple() takes fwnode as the first argument. It can be > extracted from the struct device using dev_fwnode() helper instead of > using of_node with of_fwnode_handle(). > > So use the dev_fwnode() helper. > > Signed-off-by: Jiri Sla

Re: [PATCH 0/8] ASoC: codecs: More const and unused member cleanups

2025-05-29 Thread Krzysztof Kozlowski
On 29/05/2025 11:33, Srinivas Kandagatla wrote: > > > On 5/28/25 8:59 PM, Krzysztof Kozlowski wrote: >> Make static data const for code safety and drop some unused fields in >> structs. >> >> This is based on for-v6.16 branch in ASoC tree for context in wcd9

[PATCH 8/8] ASoC: codecs: wcd939x: Drop unused 'struct wcd939x_priv' fields

2025-05-28 Thread Krzysztof Kozlowski
'wcd_regmap_irq_chip' and 'jack' in 'struct wcd939x_priv' are not used at all. Signed-off-by: Krzysztof Kozlowski --- sound/soc/codecs/wcd939x.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/sound/soc/codecs/wcd939x.c b/so

[PATCH 7/8] ASoC: codecs: wcd938x: Drop unused variant field

2025-05-28 Thread Krzysztof Kozlowski
Member wcd938x_priv.variant is assigned in probe() function and used immediately thereafter, thus it can be just a local variable for less variables stored in 'struct wcd938x_priv' device-wide state. Signed-off-by: Krzysztof Kozlowski --- sound/soc/codecs/wcd938x.c | 14 +++-

[PATCH 6/8] ASoC: codecs: wcd938x: Drop unused 'struct wcd938x_priv' fields

2025-05-28 Thread Krzysztof Kozlowski
'wcd_regmap_irq_chip' and 'jack' in 'struct wcd938x_priv' are not used at all. Signed-off-by: Krzysztof Kozlowski --- sound/soc/codecs/wcd938x.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/sound/soc/codecs/wcd938x.c b/so

[PATCH 5/8] ASoC: codecs: wcd937x: Drop unused 'struct wcd937x_priv' fields

2025-05-28 Thread Krzysztof Kozlowski
'wcd_regmap_irq_chip' and 'jack' in 'struct wcd937x_priv' are not used at all. Signed-off-by: Krzysztof Kozlowski --- sound/soc/codecs/wcd937x.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/sound/soc/codecs/wcd937x.c b/so

[PATCH 4/8] ASoC: codecs: wcd934x: Drop unused num_rx_port/num_tx_port fields

2025-05-28 Thread Krzysztof Kozlowski
Members wcd934x_codec.num_rx_port and num_tx_port are not read anywhere after assignment, so they can be safely dropped. Signed-off-by: Krzysztof Kozlowski --- sound/soc/codecs/wcd934x.c | 4 1 file changed, 4 deletions(-) diff --git a/sound/soc/codecs/wcd934x.c b/sound/soc/codecs

[PATCH 3/8] ASoC: codecs: wcd9335: Drop unused sido_input_src field

2025-05-28 Thread Krzysztof Kozlowski
Member wcd9335_codec.sido_input_src is not read anywhere after assignment, so it can be safely dropped. Signed-off-by: Krzysztof Kozlowski --- sound/soc/codecs/wcd9335.c | 5 - 1 file changed, 5 deletions(-) diff --git a/sound/soc/codecs/wcd9335.c b/sound/soc/codecs/wcd9335.c index

[PATCH 2/8] ASoC: fsl: Constify reg_default array

2025-05-28 Thread Krzysztof Kozlowski
Static 'struct reg_default' array is not modified so can be changed to const for more safety. Signed-off-by: Krzysztof Kozlowski --- sound/soc/fsl/fsl_asrc.c | 2 +- sound/soc/fsl/fsl_sai.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/sound/soc/fsl/fs

[PATCH 1/8] ASoC: codecs: Constify regmap configuration static variables

2025-05-28 Thread Krzysztof Kozlowski
Static arrays/structs for regmap configuration like 'struct reg_default', 'struct reg_sequence' and others are not modified so can be changed to const for more safety. Signed-off-by: Krzysztof Kozlowski --- sound/soc/codecs/cs35l36.c| 2 +- sound/soc/codecs/

[PATCH 0/8] ASoC: codecs: More const and unused member cleanups

2025-05-28 Thread Krzysztof Kozlowski
Make static data const for code safety and drop some unused fields in structs. This is based on for-v6.16 branch in ASoC tree for context in wcd938x driver. Best regards, Krzysztof --- Krzysztof Kozlowski (8): ASoC: codecs: Constify regmap configuration static variables ASoC: fsl

Re: [PATCH 6/6] ASoC: qcom: Use helper function for_each_child_of_node_scoped()

2025-05-20 Thread Krzysztof Kozlowski
On 20/05/2025 11:11, Ai Chao wrote: > The for_each_child_of_node_scoped() helper provides a scope-based > clean-up functionality to put the device_node automatically, and > as such, there is no need to call of_node_put() directly. I do not see any of_node_put() there, so I don't understand what i

Re: [PATCH v2] soc: fsl: qe: remove unused qe_ic_from_irq function

2025-05-09 Thread Krzysztof Kozlowski
is applies. I am annoying hitting this warning on every W=1 build, so: Applied, thanks! [1/1] soc: fsl: qe: remove unused qe_ic_from_irq function https://git.kernel.org/krzk/linux-dt/c/d47f1233374597c348696c3da2142cc92a36fc90 Best regards, -- Krzysztof Kozlowski

Re: [PATCH] dt-bindings: soc: fsl,ls1028a-reset: Drop extra "/" in $id

2025-05-07 Thread Krzysztof Kozlowski
On Wed, May 07, 2025 at 04:59:02PM GMT, Rob Herring (Arm) wrote: > The $id value has a double "//". Drop it. > > Signed-off-by: Rob Herring (Arm) Fixes: 9ca5a7d9d2e0 ("dt-bindings: soc: fsl: Add fsl,ls1028a-reset for reset syscon node") Reviewed-by: Krzys

[PATCH] soc: fsl: Do not enable DPAA2_CONSOLE by default during compile testing

2025-04-04 Thread Krzysztof Kozlowski
Enabling the compile test should not cause automatic enabling of such drivers. Signed-off-by: Krzysztof Kozlowski --- drivers/soc/fsl/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/soc/fsl/Kconfig b/drivers/soc/fsl/Kconfig index a1e0bc8c1757..47870e29c290

Re: [PATCH v2 1/2] ASoC: dt-bindings: imx-card: Add playback-only and capture-only property

2025-02-14 Thread Krzysztof Kozlowski
On Fri, Feb 14, 2025 at 03:05:32PM +0800, Shengjiu Wang wrote: > diff --git a/Documentation/devicetree/bindings/sound/imx-audio-card.yaml > b/Documentation/devicetree/bindings/sound/imx-audio-card.yaml > index f7ad5ea2491e..86571fa930f6 100644 > --- a/Documentation/devicetree/bindings/sound/imx-au

Re: [PATCH 2/9] net: bcmasp: Add missing of_node_get() before of_find_node_by_name()

2025-02-11 Thread Krzysztof Kozlowski
On 07/02/2025 02:31, Zhang Zekun wrote: > of_find_node_by_name() will decrease the refcount of the device_node. > So, get the device_node before passing to it. > > Fixes: 490cb412007d ("net: bcmasp: Add support for ASP2.0 Ethernet > controller") > Signed-off-by: Zhang Zekun > --- > drivers/net/

Re: [PATCH 1/9] of: Add warpper function of_find_node_by_name_balanced()

2025-02-11 Thread Krzysztof Kozlowski
On 07/02/2025 02:31, Zhang Zekun wrote: > There are many drivers use of_find_node_by_name() with a not-NULL > device_node pointer, and a number of callers would require a call to > of_node_get() before using it. There are also some drivers who forget > to call of_node_get() which would cause a ref

Re: [PATCH v2 09/12] dt-bindings: memory-controllers: Convert fsl,elbc to YAML

2025-02-09 Thread Krzysztof Kozlowski
On 09/02/2025 18:28, J. Neuschäfer wrote: > On Fri, Feb 07, 2025 at 05:44:59PM -0600, Rob Herring (Arm) wrote: >> On Fri, 07 Feb 2025 22:30:26 +0100, J. Neuschäfer wrote: > [...] >>> .../bindings/memory-controllers/fsl,elbc.yaml | 146 >>> + >>> .../devicetree/bindings/po

Re: [PATCH RFC 9/9] dt-bindings: nand: Convert fsl,elbc bindings to YAML

2025-01-27 Thread Krzysztof Kozlowski
On Sun, Jan 26, 2025 at 07:59:04PM +0100, J. Neuschäfer wrote: > Convert the Freescale localbus controller bindings from text form to > YAML. The list of compatible strings reflects current usage. simple-bus and 20 other compatibles you used were not present in the original binding. Does above "li

[PATCH v2] cpufreq: Use str_enable_disable-like helpers

2025-01-14 Thread Krzysztof Kozlowski
thus also easier to read. 3. It brings uniformity in the text - same string. 4. Allows deduping by the linker, which results in a smaller binary file. Signed-off-by: Krzysztof Kozlowski --- Changes in v2: 1. Fix enable->enabled --- drivers/cpufreq/cpufreq.c | 7 ---

Re: [PATCH] cpufreq: Use str_enable_disable-like helpers

2025-01-14 Thread Krzysztof Kozlowski
On 14/01/2025 11:56, Krzysztof Kozlowski wrote: > if (cpufreq_boost_trigger_state(enable)) { > pr_err("%s: Cannot %s BOOST!\n", > -__func__, enable ? "enable" : "disable"); > +__func__, str_enabl

[PATCH] cpufreq: Use str_enable_disable-like helpers

2025-01-14 Thread Krzysztof Kozlowski
thus also easier to read. 3. It brings uniformity in the text - same string. 4. Allows deduping by the linker, which results in a smaller binary file. Signed-off-by: Krzysztof Kozlowski --- drivers/cpufreq/cpufreq.c | 7 --- drivers/cpufreq/powernv-cpufreq.c | 3 ++- 2 files c

[PATCH 2/2] PCI: dwc: layerscape: Use syscon_regmap_lookup_by_phandle_args

2025-01-12 Thread Krzysztof Kozlowski
Use syscon_regmap_lookup_by_phandle_args() which is a wrapper over syscon_regmap_lookup_by_phandle() combined with getting the syscon argument. Except simpler code this annotates within one line that given phandle has arguments, so grepping for code would be easier. Signed-off-by: Krzysztof

[PATCH 1/2] PCI: dwc: dra7xx: Use syscon_regmap_lookup_by_phandle_args

2025-01-12 Thread Krzysztof Kozlowski
in printing errors on missing syscon argument, because this is done just too late: runtime check on static/build-time data. Dtschema and Devicetree bindings offer the static/build-time check for this already. Signed-off-by: Krzysztof Kozlowski --- drivers/pci/controller/dwc/pci-dra7xx.c | 27

[PATCH 0/2] PCI: Simplify few things

2025-01-12 Thread Krzysztof Kozlowski
Few code simplifications without functional impact. Not tested on hardware. Best regards, Krzysztof --- Krzysztof Kozlowski (2): PCI: dwc: dra7xx: Use syscon_regmap_lookup_by_phandle_args PCI: dwc: layerscape: Use syscon_regmap_lookup_by_phandle_args drivers/pci/controller/dwc/pci

Re: [PATCH 16/19] powerpc: dts: Add LANCOM NWAPP2 board devicetree

2025-01-10 Thread Krzysztof Kozlowski
On 02/01/2025 19:31, J. Neuschäfer via B4 Relay wrote: > arch/powerpc/boot/dts/Makefile | 1 + > arch/powerpc/boot/dts/lancom-nwapp2.dts | 276 > > 2 files changed, 277 insertions(+) > > diff --git a/arch/powerpc/boot/dts/Makefile b/arch/powerpc/boot/d

Re: [PATCH 10/19] powerpc: dts: Add MPC8314E devicetree

2025-01-10 Thread Krzysztof Kozlowski
On 02/01/2025 19:31, J. Neuschäfer via B4 Relay wrote: > From: "J. Neuschäfer" > > The MPC8314E is a variant of the MPC8315E without SATA controllers. > > Signed-off-by: J. Neuschäfer > --- > arch/powerpc/boot/dts/mpc8314e.dtsi | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/a

Re: [PATCH 04/19] powerpc: dts: mpc8315e: Add labels to peripherals

2025-01-10 Thread Krzysztof Kozlowski
On 02/01/2025 19:31, J. Neuschäfer via B4 Relay wrote: > From: "J. Neuschäfer" > > Labels can be used in board-specific devicetrees to refer to nodes more > conveniently. > > mpc8315erdb.dtb remains identical after this patch. > > Signed-off-by: J. Neuschäfer Adding labels just to add labels

Re: [PATCH 11/19] dt-bindings: gpio: fsl,qoriq-gpio: Add compatible string fsl,mpc8314-gpio

2025-01-03 Thread Krzysztof Kozlowski
On Thu, Jan 02, 2025 at 07:31:52PM +0100, J. Neuschäfer wrote: > This is for the MPC831{4,5}{,E} SoCs. > > Signed-off-by: J. Neuschäfer > --- > Documentation/devicetree/bindings/gpio/fsl,qoriq-gpio.yaml | 1 + > 1 file changed, 1 insertion(+) Acked-by: Krzysztof Kozlow

Re: [PATCH 15/19] dt-bindings: vendor-prefixes: Add LANCOM Systems GmbH

2025-01-03 Thread Krzysztof Kozlowski
> 1 file changed, 2 insertions(+) Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: (subset) [PATCH treewide 00/11] ASoC: Clean up {hp,mic}-det-gpio handling

2024-12-05 Thread Krzysztof Kozlowski
/11] arm64: dts: uniphier: Switch to hp-det-gpios https://git.kernel.org/krzk/linux-dt/c/751df73d825b3f7e6cad42ed333c28096635784d Best regards, -- Krzysztof Kozlowski

Re: [PATCH 2/2] Documentation: dt-bindings: Remove trailing whitespace

2024-11-07 Thread Krzysztof Kozlowski
On Wed, Nov 06, 2024 at 11:11:24PM -0700, Abhinav Saxena wrote: > Remove trailing whitespace from devicetree binding documentation files: > - regulator/regulator-max77620.txt > - interrupt-controller/nvidia,tegra20-ictlr.txt > - interrupt-controller/msi.txt > > No functional changes. Issues detect

Re: [PATCH 1/2] Documentation: dt-bindings: Fix repeated words

2024-11-07 Thread Krzysztof Kozlowski
neline -- DIRECTORY_OR_FILE' on the directory your patch is touching. For bindings, the preferred subjects are explained here: https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters With changes above: Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH] powermac: Call of_node_put(bk_node) only once in pmac_has_backlight_type()

2024-10-03 Thread Krzysztof Kozlowski
On 03/10/2024 07:56, Dan Carpenter wrote: > First of all, the change is wrong. We can't dereference "prop" after calling > of_node_put(). You have to be a bit extra careful reviewing Markus's patches > because a lot of the rest of us have blocked these messages so you're on your > own in that way

Re: [PATCH treewide 10/11] ARM: dts: nxp: imx: Switch to {hp,mic}-det-gpios

2024-09-27 Thread Krzysztof Kozlowski
On 27/09/2024 14:42, Geert Uytterhoeven wrote: > Replace the deprecated "hp-det-gpio" and "mic-det-gpio" properties by > "hp-det-gpios" resp. "mic-det-gpios" in Freescale Generic ASoC Sound > Card device nodes. > > Signed-off-by: Geert Uytterhoeven > --- > This has a run-time dependency on "ASoC:

Re: [PATCH treewide 01/11] ASoC: fsl-asoc-card: Add missing handling of {hp,mic}-dt-gpios

2024-09-27 Thread Krzysztof Kozlowski
;) > Fixes: 40ba2eda0a7b727f ("arm64: dts: imx8mm-nitrogen-r2: add audio") > Signed-off-by: Geert Uytterhoeven > --- > Noticed accidentally. > Compile-tested only. Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH treewide 09/11] mips: dts: ingenic: Switch to simple-audio-card,hp-det-gpios

2024-09-27 Thread Krzysztof Kozlowski
On 27/09/2024 14:42, Geert Uytterhoeven wrote: > Replace the deprecated "simple-audio-card,hp-det-gpio" property by > "simple-audio-card,hp-det-gpios" in Simple Audio Card device nodes. > > Signed-off-by: Geert Uytterhoeven > --- Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH treewide 08/11] arm64: dts: uniphier: Switch to hp-det-gpios

2024-09-27 Thread Krzysztof Kozlowski
On 27/09/2024 14:42, Geert Uytterhoeven wrote: > Replace the deprecated "hp-det-gpio" property by "hp-det-gpios" in Audio > Graph Card device nodes. > > Signed-off-by: Geert Uytterhoeven > --- Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH treewide 06/11] arm64: dts: rockchip: Switch to simple-audio-card,hp-det-gpios

2024-09-27 Thread Krzysztof Kozlowski
On 27/09/2024 14:42, Geert Uytterhoeven wrote: > Replace the deprecated "simple-audio-card,hp-det-gpio" property by > "simple-audio-card,hp-det-gpios" in Simple Audio Card device nodes. > > Signed-off-by: Geert Uytterhoeven Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH treewide 03/11] ARM: dts: marvell: mmp2-olpc-xo-1-75: Switch to {hp,mic}-det-gpios

2024-09-27 Thread Krzysztof Kozlowski
> arch/arm/boot/dts/marvell/mmp2-olpc-xo-1-75.dts | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) I think the non-Freescale DTS could be split to indicate there is no real dependency. Only Freescale DTS will be affected, thus should be taken at least with one cycle break. Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH treewide 07/11] arm64: dts: rockchip: Switch to hp-det-gpios

2024-09-27 Thread Krzysztof Kozlowski
On 27/09/2024 14:42, Geert Uytterhoeven wrote: > Replace the deprecated "hp-det-gpio" property by "hp-det-gpios" in Audio > Graph Card and Realtek RT5651 Audio Codec device nodes. > > Signed-off-by: Geert Uytterhoeven Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH treewide 05/11] arm64: dts: renesas: beacon-renesom: Switch to mic-det-gpios

2024-09-27 Thread Krzysztof Kozlowski
| 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH treewide 04/11] arm64: dts: freescale: imx: Switch to simple-audio-card,hp-det-gpios

2024-09-27 Thread Krzysztof Kozlowski
On 27/09/2024 14:42, Geert Uytterhoeven wrote: > Replace the deprecated "simple-audio-card,hp-det-gpio" property by > "simple-audio-card,hp-det-gpios" in Simple Audio Card device nodes. > > Signed-off-by: Geert Uytterhoeven Subject: drop freescale prefix.

Re: [PATCH treewide 02/11] ASoC: dt-bindings: Deprecate {hp,mic}-det-gpio

2024-09-27 Thread Krzysztof Kozlowski
ings to > reflect this. > > Signed-off-by: Geert Uytterhoeven > --- > No driver changes needed, as gpiod_get_optional() as called from > simple_util_init_jack() tries all suffixes. > --- Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH -next 2/8] soc: fsl: cpm1: Simplify with dev_err_probe()

2024-08-28 Thread Krzysztof Kozlowski
On 28/08/2024 03:58, Jinjie Ruan wrote: > > > On 2024/8/27 21:50, Krzysztof Kozlowski wrote: >> On 27/08/2024 13:46, Jinjie Ruan wrote: >>> Use the dev_err_probe() helper to simplify error handling during probe. >>> This also handle scenario, when EDEFER is

Re: [PATCH -next 2/8] soc: fsl: cpm1: Simplify with dev_err_probe()

2024-08-27 Thread Krzysztof Kozlowski
On 27/08/2024 13:46, Jinjie Ruan wrote: > Use the dev_err_probe() helper to simplify error handling during probe. > This also handle scenario, when EDEFER is returned and useless error > is printed. ? Sorry, this cannot happen. Please point to below code which can defer. > > Signed-off-by: Jinji

[PATCH] dt-bindings: fsl: fsl,rcpm: fix unevaluated fsl,rcpm-wakeup property

2024-08-11 Thread Krzysztof Kozlowski
ooks like none of in-tree DTS use it. Fixes: ad21e3840a88 ("dt-bindings: soc: fsl: Convert rcpm to yaml format") Signed-off-by: Krzysztof Kozlowski --- .../devicetree/bindings/soc/fsl/fsl,rcpm.yaml | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --

Re: [PATCH 1/1] dt-bindings: soc: fsl: add missed compatible string fsl,ls*-isc

2024-08-05 Thread Krzysztof Kozlowski
On 02/08/2024 19:11, Frank Li wrote: > Add compatible string, fsl,ls1088a-isc, fsl,ls2080a-isc, fsl,lx2160a-isc. git grep on fsl,lx2046a-isc gives me 0. > Fix the below warning: > arch/arm64/boot/dts/freescale/fsl-ls2080a-qds.dtb: /soc/syscon@1f7: > failed to match any schema with compatible

Re: [PATCH v3 2/3] powerpc/configs: Update defconfig with now user-visible CONFIG_FSL_IFC

2024-07-02 Thread Krzysztof Kozlowski
On 02/07/2024 14:01, Michael Ellerman wrote: > Krzysztof Kozlowski writes: >> On 30/05/2024 16:46, Esben Haabendal wrote: >>> With CONFIG_FSL_IFC now being user-visible, and thus changed from a select >>> to depends in CONFIG_MTD_NAND_FSL_IFC, the dependencies

Re: [PATCH v3 3/3] arm64/configs: Update defconfig with now user-visible CONFIG_FSL_IFC

2024-07-02 Thread Krzysztof Kozlowski
On 30/05/2024 16:46, Esben Haabendal wrote: > With CONFIG_FSL_IFC now being user-visible, and thus changed from a select > to depends in CONFIG_MTD_NAND_FSL_IFC, the dependencies needs to be > selected in defconfig. > > Signed-off-by: Esben Haabendal Reviewed-by: Krzysztof K

Re: [PATCH v3 2/3] powerpc/configs: Update defconfig with now user-visible CONFIG_FSL_IFC

2024-07-02 Thread Krzysztof Kozlowski
s up? Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [Patch v5 12/12] i2x: pnx: Fix potential deadlock warning from del_timer_sync() call in isr

2024-06-28 Thread Krzysztof Kozlowski
On 27/06/2024 17:00, Piotr Wojtaszczyk wrote: > When del_timer_sync() is called in an interrupt context it throws a warning > because of potential deadlock. The timer is used only to exit from > wait_for_completion() after a timeout so replacing the call with > wait_for_completion_timeout() allows

Re: [Patch v5 02/12] dt-bindings: dma: Add lpc32xx DMA mux binding

2024-06-28 Thread Krzysztof Kozlowski
On 27/06/2024 17:00, Piotr Wojtaszczyk wrote: > LPC32XX SoCs use pl080 dma controller which have few request signals > multiplexed between peripherals. This binding describes how devices can > use the multiplexed request signals. > > Signed-off-by: Piotr Wojtaszczyk Reviewe

Re: [PATCHv5 7/9] ASoC: dt-bindings: imx-audio-spdif: remove binding

2024-06-24 Thread Krzysztof Kozlowski
On 24/06/2024 11:18, Elinor Montmasson wrote: >>> >>> Previous `imx-spdif` driver used the dummy codec instead of >>> using declared spdif codecs. It was discussed in previous version of this >>> contribution >>> that using the dummy codec isn't good practice. So one to one backward >>> compatibili

Re: [PATCHv5 6/9] ASoC: dt-bindings: fsl-asoc-card: add compatible string for spdif

2024-06-24 Thread Krzysztof Kozlowski
On 24/06/2024 10:51, Elinor Montmasson wrote: > >> The compatible is already documented, so now you create duplicated binding. >> >> This is very confusing. > > > The double compatible documentation is only temporary, next commit (7/9) > removes the previous binding in "fsl,imx-audio-spdif.yaml"

Re: [PATCHv5 7/9] ASoC: dt-bindings: imx-audio-spdif: remove binding

2024-06-24 Thread Krzysztof Kozlowski
On 24/06/2024 10:51, Elinor Montmasson wrote: > From: "Krzysztof Kozlowski" > Sent: Sunday, 23 June, 2024 13:09:33 >> On 20/06/2024 15:25, Elinor Montmasson wrote: >>> imx-audio-spdif was merged into the fsl-asoc-card driver, and therefore >>> removed.

Re: [PATCHv5 8/9] arm64: dts: imx8m: update spdif sound card node properties

2024-06-23 Thread Krzysztof Kozlowski
On 20/06/2024 15:25, Elinor Montmasson wrote: > Following merge of imx-spdif driver into fsl-asoc-card: > * update properties to match those used by fsl-asoc-card. > * S/PDIF in/out dummy codecs must now be declared explicitly, add and > use them. > > These modifications were tested only on an i

Re: [PATCHv5 7/9] ASoC: dt-bindings: imx-audio-spdif: remove binding

2024-06-23 Thread Krzysztof Kozlowski
On 20/06/2024 15:25, Elinor Montmasson wrote: > imx-audio-spdif was merged into the fsl-asoc-card driver, and therefore > removed. So what happens with all existing users (e.g. DTS)? They become invalid/not supported? After quick look, I do not see backwards compatibility in the driver and above

Re: [PATCHv5 6/9] ASoC: dt-bindings: fsl-asoc-card: add compatible string for spdif

2024-06-23 Thread Krzysztof Kozlowski
On 20/06/2024 15:25, Elinor Montmasson wrote: > The S/PDIF audio card support was merged from imx-spdif into the > fsl-asoc-card driver, making it possible to use an S/PDIF with an ASRC. > Add the new compatible and update properties. Please use standard email subjects, so with the PATCH keyword i

Re: [Patch v4 07/10] ARM: lpc32xx: Remove pl08x platform data in favor for device tree

2024-06-20 Thread Krzysztof Kozlowski
On 21/06/2024 07:56, Markus Elfring wrote: >> With the driver for nxp,lpc3220-dmamux we can remove the pl08x platform >> data and let pl08x driver to create peripheral channels from the DT >> properties. > > Do you see opportunities to improve such a change description? > https://git.kernel.org/pu

Re: [Patch v4 06/10] dmaengine: Add dma router for pl08x in LPC32XX SoC

2024-06-20 Thread Krzysztof Kozlowski
On 20/06/2024 19:56, Piotr Wojtaszczyk wrote: > LPC32XX connects few of its peripherals to pl08x DMA thru a multiplexer, > this driver allows to route a signal request line thru the multiplexer for > given peripheral. > > Signed-off-by: Piotr Wojtaszczyk > --- > Changes for v4: > - This patch is

Re: [Patch v4 05/10] clk: lpc32xx: initialize regmap using parent syscon

2024-06-20 Thread Krzysztof Kozlowski
On 20/06/2024 19:56, Piotr Wojtaszczyk wrote: > > - base = of_iomap(np, 0); > - if (!base) { > - pr_err("failed to map system control block registers\n"); > - return; > - } > - > - clk_regmap = regmap_init_mmio(NULL, base, &lpc32xx_scb_regmap_config); > +

Re: [Patch v4 04/10] ARM: dts: lpc32xx: Add missing dma and i2s properties

2024-06-20 Thread Krzysztof Kozlowski
On 20/06/2024 19:56, Piotr Wojtaszczyk wrote: > Adds properties declared in the new DT bindings: > - nxp,lpc3220-i2s.yaml > - nxp,lpc3220-dmamux.yaml > for dma router/mux and I2S interface. > > Signed-off-by: Piotr Wojtaszczyk You are doing here multiple things at once. This should be One pat

Re: [Patch v4 03/10] ASoC: dt-bindings: lpc32xx: Add lpc32xx i2s DT binding

2024-06-20 Thread Krzysztof Kozlowski
Vladimir Zapolskiy > +L: alsa-de...@alsa-project.org (moderated for non-subscribers) > +L: linuxppc-dev@lists.ozlabs.org > +S: Maintained > +F: Documentation/devicetree/bindings/sound/nxp,lpc3220-i2s.yaml > +N: lpc32xx Drop the last "N:". Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [Patch v4 02/10] dt-bindings: dma: Add lpc32xx DMA mux binding

2024-06-20 Thread Krzysztof Kozlowski
On 20/06/2024 19:56, Piotr Wojtaszczyk wrote: > LPC32XX SoCs use pl080 dma controller which have few request signals > multiplexed between peripherals. This binding describes how devices can > use the multiplexed request signals. > > Signed-off-by: Piotr Wojtaszczyk > + > +properties: > + "#dma

Re: [Patch v4 01/10] dt-bindings: dma: pl08x: Add dma-cells description

2024-06-20 Thread Krzysztof Kozlowski
On 20/06/2024 19:56, Piotr Wojtaszczyk wrote: > Recover dma-cells description from the legacy DT binding. Fixes: 6f64aa5746d2 ("dt-bindings: dma: convert arm-pl08x to yaml") Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v3 1/4] ASoC: dt-bindings: lpc32xx: Add lpc32xx i2s DT binding

2024-06-17 Thread Krzysztof Kozlowski
On 17/06/2024 16:04, Piotr Wojtaszczyk wrote: >> >>> It's used by snd_soc_dai_init_dma_data() in [PATCH v3 4/4] to give the >>> dmaengine a >>> hint which dma config to use. The LPC32xx doesn't have yet a dmamux driver >>> like >> >> and if I change driver platform data to foo and bar, does the DT

Re: [PATCH v3 1/4] ASoC: dt-bindings: lpc32xx: Add lpc32xx i2s DT binding

2024-06-17 Thread Krzysztof Kozlowski
On 17/06/2024 11:33, Piotr Wojtaszczyk wrote: > On Sat, Jun 15, 2024 at 12:01 PM Krzysztof Kozlowski wrote: >> Do not attach (thread) your patchsets to some other threads (unrelated >> or older versions). This buries them deep in the mailbox and might >> interfere with

Re: (subset) [RFC PATCH 2/2] dt-bindings: memory: fsl: replace maintainer

2024-06-16 Thread Krzysztof Kozlowski
b570a28b4e3d877ef6c Best regards, -- Krzysztof Kozlowski

Re: [RFC PATCH 2/2] dt-bindings: memory: fsl: replace maintainer

2024-06-16 Thread Krzysztof Kozlowski
On 17/06/2024 05:24, Shawn Guo wrote: > On Tue, Jun 11, 2024 at 10:49:36AM +0200, Krzysztof Kozlowski wrote: >> On 04/06/2024 16:22, Michael Walle wrote: >>> Li Yang's mail address is bouncing, replace it with Shawn Guo's one. >>> >>> Signed-off-by: M

Re: [PATCH v3 1/4] ASoC: dt-bindings: lpc32xx: Add lpc32xx i2s DT binding

2024-06-15 Thread Krzysztof Kozlowski
On 14/06/2024 18:34, Piotr Wojtaszczyk wrote: > Add nxp,lpc3220-i2s DT binding documentation. > > Signed-off-by: Piotr Wojtaszczyk Do not attach (thread) your patchsets to some other threads (unrelated or older versions). This buries them deep in the mailbox and might interfere with applying ent

Re: [Patch v2 2/2] ASoC: dt-bindings: lpc32xx: Add lpc32xx i2s DT binding

2024-06-12 Thread Krzysztof Kozlowski
On 12/06/2024 10:02, Piotr Wojtaszczyk wrote: > On Tue, Jun 11, 2024 at 12:18 PM Krzysztof Kozlowski wrote: >> I do not see my comment about DAI being addressed. > Were you asking if it's a DAI? yes it is. > Then you miss $ref to dai-common and defining sound-dai-cells li

Re: [Patch v2 2/2] ASoC: dt-bindings: lpc32xx: Add lpc32xx i2s DT binding

2024-06-12 Thread Krzysztof Kozlowski
On 12/06/2024 10:06, Piotr Wojtaszczyk wrote: > On Tue, Jun 11, 2024 at 12:45 PM Krzysztof Kozlowski wrote: >>> Changes for v2: >>> - Added maintainers field >>> - Dropped clock-names >>> - Dropped unused unneded interrupts field >> >> Does th

Re: (subset) [PATCH v3 1/3] memory: fsl_ifc: Make FSL_IFC config visible and selectable

2024-06-12 Thread Krzysztof Kozlowski
inux-mem-ctrl/c/9ba0cae3cac07c21c583f9ff194f74043f90d29c Best regards, -- Krzysztof Kozlowski

Re: [Patch v2 2/2] ASoC: dt-bindings: lpc32xx: Add lpc32xx i2s DT binding

2024-06-11 Thread Krzysztof Kozlowski
On 11/06/2024 11:47, Piotr Wojtaszczyk wrote: > Add nxp,lpc3220-i2s DT binding documentation. > > Signed-off-by: Piotr Wojtaszczyk > --- > Changes for v2: > - Added maintainers field > - Dropped clock-names > - Dropped unused unneded interrupts field Does the device has interrupts or not? This s

Re: [Patch v2 2/2] ASoC: dt-bindings: lpc32xx: Add lpc32xx i2s DT binding

2024-06-11 Thread Krzysztof Kozlowski
On 11/06/2024 11:47, Piotr Wojtaszczyk wrote: > Add nxp,lpc3220-i2s DT binding documentation. > > Signed-off-by: Piotr Wojtaszczyk > --- > + > +maintainers: > + - Piotr Wojtaszczyk > + > +properties: > + compatible: > +enum: > + - nxp,lpc3220-i2s > + > + reg: > +maxItems: 1 > +

Re: [Patch v2 1/2] ASoC: fsl: Add i2s and pcm drivers for LPC32xx CPUs

2024-06-11 Thread Krzysztof Kozlowski
On 11/06/2024 11:47, Piotr Wojtaszczyk wrote: > This driver was ported from an old version in linux 2.6.27 and adjusted > for the new ASoC framework and DMA API. > > Signed-off-by: Piotr Wojtaszczyk > --- > Changes for v2: > - Coding Style cleanup > - Use dev_err_probe() for error handling in pro

Re: [RFC PATCH 2/2] dt-bindings: memory: fsl: replace maintainer

2024-06-11 Thread Krzysztof Kozlowski
rship. > --- I suppose this could go via IMX SoC tree, so: Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 1/2] dt-bindings: Drop Li Yang as maintainer for all bindings

2024-06-11 Thread Krzysztof Kozlowski
NERS but > didn't address all the in-file entries of the device tree bindings. > > Signed-off-by: Michael Walle Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v2 2/2] powerpc/configs: Update defconfig with now user-visible CONFIG_FSL_IFC

2024-05-28 Thread Krzysztof Kozlowski
On 28/05/2024 15:33, Esben Haabendal wrote: > Krzysztof Kozlowski writes: > >> On 28/05/2024 14:28, Esben Haabendal wrote: >>> With CONFIG_FSL_IFC now being user-visible, and thus changed from a select >>> to depends in CONFIG_MTD_NAND_FSL_IFC, the dependencies need

Re: [PATCH v2 1/2] memory: fsl_ifc: Make FSL_IFC config visible and selectable

2024-05-28 Thread Krzysztof Kozlowski
On 28/05/2024 15:15, Christophe Leroy wrote: > > > Le 28/05/2024 à 14:28, Esben Haabendal a écrit : >> [Vous ne recevez pas souvent de courriers de es...@geanix.com. Découvrez >> pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ] >> >> While use of fsl_ifc driver with

Re: [PATCH v2 2/2] powerpc/configs: Update defconfig with now user-visible CONFIG_FSL_IFC

2024-05-28 Thread Krzysztof Kozlowski
On 28/05/2024 14:28, Esben Haabendal wrote: > With CONFIG_FSL_IFC now being user-visible, and thus changed from a select > to depends in CONFIG_MTD_NAND_FSL_IFC, the dependencies needs to be > selected in config snippets. > > Signed-off-by: Esben Haabendal > --- > arch/powerpc/configs/85xx-hw.co

Re: [PATCH 1/2] ASoC: dt-bindings: fsl,mqs: Add i.MX95 platform support

2024-05-20 Thread Krzysztof Kozlowski
On 17/05/2024 11:45, Shengjiu Wang wrote: > In order to support the MQS module on i.MX95, a new property > "fsl,mqs-ctrl" needs to be added, as there are two MQS instances > on the i.MX95 platform, the definition of bit positions in the > control register is different. This new property is to disti

[PATCH 13/13] ASoC: sunxi: Use snd_soc_substream_to_rtd() for accessing private_data

2024-04-30 Thread Krzysztof Kozlowski
Do not open-code snd_soc_substream_to_rtd(). Signed-off-by: Krzysztof Kozlowski --- sound/soc/sunxi/sun50i-dmic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/sunxi/sun50i-dmic.c b/sound/soc/sunxi/sun50i-dmic.c index c76628bc86c6..fedfa4fc95fb 100644 --- a/sound

[PATCH 12/13] ASoC: samsung: Use snd_soc_substream_to_rtd() for accessing private_data

2024-04-30 Thread Krzysztof Kozlowski
Do not open-code snd_soc_substream_to_rtd(). Signed-off-by: Krzysztof Kozlowski --- sound/soc/samsung/midas_wm1811.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/samsung/midas_wm1811.c b/sound/soc/samsung/midas_wm1811.c index f31244156ff6..0841e2e6f8ce 100644

[PATCH 11/13] ASoC: meson: Use snd_soc_substream_to_rtd() for accessing private_data

2024-04-30 Thread Krzysztof Kozlowski
Do not open-code snd_soc_substream_to_rtd(). Signed-off-by: Krzysztof Kozlowski --- sound/soc/meson/aiu-fifo.c | 2 +- sound/soc/meson/axg-fifo.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/meson/aiu-fifo.c b/sound/soc/meson/aiu-fifo.c index 4041ff8e437f

[PATCH 10/13] ASoC: mediatek: Use snd_soc_substream_to_rtd() for accessing private_data

2024-04-30 Thread Krzysztof Kozlowski
Do not open-code snd_soc_substream_to_rtd(). Signed-off-by: Krzysztof Kozlowski --- sound/soc/mediatek/mt7986/mt7986-afe-pcm.c | 4 ++-- sound/soc/mediatek/mt8186/mt8186-afe-pcm.c | 14 +++--- sound/soc/mediatek/mt8186/mt8186-mt6366.c | 2 +- sound/soc/mediatek/mt8188/mt8188-afe

[PATCH 09/13] ASoC: loongson: Use snd_soc_substream_to_rtd() for accessing private_data

2024-04-30 Thread Krzysztof Kozlowski
Do not open-code snd_soc_substream_to_rtd(). Signed-off-by: Krzysztof Kozlowski --- sound/soc/loongson/loongson_card.c | 2 +- sound/soc/loongson/loongson_dma.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/loongson/loongson_card.c b/sound/soc/loongson

[PATCH 08/13] ASoC: kirkwood: Use snd_soc_substream_to_rtd() for accessing private_data

2024-04-30 Thread Krzysztof Kozlowski
Do not open-code snd_soc_substream_to_rtd(). Signed-off-by: Krzysztof Kozlowski --- sound/soc/kirkwood/kirkwood-dma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/kirkwood/kirkwood-dma.c b/sound/soc/kirkwood/kirkwood-dma.c index ef00792e1d49..036b42058272

[PATCH 07/13] ASoC: img: Use snd_soc_substream_to_rtd() for accessing private_data

2024-04-30 Thread Krzysztof Kozlowski
Do not open-code snd_soc_substream_to_rtd(). Signed-off-by: Krzysztof Kozlowski --- sound/soc/img/img-i2s-in.c | 2 +- sound/soc/img/img-i2s-out.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/img/img-i2s-in.c b/sound/soc/img/img-i2s-in.c index dacc29fcf24b

[PATCH 06/13] ASoC: fsl: Use snd_soc_substream_to_rtd() for accessing private_data

2024-04-30 Thread Krzysztof Kozlowski
Do not open-code snd_soc_substream_to_rtd(). Signed-off-by: Krzysztof Kozlowski --- sound/soc/fsl/fsl-asoc-card.c | 2 +- sound/soc/fsl/imx-card.c | 6 +++--- sound/soc/fsl/imx-hdmi.c | 2 +- sound/soc/fsl/imx-pcm-rpmsg.c | 6 +++--- 4 files changed, 8 insertions(+), 8 deletions

[PATCH 05/13] ASoC: amd: Use snd_soc_substream_to_rtd() for accessing private_data

2024-04-30 Thread Krzysztof Kozlowski
Do not open-code snd_soc_substream_to_rtd(). Signed-off-by: Krzysztof Kozlowski --- sound/soc/amd/acp/acp-mach-common.c | 2 +- sound/soc/amd/acp3x-rt5682-max9836.c | 2 +- sound/soc/amd/ps/ps-sdw-dma.c| 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/sound/soc/amd

  1   2   3   4   >