Re: [PATCH] Fix masking of interrupts for 52xx GPT IRQ.

2011-03-04 Thread Henk Stegeman
Henk. On Wed, Mar 2, 2011 at 10:30 PM, Grant Likely wrote: > [fixed top-posted reply] > > On Wed, Feb 9, 2011 at 3:16 AM, Henk Stegeman wrote: >> On Mon, Feb 7, 2011 at 12:05 AM, Benjamin Herrenschmidt >> wrote: >>> On Sat, 2011-01-15 at 02:28 +0100, Henk Stegeman wro

Re: [PATCH] Fix masking of interrupts for 52xx GPT IRQ.

2011-02-09 Thread Henk Stegeman
wrong it would be nice to let the kernel print a big fat warning when this is registered. Cheers, Henk On Mon, Feb 7, 2011 at 12:05 AM, Benjamin Herrenschmidt wrote: > On Sat, 2011-01-15 at 02:28 +0100, Henk Stegeman wrote: >> When using the GPT as interrupt controller interupts were missi

[PATCH] Fix masking of interrupts for 52xx GPT IRQ.

2011-01-18 Thread Henk Stegeman
because the GPT as interrupt ontroller only serves one IRQ. Signed-off-by: Henk Stegeman --- arch/powerpc/platforms/52xx/mpc52xx_gpt.c | 25 ++--- 1 files changed, 22 insertions(+), 3 deletions(-) diff --git a/arch/powerpc/platforms/52xx/mpc52xx_gpt.c b/arch/powerpc/platforms

BUG: mpc52xx_gpt mask/unmask of interrupts

2010-03-11 Thread Henk Stegeman
ix yet. Is it possible to somehow make use of the mpc52xx_pic mask funtions? For this case that would be quite valid as the gpt as interrupt controller only provides one interrupt, so masking one is the same as masking 'all' on the parent. Ch

IRQ's missing with MPC5200 GPT as an interrupt controller

2010-03-08 Thread Henk Stegeman
I'm trying to make use of the GPT as interrupt controller. My driver is getting most, but not all of the interrupts, besides that I'm getting a whole bunch of spurious IRQs, so I'm trying to figure out what's wrong. gpt6: ti...@660 { compatible = "fsl

Re: Chipselect in SPI binding with mpc5200-psc-spi

2009-07-08 Thread Henk Stegeman
It now works, in the dts interrupt-controller = < &gpt6 >; // Use GPT6 as should have been interrupt-parent = < &gpt6 >; // Use GPT6 as On Tue, Jul 7, 2009 at 5:57 PM, Grant Likely wrote: > On Tue, Jul 7, 2009 at 8:31 AM, Henk Stegeman wrote: >> I

Re: Chipselect in SPI binding with mpc5200-psc-spi

2009-07-07 Thread Henk Stegeman
uot;; spi-max-frequency = <80>; spi-cpha; reg = <0>; word-delay-us = <30>; interrupt-controller = <&gpt6>; // Use GPT6 as the IRQ controller interrupts = <2>; // And make it edge fall

Patch: Fix fec_mpc52xx driver to use net_device_ops

2009-03-31 Thread Henk Stegeman
Fix fec_mpc52xx driver to use net_device_ops and to be careful not to dereference phy_device if a phy has not yet been connected. Signed-off-by: Henk Stegeman diff --git a/drivers/net/fec_mpc52xx.c b/drivers/net/fec_mpc52xx.c index cd8e98b..ca76b95 100644 --- a/drivers/net/fec_mpc52xx.c +++ b

Re: Davicom DM9000A on MPC5200B (powerpc) works using a dirty offsetting and byte trick

2009-03-09 Thread Henk Stegeman
uting the data bus and one by enabling the byte swap on the chip-select. Or does one of them not really swap bytes? Henk On Sat, Mar 7, 2009 at 11:09 AM, Juergen Beisert wrote: > Henk, > > On Freitag, 20. Februar 2009, Henk Stegeman wrote: >> - Any suggestions to what could be wro

Re: support IRQ from GPIO trough OF and GPIOLIB

2009-03-06 Thread Henk Stegeman
I just saw that I missed an earlier very useful a suggestion from Grant Likely: http://ozlabs.org/pipermail/linuxppc-dev/2009-February/068357.html By defining the irq in the dts directly I don't need the gpio irq support anymore. On Thu, Mar 5, 2009 at 12:20 PM, Henk Stegeman wrote

support IRQ from GPIO trough OF and GPIOLIB

2009-03-05 Thread Henk Stegeman
Hello, I have an SPI device that sends an IRQ to the CPU (MPC5200) via GPIO (GPT6): gpt6: ti...@660 { // General Purpose Timer GPT6 in GPIO mode for SMC4000IO sample irq. compatible = "fsl,mpc5200b-gpt-gpio","fsl,mpc5200-gpt-gpio"; cell-index = <6>; reg = <0x660 0x10

Re: support IRQ from GPIO trough OF and GPIOLIB

2009-03-05 Thread Henk Stegeman
PM, Henk Stegeman wrote: > Hello, > > I have an SPI device that sends an IRQ to the CPU (MPC5200) via GPIO (GPT6): > > gpt6: ti...@660 {       // General Purpose Timer GPT6 in GPIO mode for > SMC4000IO sample irq. >        compatible = "fsl,mpc5200b-gpt-gpio","

Two thoughts about SPI chip-selects in the DTS

2009-02-26 Thread Henk Stegeman
As far as I understand the DTS bindings now support an SPI master controller to - use the chip-selects controlled directly by the SPI master controller hardware or - to use GPIO's trough gpiolib as chip selects but not a combination of both, am I right? Now every SPI driver needs to be adapted to

Davicom DM9000A on MPC5200B (powerpc) works using a dirty offsetting and byte trick

2009-02-20 Thread Henk Stegeman
ase only byte swap u16 reads, but a u8 read is unchanged? - What about how the DM9000 driver deals with this u8 read and u16 read, is this correct? Thanks, Henk /* * dm9000 device setup code * * Maintained by Henk Stegeman < henk.stege...@gmail.com > * * This program is free so

Re: net_device_ops support in bridging and fec_mpc52xx.c

2009-02-19 Thread Henk Stegeman
s = &mpc52xx_fec_netdev_ops; priv->t_irq = priv->r_irq = ndev->irq = NO_IRQ; /* IRQ are free for now */ On Wed, Feb 18, 2009 at 10:48 PM, David Miller wrote: > From: Henk Stegeman > Date: Wed, 18 Feb 2009 11:41:14 +0100 > > Please CC: netdev, now added, on all n

net_device_ops support in bridging and fec_mpc52xx.c

2009-02-18 Thread Henk Stegeman
Hello, I discovered the hard way that because linux bridging uses net_device_ops, bridging only works with network drivers that publish their device operations trough net_device_ops. In my case running: brctl addif br0 eth0 (where eth0 fec_mpc52xx.c did not yet support net_device_ops) gave me a:

Re: Chipselect in SPI binding with mpc5200-psc-spi

2009-02-13 Thread Henk Stegeman
l as example for adding the of support to my 'own' spi slave driver. (Thanks Anton,) Henk. On Fri, Feb 13, 2009 at 4:19 PM, Grant Likely wrote: > On Fri, Feb 13, 2009 at 3:40 AM, Henk Stegeman > wrote: > > I'm busy adding support for slave deviced behind mpc52xx-psc-spi

Re: Chipselect in SPI binding with mpc5200-psc-spi

2009-02-13 Thread Henk Stegeman
init); Then my smc4000io_of_probe function never gets called. Thanks in advance, Henk. On Wed, Oct 29, 2008 at 3:45 PM, Grant Likely wrote: > On Wed, Oct 29, 2008 at 7:43 AM, Henk Stegeman > wrote: > > .. > > .. > > In my dts > > > > I have my chipsel

Chipselect in SPI binding with mpc5200-psc-spi

2008-10-29 Thread Henk Stegeman
.. .. In my dts I have my chipselect defined as follows: gpt4: [EMAIL PROTECTED] {// General Purpose Timer GPT4 in GPIO mode for SMC4000IO chip select. compatible = "fsl,mpc5200b-gpt-gpio","fsl,mpc5200-gpt-gpio"; cell-index = <4>; reg = <0x640 0x10