Re: [PATCH v2 00/11] kasan: unify kasan_arch_is_ready with kasan_enabled

2025-07-01 Thread Heiko Carstens
On Tue, Jul 01, 2025 at 12:25:32PM +0200, Christophe Leroy wrote: > Your patch below is simpler than what I proposed, but it keeps the static > branches so the overhead remains. > > I also proposed a change, it goes further by removing the static branch for > architectures that don't need it, see

Re: [PATCH v2 00/11] kasan: unify kasan_arch_is_ready with kasan_enabled

2025-07-01 Thread Heiko Carstens
> > > Another thing that needs careful consideration is whether it's > > > possible to combine kasan_arch_is_ready() and kasan_enabled() into the > > > same check logically at all. There's one issue mentioned in [1]: > > > > Hello, > > I've removed kasan_arch_is_ready() at all in this series: > > [

Re: [PATCH v2 01/11] kasan: unify static kasan_flag_enabled across modes

2025-06-30 Thread Heiko Carstens
On Mon, Jun 30, 2025 at 02:31:00PM +0200, Alexander Gordeev wrote: > On Thu, Jun 26, 2025 at 08:31:37PM +0500, Sabyrzhan Tasbolatov wrote: > > Hi Sabyrzhan, > > > diff --git a/mm/kasan/generic.c b/mm/kasan/generic.c > > index d54e89f8c3e..32c432df24a 100644 > > --- a/mm/kasan/generic.c > > +++ b/

Re: [PATCH 5/7] s390/crc: drop "glue" from filenames

2025-04-25 Thread Heiko Carstens
Makefile | 2 +- > arch/s390/lib/{crc32-glue.c => crc32.c} | 0 > 2 files changed, 1 insertion(+), 1 deletion(-) > rename arch/s390/lib/{crc32-glue.c => crc32.c} (100%) Acked-by: Heiko Carstens

Re: [PATCH v2 10/13] crypto: s390 - move library functions to arch/s390/lib/crypto/

2025-04-22 Thread Heiko Carstens
/crypto/chacha-s390.S (100%) > rename arch/s390/{ => lib}/crypto/chacha-s390.h (100%) Acked-by: Heiko Carstens

Re: [PATCH v2 03/13] crypto: s390 - drop redundant dependencies on S390

2025-04-22 Thread Heiko Carstens
-off-by: Eric Biggers > --- > arch/s390/crypto/Kconfig | 10 -- > 1 file changed, 10 deletions(-) Acked-by: Heiko Carstens

Re: [PATCH] lib/crc: make the CPU feature static keys __ro_after_init

2025-04-17 Thread Heiko Carstens
| 4 ++-- > arch/loongarch/lib/crc32-loongarch.c | 2 +- > arch/mips/lib/crc32-mips.c | 2 +- > arch/powerpc/lib/crc-t10dif-glue.c | 2 +- > arch/powerpc/lib/crc32-glue.c | 2 +- > arch/s390/lib/crc32-glue.c | 2 +- Acked-by: Heiko Carstens # s390 I just

Re: [PATCH v4 10/14] s390: Add support for suppressing warning backtraces

2025-04-05 Thread Heiko Carstens
On Fri, Mar 21, 2025 at 10:05:42PM +0100, Alessandro Carminati wrote: > > > +#ifdef CONFIG_KUNIT_SUPPRESS_BACKTRACE > > > +# define HAVE_BUG_FUNCTION > > > +# define __BUG_FUNC_PTR " .long %0-.\n" > > > +# define __BUG_FUNC __func__ > > > > gcc 7.5.0 on s390 barfs; it doesn't like the

Re: [PATCH 07/13] s390: make setup_zero_pages() use memblock

2025-03-07 Thread Heiko Carstens
generic > code and reducing code duplication in arch::mem_init(). > > Signed-off-by: Mike Rapoport (Microsoft) > --- > arch/s390/mm/init.c | 14 +++--- > 1 file changed, 3 insertions(+), 11 deletions(-) Acked-by: Heiko Carstens > - empty_zero_page

Re: [PATCH 10/17] s390/vdso: Switch to generic storage implementation

2025-01-09 Thread Heiko Carstens
-- > 9 files changed, 17 insertions(+), 153 deletions(-) Looks good to me and works. Acked-by: Heiko Carstens

Re: [PATCH v3 5/6] s390/crash: Use note name macros

2025-01-08 Thread Heiko Carstens
sa->todpreg); > > > + size += NT_SIZE(S390_CTRS, sa->ctrs); > > > + size += NT_SIZE(S390_PREFIX, sa->prefix); > > > > It might be worth fixing the funny spacing on these lines, since all > > the affected lines are being replaced. Yes, please! Besides that this looks good: Acked-by: Heiko Carstens

Re: [PATCH v2 04/21] s390: kernel: Convert timeouts to use secs_to_jiffies()

2024-11-18 Thread Heiko Carstens
On Fri, Nov 15, 2024 at 09:26:21PM +, Easwar Hariharan wrote: > Changes made with the following Coccinelle rules: > > @@ constant C; @@ > > - msecs_to_jiffies(C * 1000) > + secs_to_jiffies(C) > > @@ constant C; @@ > > - msecs_to_jiffies(C * MSEC_PER_SEC) > + secs_to_jiffies(C) > > Signed-o

Re: [PATCH 07/15] s390/crc32: expose CRC32 functions through lib

2024-10-21 Thread Heiko Carstens
On Sun, Oct 20, 2024 at 05:29:27PM -0700, Eric Biggers wrote: > From: Eric Biggers > > Move the s390 CRC32 assembly code into the lib directory and wire it up > to the library interface. This allows it to be used without going > through the crypto API. It remains usable via the crypto API too v

Re: [PATCH 6/9] s390/vdso: Remove timekeeper includes

2024-10-10 Thread Heiko Carstens
; > Also drop the comment which is out of date and in the wrong place. > > Signed-off-by: Thomas Weißschuh > --- > arch/s390/include/asm/vdso/vsyscall.h | 5 - > arch/s390/kernel/time.c | 1 - > 2 files changed, 6 deletions(-) Acked-by: Heiko Carstens

Re: [PATCH 03/28] s390/vdso: Drop LBASE_VDSO

2024-10-10 Thread Heiko Carstens
> Signed-off-by: Thomas Weißschuh > --- > arch/s390/include/asm/vdso.h | 3 --- > arch/s390/kernel/vdso32/vdso32.lds.S | 2 +- > arch/s390/kernel/vdso64/vdso64.lds.S | 2 +- > 3 files changed, 2 insertions(+), 5 deletions(-) Acked-by: Heiko Carstens

Re: [PATCH 28/28] vdso: Rename struct arch_vdso_data to arch_vdso_time_data

2024-10-10 Thread Heiko Carstens
clude/vdso/datapage.h | 8 > 9 files changed, 26 insertions(+), 26 deletions(-) Acked-by: Heiko Carstens # s390

Re: [PATCH v2 2/2] ftrace: Consolidate ftrace_regs accessor functions for archs using pt_regs

2024-10-09 Thread Heiko Carstens
ll also make it easier to add new accessor functions to > ftrace_regs as it will mean having to touch less architectures. > > Suggested-by: Masami Hiramatsu (Google) > Signed-off-by: Steven Rostedt (Google) ... > arch/s390/include/asm/ftrace.h | 26 + Acked-by: Heiko Carstens # s390

Re: [PATCH v2 1/2] ftrace: Make ftrace_regs abstract from direct use

2024-10-09 Thread Heiko Carstens
t; > Acked-by: Catalin Marinas > Signed-off-by: Steven Rostedt (Google) > --- ... > arch/s390/include/asm/ftrace.h | 23 ++- > arch/s390/kernel/asm-offsets.c | 4 ++-- > arch/s390/kernel/ftrace.c| 2 +- > arch/s390/lib/test_unwind.c | 4 ++-- Acked-by: Heiko Carstens # s390

Re: [PATCH v2 0/2] ftrace: Make ftrace_regs abstract and consolidate code

2024-10-09 Thread Heiko Carstens
On Tue, Oct 08, 2024 at 07:05:27PM -0400, Steven Rostedt wrote: > > This is based on: > > https://git.kernel.org/pub/scm/linux/kernel/git/trace/linux-trace.git/ > ftrace/for-next > > ftrace_regs was created to hold registers that store information to save > function parameters, return val

Re: [PATCH] ftrace: Make ftrace_regs abstract from direct use

2024-10-08 Thread Heiko Carstens
On Mon, Oct 07, 2024 at 08:54:58PM -0400, Steven Rostedt wrote: > On Mon, 7 Oct 2024 20:47:43 -0400 > Steven Rostedt wrote: > #define arch_ftrace_get_regs(fregs) ({ &arch_ftrace_regs(fregs)->regs; }) > > I may send a v2 (tomorrow). Could you also write against which tree this patch is? It does

Re: [PATCH 02/15] syscalls: fix compat_sys_io_pgetevents_time64 usage

2024-06-21 Thread Heiko Carstens
l/syscalls/syscall_o32.tbl | 2 +- > arch/powerpc/kernel/syscalls/syscall.tbl | 2 +- > arch/s390/kernel/syscalls/syscall.tbl | 2 +- > arch/sparc/kernel/syscalls/syscall.tbl| 2 +- > arch/x86/entry/syscalls/syscall_32.tbl| 2 +- > include/uapi/asm-generic/unistd.h | 2 +- > 8 files changed, 8 insertions(+), 8 deletions(-) Acked-by: Heiko Carstens # s390

Re: [PATCH 12/15] s390: remove native mmap2() syscall

2024-06-21 Thread Heiko Carstens
t; > Signed-off-by: Arnd Bergmann > --- > arch/s390/kernel/syscall.c | 27 --- > 1 file changed, 27 deletions(-) Acked-by: Heiko Carstens

Re: [PATCH v3 11/11] sysctl: treewide: constify the ctl_table argument of handlers

2024-04-29 Thread Heiko Carstens
ta_base.c| 10 ++--- > arch/s390/kernel/debug.c | 2 +- > arch/s390/kernel/topology.c | 2 +- > arch/s390/mm/cmm.c| 6 +-- Acked-by: Heiko Carstens # s390

Re: [PATCH 7/9] s390: Convert from tasklet to BH workqueue

2024-04-08 Thread Heiko Carstens
On Wed, Mar 27, 2024 at 04:03:12PM +, Allen Pais wrote: > The only generic interface to execute asynchronously in the BH context is > tasklet; however, it's marked deprecated and has some design flaws. To > replace tasklets, BH workqueue support was recently added. A BH workqueue > behaves simi

Re: [PATCH v2 6/7] s390: mm: accelerate pagefault when badaccess

2024-04-07 Thread Heiko Carstens
count_vm_vma_lock_event(VMA_LOCK_SUCCESS); > + return handle_fault_error_nolock(regs, SEGV_ACCERR); Reviewed-by: Heiko Carstens

Re: [PATCH v2 0/7] arch/mm/fault: accelerate pagefault when badaccess

2024-04-07 Thread Heiko Carstens
On Sun, Apr 07, 2024 at 03:49:53PM +0800, Kefeng Wang wrote: > On 2024/4/4 4:45, Andrew Morton wrote: > > On Wed, 3 Apr 2024 16:37:58 +0800 Kefeng Wang > > wrote: > > > > > After VMA lock-based page fault handling enabled, if bad access met > > > under per-vma lock, it will fallback to mmap_lock

Re: [PATCH 3/4] arch: define CONFIG_PAGE_SIZE_*KB on all architectures

2024-02-27 Thread Heiko Carstens
> #include > > -#define _PAGE_SHIFT 12 > +#define _PAGE_SHIFT CONFIG_PAGE_SHIFT Acked-by: Heiko Carstens

Re: [PATCH 5/5] sched/vtime: do not include header

2024-01-29 Thread Heiko Carstens
On Sun, Jan 28, 2024 at 08:58:54PM +0100, Alexander Gordeev wrote: > There is no architecture-specific code or data left > that generic needs to know about. > Thus, avoid the inclusion of header. > > Signed-off-by: Alexander Gordeev > --- > include/asm-generic/vtime.h | 1 - > include/linux/vt

Re: [PATCH 4/5] s390/irq,nmi: do not include header

2024-01-29 Thread Heiko Carstens
; +++ b/arch/s390/kernel/nmi.c > +#include It is confusing when the patch subject is "do not include.." and all what this patch is doing is to add two includes. I see what this is doing: getting rid of the implicit include of asm/vtime.h most likely via linux/hardirq.h, but that's not very obvious. Anyway: Acked-by: Heiko Carstens

Re: [PATCH 3/5] s390/vtime: remove unused __ARCH_HAS_VTIME_TASK_SWITCH leftover

2024-01-29 Thread Heiko Carstens
On Sun, Jan 28, 2024 at 08:58:52PM +0100, Alexander Gordeev wrote: > __ARCH_HAS_VTIME_TASK_SWITCH macro is not used anymore. > > Signed-off-by: Alexander Gordeev > --- > arch/s390/include/asm/vtime.h | 2 -- > 1 file changed, 2 deletions(-) Acked-by: Heiko Carstens

Re: [PATCH 4/4] ptdump: add check_wx_pages debugfs attribute

2024-01-09 Thread Heiko Carstens
On Tue, Jan 09, 2024 at 01:14:38PM +0100, Christophe Leroy wrote: > Add a writable attribute in debugfs to trigger a > W^X pages check at any time. > > To trigger the test, just echo any numeric value into > /sys/kernel/debug/check_wx_pages > > The result is provided into dmesg. > > Signed-off-b

Re: [linux-next:master] BUILD REGRESSION 2dac75696c6da3c848daa118a729827541c89d33

2023-10-19 Thread Heiko Carstens
On Thu, Oct 19, 2023 at 04:07:35AM +0800, kernel test robot wrote: > arch/s390/include/asm/ctlreg.h:129:9: warning: array subscript 0 is outside > array bounds of 'struct ctlreg[0]' [-Warray-bounds=] > arch/s390/include/asm/ctlreg.h:80:9: warning: array subscript 0 is outside > array bounds of 's

Re: [PATCH mm-unstable v9 14/31] s390: Convert various pgalloc functions to use ptdescs

2023-10-12 Thread Heiko Carstens
On Mon, Aug 07, 2023 at 04:04:56PM -0700, Vishal Moola (Oracle) wrote: > As part of the conversions to replace pgtable constructor/destructors with > ptdesc equivalents, convert various page table functions to use ptdescs. > > Some of the functions use the *get*page*() helper functions. Convert >

Re: [PATCH 1/8] S390: Remove sentinel elem from ctl_table arrays

2023-09-07 Thread Heiko Carstens
rch/s390/kernel/topology.c| 3 +-- > arch/s390/mm/cmm.c | 3 +-- > arch/s390/mm/pgalloc.c | 3 +-- > 5 files changed, 6 insertions(+), 12 deletions(-) Acked-by: Heiko Carstens

Re: [PATCH rfc v2 04/10] s390: mm: use try_vma_locked_page_fault()

2023-08-24 Thread Heiko Carstens
On Thu, Aug 24, 2023 at 10:16:33AM +0200, Alexander Gordeev wrote: > On Mon, Aug 21, 2023 at 08:30:50PM +0800, Kefeng Wang wrote: > > Use new try_vma_locked_page_fault() helper to simplify code. > > No functional change intended. > > > > Signed-off-by: Kefeng Wang > > --- > > arch/s390/mm/fault.

Re: [RFC][PATCH] sched: Rename DIE domain

2023-07-14 Thread Heiko Carstens
d* be relying on this, but who knows. > > Signed-off-by: Peter Zijlstra (Intel) > --- > arch/powerpc/kernel/smp.c | 2 +- > arch/s390/kernel/topology.c | 2 +- > arch/x86/kernel/smpboot.c | 2 +- > kernel/sched/topology.c | 2 +- > 4 files changed, 4 insertions(+), 4 deletions(-) For s390: Acked-by: Heiko Carstens

Re: [PATCH] cachestat: wire up cachestat for other architectures

2023-05-11 Thread Heiko Carstens
for all the other architectures. > > Signed-off-by: Nhat Pham > --- ... > arch/s390/kernel/syscalls/syscall.tbl | 1 + Acked-by: Heiko Carstens (s390)

Re: [PATCH v3 00/24] Remove COMMAND_LINE_SIZE from uapi

2023-02-14 Thread Heiko Carstens
On Tue, Feb 14, 2023 at 09:58:17AM +0100, Geert Uytterhoeven wrote: > Hi Heiko, > > On Tue, Feb 14, 2023 at 9:39 AM Heiko Carstens wrote: > > On Tue, Feb 14, 2023 at 08:49:01AM +0100, Alexandre Ghiti wrote: > > > This all came up in the context of increasing COMMAND_LINE_

Re: [PATCH v3 00/24] Remove COMMAND_LINE_SIZE from uapi

2023-02-14 Thread Heiko Carstens
On Tue, Feb 14, 2023 at 08:49:01AM +0100, Alexandre Ghiti wrote: > This all came up in the context of increasing COMMAND_LINE_SIZE in the > RISC-V port. In theory that's a UABI break, as COMMAND_LINE_SIZE is the > maximum length of /proc/cmdline and userspace could staticly rely on > that to be co

Re: [PATCH v3 24/24] s390: Remove empty

2023-02-14 Thread Heiko Carstens
4 arch/s390/include/uapi/asm/setup.h Acked-by: Heiko Carstens

Re: [PATCH 00/14] Remove clang's -Qunused-arguments from KBUILD_CPPFLAGS

2023-01-05 Thread Heiko Carstens
ry '-c' flags ... > arch/s390/kernel/vdso64/Makefile| 4 +-- > arch/s390/purgatory/Makefile| 2 +- For the s390 bits: Acked-by: Heiko Carstens

Re: [PATCH] mm: remove zap_page_range and create zap_vma_pages

2023-01-04 Thread Heiko Carstens
| 7 -- > mm/memory.c | 30 - > mm/page-writeback.c | 2 +- > net/ipv4/tcp.c | 7 +++--- > 13 files changed, 21 insertions(+), 58 deletions(-) For s390: Acked-by: Heiko Carstens

Re: [PATCH v3] arch: rename all internal names __xchg to __arch_xchg

2023-01-03 Thread Heiko Carstens
On Fri, Dec 30, 2022 at 03:15:52PM +0100, Andrzej Hajda wrote: > __xchg will be used for non-atomic xchg macro. > > Signed-off-by: Andrzej Hajda > Reviewed-by: Arnd Bergmann > --- > v2: squashed all arch patches into one > v3: fixed alpha/xchg_local, thx to l...@intel.com > --- ... > arch/s390/

Re: [PATCH] mm: remove kern_addr_valid() completely

2022-10-18 Thread Heiko Carstens
dress, so no need kern_addr_valid(), > let's remove unneeded kern_addr_valid() completely. > > Signed-off-by: Kefeng Wang > --- ... > arch/s390/include/asm/pgtable.h | 2 - For s390: Acked-by: Heiko Carstens

Re: [PATCH v6 5/7] treewide: use get_random_u32() when possible

2022-10-11 Thread Heiko Carstens
gensen # for sch_cake > Acked-by: Chuck Lever # for nfsd > Reviewed-by: Jan Kara # for ext4 > Acked-by: Mika Westerberg # for thunderbolt > Acked-by: Darrick J. Wong # for xfs > Signed-off-by: Jason A. Donenfeld > --- > arch/s390/mm/mmap.c | 2 +- For s390: Acked-by: Heiko Carstens

Re: [PATCH v6 4/7] treewide: use get_random_{u8,u16}() when possible, part 2

2022-10-11 Thread Heiko Carstens
ess.c | 2 +- For s390: Acked-by: Heiko Carstens

Re: [PATCH v6 1/7] treewide: use prandom_u32_max() when possible, part 1

2022-10-11 Thread Heiko Carstens
k J. Wong # for xfs > Signed-off-by: Jason A. Donenfeld > --- > arch/s390/kernel/process.c| 2 +- > arch/s390/kernel/vdso.c | 2 +- For s390: Acked-by: Heiko Carstens

Re: [PATCH v3] random: handle archrandom with multiple longs

2022-07-22 Thread Heiko Carstens
-time > platforms, while performance is greatly improved on platforms such as > s390. > > Cc: Will Deacon > Cc: Alexander Gordeev > Cc: Thomas Gleixner > Cc: H. Peter Anvin > Cc: Catalin Marinas > Cc: Borislav Petkov > Cc: Heiko Carstens > Cc: Johanne

Re: [PATCH v2] random: remove CONFIG_ARCH_RANDOM

2022-07-06 Thread Heiko Carstens
. It leaves "nordrand" for now, as the removal of that will take a > different route. > > Cc: Catalin Marinas > Cc: Will Deacon > Cc: Michael Ellerman > Cc: Heiko Carstens > Cc: Alexander Gordeev > Cc: Thomas Gleixner > Cc: H. Peter Anvin > Cc: Greg K

Re: [PATCH v5] mm: Avoid unnecessary page fault retires on shared memory types

2022-05-31 Thread Heiko Carstens
(unlikely(fault & VM_FAULT_ERROR)) > goto out_up; > > @@ -452,6 +463,7 @@ static inline vm_fault_t do_exception(struct pt_regs > *regs, int access) > mmap_read_lock(mm); > goto retry; > } > +out_gmap: > if (IS_ENABLED(CONFIG_PGSTE) && gmap) { > address = __gmap_link(gmap, current->thread.gmap_addr, > address); FWIW: Acked-by: Heiko Carstens

Re: [PATCH v4] mm: Avoid unnecessary page fault retires on shared memory types

2022-05-30 Thread Heiko Carstens
r...@linux.ibm.com>, linux-par...@vger.kernel.org, Max Filippov , linux-ker...@vger.kernel.org, Johannes Berg , Dinh Nguyen , linux-ri...@lists.infradead.org, Palmer Dabbelt , Sven Schnelle , linux-al...@vger.kernel.org, Ivan Kokshaysky , Andrew Morton , Thomas Bogendoerfer , linuxppc-dev@lis

Re: [PATCH v4] mm: Avoid unnecessary page fault retires on shared memory types

2022-05-30 Thread Heiko Carstens
on...@monstr.eu>, Thomas Bogendoerfer , linux-par...@vger.kernel.org, Max Filippov , linux-ker...@vger.kernel.org, Johannes Berg , Dinh Nguyen , linux-ri...@lists.infradead.org, Palmer Dabbelt , Sven Schnelle , linux-al...@vger.kernel.org, Ivan Kokshaysky , Andrew Morton , linuxppc-dev@lists.

Re: [PATCH v3] mm: Avoid unnecessary page fault retires on shared memory types

2022-05-27 Thread Heiko Carstens
e.net>, Chris Zankel , Michal Simek , Thomas Bogendoerfer , linux-par...@vger.kernel.org, Max Filippov , linux-ker...@vger.kernel.org, Dinh Nguyen , Palmer Dabbelt , Sven Schnelle , Guo Ren , Borislav Petkov , Johannes Berg , linuxppc-dev@lists.ozlabs.org, "David S . Miller" Errors-To: linux

Re: [PATCH 1/2] locking/lockref: Use try_cmpxchg64 in CMPXCHG_LOOP macro

2022-05-27 Thread Heiko Carstens
On Thu, May 26, 2022 at 01:42:35PM +0100, Mark Rutland wrote: > On Thu, May 26, 2022 at 10:14:59PM +1000, Michael Ellerman wrote: > > Linus Torvalds writes: > > > On Wed, May 25, 2022 at 7:40 AM Uros Bizjak wrote: > > >> > > >> Use try_cmpxchg64 instead of cmpxchg64 in CMPXCHG_LOOP macro. > > >>

Re: [PATCH 22/30] panic: Introduce the panic post-reboot notifier list

2022-05-11 Thread Heiko Carstens
r effectively stopping the machine (s390). > > > > This patch introduces yet another notifier list to offer the > > architectures a way to add callbacks in such late moment on > > panic path without the need of ifdefs / hardcoded approaches. > > > > Cc: Alexand

Re: [PATCH 13/30] s390/consoles: Improve panic notifiers reliability

2022-04-29 Thread Heiko Carstens
wn body, and changed the > priority of such notifiers to execute late, since they are "heavyweight" > for the panic environment, so we aim to reduce risks here. > Changed return values to NOTIFY_DONE as well, the standard one. > > Cc: Alexander Gordeev > Cc: Christian B

Re: [PATCH v2 09/13] powerpc/ftrace: Implement CONFIG_DYNAMIC_FTRACE_WITH_ARGS

2022-02-16 Thread Heiko Carstens
On Tue, Feb 15, 2022 at 09:55:52PM +0530, Naveen N. Rao wrote: > > > > > > > I think this is wrong. We need to differentiate > > > > > > > between ftrace_caller() and ftrace_regs_caller() > > > > > > > here, and only return pt_regs if coming in through > > > > > > > ftrace_regs_caller() (i.e., FL_S

Re: [PATCH V3 5/8] sched: s390: Remove unused TASK_SIZE_OF

2021-12-28 Thread Heiko Carstens
On Tue, Dec 28, 2021 at 02:47:26PM +0800, guo...@kernel.org wrote: > From: Guo Ren > > This macro isn't used in Linux sched, now. Delete in > include/linux/sched.h and arch's include/asm. > > Signed-off-by: Guo Ren > Signed-off-by: Guo Ren > Reviewed-by: Arnd Bergmann > --- > arch/s390/inclu

Re: [PATCH V2 5/8] sched: s390: Remove unused TASK_SIZE_OF

2021-12-25 Thread Heiko Carstens
On Sat, Dec 25, 2021 at 12:54:27PM +0800, guo...@kernel.org wrote: > From: Guo Ren > > This macro isn't used in Linux sched, now. Delete in > include/linux/sched.h and arch's include/asm. > > Signed-off-by: Guo Ren > Reviewed-by: Arnd Bergmann > --- > arch/s390/include/asm/processor.h | 3 +--

Re: [PATCH v1 0/5] Implement livepatch on PPC32

2021-12-14 Thread Heiko Carstens
On Mon, Dec 13, 2021 at 05:50:52PM +, Christophe Leroy wrote: > Le 13/12/2021 à 18:33, Steven Rostedt a écrit : > > On Mon, 13 Dec 2021 17:30:48 + > > Christophe Leroy wrote: > > > >> Thanks, I will try that. > >> > >> I can't find ftrace_graph_func() in s390. Does it mean that s390 doesn

Re: [PATCH v2 0/6] KEXEC_SIG with appended signature

2021-11-30 Thread Heiko Carstens
l.h | 2 - > kernel/module.c | 12 +++-- > kernel/module_signature.c| 56 +++- > kernel/module_signing.c | 33 +++--- > security/integrity/ima/ima_modsig.c | 22 ++ > 11 files changed, 113 insertions(+), 85 deletions(-) For all patches which touch s390: Acked-by: Heiko Carstens

Re: [PATCH v2 4/4] s390: Use generic version of arch_is_kernel_initmem_freed()

2021-09-28 Thread Heiko Carstens
; --- > arch/s390/include/asm/sections.h | 12 > arch/s390/mm/init.c | 3 --- > 2 files changed, 15 deletions(-) Looks good. Thanks for cleaning this up! Acked-by: Heiko Carstens

Re: [PATCH] ftrace: Cleanup ftrace_dyn_arch_init()

2021-09-03 Thread Heiko Carstens
h/x86/kernel/ftrace.c | 5 - > include/linux/ftrace.h| 1 - > kernel/trace/ftrace.c | 5 + > 16 files changed, 11 insertions(+), 62 deletions(-) For s390: Acked-by: Heiko Carstens

Re: [PATCH 2/3] trace: refactor TRACE_IRQFLAGS_SUPPORT in Kconfig

2021-07-31 Thread Heiko Carstens
- For s390: Acked-by: Heiko Carstens

Re: [PATCH v5 0/6] compat: remove compat_alloc_user_space

2021-07-30 Thread Heiko Carstens
On Tue, Jul 27, 2021 at 04:48:53PM +0200, Arnd Bergmann wrote: > From: Arnd Bergmann > > Going through compat_alloc_user_space() to convert indirect system call > arguments tends to add complexity compared to handling the native and > compat logic in the same code. > > Out of the other remaining

Re: [PATCH v5 4/6] mm: simplify compat numa syscalls

2021-07-27 Thread Heiko Carstens
On Tue, Jul 27, 2021 at 08:49:40PM +0200, Arnd Bergmann wrote: > On Tue, Jul 27, 2021 at 8:38 PM Heiko Carstens wrote: > > > > -268 commonmbind sys_mbind > > compat_sys_mbind > > -269 commonget_mempolicy

Re: [PATCH v5 4/6] mm: simplify compat numa syscalls

2021-07-27 Thread Heiko Carstens
On Tue, Jul 27, 2021 at 07:40:05PM +0200, Arnd Bergmann wrote: > On Tue, Jul 27, 2021 at 7:27 PM Heiko Carstens wrote: > > > +static int get_bitmap(unsigned long *mask, const unsigned long __user > > > *nmask, > > > + unsigned long maxnode) >

Re: [PATCH v5 4/6] mm: simplify compat numa syscalls

2021-07-27 Thread Heiko Carstens
On Tue, Jul 27, 2021 at 04:48:57PM +0200, Arnd Bergmann wrote: > --- > include/linux/compat.h | 17 ++-- > mm/mempolicy.c | 175 + > 2 files changed, 63 insertions(+), 129 deletions(-) ... > +static int get_bitmap(unsigned long *mask, const unsigned

Re: [PATCH v1 04/12] mm/memory_hotplug: remove nid parameter from arch_remove_memory()

2021-06-08 Thread Heiko Carstens
| 5 + > 10 files changed, 11 insertions(+), 22 deletions(-) For s390: Acked-by: Heiko Carstens

Re: consolidate the flock uapi definitions

2021-04-15 Thread Heiko Carstens
-- > 11 files changed, 54 insertions(+), 192 deletions(-) for the s390 bits: Acked-by: Heiko Carstens

Re: [PATCH 0/6] mm: some config cleanups

2021-03-09 Thread Heiko Carstens
| 5 - > mm/Kconfig | 9 > 15 files changed, 48 insertions(+), 122 deletions(-) for the s390 bits: Acked-by: Heiko Carstens

Re: [PATCH AUTOSEL 5.9 27/39] sched/idle: Fix arch_cpu_idle() vs tracing

2020-12-03 Thread Heiko Carstens
On Thu, Dec 03, 2020 at 08:28:21AM -0500, Sasha Levin wrote: > From: Peter Zijlstra > > [ Upstream commit 58c644ba512cfbc2e39b758dd979edd1d6d00e27 ] > > We call arch_cpu_idle() with RCU disabled, but then use > local_irq_{en,dis}able(), which invokes tracing, which relies on RCU. > > Switch all

Re: [PATCH seccomp 5/8] s390: Enable seccomp architecture tracking

2020-11-09 Thread Heiko Carstens
ine SECCOMP_ARCH_COMPAT AUDIT_ARCH_S390 > +# define SECCOMP_ARCH_COMPAT_NR NR_syscalls > +# define SECCOMP_ARCH_COMPAT_NAME"s390" > +#endif > + Acked-by: Heiko Carstens

Re: [PATCH] ima: add a new CONFIG for loading arch-specific policies

2020-03-02 Thread Heiko Carstens
On Mon, Mar 02, 2020 at 09:56:58AM -0500, Mimi Zohar wrote: > On Mon, 2020-03-02 at 15:52 +0100, Ard Biesheuvel wrote: > > On Mon, 2 Mar 2020 at 15:48, Mimi Zohar wrote: > > > > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig > > > > index beea77046f9b..cafa66313fe2 100644 > > > > --- a/arch/x86/

Re: [PATCH v3 02/22] compat: provide compat_ptr() on all architectures

2020-01-07 Thread Heiko Carstens
> include/linux/compat.h| 18 ++ > 9 files changed, 20 insertions(+), 109 deletions(-) For s390: Acked-by: Heiko Carstens

Re: [PATCH v2 00/29] vmlinux.lds.h: Refactor EXCEPTION_TABLE and NOTES

2019-10-16 Thread Heiko Carstens
explode rather > badly. :) Feel free to add Acked-by: Heiko Carstens to every patch in this series which touches s390.

Re: [PATCH v2 06/29] s390: Move RO_DATA into "text" PT_LOAD Program Header

2019-10-16 Thread Heiko Carstens
64,7 @@ SECTIONS > .data..ro_after_init : { >*(.data..ro_after_init) > JUMP_TABLE_DATA > - } > + } :data > EXCEPTION_TABLE(16) > . = ALIGN(PAGE_SIZE); > __end_ro_after_init = .; Acked-by: Heiko Carstens

Re: [PATCH 2/2] arch: add pidfd and io_uring syscalls everywhere

2019-03-30 Thread Heiko Carstens
common io_uring_register sys_io_uring_register I was just about to write that io_uring_enter is missing compat handling, but your first patch actually fixes that. Would have been good to be cc'ed on both patches :) For s390: Acked-by: Heiko Carstens

Re: CONFIG_ARCH_SUPPORTS_INT128: Why not mips, s390, powerpc, and alpha?

2019-03-30 Thread Heiko Carstens
On Fri, Mar 29, 2019 at 01:07:07PM +, George Spelvin wrote: > (Cross-posted in case there are generic issues; please trim if > discussion wanders into single-architecture details.) > > I was working on some scaling code that can benefit from 64x64->128-bit > multiplies. GCC supports an __int1

Re: [PATCH] compiler: allow all arches to enable CONFIG_OPTIMIZE_INLINING

2019-03-21 Thread Heiko Carstens
On Wed, Mar 20, 2019 at 03:20:27PM +0900, Masahiro Yamada wrote: > Commit 60a3cdd06394 ("x86: add optimized inlining") introduced > CONFIG_OPTIMIZE_INLINING, but it has been available only for x86. > > The idea is obviously arch-agnostic although we need some code fixups. > This commit moves the c

Re: [PATCH v2 29/29] y2038: add 64-bit time_t syscalls to all 32-bit architectures

2019-01-21 Thread Heiko Carstens
they > pass only counts elapsed time, not time since the epoch. They > will be dealt with later. > > Signed-off-by: Arnd Bergmann > --- > arch/s390/kernel/syscalls/syscall.tbl | 20 + For the s390 bits: Acked-by: Heiko Carstens

Re: [PATCH v2 28/29] y2038: rename old time and utime syscalls

2019-01-21 Thread Heiko Carstens
> we need __ARCH_WANT_SYS_TIME32/UTIME32 for 32-bit architectures and compat > mode. The resulting asm/unistd.h changes look a bit counterintuitive. > > This is only a cleanup patch and it should not change any behavior. > > Signed-off-by: Arnd Bergmann ... > arch/s390/include/asm/unistd.h | 2 +- For the s390 bits: Acked-by: Heiko Carstens

Re: [PATCH v2 17/29] syscalls: remove obsolete __IGNORE_ macros

2019-01-21 Thread Heiko Carstens
/include/asm/unistd.h | 16 > arch/parisc/include/asm/unistd.h | 3 --- > arch/s390/include/asm/unistd.h | 2 -- > arch/xtensa/include/asm/unistd.h | 12 > 4 files changed, 33 deletions(-) For the s390 bits: Acked-by: Heiko Carstens

Re: [PATCH v2 14/29] arch: add pkey and rseq syscall numbers everywhere

2019-01-21 Thread Heiko Carstens
nel/syscalls/syscall.tbl | 3 +++ > arch/sh/kernel/syscalls/syscall.tbl | 4 > arch/sparc/include/asm/unistd.h | 5 - > arch/sparc/kernel/syscalls/syscall.tbl | 4 > arch/xtensa/kernel/syscalls/syscall.tbl | 1 + > 12 files changed, 28 insertions(+), 15 deletions(-) For the s390 bits: Acked-by: Heiko Carstens

Re: [PATCH v2 13/29] arch: add split IPC system calls where needed

2019-01-21 Thread Heiko Carstens
+++ > arch/powerpc/kernel/syscalls/syscall.tbl | 13 + > arch/s390/kernel/syscalls/syscall.tbl | 12 > arch/sh/kernel/syscalls/syscall.tbl | 11 +++ > arch/sparc/kernel/syscalls/syscall.tbl| 12 > arch/x86/entry/syscalls/syscall_32.tbl| 11 +++ > 7 files changed, 81 insertions(+) For the s390 bits: Acked-by: Heiko Carstens

Re: [PATCH 19/21] treewide: add checks for the return value of memblock_alloc*()

2019-01-18 Thread Heiko Carstens
remove this hunk, since the code _should_ be able to handle allocation failures anyway (see end of quoted code). Otherwise for the s390 bits: Acked-by: Heiko Carstens

Re: [PATCH 15/15] arch: add pkey and rseq syscall numbers everywhere

2019-01-14 Thread Heiko Carstens
On Fri, Jan 11, 2019 at 06:30:43PM +0100, Arnd Bergmann wrote: > On Thu, Jan 10, 2019 at 9:36 PM Heiko Carstens > wrote: > > On Thu, Jan 10, 2019 at 05:24:35PM +0100, Arnd Bergmann wrote: > > > Since you only need/want the system call numbers, could you please >

Re: [PATCH 07/11] y2038: syscalls: rename y2038 compat syscalls

2019-01-10 Thread Heiko Carstens
On Thu, Jan 10, 2019 at 06:22:12PM +0100, Arnd Bergmann wrote: > diff --git a/arch/s390/kernel/syscalls/syscall.tbl > b/arch/s390/kernel/syscalls/syscall.tbl > index f84ea364a302..b3199a744731 100644 > --- a/arch/s390/kernel/syscalls/syscall.tbl > +++ b/arch/s390/kernel/syscalls/syscall.tbl > @@ -

Re: [PATCH 15/15] arch: add pkey and rseq syscall numbers everywhere

2019-01-10 Thread Heiko Carstens
On Thu, Jan 10, 2019 at 05:24:35PM +0100, Arnd Bergmann wrote: > Most architectures define system call numbers for the rseq and pkey system > calls, even when they don't support the features, and perhaps never will. > > Only a few architectures are missing these, so just define them anyway > for c

Re: [PATCH 14/15] arch: add split IPC system calls where needed

2019-01-10 Thread Heiko Carstens
On Thu, Jan 10, 2019 at 05:24:34PM +0100, Arnd Bergmann wrote: > The IPC system call handling is highly inconsistent across architectures, > some use sys_ipc, some use separate calls, and some use both. We also > have some architectures that require passing IPC_64 in the flags, and > others that s

Re: [PATCH RFC 1/2] drivers/base: export lock_device_hotplug/unlock_device_hotplug

2018-08-17 Thread Heiko Carstens
On Fri, Aug 17, 2018 at 01:04:58PM +0200, David Hildenbrand wrote: > >> If there are no objections, I'll go into that direction. But I'll wait > >> for more comments regarding the general concept first. > > > > It is the middle of the merge window, and maintainers are really busy > > right now. I

Re: [PATCH v3 04/17] y2038: s390: Remove unneeded ipc uapi header files

2018-04-20 Thread Heiko Carstens
44 arch/s390/include/uapi/asm/msgbuf.h > delete mode 100644 arch/s390/include/uapi/asm/sembuf.h > delete mode 100644 arch/s390/include/uapi/asm/shmbuf.h FWIW, Acked-by: Heiko Carstens

Re: [PATCH v1] mm: relax deferred struct page requirements

2017-11-16 Thread Heiko Carstens
with CONFIG_MEMORY_HOTPLUG disabled. > > Signed-off-by: Pavel Tatashin > --- > arch/powerpc/Kconfig | 1 - > arch/s390/Kconfig| 1 - > arch/x86/Kconfig | 1 - > mm/Kconfig | 7 +-- > 4 files changed, 1 insertion(+), 9 deletions(-) For s390 the s390 bit: Acked-by: Heiko Carstens

Re: [v3 9/9] s390: teach platforms not to zero struct pages memory

2017-05-15 Thread Heiko Carstens
his table is allocated zeroed, but now it won't > be zeroed. The page table, if needed, is allocated and populated a couple of lines above. See the vmem_pte_alloc() call. So my request to include the hunk below is still valid ;) > >If you add the hunk below then this is > > > &

Re: [v3 9/9] s390: teach platforms not to zero struct pages memory

2017-05-08 Thread Heiko Carstens
true); > +VMEMMAP_ZERO); > if (!new_page) > goto out; > pmd_val(*pm_dir) = __pa(new_page) | sgt_prot; If you add the h

Re: [v2 5/5] mm: teach platforms not to zero struct pages memory

2017-03-26 Thread Heiko Carstens
On Fri, Mar 24, 2017 at 03:19:52PM -0400, Pavel Tatashin wrote: > If we are using deferred struct page initialization feature, most of > "struct page"es are getting initialized after other CPUs are started, and > hence we are benefiting from doing this job in parallel. However, we are > still zeroi

Re: [v1 0/5] parallelized "struct page" zeroing

2017-03-24 Thread Heiko Carstens
On Fri, Mar 24, 2017 at 09:51:09AM +0100, Christian Borntraeger wrote: > On 03/24/2017 12:01 AM, Pavel Tatashin wrote: > > When deferred struct page initialization feature is enabled, we get a > > performance gain of initializing vmemmap in parallel after other CPUs are > > started. However, we sti

Re: [PATCH 1/3] futex: remove duplicated code

2017-03-03 Thread Heiko Carstens
++ Looks good to me and still boots on s390. Therefore for the s390 bits: Acked-by: Heiko Carstens Thanks!

Re: [RFC 1/4] mm: remove unused TASK_SIZE_OF()

2017-01-01 Thread Heiko Carstens
(1UL << 53) > > #define STACK_TOP(1UL << (test_thread_flag(TIF_31BIT) ? 31:42)) FWIW, for the s390 part: Acked-by: Heiko Carstens

Re: [PATCH 1/3] kernel/sched: introduce vcpu preempted check interface

2016-06-28 Thread Heiko Carstens
On Mon, Jun 27, 2016 at 04:00:43PM +0200, Peter Zijlstra wrote: > On Mon, Jun 27, 2016 at 01:41:28PM -0400, Pan Xinhui wrote: > > +++ b/include/linux/sched.h > > @@ -3293,6 +3293,15 @@ static inline void set_task_cpu(struct task_struct > > *p, unsigned int cpu) > > > > #endif /* CONFIG_SMP */ >

  1   2   >