RE: [PATCH net] net: enetc: add missing static descriptor and inline keyword

tatic > 8 warnings generated. > > Fixes: 6517798dd343 ("enetc: Make MDIO accessors more generic and export > to include/linux/fsl") Reviewed-by: Claudiu Manoil

[PATCH net-next 2/2] powerpc: dts: fsl: Drop obsolete fsl, rx-bit-map and fsl, tx-bit-map properties

These are very old properties that were used by the "gianfar" ethernet driver. They don't have documented bindings and are obsolete. Signed-off-by: Claudiu Manoil --- arch/powerpc/boot/dts/fsl/bsc9131si-post.dtsi | 4 arch/powerpc/boot/dts/fsl/bsc9132si-post.dtsi | 4 ---

[PATCH net-next 1/2] gianfar: Drop GFAR_MQ_POLLING support

ust dead code, and no one asked for it so far. For the Tx queues, multi-queue support (more than 1 Tx queue per CPU) could be revisited by adding tc MQPRIO support, but again, one has to consider that there are only 2 interrupt lines. So the NAPI poll routine would have to service multiple Tx rings

[PATCH net-next 0/2] net: gianfar: Drop GFAR_MQ_POLLING support

Drop long time obsolete "per NAPI multi-queue" support in gianfar, and related (and undocumented) device tree properties. Claudiu Manoil (2): gianfar: Drop GFAR_MQ_POLLING support powerpc: dts: fsl: Drop obsolete fsl,rx-bit-map and fsl,tx-bit-map properties arch/powerpc/bo

[PATCH 16/17] soc/qman: Clean up CGR CSCN target update operations

Signed-off-by: Claudiu Manoil --- drivers/soc/fsl/qbman/qman.c | 37 +++-- include/soc/fsl/qman.h | 4 ++-- 2 files changed, 25 insertions(+), 16 deletions(-) diff --git a/drivers/soc/fsl/qbman/qman.c b/drivers/soc/fsl/qbman/qman.c index ac020fd..d287ef0

[PATCH 17/17] soc/qman: Handle endianness of h/w descriptors

The hardware descriptors have big endian (BE) format. Provide proper endianness handling for the remaining descriptor fields, to ensure they are correctly accessed by non-BE CPUs too. Signed-off-by: Claudiu Manoil --- drivers/soc/fsl/qbman/qman.c| 65

[PATCH 15/17] soc/qman: Change remaining contextB into context_b

There are multiple occurences of both contextB and context_b in different h/w descriptors, referring to the same descriptor field known as "Context B". Stick with the "context_b" naming, for obvious reasons including consistency (see also context_a). Signed-off-by: Claudiu

[PATCH 14/17] soc/qbman: Handle endianness of qm/bm_in/out()

Signed-off-by: Claudiu Manoil --- drivers/soc/fsl/qbman/bman.c | 6 +++--- drivers/soc/fsl/qbman/qman.c | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/soc/fsl/qbman/bman.c b/drivers/soc/fsl/qbman/bman.c index ffa48fd..345e50c 100644 --- a/drivers/soc/fsl/qbman

[PATCH 06/17] soc/qman: Fix direct access to fd's addr_lo, use proper accesor

Use the proper accessor to get the FD address. Accessing the internal field "addr_lo" directly is not portable and error prone. Signed-off-by: Claudiu Manoil --- drivers/soc/fsl/qbman/qman.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/soc/fsl/qbma

[PATCH 08/17] soc/qman: Don't add a new platform device for dma mapping

: Claudiu Manoil --- drivers/soc/fsl/qbman/qman.c| 31 ++- drivers/soc/fsl/qbman/qman_portal.c | 11 +++ drivers/soc/fsl/qbman/qman_priv.h | 1 + 3 files changed, 22 insertions(+), 21 deletions(-) diff --git a/drivers/soc/fsl/qbman/qman.c b/drivers/soc/fsl

[PATCH 13/17] soc/qman: Drop unused field from eqcr/dqrr descriptors

ORP ("Order Restoration Point") mechanism not supported. Signed-off-by: Claudiu Manoil --- drivers/soc/fsl/qbman/qman.c | 3 +-- include/soc/fsl/qman.h | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/soc/fsl/qbman/qman.c b/drivers/soc/fsl/qbman/qm

[PATCH 12/17] soc/qman: Fix accesses to fqid, cleanup

Preventively mask every access to the 'fqid' h/w field, since it is defined as a 24-bit field, for every h/w descriptor. Add generic accessors for this field to ensure correct access. Signed-off-by: Claudiu Manoil --- drivers/soc/fsl/qbman/qman.c | 32 ---

[PATCH 11/17] soc/qman: Remove unused struct qm_mcc* layouts

easoning above and for consistent naming. Signed-off-by: Claudiu Manoil --- drivers/soc/fsl/qbman/qman.c | 58 --- drivers/soc/fsl/qbman/qman_priv.h | 6 2 files changed, 18 insertions(+), 46 deletions(-) diff --git a/drivers/soc/fsl/qbman/qma

[PATCH 10/17] soc/qman: Remove redundant checks from qman_create_cgr()

opts is checked redundantly. Move local_opts declaration inside its usage scope. Signed-off-by: Claudiu Manoil --- drivers/soc/fsl/qbman/qman.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/soc/fsl/qbman/qman.c b/drivers/soc/fsl/qbman/qman.c index 283c2d3

[PATCH 09/17] soc/qman: test: Don't use dummy platform device for dma mapping

Replace dummy platform device hack with a reference to a portal's platform device, in order to dma map the test frame for this small unit test. The 2 qman symbols need to be exported because this self test is a kernel module. Signed-off-by: Claudiu Manoil --- drivers/soc/fsl/qbman/q

[PATCH 04/17] soc/qbman: Fix resource leak on portal probing error path

In case init_pcfg() returns with error the CI region must be unmapped too. Signed-off-by: Claudiu Manoil --- drivers/soc/fsl/qbman/bman_portal.c | 17 - drivers/soc/fsl/qbman/qman_portal.c | 17 - 2 files changed, 24 insertions(+), 10 deletions(-) diff --git a

[PATCH 07/17] soc/qman: test: Fix implementation of fd_cmp()

This function must only return the truth value of whether two frame descriptors are different or not. It does NOT have to compute some obscure difference between fd fields and return it as an int, making sparse complain about type conversions in the process. Signed-off-by: Claudiu Manoil

[PATCH 05/17] soc/qman: Fix struct qm_fqd set accessor for context_a

context_a.hi is 32bit Signed-off-by: Claudiu Manoil --- include/soc/fsl/qman.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/soc/fsl/qman.h b/include/soc/fsl/qman.h index 37f3eb0..1405810 100644 --- a/include/soc/fsl/qman.h +++ b/include/soc/fsl/qman.h @@ -411,7

[PATCH 03/17] soc/qman: Fix h/w resource cleanup error path handling

oded fqid value with corresponding define). Signed-off-by: Claudiu Manoil --- drivers/soc/fsl/qbman/qman.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/drivers/soc/fsl/qbman/qman.c b/drivers/soc/fsl/qbman/qman.c index 119054b..80ff0b7 100644 --- a/drivers

[PATCH 02/17] soc/qman: Replace of_get_property() with portable equivalent

From: Madalin Bucur Use arch portable of_property_read_u32() instead, which takes care of endianness conversions. Signed-off-by: Madalin Bucur Signed-off-by: Claudiu Manoil --- drivers/soc/fsl/qbman/dpaa_sys.h| 1 + drivers/soc/fsl/qbman/qman_portal.c | 12 ++-- 2 files changed

[PATCH 01/17] soc/qman: Check ioremap return value

From: Madalin Bucur Signed-off-by: Madalin Bucur Signed-off-by: Claudiu Manoil --- drivers/soc/fsl/qbman/qman_ccsr.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/soc/fsl/qbman/qman_ccsr.c b/drivers/soc/fsl/qbman/qman_ccsr.c index 0cace9e..f4e6e70 100644 --- a/drivers/soc

[PATCH 00/17] soc/qman: Fixes, endianness handling and related cleanup

* endianness fixes to ensure correct handling on little endian CPUs, as the qman h/w is big endian; * removal of a platform device hack that may fail, used for dma mapping; * various fixes and code cleanup; Claudiu Manoil (15): soc/qman: Fix h/w resource cleanup error path handling soc

[PATCH v2 3/5] soc/bman: Add self-test for BMan driver

Add a self test for the DPAA 1.x Buffer Manager driver. This test ensures that the driver can properly acquire and release buffers using the BMan portal infrastructure. Signed-off-by: Roy Pledge Signed-off-by: Claudiu Manoil --- v2: none drivers/soc/fsl/qbman/Kconfig | 16

[PATCH v2 5/5] arch/powerpc: Add CONFIG_FSL_DPAA to corenetXX_smp_defconfig

Enable the drivers on the powerpc arch. Signed-off-by: Roy Pledge Signed-off-by: Claudiu Manoil --- v2: none arch/powerpc/Makefile| 4 ++-- arch/powerpc/configs/dpaa.config | 1 + drivers/soc/Kconfig | 1 + drivers/soc/fsl/Makefile | 1 + 4 files changed, 5

[PATCH v2 4/5] soc/qman: Add self-test for QMan driver

Add self tests for the DPAA 1.x Queue Manager driver. The tests ensure that the driver can properly enqueue and dequeue to/from frame queues using the QMan portal infrastructure. Signed-off-by: Roy Pledge Signed-off-by: Claudiu Manoil --- v2: none drivers/soc/fsl/qbman/Kconfig | 23

[PATCH v2 1/5] soc/fsl: Introduce DPAA 1.x BMan device driver

This driver enables the Freescale DPAA 1.x Buffer Manager block. BMan is a hardware accelerator that manages buffer pools. It allows CPUs and other accelerators connected to the SoC datapath to acquire and release buffers during data processing. Signed-off-by: Roy Pledge Signed-off-by: Claudiu

[PATCH v2 0/5] Freescale DPAA 1.x QBMan Drivers

Add basic support for the Data Path Acceleration Architecture v1.x (DPAA 1.x) hardware infrastructure and accelerators found on multicore Freescale SoCs, commonly known as the QorIQ series. CC: Roy Pledge Claudiu Manoil (5): soc/fsl: Introduce DPAA 1.x BMan device driver soc/fsl: Introduce

[PATCH 5/5] arch/powerpc: Add CONFIG_FSL_DPAA to corenetXX_smp_defconfig

Enable the drivers on the powerpc arch. Signed-off-by: Roy Pledge Signed-off-by: Claudiu Manoil --- arch/powerpc/Makefile| 4 ++-- arch/powerpc/configs/dpaa.config | 1 + drivers/soc/Kconfig | 1 + drivers/soc/fsl/Makefile | 1 + 4 files changed, 5 insertions

[PATCH 4/5] soc/qman: Add self-test for QMan driver

Add self tests for the DPAA 1.x Queue Manager driver. The tests ensure that the driver can properly enqueue and dequeue to/from frame queues using the QMan portal infrastructure. Signed-off-by: Roy Pledge Signed-off-by: Claudiu Manoil --- drivers/soc/fsl/qbman/Kconfig | 23

[PATCH 3/5] soc/bman: Add self-test for BMan driver

Add a self test for the DPAA 1.x Buffer Manager driver. This test ensures that the driver can properly acquire and release buffers using the BMan portal infrastructure. Signed-off-by: Roy Pledge Signed-off-by: Claudiu Manoil --- drivers/soc/fsl/qbman/Kconfig | 16 drivers/soc/fsl

[PATCH 1/5] soc/fsl: Introduce DPAA 1.x BMan device driver

This driver enables the Freescale DPAA 1.x Buffer Manager block. BMan is a hardware accelerator that manages buffer pools. It allows CPUs and other accelerators connected to the SoC datapath to acquire and release buffers during data processing. Signed-off-by: Roy Pledge Signed-off-by: Claudiu

[PATCH 0/5] Freescale DPAA 1.x QBMan Drivers

Add basic support for the Data Path Acceleration Architecture v1.x (DPAA 1.x) hardware infrastructure and accelerators found on multicore Freescale SoCs, commonly known as the QorIQ series. CC: Roy Pledge Claudiu Manoil (5): soc/fsl: Introduce DPAA 1.x BMan device driver soc/fsl: Introduce

[PATCH, RESEND, v2] powerpc/85xx: Don't report SRAM to L2 cache fallback as error

If the SRAM region parameters are missing the SRAM driver probing exits and the L2 region is configured as L2 cache entirely. This is the expected default behaviour, so it makes no sense to report it as an error. Signed-off-by: Claudiu Manoil --- v2: drop info print arch/powerpc/sysdev

[PATCH][v2] powerpc/85xx: Don't report SRAM to L2 cache fallback as error

If the SRAM region parameters are missing the SRAM driver probing exits and the L2 region is configured as L2 cache entirely. This is the expected default behaviour, so it makes no sense to report it as an error. Signed-off-by: Claudiu Manoil --- v2: drop info print on Scott's request

[PATCH] powerpc/85xx: Don't report SRAM to L2 cache fallback as error

If the SRAM region parameters are missing the SRAM driver probing exits and the L2 region is configured as L2 cache entirely. This is the expected default behaviour, so it makes no sense to report it as an error. Signed-off-by: Claudiu Manoil --- arch/powerpc/sysdev/fsl_85xx_l2ctlr.c | 5

[PATCH 3/3] gianfar: Add WAKE_UCAST and "wake-on-filer" support

The "fsl,wake-on-filer" DT binding enables this capability on certain platforms that feature the necessary power management infrastructure, targeting mainly printing and imaging applications. (refer to Power Management section of the SoC Ref Man) Cc: Li Yang Cc: Zhao Chenhui Signed-

[PATCH 2/3] powerpc: dts: p1022si: Add fsl,wake-on-filer for eTSEC

Enable the "wake-on-filer" (aka. wake on user defined packet) wake on lan capability for the eTSEC ethernet nodes. Cc: Li Yang Cc: Zhao Chenhui Signed-off-by: Claudiu Manoil --- arch/powerpc/boot/dts/fsl/p1022si-post.dtsi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ar

[PATCH 1/3] doc: dt: net: Add fsl,wake-on-filer for eTSEC

Add the "fsl,wake-on-filer" property for eTSEC nodes to indicate that the system has the power management infrastructure needed to be able to wake up the system via FGPI (filer, aka. h/w rx parser) interrupt. Cc: Li Yang Cc: Zhao Chenhui Signed-off-by: Claudiu Manoil --- Doc

Re: [PATCH] powerpc/85xx: Merge 85xx/p1023_defconfig into mpc85xx_smp_defconfig and mpc85xx_defconfig

On 11/9/2013 1:17 AM, Lijun Pan wrote: diff --git a/arch/powerpc/configs/mpc85xx_defconfig b/arch/powerpc/configs/mpc85xx_defconfig index d2e0fab..72fff6e 100644 --- a/arch/powerpc/configs/mpc85xx_defconfig +++ b/arch/powerpc/configs/mpc85xx_defconfig @@ -1,4 +1,5 @@ CONFIG_PPC_85xx=y +CONFIG_

Re: Gianfar driver crashes in Kernel v3.10

Hi Thomas, On 10/31/2013 1:51 PM, Thomas Hühn wrote: Hi Claudiu, Please try the following patch: http://patchwork.ozlabs.org/patch/283235/ It should help with your issue. Several OpenWrt users including myself have tested your patch on TPLink-4900 routers. We do have positive feedback, as

Re: Fwd: Gianfar driver crashes in Kernel v3.10

On 10/11/2013 11:59 AM, Thomas Hühn wrote: Hi Claudiu, Does this show up on a half duplex (100Mb/s) link? In my testsetup I always used 1GBit Ethernet connections, so no 100MBit tested yet. Should I do so ? Could you provide following for the gianfar interface, on your setup: sure: # et

Re: Gianfar driver crashes in Kernel v3.10

On 10/11/2013 12:41 AM, Scott Wood wrote: On Thu, 2013-10-10 at 14:07 +0300, Claudiu Manoil wrote: On 10/4/2013 3:28 PM, Thomas Hühn wrote: [code] [ 2671.841927] Oops: Exception in kernel mode, sig: 5 [#1] [ 2671.847141] Freescale P1014 [ 2671.849925] Modules linked in: ath9k pppoe

Re: Gianfar driver crashes in Kernel v3.10

On 10/4/2013 3:28 PM, Thomas Hühn wrote: [code] [ 2671.841927] Oops: Exception in kernel mode, sig: 5 [#1] [ 2671.847141] Freescale P1014 [ 2671.849925] Modules linked in: ath9k pppoe ppp_async iptable_nat ath9k_common pppox p e xt_tcpudp xt_tcpmss xt_string xt_statistic xt_state xt_recent xt_qu

[PATCH 3/3] gianfar: Enable eTSEC-20 erratum w/a for P2020 Rev1

was fixed in Rev 2.0. Signed-off-by: Claudiu Manoil --- drivers/net/ethernet/freescale/gianfar.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ethernet/freescale/gianfar.c b/drivers/net/ethernet/freescale/gianfar.c index 329a206..9fbe4dd 100644 --- a/drivers/net/ethernet

[PATCH 2/3] gianfar: Use mpc85xx support for errata detection

) == SVR_8548) && (SVR_REV(svr) == 0x20) instead of: (pvr == 0x80210020 && mod == 0x8030 && rev == 0x0020) Signed-off-by: Claudiu Manoil --- drivers/net/ethernet/freescale/gianfar.c | 33 1 file changed, 25 insertions(+), 8 deletions(-) diff --gi

[PATCH 1/3] gianfar: Enable eTSEC-A002 erratum w/a for all parts

(runt frames or even frames with RX error detected at PHY level) during controller reset, the controller might fail to indicate Rx reset (GRS) completion. Signed-off-by: Claudiu Manoil --- drivers/net/ethernet/freescale/gianfar.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff

Re: Gianfar driver crashes in Kernel v3.10

On 10/4/2013 3:03 PM, Thomas Hühn wrote: Hi all, We are several Openwrt users based on the TPlink 4900 device and suffer from a crashing gianfar driver. We troubleshooted the problem down to the fact, that a 3.8er Linux kernel is working, and a v3.10 crashes, but there is no reproducable case

Re: gianfar driver crash on P1020

Hello, Did you try this patch? http://patchwork.ozlabs.org/patch/186315/ Claudiu On 10/9/2012 3:22 PM, Avi Tsarfati wrote: Hi, I have the same problem as you do. Have you found the CPU stuck reason (or fix) in P1020RDB board ? Thanks, Avi Tsarfati. *

[PATCH][v1] powerpc/85xx: Fix sram_offset parameter type

), although this is a valid offset value. Signed-off-by: Tang Yuantian Signed-off-by: Claudiu Manoil --- v1: fixed copyright year format arch/powerpc/sysdev/fsl_85xx_cache_ctlr.h |4 +- arch/powerpc/sysdev/fsl_85xx_l2ctlr.c | 39 ++-- 2 files changed, 16 insertions

Re: [PATCH] powerpc/85xx: Fix sram_offset parameter type

On 7/19/2012 3:07 PM, Kumar Gala wrote: On Jul 19, 2012, at 5:28 AM, Claudiu Manoil wrote: The sram_offset parameter represents a physical address and should be of type phys_addr_t. As part of this fix, the extraction of sram_params is being cleaned-up and fixed. This patch fixes now the case

[PATCH] powerpc/85xx: Fix sram_offset parameter type

), although this is a valid offset value. Signed-off-by: Tang Yuantian Signed-off-by: Claudiu Manoil --- arch/powerpc/sysdev/fsl_85xx_cache_ctlr.h |4 +- arch/powerpc/sysdev/fsl_85xx_l2ctlr.c | 39 ++-- 2 files changed, 16 insertions(+), 27 deletions(-) diff --git a

[PATCH][v2] powerpc/85xx: Fix compiler error with THIS_MODULE and related

;int' in declaration of 'EXPORT_SYMBOL' arch/powerpc/sysdev/fsl_85xx_cache_sram.c:80:1: error: parameter names (without types) in function declaration make[1]: *** [arch/powerpc/sysdev/fsl_85xx_cache_sram.o] Error 1 Signed-off-by: Claudiu Manoil --- Replaced with for fsl_85xx_cache_s

[PATCH] powerpc/85xx: Fix compiler error with THIS_MODULE and related

;int' in declaration of 'EXPORT_SYMBOL' arch/powerpc/sysdev/fsl_85xx_cache_sram.c:80:1: error: parameter names (without types) in function declaration make[1]: *** [arch/powerpc/sysdev/fsl_85xx_cache_sram.o] Error 1 Signed-off-by: Claudiu Manoil --- arch/powerpc/sysdev/fsl_85xx_

[PATCH] powerpc/85xx: Add missing config option for CACHE SRAM code

fsl_85xx_l2ctlr.o and fsl_85xx_cache_sram.o are built only if CONFIG_FSL_85XX_CACHE_SRAM is defined. The driver that qualifies and wants to make use of the CACHE SRAM's exported API (i.e. a freescale net driver) should (be able to) select this config option. Signed-off-by: Claudiu M