between them and hence went ahead with that patch.
My guess was a 1-byte , 2-byte or a (PAGE_SIZE -1)-byte reservations may not
even
go into that loop. However we just need a fix for this problem. So if there is
a
better fix that you have please post it to lkml.
Thanks,
Chandru
__
Chandru wrote:
In case either physbase or reserve_size are not page aligned and in addition
if the following condition is also true
node_ar.end_pfn = node->node_end_pfn = PFN_DOWN(physbase+reserve_size).
we may hit the BUG_ON(end > bdata->node_low_pfn) in mark_bootmem_node() in
mm/
s the pfn that the physbase is part of and align
reserve_size before calling reserve_bootmem_node().
Signed-off-by: Chandru S
Cc: Dave Hansen
---
arch/powerpc/mm/numa.c |6 --
1 file changed, 4 insertions(+), 2 deletions(-)
--- linux-2.6.29-rc2/arch/powerpc/mm/numa.c.orig2009-01-
mem_node() for which we hit the
BUG_ON() eventually. Prior to calling reserve_bootmem_node() we have...
node_ar.end_pfn = node->node_end_pfn = PFN_DOWN(physbase+reserve_size).
Hence a PFN_UP() will raise the value of 'end'. The kernel has
CONFIG_PPC_64K_PAGES enabl
On Thursday 15 January 2009 13:35:27 Chandru wrote:
> Hello Dave, From the debug console output, if there is anything you can add
> here, pls let me know.
As we can see from the console output here, physbase isn't page aligned when
the panic occurs. So we could as well send
On Friday 09 January 2009 16:37:24 Chandru wrote:
> On Friday 09 January 2009 01:33:12 Dave Hansen wrote:
> > Now I'm even more confused. Could you please send a fully changelogged
> > patch that describes the problem, and how this fixes it? This just
> > seems like
nything.
>
> Does 'end_pfn' need fixing?
>
Attached is the console log with debug command line parameters enabled and
with couple of more debug statements added to the code. Please take a look at
it.
thanks,
Chandru
Using 0078209e bytes for initrd buffer
Please w
On Wednesday 07 January 2009 22:55:25 Dave Hansen wrote:
>
> I'm just suggesting making your fix in the ppc code instead of in
> mm/bootmem.c.
>
Here are the changes that helped to boot the kernel. Please review it.
Thanks,
Signed-off-by: Chandru S
Cc: Dave Hansen
---
On Wednesday 07 January 2009 07:20:17 Benjamin Herrenschmidt wrote:
> On Mon, 2008-12-22 at 16:14 +0530, Chandru wrote:
> > On a ppc64 machine booting linux-2.6.28-rc9 with crashkernel=2...@32m
> > boot parameter caused the kernel to panic while booting. Follwing is the
>
e again so that PFN_UP() will equate to
node_end_pfn ??
end
Also I was wondering if in reserve_bootmem_node()
end = PFN_DOWN() ; will do..
With the recent changes from you that went into 2.6.28 stable
(commit:a4c74ddd5ea3db53fc73d29c222b22656a7d05be), it worked on the system
wit
- (start_pfn << PAGE_SHIFT);
but the reserve_bootmem_node() in mm/bootmem.c raises the pfn value of end
end = PFN_UP(physaddr + size);
This causes end to get a value past the last page in the 0-256M node. The
following change restricts the value of end if
ernel memory in the next node as reserved.
It references NODE_DATA(node_ar.nid) and this causes another 'Oops: kernel
access of bad area' problem. The following changes made the system to boot
with any amount of crashkernel memory size.
Fix code for reserved memory spanning acroos n
duple for the above mentioned regions.
Signed-off-by: Chandru Siddalingappa <[EMAIL PROTECTED]>
---
Patch was tested on a power6 box. Could you pls add this patch to powerpc git
tree ? . Thanks,
arch/powerpc/kernel/prom.c | 40 +++--
arch/powerpc/mm/numa.c | 79
Pls let me know the status of this patch.
Thanks,
Chandru
On Thursday 14 August 2008 15:17:32 Chandru wrote:
> kdump kernel needs to use only those memory regions that it is allowed to use
> (crashkernel, rtas, tce ..etc ). Each of these regions have their own sizes
> and are curren
kernel.
Signed-off-by: Chandru Siddalingappa <[EMAIL PROTECTED]>
---
kexec/arch/ppc64/fs2dt.c | 72 +
1 file changed, 72 insertions(+)
--- kexec-tools-testing-orig/kexec/arch/ppc64/fs2dt.c 2008-08-14
14:41:52.0 +0530
+++ kexec-tools-testing
or the above mentioned regions.
Signed-off-by: Chandru Siddalingappa <[EMAIL PROTECTED]>
---
These patches were sent earlier but these are V3 of the patches. Pls let me
know your thoughts. Thanks.
arch/powerpc/kernel/prom.c | 40 +++--
arch/powerpc/mm/numa.c | 79
On Tuesday 22 July 2008 14:46:20 Paul Mackerras wrote:
> Chandru writes:
>
> > Scan for linux,usable-memory properties in case of dynamic reconfiguration
> > memory . Support for kexec/kdump.
> >
> > Signed-off-by: Chandru Siddalingappa <[EMAIL PROTECTED]>
Scan for linux,usable-memory properties in case of dynamic reconfiguration
memory . Support for kexec/kdump.
Signed-off-by: Chandru Siddalingappa <[EMAIL PROTECTED]>
---
Patch applies on powerpc tree. Patch was reviewed by Nathan Fontenot, Stephen
Rothwell, Michael Neuling.
arch/p
Scan for linux,usable-memory properties in case of dynamic reconfiguration
memory. Support for kexec/kdump.
Signed-off-by: Chandru Siddalingappa <[EMAIL PROTECTED]>
---
Patch applies on linux-next tree (patch-v2.6.26-rc9-next-20080711.gz)
arch/powerpc/kernel/prom.c
On Friday 11 July 2008 03:57:53 Nathan Fontenot wrote:
> Hello Chandru,
>
> > static int __init early_init_dt_scan_drconf_memory(unsigned long node)
> > {
> > - cell_t *dm, *ls;
> > + cell_t *dm, *ls, *endp, *usm;
> > unsigned long l, n, fla
Thanks for the review comments. I will change to 'snprintf' at all the places
and remove the unnecessary casts.
On Tuesday 08 July 2008 07:06:46 Stephen Rothwell wrote:
> Hi Chandru,
>
> On Tue, 8 Jul 2008 00:14:24 +0530 Chandru <[EMAIL PROTECTED]> wrote:
> &
Changes to kexec-ppc64.c in case of ibm,dynamic-reconfiguration-memory node
of /proc/device-tree.
Signed-off-by: Chandru Siddalingappa <[EMAIL PROTECTED]>
---
diff -Naurp kexec-tools-testing-orig/kexec/arch/ppc64/kexec-ppc64.c
kexec-tools-testing/kexec/arch/ppc64/kexec-ppc64.c
--- kexec
get crash memory ranges from ibm,dynamic-reconfiguration-memory node
of /proc/device-tree.
Signed-off-by: Chandru Siddalingappa <[EMAIL PROTECTED]>
---
diff -Naurp kexec-tools-testing-orig/kexec/arch/ppc64/crashdump-ppc64.c
kexec-tools-testing/kexec/arch/ppc64/crashdump-ppc64.c
---
Add linux,usable-memory properties into device tree in case of
ibm,dynamic-reconfiguration-memory node of /proc/device-tree
Signed-off-by: Chandru Siddalingappa <[EMAIL PROTECTED]>
---
diff -Naurp kexec-tools-testing-orig/kexec/arch/ppc64/fs2dt.c
kexec-tools-testing/kexec/arch/ppc64/f
kexec-tools adds crash, rtas, and tce memory regions as linux,usable-memory
properties in device-tree. Following changes are made in the kernel to
recognize these special properties in case of
ibm,dynamic-reconfiguration-memory node of device-tree.
Signed-off-by: Chandru Siddalingappa
bm,dynamic-memory) , I have appended the lmb entry number to
the 'linux,usable-memory' string so as to identify usable-memory ranges in
the device-tree.
Signed-off-by: Chandru Siddalingappa <[EMAIL PROTECTED]>
___
Linuxppc-dev mailing li
On Friday 13 June 2008 14:51:39 Chandru wrote:
> kexec-tools in user space collects rtas, crash , tce region ranges
> from /proc/device-tree/ and passes them as linux,usable-memory properties
> to second/kdump kernel in the device tree buffer. With drconf memory in
> power6 machine
ded in this patch is in
arch/powerpc/mm/numa.c.
Signed-off-by: Chandru S <[EMAIL PROTECTED]>
---
--- arch/powerpc/kernel/prom.c.orig 2008-06-13 11:42:45.0 +0530
+++ arch/powerpc/kernel/prom.c 2008-06-13 12:09:04.0 +0530
@@ -884,9 +884,10 @@ static u64 __init dt_mem_nex
odes
for 2.6.26-rc1 ?.
Thanks,
Chandru
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
29 matches
Mail list logo