On Mon, Aug 25, 2025 at 02:48:21PM -0600, Jens Axboe wrote:
> On Mon, 25 Aug 2025 18:32:54 +0200, Andy Shevchenko wrote:
> > There are a few places in architecture code for the floppy driver
> > that may be cleaned up. Do it so.
> >
> > Assumed to route via Andrew
Since the commit 3d86739c6343 ("floppy: always use the track buffer")
the CROSS_64KB() is not used by the driver, remove the leftovers.
Acked-by: Helge Deller #parisc
Acked-by: Geert Uytterhoeven # m68k
Signed-off-by: Andy Shevchenko
---
arch/alpha/include/asm/floppy
There are only two headers using the K_64 custom constant. Moreover,
its usage tangles a code because the constant is defined in the C
file, while users are in the headers. Replace it with well defined
SZ_64K from sizes.h.
Acked-by: Helge Deller
Signed-off-by: Andy Shevchenko
---
arch/parisc
Sorting headers alphabetically helps locating duplicates, and makes it
easier to figure out where to insert new headers.
Signed-off-by: Andy Shevchenko
---
drivers/block/floppy.c | 54 +-
1 file changed, 27 insertions(+), 27 deletions(-)
diff --git a
n the commit message (Geert)
Andy Shevchenko (3):
floppy: Remove unused CROSS_64KB() macro from arch/ code
floppy: Replace custom SZ_64K constant
floppy: Sort headers alphabetically
arch/alpha/include/asm/floppy.h| 19 --
arch/arm/include/asm/floppy.h | 2 --
arch/m68k/includ
On Thu, Aug 14, 2025 at 10:33:52AM +0200, Christophe Leroy wrote:
> Le 18/11/2024 à 13:31, Andy Shevchenko a écrit :
> > Remove legacy-of-mm-gpiochip.h header file. The above mentioned
> > file provides an OF API that's deprecated. There is no agnostic
> > alternatives
gt; Make them sane such that:
> * 'u32' is used for register values, and
> * 'unsigned int' is used for offsets.
>
> While at it, name hooks' parameters, so it is clear what is what.
At a glance this looks just mechanical change. Have you used coccinelle for
that?
On Tue, Jun 10, 2025 at 11:03:39PM +0300, Laurent Pinchart wrote:
> On Tue, Jun 10, 2025 at 10:39:31PM +0300, Andy Shevchenko wrote:
> > On Fri, Apr 25, 2025 at 08:07:32PM +0300, Laurent Pinchart wrote:
> > > On Fri, Apr 25, 2025 at 06:30:10PM +0300, Dan Carpenter wrote:
> &g
cremented
> > drivers/net/pse-pd/tps23881.c:505 tps23881_get_of_channels() warn:
> > 'priv->np' was not incremented
> > drivers/media/platform/qcom/venus/core.c:301 venus_add_video_core() warn:
> > 'dev->of_node' was not incremented
> > drivers/regulator/tps6594-regulator.c:618 tps6594_regulator_probe() warn:
> > 'tps->dev->of_node' was not incremented
--
With Best Regards,
Andy Shevchenko
Since the commit 3d86739c6343 ("floppy: always use the track buffer")
the CROSS_64K() is not used by the driver, remove the leftovers.
Signed-off-by: Andy Shevchenko
---
arch/alpha/include/asm/floppy.h| 19 ---
arch/arm/include/asm/floppy.h | 2 --
arch/m6
re occurences and the build bots are happy, too. It really seems this
> is all that is left to do. No complaint, though.
Reviewed-by: Andy Shevchenko
--
With Best Regards,
Andy Shevchenko
the
research for the later.
--
With Best Regards,
Andy Shevchenko
header for BIT() et al. is bits.h.
bitfield.h is for FIELD_*() et al.
--
With Best Regards,
Andy Shevchenko
g/doc/ (once applied, of course).
I am all to support the idea, but in some cases I would think of a bit
more work to be done to get rid of the of_fwnode_handle(np) in favour
of dev_fwnode(dev). Note, this is based on a brief look, I haven't any
example at hand right now.
--
With Best Regards,
Andy Shevchenko
ble this if the kdump is enabled in the kernel configuration?
--
With Best Regards,
Andy Shevchenko
atically if kdump is expected?
> +static bool stop_on_panic;
> +module_param(stop_on_panic, bool, 0444);
> +MODULE_PARM_DESC(stop_on_panic, "Stop watchdogs on panic (0=keep watching,
> 1=stop)");
+ blank line.
Also I do not see the documentation update. Where is it lost?
> /*
--
With Best Regards,
Andy Shevchenko
the last one. Currently it's a lot of unneeded churn that makes review a bit
harder (each needs to be carefully checked for the correctness).
--
With Best Regards,
Andy Shevchenko
0-386d7c3ee...@gmail.com/T/#u
> > [0]
> >
> > Signed-off-by: Tamir Duberstein
>
> I have just quickly tested this before leaving for a week.
> And I am fine with the result.
Seems reasonable to me. But I want a consensus with Rasmus.
--
With Best Regards,
Andy Shevchenko
fore they are picked up, so anything that gets
> applied early saves me from resending.
Arnd, can you refresh this one? It seems some misses still...
I have got 3+ 0-day reports against one of the mux drivers.
https://lore.kernel.org/all/?q=adg792a.c
--
With Best Regards,
Andy Shevchenko
On Fri, Dec 13, 2024 at 07:01:42PM +0100, Christophe Leroy wrote:
> Le 13/12/2024 à 18:07, Andy Shevchenko a écrit :
> > On Fri, Dec 13, 2024 at 07:28:45AM +0100, Christophe Leroy wrote:
> > > Le 12/12/2024 à 17:24, Andy Shevchenko a écrit :
> > > > On Mon, No
On Fri, Dec 13, 2024 at 07:28:45AM +0100, Christophe Leroy wrote:
> Le 12/12/2024 à 17:24, Andy Shevchenko a écrit :
> > On Mon, Nov 18, 2024 at 03:10:09PM +0100, Christophe Leroy wrote:
> > > Le 18/11/2024 à 13:31, Andy Shevchenko a écrit :
> > > > Remove legacy-of-
On Mon, Nov 18, 2024 at 03:10:09PM +0100, Christophe Leroy wrote:
> Le 18/11/2024 à 13:31, Andy Shevchenko a écrit :
> > Remove legacy-of-mm-gpiochip.h header file. The above mentioned
> > file provides an OF API that's deprecated. There is no agnostic
> > alternatives
eling schemas and resource retrieval
that only a few may gain of the code deduplication, so whenever
alternative is appear we can move drivers again to use that one.
As a side effect this change fixes a potential memory leak on
an error path, if of_mm_gpiochip_add_data() fails.
Signed-off-by: Andy Shevc
On Mon, Nov 18, 2024 at 12:02:44PM +0100, Christophe Leroy wrote:
> Le 18/11/2024 à 10:20, Andy Shevchenko a écrit :
> > On Sat, Nov 16, 2024 at 11:44:35AM +0100, Christophe Leroy wrote:
> > > Le 15/11/2024 à 14:38, Andy Shevchenko a écrit :
> > > > Remove legac
On Sat, Nov 16, 2024 at 11:44:35AM +0100, Christophe Leroy wrote:
> Le 15/11/2024 à 14:38, Andy Shevchenko a écrit :
> > Remove legacy-of-mm-gpiochip.h header file, replace of_* functions
> > and structs with appropriate alternatives.
>
> Looks like you don't rea
Remove legacy-of-mm-gpiochip.h header file, replace of_* functions
and structs with appropriate alternatives.
Signed-off-by: Andy Shevchenko
---
arch/powerpc/platforms/8xx/cpm1.c | 119 +++---
1 file changed, 60 insertions(+), 59 deletions(-)
diff --git a/arch/powerpc
On Mon, Aug 26, 2024 at 09:51:10AM +0200, Marco Felsch wrote:
> On 24-08-23, Andy Shevchenko wrote:
> > On Mon, Jul 01, 2024 at 03:53:39PM +0200, Marco Felsch wrote:
> > > This series adds the intial support to handle EEPROMs via the MTD layer
> > > as well. This a
EEPROMs that most likely appear on the devices with
limited amount of resources!) in a reasonable size and performance, why not?
--
With Best Regards,
Andy Shevchenko
of_gpio.h is deprecated and subject to remove.
The driver doesn't use it directly, replace it
with what is really being used.
Signed-off-by: Andy Shevchenko
---
sound/soc/samsung/aries_wm8994.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/samsung/aries_wm8
of_gpio.h is deprecated and subject to remove.
The driver doesn't use it directly, replace it
with what is really being used.
Acked-by: Kuninori Morimoto
Signed-off-by: Andy Shevchenko
---
sound/soc/generic/audio-graph-card2-custom-sample.c | 3 ++-
1 file changed, 2 insertions(+), 1 del
of_gpio.h is deprecated and subject to remove. The drivers in question
don't use it, simply remove the unused header.
Signed-off-by: Andy Shevchenko
---
sound/soc/rockchip/rockchip_i2s.c | 1 -
sound/soc/rockchip/rockchip_spdif.c | 1 -
2 files changed, 2 deletions(-)
diff --git a/soun
of_gpio.h is deprecated and subject to remove.
The driver doesn't use it directly, replace it
with what is really being used.
Signed-off-by: Andy Shevchenko
---
sound/soc/codecs/aw88395/aw88395.c | 2 +-
sound/soc/codecs/aw88399.c | 2 +-
2 files changed, 2 insertions(+), 2 dele
of_gpio.h is deprecated and subject to remove. The drivers in question
don't use it, simply remove the unused header.
Reviewed-by: Kuninori Morimoto
Reviewed-by: Charles Keepax
Signed-off-by: Andy Shevchenko
---
sound/soc/codecs/ak4118.c| 1 -
sound/soc/codecs/ak4458.c
of_gpio.h is deprecated and subject to remove. The drivers in question
don't use it, simply remove the unused header.
Signed-off-by: Andy Shevchenko
---
sound/soc/fsl/imx-es8328.c | 1 -
sound/soc/fsl/imx-rpmsg.c | 2 --
2 files changed, 3 deletions(-)
diff --git a/sound/soc/fsl/imx-es8
out TAS2781 (it's a mess from GPIO handling perspective)
Andy Shevchenko (6):
ASoC: codecs: Remove unused of_gpio.h
ASoC: fsl: Remove unused of_gpio.h
ASoC: rockchip: Remove unused of_gpio.h
ASoC: codecs: Replace of_gpio.h by proper one
ASoC: generic: Replace of_gpio.h by proper one
Make two APIs look similar. Hence convert match_string() to be
a 2-argument macro. In order to avoid unneeded churn, convert
all users as well. There is no functional change intended.
Signed-off-by: Andy Shevchenko
---
Compile tested with `make allyesconfig` and `make allmodconfig`
on x86_64
of_gpio.h is deprecated and subject to remove.
The driver doesn't use it directly, replace it
with what is really being used.
Signed-off-by: Andy Shevchenko
---
sound/soc/samsung/aries_wm8994.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/samsung/aries_wm8
of_gpio.h is deprecated and subject to remove.
The driver doesn't use it directly, replace it
with what is really being used.
Acked-by: Kuninori Morimoto
Signed-off-by: Andy Shevchenko
---
sound/soc/generic/audio-graph-card2-custom-sample.c | 3 ++-
1 file changed, 2 insertions(+), 1 del
of_gpio.h is deprecated and subject to remove. The drivers in question
don't use it, simply remove the unused header.
Signed-off-by: Andy Shevchenko
---
sound/soc/fsl/imx-es8328.c | 1 -
sound/soc/fsl/imx-rpmsg.c | 2 --
2 files changed, 3 deletions(-)
diff --git a/sound/soc/fsl/imx-es8
of_gpio.h is deprecated and subject to remove. The drivers in question
don't use it, simply remove the unused header.
Signed-off-by: Andy Shevchenko
---
sound/soc/rockchip/rockchip_i2s.c | 1 -
sound/soc/rockchip/rockchip_spdif.c | 1 -
2 files changed, 2 deletions(-)
diff --git a/soun
Replace or drop the legacy header that is subject to remove.
Not all of them were compile-tested, the series might have
hidden compilation errors.
In v2:
- added tags (Kuninori, Charles)
- ripped out TAS2781 (it's a mess from GPIO handling perspective)
Andy Shevchenko (6):
ASoC: codecs: R
of_gpio.h is deprecated and subject to remove.
The driver doesn't use it directly, replace it
with what is really being used.
Signed-off-by: Andy Shevchenko
---
sound/soc/codecs/aw88395/aw88395.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/aw
of_gpio.h is deprecated and subject to remove. The drivers in question
don't use it, simply remove the unused header.
Reviewed-by: Kuninori Morimoto
Reviewed-by: Charles Keepax
Signed-off-by: Andy Shevchenko
---
sound/soc/codecs/ak4118.c| 1 -
sound/soc/codecs/ak4458.c
.10-rc1 next-20240529]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
>
> url:
> https://github.com
of_gpio.h is deprecated and subject to remove.
The driver doesn't use it directly, replace it
with what is really being used.
Signed-off-by: Andy Shevchenko
---
sound/soc/generic/audio-graph-card2-custom-sample.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/soun
of_gpio.h is deprecated and subject to remove.
The driver doesn't use it directly, replace it
with what is really being used.
Signed-off-by: Andy Shevchenko
---
sound/soc/samsung/aries_wm8994.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/samsung/aries_wm8
of_gpio.h is deprecated and subject to remove. The drivers in question
don't use it, simply remove the unused header.
Signed-off-by: Andy Shevchenko
---
sound/soc/codecs/ak4118.c | 1 -
sound/soc/codecs/ak4458.c | 1 -
sound/soc/codecs/aw88399.c| 1 -
sound/soc/c
Replace or drop the legacy header that is subject to remove.
Not all of them were compile-tested, the series might have
hidden compilation errors.
Andy Shevchenko (6):
ASoC: codecs: Remove unused of_gpio.h
ASoC: fsl: Remove unused of_gpio.h
ASoC: rockchip: Remove unused of_gpio.h
ASoC
of_gpio.h is deprecated and subject to remove. The drivers in question
don't use it, simply remove the unused header.
Signed-off-by: Andy Shevchenko
---
sound/soc/fsl/imx-es8328.c | 1 -
sound/soc/fsl/imx-rpmsg.c | 2 --
2 files changed, 3 deletions(-)
diff --git a/sound/soc/fsl/imx-es8
of_gpio.h is deprecated and subject to remove.
The driver doesn't use it directly, replace it
with what is really being used.
Signed-off-by: Andy Shevchenko
---
sound/soc/codecs/aw88395/aw88395.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/aw
of_gpio.h is deprecated and subject to remove. The drivers in question
don't use it, simply remove the unused header.
Signed-off-by: Andy Shevchenko
---
sound/soc/rockchip/rockchip_i2s.c | 1 -
sound/soc/rockchip/rockchip_spdif.c | 1 -
2 files changed, 2 deletions(-)
diff --git a/soun
s >> 8) == PCI_CLASS_BRIDGE_PCI) {
> + slotno = PCI_SLOT(PCI_DN(dn)->devfn);
> + pci_scan_slot(bus, PCI_DEVFN(slotno, 0));
> + }
> + }
> +
> + return NULL;
> +}
--
With Best Regards,
Andy Shevchenko
On Fri, Apr 05, 2024 at 10:58:55AM +1100, Michael Ellerman wrote:
> Andy Shevchenko writes:
> > On Wed, Mar 13, 2024 at 03:56:45PM +0200, Andy Shevchenko wrote:
> >> of_gpio.h is deprecated and subject to remove.
> >> The driver doesn't use it directly, replace i
On Fri, Apr 5, 2024 at 6:06 AM Michael Ellerman wrote:
> Andy Shevchenko writes:
> > On Thu, Apr 4, 2024 at 2:57 AM Finn Thain wrote:
> >> On Thu, 4 Apr 2024, Andy Shevchenko wrote:
> >
> >> > > Cc: Benjamin Herrenschmidt
> >> > > Cc: Micha
On Fri, Apr 5, 2024 at 1:15 AM Finn Thain wrote:
> On Thu, 4 Apr 2024, Andy Shevchenko wrote:
>
> > > > > ---
> > > > (here is a good location for Cc:)
> > >
> > > Documentation/process/submitting-patches.rst indicats that it should
> >
On Thu, Apr 4, 2024 at 2:57 AM Finn Thain wrote:
> On Thu, 4 Apr 2024, Andy Shevchenko wrote:
...
> > > Cc: Benjamin Herrenschmidt
> > > Cc: Michael Ellerman
> > > Cc: Nicholas Piggin
> > > Cc: Christophe Leroy
> > > Cc: "Aneesh Kum
On Thu, Apr 4, 2024 at 8:07 AM Jiri Slaby wrote:
> On 04. 04. 24, 0:29, Andy Shevchenko wrote:
> >> Cc: Benjamin Herrenschmidt
> >> Cc: Michael Ellerman
> >> Cc: Nicholas Piggin
> >> Cc: Christophe Leroy
> >> Cc: "Aneesh Kumar K.V"
fs+0x0/0x60
> [ 14.56] [<00638410>] _sinittext+0x410/0xadc
> [ 14.56]
First of all, please read this
https://www.kernel.org/doc/html/latest/process/submitting-patches.html#backtraces-in-commit-messages
and amend the commit message accordingly.
> Cc: Benjamin Herrenschmidt
> Cc: Michael Ellerman
> Cc: Nicholas Piggin
> Cc: Christophe Leroy
> Cc: "Aneesh Kumar K.V"
> Cc: "Naveen N. Rao"
> Cc: linux-m...@lists.linux-m68k.org
Second, please move these Cc to be after the '---' line
> Link: https://github.com/vivier/qemu-m68k/issues/44
> Link: https://lore.kernel.org/all/1078874617.9746.36.camel@gaston/
Missed Fixes tag?
> Signed-off-by: Finn Thain
> ---
(here is a good location for Cc:)
--
With Best Regards,
Andy Shevchenko
On Wed, Mar 13, 2024 at 03:56:45PM +0200, Andy Shevchenko wrote:
> of_gpio.h is deprecated and subject to remove.
> The driver doesn't use it directly, replace it
> with what is really being used.
Any comments on this?
--
With Best Regards,
Andy Shevchenko
The gpio field is not used anymore, remove the leftover.
This also fixes the compilation error after the ...
Fixes: 9855f05e5536 ("ASoC: fsl: imx-es8328: Switch to using gpiod API")
Signed-off-by: Andy Shevchenko
---
sound/soc/fsl/imx-es8328.c | 1 -
1 file changed, 1 deletion(-)
di
On Mon, Mar 18, 2024 at 10:07:56PM +0200, Andy Shevchenko wrote:
> This updates the driver to gpiod API, and removes yet another use of
> of_get_named_gpio().
This also needs a leftover removal. :-(
--
With Best Regards,
Andy Shevchenko
iously is
not needed to be fixed in a separate patch. So, please consider this.
--
With Best Regards,
Andy Shevchenko
= at91_twi_xfer,
> + .xfer = at91_twi_xfer,
Seems you made this by a script, can you check the indentations afterwards?
> .functionality = at91_twi_func,
> };
--
With Best Regards,
Andy Shevchenko
This updates the driver to gpiod API, and removes yet another use of
of_get_named_gpio().
Signed-off-by: Andy Shevchenko
---
v2: fixed compilation error
sound/soc/fsl/imx-es8328.c | 16 ++--
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git a/sound/soc/fsl/imx-es8328.c b
On Mon, Mar 18, 2024 at 09:58:37PM +0200, Andy Shevchenko wrote:
> This updates the driver to gpiod API, and removes yet another use of
> of_get_named_gpio().
This won't compile, sorry for the noise. I'll send a v2.
--
With Best Regards,
Andy Shevchenko
This updates the driver to gpiod API, and removes yet another use of
of_get_named_gpio().
Signed-off-by: Andy Shevchenko
---
sound/soc/fsl/imx-es8328.c | 16 ++--
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git a/sound/soc/fsl/imx-es8328.c b/sound/soc/fsl/imx-es8328.c
ce dedicated devm wrapper
> for mutex as it's often used resource.
The leds related changes (except the last one) LGTM, hence FWIW,
Reviewed-by: Andy Shevchenko
(for patches 2-8)
> [1]
> https://lore.kernel.org/lkml/8704539b-ed3b-44e6-aa82-586e2f895...@salutedev
implementation.
So, this change is not related to the main purpose of the series...
--
With Best Regards,
Andy Shevchenko
t say if there is a better (more
ordered) place to squeeze a new header to. Please, check.
...
After addressing the above comments
Reviewed-by: Andy Shevchenko
--
With Best Regards,
Andy Shevchenko
of_gpio.h is deprecated and subject to remove.
The driver doesn't use it directly, replace it
with what is really being used.
Signed-off-by: Andy Shevchenko
---
arch/powerpc/platforms/52xx/mpc52xx_common.c | 2 --
arch/powerpc/platforms/52xx/mpc52xx_gpt.c| 2 +-
2 files changed, 1 inse
]
> > On 3/7/24 13:34, Andy Shevchenko wrote:
> >> On Thu, Mar 7, 2024 at 4:40 AM George Stark
> >> wrote:
...
> >>> Signed-off-by: George Stark
> >>> Signed-off-by: Christophe Leroy
> >>
> >>> Hello Christophe. Hope you do
nd
probably add a (missing) Co-developed-by. After all you should also
follow the correct order of SoBs.
--
With Best Regards,
Andy Shevchenko
On Wed, Mar 06, 2024 at 04:43:11PM +0100, Herve Codina wrote:
> On Wed, 6 Mar 2024 15:43:04 +0200
> Andy Shevchenko wrote:
> > On Wed, Mar 06, 2024 at 05:06:12AM -0800, Yury Norov wrote:
> > > On Wed, Mar 06, 2024 at 09:07:20AM +0100, Herve Codina wrote:
...
> >
OM_U64(slot_map) };
This looks ugly. Can we rather provide a macro that does this under the hood?
Roughly:
#define DEFINE_BITMAP_64(name, src) \
DECLARE_BITMAP(name, 64) = { BITMAP_FROM_U64(src) }
--
With Best Regards,
Andy Shevchenko
, otherwise I can move it with bitmap-for-next.
--
With Best Regards,
Andy Shevchenko
RX_FLAG_HDLC_OVF);
This is harder to read. And IIUC net subsystem dislikes the proposed one
(I tried to submit a patch to clarify some boolean types vs. integer ones
and it was rejected because of the reason I have mentioned).
--
With Best Regards,
Andy Shevchenko
On Tue, Mar 05, 2024 at 12:02:26PM +0100, Herve Codina wrote:
> On Thu, 29 Feb 2024 17:23:32 +0200
> Andy Shevchenko wrote:
...
> > I think it's a good series and next version will be final. The only
> > question is
> > possible use of the returned values from b
ed by following commit
>
> commit 66a5c40f60f5d88ad8d47ba6a4ba05892853fa1f
> kernel.h: removed REPEAT_BYTE from kernel.h
Thanks for the report.
What is missing here are the steps to reproduce it here. E.g., I have
an x86_64 machine, I can use QEMU if required.
--
With Best Regards,
Andy Shevchenko
k it's a good series and next version will be final. The only question is
possible use of the returned values from bitmap_scatter()/bitmap_gather(), the
rest are minors.
Feel free to add
Reviewed-by: Andy Shevchenko
to patches 4 and 5.
--
With Best Regards,
Andy Shevchenko
bitmap_weight(map, 64)) {
> + dev_err(qmc_hdlc->dev, "Cannot translate timeslots (%64pb,
> %64pb) -> %64pb\n",
> + ts_mask_avail, ts_mask, map);
> + return -EINVAL;
> + }
Ditto.
--
With Best Regards,
Andy Shevchenko
On Thu, Feb 29, 2024 at 03:15:51PM +0100, Herve Codina wrote:
> From: Andy Shevchenko
>
> These helpers scatters or gathers a bitmap with the help of the mask
> position bits parameter.
>
> bitmap_scatter() does the following:
> s
de
> +#include
> +#include
> +#include
> +#include
+ spinlock.h
+ types.h
With this fixed (below is up to you),
Reviewed-by: Andy Shevchenko
...
> +free_desc:
> + qmc_chan_reset(qmc_hdlc->qmc_chan, QMC_CHAN_ALL);
> + for (i = 0; i < ARRAY_SIZE(qmc_hdlc->rx_descs);
On Thu, Feb 29, 2024 at 01:56:05PM +0100, Herve Codina wrote:
> On Thu, 22 Feb 2024 17:49:40 +0200
> Andy Shevchenko wrote:
> > On Thu, Feb 22, 2024 at 03:22:18PM +0100, Herve Codina wrote:
...
> I've got an issue with guard(spinlock_irqsave).
No, you got an issue with s
On Thu, Feb 22, 2024 at 05:45:01PM +0100, Herve Codina wrote:
> On Thu, 22 Feb 2024 17:29:05 +0200
> Andy Shevchenko wrote:
> > On Thu, Feb 22, 2024 at 03:22:14PM +0100, Herve Codina wrote:
...
> > > + spin_lock_irqsave(&qmc_hdlc->tx_lock, flags);
> >
>
> Compared to the previous iteration:
>
> https://lore.kernel.org/linux-kernel/20240212075646.19114-1-herve.cod...@bootlin.com/
> this v4 series mainly:
>From my point of view after addressing the few non-critical issues
the v4 will be final. Thank you!
--
With Best Regards,
Andy Shevchenko
;dev, "get framer status failed (%d)\n", ret);
> + goto end;
> + }
> + if (framer_status.link_is_on)
> + netif_carrier_on(qmc_hdlc->netdev);
> + else
> + netif_carrier_off(qmc_hdlc->netdev);
> +
> +end:
> + spin_unlock_irqrestore(&qmc_hdlc->carrier_lock, flags);
> + return ret;
> +}
--
With Best Regards,
Andy Shevchenko
const struct qmc_chan_ts_info *ts_info, u32
> *slot_map)
Similar comments apply as per above function.
...
> + ret = qmc_chan_get_ts_info(qmc_hdlc->qmc_chan, &ts_info);
> + if (ret) {
> + dev_err(qmc_hdlc->dev, "get QMC channel ts info failed %d\n",
> ret);
> + return ret;
return dev_err_probe(...);
> + }
--
With Best Regards,
Andy Shevchenko
On Thu, Feb 22, 2024 at 05:39:27PM +0200, Andy Shevchenko wrote:
> On Thu, Feb 22, 2024 at 03:22:16PM +0100, Herve Codina wrote:
> > From: Andy Shevchenko
> > The original work was done by Andy Shevchenko.
>
> Mine SoB is enough for a credit, but thank you :-)
That said, y
On Thu, Feb 22, 2024 at 03:22:16PM +0100, Herve Codina wrote:
> From: Andy Shevchenko
>
> These helpers scatters or gathers a bitmap with the help of the mask
> position bits parameter.
>
> bitmap_scatter() does the following:
> s
lc->netdev);
> + hdlc->attach = qmc_hdlc_attach;
> + hdlc->xmit = qmc_hdlc_xmit;
> + SET_NETDEV_DEV(qmc_hdlc->netdev, qmc_hdlc->dev);
> + qmc_hdlc->netdev->tx_queue_len = ARRAY_SIZE(qmc_hdlc->tx_descs);
> + qmc_hdlc->netdev->netdev_ops = &qmc_hdlc_netdev_ops;
> + ret = register_hdlc_device(qmc_hdlc->netdev);
> + if (ret) {
> + dev_err(qmc_hdlc->dev, "failed to register hdlc device (%d)\n",
> ret);
> + goto free_netdev;
> + }
> +
> + platform_set_drvdata(pdev, qmc_hdlc);
> +
> + return 0;
> +
> +free_netdev:
> + free_netdev(qmc_hdlc->netdev);
> + return ret;
> +}
--
With Best Regards,
Andy Shevchenko
On Thu, Feb 22, 2024 at 01:05:16PM +0100, Herve Codina wrote:
> On Mon, 12 Feb 2024 14:22:56 +0200
> Andy Shevchenko wrote:
...
> > > +#include
> > > +#include
> > > +#include
> >
> > > +#include
> > > +#include
> >
>
On Wed, Feb 21, 2024 at 02:44:31PM +0100, Herve Codina wrote:
> On Thu, 15 Feb 2024 21:17:23 +0200
> Andy Shevchenko wrote:
[...]
> > > Now what's the plan ?
> > > Andy, do you want to send a v2 of this patch or may I get the patch,
> > > modify it
> &g
), perhaps in a separate patch we can
replace it with bitmap_scatter() (IIUC) with explanation that the former
1) uses atomic ops while being non-atomic as a whole, and b) having quite
hard to get documentation. At least that's how I see it, I mean that I would
like to leave bitmap_onto() alone and address it separately.
> Yury, any preferences ?
--
With Best Regards,
Andy Shevchenko
On Tue, Feb 13, 2024 at 2:14 AM George Stark wrote:
>
> Hello Andy
>
> On 2/12/24 12:53, Andy Shevchenko wrote:
> > On Mon, Feb 12, 2024 at 1:52 AM George Stark
> > wrote:
> >> I haven't lose hope for the devm_mutex thing and keep pinging those guys
&
On Mon, Feb 12, 2024 at 03:20:22PM +0100, Herve Codina wrote:
> On Mon, 12 Feb 2024 16:01:38 +0200
> Andy Shevchenko wrote:
...
> Agree, the bitmap_onto() code is simpler to understand than its help.
>
> I introduced bitmap_off() to be the "reverse" bitmap_onto() ope
On Mon, Feb 12, 2024 at 02:37:53PM +0100, Herve Codina wrote:
> On Mon, 12 Feb 2024 14:27:16 +0200
> Andy Shevchenko wrote:
> > On Mon, Feb 12, 2024 at 08:56:31AM +0100, Herve Codina wrote:
> > > Currently the bitmap_onto() is available only for CONFIG_NUMA=y case,
>
d exporting for
> modules.
Wondering if you are trying to have something like
https://lore.kernel.org/lkml/20230926052007.3917389-1-andriy.shevche...@linux.intel.com/
--
With Best Regards,
Andy Shevchenko
these are being used, am I right?
What's is missing OTOH is the mod_devicetable.h.
> +#include
> +#include
+ Blank line?
> +#include
--
With Best Regards,
Andy Shevchenko
updated
version into your series. Am I wrong?
> Sure I can single out the fix-only patch I'll do it tomorrow.
I believe it can be handled without issuing it separately. `b4` tool
is capable of selective choices. It was rather Q to Lee if he can/want
to apply it right away.
> On 2/
14705d9f06e91421f
> [3]
> https://lore.kernel.org/lkml/8704539b-ed3b-44e6-aa82-586e2f895...@salutedevices.com/T/#mdbf572a85c33f869a553caf986b6228bb65c8383
Are you going to send an updated version with the amended second patch?
--
With Best Regards,
Andy Shevchenko
1 - 100 of 500 matches
Mail list logo
