[PATCH 8/8] powerpc/64s: tidy machine check SLB logging

Since ISA v3.0, SLB no longer uses the slb_cache, and stab_rr is no longer correlated with SLB allocation. Move those to pre-3.0. While here, improve some alignments and reduce whitespace. Signed-off-by: Nicholas Piggin --- arch/powerpc/mm/book3s64/slb.c | 39 ++

[PATCH 7/8] powerpc/64s: Remove "Host" from MCE logging

"Host" caused machine check is printed when the kernel sees a MCE hit in this kernel or userspace, and "Guest" if it hit one of its guests. This is confusing when a guest kernel handles a hypervisor- delivered MCE, it also prints "Host". Just remove "Host". "Guest" is adequate to make the distinct

[PATCH 6/8] powerpc/64s/pseries: Add ERAT specific machine check handler

Don't treat ERAT MCEs as SLB, don't save the SLB and use a specific ERAT flush to recover it. Signed-off-by: Nicholas Piggin --- arch/powerpc/include/asm/mce.h | 1 + arch/powerpc/kernel/mce_power.c | 2 +- arch/powerpc/platforms/pseries/ras.c | 5 - 3 files changed, 6 insertions(

[PATCH 5/8] powerpc/64s/powernv: ratelimit harmless HMI error printing

Harmless HMI errors can be triggered by guests in some cases, and don't contain much useful information anyway. Ratelimit these to avoid flooding the console/logs. Signed-off-by: Nicholas Piggin --- arch/powerpc/platforms/powernv/opal-hmi.c | 27 +-- 1 file changed, 15 insert

[PATCH 4/8] KVM: PPC: Book3S HV: Ratelimit machine check messages coming from guests

A number of machine check exceptions are triggerable by the guest. Ratelimit these to avoid a guest flooding the host console and logs. Signed-off-by: Nicholas Piggin --- arch/powerpc/kvm/book3s_hv.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/arch/powerpc/kvm

[PATCH 3/8] KVM: PPC: Book3S HV: Don't attempt to recover machine checks for FWNMI enabled guests

Guests that can deal with machine checks would actually prefer the hypervisor not to try recover for them. For example if SLB multi-hits are recovered by the hypervisor by clearing the SLB then the guest will not be able to log the contents and debug its programming error. If guests don't register

[PATCH 2/8] powerpc/64s/powernv: Allow KVM to handle guest machine check details

KVM has strategies to perform machine check recovery. If a MCE hits in a guest, have the low level handler just decode and save the MCE but not try to recover anything, so KVM can deal with it. The host does not own SLBs and does not need to report the SLB state in case of a multi-hit for example,

[PATCH 1/8] powerpc/64s/powernv: Fix memory corruption when saving SLB entries on MCE

This can be hit by an HPT guest running on an HPT host and bring down the host, so it's quite important to fix. Fixes: 7290f3b3d3e66 ("powerpc/64s/powernv: machine check dump SLB contents") Signed-off-by: Nicholas Piggin --- arch/powerpc/platforms/powernv/setup.c | 9 +++-- 1 file changed, 7

[PATCH 0/8] powerpc/64s: fix and improve machine check handling

First patch is a nasty memory scribble introduced by me :( That should go into fixes. The next ones could wait for next merge window. They get things to the point where misbehaving or buggy guest isn't so painful for the host, and also get the guest SLB dumping code working (because the host no lo

Re: [PATCH] powerpc: fix the allyesconfig build

Hi Jakub, On Fri, 27 Nov 2020 17:56:42 -0800 Jakub Kicinski wrote: > > What's the offending structure in hisilicon? I'd rather have a look > packing structs with pointers in 'em sounds questionable. > > I only see these two: > > $ git grep packed drivers/net/ethernet/hisilicon/ > drivers/net/et

Re: [PATCH] powerpc: fix the allyesconfig build

On 2020/11/28 9:56, Jakub Kicinski wrote: > On Sat, 28 Nov 2020 12:28:19 +1100 Stephen Rothwell wrote: >> There are 2 drivers that have arrays of packed structures that contain >> pointers that end up at unaligned offsets. These produce warnings in >> the PowerPC allyesconfig build like this: >> >

Re: [PATCH] powerpc: fix the allyesconfig build

On Sat, 28 Nov 2020 12:28:19 +1100 Stephen Rothwell wrote: > There are 2 drivers that have arrays of packed structures that contain > pointers that end up at unaligned offsets. These produce warnings in > the PowerPC allyesconfig build like this: > > WARNING: 148 bad relocations > ce56510

[PATCH] powerpc: fix the allyesconfig build

There are 2 drivers that have arrays of packed structures that contain pointers that end up at unaligned offsets. These produce warnings in the PowerPC allyesconfig build like this: WARNING: 148 bad relocations ce56510b R_PPC64_UADDR64 .rodata+0x01c72378 ce565126 R_PPC64

[powerpc:next-test] BUILD SUCCESS 278f4532318c176ef8a22a78f45a8c8a30abe40b

powerpc allyesconfig powerpc allmodconfig powerpc allnoconfig i386 randconfig-a004-20201127 i386 randconfig-a003-20201127 i386 randconfig-a002-20201127 i386

[powerpc:merge] BUILD SUCCESS 2551450071df2dabd7134e548ac209688ac6741d

01126 i386 randconfig-a003-20201126 i386 randconfig-a002-20201126 i386 randconfig-a005-20201126 i386 randconfig-a001-20201126 i386 randconfig-a006-20201126 i386 randconfig-a004-20201127 i386 randconfig-a003-202

[powerpc:fixes-test] BUILD SUCCESS 10f78fd0dabbc3856ddd67b09a46abdedb045913

mips allmodconfig powerpc allyesconfig powerpc allmodconfig powerpc allnoconfig i386 randconfig-a004-20201127 i386 randconfig-a003-20201127 i386

[PATCH] ALSA: ppc: remove redundant checks in PS3 driver probe

The check for the FW_FEATURE_PS3_LV1 firmware feature is already performed in ps3_system_bus_init() before registering the driver. So if the probe function is actually used, this feature is already known to be available. The check for the match id is also superfluous; the condition is always true

Re: [PATCH] ALSA: ppc: remove redundant checks in PS3 driver probe

On 11/27/20 7:22 AM, Leonard Goehrs wrote: > The check for the FW_FEATURE_PS3_LV1 firmware feature is already performed > in ps3_system_bus_init() before registering the driver. So if the probe > function is actually used, this feature is already known to be available. > > The check for the match

Re: [PATCH 2/2] powerpc/ps3: make system bus's remove and shutdown callbacks return void

On 11/26/20 8:59 AM, Uwe Kleine-König wrote: > The driver core ignores the return value of struct device_driver::remove > because there is only little that can be done. For the shutdown callback > it's ps3_system_bus_shutdown() which ignores the return value. > > To simplify the quest to make stru

Re: [PATCH 1/2] ALSA: ppc: drop if block with always false condition

Hi Uwe, On 11/26/20 8:59 AM, Uwe Kleine-König wrote: > The remove callback is only called for devices that were probed > successfully before. As the matching probe function cannot complete > without error if dev->match_id != PS3_MATCH_ID_SOUND, we don't have to > check this here. > > Signed-off-b

Re: [GIT PULL] Please pull powerpc/linux.git powerpc-5.10-4 tag

The pull request you sent on Fri, 27 Nov 2020 23:45:35 +1100: > https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git > tags/powerpc-5.10-4 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/95e1c7b1dd4a91451040ff0f41c5b5173503a38e Thank you! -- Deet-doot-d

Re: [PATCH 13/13] ibmvfc: register Sub-CRQ handles with VIOS during channel setup

Reviewed-by: Brian King -- Brian King Power Linux I/O IBM Linux Technology Center

Re: [PATCH 12/13] ibmvfc: send commands down HW Sub-CRQ when channelized

Reviewed-by: Brian King -- Brian King Power Linux I/O IBM Linux Technology Center

Re: [PATCH 10/13] ibmvfc: advertise client support for using hardware channels

Reviewed-by: Brian King -- Brian King Power Linux I/O IBM Linux Technology Center

Re: [PATCH 11/13] ibmvfc: set and track hw queue in ibmvfc_event struct

Reviewed-by: Brian King -- Brian King Power Linux I/O IBM Linux Technology Center

Re: [PATCH 09/13] ibmvfc: implement channel enquiry and setup commands

On 11/25/20 7:48 PM, Tyrel Datwyler wrote: > --- a/drivers/scsi/ibmvscsi/ibmvfc.c > +++ b/drivers/scsi/ibmvscsi/ibmvfc.c > @@ -4462,6 +4464,118 @@ static void ibmvfc_discover_targets(struct > ibmvfc_host *vhost) > ibmvfc_link_down(vhost, IBMVFC_LINK_DEAD); > } > > +static void ib

Re: [PATCH 08/13] ibmvfc: map/request irq and register Sub-CRQ interrupt handler

Reviewed-by: Brian King -- Brian King Power Linux I/O IBM Linux Technology Center

Re: [PATCH 07/13] ibmvfc: define Sub-CRQ interrupt handler routine

Reviewed-by: Brian King -- Brian King Power Linux I/O IBM Linux Technology Center

Re: [PATCH 06/13] ibmvfc: add handlers to drain and complete Sub-CRQ responses

On 11/25/20 7:48 PM, Tyrel Datwyler wrote: > The logic for iterating over the Sub-CRQ responses is similiar to that > of the primary CRQ. Add the necessary handlers for processing those > responses. > > Signed-off-by: Tyrel Datwyler > --- > drivers/scsi/ibmvscsi/ibmvfc.c | 72 +++

Re: [PATCH 05/13] ibmvfc: add Sub-CRQ IRQ enable/disable routine

Reviewed-by: Brian King -- Brian King Power Linux I/O IBM Linux Technology Center

Re: [PATCH 04/13] ibmvfc: add alloc/dealloc routines for SCSI Sub-CRQ Channels

On 11/25/20 7:48 PM, Tyrel Datwyler wrote: > Allocate a set of Sub-CRQs in advance. During channel setup the client > and VIOS negotiate the number of queues the VIOS supports and the number > that the client desires to request. Its possible that the final channel > resources allocated is less than

Re: [PATCH 03/13] ibmvfc: add Subordinate CRQ definitions

Reviewed-by: Brian King -- Brian King Power Linux I/O IBM Linux Technology Center

Re: [PATCH 02/13] ibmvfc: define hcall wrapper for registering a Sub-CRQ

Reviewed-by: Brian King -- Brian King Power Linux I/O IBM Linux Technology Center

Re: [PATCH 01/13] ibmvfc: add vhost fields and defaults for MQ enablement

On 11/25/20 7:48 PM, Tyrel Datwyler wrote: > diff --git a/drivers/scsi/ibmvscsi/ibmvfc.h b/drivers/scsi/ibmvscsi/ibmvfc.h > index 9d58cfd774d3..8225bdbb127e 100644 > --- a/drivers/scsi/ibmvscsi/ibmvfc.h > +++ b/drivers/scsi/ibmvscsi/ibmvfc.h > @@ -41,6 +41,11 @@ > #define IBMVFC_DEFAULT_LOG_LEVEL

Re: [PATCH 0/8] Rid W=1 warnings in Net

On Thu, 26 Nov 2020 13:38:45 + Lee Jones wrote: > Resending the stragglers. > > This set is part of a larger effort attempting to clean-up W=1 > kernel builds, which are currently overwhelmingly riddled with > niggly little warnings. This set doesn't apply to net-next, please rebase.

Re: [PATCH] ALSA: ppc: remove redundant checks in PS3 driver probe

Hallo Leonard, On Fri, Nov 27, 2020 at 04:22:59PM +0100, Leonard Goehrs wrote: > The check for the FW_FEATURE_PS3_LV1 firmware feature is already performed > in ps3_system_bus_init() before registering the driver. So if the probe > function is actually used, this feature is already known to be ava

Re: powerpc 5.10-rcN boot failures with RCU_SCALE_TEST=m

> Hi all, > > I'm having some difficulty tracking down a bug. > > Some configurations of the powerpc kernel since somewhere in the 5.10 > merge window fail to boot on some ppc64 systems. They hang while trying > to bring up SMP. It seems to depend on the RCU_SCALE/PERF_TEST option. > (It was rena

[powerpc:next-test 89/109] arch/powerpc/kernel/vdso.c:192:1-3: WARNING: PTR_ERR_OR_ZERO can be used

-c003-20201127 (attached as .config) compiler: powerpc-linux-gcc (GCC) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot "coccinelle warnings: (new ones prefixed by >>)" >> arch/powerpc/kernel/vdso.c:192:1-3: WARNING: PTR_E

Re: powerpc 5.10-rcN boot failures with RCU_SCALE_TEST=m

On Fri, Nov 27, 2020 at 01:02:29PM +1100, Daniel Axtens wrote: > Hi all, > > I'm having some difficulty tracking down a bug. > > Some configurations of the powerpc kernel since somewhere in the 5.10 > merge window fail to boot on some ppc64 systems. They hang while trying > to bring up SMP. It se

[PATCH] powerpc/vdso: fix ptr_ret.cocci warnings

From: kernel test robot arch/powerpc/kernel/vdso.c:192:1-3: WARNING: PTR_ERR_OR_ZERO can be used Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR Generated by: scripts/coccinelle/api/ptr_ret.cocci Fixes: 08bbcbede11f ("powerpc/vdso: Move to _install_special_mapping() and remove arc

[GIT PULL] Please pull powerpc/linux.git powerpc-5.10-4 tag

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi Linus, Please pull some more powerpc fixes for 5.10. Note this includes a merge of the powerpc-cve-2020-4788 tag, which you already have, so that I could fix a build break it introduced. That merge should be a nop from your POV. cheers The fo

[Bug 203699] Kernel 5.2-rc1 fails to boot on a Mac Mini G4: dt_headr_start=0x01501000

https://bugzilla.kernel.org/show_bug.cgi?id=203699 Michael Ellerman (mich...@ellerman.id.au) changed: What|Removed |Added Status|NEW |NEEDINFO

[Bug 209869] Kernel 5.10-rc1 fails to boot on a PowerMac G4 3,6 at an early stage

https://bugzilla.kernel.org/show_bug.cgi?id=209869 Michael Ellerman (mich...@ellerman.id.au) changed: What|Removed |Added Status|NEW |RESOLVED

[PATCH v5] PCI: Unify ECAM constants in native PCI Express drivers

Unify ECAM-related constants into a single set of standard constants defining memory address shift values for the byte-level address that can be used when accessing the PCI Express Configuration Space, and then move native PCI Express controller drivers to use newly introduced definitions retiring

Re: [PATCH 1/2] ALSA: ppc: drop if block with always false condition

On Fri, Nov 27, 2020 at 09:35:39AM +0100, Geert Uytterhoeven wrote: > Hi Uwe, > > On Thu, Nov 26, 2020 at 6:03 PM Uwe Kleine-König > wrote: > > The remove callback is only called for devices that were probed > > successfully before. As the matching probe function cannot complete > > without error

Re: [PATCH 2/2] powerpc/ps3: make system bus's remove and shutdown callbacks return void

Hi Uwe, On Thu, Nov 26, 2020 at 6:03 PM Uwe Kleine-König wrote: > The driver core ignores the return value of struct device_driver::remove > because there is only little that can be done. For the shutdown callback > it's ps3_system_bus_shutdown() which ignores the return value. > > To simplify th

Re: [PATCH 1/2] ALSA: ppc: drop if block with always false condition

Hi Uwe, On Thu, Nov 26, 2020 at 6:03 PM Uwe Kleine-König wrote: > The remove callback is only called for devices that were probed > successfully before. As the matching probe function cannot complete > without error if dev->match_id != PS3_MATCH_ID_SOUND, we don't have to > check this here. > > S