Hallo Leonard, On Fri, Nov 27, 2020 at 04:22:59PM +0100, Leonard Goehrs wrote: > The check for the FW_FEATURE_PS3_LV1 firmware feature is already performed > in ps3_system_bus_init() before registering the driver. So if the probe > function is actually used, this feature is already known to be available. > > The check for the match id is also superfluous; the condition is always > true because the bus' match function (ps3_system_bus_match()) only > considers this driver for devices having: > dev->match_id == snd_ps3_bus_driver_info.match_id. > > Suggested-by: Geert Uytterhoeven <ge...@linux-m68k.org> > Signed-off-by: Leonard Goehrs <l.goe...@pengutronix.de>
Reviewed-by: Uwe Kleine-König <u.kleine-koe...@pengutronix.de> Thanks for picking this up. Best regards and have a nice week-end, Uwe Kleine-König -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ |
signature.asc
Description: PGP signature
