Re: [PATCH 1/2] cpufreq/powernv: Fix use-after-free

2020-02-24 Thread Andrew Donnellan
On 6/2/20 5:26 pm, Oliver O'Halloran wrote: The cpufreq driver has a use-after-free that we can hit if: a) There's an OCC message pending when the notifier is registered, and b) The cpufreq driver fails to register with the core. When a) occurs the notifier schedules a workqueue item to handle

Re: [PATCH 2/2] cpufreq/powernv: Fix unsafe notifiers

2020-02-24 Thread Gautham R Shenoy
On Thu, Feb 06, 2020 at 05:26:22PM +1100, Oliver O'Halloran wrote: > The PowerNV cpufreq driver registers two notifiers: one to catch throttle > messages from the OCC and one to bump the CPU frequency back to normal > before a reboot. Both require the cpufreq driver to be registered in order > to f

Re: [PATCH 1/2] cpufreq/powernv: Fix use-after-free

2020-02-24 Thread Gautham R Shenoy
On Thu, Feb 06, 2020 at 05:26:21PM +1100, Oliver O'Halloran wrote: > The cpufreq driver has a use-after-free that we can hit if: > > a) There's an OCC message pending when the notifier is registered, and > b) The cpufreq driver fails to register with the core. > > When a) occurs the notifier sche

Re: [linux-next/mainline][bisected 3acac06][ppc] Oops when unloading mpt3sas driver

2020-02-24 Thread Abdul Haleem
On Fri, 2020-01-17 at 18:21 +0530, Abdul Haleem wrote: > On Thu, 2020-01-16 at 09:44 -0800, Christoph Hellwig wrote: > > Hi Abdul, > > > > I think the problem is that mpt3sas has some convoluted logic to do > > some DMA allocations with a 32-bit coherent mask, and then switches > > to a 63 or 64 b

[PATCH] powerpc/64s: Fix section mismatch warnings from boot code

2020-02-24 Thread Michael Ellerman
We currently have two section mismatch warnings: The function __boot_from_prom() references the function __init prom_init(). The function start_here_common() references the function __init start_kernel(). The warnings are correct, we do have branches from non-init code into init code, wh

Re: [PATCH v3 11/27] powerpc: Enable the OpenCAPI Persistent Memory driver for powernv_defconfig

2020-02-24 Thread Andrew Donnellan
On 21/2/20 2:27 pm, Alastair D'Silva wrote: From: Alastair D'Silva This patch enables the OpenCAPI Persistent Memory driver, as well as DAX support, for the 'powernv' platform. defconfig, not platform DAX is not a strict requirement for the functioning of the driver, but it is likely that

Re: [PATCH 1/2] powerpc/powernv: Treat an empty reboot string as default

2020-02-24 Thread Alexey Kardashevskiy
On 24/02/2020 21:04, Segher Boessenkool wrote: > On Mon, Feb 24, 2020 at 01:32:28PM +1100, Alexey Kardashevskiy wrote: >> On 17/02/2020 13:48, Oliver O'Halloran wrote: >>> Treat an empty reboot cmd string the same as a NULL string. This squashes a >>> spurious unsupported reboot message that som

Re: [PATCH 5/8] powerpc: Drop XILINX MAINTAINERS entry

2020-02-24 Thread Grant Likely
On 24/02/2020 23:31, Michael Ellerman wrote: This has been orphaned for ~7 years, remove it. Cc: Grant Likely Signed-off-by: Michael Ellerman Acked-by: Grant Likely --- MAINTAINERS | 6 -- 1 file changed, 6 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 939da2ac08db.

Re: [PATCH][next] toshiba: Replace zero-length array with flexible-array member

2020-02-24 Thread Geoff Levand
On 2/24/20 8:32 AM, Gustavo A. R. Silva wrote: > The current codebase makes use of the zero-length array language > extension to the C90 standard, but the preferred mechanism to declare > variable-length types such as these ones is a flexible array member[1][2], > introduced in C99: Seems fine. A

Re: [PATCH 3/8] powerpc: Remove PA SEMI MAINTAINERS entries

2020-02-24 Thread Olof Johansson
On Mon, Feb 24, 2020 at 3:31 PM Michael Ellerman wrote: > > The PA SEMI entries have been orphaned for 3 ½ years, so fold them > into the main POWERPC entry. The result of get_maintainer.pl is more > or less unchanged. > > Cc: Olof Johansson > Signed-off-by: Michael Ellerman Acked-by: Olof Joha

Re: [PATCH 4/8] powerpc: Mark 4xx as Orphan in MAINTAINERS

2020-02-24 Thread Alistair Popple
Acked-by: Alistair Popple On Tuesday, 25 February 2020 10:31:42 AM AEDT Michael Ellerman wrote: > The 4xx platforms are no longer maintained. > > Cc: Alistair Popple > Cc: Matt Porter > Signed-off-by: Michael Ellerman > --- > MAINTAINERS | 5 + > 1 file changed, 1 insertion(+), 4 deletio

Re: [PATCH] powerpc/vdso: remove deprecated VDS64_HAS_DESCRIPTORS references

2020-02-24 Thread Michael Ellerman
Joe Lawrence writes: > The original 2005 patch that introduced the powerpc vdso, pre-git > ("ppc64: Implement a vDSO and use it for signal trampoline") notes that: > > ... symbols exposed by the vDSO aren't "normal" function symbols, apps > can't be expected to link against them directly, the

[PATCH 8/8] powerpc: Update 83xx/85xx MAINTAINERS entry

2020-02-24 Thread Michael Ellerman
Scott said he was still maintaining this "sort of", so change the status to Odd Fixes. Kumar has long ago moved on to greener pastures. Remove the dead penguinppc.org link. Cc: Scott Wood Cc: Kumar Gala Signed-off-by: Michael Ellerman --- MAINTAINERS | 4 +--- 1 file changed, 1 insertion(+),

[PATCH 7/8] powerpc: Update powermac MAINTAINERS entry

2020-02-24 Thread Michael Ellerman
Ben is no longer actively maintaining the powermac code, but we know where to find him if something really needs attention. The www.penguinppc.org link is dead so remove it. Cc: Benjamin Herrenschmidt Signed-off-by: Michael Ellerman --- MAINTAINERS | 3 +-- 1 file changed, 1 insertion(+), 2 de

[PATCH 6/8] powerpc: Update MPC5XXX MAINTAINERS entry

2020-02-24 Thread Michael Ellerman
It's several years since the last commit from Anatolij, so mark MPC5XXX as "Odd Fixes" rather than "Maintained". Also the git link no longer works so remove it. Cc: Anatolij Gustschin Signed-off-by: Michael Ellerman --- MAINTAINERS | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff

[PATCH 5/8] powerpc: Drop XILINX MAINTAINERS entry

2020-02-24 Thread Michael Ellerman
This has been orphaned for ~7 years, remove it. Cc: Grant Likely Signed-off-by: Michael Ellerman --- MAINTAINERS | 6 -- 1 file changed, 6 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 939da2ac08db..d5db5cac5a39 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -9668,12 +9668,6 @@

[PATCH 4/8] powerpc: Mark 4xx as Orphan in MAINTAINERS

2020-02-24 Thread Michael Ellerman
The 4xx platforms are no longer maintained. Cc: Alistair Popple Cc: Matt Porter Signed-off-by: Michael Ellerman --- MAINTAINERS | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 5c4f37c41188..939da2ac08db 100644 --- a/MAINTAINERS +++ b/MAIN

[PATCH 3/8] powerpc: Remove PA SEMI MAINTAINERS entries

2020-02-24 Thread Michael Ellerman
The PA SEMI entries have been orphaned for 3 ½ years, so fold them into the main POWERPC entry. The result of get_maintainer.pl is more or less unchanged. Cc: Olof Johansson Signed-off-by: Michael Ellerman --- MAINTAINERS | 19 ++- 1 file changed, 2 insertions(+), 17 deletions(-

[PATCH 2/8] powerpc: Update wiki link in MAINTAINERS

2020-02-24 Thread Michael Ellerman
The wiki has moved, update the link. Signed-off-by: Michael Ellerman --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 339bc3e53862..435e4efc9a32 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -9604,7 +9604,7 @@ LINUX FOR POWERPC (

[PATCH 1/8] powerpc: Update MAINTAINERS

2020-02-24 Thread Michael Ellerman
A while back Paul pointed out I'd been maintaining the tree more or less solo for over five years, so perhaps it's time to update the MAINTAINERS entry. Ben & Paul still wrote most of the code, so keep them as Reviewers so they still get Cc'ed on things. But if you're wondering why your patch hasn

Re: [PATCH][next] toshiba: Replace zero-length array with flexible-array member

2020-02-24 Thread David Miller
From: "Gustavo A. R. Silva" Date: Mon, 24 Feb 2020 10:32:52 -0600 > The current codebase makes use of the zero-length array language > extension to the C90 standard, but the preferred mechanism to declare > variable-length types such as these ones is a flexible array member[1][2], > introduced in

[PATCH] powerpc/vdso: remove deprecated VDS64_HAS_DESCRIPTORS references

2020-02-24 Thread Joe Lawrence
The original 2005 patch that introduced the powerpc vdso, pre-git ("ppc64: Implement a vDSO and use it for signal trampoline") notes that: ... symbols exposed by the vDSO aren't "normal" function symbols, apps can't be expected to link against them directly, the vDSO's are both seen as if th

[PATCH] powerpc/kprobes: Use probe_address() to read instructions

2020-02-24 Thread Christophe Leroy
In order to avoid Oopses, use probe_address() to read the instruction at the address where the trap happened. Signed-off-by: Christophe Leroy --- arch/powerpc/kernel/kprobes.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/arch/powerpc/kernel/kprobes.c b/arch/powe

[PATCH v2] powerpc/kprobes: Blacklist functions running with MMU disabled on PPC32

2020-02-24 Thread Christophe Leroy
kprobe does not handle events happening in real mode, all functions running with MMU disabled have to be blacklisted. As already done for PPC64, do it for PPC32. Signed-off-by: Christophe Leroy --- v2: - Don't rename nonrecoverable as local, mark it noprobe instead. - Add missing linux/kprobes.h

[PATCH][next] toshiba: Replace zero-length array with flexible-array member

2020-02-24 Thread Gustavo A. R. Silva
The current codebase makes use of the zero-length array language extension to the C90 standard, but the preferred mechanism to declare variable-length types such as these ones is a flexible array member[1][2], introduced in C99: struct foo { int stuff; struct boo array[]; }; By ma

[PATCH] crypto: Replace zero-length array with flexible-array member

2020-02-24 Thread Gustavo A. R. Silva
The current codebase makes use of the zero-length array language extension to the C90 standard, but the preferred mechanism to declare variable-length types such as these ones is a flexible array member[1][2], introduced in C99: struct foo { int stuff; struct boo array[]; }; By ma

Re: vdso function descriptors (VDS64_HAS_DESCRIPTORS)?

2020-02-24 Thread Benjamin Herrenschmidt
On Mon, 2020-02-24 at 10:20 -0500, Joe Lawrence wrote: > On > > I don't remember why :-) I think I didn't want to mess with the OPD > > fixup in glibc back then. > > > > Does it make sense to just drop the unused VDS64_HAS_DESCRIPTORS code > then? I'd think so yes. Cheers, Ben.

Re: vdso function descriptors (VDS64_HAS_DESCRIPTORS)?

2020-02-24 Thread Joe Lawrence
On 2/24/20 5:17 AM, Benjamin Herrenschmidt wrote: On Sat, 2020-02-22 at 18:07 -0600, Segher Boessenkool wrote: so I don't believe they are ever used by default -- in this case V_FUNCTION_BEGIN doesn't add to the .opd section with .name, .TOC base, etc. Manually setting VDS64_HAS_DESCRIPTORS re

Re: [RESEND PATCH v2 9/9] ath5k: Constify ioreadX() iomem argument (as in generic implementation)

2020-02-24 Thread Krzysztof Kozlowski
On Mon, Feb 24, 2020 at 01:54:00PM +0100, Geert Uytterhoeven wrote: > Hi Krzysztof, > > On Mon, Feb 24, 2020 at 1:47 PM Krzysztof Kozlowski wrote: > > On Thu, Feb 20, 2020 at 10:48:33AM +0100, Jiri Slaby wrote: > > > On 19. 02. 20, 18:50, Krzysztof Kozlowski wrote: > > > > The ioreadX() helpers h

RE: [RESEND PATCH v2 9/9] ath5k: Constify ioreadX() iomem argument (as in generic implementation)

2020-02-24 Thread David Laight
From: Geert Uytterhoeven > Sent: 24 February 2020 12:54 > To: Krzysztof Kozlowski ... > > > > diff --git a/drivers/net/wireless/ath/ath5k/ahb.c > > > > b/drivers/net/wireless/ath/ath5k/ahb.c > > > > index 2c9cec8b53d9..8bd01df369fb 100644 > > > > --- a/drivers/net/wireless/ath/ath5k/ahb.c > > > >

Re: [RESEND PATCH v2 9/9] ath5k: Constify ioreadX() iomem argument (as in generic implementation)

2020-02-24 Thread Geert Uytterhoeven
Hi Krzysztof, On Mon, Feb 24, 2020 at 1:47 PM Krzysztof Kozlowski wrote: > On Thu, Feb 20, 2020 at 10:48:33AM +0100, Jiri Slaby wrote: > > On 19. 02. 20, 18:50, Krzysztof Kozlowski wrote: > > > The ioreadX() helpers have inconsistent interface. On some architectures > > > void *__iomem address a

Re: [RESEND PATCH v2 9/9] ath5k: Constify ioreadX() iomem argument (as in generic implementation)

2020-02-24 Thread Krzysztof Kozlowski
On Thu, Feb 20, 2020 at 10:48:33AM +0100, Jiri Slaby wrote: > On 19. 02. 20, 18:50, Krzysztof Kozlowski wrote: > > The ioreadX() helpers have inconsistent interface. On some architectures > > void *__iomem address argument is a pointer to const, on some not. > > > > Implementations of ioreadX() d

Re: [PATCH] powerpc: Include .BTF section

2020-02-24 Thread Michael Ellerman
"Naveen N. Rao" writes: > Michael Ellerman wrote: >> "Naveen N. Rao" writes: >>> Selecting CONFIG_DEBUG_INFO_BTF results in the below warning from ld: >>> ld: warning: orphan section `.BTF' from `.btf.vmlinux.bin.o' being placed >>> in section `.BTF' >>> >>> Include .BTF section in vmlinux exp

Re: [PATCH 3/7] docs: fix broken references to text files

2020-02-24 Thread Federico Vaga
On Saturday, February 22, 2020 10:00:03 AM CET Mauro Carvalho Chehab wrote: > Several references got broken due to txt to ReST conversion. > > Several of them can be automatically fixed with: > > scripts/documentation-file-ref-check --fix > > Signed-off-by: Mauro Carvalho Chehab > --- >

Re: [RFC PATCH v2 00/12] Reduce ifdef mess in ptrace

2020-02-24 Thread Michael Ellerman
Christophe Leroy writes: > Le 24/02/2020 à 03:15, Michael Neuling a écrit : >> Christophe, >>> Le 28/06/2019 à 17:47, Christophe Leroy a écrit : The purpose of this series is to reduce the amount of #ifdefs in ptrace.c >>> >>> Any feedback on this series which aims at fixing the issue yo

Re: [RFC PATCH v2 04/12] powerpc/ptrace: split out VSX related functions.

2020-02-24 Thread Michael Ellerman
Christophe Leroy writes: > diff --git a/arch/powerpc/kernel/ptrace/ptrace-novsx.c > b/arch/powerpc/kernel/ptrace/ptrace-novsx.c > new file mode 100644 > index ..55fbbb4aa9d7 > --- /dev/null > +++ b/arch/powerpc/kernel/ptrace/ptrace-novsx.c > @@ -0,0 +1,83 @@ > +/* SPDX-License-Identif

Re: [RFC PATCH v2 02/12] powerpc/ptrace: drop unnecessary #ifdefs CONFIG_PPC64

2020-02-24 Thread Michael Ellerman
Christophe Leroy writes: > Drop a bunch of #ifdefs CONFIG_PPC64 that are not vital. > > Signed-off-by: Christophe Leroy > --- > arch/powerpc/include/asm/ptrace.h | 9 - > arch/powerpc/include/uapi/asm/ptrace.h | 12 > arch/powerpc/kernel/ptrace/ptrace.c| 24 +++

Re: vdso function descriptors (VDS64_HAS_DESCRIPTORS)?

2020-02-24 Thread Benjamin Herrenschmidt
On Sat, 2020-02-22 at 18:07 -0600, Segher Boessenkool wrote: > > > > so I don't believe they are ever used by default -- in this case > > V_FUNCTION_BEGIN doesn't add to the .opd section with .name, .TOC base, > > etc. > > > > Manually setting VDS64_HAS_DESCRIPTORS results in a vdso64.so in which

Re: [RESEND PATCH v5 2/5] arm64/crash_core: Export TCR_EL1.T1SZ in vmcoreinfo

2020-02-24 Thread Bhupesh Sharma
Hi Amit, On Fri, Feb 21, 2020 at 2:36 PM Amit Kachhap wrote: > > Hi Bhupesh, > > On 1/13/20 5:44 PM, Bhupesh Sharma wrote: > > Hi James, > > > > On 01/11/2020 12:30 AM, Dave Anderson wrote: > >> > >> - Original Message - > >>> Hi Bhupesh, > >>> > >>> On 25/12/2019 19:01, Bhupesh Sharma wr

Re: [PATCH 1/2] powerpc/powernv: Treat an empty reboot string as default

2020-02-24 Thread Segher Boessenkool
On Mon, Feb 24, 2020 at 01:32:28PM +1100, Alexey Kardashevskiy wrote: > On 17/02/2020 13:48, Oliver O'Halloran wrote: > > Treat an empty reboot cmd string the same as a NULL string. This squashes a > > spurious unsupported reboot message that sometimes gets out when using > > xmon. > > -

Re: [PATCH v3 6/7] mm/memory_hotplug: Add pgprot_t to mhp_params

2020-02-24 Thread David Hildenbrand
On 21.02.20 19:25, Logan Gunthorpe wrote: > devm_memremap_pages() is currently used by the PCI P2PDMA code to create > struct page mappings for IO memory. At present, these mappings are created > with PAGE_KERNEL which implies setting the PAT bits to be WB. However, on > x86, an mtrr register will

Re: [PATCH][next] soc: fsl: dpio: fix dereference of pointer p before null check

2020-02-24 Thread Dan Carpenter
On Fri, Feb 21, 2020 at 11:11:43PM +, Colin King wrote: > --- > drivers/soc/fsl/dpio/qbman-portal.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/soc/fsl/dpio/qbman-portal.c > b/drivers/soc/fsl/dpio/qbman-portal.c > index 740ee0d19582..d1f49caa5b13 100

RE: [PATCH v6 2/3] arm64: dts: ls1028a: Add PCIe controller DT nodes

2020-02-24 Thread Z.q. Hou
Hi Michael and Shawn, I'll update the patch with iommu-map property. Thanks, Zhiqiang > -Original Message- > From: Michael Walle > Sent: 2020年2月24日 16:54 > To: Shawn Guo > Cc: Xiaowei Bao ; Z.q. Hou > ; bhelg...@google.com; > devicet...@vger.kernel.org; Leo Li ; > linux-arm-ker...@list

Re: [PATCH v3 2/7] mm/memory_hotplug: Rename mhp_restrictions to mhp_params

2020-02-24 Thread David Hildenbrand
On 21.02.20 19:24, Logan Gunthorpe wrote: > The mhp_restrictions struct really doesn't specify anything resembling > a restriction anymore so rename it to be mhp_params as it is a list > of extended parameters. > > Signed-off-by: Logan Gunthorpe Reviewed-by: David Hildenbrand -- Thanks, Dav

Re: [5.6.0-rc2-next-20200218/powerpc] Boot failure on POWER9

2020-02-24 Thread Michal Hocko
On Sat 22-02-20 03:38:11, Cristopher Lameter wrote: > On Tue, 18 Feb 2020, Michal Hocko wrote: > > > Anyway, I do not think it is expected that kmalloc_node just blows up > > on those nodes. The page allocator simply falls back to the closest > > node. Something for kmalloc maintainers I believe.

Re: [PATCH v6 2/3] arm64: dts: ls1028a: Add PCIe controller DT nodes

2020-02-24 Thread Michael Walle
Hi Shawn, all, Am 2020-02-24 09:43, schrieb Shawn Guo: On Mon, Feb 24, 2020 at 09:11:05AM +0100, Michael Walle wrote: Hi Xiaowei, Hi Shawn, > LS1028a implements 2 PCIe 3.0 controllers. Patch 1/3 and 3/3 are in Linus' tree but nobody seems to care about this patch anymore :( This doesn't wo

Re: [PATCH v2 3/3] ASoC: fsl_easrc: Add EASRC ASoC CPU DAI and platform drivers

2020-02-24 Thread S.j. Wang
Hi > > > > Signed-off-by: Shengjiu Wang > > --- > > sound/soc/fsl/Kconfig | 10 + > > sound/soc/fsl/Makefile |2 + > > sound/soc/fsl/fsl_asrc_common.h |1 + > > sound/soc/fsl/fsl_easrc.c | 2265 +++ > > sound/soc/fsl/fsl_easrc.h

Re: [PATCH v6 2/3] arm64: dts: ls1028a: Add PCIe controller DT nodes

2020-02-24 Thread Shawn Guo
On Mon, Feb 24, 2020 at 09:11:05AM +0100, Michael Walle wrote: > Hi Xiaowei, Hi Shawn, > > > LS1028a implements 2 PCIe 3.0 controllers. > > Patch 1/3 and 3/3 are in Linus' tree but nobody seems to care about this patch > anymore :( > > This doesn't work well with the IOMMU, because the iommu-map

Re: [PATCH v6 2/3] arm64: dts: ls1028a: Add PCIe controller DT nodes

2020-02-24 Thread Michael Walle
Hi Xiaowei, Hi Shawn, > LS1028a implements 2 PCIe 3.0 controllers. Patch 1/3 and 3/3 are in Linus' tree but nobody seems to care about this patch anymore :( This doesn't work well with the IOMMU, because the iommu-map property is missing. The bootloader needs the &smmu phandle to fixup the entry