Hi Michael and Shawn, I'll update the patch with iommu-map property.
Thanks, Zhiqiang > -----Original Message----- > From: Michael Walle <mich...@walle.cc> > Sent: 2020年2月24日 16:54 > To: Shawn Guo <shawn...@kernel.org> > Cc: Xiaowei Bao <xiaowei....@nxp.com>; Z.q. Hou > <zhiqiang....@nxp.com>; bhelg...@google.com; > devicet...@vger.kernel.org; Leo Li <leoyang...@nxp.com>; > linux-arm-ker...@lists.infradead.org; linux-ker...@vger.kernel.org; > linux-...@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; > lorenzo.pieral...@arm.com; mark.rutl...@arm.com; M.h. Lian > <minghuan.l...@nxp.com>; Mingkai Hu <mingkai...@nxp.com>; > robh...@kernel.org; Roy Zang <roy.z...@nxp.com> > Subject: Re: [PATCH v6 2/3] arm64: dts: ls1028a: Add PCIe controller DT > nodes > > Hi Shawn, all, > > Am 2020-02-24 09:43, schrieb Shawn Guo: > > On Mon, Feb 24, 2020 at 09:11:05AM +0100, Michael Walle wrote: > >> Hi Xiaowei, Hi Shawn, > >> > >> > LS1028a implements 2 PCIe 3.0 controllers. > >> > >> Patch 1/3 and 3/3 are in Linus' tree but nobody seems to care about > >> this patch anymore :( > >> > >> This doesn't work well with the IOMMU, because the iommu-map property > >> is missing. The bootloader needs the &smmu phandle to fixup the > >> entry. > >> See > >> below. > >> > >> Shawn, will you add this patch to your tree once its fixed, > >> considering it just adds the device tree node for the LS1028A? > > > > The patch/thread is a bit aged. You may want to send an updated patch > > for discussion. > > So should I just pick up the patch add my two fixes and send it again? > What about > the Signed-off-by tags? Leave them? Replace them? Add mine? > > -michael
