Re: [PATCH] mm: Generalize and rename notify_page_fault() as kprobe_page_fault()

2019-06-29 Thread Anshuman Khandual
Hello Guenter, On 06/29/2019 08:20 PM, Guenter Roeck wrote: > Hi, > > On Thu, Jun 13, 2019 at 03:37:24PM +0530, Anshuman Khandual wrote: >> Architectures which support kprobes have very similar boilerplate around >> calling kprobe_fault_handler(). Use a helper function in kprobes.h to unify >> th

Re: [PATCH] i2c: remove casting dma_alloc

2019-06-29 Thread Jochen Friedrich
Hi Wolfram,yes, I'm still here. However, I don't have the hardware anymore to test the patch.Thanks, Jochen Am 29.06.2019 13:34 schrieb Wolfram Sang :On Sun, Jun 23, 2019 at 11:13:53PM +0200, Vasyl Gomonovych wrote: > From: Vasyl > > Generated by:  alloc_cast.cocci > > Signed-off-by: Vasyl

Re: [GIT PULL] Please pull powerpc/linux.git powerpc-5.2-7 tag

2019-06-29 Thread pr-tracker-bot
The pull request you sent on Sat, 29 Jun 2019 22:26:26 +1000: > https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git > tags/powerpc-5.2-7 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/39132f746eceed6beecb16c7b79600fb54eb8b2b Thank you! -- Deet-doot-do

Re: [PATCH v3 1/3] powerpc/pseries: Update SCM hcall op-codes in hvcall.h

2019-06-29 Thread Vaibhav Jain
Thanks for reviewing this patch Mpe. Michael Ellerman writes: > "Oliver O'Halloran" writes: >> On Fri, Jun 28, 2019 at 1:39 PM Michael Ellerman wrote: >>> >>> Vaibhav Jain writes: >>> > *snip* >>> >>> How can we be changing the meaning of HCALL numbers without breaking all >>> existing usages

[PATCH v4 3/3] powerpc/papr_scm: Force a scm-unbind if initial scm-bind fails

2019-06-29 Thread Vaibhav Jain
In some cases initial bind of scm memory for an lpar can fail if previously it wasn't released using a scm-unbind hcall. This situation can arise due to panic of the previous kernel or forced lpar fadump. In such cases the H_SCM_BIND_MEM return a H_OVERLAP error. To mitigate such cases the patch u

[PATCH v4 2/3] powerpc/papr_scm: Update drc_pmem_unbind() to use H_SCM_UNBIND_ALL

2019-06-29 Thread Vaibhav Jain
The new hcall named H_SCM_UNBIND_ALL has been introduce that can unbind all or specific scm memory assigned to an lpar. This is more efficient than using H_SCM_UNBIND_MEM as currently we don't support partial unbind of scm memory. Hence this patch proposes following changes to drc_pmem_unbind():

[PATCH v4 1/3] powerpc/pseries: Update SCM hcall op-codes in hvcall.h

2019-06-29 Thread Vaibhav Jain
Update the hvcalls.h to include op-codes for new hcalls introduce to manage SCM memory. Also update existing hcall definitions to reflect current papr specification for SCM. The removed hcall op-codes H_SCM_MEM_QUERY, H_SCM_BLOCK_CLEAR were transient proposals and there support was never implement

[PATCH v4 0/3] powerpc/papr_scm: Workaround for failure of drc bind after kexec

2019-06-29 Thread Vaibhav Jain
Presently an error is returned in response to hcall H_SCM_BIND_MEM when a new kernel boots on lpar via kexec. This prevents papr_scm from registering drc memory regions with nvdimm. The error reported is of the form below: "papr_scm ibm,persistent-memory:ibm,pmemory@4412: bind err: -68" On in

Re: ["RFC PATCH" 2/2] powerpc/mm: Conslidate numa_enable check and min_common_depth check

2019-06-29 Thread Aneesh Kumar K.V
On 6/29/19 9:09 PM, Vaibhav Jain wrote: "Aneesh Kumar K.V" writes: Update min_common_depth = -1 if numa is disabled. This help us to avoid checking for both in different code paths. Signed-off-by: Aneesh Kumar K.V --- arch/powerpc/mm/numa.c | 9 + 1 file changed, 5 insertions(+),

Re: ["RFC PATCH" 2/2] powerpc/mm: Conslidate numa_enable check and min_common_depth check

2019-06-29 Thread Vaibhav Jain
"Aneesh Kumar K.V" writes: > Update min_common_depth = -1 if numa is disabled. This > help us to avoid checking for both in different code paths. > > Signed-off-by: Aneesh Kumar K.V > --- > arch/powerpc/mm/numa.c | 9 + > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/

Re: [PATCH 06/16] sh: use the generic get_user_pages_fast code

2019-06-29 Thread Guenter Roeck
On Tue, Jun 25, 2019 at 04:37:05PM +0200, Christoph Hellwig wrote: > The sh code is mostly equivalent to the generic one, minus various > bugfixes and two arch overrides that this patch adds to pgtable.h. > > Signed-off-by: Christoph Hellwig sh:defconfig no longer builds with this patch applied.

Re: [PATCH] i2c: remove casting dma_alloc

2019-06-29 Thread Wolfram Sang
Hi Jochen, (could you send text emails, please?) > yes, I'm still here. However, I don't have the hardware anymore to test the > patch. Thanks for answering! And besides (not) testing, are you still open to review patches to the best of your knowledge (I neither have most of the HW). Or do you

Re: [PATCH] mm: Generalize and rename notify_page_fault() as kprobe_page_fault()

2019-06-29 Thread Guenter Roeck
Hi, On Thu, Jun 13, 2019 at 03:37:24PM +0530, Anshuman Khandual wrote: > Architectures which support kprobes have very similar boilerplate around > calling kprobe_fault_handler(). Use a helper function in kprobes.h to unify > them, based on the x86 code. > > This changes the behaviour for other a

Re: [PATCH 04/16] MIPS: use the generic get_user_pages_fast code

2019-06-29 Thread Guenter Roeck
Hi, On Tue, Jun 25, 2019 at 04:37:03PM +0200, Christoph Hellwig wrote: > The mips code is mostly equivalent to the generic one, minus various > bugfixes and an arch override for gup_fast_permitted. > > Note that this defines ARCH_HAS_PTE_SPECIAL for mips as mips has > pte_special and pte_mkspecia

[GIT PULL] Please pull powerpc/linux.git powerpc-5.2-7 tag

2019-06-29 Thread Michael Ellerman
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Linus, Please pull one more powerpc fix for 5.2: The following changes since commit 50087112592016a3fc10b394a55f1f1a1bde6908: KVM: PPC: Book3S HV: Invalidate ERAT when flushing guest TLB entries (2019-06-20 22:11:25 +1000) are available in th

Re: [PATCH] powerpc/64s/exception: Fix machine check early corrupting AMR

2019-06-29 Thread Michael Ellerman
Nicholas Piggin writes: > The early machine check runs in real mode, so locking is unnecessary. > Worse, the windup does not restore AMR, so this can result in a false > KUAP fault after a recoverable machine check hits inside a user copy > operation. > > Fix this similarly to HMI by just avoidin

Re: [PATCH] powerpc/64s/exception: Fix machine check early corrupting AMR

2019-06-29 Thread Michael Ellerman
On Fri, 2019-06-21 at 22:55:54 UTC, Nicholas Piggin wrote: > The early machine check runs in real mode, so locking is unnecessary. > Worse, the windup does not restore AMR, so this can result in a false > KUAP fault after a recoverable machine check hits inside a user copy > operation. > > Fix thi

Re: [PATCH] i2c: remove casting dma_alloc

2019-06-29 Thread Wolfram Sang
On Sun, Jun 23, 2019 at 11:13:53PM +0200, Vasyl Gomonovych wrote: > From: Vasyl > > Generated by: alloc_cast.cocci > > Signed-off-by: Vasyl Your other patches in git history have your full name. Why not this one? @Jochen: are you still there, your ack would be very welcome. > --- > drivers

Re: [PATCH V2] crypto/NX: Set receive window credits to max number of CRBs in RxFIFO

2019-06-29 Thread Michael Ellerman
Herbert Xu writes: > On Fri, Jun 28, 2019 at 11:43:16AM +1000, Michael Ellerman wrote: >> >> No. I assumed you'd take it because it's in drivers/crypto. >> >> If you want me to take it that's fine, just let me know. > > No that's fine Michael. I'll pick it up. Thanks. cheers

Re: [PATCH v3 1/3] powerpc/pseries: Update SCM hcall op-codes in hvcall.h

2019-06-29 Thread Michael Ellerman
"Oliver O'Halloran" writes: > On Fri, Jun 28, 2019 at 1:39 PM Michael Ellerman wrote: >> >> Vaibhav Jain writes: >> > *snip* >> >> How can we be changing the meaning of HCALL numbers without breaking all >> existing usages? > > The changed one being changed here were never used by linux or > imp

Re: power9 NUMA crash while reading debugfs imc_cmd

2019-06-29 Thread Michael Ellerman
Qian Cai writes: > On Fri, 2019-06-28 at 17:19 +0530, Anju T Sudhakar wrote: >> On 6/28/19 9:04 AM, Qian Cai wrote: >> > >> > > On Jun 27, 2019, at 11:12 PM, Michael Ellerman >> > > wrote: >> > > >> > > Qian Cai writes: >> > > > Read of debugfs imc_cmd file for a memory-less node will trigger

Re: ["RFC PATCH" 2/2] powerpc/mm: Conslidate numa_enable check and min_common_depth check

2019-06-29 Thread Aneesh Kumar K.V
On 6/29/19 2:06 PM, Aneesh Kumar K.V wrote: Update min_common_depth = -1 if numa is disabled. This help us to avoid checking for both in different code paths. Signed-off-by: Aneesh Kumar K.V --- arch/powerpc/mm/numa.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git

Re: ["RFC PATCH" 1/2] powerpc/mm: Fix node look up with numa=off boot

2019-06-29 Thread Aneesh Kumar K.V
On 6/29/19 2:06 PM, Aneesh Kumar K.V wrote: If we boot with numa=off, we need to make sure we return NUMA_NO_NODE when looking up associativity details of resources. Without this, we hit crash like below BUG: Unable to handle kernel data access at 0x408 Faulting instruction address: 0xc0

Re: [PATCH 08/13] powerpc/memcpy: Add memcpy_mcsafe for pmem

2019-06-29 Thread christophe leroy
Le 21/06/2019 à 06:55, Santosh Sivaraj a écrit : From: Balbir Singh The pmem infrastructure uses memcpy_mcsafe in the pmem layer so as to convert machine check exceptions into a return value on failure in case a machine check exception is encountered during the memcpy. This patch largely bo

["RFC PATCH" 2/2] powerpc/mm: Conslidate numa_enable check and min_common_depth check

2019-06-29 Thread Aneesh Kumar K.V
Update min_common_depth = -1 if numa is disabled. This help us to avoid checking for both in different code paths. Signed-off-by: Aneesh Kumar K.V --- arch/powerpc/mm/numa.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/arch/powerpc/mm/numa.c b/arch/powerpc/mm/numa

["RFC PATCH" 1/2] powerpc/mm: Fix node look up with numa=off boot

2019-06-29 Thread Aneesh Kumar K.V
If we boot with numa=off, we need to make sure we return NUMA_NO_NODE when looking up associativity details of resources. Without this, we hit crash like below BUG: Unable to handle kernel data access at 0x408 Faulting instruction address: 0xc8f31704 cpu 0x1b: Vector: 380 (Data SLB

[PATCH] powerpc: remove device_to_mask

2019-06-29 Thread Christoph Hellwig
Use the dma_get_mask helper from dma-mapping.h instead. Signed-off-by: Christoph Hellwig --- arch/powerpc/include/asm/iommu.h | 8 arch/powerpc/kernel/dma-iommu.c | 4 ++-- arch/powerpc/platforms/pseries/vio.c | 4 ++-- 3 files changed, 4 insertions(+), 12 deletions(-) diff --

[PATCH] powerpc/mm/radix: Use the right page size for vmemmap mapping

2019-06-29 Thread Aneesh Kumar K.V
Also on hash with 4K PAGE_SIZE make sure we use 4K page size for vmemmap. Fixes: 2bfd65e45e87 ("powerpc/mm/radix: Add radix callbacks for early init routines") Signed-off-by: Aneesh Kumar K.V --- arch/powerpc/mm/book3s64/hash_utils.c| 4 +--- arch/powerpc/mm/book3s64/radix_pgtable.c | 16 +

[PATCH] powerpc/mm/nvdimm: Add an informative message if we fail to allocate altmap block

2019-06-29 Thread Aneesh Kumar K.V
Allocation from altmap area can fail based on vmemmap page size used. Add kernel info message to indicate the failure. That allows the user to identify whether they are really using persistent memory reserved space for per-page metadata. The message looks like: [ 136.587212] altmap block allocat