Re: [PATCH] jump_label: align jump_entry table to at least 4-bytes

2017-02-28 Thread Sachin Sant
> I also checked all the other .ko files and they were properly aligned. So I > think this should hopefully work, and I like that its not a per-arch fix. > > Sachin, sorry to bother you again, but I'm hoping you can try David's latest > patch to scripts/module-common.lds, just to test in your s

Re: [PATCH] jump_label: align jump_entry table to at least 4-bytes

2017-02-28 Thread Michael Ellerman
Jason Baron writes: ... > I also checked all the other .ko files and they were properly aligned. > So I think this should hopefully work, and I like that its not a > per-arch fix. > > Sachin, sorry to bother you again, but I'm hoping you can try David's > latest patch to scripts/module-common.l

Re: [PATCH v2] powernv/opal: Handle OPAL_WRONG_STATE error from OPAL fails

2017-02-28 Thread Michael Ellerman
Stewart Smith writes: > Vipin K Parashar writes: >> Added check for OPAL_WRONG_STATE error code returned from OPAL. >> Currently Linux flashes "unexpected error" over console for this >> error. This will avoid throwing such message and return I/O error >> for such OPAL failures. >> >> Signed-off

[GIT PULL] Please pull powerpc/linux.git powerpc-4.11-2 tag

2017-02-28 Thread Michael Ellerman
Hi Linus, Please pull the second set of powerpc updates for 4.11. This includes an update of the disassembly code in xmon, from binutils. We've received permission from all the authors of the relevant binutils changes to relicense their changes to the relevant files from GPLv3 to GPLv2. That was

Re: [PATCH V3 2/2] powerpc: Update to new option-vector-5 format for CAS

2017-02-28 Thread Paul Mackerras
On Tue, Feb 28, 2017 at 05:03:48PM +1100, Suraj Jitindar Singh wrote: > On POWER9 the ibm,client-architecture-support (CAS) negotiation process > has been updated to change how the host to guest negotiation is done for > the new hash/radix mmu as well as the nest mmu, process tables and guest > tra

Re: [RFC 3/3] cxl: Reset freeze counters before adapter PERST for flashing new image

2017-02-28 Thread Russell Currey
[resending this since it didn't get delivered to the list] On Tue, 2017-02-28 at 12:52 +0530, Vaibhav Jain wrote: > The patch resets the freeze counter on eeh_pe struct for PHB > associated with the cxl pci adapter. This would enable re-flashing of > the cxl-adapter beyond the default limit of 5.

Re: [RFC 2/3] powerpc/eeh: Introduce function eeh_pe_reset_freeze_counter

2017-02-28 Thread Russell Currey
On Tue, 2017-02-28 at 12:32 +0530, Vaibhav Jain wrote: > This patch introduces function eeh_pe_reset_freeze_counter which can > be used to reset the PE's freeze count variable outside eeh code. This > is useful for devices that can acquire a different personality after > a PERST event (e.g FPGA Ada

Re: [RFC 1/3] powerpc/eeh: Refactor eeh_pe_update_time_stamp to update freeze_count

2017-02-28 Thread Russell Currey
On Tue, 2017-02-28 at 12:32 +0530, Vaibhav Jain wrote: > This patch introduces a new function named > eeh_pe_update_freeze_counter replacing existing function > eeh_pe_update_time_stamp. The new function also manages the value of > freeze_count along with tstamp to track the number of times the PE

Re: [PATCH v3] powerpc/powernv: add hdat attribute to sysfs

2017-02-28 Thread Andrew Donnellan
On 27/02/17 21:56, Michael Ellerman wrote: +/* HDAT attribute for sysfs */ +static struct bin_attribute hdat_attr = { + .attr = {.name = "hdat", .mode = 0444}, ajd and oohal report to my office. ...ACK... :/ -- Andrew Donnellan

Re: [PATCH] powerpc: booke: fix boot crash due to null hugepd

2017-02-28 Thread Scott Wood
On Tue, 2017-02-28 at 14:55 +, Laurentiu Tudor wrote: > Hi, > > Some more information on the crash, inline. > > On 02/17/2017 02:18 PM, Aneesh Kumar K.V wrote: > > > > laurentiu.tu...@nxp.com writes: > > > > > > > > From: Laurentiu Tudor > > > > > > On 32-bit book-e machines, hugepd_ok()

Re: [PATCH] jump_label: align jump_entry table to at least 4-bytes

2017-02-28 Thread Jason Baron
On 02/28/2017 03:15 PM, David Daney wrote: On 02/28/2017 11:34 AM, Jason Baron wrote: On 02/28/2017 02:22 PM, David Daney wrote: On 02/28/2017 11:05 AM, David Daney wrote: On 02/28/2017 10:39 AM, Jason Baron wrote: [...] I suspect that the alignment of the __jump_table section in the .ko

Re: [PATCH V3 1/2] powerpc: Parse the command line before calling CAS

2017-02-28 Thread Balbir Singh
On 28/02/17 17:03, Suraj Jitindar Singh wrote: > On POWER9 the hypervisor requires the guest to decide whether it would > like to use a hash or radix mmu model at the time it calls > ibm,client-architecture-support (CAS) based on what the hypervisor has > said it's allowed to do. It is possible t

Re: [PATCH v2] powernv/opal: Handle OPAL_WRONG_STATE error from OPAL fails

2017-02-28 Thread Stewart Smith
Vipin K Parashar writes: > Added check for OPAL_WRONG_STATE error code returned from OPAL. > Currently Linux flashes "unexpected error" over console for this > error. This will avoid throwing such message and return I/O error > for such OPAL failures. > > Signed-off-by: Vipin K Parashar > --- > C

Re: [Patch v4] powerpc/powernv: add hdat attribute to sysfs

2017-02-28 Thread Stewart Smith
Matt Brown writes: > The HDAT data area is consumed by skiboot and turned into a device-tree. > In some cases we would like to look directly at the HDAT, so this patch > adds a sysfs node to allow it to be viewed. This is not possible through > /dev/mem as it is reserved memory which is stopped b

Re: [PATCH] jump_label: align jump_entry table to at least 4-bytes

2017-02-28 Thread David Daney
On 02/28/2017 11:34 AM, Jason Baron wrote: On 02/28/2017 02:22 PM, David Daney wrote: On 02/28/2017 11:05 AM, David Daney wrote: On 02/28/2017 10:39 AM, Jason Baron wrote: [...] I suspect that the alignment of the __jump_table section in the .ko files is not correct, and you are seeing so

Re: [PATCH] jump_label: align jump_entry table to at least 4-bytes

2017-02-28 Thread Jason Baron
On 02/28/2017 02:22 PM, David Daney wrote: > On 02/28/2017 11:05 AM, David Daney wrote: >> On 02/28/2017 10:39 AM, Jason Baron wrote: >>> > [...] I suspect that the alignment of the __jump_table section in the .ko files is not correct, and you are seeing some sort of problem due to

Re: [PATCH] jump_label: align jump_entry table to at least 4-bytes

2017-02-28 Thread David Daney
On 02/28/2017 11:05 AM, David Daney wrote: On 02/28/2017 10:39 AM, Jason Baron wrote: [...] I suspect that the alignment of the __jump_table section in the .ko files is not correct, and you are seeing some sort of problem due to that. Hi, Yes, if you look at the trace that Sachin sent th

Re: [PATCH] jump_label: align jump_entry table to at least 4-bytes

2017-02-28 Thread David Daney
On 02/28/2017 10:39 AM, Jason Baron wrote: On 02/28/2017 01:16 PM, David Daney wrote: On 02/28/2017 08:21 AM, Steven Rostedt wrote: On Tue, 28 Feb 2017 10:25:46 +0530 Sachin Sant wrote: File: ./net/ipv4/xfrm4_input.o [12] __jump_table PROGBITS 000639 18 1

Re: [PATCH] jump_label: align jump_entry table to at least 4-bytes

2017-02-28 Thread Jason Baron
On 02/28/2017 01:16 PM, David Daney wrote: On 02/28/2017 08:21 AM, Steven Rostedt wrote: On Tue, 28 Feb 2017 10:25:46 +0530 Sachin Sant wrote: File: ./net/ipv4/xfrm4_input.o [12] __jump_table PROGBITS 000639 18 18 WAM 0 0 1 File: ./net/ipv4/udplite.o F

Re: [PATCH] jump_label: align jump_entry table to at least 4-bytes

2017-02-28 Thread David Daney
On 02/28/2017 08:21 AM, Steven Rostedt wrote: On Tue, 28 Feb 2017 10:25:46 +0530 Sachin Sant wrote: File: ./net/ipv4/xfrm4_input.o [12] __jump_table PROGBITS 000639 18 18 WAM 0 0 1 File: ./net/ipv4/udplite.o File: ./net/ipv4/xfrm4_output.o [ 9] __jump_

Re: [PATCH 5/5] powerpc/64s: fix POWER9 machine check handler from stop state

2017-02-28 Thread Gautham R Shenoy
Hi Nick, On Fri, Feb 17, 2017 at 12:09 AM, Nicholas Piggin wrote: > The ISA specifies power save wakeup can cause a machine check interrupt. > The machine check handler currently has code to handle that for POWER8, > but POWER9 crashes when trying to execute the P8 style sleep > instructions. > >

Re: [PATCH] jump_label: align jump_entry table to at least 4-bytes

2017-02-28 Thread Steven Rostedt
On Tue, 28 Feb 2017 10:25:46 +0530 Sachin Sant wrote: > File: ./net/ipv4/xfrm4_input.o > [12] __jump_table PROGBITS 000639 18 18 > WAM 0 0 1 > File: ./net/ipv4/udplite.o > File: ./net/ipv4/xfrm4_output.o > [ 9] __jump_table PROGBITS00

Re: [PATCH 2/5] powerpc/64: stop using bit in HSPRG0 to test winkle

2017-02-28 Thread Nicholas Piggin
On Tue, 28 Feb 2017 20:38:19 +0530 Gautham R Shenoy wrote: > Hi Nick, > > On Fri, Feb 17, 2017 at 12:08 AM, Nicholas Piggin wrote: > > The POWER8 idle code has a neat trick of programming the power on engine > > to restore a low bit into HSPRG0, so idle wakeup code can test and see > > if it ha

Re: [PATCH 4/5] powerpc/64s: consolidate pnv_restore_hyp_resource into pnv_powersave_wakeup

2017-02-28 Thread Gautham R Shenoy
Hi Nick, On Fri, Feb 17, 2017 at 12:09 AM, Nicholas Piggin wrote: > There is only one caller, so this reduces spaghetti of subsequent > callees returning into the caller. > > Signed-off-by: Nicholas Piggin This patch is good! Reviewed-by: Gautham R. Shenoy -- Thanks and Regards gautham.

Re: [PATCH 3/5] powerpc/64s: use alternative feature patching

2017-02-28 Thread Gautham R Shenoy
Hi Nick, On Fri, Feb 17, 2017 at 12:08 AM, Nicholas Piggin wrote: > This reduces the number of nops for POWER8 > > Signed-off-by: Nicholas Piggin This change looks ok to me. Reviewed-by: Gautham R. Shenoy > --- > arch/powerpc/kernel/idle_book3s.S | 15 +++ > 1 file changed, 7 in

Re: [PATCH 2/5] powerpc/64: stop using bit in HSPRG0 to test winkle

2017-02-28 Thread Gautham R Shenoy
Hi Nick, On Fri, Feb 17, 2017 at 12:08 AM, Nicholas Piggin wrote: > The POWER8 idle code has a neat trick of programming the power on engine > to restore a low bit into HSPRG0, so idle wakeup code can test and see > if it has been programmed this way and therefore lost all state. Restore > time c

Re: [PATCH] powerpc: booke: fix boot crash due to null hugepd

2017-02-28 Thread Laurentiu Tudor
Hi, Some more information on the crash, inline. On 02/17/2017 02:18 PM, Aneesh Kumar K.V wrote: > laurentiu.tu...@nxp.com writes: > >> From: Laurentiu Tudor >> >> On 32-bit book-e machines, hugepd_ok() does not take >> into account null hugepd values, causing this crash at boot: >> >> Unable to

Re: [PATCH v3 1/2] powerpc: split ftrace bits into a separate file

2017-02-28 Thread Steven Rostedt
On Tue, 28 Feb 2017 15:04:15 +1100 Michael Ellerman wrote: kernel/trace/ftrace.c more obvious. > > I don't know if it's really worth keeping the names the same across > arches, especially as we already have: > > arch/arm64/kernel/entry-ftrace.S > arch/arm/kernel/entry-ftrace.S > arch/blac

Re: [bug report] v4.10.1 Oops on P1010 - huge tlb - there's already a fix ...

2017-02-28 Thread Laurentiu Tudor
Hi Wolfgang, Thanks for reporting! On 02/28/2017 01:47 PM, Wolfgang Ocker wrote:> On Tue, 2017-02-28 at 10:57 +0100, Wolfgang Ocker wrote: >> With kernel v4.10.1 and huge tlb enabled (CONFIG_HUGETLBFS=y) I see >> the >> following oops on a P1010: > > Just saw that there is already a fix:

Re: [bug report] v4.10.1 Oops on P1010 - huge tlb - there's already a fix ...

2017-02-28 Thread Wolfgang Ocker
On Tue, 2017-02-28 at 10:57 +0100, Wolfgang Ocker wrote: > With kernel v4.10.1 and huge tlb enabled (CONFIG_HUGETLBFS=y) I see > the >  following oops on a P1010: Just saw that there is already a fix: https://lists.ozlabs.org/pipermail/linuxppc-dev/2017-February/154204.html Thanks!

Re: [PATCH 1/5] powerpc/64s: move remaining system reset idle code into idle_book3s.S

2017-02-28 Thread Gautham R Shenoy
Hi Nick, This patch is fine by me. Reviewed-by: Gautham R. Shenoy On Fri, Feb 17, 2017 at 12:08 AM, Nicholas Piggin wrote: > Should be no functional change. > > Signed-off-by: Nicholas Piggin > --- > arch/powerpc/kernel/exceptions-64s.S | 26 +--- > arch/powerpc/kernel/id

[bug report] v4.10.1 Oops on P1010 - huge tlb

2017-02-28 Thread Wolfgang Ocker
With kernel v4.10.1 and huge tlb enabled (CONFIG_HUGETLBFS=y) I see the following oops on a P1010: Freeing unused kernel memory: 428K This architecture does not have kernel memory protection. Unable to handle kernel paging request for data at address 0x8000 Faulting instruction address: 0xc0

Re: [PATCH] staging: fsl-mc: fix warning in DT ranges parser

2017-02-28 Thread Laurentiu Tudor
Hi Arnd, On 02/27/2017 10:42 PM, Arnd Bergmann wrote: > The fsl-mc-bus driver in staging contains a copy of the standard > 'ranges' property parsing algorithm with a hack to treat a missing > property the same way as an empty one. This code produces false-positive > warnings for me in an allmodcon

Re: [PATCH] kbuild: avoid unrecognized option error for external DTC

2017-02-28 Thread Michael Ellerman
Ben Hutchings writes: > [ Unknown signature status ] > On Mon, 2017-02-27 at 14:40 +0900, Masahiro Yamada wrote: >> Since commit 6b22b3d1614a ("kbuild: Allow using host dtc instead of >> kernel's copy"), it is possible to use an external dtc.  In this >> case, we do not know which options are sup

[PATCH v2] powernv/opal: Handle OPAL_WRONG_STATE error from OPAL fails

2017-02-28 Thread Vipin K Parashar
Added check for OPAL_WRONG_STATE error code returned from OPAL. Currently Linux flashes "unexpected error" over console for this error. This will avoid throwing such message and return I/O error for such OPAL failures. Signed-off-by: Vipin K Parashar --- Changes in v2: - Added log message indica

Re: [PATCH] powernv/opal: Handle OPAL_WRONG_STATE error from OPAL fails

2017-02-28 Thread Vipin K Parashar
Thanks!! for review. Sending out v2 with suggested changes. On Thursday 23 February 2017 09:22 AM, Stewart Smith wrote: Michael Ellerman writes: Stewart Smith writes: Vipin K Parashar writes: On Monday 13 February 2017 06:13 AM, Michael Ellerman wrote: Vipin K Parashar writes: OPA

Re: [PATCH 1/3] powerpc/64s: fix handling of non-synchronous machine checks

2017-02-28 Thread Nicholas Piggin
On Tue, 28 Feb 2017 11:27:29 +0530 Mahesh Jagannath Salgaonkar wrote: > On 02/28/2017 07:30 AM, Nicholas Piggin wrote: > > A synchronous machine check is an exception raised by the attempt to > > execute the current instruction. If the error can't be corrected, it > > can make sense to SIGBUS the