Re: [PATCH V2 1/2] devicetree/bindings: Add binding for operator panel on FSP machines

2016-04-26 Thread Stewart Smith
Suraj Jitindar Singh writes: > Add a binding to Documentation/devicetree/bindings/powerpc/opal > (oppanel-opal.txt) for the operator panel which is present on IBM > pseries machines with FSPs. It's not pseries (as that implies PowerVM / PAPR) - while here we're all about OPAL. With a slight chan

Re: [RFC v6 00/10] vfio-pci: Allow to mmap sub-page MMIO BARs and MSI-X table

2016-04-26 Thread Yongji Xie
On 2016/4/27 0:40, Alex Williamson wrote: On Mon, 25 Apr 2016 18:05:53 +0800 Yongji Xie wrote: Hi Alex, Any comment? TBH, I shuffled this to the bottom of the review pile because you're depending on a patch series for ARM MSI mapping that's still very much in flux. You've really got 3 or 4

Re: [PATCH] powerpc: Add support for userspace P9 copy paste

2016-04-26 Thread Michael Neuling
On Tue, 2016-04-26 at 17:45 +1000, Balbir Singh wrote: > >  > > /* > >  * System calls. > > @@ -508,6 +509,14 @@ BEGIN_FTR_SECTION > > ldarxr6,0,r1 > > END_FTR_SECTION_IFSET(CPU_FTR_STCX_CHECKS_ADDRESS) > >  > > +BEGIN_FTR_SECTION > > +/* > > + * A cp_abort (copy paste abort) here ensures t

Re: [PATCH] powerpc/mm: Use jump label to speed up radix_enabled check

2016-04-26 Thread Benjamin Herrenschmidt
On Wed, 2016-04-27 at 11:00 +1000, Balbir Singh wrote: > Just basic testing across CPUs with various mm features  > enabled/disabled. Just for sanity I still don't think it's worth scattering the change. Either the jump label works or it doesn't ... The only problem is make sure we identify all th

Re: [PATCH v2 1/3] powerpc/eeh: Ignore error handlers in eeh_pe_reset_and_recover()

2016-04-26 Thread Gavin Shan
On Tue, Apr 26, 2016 at 08:17:31PM +1000, Gavin Shan wrote: >On Tue, Apr 26, 2016 at 03:29:59PM +1000, David Gibson wrote: >>On Fri, Apr 22, 2016 at 11:28:02PM +1000, Gavin Shan wrote: >>> The function eeh_pe_reset_and_recover() is used to recover EEH >>> error when the passthrough device are trans

[PATCH v3 2/4] powerpc/eeh: Restore initial state in eeh_pe_reset_and_recover()

2016-04-26 Thread Gavin Shan
The function eeh_pe_reset_and_recover() is used to recover EEH error when the passthrou device are transferred to guest and backwards. The content in the device's config space will be lost on PE reset issued in the middle of the recovery. The function saves/restores it before/after the reset. Howev

[PATCH v3 1/4] powerpc/eeh: Don't report error in eeh_pe_reset_and_recover()

2016-04-26 Thread Gavin Shan
The function eeh_pe_reset_and_recover() is used to recover EEH error when the passthrough device are transferred to guest and backwards, meaning the device's driver is vfio-pci or none. When the driver is vfio-pci that provides error_detected() error handler only, the handler simply stops the guest

[PATCH v3 4/4] powerpc/eeh: Drop unnecessary label in eeh_pe_change_owner()

2016-04-26 Thread Gavin Shan
The label "reset" in eeh_pe_change_owner() is used only for once. No need to keep it and just drop it. No logical changes introduced. Signed-off-by: Gavin Shan Reviewed-by: David Gibson Reviewed-by: Russell Currey --- arch/powerpc/kernel/eeh.c | 5 + 1 file changed, 1 insertion(+), 4 delet

[PATCH v3 3/4] powerpc/eeh: Ignore handlers in eeh_pe_reset_and_recover()

2016-04-26 Thread Gavin Shan
The function eeh_pe_reset_and_recover() is used to recover EEH error when the passthrough device are transferred to guest and backwards, meaning the device's driver is vfio-pci or none. In both cases, the handlers triggered by eeh_report_reset() and eeh_report_resume() shouldn't be called. This ig

Re: [PATCH kernel 2/2] powerpc/powernv/ioda2: Delay PE disposal

2016-04-26 Thread Gavin Shan
On Thu, Apr 21, 2016 at 01:20:09PM +1000, Alexey Kardashevskiy wrote: >On 04/21/2016 10:21 AM, Gavin Shan wrote: >>On Fri, Apr 08, 2016 at 04:36:44PM +1000, Alexey Kardashevskiy wrote: >>>When SRIOV is disabled, the existing code presumes there is no >>>virtual function (VF) in use and destroys all

Re: [PATCH] powerpc/mm: Use jump label to speed up radix_enabled check

2016-04-26 Thread Balbir Singh
On 27/04/16 09:05, Benjamin Herrenschmidt wrote: > On Wed, 2016-04-27 at 08:16 +1000, Balbir Singh wrote: >> >> On 27/04/16 07:05, Benjamin Herrenschmidt wrote: >>> >>> On Tue, 2016-04-26 at 21:54 +0530, Aneesh Kumar K.V wrote: This add generic mmu_feature_enabled() function that get pa

Re: [PATCH v5 0/4] Cleaning printk stuff in NMI context

2016-04-26 Thread Sergey Senozhatsky
On (04/21/16 13:48), Petr Mladek wrote: > v5 adds changes suggested by Sergey Senozhatsky. It should not longer > conflict with his async printk patchset. passes my tests. (apart from that cosmetic-nano-nit) the series looks good to me Reviewed-by: Sergey Senozhatsky -ss ___

Re: [PATCH v5 4/4] printk/nmi: flush NMI messages on the system panic

2016-04-26 Thread Sergey Senozhatsky
On (04/26/16 16:21), Petr Mladek wrote: [..] > > move printk_nmi_flush_on_panic() to printk.c, and place it next to > > printk_flush_on_panic() (so we will have two printk "flush-on-panic" > > functions sitting together). /* printk_nmi_flush() is in printk.h, > > so it's visible to printk anyway */

Re: [PATCH v2 4/6] rtc: parisc: provide rtc_class_ops directly

2016-04-26 Thread kbuild test robot
Hi, [auto build test ERROR on next-20160426] [cannot apply to m68k/for-next abelloni/rtc-next v4.6-rc5 v4.6-rc4 v4.6-rc3 v4.6-rc5] [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] url: https://github.com/0day-ci/linux/commits/Arnd

Re: [PATCH 6/8] char/genrtc: parisc: use asm-generic/rtc.h

2016-04-26 Thread Rolf Eike Beer
Arnd Bergmann wrote: > The asm-generic/rtc.h header can now be included by > architectures that provide their own set_rtc_time/get_rtc_time > macros, letting us remove most of the common contents in > the powerpc implementation. parisc in this case. Eike signature.asc Description: This is a digi

Re: [PATCH] powerpc/mm: Use jump label to speed up radix_enabled check

2016-04-26 Thread Benjamin Herrenschmidt
On Wed, 2016-04-27 at 08:16 +1000, Balbir Singh wrote: > > On 27/04/16 07:05, Benjamin Herrenschmidt wrote: > > > > On Tue, 2016-04-26 at 21:54 +0530, Aneesh Kumar K.V wrote: > > > > > > This add generic mmu_feature_enabled() function that get patched > > > to take right code path based on the f

Re: [PATCH v2 1/6] powerpc: rework sparse for lib/xor_vmx.c

2016-04-26 Thread Balbir Singh
On 26/04/16 23:49, Daniel Axtens wrote: > Sparse doesn't seem to be passing -maltivec around properly, leading > to lots of errors: > > .../include/altivec.h:34:2: error: Use the "-maltivec" flag to enable PowerPC > AltiVec support > arch/powerpc/lib/xor_vmx.c:27:16: error: Expected ; at end of

Re: [PATCH] powerpc/mm: Use jump label to speed up radix_enabled check

2016-04-26 Thread Balbir Singh
On 27/04/16 07:05, Benjamin Herrenschmidt wrote: > On Tue, 2016-04-26 at 21:54 +0530, Aneesh Kumar K.V wrote: >> This add generic mmu_feature_enabled() function that get patched >> to take right code path based on the feature bit enabled. The main >> difference between the existing mmu_has_featur

Re: [PATCH v2] livepatch: Add some basic LivePatch documentation

2016-04-26 Thread Josh Poimboeuf
On Mon, Apr 25, 2016 at 05:14:35PM +0200, Petr Mladek wrote: > LivePatch framework deserves some documentation, definitely. > This is an attempt to provide some basic info. I hope that > it will be useful for both LivePatch producers and also > potential developers of the framework itself. > > Sig

[PATCH v2 4/6] rtc: parisc: provide rtc_class_ops directly

2016-04-26 Thread Arnd Bergmann
The rtc-generic driver provides an architecture specific wrapper on top of the generic rtc_class_ops abstraction, and on pa-risc, that is implemented using an open-coded version of rtc_time_to_tm/rtc_tm_to_time. This changes the parisc rtc-generic device to provide its rtc_class_ops directly, usin

[PATCH v2 1/6] rtc: m68k: provide rtc_class_ops directly

2016-04-26 Thread Arnd Bergmann
The rtc-generic driver provides an architecture specific wrapper on top of the generic rtc_class_ops abstraction, and m68k has another abstraction on top, which is a bit silly. This changes the m68k rtc-generic device to provide its rtc_class_ops directly, to reduce the number of layers by one. S

[PATCH v2 0/6] simplify rtc-generic driver

2016-04-26 Thread Arnd Bergmann
This is a resend of an earlier series, to clean up the rtc-generic driver by avoiding the dependency on the architecture specific include/asm/rtc.h header that after this series is only used for the deprecated "genrtc" driver. As I've shown in another series, only three architectures (m68k, powerpc

[PATCH v2 6/6] rtc: generic: remove get_rtc_time/set_rtc_time wrappers

2016-04-26 Thread Arnd Bergmann
All architectures using this driver are now converted to provide their own operations, so this one can be turned into a trivial stub driver relying on its platform data. Signed-off-by: Arnd Bergmann --- drivers/rtc/rtc-generic.c | 36 +--- 1 file changed, 1 insert

[PATCH 4/8] char/rtc: move mc146818rtc code out of asm-generic/rtc.h

2016-04-26 Thread Arnd Bergmann
Drivers should not really include stuff from asm-generic directly, and the PC-style cmos rtc driver does this in order to reuse the mc146818 implementation of get_rtc_time/set_rtc_time rather than the architecture specific one for the architecture it gets built for. To make it more obvious what is

[PATCH v2 2/6] rtc: m68k: provide ioctl for q40

2016-04-26 Thread Arnd Bergmann
The q40 platform is the only machine in the kernel that provides RTC_PLL_GET/RTC_PLL_SET ioctl commands in its rtc through the mach_get_rtc_pll/mach_set_rtc_pll callbacks. However, this currenctly works only in the old-style genrtc driver, not the (somewhat) modern rtc-generic driver replacing it.

[PATCH v2 3/6] rtc: powerpc: provide rtc_class_ops directly

2016-04-26 Thread Arnd Bergmann
The rtc-generic driver provides an architecture specific wrapper on top of the generic rtc_class_ops abstraction, and powerpc has another abstraction on top, which is a bit silly. This changes the powerpc rtc-generic device to provide its rtc_class_ops directly, to reduce the number of layers by o

[PATCH 2/8] char/rtc: legacy RTC is no longer supported on x86

2016-04-26 Thread Arnd Bergmann
Commit 3195ef59cb42 ("x86: Do full rtc synchronization with ntp") had the side-effect of unconditionally enabling the RTC_LIB symbol on x86, which in turn disables the selection of the CONFIG_RTC and CONFIG_GEN_RTC drivers that contain a two older implementations of the CONFIG_RTC_DRV_CMOS driver.

[PATCH v2 5/6] rtc: sh: provide rtc_class_ops directly

2016-04-26 Thread Arnd Bergmann
The rtc-generic driver provides an architecture specific wrapper on top of the generic rtc_class_ops abstraction, and on sh, that goes through another indirection using the rtc_sh_get_time/rtc_sh_set_time functions. This changes the sh rtc-generic device to provide its rtc_class_ops directly, skip

[PATCH 1/8] char/rtc: replace blacklist with whitelist

2016-04-26 Thread Arnd Bergmann
Every new architecture has to add itself to the growing list of those that do not support the legacy PC RTC driver. This replaces the long list of architectures that don't support it with a shorter list of those that do. The list is taken from those architectures that have a non-empty asm/mc14681

[PATCH 7/8] char/genrtc: disallow building on Alpha

2016-04-26 Thread Arnd Bergmann
The genrtc driver serves no purpose on Alpha because it drives the same hardware as the original rtc.c driver, and the newer rtc-generic.c or rtc-cmos.c drivers on architectures that use the asm-generic/rtc.h header. The defconfig uses CONFIG_RTC=y, so this driver is not used by default. At one po

char: legacy RTC cleanups

2016-04-26 Thread Arnd Bergmann
I've had these patches in my tree for a while, after the first one had a few issues that are fixed in this new version. The old-style PC RTC driver is now also disabled on m68k (as pointed out by Geert), ppc (it was also blacklisted), and m32r (I showed that it did not build). For the genrtc drive

[PATCH 8/8] char/genrtc: disallow building on mn10300

2016-04-26 Thread Arnd Bergmann
The genrtc driver serves no purpose on mn10300 because it drives the same hardware as the original rtc.c driver, and the newer rtc-generic.c or rtc-cmos.c drivers on architectures that use the asm-generic/rtc.h header. I assume it was initially only added for completeness when the mn10300 port was

[PATCH 5/8] char/genrtc: powerpc: use asm-generic/rtc.h

2016-04-26 Thread Arnd Bergmann
The asm-generic/rtc.h header can now be included by architectures that provide their own set_rtc_time/get_rtc_time macros, letting us remove most of the common contents in the powerpc implementation. Signed-off-by: Arnd Bergmann --- arch/powerpc/include/asm/rtc.h | 36 +--

[PATCH 3/8] char/rtc: remove empty asm/mc146818rtc.h files

2016-04-26 Thread Arnd Bergmann
Nothing on these architectures ever includes the asm/mc146818rtc.h file, the drivers that used to do this have been fixed long ago, and the remaining users are all PC-specific. This removes the files for good. Signed-off-by: Arnd Bergmann --- arch/frv/include/asm/mc146818rtc.h| 16 -

[PATCH 6/8] char/genrtc: parisc: use asm-generic/rtc.h

2016-04-26 Thread Arnd Bergmann
The asm-generic/rtc.h header can now be included by architectures that provide their own set_rtc_time/get_rtc_time macros, letting us remove most of the common contents in the powerpc implementation. Signed-off-by: Arnd Bergmann --- arch/parisc/include/asm/rtc.h | 38 +---

Re: [PATCH] powerpc/mm: Use jump label to speed up radix_enabled check

2016-04-26 Thread Benjamin Herrenschmidt
On Tue, 2016-04-26 at 21:54 +0530, Aneesh Kumar K.V wrote: > This add generic mmu_feature_enabled() function that get patched > to take right code path based on the feature bit enabled. The main > difference between the existing mmu_has_feature() function is the > hot patching using jump label fram

[PATCH] powerpc/4xx: make sam440ep_setup_rtc init

2016-04-26 Thread Yang Shi
sam440ep_setup_rtc is just called by machine_device_initcall, and it calls i2c_register_board_info which is init too, so the lack of __init may cause mismatch warning when linking kernel. Signed-off-by: Yang Shi --- arch/powerpc/platforms/44x/sam440ep.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [RFC v6 00/10] vfio-pci: Allow to mmap sub-page MMIO BARs and MSI-X table

2016-04-26 Thread Alex Williamson
On Mon, 25 Apr 2016 18:05:53 +0800 Yongji Xie wrote: > Hi Alex, > > Any comment? TBH, I shuffled this to the bottom of the review pile because you're depending on a patch series for ARM MSI mapping that's still very much in flux. You've really got 3 or 4 separate patch series here that should

[PATCH] powerpc/mm: Use jump label to speed up radix_enabled check

2016-04-26 Thread Aneesh Kumar K.V
This add generic mmu_feature_enabled() function that get patched to take right code path based on the feature bit enabled. The main difference between the existing mmu_has_feature() function is the hot patching using jump label framework. The implementation wraps around mmu_has_feature so that we

Re: [PATCH 04/14] ARM: dts: OMAP36xx: : DT spelling s/#address-cell/#address-cells/

2016-04-26 Thread Tony Lindgren
* Rob Herring [160420 16:48]: > On Wed, Apr 20, 2016 at 10:32 AM, Geert Uytterhoeven > wrote: > > Signed-off-by: Geert Uytterhoeven > > --- > > arch/arm/boot/dts/omap36xx.dtsi | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/arm/boot/dts/omap36xx.dtsi > > b/a

Re: [PATCH v5 4/4] printk/nmi: flush NMI messages on the system panic

2016-04-26 Thread Petr Mladek
On Sat 2016-04-23 12:49:24, Sergey Senozhatsky wrote: > Hello Petr, > > On (04/21/16 13:48), Petr Mladek wrote: > > extern void printk_nmi_flush(void); > > +extern void printk_nmi_flush_on_panic(void); > > #else > > static inline void printk_nmi_flush(void) { } > > +static inline void printk_nm

[PATCH v2 1/6] powerpc: rework sparse for lib/xor_vmx.c

2016-04-26 Thread Daniel Axtens
Sparse doesn't seem to be passing -maltivec around properly, leading to lots of errors: .../include/altivec.h:34:2: error: Use the "-maltivec" flag to enable PowerPC AltiVec support arch/powerpc/lib/xor_vmx.c:27:16: error: Expected ; at end of declaration arch/powerpc/lib/xor_vmx.c:27:16: error:

Re: [PATCH v2] ftrace: Match dot symbols when searching functions on ppc64

2016-04-26 Thread Steven Rostedt
On Mon, 25 Apr 2016 18:56:14 -0300 Thiago Jung Bauermann wrote: > In the ppc64 big endian ABI, function symbols point to function > descriptors. The symbols which point to the function entry points > have a dot in front of the function name. Consequently, when the > ftrace filter mechanism search

Re: [PATCH V10 00/28] Add new powerpc specific ELF core notes

2016-04-26 Thread Edjunior Barbosa Machado
On 04/13/2016 02:36 AM, Michael Ellerman wrote: > On Mon, 2016-04-11 at 03:32 -0300, Edjunior Barbosa Machado wrote: >> Hi Michael, Anshuman, >> >> I've managed to implement the GDB support for the new regsets and test >> on Power8 (BE and LE). > > Great work thanks! > >> The following is an exam

Re: [PATCH v2] livepatch: Add some basic LivePatch documentation

2016-04-26 Thread Chris J Arges
On Mon, Apr 25, 2016 at 05:14:35PM +0200, Petr Mladek wrote: > LivePatch framework deserves some documentation, definitely. > This is an attempt to provide some basic info. I hope that > it will be useful for both LivePatch producers and also > potential developers of the framework itself. > > Sig

Re: [PATCH V3] powerpc: Implement {cmp}xchg for u8 and u16

2016-04-26 Thread Pan Xinhui
On 2016年04月25日 23:37, Peter Zijlstra wrote: > On Mon, Apr 25, 2016 at 06:10:51PM +0800, Pan Xinhui wrote: >>> So I'm not actually _that_ familiar with the PPC LL/SC implementation; >>> but there are things a CPU can do to optimize these loops. >>> >>> For example, a CPU might choose to not release

Re: [PATCH V2] powerpc/infiniband: Use cache inhibitted and guarded mapping on powerpc

2016-04-26 Thread Michael Ellerman
On Wed, 2016-04-20 at 16:29 +, Marciniszyn, Mike wrote: > > From: Aneesh Kumar K.V [mailto:aneesh.ku...@linux.vnet.ibm.com] > > Sent: Wednesday, April 20, 2016 3:58 AM > > Subject: [PATCH V2] powerpc/infiniband: Use cache inhibitted and guarded > > mapping on powerpc > > > > Doug, can you fix

Re: [PATCH v2 0/5] powerpc/pm: QorIQ deep sleep

2016-04-26 Thread Chenhui Zhao
Any comment? Thanks, Chenhui From: Chenhui Zhao Sent: Friday, April 15, 2016 7:13 PM To: linuxppc-dev@lists.ozlabs.org; o...@buserror.net Cc: Zhengxiong Jin; Chenhui Zhao Subject: [PATCH v2 0/5] powerpc/pm: QorIQ deep sleep Changes for v2: * Ioremap eve

Re: [PATCH v2 2/3] powerpc/eeh: Restore config from edev in eeh_pe_reset_and_recover()

2016-04-26 Thread Gavin Shan
On Fri, Apr 22, 2016 at 11:28:03PM +1000, Gavin Shan wrote: >The function eeh_pe_reset_and_recover() is used to recover EEH >error when the passthrou device are transferred to guest and >backwards. The content in the device's config space will be lost >on PE reset issued in the middle of the recove

Re: [PATCH v2 1/3] powerpc/eeh: Ignore error handlers in eeh_pe_reset_and_recover()

2016-04-26 Thread Gavin Shan
On Tue, Apr 26, 2016 at 03:29:59PM +1000, David Gibson wrote: >On Fri, Apr 22, 2016 at 11:28:02PM +1000, Gavin Shan wrote: >> The function eeh_pe_reset_and_recover() is used to recover EEH >> error when the passthrough device are transferred to guest and >> backwards, meaning the device's driver is

Re: [PATCH v2] livepatch: Add some basic LivePatch documentation

2016-04-26 Thread Balbir Singh
Hi Petr Very very nice documentation, some comments inline Reviewed-by: Balbir Singh Balbir On 26/04/16 01:14, Petr Mladek wrote: > LivePatch framework deserves some documentation, definitely. > This is an attempt to provide some basic info. I hope that > it will be useful for both LivePatch p

[PATCH v2 18/23] ata: sata_dwc_460ex: switch to new dmaengine_terminate_* API

2016-04-26 Thread Andy Shevchenko
Convert dmaengine_terminate_all() calls to synchronous and asynchronous versions where appropriate. Tested-by: Christian Lamparter Signed-off-by: Andy Shevchenko --- drivers/ata/sata_dwc_460ex.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ata/sata_dwc_460ex.c b/d

[PATCH v2 21/23] ata: sata_dwc_460ex: use devm_ioremap

2016-04-26 Thread Andy Shevchenko
This simplifies error handling and cleanup by using devm to manage IO mappings. Tested-by: Christian Lamparter Signed-off-by: Mans Rullgard Signed-off-by: Andy Shevchenko --- drivers/ata/sata_dwc_460ex.c | 30 +++--- 1 file changed, 11 insertions(+), 19 deletions(-) di

[PATCH v2 01/23] ata: sata_dwc_460ex: remove incorrect locking

2016-04-26 Thread Andy Shevchenko
From: Mans Rullgard This lock is already taken in ata_scsi_queuecmd() a few levels up the call stack so attempting to take it here is an error. Moreover, it is pointless in the first place since it only protects a single, atomic assignment. Enabling lock debugging gives the following output: =

[PATCH v2 23/23] powerpc/4xx: Device tree update for the 460ex DWC SATA

2016-04-26 Thread Andy Shevchenko
Device tree update for the Applied micro processor 460ex on-chip SATA to use "dmas" property. Acked-by: Rob Herring Signed-off-by: Andy Shevchenko --- arch/powerpc/boot/dts/canyonlands.dts | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/arch/powerpc/boot/dts

[PATCH v2 07/23] ata: sata_dwc_460ex: skip dma setup for non-dma commands

2016-04-26 Thread Andy Shevchenko
From: Mans Rullgard Calling dmaengine_prep_slave_sg() for non-dma ATA commands is unnecessary at best and could be harmful if the dma driver reacts badly to this. It also causes this driver to print a bogus error message in these cases. This patch changes sata_dwc_qc_issue() to only do the dma

[PATCH v2 04/23] ata: sata_dwc_460ex: burst size must be in items not bytes

2016-04-26 Thread Andy Shevchenko
The burst size as defined by DMAengine API is in items of address width. Derive burst size from AHB_DMA_BRST_DFLT (64 bytes) by dividing it to DMA_SLAVE_BUSWIDTH_4_BYTES (4 bytes) that gives us 16 items. Tested-by: Christian Lamparter Signed-off-by: Andy Shevchenko --- drivers/ata/sata_dwc_460e

[PATCH v2 22/23] ata: sata_dwc_460ex: make debug messages neat

2016-04-26 Thread Andy Shevchenko
There is a duplication in the debug messages when accessing SCR registers. Remove duplication to make the messages neat. Tested-by: Christian Lamparter Signed-off-by: Andy Shevchenko --- drivers/ata/sata_dwc_460ex.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/dri

[PATCH v2 16/23] ata: sata_dwc_460ex: add __iomem to register base pointer

2016-04-26 Thread Andy Shevchenko
From: Mans Rullgard The pointer to the mmio register base is missing the __iomem annotation. Fix this. Tested-by: Christian Lamparter Signed-off-by: Mans Rullgard --- drivers/ata/sata_dwc_460ex.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ata/sata_dwc_460ex.c

[PATCH v2 11/23] ata: sata_dwc_460ex: get rid of global data

2016-04-26 Thread Andy Shevchenko
From: Mans Rullgard This moves all global data into the driver private struct, thus permitting multiple devices of this type to be used. The core_scr_read/write() functions are replaced with equivalent calls to the existing sata_dwc_scr_read/write(). Tested-by: Christian Lamparter Signed-off-b

[PATCH v2 19/23] ata: sata_dwc_460ex: use readl/writel_relaxed()

2016-04-26 Thread Andy Shevchenko
From: Mans Rullgard Rename the register access macros and use standard _relaxed() ops instead of __raw variants with explicit byte swapping. The original driver used the ppc-specific in/out_le32(). When it was adapted to other systems, these were added to the driver under ifdefs. However, thos

[PATCH v2 17/23] ata: sata_dwc_460ex: supply physical address of FIFO to DMA

2016-04-26 Thread Andy Shevchenko
DMA operates with physical addresses which is not exactly the same as ioremap() returns. Introduce variable to keep physical address of the SATA FIFO register and supply it when prepare DMA channel. Tested-by: Christian Lamparter Signed-off-by: Andy Shevchenko --- drivers/ata/sata_dwc_460ex.c

[PATCH v2 20/23] ata: sata_dwc_460ex: tidy up sata_dwc_clear_dmacr()

2016-04-26 Thread Andy Shevchenko
From: Mans Rullgard This consolidates the reads from each of the if/else branches to one place making the code a lot nicer to look at. Tested-by: Christian Lamparter Signed-off-by: Mans Rullgard --- drivers/ata/sata_dwc_460ex.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions

[PATCH v2 13/23] ata: sata_dwc_460ex: remove empty libata callback

2016-04-26 Thread Andy Shevchenko
From: Mans Rullgard The sata_dwc_qc_prep() does nothing. Use the default ata_noop_qc_prep instead. Tested-by: Christian Lamparter Signed-off-by: Mans Rullgard --- drivers/ata/sata_dwc_460ex.c | 22 -- 1 file changed, 22 deletions(-) diff --git a/drivers/ata/sata_dwc_460e

[PATCH v2 14/23] ata: sata_dwc_460ex: get rid of some pointless casts

2016-04-26 Thread Andy Shevchenko
From: Mans Rullgard Casting a pointer to unsigned long only to immediately cast it back to a pointer makes no sense. Fix this. Tested-by: Christian Lamparter Signed-off-by: Mans Rullgard --- drivers/ata/sata_dwc_460ex.c | 30 +++--- 1 file changed, 15 insertions(+), 1

[PATCH v2 15/23] ata: sata_dwc_460ex: get rid of incorrect cast

2016-04-26 Thread Andy Shevchenko
From: Mans Rullgard The (void *__iomem) cast is wrong. Change the target type of the "base" pointer to void __iomem instead and drop the cast. Tested-by: Christian Lamparter Signed-off-by: Mans Rullgard --- drivers/ata/sata_dwc_460ex.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-

[PATCH v2 12/23] ata: sata_dwc_460ex: correct HOSTDEV{P}_FROM_*() macros

2016-04-26 Thread Andy Shevchenko
Here we refactor HOSTDEV{P}_FROM_*() macros to fit one line and fix the definition of HSDEV_FROM_HSDEVP() where wrong name of the parameter waas used. Tested-by: Christian Lamparter Signed-off-by: Andy Shevchenko --- drivers/ata/sata_dwc_460ex.c | 17 ++--- 1 file changed, 6 inserti

[PATCH v2 10/23] ata: sata_dwc_460ex: add phy support

2016-04-26 Thread Andy Shevchenko
From: Mans Rullgard This adds support for powering on an optional PHY when activating the device. Tested-by: Christian Lamparter Signed-off-by: Mans Rullgard --- drivers/ata/Kconfig | 1 + drivers/ata/sata_dwc_460ex.c | 22 ++ 2 files changed, 23 insertions(+) d

[PATCH v2 09/23] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

2016-04-26 Thread Andy Shevchenko
From: Mans Rullgard Currently this driver only works with a DesignWare DMA engine which it registers manually using the second "reg" address range and interrupt number from the DT node. This patch makes the driver instead use the "dmas" property if present, otherwise optionally falling back on t

[PATCH v2 05/23] ata: sata_dwc_460ex: DMA is always a flow controller

2016-04-26 Thread Andy Shevchenko
In the original code the DMA is always a flow controller. Set this accordingly in updated code. Tested-by: Christian Lamparter Signed-off-by: Andy Shevchenko --- drivers/ata/sata_dwc_460ex.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ata/sata_dwc_460ex.c b/drive

[PATCH v2 08/23] ata: sata_dwc_460ex: don't call ata_sff_qc_issue() on DMA commands

2016-04-26 Thread Andy Shevchenko
ata_sff_qc_issue() can't handle DMA commands and thus we have to avoid it for them. Do call ata_bmdma_qc_issue() instead for this case. Note that the former one distinguishes PIO and DMA mode and behaves accordingly. Suggested-by: Christian Lamparter Signed-off-by: Andy Shevchenko --- drivers/a

[PATCH v2 06/23] ata: sata_dwc_460ex: select only core part of DMA driver

2016-04-26 Thread Andy Shevchenko
There is no need to have a platform driver compiled since the DMA driver is used as a library. Tested-by: Christian Lamparter Signed-off-by: Andy Shevchenko --- drivers/ata/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig inde

[PATCH v2 03/23] ata: sata_dwc_460ex: set dma_boundary to 0x1fff

2016-04-26 Thread Andy Shevchenko
The original code states: Make sure a LLI block is not created that will span 8K max FIS boundary. If the block spans such a FIS boundary, there is a chance that a DMA burst will cross that boundary -- this results in an error in the host controller. Since we have

[PATCH v2 00/23] ata: sata_dwc_460ex: make it working again

2016-04-26 Thread Andy Shevchenko
The last approach in the commit 8b3444852a2b ("sata_dwc_460ex: move to generic DMA driver") to switch to generic DMA engine API wasn't tested on bare metal. Besides that we expecting new board support coming with the same SATA IP but with different DMA. This series is targetting the following thin

[PATCH v2 02/23] ata: sata_dwc_460ex: fix crash on offline links without an attached drive

2016-04-26 Thread Andy Shevchenko
From: Christian Lamparter This patch fixes Machine Check "Data Write PLB Error" which happens when libata-sff's ata_sff_dev_select is trying to write into the device_addr in order to select a drive. However, SATA has no master or slave devices like the old ATA Bus, therefore selecting a different

[PATCH] powerpc/mpic: handle subsys_system_register() failure

2016-04-26 Thread Andrew Donnellan
mpic_init_sys() currently doesn't check whether subsys_system_register() succeeded or not. Check the return code of subsys_system_register() and clean up if there's an error. Signed-off-by: Andrew Donnellan --- Found by Coverity Scan. Build-tested only. --- arch/powerpc/sysdev/mpic.c | 9 +

Re: [PATCH] powerpc: Add support for userspace P9 copy paste

2016-04-26 Thread Balbir Singh
> /* > * System calls. > @@ -508,6 +509,14 @@ BEGIN_FTR_SECTION > ldarxr6,0,r1 > END_FTR_SECTION_IFSET(CPU_FTR_STCX_CHECKS_ADDRESS) > > +BEGIN_FTR_SECTION > +/* > + * A cp_abort (copy paste abort) here ensures that when context switching, a > + * copy from one process can't leak into the

Re: [PATCH 1/2] powerpc/85xx: adapt QorIQ eSDHC to the new clocking model

2016-04-26 Thread Scott Wood
On 04/26/2016 01:29 AM, Yangbo Lu wrote: > > >> -Original Message- >> From: Yangbo Lu >> Sent: Tuesday, April 26, 2016 2:19 PM >> To: 'Scott Wood'; linux-...@vger.kernel.org; linuxppc- >> d...@lists.ozlabs.org; devicet...@vger.kernel.org >> Cc: ulf.hans...@linaro.org; Rob Herring; Scott W