Re: [PATCH V2] QorIQ/TMU: add thermal management support based on TMU

2015-07-29 Thread Eduardo Valentin
On Wed, Jul 29, 2015 at 02:19:39PM +0800, Jia Hongtao wrote: > It supports one critical trip point and one passive trip point. > The cpufreq is used as the cooling device to throttle CPUs when > the passive trip is crossed. > > Signed-off-by: Jia Hongtao > --- > This patch based on: > http://patc

[PATCH] powerpc/eeh-powernv: Fix unbalanced IRQ warning

2015-07-29 Thread Alistair Popple
pnv_eeh_next_error() re-enables the eeh opal event interrupt but it gets called from a loop if there are more outstanding events to process, resulting in a warning due to enabling an already enabled interrupt. Instead the interrupt should only be re-enabled once the last outstanding event has been

[PATCH] powerpc/powernv: Fix unbalanced IRQ warning in eeh-powernv.c

2015-07-29 Thread Michael Ellerman
To avoid EEH getting invoked repeatedly for the same error, the OPAL interrupt that invokes EEH is masked at the start of the process. Currently, pnv_eeh_next_error() re-enables the interrupt but it gets called from a loop if there are more outstanding events to process. This causes an unbalanced

[PATCH v2] powerpc/kernel: Enable seccomp filter

2015-07-29 Thread Michael Ellerman
This commit enables seccomp filter on powerpc, now that we have all the necessary pieces in place. To support seccomp's desire to modify the syscall return value under some circumstances, we use a different ABI to the ptrace ABI. That is we use r3 as the syscall return value, and orig_gpr3 is the

Re: [PATCH] powerpc/powernv: use one M64 BAR in Single PE mode for one VF BAR

2015-07-29 Thread Wei Yang
On Thu, Jul 30, 2015 at 11:15:01AM +1000, Gavin Shan wrote: >On Wed, Jul 29, 2015 at 03:22:07PM +0800, Wei Yang wrote: >>In current implementation, when VF BAR is bigger than 64MB, it uses 4 M64 >>BAR in Single PE mode to cover the number of VFs required to be enabled. >>By doing so, several VFs wo

RE: [PATCH][v2] powerpc/fsl-booke: Add T1040D4RDB/T1042D4RDB board support

2015-07-29 Thread Priyanka Jain
> -Original Message- > From: Wood Scott-B07421 > Sent: Thursday, July 30, 2015 3:45 AM > To: Jain Priyanka-B32167 > Cc: linuxppc-dev@lists.ozlabs.org > Subject: Re: [PATCH][v2] powerpc/fsl-booke: Add T1040D4RDB/T1042D4RDB > board support > > On Wed, 2015-07-29 at 04:07 -0500, Jain Priyan

[PATCH][v3] powerpc/fsl-booke: Add T1040D4RDB/T1042D4RDB board support

2015-07-29 Thread Priyanka Jain
T1040D4RDB/T1042D4RDB are Freescale Reference Design Board which can support T1040/T1042 QorIQ Power Architectureâ„¢ processor respectively T1040D4RDB/T1042D4RDB board Overview - - SERDES Connections, 8 lanes supporting: - PCI - SGMII - SAT

RE: [RFC v2] genalloc:add an gen_pool_first_fit_align algo to genalloc

2015-07-29 Thread Zhao Qiang
On Thu, 2015-07-30 at 5:21, Scott Wood wrote: > -Original Message- > From: Wood Scott-B07421 > Sent: Thursday, July 30, 2015 12:19 AM > To: Zhao Qiang-B45475 > Cc: lau...@codeaurora.org; linux-ker...@vger.kernel.org; linuxppc- > d...@lists.ozlabs.org; a...@linux-foundation.org; o...@lixom.n

Re: [PATCH] powerpc/powernv: use one M64 BAR in Single PE mode for one VF BAR

2015-07-29 Thread Gavin Shan
On Wed, Jul 29, 2015 at 03:22:07PM +0800, Wei Yang wrote: >In current implementation, when VF BAR is bigger than 64MB, it uses 4 M64 >BAR in Single PE mode to cover the number of VFs required to be enabled. >By doing so, several VFs would be in one VF Group and leads to interference >between VFs in

[PATCH] powerpc/eeh: Disable automatically blocked PCI config

2015-07-29 Thread Gavin Shan
pcibios_set_pcie_reset_state() could be called to complete reset request when passing through PCI device, flag EEH_PE_ISOLATED is set before saving the PCI config sapce. On some Broadcom adapters, EEH_PE_CFG_BLOCKED is automatically set when the flag EEH_PE_ISOLATED is marked. It caused bogus data

Re: [PATCH 0/2] powerpc/powernv: Avoid compound PE for VF

2015-07-29 Thread Gavin Shan
On Fri, Jul 17, 2015 at 10:14:41AM +1000, Gavin Shan wrote: >When the VF BAR size is equal to 128MB or bigger than that, the IOV BAR >is extended to cover number of maximal VFs supported by the PF, not 256. >Also, one PHB's M64 BAR is picked to cover VF BARs for 4 continous VFs, >but the PHB's M64

Re: [PATCH v5 1/2] perf,kvm/ppc: Add kvm_perf.h for powerpc

2015-07-29 Thread Scott Wood
On Wed, 2015-07-29 at 16:07 +0530, Hemant Kumar wrote: > Hi Scott, > > On 07/17/2015 01:40 AM, Scott Wood wrote: > > On Thu, 2015-07-16 at 21:18 +0530, Hemant Kumar wrote: > > > To analyze the exit events with perf, we need kvm_perf.h to be added in > > > the arch/powerpc directory, where the kvm

Re: [PATCH][v2] powerpc/fsl-booke: Add T1040D4RDB/T1042D4RDB board support

2015-07-29 Thread Scott Wood
On Wed, 2015-07-29 at 04:07 -0500, Jain Priyanka-B32167 wrote: > > > -Original Message- > > From: Wood Scott-B07421 > > Sent: Friday, July 24, 2015 8:58 PM > > To: Jain Priyanka-B32167 > > Cc: linuxppc-dev@lists.ozlabs.org > > Subject: Re: [PATCH][v2] powerpc/fsl-booke: Add T1040D4RDB/T104

Re: [PATCH] gianfar: Fix warnings when built on 64-bit

2015-07-29 Thread Arnd Bergmann
On Wednesday 29 July 2015 11:02:41 Scott Wood wrote: > On Wed, 2015-07-29 at 10:02 +0200, Arnd Bergmann wrote: > > On Wednesday 29 July 2015 00:24:37 Scott Wood wrote: > > > +#ifdef CONFIG_PM > > > static void lock_tx_qs(struct gfar_private *priv) > > > { > > > int i; > > > @@ -580,6 +581,7 @

Re: [RFC v2] genalloc:add an gen_pool_first_fit_align algo to genalloc

2015-07-29 Thread Scott Wood
On Tue, 2015-07-28 at 00:32 -0500, Zhao Qiang-B45475 wrote: > On Tue, 2015-07-28 at 5:21, Scott Wood wrote: > > -Original Message- > > From: Wood Scott-B07421 > > Sent: Tuesday, July 28, 2015 5:21 AM > > To: Zhao Qiang-B45475 > > Cc: lau...@codeaurora.org; linux-ker...@vger.kernel.org; linu

Re: [PATCH] gianfar: Fix warnings when built on 64-bit

2015-07-29 Thread Scott Wood
On Wed, 2015-07-29 at 10:02 +0200, Arnd Bergmann wrote: > On Wednesday 29 July 2015 00:24:37 Scott Wood wrote: > > +#ifdef CONFIG_PM > > static void lock_tx_qs(struct gfar_private *priv) > > { > > int i; > > @@ -580,6 +581,7 @@ static void unlock_tx_qs(struct gfar_private *priv) > > for (

[PATCH V6 4/6] mm: mlock: Add mlock flags to enable VM_LOCKONFAULT usage

2015-07-29 Thread Eric B Munson
The previous patch introduced a flag that specified pages in a VMA should be placed on the unevictable LRU, but they should not be made present when the area is created. This patch adds the ability to set this state via the new mlock system calls. We add MLOCK_ONFAULT for mlock2 and MCL_ONFAULT f

[PATCH V6 0/6] Allow user to request memory to be locked on page fault

2015-07-29 Thread Eric B Munson
mlock() allows a user to control page out of program memory, but this comes at the cost of faulting in the entire mapping when it is allocated. For large mappings where the entire area is not necessary this is not ideal. Instead of forcing all locked pages to be present when they are allocated, t

[PATCH V6 2/6] mm: mlock: Add new mlock system call

2015-07-29 Thread Eric B Munson
With the refactored mlock code, introduce a new system call for mlock. The new call will allow the user to specify what lock states are being added. mlock2 is trivial at the moment, but a follow on patch will add a new mlock state making it useful. Signed-off-by: Eric B Munson Cc: Michal Hocko

Re: [PATCH v4 04/46] staging: emxx_udc: add ep capabilities support

2015-07-29 Thread Felipe Balbi
On Mon, Jul 27, 2015 at 11:16:14AM +0200, Robert Baldyga wrote: > Convert endpoint configuration to new capabilities model. > > Fixed typo in "epc-nulk" to "epc-bulk". > > Signed-off-by: Robert Baldyga > --- > drivers/staging/emxx_udc/emxx_udc.c | 60 > ++--- >

Re: [PATCH 4/8] xen: Use the correctly the Xen memory terminologies

2015-07-29 Thread Boris Ostrovsky
On 07/29/2015 10:23 AM, Julien Grall wrote: On 29/07/15 15:14, Boris Ostrovsky wrote: static inline unsigned long pfn_to_gfn(unsigned long pfn) { if (xen_feature(XENFEAT_autotranslated_physmap)) return pfn; else return pfn_to_mfn(pfn); } But you'd still say 'op.arg1

Re: [PATCH 4/8] xen: Use the correctly the Xen memory terminologies

2015-07-29 Thread Julien Grall
On 29/07/15 15:14, Boris Ostrovsky wrote: >> static inline unsigned long pfn_to_gfn(unsigned long pfn) >> { >> if (xen_feature(XENFEAT_autotranslated_physmap)) >> return pfn; >> else >> return pfn_to_mfn(pfn); >> } > > > But you'd still say 'op.arg1.mfn = pfn_to_gfn(pfn);'

Re: [PATCH 4/8] xen: Use the correctly the Xen memory terminologies

2015-07-29 Thread Boris Ostrovsky
On 07/29/2015 07:25 AM, Julien Grall wrote: Hi Boris, On 28/07/15 20:12, Boris Ostrovsky wrote: On 07/28/2015 11:02 AM, Julien Grall wrote: Based on include/xen/mm.h [1], Linux is mistakenly using MFN when GFN is meant, I suspect this is because the first support for Xen was for PV. This broug

Re: [PATCH 02/10] dpaa_eth: add support for DPAA Ethernet

2015-07-29 Thread Joakim Tjernlund
On Wed, 2015-07-22 at 19:16 +0300, Madalin Bucur wrote: > This introduces the Freescale Data Path Acceleration Architecture > (DPAA) Ethernet driver (dpaa_eth) that builds upon the DPAA QMan, > BMan, PAMU and FMan drivers to deliver Ethernet connectivity on > the Freescale DPAA QorIQ platforms. >

Re: [Xen-devel] [PATCH 4/8] xen: Use the correctly the Xen memory terminologies

2015-07-29 Thread Wei Liu
On Wed, Jul 29, 2015 at 12:35:54PM +0100, Julien Grall wrote: > Hi Wei, > > On 29/07/15 11:13, Wei Liu wrote: > > On Tue, Jul 28, 2015 at 04:02:45PM +0100, Julien Grall wrote: > > [...] > >> diff --git a/drivers/net/xen-netback/netback.c > >> b/drivers/net/xen-netback/netback.c > >> index 7d50711

Re: [PATCH 4/8] xen: Use the correctly the Xen memory terminologies

2015-07-29 Thread Wei Liu
On Tue, Jul 28, 2015 at 04:02:45PM +0100, Julien Grall wrote: [...] > diff --git a/drivers/net/xen-netback/netback.c > b/drivers/net/xen-netback/netback.c > index 7d50711..3b7b7c3 100644 > --- a/drivers/net/xen-netback/netback.c > +++ b/drivers/net/xen-netback/netback.c > @@ -314,7 +314,7 @@ stati

Re: [PATCH] powerpc/rtas: Introduce rtas_get_sensor_fast() for IRQ handlers

2015-07-29 Thread Thomas Huth
- Original Message - > The EPOW interrupt handler uses rtas_get_sensor(), which in turn > uses rtas_busy_delay() to wait for RTAS becoming ready in case it > is necessary. But rtas_busy_delay() is annotated with might_sleep() > and thus may not be used by interrupts handlers like the EPOW h

Re: [Xen-devel] [PATCH 4/8] xen: Use the correctly the Xen memory terminologies

2015-07-29 Thread David Vrabel
On 29/07/15 12:35, Julien Grall wrote: > Hi Wei, > > On 29/07/15 11:13, Wei Liu wrote: >> On Tue, Jul 28, 2015 at 04:02:45PM +0100, Julien Grall wrote: >> [...] >>> diff --git a/drivers/net/xen-netback/netback.c >>> b/drivers/net/xen-netback/netback.c >>> index 7d50711..3b7b7c3 100644 >>> --- a/d

Re: [Xen-devel] [PATCH 4/8] xen: Use the correctly the Xen memory terminologies

2015-07-29 Thread Julien Grall
Hi Wei, On 29/07/15 11:13, Wei Liu wrote: > On Tue, Jul 28, 2015 at 04:02:45PM +0100, Julien Grall wrote: > [...] >> diff --git a/drivers/net/xen-netback/netback.c >> b/drivers/net/xen-netback/netback.c >> index 7d50711..3b7b7c3 100644 >> --- a/drivers/net/xen-netback/netback.c >> +++ b/drivers/n

Re: [Xen-devel] [PATCH 4/8] xen: Use the correctly the Xen memory terminologies

2015-07-29 Thread Julien Grall
Hi Chris, On 28/07/15 20:39, Chris (Christopher) Brand wrote: >> Based on include/xen/mm.h [1], Linux is mistakenly using MFN when GFN is >> meant, >> I suspect this is because the first support for Xen was for PV. This brough >> some > Typo : "brought" > Perhaps "resulted in" would be better ?

Re: [PATCH 4/8] xen: Use the correctly the Xen memory terminologies

2015-07-29 Thread Julien Grall
Hi Boris, On 28/07/15 20:12, Boris Ostrovsky wrote: > On 07/28/2015 11:02 AM, Julien Grall wrote: >> Based on include/xen/mm.h [1], Linux is mistakenly using MFN when GFN >> is meant, I suspect this is because the first support for Xen was for >> PV. This brough some misimplementation of helpers o

RE: [PATCH] gianfar: Fix warnings when built on 64-bit

2015-07-29 Thread Manoil Claudiu
> -Original Message- > From: Arnd Bergmann [mailto:a...@arndb.de] > Sent: Wednesday, July 29, 2015 11:02 AM > To: linuxppc-dev@lists.ozlabs.org; net...@vger.kernel.org; Manoil Claudiu- > B08782; Wood Scott-B07421 > Subject: Re: [PATCH] gianfar: Fix warnings when built on 64-bit > > On Wedn

Re: [Xen-devel] [PATCH 4/8] xen: Use the correctly the Xen memory terminologies

2015-07-29 Thread Julien Grall
On 28/07/15 18:16, David Vrabel wrote: > On 28/07/15 16:02, Julien Grall wrote: >> Based on include/xen/mm.h [1], Linux is mistakenly using MFN when GFN >> is meant, I suspect this is because the first support for Xen was for >> PV. This brough some misimplementation of helpers on ARM and make the

Re: [PATCH 0/8] Use correctly the Xen memory terminologies in Linux

2015-07-29 Thread Julien Grall
On 28/07/15 16:02, Julien Grall wrote: > Hi all, > > This patch series aims to use the memory terminologies described in > include/linux/mm.h [1] for Linux xen code. I mistakenly wrote the wrong include here. It should be include/xen/mm.h from the Xen tree: http://xenbits.xen.org/gitweb/?p=xen.g

Re: [PATCH V5 0/7] Allow user to request memory to be locked on page fault

2015-07-29 Thread Vlastimil Babka
On 07/29/2015 12:45 PM, Michal Hocko wrote: >> In a much less >> likely corner case, it is not possible in the current setup to request >> all current VMAs be VM_LOCKONFAULT and all future be VM_LOCKED. > > Vlastimil has already pointed that out. MCL_FUTURE doesn't clear > MCL_CURRENT. I was quite

Re: [PATCH V5 0/7] Allow user to request memory to be locked on page fault

2015-07-29 Thread Michal Hocko
On Tue 28-07-15 09:49:42, Eric B Munson wrote: > On Tue, 28 Jul 2015, Michal Hocko wrote: > > > [I am sorry but I didn't get to this sooner.] > > > > On Mon 27-07-15 10:54:09, Eric B Munson wrote: > > > Now that VM_LOCKONFAULT is a modifier to VM_LOCKED and > > > cannot be specified independental

Re: [PATCH v5 1/2] perf,kvm/ppc: Add kvm_perf.h for powerpc

2015-07-29 Thread Hemant Kumar
Hi Scott, On 07/17/2015 01:40 AM, Scott Wood wrote: On Thu, 2015-07-16 at 21:18 +0530, Hemant Kumar wrote: To analyze the exit events with perf, we need kvm_perf.h to be added in the arch/powerpc directory, where the kvm tracepoints needed to trace the KVM exit events are defined. This patch a

RE: [PATCH][v2] powerpc/fsl-booke: Add T1040D4RDB/T1042D4RDB board support

2015-07-29 Thread Priyanka Jain
> -Original Message- > From: Wood Scott-B07421 > Sent: Friday, July 24, 2015 8:58 PM > To: Jain Priyanka-B32167 > Cc: linuxppc-dev@lists.ozlabs.org > Subject: Re: [PATCH][v2] powerpc/fsl-booke: Add T1040D4RDB/T1042D4RDB > board support > > On Wed, 2015-07-22 at 05:49 -0500, Jain Priyanka

RE: [PATCH] gianfar: Fix warnings when built on 64-bit

2015-07-29 Thread Manoil Claudiu
> -Original Message- > From: Arnd Bergmann [mailto:a...@arndb.de] > Sent: Wednesday, July 29, 2015 11:02 AM > To: linuxppc-dev@lists.ozlabs.org; net...@vger.kernel.org; Manoil Claudiu- > B08782; Wood Scott-B07421 > Subject: Re: [PATCH] gianfar: Fix warnings when built on 64-bit > > On Wedn

Re: [4/5] powerpc/perf: Change name & type of 'pred' in power_pmu_bhrb_read

2015-07-29 Thread Anshuman Khandual
On 07/29/2015 08:55 AM, Michael Ellerman wrote: > On Tue, 2015-30-06 at 08:20:30 UTC, Anshuman Khandual wrote: >> > Branch record attributes 'mispred' and 'predicted' are single bit >> > fields as defined in the perf ABI. Hence the data type of the field >> > 'pred' used during BHRB processing shou

Re: [PATCH] gianfar: Fix warnings when built on 64-bit

2015-07-29 Thread Arnd Bergmann
On Wednesday 29 July 2015 00:24:37 Scott Wood wrote: > Alternatively, if there's a desire to not mess with this code (I don't > know how to trigger this code path to test it), this driver should be > given dependencies that ensure that it only builds on 32-bit. These are obvious fixes, they shoul

[PATCH v3] powerpc/dts: Add and fix 1588 timer node for eTSEC

2015-07-29 Thread Yangbo Lu
Add 1588 timer node in files: arch/powerpc/boot/dts/bsc9131rdb.dtsi arch/powerpc/boot/dts/bsc9132qds.dtsi arch/powerpc/boot/dts/p1010rdb.dtsi arch/powerpc/boot/dts/p1020rdb-pd.dts arch/powerpc/boot/dts/p1021rdb-pc.dtsi arch/powerpc/boot/dts/p1022ds.dtsi arch/powerpc/boot/dts/p1025twr.dtsi For P2020

RE: [PATCH v2] powerpc/dts: Add and fix 1588 timer node for eTSEC

2015-07-29 Thread Lu Y . B .
Hi Scott, I submitted a v3 patch for this. Sorry for my misunderstanding and thank a lot. Best regards, Yangbo Lu > -Original Message- > From: Wood Scott-B07421 > Sent: Friday, July 24, 2015 11:08 PM > To: Lu Yangbo-B47093 > Cc: linuxppc-dev@lists.ozlabs.org; linux-ker...@vger.kernel.o

Re: [RFC PATCH] powerpc/kexec: Wait 1s for secondaries to enter OPAL

2015-07-29 Thread Stewart Smith
Benjamin Herrenschmidt writes: > On Tue, 2015-07-28 at 16:13 +1000, Samuel Mendoza-Jonas wrote: > >> "It sounds reasonable" was more or less the inspiration :) >> While I was going over some of the code relating to the previous kexec >> fix with Ben he pointed this out and suggested there wasn't >

[PATCH] powerpc/powernv: use one M64 BAR in Single PE mode for one VF BAR

2015-07-29 Thread Wei Yang
In current implementation, when VF BAR is bigger than 64MB, it uses 4 M64 BAR in Single PE mode to cover the number of VFs required to be enabled. By doing so, several VFs would be in one VF Group and leads to interference between VFs in the same group. This patch changes the design by using one M

Re: [PATCH] ipmi/powernv: Fix potential invalid pointer dereference

2015-07-29 Thread Neelesh Gupta
Hi Alistair, Thanks for the review. On 07/28/2015 11:21 PM, Alistair Popple wrote: Hi Neelesh, This fix looks reasonable to me, although Jeremy would be the best person to comment if he has time. I wonder why we bother polling at all given that our event interface should call opal_ipmi_recv()

[PATCH 2/8] powerpc/slb: Rename all the 'slot' occurrences to 'entry'

2015-07-29 Thread Anshuman Khandual
These are essentially SLB individual slots with entries what we are dealing with in these functions. Usage of both 'entry' and 'slot' synonyms makes it real confusing sometimes. This patch makes it uniform across the file by replacing all those 'slot's with 'entry's. Signed-off-by: Anshuman Khandu

[PATCH 8/8] powerpc/xmon: Add some more elements to the existing PACA dump list

2015-07-29 Thread Anshuman Khandual
This patch adds a set of new elements to the existing PACA dump list inside an xmon session which can be listed below improving the overall xmon debug support. (1) hmi_event_available (2) dscr_default (3) vmalloc_sllp (4) slb_cache_ptr (5) sprg_vdso (6) tm_scratch (7) core_idle_state_ptr (8) threa

[PATCH 1/8] powerpc/slb: Remove a duplicate extern variable

2015-07-29 Thread Anshuman Khandual
This patch just removes one redundant entry for one extern variable 'slb_compare_rr_to_size' from the scope. This patch does not change any functionality. Signed-off-by: Anshuman Khandual --- arch/powerpc/mm/slb.c | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/powerpc/mm/slb.c b/arch/po

[PATCH 3/8] powerpc/slb: Define macros for the bolted slots

2015-07-29 Thread Anshuman Khandual
This patch defines macros for all the three bolted SLB slots. This also renames the 'create_shadowed_slb' function as 'new_shadowed_slb'. Signed-off-by: Anshuman Khandual --- arch/powerpc/mm/slb.c | 29 + 1 file changed, 17 insertions(+), 12 deletions(-) diff --git a

[PATCH 4/8] powerpc/slb: Add some helper functions to improve modularization

2015-07-29 Thread Anshuman Khandual
This patch adds the following six helper functions to help improve modularization and readability of the code. (1) slb_invalidate_all: Invalidates the entire SLB (2) slb_invalidate: Invalidates SLB entries present in PACA (3) mmu_linear_vsid_flags: VSID flags for kernel li

[PATCH 5/8] powerpc/slb: Add documentation to runtime patching of SLB encoding

2015-07-29 Thread Anshuman Khandual
This patch adds some documentation to 'patch_slb_encoding' function explaining about how it clears the existing immediate value in the given instruction and inserts a new one there. Signed-off-by: Anshuman Khandual --- arch/powerpc/mm/slb.c | 13 - 1 file changed, 12 insertions(+), 1

[PATCH 6/8] powerpc/prom: Simplify the logic while fetching SLB size

2015-07-29 Thread Anshuman Khandual
This patch just simplifies the existing code logic while fetching the SLB size property from the device tree. This also changes the function name from check_cpu_slb_size to init_mmu_slb_size as it just initializes the mmu_slb_size value. Signed-off-by: Anshuman Khandual --- arch/powerpc/kernel/p

[PATCH 7/8] powerpc/xmon: Drop the 'valid' variable completely in 'dump_segments'

2015-07-29 Thread Anshuman Khandual
Value of the 'valid' variable is zero when 'esid' is zero and it does not matter when 'esid' is non-zero. The variable 'valid' can be dropped from the function 'dump_segments' by checking for validity of 'esid' inside the nested code block. This patch does that change. Signed-off-by: Anshuman Khan