Re: [RFC PATCH] powerpc/numa: initialize distance lookup table from drconf path

2015-06-25 Thread Nikunj A Dadhania
Hi Anton/Michael, Nikunj A Dadhania writes: > Hi Anton, > > Anton Blanchard writes: >> Hi Nikunj, >> >>> From: Nikunj A Dadhania >>> >>> powerpc/numa: initialize distance lookup table from drconf path >>> >>> In some situations, a NUMA guest that supports >>> ibm,dynamic-memory-reconfigurati

Re: [PATCH v4 3/3] leds/powernv: Add driver for PowerNV platform

2015-06-25 Thread Vasant Hegde
On 06/25/2015 06:39 AM, Benjamin Herrenschmidt wrote: > On Tue, 2015-04-28 at 15:40 +0530, Vasant Hegde wrote: > >> +Device Tree binding for LEDs on IBM Power Systems >> +- >> + >> +The 'led' node under '/ibm,opal' lists service indicators available

Re: [PATCH v4] powerpc/rcpm: add RCPM driver

2015-06-25 Thread Scott Wood
On Tue, 2015-06-23 at 16:07 +0800, yuantian.t...@freescale.com wrote: > From: Tang Yuantian > > There is a RCPM (Run Control/Power Management) in Freescale QorIQ > series processors. The device performs tasks associated with device > run control and power management. > > The driver implements so

Re: [v2,5/9] fsl/fman: Add Frame Manager support

2015-06-25 Thread Scott Wood
On Wed, 2015-06-24 at 22:35 +0300, igal.liber...@freescale.com wrote: > From: Igal Liberman > > Add Frame Manger Driver support. > This patch adds The FMan configuration, initialization and > runtime control routines. > > Signed-off-by: Igal Liberman > --- > drivers/net/ethernet/freescale/fman

Re: [v2,9/9] fsl/fman: Add FMan MAC driver

2015-06-25 Thread Scott Wood
On Fri, 2015-06-26 at 12:21 +1000, Michael Ellerman wrote: > On Thu, 2015-06-25 at 19:59 -0500, Scott Wood wrote: > > On Fri, 2015-06-26 at 01:06 +0200, Paul Bolle wrote: > > > (Evolution 3.16 is basically unbearable for replying to patches. > > > Anyone > > > else running into this?) > > > > If

Re: [v2,9/9] fsl/fman: Add FMan MAC driver

2015-06-25 Thread Michael Ellerman
On Thu, 2015-06-25 at 19:59 -0500, Scott Wood wrote: > On Fri, 2015-06-26 at 01:06 +0200, Paul Bolle wrote: > > (Evolution 3.16 is basically unbearable for replying to patches. > > Anyone > > else running into this?) > > If you mean the crazy lag when selecting moderate-to-large amounts of > te

Re: [v2,4/9] fsl/fman: Add FMan MURAM support

2015-06-25 Thread Scott Wood
On Wed, 2015-06-24 at 22:34 +0300, igal.liber...@freescale.com wrote: > + struct muram_info *p_muram; No Hungarian notation. > +void fm_muram_free(struct muram_info *p_muram) > +{ > + /* Destroy pool */ > + gen_pool_destroy(p_muram->pool); > + /* Unmap memory */ > + iounmap(p_

Re: [v2,3/9] fsl/fman: Add the FMan MAC FLIB

2015-06-25 Thread Scott Wood
On Wed, 2015-06-24 at 22:34 +0300, igal.liber...@freescale.com wrote: > From: Igal Liberman > > The FMan MAC FLib provides basic API used by the drivers to > configure and control the FMan MAC hardware. > > Signed-off-by: Igal Liberman ... > > +int fman_dtsec_mii_write_reg(struct dtsec_mii_reg

Re: [v2,1/9] fsl/fman: Add the FMan FLIB

2015-06-25 Thread Scott Wood
On Wed, 2015-06-24 at 22:33 +0300, igal.liber...@freescale.com wrote: > From: Igal Liberman > > The FMan FLib provides the basic API used by the FMan drivers to > > configure and control the FMan hardware. > > Signed-off-by: Igal Liberman Again, what is an FLib? What determines whether conten

Re: [v2,9/9] fsl/fman: Add FMan MAC driver

2015-06-25 Thread Scott Wood
On Fri, 2015-06-26 at 01:06 +0200, Paul Bolle wrote: > (Evolution 3.16 is basically unbearable for replying to patches. > Anyone > else running into this?) If you mean the crazy lag when selecting moderate-to-large amounts of text (for snipping), yes. -Scott __

Re: [v2,5/9] fsl/fman: Add Frame Manager support

2015-06-25 Thread Paul Bolle
On Fri, 2015-06-26 at 01:53 +0200, Paul Bolle wrote: > So I decided to pick one subject: exports. I think I had something to > comment on all eight of them. s/eight/twelve/ Paul Bolle ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://

Re: [v2,5/9] fsl/fman: Add Frame Manager support

2015-06-25 Thread Paul Bolle
On Wed, 2015-06-24 at 22:35 +0300, igal.liber...@freescale.com wrote: > --- /dev/null > +++ b/drivers/net/ethernet/freescale/fman/fm_drv.c > +u16 fm_get_max_frm(void) > +{ > + return fsl_fm_max_frm; > +} > +EXPORT_SYMBOL(fm_get_max_frm); Which module is using this export? (And what does this

Re: [v2,8/9] fsl/fman: Add FMan Port Support

2015-06-25 Thread Paul Bolle
On Wed, 2015-06-24 at 22:37 +0300, igal.liber...@freescale.com wrote: > --- a/drivers/net/ethernet/freescale/fman/fm_drv.c > +++ b/drivers/net/ethernet/freescale/fman/fm_drv.c > +struct fm_port_t *fm_port_drv_handle(const struct fm_port_drv_t *port) > +{ > + return port->fm_port; > +} > +EXPOR

Re: [v2,9/9] fsl/fman: Add FMan MAC driver

2015-06-25 Thread Paul Bolle
(Evolution 3.16 is basically unbearable for replying to patches. Anyone else running into this?) On Wed, 2015-06-24 at 22:37 +0300, igal.liber...@freescale.com wrote: > > --- /dev/null > +++ b/drivers/net/ethernet/freescale/fman/mac/mac-api.c > +int set_mac_active_pause(struct mac_device *mac_de

Re: [8/8] powerpc/perf: cleanup in perf_event_print_debug()

2015-06-25 Thread Michael Ellerman
On Thu, 2015-11-06 at 08:43:37 UTC, Madhavan Srinivasan wrote: > From: Janani > > Code cleanup/fix in perf_event_print_debug(). Performance > Monitoring Unit (PMU) registers in the server side > are 64bit long. No they're not, see the ISA, figure 17. cheers _

Re: powerpc,numa: Memory hotplug to memory-less nodes ?

2015-06-25 Thread Nishanth Aravamudan
On 24.06.2015 [07:13:36 -0500], Nathan Fontenot wrote: > On 06/23/2015 11:01 PM, Bharata B Rao wrote: > > So will it be correct to say that memory hotplug to memory-less node > > isn't supported by PowerPC kernel ? Should I enforce the same in QEMU > > for PowerKVM ? > > > > I'm not sure if that i

Re: [RESEND PATCH V2 1/3] Add mmap flag to request pages are locked after page fault

2015-06-25 Thread Eric B Munson
On Wed, 24 Jun 2015, Michal Hocko wrote: > On Mon 22-06-15 10:18:06, Eric B Munson wrote: > > On Mon, 22 Jun 2015, Michal Hocko wrote: > > > > > On Fri 19-06-15 12:43:33, Eric B Munson wrote: > [...] > > > > Are you objecting to the addition of the VMA flag VM_LOCKONFAULT, or the > > > > new MAP_

Re: [RESEND PATCH V2 0/3] Allow user to request memory to be locked on page fault

2015-06-25 Thread Andy Lutomirski
On Thu, Jun 25, 2015 at 7:16 AM, Eric B Munson wrote: > On Tue, 23 Jun 2015, Vlastimil Babka wrote: > >> On 06/15/2015 04:43 PM, Eric B Munson wrote: >> >> >> >>If the new LOCKONFAULT functionality is indeed desired (I haven't >> >>still decided myself) then I agree that would be the cleanest way.

Re: [RESEND PATCH V2 0/3] Allow user to request memory to be locked on page fault

2015-06-25 Thread Eric B Munson
On Tue, 23 Jun 2015, Vlastimil Babka wrote: > On 06/15/2015 04:43 PM, Eric B Munson wrote: > >>Note that the semantic of MAP_LOCKED can be subtly surprising: > >> > >>"mlock(2) fails if the memory range cannot get populated to guarantee > >>that no future major faults will happen on the range. > >

Re: [GIT PULL 00/13] perf/core improvements and fixes

2015-06-25 Thread Arnaldo Carvalho de Melo
Em Thu, Jun 25, 2015 at 09:31:41AM +0200, Ingo Molnar escreveu: > Pulled, thanks a lot Arnaldo! > > Btw., one small thing I noticed about the status line in perf top: if I ever > use > 'f' to freeze/unfreeze events, the following message: > > Press 'f' to disable the events or 'h' to see othe

Re: [RFC] powerpc, tm: Drop tm_orig_msr from thread_struct

2015-06-25 Thread Anshuman Khandual
On 04/24/2015 10:31 AM, Anshuman Khandual wrote: > On 04/20/2015 01:45 PM, Anshuman Khandual wrote: >> Currently tm_orig_msr is getting used during process context switch only. >> Then there is ckpt_regs which saves the checkpointed userspace context >> The MSR slot contained in ckpt_regs structure

Re: [PATCH V9 06/13] powerpc, perf: Re organize BHRB processing

2015-06-25 Thread Anshuman Khandual
On 06/25/2015 11:22 AM, Daniel Axtens wrote: > >> +static void insert_branch(struct cpu_hw_events *cpuhw, >> +int index, u64 from, u64 to, int mispred) > Given that your previous patch made mispred a bool, this could take a > bool too. It could probably be an inline function as

Re: [PATCH V9 05/13] powerpc, perf: Change name & type of 'pred' in power_pmu_bhrb_read

2015-06-25 Thread Anshuman Khandual
On 06/25/2015 10:41 AM, Daniel Axtens wrote: >> cpuhw->bhrb_entries[u_index].to = addr; >> -cpuhw->bhrb_entries[u_index].mispred = pred; >> -cpuhw->bhrb_entries[u_index].predicted = ~pred; >> +

Re: [PATCH V9 04/13] powerpc, perf: Restore privilege level filter support for BHRB

2015-06-25 Thread Anshuman Khandual
On 06/25/2015 10:32 AM, Daniel Axtens wrote: > >> diff --git a/arch/powerpc/perf/core-book3s.c >> b/arch/powerpc/perf/core-book3s.c >> index 7a03cce..892340e 100644 >> --- a/arch/powerpc/perf/core-book3s.c >> +++ b/arch/powerpc/perf/core-book3s.c >> @@ -930,7 +930,7 @@ static int power_check_cons

Re: [PATCH V9 02/13] powerpc, perf: Change type of the bhrb_users variable

2015-06-25 Thread Anshuman Khandual
On 06/25/2015 11:12 AM, Daniel Axtens wrote: >> -int bhrb_users; >> +unsigned intbhrb_users; > > OK, so this is a good start. > > A quick git grep for bhrb_users reveals this: > perf/core-book3s.c: WARN_ON_ONCE(cpuhw->bhrb_users < 0); >

Re: [PATCH V9 00/13] powerpc, perf: Enable SW branch filters

2015-06-25 Thread Anshuman Khandual
On 06/25/2015 11:48 AM, Daniel Axtens wrote: > Hi Anshuman, > > Thanks for your continued work on this. > > Given that the series is now at version 9 and is 13 patches long, I > wonder if it might be worth splitting it up. Splitting it up completely or just keeping all the generic fixes and cle

[PATCH v3 7/7]powerpc/powernv: nest pmu cpumask and cpu hotplug support

2015-06-25 Thread Madhavan Srinivasan
Adds cpumask attribute to be used by each nest pmu since nest units are per-chip. Only one cpu (first online cpu) from each node/chip is designated to read counters. On cpu hotplug, dying cpu is checked to see whether it is one of the designated cpus, if yes, next online cpu from the same node/chi

[PATCH v3 6/7]powerpc/powernv: generic nest pmu event functions

2015-06-25 Thread Madhavan Srinivasan
Add set of generic nest pmu related event functions to be used by each nest pmu. Add code to register nest pmus. Cc: Michael Ellerman Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Anton Blanchard Cc: Sukadev Bhattiprolu Cc: Anshuman Khandual Cc: Stephane Eranian Signed-off-by: Madhavan

[PATCH v3 3/7]powerpc/powernv: Nest PMU detection and device tree parser

2015-06-25 Thread Madhavan Srinivasan
Create a file "nest-pmu.c" to contain nest pmu related functions. Code to detect nest pmu support and parser to collect per-chip reserved memory region information from device tree (DT). Detection mechanism is to look for specific property "ibm,ima-chip" in DT. For Nest pmu, device tree will have

[PATCH v3 4/7]powerpc/powernv: detect supported nest pmus and its events

2015-06-25 Thread Madhavan Srinivasan
Parse device tree to detect supported nest pmu units. Traverse through each nest pmu unit folder to find supported events and corresponding unit/scale files (if any). The nest unit event file from DT, will contain the offset in the reserved memory region to get the counter data for a given event.

[PATCH v3 1/7]powerpc/powernv: Data structure and macros definition

2015-06-25 Thread Madhavan Srinivasan
Create new header file "nest-pmu.h" to add the data structures and macros needed for the nest pmu support. Cc: Michael Ellerman Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Anton Blanchard Cc: Sukadev Bhattiprolu Cc: Anshuman Khandual Cc: Stephane Eranian Signed-off-by: Madhavan Sriniv

[PATCH v3 5/7]powerpc/powernv: add event attribute and group to nest pmu

2015-06-25 Thread Madhavan Srinivasan
Add code to create event/format attributes and attribute groups for each nest pmu. Cc: Michael Ellerman Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Anton Blanchard Cc: Sukadev Bhattiprolu Cc: Anshuman Khandual Cc: Stephane Eranian Signed-off-by: Madhavan Srinivasan --- arch/powerpc/

[PATCH v3 2/7]powerpc/powernv: Add OPAL support for Nest PMU

2015-06-25 Thread Madhavan Srinivasan
Nest Counters can be configured via PORE Engine and OPAL provides an interface to start/stop it. OPAL side patches are posted in the skiboot mailing. Cc: Stewart Smith Cc: Jeremy Kerr Cc: Benjamin Herrenschmidt Cc: Michael Ellerman Cc: Paul Mackerras Cc: Anton Blanchard Cc: Sukadev Bhattipr

[PATCH v3 0/7]powerpc/powernv: Nest Instrumentation support

2015-06-25 Thread Madhavan Srinivasan
This patchset enables Nest Instrumentation support on powerpc. POWER8 has per-chip Nest Intrumentation which provides various per-chip metrics like memory, powerbus, Xlink and Alink bandwidth. Nest Instrumentation provides an interface (via PORE Engine) to configure and move the nest counter data

Re: [PATCH] powerpc/powernv: Fix vma page prot flags in opal-prd driver

2015-06-25 Thread Vaidyanathan Srinivasan
* Vaidyanathan Srinivasan [2015-06-25 11:45:46]: [snip] > Hi Ben, > > remap_pfn_range() is the correct method to map the firmware pages > because we will not have struct page associated with this RAM area. > > We do a memblock_reserve() in early boot and take out this memory from > kernel and

Re: [GIT PULL 00/13] perf/core improvements and fixes

2015-06-25 Thread Ingo Molnar
* Arnaldo Carvalho de Melo wrote: > Hi Ingo, > > Please consider pulling, > > - Arnaldo > > The following changes since commit a9a3cd900fbbcbf837d65653105e7bfc583ced09: > > Merge tag 'perf-core-for-mingo' of > git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core