On Wed, 2015-06-24 at 22:34 +0300, igal.liber...@freescale.com wrote:
> + struct muram_info *p_muram;
No Hungarian notation.
> +void fm_muram_free(struct muram_info *p_muram)
> +{
> + /* Destroy pool */
> + gen_pool_destroy(p_muram->pool);
> + /* Unmap memory */
> + iounmap(p_muram->vbase);
> + /* Free pointer */
> + kfree(p_muram);
> +}
This type of commenting is not useful.
> + memset_io((void __iomem *)vaddr, 0, (int)size);
Unnecessary cast of size.
-Scott
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
