Re: [PATCH v2 2/2] cpufreq: powernv: Register for OCC related opal_message notification

2015-04-27 Thread Viresh Kumar
On 28 April 2015 at 11:53, Shilpasri G Bhat wrote: > Changes from v1: > - Add macros to define OCC_RESET, OCC_LOAD and OCC_THROTTLE > - Define a structure to store chip id, chip mask which has bits set > for cpus present in the chip, throttled state and a work_struct. > - Modify powernv_cpufreq

Re: Build regressions/improvements in v4.1-rc1

2015-04-27 Thread Rusty Russell
Geert Uytterhoeven writes: > On Mon, Apr 27, 2015 at 11:51 AM, Geert Uytterhoeven > wrote: >> Below is the list of build error/warning regressions/improvements in >> v4.1-rc1[1] compared to v4.0[2]. >> >> Summarized: >> - build errors: +34/-11 >> - build warnings: +135/-163 >> >> As I haven't

[PATCH v2 2/2] cpufreq: powernv: Register for OCC related opal_message notification

2015-04-27 Thread Shilpasri G Bhat
OCC is an On-Chip-Controller which takes care of power and thermal safety of the chip. During runtime due to power failure or overtemperature the OCC may throttle the frequencies of the CPUs to remain within the power budget. We want the cpufreq driver to be aware of such situations to be able to

[PATCH v2 1/2] powerpc/powernv: Add definition of OPAL_MSG_OCC message type

2015-04-27 Thread Shilpasri G Bhat
Add OPAL_MSG_OCC message definition to opal_message_type to receive OCC events like reset, load and throttled. Host performance can be affected when OCC is reset or OCC throttles the max Pstate. We can register to opal_message_notifier to receive OPAL_MSG_OCC type of message and report it to the us

[PATCH v2 0/2] powernv: cpufreq: Report frequency throttle by OCC

2015-04-27 Thread Shilpasri G Bhat
This patchset intends to add frequency throttle reporting mechanism to powernv-cpufreq driver when OCC throttles the frequency. OCC is an On-Chip-Controller which takes care of the power and thermal safety of the chip. The CPU frequency can be throttled during an OCC reset or when OCC tries to limi

Re: [PATCH 2/2] cpufreq: powernv: Register for OCC related opal_message notification

2015-04-27 Thread Shilpasri G Bhat
Hi Preeti, On 04/23/2015 05:28 PM, Preeti U Murthy wrote: > Hi Shilpa, > > On 04/22/2015 10:34 PM, Shilpasri G Bhat wrote: >> OCC is an On-Chip-Controller which takes care of power and thermal >> safety of the chip. During runtime due to power failure or >> overtemperature the OCC may throttle th

Re: [PATCH 2/2] cpufreq: powernv: Register for OCC related opal_message notification

2015-04-27 Thread Shilpasri G Bhat
Hi Viresh, On 04/27/2015 10:02 AM, Viresh Kumar wrote: > On 22 April 2015 at 22:34, Shilpasri G Bhat > wrote: >> diff --git a/drivers/cpufreq/powernv-cpufreq.c >> b/drivers/cpufreq/powernv-cpufreq.c > >> +static char throttle_reason[6][50] = { "No throttling", > > Don't need to mention 6 here.

[PATCH 3/3] powerpc/powernv: Move dma_set_mask from pnv_phb to pci_controller_ops

2015-04-27 Thread Daniel Axtens
Previously, dma_set_mask on powernv was convoluted: 0) Call dma_set_mask (kernel/dma.c) 1) In dma_set_mask, ppc_md.dma_set_mask exists, so call it. 2) On powernv, that function pointer is pnv_dma_set_mask. In pnv_dma_set_mask, the device is pci, so call pnv_pci_dma_set_mask. 3) In pnv_pci_dma_se

[PATCH 2/3] powerpc/pci: add dma_set_mask to pci_controller_ops

2015-04-27 Thread Daniel Axtens
Some systems only need to deal with DMA masks for PCI devices. For these systems, we can avoid the need for a platform hook and instead use a pci controller based hook. Signed-off-by: Daniel Axtens --- arch/powerpc/include/asm/pci-bridge.h | 2 ++ arch/powerpc/kernel/dma.c | 11

[PATCH 1/3] powerpc/powernv: Specialise pci_controller_ops for each controller type

2015-04-27 Thread Daniel Axtens
Remove powernv generic PCI controller operations. Replace it with controller ops for each of the two supported PHBs. As an added bonus, make the two new structs const, which will help guard against bugs such as the one introduced in 65ebf4b63 ("powerpc/powernv: Move controller ops from ppc_md to c

[PATCH 0/3] Add dma_set_mask to pci_controller_ops

2015-04-27 Thread Daniel Axtens
This adds dma_set_mask to pci_controller_ops. Currently it's only implemented on PowerNV, because it gets very messy on systems that have more than just simple PCI busses. On the plus side, this series massively simplifies the code path on PowerNV (see patch #3). It is based on my recent MSI pat

Re: Kernel 4.1-rc1 build fails on Sam460ex amcc 460ex powerpc Canyonlands

2015-04-27 Thread Tejun Heo
On Tue, Apr 28, 2015 at 11:12:25AM +1000, Michael Ellerman wrote: > On Mon, 2015-04-27 at 06:59 -0400, Julian Margetson wrote: > > Kernel 4.1-rc1 build fails on Sam460ex amcc 460ex powerpc Canyonlands with > > CONFIG_SATA_DWC=y > > > > sata_dwc_460ex.c:(.text+0xa165c): undefined reference to `dw

Re: Kernel 4.1-rc1 build fails on Sam460ex amcc 460ex powerpc Canyonlands

2015-04-27 Thread Michael Ellerman
On Mon, 2015-04-27 at 06:59 -0400, Julian Margetson wrote: > Kernel 4.1-rc1 build fails on Sam460ex amcc 460ex powerpc Canyonlands with > CONFIG_SATA_DWC=y > > sata_dwc_460ex.c:(.text+0xa165c): undefined reference to `dw_dma_remove' > drivers/built-in.o: In function `sata_dwc_probe': > sata_dwc_

[PATCH] powerpc/kvm: Fix SMP=n build error in book3s_xics.c

2015-04-27 Thread Michael Ellerman
Commit 34cb7954c0aa "Convert ICS mutex lock to spin lock" added an include of asm/spinlock.h, which does not work in the SMP=n case. It should instead include linux/spinlock.h Fixes: 34cb7954c0aa ("KVM: PPC: Book3S HV: Convert ICS mutex lock to spin lock") Signed-off-by: Michael Ellerman --- I'

Re: [PATCH net-next v2 4/4] ibmveth: Add support for Large Receive Offload

2015-04-27 Thread Eric Dumazet
On Mon, 2015-04-27 at 17:10 -0500, Thomas Falcon wrote: > + if (be16_to_cpu(skb->protocol) == ETH_P_IP) { > + skb_set_network_header(skb, 0); > + skb_set_transport_header(skb, > sizeof(struct ip

Re: [PATCH kernel v9 30/32] vfio: powerpc/spapr: Use 32bit DMA window properties from table_group

2015-04-27 Thread Alex Williamson
On Sat, 2015-04-25 at 22:14 +1000, Alexey Kardashevskiy wrote: > A table group might not have a table but it always has the default 32bit > window parameters so use these. > > No change in behavior is expected. > > Signed-off-by: Alexey Kardashevskiy > --- > Changes: > v9: > * new in the series

[PATCH net-next v2 4/4] ibmveth: Add support for Large Receive Offload

2015-04-27 Thread Thomas Falcon
Enables receiving large packets from other LPARs. These packets have a -1 IP header checksum, so we must recalculate to have a valid checksum. Signed-off-by: Brian King Signed-off-by: Thomas Falcon --- v2: -Included statistics that were previously in a separate patch -Zeroed the IP header che

[PATCH net-next v2 3/4] ibmveth: Add GRO support

2015-04-27 Thread Thomas Falcon
Cc: Brian King Signed-off-by: Thomas Falcon --- drivers/net/ethernet/ibm/ibmveth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/ibm/ibmveth.c b/drivers/net/ethernet/ibm/ibmveth.c index 25cfc26..f0ec4e5 100644 --- a/drivers/net/ethernet/ibm/ibmveth.c +

[PATCH net-next v2 2/4] ibmveth: Add support for TSO

2015-04-27 Thread Thomas Falcon
Add support for TSO. TSO is turned off by default and must be enabled and configured by the user. The driver version number is increased so that users can be sure that they are using ibmveth with TSO support. Cc: Brian King Signed-off-by: Thomas Falcon --- v2: Included statistics that were pre

[PATCH net-next v2 1/4] ibmveth: change rx buffer default allocation for CMO

2015-04-27 Thread Thomas Falcon
This patch enables 64k rx buffer pools by default. If Cooperative Memory Overcommitment (CMO) is enabled, the number of 64k buffers is reduced to save memory. Cc: Brian King Signed-off-by: Thomas Falcon --- drivers/net/ethernet/ibm/ibmveth.c | 3 +++ drivers/net/ethernet/ibm/ibmveth.h | 3 ++-

Re: [PATCH kernel v9 16/32] powerpc/powernv/ioda: Move TCE kill register address to PE

2015-04-27 Thread Alex Williamson
On Sat, 2015-04-25 at 22:14 +1000, Alexey Kardashevskiy wrote: > At the moment the DMA setup code looks for the "ibm,opal-tce-kill" property > which contains the TCE kill register address. Writes to this register > invalidates TCE cache on IODA/IODA2 hub. > > This moves the register address from i

Re: [PATCH kernel v9 02/32] Revert "powerpc/powernv: Allocate struct pnv_ioda_pe iommu_table dynamically"

2015-04-27 Thread Alex Williamson
On Sat, 2015-04-25 at 22:14 +1000, Alexey Kardashevskiy wrote: > This reverts commit 9e8d4a19ab66ec9e132d405357b9108a4f26efd3 as > tce32_table has exactly the same life time as the whole PE. scripts/checkpatch.pl would like your commit reference to appear as: commit 9e8d4a19ab66 ("powerpc/powernv

Re: [PATCH v2 RESEND 2/2] mmc: host: Add some quirks to be read from fdt in sdhci-pltm.c

2015-04-27 Thread Arnd Bergmann
On Monday 27 April 2015 21:25:20 Suman Tripathi wrote: > > On Monday 27 April 2015 20:33:25 Suman Tripathi wrote: > > > > On Tuesday 21 April 2015 21:12:39 Suman Tripathi wrote: > > > > > + host->quirks |= SDHCI_QUIRK_BROKEN_DMA; > > > > > + > > > > > + if (of_ge

Re: Build regressions/improvements in v4.1-rc1

2015-04-27 Thread Guenter Roeck
On Mon, Apr 27, 2015 at 12:03:32PM +0200, Geert Uytterhoeven wrote: > On Mon, Apr 27, 2015 at 11:51 AM, Geert Uytterhoeven > wrote: > > Below is the list of build error/warning regressions/improvements in > > v4.1-rc1[1] compared to v4.0[2]. > > > > Summarized: > > - build errors: +34/-11 > >

Re: Build regressions/improvements in v4.1-rc1

2015-04-27 Thread Aaro Koskinen
Hi, On Mon, Apr 27, 2015 at 12:03:32PM +0200, Geert Uytterhoeven wrote: > > *** ERRORS *** > > > > 34 regressions: > > The quiet days are over... > > > + /home/kisskb/slave/src/arch/mips/cavium-octeon/smp.c: error: passing > > argument 2 of 'cpumask_clear_cpu' discards 'volatile' qualifier fr

Re: [PATCH v2 RESEND 2/2] mmc: host: Add some quirks to be read from fdt in sdhci-pltm.c

2015-04-27 Thread Suman Tripathi
On Monday 27 April 2015 20:33:25 Suman Tripathi wrote: > > On Tuesday 21 April 2015 21:12:39 Suman Tripathi wrote: > > > index bef250e..9f6a4b9 100644 > > > --- a/drivers/mmc/host/sdhci-pltfm.c > > > +++ b/drivers/mmc/host/sdhci-pltfm.c > > > @@ -85,6 +85,21 @@ void sdhci_get_of_property(struct pla

Re: [PATCH v2 RESEND 2/2] mmc: host: Add some quirks to be read from fdt in sdhci-pltm.c

2015-04-27 Thread Arnd Bergmann
On Monday 27 April 2015 20:33:25 Suman Tripathi wrote: > > On Tuesday 21 April 2015 21:12:39 Suman Tripathi wrote: > > > index bef250e..9f6a4b9 100644 > > > --- a/drivers/mmc/host/sdhci-pltfm.c > > > +++ b/drivers/mmc/host/sdhci-pltfm.c > > > @@ -85,6 +85,21 @@ void sdhci_get_of_property(struct pla

Re: [PATCH v2 RESEND 2/2] mmc: host: Add some quirks to be read from fdt in sdhci-pltm.c

2015-04-27 Thread Suman Tripathi
On Tuesday 21 April 2015 21:12:39 Suman Tripathi wrote: > index bef250e..9f6a4b9 100644 > --- a/drivers/mmc/host/sdhci-pltfm.c > +++ b/drivers/mmc/host/sdhci-pltfm.c > @@ -85,6 +85,21 @@ void sdhci_get_of_property(struct platform_device *pdev) > > if (of_get_property(np, "broken-cd"

Re: [PATCH v2 2/2] leds/powernv: Add driver for PowerNV platform

2015-04-27 Thread Vasant Hegde
On 04/27/2015 04:45 PM, Jacek Anaszewski wrote: > On 04/27/2015 11:53 AM, Benjamin Herrenschmidt wrote: >> On Mon, 2015-04-27 at 09:24 +0200, Jacek Anaszewski wrote: >>> I was not aware that some other entity than the driver could be >>> interested in the information provided by DT node. I will no

[PATCH] powerpc: Constify irq_domain_ops

2015-04-27 Thread Krzysztof Kozlowski
The irq_domain_ops are not modified by the driver and the irqdomain core code accepts pointer to a const data. Signed-off-by: Krzysztof Kozlowski --- arch/powerpc/sysdev/i8259.c| 2 +- arch/powerpc/sysdev/ipic.c | 2 +- arch/powerpc/sysdev/mpc8xx_pic.c | 2 +- arch/

Re: [PATCH v2 2/2] leds/powernv: Add driver for PowerNV platform

2015-04-27 Thread Jacek Anaszewski
On 04/27/2015 11:53 AM, Benjamin Herrenschmidt wrote: On Mon, 2015-04-27 at 09:24 +0200, Jacek Anaszewski wrote: I was not aware that some other entity than the driver could be interested in the information provided by DT node. I will no longer object, provided that we will get an ack from DT ma

Kernel 4.1-rc1 build fails on Sam460ex amcc 460ex powerpc Canyonlands

2015-04-27 Thread Julian Margetson
Kernel 4.1-rc1 build fails on Sam460ex amcc 460ex powerpc Canyonlands with CONFIG_SATA_DWC=y sata_dwc_460ex.c:(.text+0xa165c): undefined reference to `dw_dma_remove' drivers/built-in.o: In function `sata_dwc_probe': sata_dwc_460ex.c:(.text+0xa1900): undefined reference to `dw_dma_probe' sata_dwc

Re: [PATCH v2 2/2] leds/powernv: Add driver for PowerNV platform

2015-04-27 Thread Jacek Anaszewski
Hi Vasant, On 04/24/2015 12:15 PM, Jacek Anaszewski wrote: [...] For attention and fault LEDs only brightness attribute would matter. Sure. DT bindings would look as follows: opal-leds { compatible = "ibm,opal-leds"; U78C9.001.RST0027-P1-C1:fault { };

Re: [PATCH v2 4/4] pci: Use QEMU created PCI device nodes

2015-04-27 Thread Thomas Huth
On Mon, 27 Apr 2015 15:26:00 +0530 Nikunj A Dadhania wrote: > Thomas Huth writes: > > > On Mon, 27 Apr 2015 13:32:33 +0530 > > Nikunj A Dadhania wrote: > > > >> PCI Enumeration has been part of SLOF. Now with hotplug code addition > >> in QEMU, it makes more sense to have this code in one plac

Re: [PATCH v2 2/4] pci: Support 64-bit address translation

2015-04-27 Thread Thomas Huth
On Mon, 27 Apr 2015 19:57:26 +1000 Benjamin Herrenschmidt wrote: > On Mon, 2015-04-27 at 11:32 +0200, Thomas Huth wrote: > > Anyway, I think we can fix that up as soon as somebody tries to run > > the > > js2x code again (I still have a YDL PowerStation at home somewhere, > > maybe I will have en

Re: Build regressions/improvements in v4.1-rc1

2015-04-27 Thread Geert Uytterhoeven
On Mon, Apr 27, 2015 at 11:51 AM, Geert Uytterhoeven wrote: > Below is the list of build error/warning regressions/improvements in > v4.1-rc1[1] compared to v4.0[2]. > > Summarized: > - build errors: +34/-11 > - build warnings: +135/-163 > > As I haven't mastered kup yet, there's no verbose su

Re: [PATCH v2 2/4] pci: Support 64-bit address translation

2015-04-27 Thread Benjamin Herrenschmidt
On Mon, 2015-04-27 at 11:32 +0200, Thomas Huth wrote: > Anyway, I think we can fix that up as soon as somebody tries to run > the > js2x code again (I still have a YDL PowerStation at home somewhere, > maybe I will have enough spare time to reactivate it one day). > > And since your changes itself

Re: [PATCH v2 4/4] pci: Use QEMU created PCI device nodes

2015-04-27 Thread Nikunj A Dadhania
Thomas Huth writes: > On Mon, 27 Apr 2015 13:32:33 +0530 > Nikunj A Dadhania wrote: > >> PCI Enumeration has been part of SLOF. Now with hotplug code addition >> in QEMU, it makes more sense to have this code in one place, >> i.e. QEMU. >> >> Adding routines to walk through the device nodes cre

Re: [PATCH v2 2/2] leds/powernv: Add driver for PowerNV platform

2015-04-27 Thread Benjamin Herrenschmidt
On Mon, 2015-04-27 at 09:24 +0200, Jacek Anaszewski wrote: > I was not aware that some other entity than the driver could be > interested in the information provided by DT node. I will no longer > object, provided that we will get an ack from DT maintainer. My understanding is that we no longer ne

Re: [PATCH v2 2/4] pci: Support 64-bit address translation

2015-04-27 Thread Thomas Huth
On Mon, 27 Apr 2015 13:32:31 +0530 Nikunj A Dadhania wrote: > Signed-off-by: Nikunj A Dadhania > --- > slof/fs/translate.fs | 6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/slof/fs/translate.fs b/slof/fs/translate.fs > index e2633e5..9654f24 100644 > --- a/slof/fs

Re: [PATCH v2 4/4] pci: Use QEMU created PCI device nodes

2015-04-27 Thread Thomas Huth
On Mon, 27 Apr 2015 13:32:33 +0530 Nikunj A Dadhania wrote: > PCI Enumeration has been part of SLOF. Now with hotplug code addition > in QEMU, it makes more sense to have this code in one place, > i.e. QEMU. > > Adding routines to walk through the device nodes created by QEMU. SLOF > will now co

Re: [PATCH v2 3/4] usb: support 64-bit pci bars

2015-04-27 Thread Thomas Huth
On Mon, 27 Apr 2015 13:32:32 +0530 Nikunj A Dadhania wrote: > With the addition of 64-bit bar ranges (commit: 9fbfed08 - pci: use > 64bit bar ranges), the usb-setup-hcidev needs to handle 64-bit > addresses. > > For example, QEMU provided NEC USB XHCI device requests 64-bit memory > address. Add

Re: [PATCH v2 1/4] pci: program correct bridge limit registers during probe

2015-04-27 Thread Thomas Huth
On Mon, 27 Apr 2015 13:32:30 +0530 Nikunj A Dadhania wrote: > According to the pci-to-pci bridge specification, memory/io limit > should be the last address of the window, while currently its set to > last + 1. It broke when the memory range was increased and hit 32-bit > limit. The last address

[PATCH v2 4/4] pci: Use QEMU created PCI device nodes

2015-04-27 Thread Nikunj A Dadhania
PCI Enumeration has been part of SLOF. Now with hotplug code addition in QEMU, it makes more sense to have this code in one place, i.e. QEMU. Adding routines to walk through the device nodes created by QEMU. SLOF will now configure the device/bridges and program the BARs for communicating with the

[PATCH v2 3/4] usb: support 64-bit pci bars

2015-04-27 Thread Nikunj A Dadhania
With the addition of 64-bit bar ranges (commit: 9fbfed08 - pci: use 64bit bar ranges), the usb-setup-hcidev needs to handle 64-bit addresses. For example, QEMU provided NEC USB XHCI device requests 64-bit memory address. Added code to check the memory type before address translation. Signed-off-b

[PATCH v2 2/4] pci: Support 64-bit address translation

2015-04-27 Thread Nikunj A Dadhania
Signed-off-by: Nikunj A Dadhania --- slof/fs/translate.fs | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/slof/fs/translate.fs b/slof/fs/translate.fs index e2633e5..9654f24 100644 --- a/slof/fs/translate.fs +++ b/slof/fs/translate.fs @@ -33,11 +33,9 @@ dup l@ FF A

[PATCH v2 0/4] PCI: Generic fixes and moving enumeration back to QEMU

2015-04-27 Thread Nikunj A Dadhania
patch 1: Fixes a bug in pci-to-pci bridge while programming the limit registers during probe patch 2,3: Support 64-bit address translation and usb devices can have 64-bit pci memory BARs patch 4: Use QEMU create device tree nodes and program the BARs Nikunj A Dadhania (

[PATCH v2 1/4] pci: program correct bridge limit registers during probe

2015-04-27 Thread Nikunj A Dadhania
According to the pci-to-pci bridge specification, memory/io limit should be the last address of the window, while currently its set to last + 1. It broke when the memory range was increased and hit 32-bit limit. The last address in the window is 0x. and max-mmio is 0x1.., because of

Re: [PATCH v2 2/2] leds/powernv: Add driver for PowerNV platform

2015-04-27 Thread Jacek Anaszewski
Hi Benjamin, Thanks for your explanation. On 04/27/2015 12:07 AM, Benjamin Herrenschmidt wrote: On Thu, 2015-04-23 at 16:13 +0200, Jacek Anaszewski wrote: How the firmware is related to kernel? These bindings are for kernel, not for the firmware. There should be no relation. DT bindings sho

Re: [PATCH 0/2] powerpc/kvm: Enable running guests on RT Linux

2015-04-27 Thread Purcareata Bogdan
On 24.04.2015 00:26, Scott Wood wrote: On Thu, 2015-04-23 at 15:31 +0300, Purcareata Bogdan wrote: On 23.04.2015 03:30, Scott Wood wrote: On Wed, 2015-04-22 at 15:06 +0300, Purcareata Bogdan wrote: On 21.04.2015 03:52, Scott Wood wrote: On Mon, 2015-04-20 at 13:53 +0300, Purcareata Bogdan wro

[PATCH v3 18/21] powerpc/pci: Export traverse_pci_device_nodes()

2015-04-27 Thread Gavin Shan
The patch exports following functions, which are derived from their original implementation, so that the PCI hotplug logic can reuse the functions to add or remove pci_dn for all device nodes under specified PCI slot. traverse_pci_device_nodes() traverse_pci_devices() add_pci_device_node

[PATCH v3 20/21] powerpc/powernv: Select OF_DYNAMIC

2015-04-27 Thread Gavin Shan
The device tree nodes will be changed dynamically on PCI hotplug events on PowerNV platform. The patch selects OF_DYNAMIC on the platform to support PCI hotplug. Signed-off-by: Gavin Shan --- arch/powerpc/platforms/powernv/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/powerpc/

[PATCH v3 17/21] powerpc/pci: Create eeh_dev while creating pci_dn

2015-04-27 Thread Gavin Shan
The eeh_dev is always created based on pci_dn, but with initcall supported by core_initcall_sync(). The patch creates eeh_dev when pci_dn is created, indicating they have same life cycle. Signed-off-by: Gavin Shan --- arch/powerpc/include/asm/eeh.h | 6 -- arch/powerpc/kernel/eeh_de

[PATCH v3 13/21] powerpc/pci: Move pcibios_find_pci_bus() around

2015-04-27 Thread Gavin Shan
The patch moves pcibios_find_pci_bus() to PPC kerenl directory so that it can be reused by hotplug code for pSeries and PowerNV platform at the same time. Signed-off-by: Gavin Shan Acked-by: Benjamin Herrenschmidt --- arch/powerpc/kernel/pci-hotplug.c | 36 +