Re: [PATCH v2] drivers/crypto/nx: saves chaining value from co-processor

2013-08-08 Thread Herbert Xu
On Wed, Aug 07, 2013 at 06:15:50PM -0500, Fionnuala Gunter wrote: > This patch fixes a bug that is triggered when cts(cbc(aes)) is used with > nx-crypto driver on input larger than 32 bytes. > > The chaining value from co-processor was not being saved. This value is > needed because it is used as

Re: [PATCH v2 0/2] drivers/crypto/nx: fixes when input data is too large

2013-08-08 Thread Herbert Xu
On Fri, Aug 02, 2013 at 12:09:50PM +, Marcelo Cerri wrote: > This series of patches fixes two bugs that are triggered when the input data > is > too large. The first one is caused by the miscalculation of physical addresses > and the second one by some limits that the co-processor has to the i

Re: [RFC] powerpc: put the common parts of the ppc64*defconfigs in a Kconfig file

2013-08-08 Thread Michael Neuling
Stephen Rothwell wrote: > We cannot put the unsetting of config options in the Kconfig file, nor > the integer or string options. > > I checked that after this we get the same .config files generated (except > for the addition of the new PPC64_DEFCONFIG* config options. > > Any thoughts? +1 M

Re: [PATCH v2] drivers/crypto/nx: saves chaining value from co-processor

2013-08-08 Thread Benjamin Herrenschmidt
On Wed, 2013-08-07 at 18:15 -0500, Fionnuala Gunter wrote: > This patch fixes a bug that is triggered when cts(cbc(aes)) is used with > nx-crypto driver on input larger than 32 bytes. > > The chaining value from co-processor was not being saved. This value is > needed because it is used as the IV

[RFC] powerpc: put the common parts of the ppc64*defconfigs in a Kconfig file

2013-08-08 Thread Stephen Rothwell
We cannot put the unsetting of config options in the Kconfig file, nor the integer or string options. I checked that after this we get the same .config files generated (except for the addition of the new PPC64_DEFCONFIG* config options. Any thoughts? --- arch/powerpc/Kconfig |

Re: [PATCH 36/63] powerpc: Book 3S MMU little endian support

2013-08-08 Thread Anton Blanchard
Hi Paul, > On Wed, Aug 07, 2013 at 02:01:53AM +1000, Anton Blanchard wrote: > > > +#ifdef __BIG_ENDIAN__ > > #define HPTE_LOCK_BIT 3 > > +#else > > +#define HPTE_LOCK_BIT (63-3) > > +#endif > > Are you deliberately using a different bit here? AFAICS you are using > 0x20 in the 7th byte as the

Re: Pull request: scottwood/linux.git next

2013-08-08 Thread Benjamin Herrenschmidt
On Thu, 2013-08-08 at 17:45 -0500, Scott Wood wrote: > The following changes since commit 3b2f64d00c46e1e4e9bd0bb9bb12619adac27a4b: > > Linux 3.11-rc2 (2013-07-21 12:05:29 -0700) > > are available in the git repository at: Next time, put a little blurb at the head of the pull request giving a

[PATCH v3 3/3] powerpc: Correctly context switch DSCR on POWER8

2013-08-08 Thread Michael Neuling
POWER8 allows the DSCR to be accessed directly from userspace via a new SPR number 0x3 (Rather than 0x11. DSCR SPR number 0x11 is still used on POWER8 but like POWER7, is only accessible in HV and OS modes). Currently, we allow this by setting H/FSCR DSCR bit on boot. Unfortunately this doesn't

[PATCH v2 1/3] powerpc: Rework setting up H/FSCR bit definitions

2013-08-08 Thread Michael Neuling
powerpc: Rework setting up H/FSCR bit definitions This reworks the Facility Status and Control Regsiter (FSCR) config bit definitions so that we can access the bit numbers. This will be useful when looking at the status in the facility unavailable interrupt. HFSCR and FSCR versions are the same,

[PATCH v3 2/4] powerpc: Add new save_tar() register function.

2013-08-08 Thread Michael Neuling
powerpc: Add new save_tar() register function. Add save_tar() function to save the Target Address Register (TAR). This will be used in a future patch to save the TAR earlier than it currently is. Signed-off-by: Michael Neuling Cc: --- v3: remove whitespace screw age noticed by sfr diff --git

Re: [PATCH 1/3 V2] mmc:core: parse voltage from device-tree

2013-08-08 Thread Zhang Haijun
On 08/09/2013 08:15 AM, Anton Vorontsov wrote: On Wed, Jul 31, 2013 at 02:25:25PM +0800, Haijun Zhang wrote: Add function to support get voltage from device-tree. If there are voltage-range specified in device-tree node, this function will parse it and return the avail voltage mask. Signed-off-

Re: [PATCH 63/63] powerpc: Add pseries_le_defconfig

2013-08-08 Thread Michael Ellerman
On Fri, Aug 09, 2013 at 09:12:37AM +1000, Michael Neuling wrote: > Anton Blanchard wrote: > > > > > Hi, > > > > > The CONFIG_VIRTUALIZATION disabling should be done in the Kconfig not > > > here. > > > > > > I'm not that keen on another defconfig. benh is already talking about > > > having a

Re: [PATCH 63/63] powerpc: Add pseries_le_defconfig

2013-08-08 Thread Michael Ellerman
On Thu, Aug 08, 2013 at 08:49:51PM +1000, Michael Neuling wrote: > > > +CONFIG_SCHED_SMT=y > > > +CONFIG_PPC_DENORMALISATION=y > > > +CONFIG_HOTPLUG_PCI=m > > Why the value "m" in the le_config file, when it is "y" in > > pseries_defconfig. > > We are out of sync already!?!?! *sigh* ;-) That's go

Re: [RFC PATCH 1/1] powerpc/embedded6xx: Add support for Motorola/Emerson MVME5100.

2013-08-08 Thread Scott Wood
On Thu, 2013-08-08 at 11:03 +1100, Stephen N Chivers wrote: > Add support for the Motorola/Emerson MVME5100 Single Board Computer. > > The MVME5100 is a 6U form factor VME64 computer with: > > - A single MPC7410 or MPC750 CPU > - A HAWK Processor Host Bridge (CPU to PCI) and >

Re: [PATCH 1/3 V2] mmc:core: parse voltage from device-tree

2013-08-08 Thread Anton Vorontsov
On Wed, Jul 31, 2013 at 02:25:25PM +0800, Haijun Zhang wrote: > Add function to support get voltage from device-tree. > If there are voltage-range specified in device-tree node, this function > will parse it and return the avail voltage mask. > > Signed-off-by: Haijun Zhang > --- > changes for v2

Re: [PATCH] mmc:of_spi: Update the code of getting voltage-ranges

2013-08-08 Thread Anton Vorontsov
On Wed, Jul 31, 2013 at 02:25:27PM +0800, Haijun Zhang wrote: > int num_ranges; > + u32 ocr_mask; > int i; > int ret = -EINVAL; > > @@ -102,26 +103,11 @@ struct mmc_spi_platform_data *mmc_spi_get_pdata(struct > spi_device *spi) > if (!oms) > return NULL;

Re: [PATCH 63/63] powerpc: Add pseries_le_defconfig

2013-08-08 Thread Michael Neuling
Anton Blanchard wrote: > > Hi, > > > The CONFIG_VIRTUALIZATION disabling should be done in the Kconfig not > > here. > > > > I'm not that keen on another defconfig. benh is already talking about > > having a powernv defconfig. I'm worried we are going to fragment the > > defconfigs. If you

Pull request: scottwood/linux.git next

2013-08-08 Thread Scott Wood
The following changes since commit 3b2f64d00c46e1e4e9bd0bb9bb12619adac27a4b: Linux 3.11-rc2 (2013-07-21 12:05:29 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/scottwood/linux.git next for you to fetch changes up to c8db32c8669f7de05b820ee493492

Re: [PATCHv8 02/10] PCI: remove ARCH_SUPPORTS_MSI kconfig option

2013-08-08 Thread Benjamin Herrenschmidt
On Fri, 2013-08-09 at 00:17 +0200, Thomas Petazzoni wrote: > Now that we have weak versions for each of the PCI MSI architecture > functions, we can actually build the MSI support for all platforms, > regardless of whether they provide or not architecture-specific > versions of those functions. For

Re: [PATCHv8 01/10] PCI: use weak functions for MSI arch-specific functions

2013-08-08 Thread Benjamin Herrenschmidt
On Fri, 2013-08-09 at 00:17 +0200, Thomas Petazzoni wrote: > Until now, the MSI architecture-specific functions could be overloaded > using a fairly complex set of #define and compile-time > conditionals. In order to prepare for the introduction of the msi_chip > infrastructure, it is desirable to

[PATCHv8 02/10] PCI: remove ARCH_SUPPORTS_MSI kconfig option

2013-08-08 Thread Thomas Petazzoni
Now that we have weak versions for each of the PCI MSI architecture functions, we can actually build the MSI support for all platforms, regardless of whether they provide or not architecture-specific versions of those functions. For this reason, the ARCH_SUPPORTS_MSI hidden kconfig boolean becomes

[PATCHv8 01/10] PCI: use weak functions for MSI arch-specific functions

2013-08-08 Thread Thomas Petazzoni
Until now, the MSI architecture-specific functions could be overloaded using a fairly complex set of #define and compile-time conditionals. In order to prepare for the introduction of the msi_chip infrastructure, it is desirable to switch all those functions to use the 'weak' mechanism. This commit

Re: Failure to detect PCI card

2013-08-08 Thread David Hawkins
Hi Pete, For those that are interested, we did figure out what was going on. Turns out that the clock buffer driving the PCI connector was, well, less than adequate. With some cards, the load on the clock line was large enough that the clock was in horrible shape. Fixing the clock line and the

Re: Failure to detect PCI card

2013-08-08 Thread Peter LaDow
On Mon, Aug 5, 2013 at 7:01 PM, David Hawkins wrote: > I suspect the lack of either the 5V or 3.3V power rail to the card > might be the problem. > > Did you probe the PCI edge connect to see what supplies were present? For those that are interested, we did figure out what was going on. Turns out

Re: [PATCH v4 09/31] powerpc/fsl-pci: improve clock API use

2013-08-08 Thread Anatolij Gustschin
On Tue, 6 Aug 2013 22:43:49 +0200 Gerhard Sittig wrote: ... > diff --git a/arch/powerpc/sysdev/fsl_pci.c b/arch/powerpc/sysdev/fsl_pci.c > index 46ac1dd..549ff08 100644 > --- a/arch/powerpc/sysdev/fsl_pci.c > +++ b/arch/powerpc/sysdev/fsl_pci.c ... > + clk = devm_clk_get(&pdev->dev, "per"); >

Re: [PATCH v4 11/31] net: can: mscan: improve clock API use

2013-08-08 Thread Gerhard Sittig
On Wed, Aug 07, 2013 at 09:28 +0200, Marc Kleine-Budde wrote: > > On 08/06/2013 10:43 PM, Gerhard Sittig wrote: > > [ ... ] > > diff --git a/drivers/net/can/mscan/mscan.c b/drivers/net/can/mscan/mscan.c > > index e6b4095..4f998f5 100644 > > --- a/drivers/net/can/mscan/mscan.c > > +++ b/drivers/net

Re: [PATCH v4 00/31] add COMMON_CLK support for PowerPC MPC512x

2013-08-08 Thread Gerhard Sittig
On Wed, Aug 07, 2013 at 10:40 -0500, Kumar Gala wrote: > > On Aug 6, 2013, at 3:43 PM, Gerhard Sittig wrote: > > > this series > > - fixes several drivers that are used in the MPC512x platform (UART, > > SPI, ethernet, PCI, USB, CAN, NAND flash, video capture) in how they > > handle clocks (appro

Re: [RFC PATCH 1/1] powerpc/embedded6xx: Add support for Motorola/Emerson MVME5100.

2013-08-08 Thread Scott Wood
On Thu, 2013-08-08 at 10:30 -0500, Kumar Gala wrote: > On Aug 7, 2013, at 7:03 PM, Stephen N Chivers wrote: > > > Add support for the Motorola/Emerson MVME5100 Single Board Computer. > > > > The MVME5100 is a 6U form factor VME64 computer with: > > > >- A single MPC7410 or MPC750 CPU > >

[PATCH 1/2] powerpc/pseries: Fix buffer overflow when reading from pstore

2013-08-08 Thread Aruna Balakrishnaiah
When reading from pstore there is a buffer overflow during decompression due to the header added in unzip_oops. Remove unzip_oops and call pstore_decompress directly in nvram_pstore_read. Allocate buffer of size report_length of the oops header as header will not be deallocated in pstore. Since we

[PATCH 2/2] powerpc/pseries: Add backward compatibilty to read old kernel oops-log

2013-08-08 Thread Aruna Balakrishnaiah
Older kernels has just length information in their header. Handle it while reading old kernel oops log from pstore. Applies on top of powerpc/pseries: Fix buffer overflow when reading from pstore Signed-off-by: Aruna Balakrishnaiah --- arch/powerpc/platforms/pseries/nvram.c | 18 +

Re: [PATCH 63/63] powerpc: Add pseries_le_defconfig

2013-08-08 Thread Aneesh Kumar K.V
Michael Ellerman writes: > On Wed, Aug 07, 2013 at 09:31:00AM +1000, Michael Neuling wrote: >> Anton Blanchard wrote: >> >> > This is the pseries_defconfig with CONFIG_CPU_LITTLE_ENDIAN enabled >> > and CONFIG_VIRTUALIZATION disabled (required until we fix some >> > endian issues in KVM). >> >

Re: [RFC PATCH 1/1] powerpc/embedded6xx: Add support for Motorola/Emerson MVME5100.

2013-08-08 Thread Kumar Gala
On Aug 7, 2013, at 7:03 PM, Stephen N Chivers wrote: > Add support for the Motorola/Emerson MVME5100 Single Board Computer. > > The MVME5100 is a 6U form factor VME64 computer with: > >- A single MPC7410 or MPC750 CPU >- A HAWK Processor Host Bridge (CPU to PCI) and > M

Re: [RFC PATCH 7/9] powerpc: Decode and save machine check event.

2013-08-08 Thread Benjamin Herrenschmidt
On Thu, 2013-08-08 at 18:49 +0530, Mahesh Jagannath Salgaonkar wrote: > > Secondly, we shouldn't call save_mce_event() if we're not in > > hypervisor mode, since per-cpu variables are not in general > accessible > > in real mode when running under a hypervisor with a limited > real-mode > > area (R

Re: [RFC PATCH 2/9] powerpc: handle machine check in Linux host.

2013-08-08 Thread Benjamin Herrenschmidt
On Thu, 2013-08-08 at 18:49 +0530, Mahesh Jagannath Salgaonkar wrote: > But, I think I should depend on > evt->disposition==MCE_DISPOSITION_RECOVERED and not play with MSR_RI > and > SRR1. I will fix my code. If MSR:RI is 0, then you have clobbered SRR0/SRR1 beyond repair and probably cannot recov

Re: [RFC PATCH 7/9] powerpc: Decode and save machine check event.

2013-08-08 Thread Mahesh Jagannath Salgaonkar
On 08/08/2013 10:44 AM, Paul Mackerras wrote: > On Wed, Aug 07, 2013 at 03:09:13PM +0530, Mahesh J Salgaonkar wrote: >> From: Mahesh Salgaonkar >> >> Now that we handle machine check in linux, the MCE decoding should also >> take place in linux host. This info is crucial to log before we go down >

Re: [RFC PATCH 2/9] powerpc: handle machine check in Linux host.

2013-08-08 Thread Mahesh Jagannath Salgaonkar
On 08/08/2013 10:21 AM, Paul Mackerras wrote: > On Wed, Aug 07, 2013 at 03:08:15PM +0530, Mahesh J Salgaonkar wrote: >> From: Mahesh Salgaonkar >> >> Move machine check entry point into Linux. So far we were dependent on >> firmware to decode MCE error details and handover the high level info to O

[PATCH v2] powerpc/booke64: Add LRAT error exception handler

2013-08-08 Thread Mihai Caraman
LRAT (Logical to Real Address Translation) present in MMU v2 provides hardware translation from a logical page number (LPN) to a real page number (RPN) when tlbwe is executed by a guest or when a page table translation occurs from a guest virtual address. Add LRAT error exception handler to Booke3

Re: [PATCH 63/63] powerpc: Add pseries_le_defconfig

2013-08-08 Thread Michael Neuling
> > +CONFIG_SCHED_SMT=y > > +CONFIG_PPC_DENORMALISATION=y > > +CONFIG_HOTPLUG_PCI=m > Why the value "m" in the le_config file, when it is "y" in > pseries_defconfig. We are out of sync already!?!?! *sigh* ;-) > Also I do see a warning saying invalid value for this symbol. Mikey _

Re: [v2] Enhanced support for MPC8xx/8xxx watchdog

2013-08-08 Thread Guenter Roeck
On 08/07/2013 10:50 PM, leroy christophe wrote: Le 26/06/2013 01:04, Scott Wood a écrit : On Thu, Feb 28, 2013 at 09:52:22AM +0100, LEROY Christophe wrote: This patch modifies the behaviour of the MPC8xx/8xxx watchdog. On the MPC8xx, at 133Mhz, the maximum timeout of the watchdog timer is 1s, w

Re: [PATCH 63/63] powerpc: Add pseries_le_defconfig

2013-08-08 Thread Madhavan Srinivasan
On Tuesday 06 August 2013 09:32 PM, Anton Blanchard wrote: > This is the pseries_defconfig with CONFIG_CPU_LITTLE_ENDIAN enabled > and CONFIG_VIRTUALIZATION disabled (required until we fix some > endian issues in KVM). > > Signed-off-by: Anton Blanchard > --- > arch/powerpc/configs/pseries_le_de

Re: [PATCH 63/63] powerpc: Add pseries_le_defconfig

2013-08-08 Thread Anton Blanchard
Hi, > The CONFIG_VIRTUALIZATION disabling should be done in the Kconfig not > here. > > I'm not that keen on another defconfig. benh is already talking about > having a powernv defconfig. I'm worried we are going to fragment the > defconfigs. If you want something special like LE, then chang

Re: [PATCH v2] drivers/crypto/nx: saves chaining value from co-processor

2013-08-08 Thread Michael Ellerman
Hi Fin, I don't know anything about crypto so I can only critique you on your patch submission technique :) ... On Wed, Aug 07, 2013 at 06:15:50PM -0500, Fionnuala Gunter wrote: > This patch fixes a bug that is triggered when cts(cbc(aes)) is used with > nx-crypto driver on input larger than 32