RE: [PATCH] powerpc/usb: fix issue of CPU halt when missing USB PHY clock

2012-02-01 Thread Liu Shengzhou-B36685
> -Original Message- > From: Pavan Kondeti [mailto:pkond...@codeaurora.org] > Sent: Wednesday, February 01, 2012 6:11 PM > To: Liu Shengzhou-B36685 > Cc: linux-...@vger.kernel.org; linuxppc-dev@lists.ozlabs.org > Subject: Re: [PATCH] powerpc/usb: fix issue of CPU halt when missing > USB PH

[PATCH v2] powerpc/usb: fix issue of CPU halt when missing USB PHY clock

2012-02-01 Thread Shengzhou Liu
when missing USB PHY clock, kernel booting up will halt during USB initialization. We should check USBGP[PHY_CLK_VALID] bit to avoid CPU hang in this case. Signed-off-by: Shengzhou Liu --- v2: changes: return -ENODEV instead of -1 drivers/usb/host/ehci-fsl.c | 11 +-- drivers/usb/host

Efika (mpc5200b): sound doesn't build/work from linux-2.6.38.x

2012-02-01 Thread acrux
board: Genesi Efika (MPC5200B) problem: unable to use sound subsystem instead it works fine with linux-2.6.36.4 (+ device tree supplement, attached) . With linux-2.6.38.8 and linux-2.6.39.4 it doesn't build. That's from my build log: [...] LD sound/soc/blackfin/built-in.o LD sound/

[RFC] Removing support for legacy iSeries

2012-02-01 Thread Benjamin Herrenschmidt
So I (and Stephen) believe the time has come that we get rid of the legacy iSeries support in the kernel Is there any objection ? Do we have any user left ? The hypervisor on these is really nasty, and removing support for it would allow us to clean up quite a bit of code path including low l

Re: [PATCH][v2] powerpc/85xx: Fix compiler error with THIS_MODULE and related

2012-02-01 Thread Paul Gortmaker
On Wed, Feb 1, 2012 at 12:05 PM, Claudiu Manoil wrote: > CC      arch/powerpc/sysdev/fsl_85xx_l2ctlr.o > arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:209:13: error: 'THIS_MODULE' undeclared > here (not in a function) Looks OK to me -- must be the 1st time this code has been merged into the 3.2 baseline

Re: MPC5200B FEC TX packets getting stuck

2012-02-01 Thread Joey Nelson
First I think the spin_locks in the irq handlers should be spin_lock_irqsave(), because the same lock is used in multiple irq handlers. If we get an rx interrupt while the tx interrupt holds the spin lock, this would seem to be a problem. In this case maybe not because it is a single processor sy

Re: [PATCH] powerpc: Define cpus_in_crash only for SMP kernels

2012-02-01 Thread Paul E. McKenney
On Wed, Feb 01, 2012 at 03:28:34PM -0500, Paul Gortmaker wrote: > On 12-02-01 01:55 PM, Paul E. McKenney wrote: > > The variable cpus_in_crash gets a defined-but-not-used warning when > > CONFIG_SMP=n, so fix by placing the variable under ifdef. > > I think Ben already merged a similar fix. > > h

[PATCH 07/15] PCI, powerpc: Register busn_res for root buses

2012-02-01 Thread Yinghai Lu
Signed-off-by: Yinghai Lu Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: linuxppc-dev@lists.ozlabs.org --- arch/powerpc/kernel/pci-common.c |7 ++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/arch/powerpc/kernel/pci-common.c b/arch/powerpc/kernel/pci-common.c index

Re: [PATCH] powerpc: Define cpus_in_crash only for SMP kernels

2012-02-01 Thread Paul Gortmaker
On 12-02-01 01:55 PM, Paul E. McKenney wrote: > The variable cpus_in_crash gets a defined-but-not-used warning when > CONFIG_SMP=n, so fix by placing the variable under ifdef. I think Ben already merged a similar fix. http://patchwork.ozlabs.org/patch/136549/ P. > > Signed-off-by: Paul E. McKe

[PATCH] powerpc: Define cpus_in_crash only for SMP kernels

2012-02-01 Thread Paul E. McKenney
The variable cpus_in_crash gets a defined-but-not-used warning when CONFIG_SMP=n, so fix by placing the variable under ifdef. Signed-off-by: Paul E. McKenney diff --git a/arch/powerpc/kernel/crash.c b/arch/powerpc/kernel/crash.c index 28be345..eb3384e 100644 --- a/arch/powerpc/kernel/crash.c +++

Re: [PATCH v3 22/25] irq_domain/x86: Convert x86 (embedded) to use common irq_domain

2012-02-01 Thread Grant Likely
On Wed, Feb 1, 2012 at 7:17 AM, Sebastian Andrzej Siewior wrote: > * Grant Likely | 2012-01-30 12:58:42 [-0700]: > >>Ugh.  This isn't easy.  The legacy mapping really needs all the > > Feel free to merge this patch. I don't have the time to look at this now > so I take a look at the ioapic later.

[PATCH][v2] powerpc/85xx: Fix compiler error with THIS_MODULE and related

2012-02-01 Thread Claudiu Manoil
CC arch/powerpc/sysdev/fsl_85xx_l2ctlr.o arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:209:13: error: 'THIS_MODULE' undeclared here (not in a function) arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:229:20: error: expected declaration specifiers or '...' before string constant cc1: warnings being treated as

Re: Question about GPIO Lib

2012-02-01 Thread Mark Brown
On Wed, Feb 01, 2012 at 09:56:45AM -0600, Bill Gatliff wrote: > On Wed, Feb 1, 2012 at 6:32 AM, Mark Brown wrote: > > Just to expand on this a bit: lots of people would prefer not to have a > > userspace component at all due to the same hardware safety concerns that > > you have, or to have the u

Re: Question about GPIO Lib

2012-02-01 Thread Bill Gatliff
Mark: On Wed, Feb 1, 2012 at 6:32 AM, Mark Brown wrote: > > Just to expand on this a bit: lots of people would prefer not to have a > userspace component at all due to the same hardware safety concerns that > you have, or to have the userspace component be a driver using gpiolib > which needs to

[PATCH] powerpc/dts: Added aliased MSIIR register address to MSI node in dts

2012-02-01 Thread Diana Craciun
From: Diana CRACIUN The MSIIR register for each MSI bank is aliased to a different address. The MSI node reg property was updated to contain this address: e.g. reg = <0x41600 0x200 0x44140 4>; The first region contains the address and length of the MSI register set and the second region contain

Re: [PATCH][upstream] Added aliased MSIIR register address to MSI node in dts

2012-02-01 Thread Diana CRACIUN
Please ignore this, I put a wrong subject. Thanks, Diana On 02/01/2012 05:40 PM, Diana Craciun wrote: From: Diana CRACIUN The MSIIR register for each MSI bank is aliased to a different address. The MSI node reg property was updated to contain this address: e.g. reg =<0x41600 0x200 0x44140 4>

[PATCH][upstream] Added aliased MSIIR register address to MSI node in dts

2012-02-01 Thread Diana Craciun
From: Diana CRACIUN The MSIIR register for each MSI bank is aliased to a different address. The MSI node reg property was updated to contain this address: e.g. reg = <0x41600 0x200 0x44140 4>; The first region contains the address and length of the MSI register set and the second region contain

Re: [RFC] dmaengine/dma_slave: add context parameter to prep_slave_sg callback

2012-02-01 Thread Vinod Koul
On Wed, 2012-02-01 at 12:58 +0100, Guennadi Liakhovetski wrote: > > The two things are completely orthogonal and shouldn't be clubbed. > > For your issue we need a separate debate on how to solve this... I am > > open to ideas... > > Well, I'm not sure whether they are necessarily always orthogona

Re: [PATCH v3 22/25] irq_domain/x86: Convert x86 (embedded) to use common irq_domain

2012-02-01 Thread Sebastian Andrzej Siewior
* Grant Likely | 2012-01-30 12:58:42 [-0700]: >Ugh. This isn't easy. The legacy mapping really needs all the Feel free to merge this patch. I don't have the time to look at this now so I take a look at the ioapic later. >g. Sebastian ___ Linuxppc-de

Re: Question about GPIO Lib

2012-02-01 Thread Mark Brown
On Tue, Jan 31, 2012 at 10:39:05AM -0600, Bill Gatliff wrote: > I'm just saying that, sadly, in many ways gpiolib is still a > work-in-progress. The userspace component has been somewhat > controversial in general over the years, and definitely lacks several > key features in addition to the one

Re: [RFC] dmaengine/dma_slave: add context parameter to prep_slave_sg callback

2012-02-01 Thread Guennadi Liakhovetski
On Wed, 1 Feb 2012, Vinod Koul wrote: > On Wed, 2012-02-01 at 01:09 +0100, Guennadi Liakhovetski wrote: > > On Mon, 30 Jan 2012, Vinod Koul wrote: > > > > > On Thu, 2012-01-26 at 16:22 -0500, Alexandre Bounine wrote: > > > > As we agreed during our discussion about adding DMA Engine support for

RE: [PATCH] powerpc/85xx: Fix compiler error with THIS_MODULE and related

2012-02-01 Thread Manoil Claudiu-B08782
Hi, You're right, is better for arch/powerpc/sysdev/fsl_85xx_cache_sram.c. However, it is not enough for arch/powerpc/sysdev/fsl_85xx_l2ctlr.c, as this one is defined as a module. I'll resend the patch (with for fsl_85xx_cache_sram.c), if that's fine with you. Thanks, Claudiu > -Origina

Re: next BUG: using smp_processor_id() in preemptible

2012-02-01 Thread Benjamin Herrenschmidt
On Tue, 2012-01-31 at 22:12 -0800, Hugh Dickins wrote: > > Grrr, my memory is a colander... And now am in Ballarat for the week > > with a semi working 3g connection. I'll see what I can do. > > Sorry to be such a bore - you can guess what I have to say about > 3.3-rc2 :() Yeah, I'm looking at re

Re: [PATCH] powerpc/usb: fix issue of CPU halt when missing USB PHY clock

2012-02-01 Thread Pavan Kondeti
On 2/1/2012 2:50 PM, Shengzhou Liu wrote: > diff --git a/drivers/usb/host/ehci-fsl.c b/drivers/usb/host/ehci-fsl.c > index b556a72..834237e 100644 > --- a/drivers/usb/host/ehci-fsl.c > +++ b/drivers/usb/host/ehci-fsl.c > @@ -239,7 +239,7 @@ static void ehci_fsl_setup_phy(struct ehci_hcd *ehci, >

[PATCH] powerpc/usb: fix issue of CPU halt when missing USB PHY clock

2012-02-01 Thread Shengzhou Liu
when missing USB PHY clock, kernel booting up will halt during USB initialization. We should check USBGP[PHY_CLK_VALID] bit to avoid CPU hang in this case. Signed-off-by: Shengzhou Liu --- drivers/usb/host/ehci-fsl.c | 11 +-- drivers/usb/host/ehci-fsl.h |1 + 2 files changed, 10 i