Re: linux-next: build warnings after merge of the final tree (tip treee related)

2010-09-14 Thread Stephen Rothwell
Hi Yinghai, On Tue, 14 Sep 2010 16:00:06 -0700 Yinghai Lu wrote: > > Also, we may need to remove all extern and __init and __initdata etc in .h > files. > > please check > > [PATCH -v3] memblock: Fix section mismatch warning > > Use __init_memblock to replace __init, and remove __init in memb

Re: linux-next: build warnings after merge of the final tree (tip treee related)

2010-09-14 Thread Stephen Rothwell
Hi Yinghai, On Tue, 14 Sep 2010 18:33:34 -0700 Yinghai Lu wrote: > > On 09/14/2010 05:29 PM, Stephen Rothwell wrote: > > > > Do not remove the "extern" key word. > > why? you got another warning? It is normal C coding practice to mark declarations in header files with extern. It probably does

Re: linux-next: build warnings after merge of the final tree (tip treee related)

2010-09-14 Thread Yinghai Lu
On 09/14/2010 05:29 PM, Stephen Rothwell wrote: > Hi Yinghai, > > On Tue, 14 Sep 2010 16:00:06 -0700 Yinghai Lu wrote: >> >> Also, we may need to remove all extern and __init and __initdata etc in .h >> files. > > Do not remove the "extern" key word. > why? you got another warning? Yinghai _

Re: linux-next: build warnings after merge of the final tree (tip treee related)

2010-09-14 Thread Stephen Rothwell
Hi Yinghai, On Tue, 14 Sep 2010 16:00:06 -0700 Yinghai Lu wrote: > > Also, we may need to remove all extern and __init and __initdata etc in .h > files. Do not remove the "extern" key word. -- Cheers, Stephen Rothwells...@canb.auug.org.au http://www.canb.auug.org.au/~sfr/

Re: linux-next: build warnings after merge of the final tree (tip treee related)

2010-09-14 Thread Yinghai Lu
On 09/13/2010 09:50 PM, Stephen Rothwell wrote: > Hi Yinghai, > > On Mon, 13 Sep 2010 01:24:20 -0700 Yinghai Lu wrote: >> >> On 09/12/2010 09:39 PM, Stephen Rothwell wrote: >>> >>> Your patch fixes some of the warnings, but still leaves these for a >>> powerpc allnoconfig build: >>> >>> WARNING:

Re: [PATCH v2 09/10] RapidIO: Add support for IDT CPS Gen2 switches

2010-09-14 Thread Andrew Morton
On Tue, 14 Sep 2010 10:59:22 -0400 Alexandre Bounine wrote: > +static int > +idtg2_route_add_entry(struct rio_mport *mport, u16 destid, u8 hopcount, > +u16 table, u16 route_destid, u8 route_port) > +{ > + /* > + * Select routing table to update > + */ > + if

Re: [PATCH v2 03/10] RapidIO: Use stored ingress port number instead of register read

2010-09-14 Thread Andrew Morton
On Tue, 14 Sep 2010 10:59:16 -0400 Alexandre Bounine wrote: > @@ -219,6 +219,7 @@ struct rio_net { > /** > * struct rio_switch - RIO switch info > * @node: Node in global list of switches > + * @rdev: Associated RIO device structure > * @switchid: Switch ID that is unique across a network

Re: [PATCH v2 06/10] RapidIO: Modify sysfs initialization for switches

2010-09-14 Thread Andrew Morton
On Tue, 14 Sep 2010 10:59:19 -0400 Alexandre Bounine wrote: > 1. Change to create attribute "routes" only for switches. This is also a non-back compatible userspace-visible change? ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lis

Re: [PATCH v2 01/10] RapidIO: Fix RapidIO sysfs hierarchy

2010-09-14 Thread Andrew Morton
On Tue, 14 Sep 2010 10:59:14 -0400 Alexandre Bounine wrote: > Make RapidIO devices appear in /sys/devices/rapidio directory instead of top > of /sys/devices directory. Non-backward compatible change? What is the risk of breaking existing setups with this change? ___

[PATCH 00/15] change default_llseek action

2010-09-14 Thread Arnd Bergmann
The llseek file operations traditionally behaves differently from all other file operations, the default being a generic implementation of the call instead of a stub returning an error. This changes *all* instances of struct file_operations in the kernel to have a .llseek operation and then change

[PATCH 05/15] spufs: use llseek in all file operations

2010-09-14 Thread Arnd Bergmann
The default for llseek is changing, so we need explicit operations everywhere. Signed-off-by: Arnd Bergmann Cc: Jeremy Kerr Cc: linuxppc-...@ozlabs.org --- arch/powerpc/platforms/cell/spufs/file.c | 18 ++ 1 files changed, 18 insertions(+), 0 deletions(-) diff --git a/arch/po

Re: [PATCH] hvc_console: fix dropping of characters when output byte channel is full

2010-09-14 Thread Scott Wood
On Tue, 14 Sep 2010 20:44:10 +0100 Alan Cox wrote: > > Yes, hvc_push() reschedules. It doesn't sit in a tight loop burning > > electrons! > > > > Can we do something safer&smarter here? > > > Its a printk handler - better to lose the bytes than hang the box. I > think the current code is prob

[PATCH 0/7] BKL mass-conversion to mutex

2010-09-14 Thread Arnd Bergmann
This is one out of five topic branches in my BKL removal series that I would like to get into linux-next as a preparation for merging into 2.6.37. Based on a discussion with Ingo Molnar, this series converts many drivers that only have a single file using the BKL to use a private mutex instead. A

[PATCH 3/7] mac: autoconvert trivial BKL users to private mutex

2010-09-14 Thread Arnd Bergmann
All these files use the big kernel lock in a trivial way to serialize their private file operations, typically resulting from an earlier semi-automatic pushdown from VFS. None of these drivers appears to want to lock against other code, and they all use the BKL as the top-level lock in their file

Re: [PATCH] hvc_console: fix dropping of characters when output byte channel is full

2010-09-14 Thread Timur Tabi
Alan Cox wrote: > If you want to make that change then I guess you need to audit every > other hvc driver first. > > But I never understood the point of the hvc layer anyway 8) We've come to the same conclusion here. I think we're just going to drop the hvc layer and make the driver a standard c

Re: [PATCH] hvc_console: fix dropping of characters when output byte channel is full

2010-09-14 Thread Alan Cox
> Yes, hvc_push() reschedules. It doesn't sit in a tight loop burning > electrons! > > Can we do something safer&smarter here? Its a printk handler - better to lose the bytes than hang the box. I think the current code is probably right. ___ Linuxppc-

Re: [PATCH] hvc_console: fix dropping of characters when output byte channel is full

2010-09-14 Thread Timur Tabi
Alan Cox wrote: > Its a printk handler - better to lose the bytes than hang the box. I > think the current code is probably right. What do you think about this change: http://lists.ozlabs.org/pipermail/linuxppc-dev/2009-October/thread.html#76830 This is the original version of my patch. In it,

Re: [PATCH] hvc_console: fix dropping of characters when output byte channel is full

2010-09-14 Thread Scott Wood
On Tue, 14 Sep 2010 12:17:21 -0700 Andrew Morton wrote: > On Fri, 20 Aug 2010 13:45:21 -0500 > Timur Tabi wrote: > > > hvc_console_print() calls the HVC client driver's put_chars() callback > > to write some characters to the console. If the callback returns 0, that > > indicates that no chara

Re: [PATCH] hvc_console: fix dropping of characters when output byte channel is full

2010-09-14 Thread Alan Cox
On Tue, 14 Sep 2010 14:25:34 -0500 Timur Tabi wrote: > Alan Cox wrote: > > Its a printk handler - better to lose the bytes than hang the box. I > > think the current code is probably right. > > What do you think about this change: > > http://lists.ozlabs.org/pipermail/linuxppc-dev/2009-October/

Re: [PATCH] hvc_console: fix dropping of characters when output byte channel is full

2010-09-14 Thread Andrew Morton
On Fri, 20 Aug 2010 13:45:21 -0500 Timur Tabi wrote: > hvc_console_print() calls the HVC client driver's put_chars() callback > to write some characters to the console. If the callback returns 0, that > indicates that no characters were written (perhaps the output buffer is > full), but hvc_cons

Re: [PATCH] hvc_console: fix dropping of characters when output byte channel is full

2010-09-14 Thread Timur Tabi
Andrew, Would you please take a moment to review this patch I sent last month? I'd like for it to be incorporated into 2.6.37, but I'm having a hard time finding someone to consider it. Thanks. On Fri, Aug 20, 2010 at 1:45 PM, Timur Tabi wrote: > hvc_console_print() calls the HVC client driver'

[PATCH v2 09/10] RapidIO: Add support for IDT CPS Gen2 switches

2010-09-14 Thread Alexandre Bounine
Add the RIO switch driver and definitions for IDT CPS-1848 and CPS-1616 Gen2 devices. Signed-off-by: Alexandre Bounine Cc: Thomas Moll Cc: Matt Porter Cc: Li Yang Cc: Kumar Gala Cc: Micha Nelissen --- drivers/rapidio/switches/Kconfig|7 + drivers/rapidio/switches/Makefile |1 +

[PATCH v2 05/10] RapidIO: Add default handler for error-stopped state

2010-09-14 Thread Alexandre Bounine
The default error-stopped state handler provides recovery mechanism as defined by RIO specification. Signed-off-by: Alexandre Bounine Cc: Thomas Moll Cc: Matt Porter Cc: Li Yang Cc: Kumar Gala Cc: Micha Nelissen --- drivers/rapidio/rio.c | 218 +++---

[PATCH v2 10/10] RapidIO: Add handling of redundant routes

2010-09-14 Thread Alexandre Bounine
Detects RIO link to the already enumerated device and properly sets links between device objects. Changes to the enumeration/discovery logic: 1. Use Master Enable bit to signal end of the enumeration - agents may start their discovery process as soon as they see this bit set (Component Tag register

[PATCH v2 04/10] RapidIO: Add relation links between RIO device structures

2010-09-14 Thread Alexandre Bounine
Create back and forward links between RIO devices. These links are intended for use by error management and hot-plug extensions. Links for redundant RIO connections between switches are not set (will be fixed in a separate patch). Signed-off-by: Alexandre Bounine Cc: Thomas Moll Cc: Matt Porter

[PATCH v2 03/10] RapidIO: Use stored ingress port number instead of register read

2010-09-14 Thread Alexandre Bounine
A switch port information is obtained and stored during RIO device setup. Therefore repeated reads from Switch Port Information CAR may be removed. Signed-off-by: Alexandre Bounine Cc: Thomas Moll Cc: Matt Porter Cc: Li Yang Cc: Kumar Gala Cc: Micha Nelissen --- drivers/rapidio/rio-scan.c |

[PATCH v2 07/10] RapidIO: Add handling of orphan port-write message

2010-09-14 Thread Alexandre Bounine
Add check for access to port-write (PW) message source device before processing the PW message. If source RIO device is not available (power down or RIO link failure) trace back to a last available switch/port on the PW message route and service failure at that point. Signed-off-by: Alexandre Boun

[PATCH v2 02/10] RapidIO:powerpc/85xx: Modify RIO port-write interrupt handler

2010-09-14 Thread Alexandre Bounine
- Rearranged RIO port-write interrupt handling to perform message buffering as soon as possible. - Modified to disable port-write controller when clearing Transaction Error (TE) bit. Signed-off-by: Alexandre Bounine Cc: Thomas Moll Cc: Matt Porter Cc: Li Yang Cc: Kumar Gala Cc: Micha Nelissen

[PATCH v2 06/10] RapidIO: Modify sysfs initialization for switches

2010-09-14 Thread Alexandre Bounine
1. Change to create attribute "routes" only for switches. 2. Add a switch-specific callback to create/remove proprietary attributes. Signed-off-by: Alexandre Bounine Cc: Thomas Moll Cc: Matt Porter Cc: Li Yang Cc: Kumar Gala Cc: Micha Nelissen --- drivers/rapidio/rio-sysfs.c | 26

[PATCH v2 08/10] RapidIO: Add device access check into the enumeration

2010-09-14 Thread Alexandre Bounine
Add explicit device access check before performing device enumeration. This gives a chance to clear possible link error conditions by issuing safe maintenance read request(s). Signed-off-by: Alexandre Bounine Cc: Thomas Moll Cc: Matt Porter Cc: Li Yang Cc: Kumar Gala Cc: Micha Nelissen ---

[PATCH v2 01/10] RapidIO: Fix RapidIO sysfs hierarchy

2010-09-14 Thread Alexandre Bounine
Make RapidIO devices appear in /sys/devices/rapidio directory instead of top of /sys/devices directory. Signed-off-by: Alexandre Bounine Cc: Thomas Moll Cc: Matt Porter Cc: Li Yang Cc: Kumar Gala Cc: Micha Nelissen --- drivers/rapidio/rio-driver.c |2 +- drivers/rapidio/rio-scan.c |

[PATCH v2 0/10] RapidIO: Set of patches to add Gen2 switches

2010-09-14 Thread Alexandre Bounine
This set of RapidIO patches extends support for standard error recovery mechanism and adds new IDT Gen2 sRIO switch devices - CPS-1848 and CPS-1616. Implementation of the standard error-stopped state recovery mechanism (as defined by the RapidIO specification) is required for the new switches. The

Question on of_address_to_resource() with offset != 0

2010-09-14 Thread Stefan Roese
Hi, I'm stumbling upon a problem noticed on the Ebony (440GP) eval board. Here the first chip-select is connected to 512KiB of SRAM and 512KiB NOR flash. The dts part look this way: small-fl...@0,8 { compatible = "jedec-f

Re: [alsa-devel] [PATCH] sound/ppc/powermac: remove undefined operations

2010-09-14 Thread Takashi Iwai
At Sat, 11 Sep 2010 13:16:41 +0200, Andreas Schwab wrote: > > Modifying an object twice without an intervening sequence point is > undefined. > > Signed-off-by: Andreas Schwab Applied now. Thanks. Takashi > --- > sound/ppc/tumbler.c |2 +- > 1 files changed, 1 insertions(+), 1 deletion

Re: Generating elf kernel ?

2010-09-14 Thread Baurzhan Ismagulov
On Tue, Sep 14, 2010 at 10:53:11AM +0200, Guillaume Dargaud wrote: > How do I generate an elf file ? vmlinux? With kind regards, -- Baurzhan Ismagulov http://www.kz-easy.com/ ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozl

Re: [PATCH v2 3/3][MTD] P4080/mtd: Fix the freescale lbc issue with 36bit mode

2010-09-14 Thread Timur Tabi
On Mon, Sep 13, 2010 at 11:09 PM, Zang Roy-R61911 wrote: >> > > Shouldn't this be u32 or __be32, for consistency with the actual >> > > comparisons below? >> > __be32 is better. >> >> I disagree, the return from this function is native-endian.  It should >> be u32. > But the return of this value

Re: Generating elf kernel ?

2010-09-14 Thread Guillaume Dargaud
> Which bootloader? Looks you want to run it as XIP. I have my own downloader which does a few things and then transfers the kernel from a flash to the memory and then simply jumps to the 1st address with a 0x4() C function call. But I need to first use Xilinx tools to transfer the kernel f

Re: Generating elf kernel ?

2010-09-14 Thread tiejun.chen
Guillaume Dargaud wrote: > Hello all, > In the past I've been using the PPC architecture to generate elf kernels (I > wrote my own bootloader): > $ file zImage.elf > zImage.elf: ELF 32-bit MSB executable, PowerPC or cisco 4500, version 1 > (SYSV), statically linked, not stripped > > I'm now try

Generating elf kernel ?

2010-09-14 Thread Guillaume Dargaud
Hello all, In the past I've been using the PPC architecture to generate elf kernels (I wrote my own bootloader): $ file zImage.elf zImage.elf: ELF 32-bit MSB executable, PowerPC or cisco 4500, version 1 (SYSV), statically linked, not stripped I'm now trying to change to the PowerPC architecture