RE:

Hi Wolfgang, The current mainline 2.6.36-rc3 does not report any error while building the SATA driver. Regards, Rup -Original Message- From: Rupjyoti Sarmah [mailto:rsar...@apm.com] Sent: Thursday, September 02, 2010 8:22 PM To: 'Wolfgang Denk' Cc: 'linuxppc-...@ozlabs.org'; 'Prodyut Ha

Re: pci_request_regions() failure

Ravi Gupta wrote: > Hi, > > I am facing a problem while requesting pci resource. I have some data that I > am hopeful will help address the issue. > > I am currently running on a MPC837xERDB board(powerpc) with a 2.6.35 kernel. > The problem is that whenever I insert the card (LatticeECP2M PCI Ex

Re: [PATCH 1/2] drivers/net/fs_enet/fs_enet-main.c: Add of_node_put to avoid memory leak

From: Julia Lawall Date: Sat, 4 Sep 2010 12:12:43 +0200 > In this case, a device_node structure is stored in another structure that > is then freed without first decrementing the reference count of the > device_node structure. > > The semantic match that finds this problem is as follows: > (htt

Re: [v2 PATCH] ucc_geth: fix ethtool set ring param bug

From: Liang Li Date: Fri, 3 Sep 2010 00:02:44 +0800 > + printk(KERN_INFO "Stopping interface %s.\n", netdev->name); ... > + printk(KERN_INFO "Reactivating interface %s.\n", netdev->name); Please get rid of these log messages. Also, this isn't the way to implement this.

Re: [PATCH 4/8] drivers/i2c/busses/i2c-pasemi.c: Fix unsigned return type

On Sun, Sep 05, 2010 at 09:00:22PM +0200, Julia Lawall wrote: > The function has an unsigned return type, but returns a negative constant > to indicate an error condition. The result of calling the function is > always stored in a variable of type (signed) int, and thus unsigned can be > dropped f

Re: [PATCH] APM821xx: Add support for new SoC APM821xx

On Sun, Sep 05, 2010 at 10:19:53PM -0700, Tirumala Marri wrote: > > > > Then the device tree identifier, and the cpu setup functions, etc, > > should indicate > > 464, not APM821xx. > This is new SoC based on 464 cpu core. All the previous SoC device tree > CPU portion uses SoC name. Hm, you're ri

[PATCH 00/14] Removing dead code

Hi all! As part of the VAMOS[0] research project at the University of Erlangen we are looking at multiple integrity errors in linux' configuration system. I've been running a check on the whole sourcetree for code block which are undead. This means they can't be deselected and are always i

pci_request_regions() failure

Hi, I am facing a problem while requesting pci resource. I have some data that I am hopeful will help address the issue. I am currently running on a MPC837xERDB board(powerpc) with a 2.6.35 kernel. The problem is that whenever I insert the card (LatticeECP2M PCI Express Development Kit

RE: [PATCH] APM821xx: Add support for new SoC APM821xx

> >Every new board needs new defconfig. And it is not same as others. It > has > >Different features from other. > > You make it sound as if that is a hard and fixed rule. It's not. Not > all > boards need a defconfig. Also, there was recent work to trim the > defconfigs > that exist today down

Re: How to define an I2C-to-SPI bridge device ?

Anton, looks like I should have looked at include/spi/spi.h earlier : /* * INTERFACES between SPI master-side drivers and SPI infrastructure. * (There's no SPI slave support for Linux yet...) */ ...this is what I've been looking for. thanks for your help and sorry for the noise. Regards,

[PATCH 04/14] arch/{s390,powerpc}: Removing undead ifdef __KERNEL__

The __KERNEL__ ifdef isn't necessary at this point, because it is checked in an outer ifdef level already and has no effect here. Signed-off-by: Christian Dietrich --- arch/powerpc/include/asm/processor.h |2 -- arch/powerpc/include/asm/vdso_datapage.h |2 -- arch/s390/include/asm/pr

Re: [PATCH] APM821xx: Add support for new SoC APM821xx

On Sun, Sep 05, 2010 at 10:19:53PM -0700, Tirumala Marri wrote: >> >> Then the device tree identifier, and the cpu setup functions, etc, >> should indicate >> 464, not APM821xx. >This is new SoC based on 464 cpu core. All the previous SoC device tree >CPU portion uses SoC name. > >> >> Also, why ad

Re: How to define an I2C-to-SPI bridge device ?

Anton, we're about to get new MPC8377 based hardware with various peripherals. There are two I2C-to-SPI bridge devices (NXP SC18IS602) and I'm not sure how to define a proper dts... Of course it's an easy thing creating 2 child nodes on the CPU's I2C device - but how can I represent the creat

RE: [PATCH 1/3][MTD] P4080/eLBC: Make Freescale elbc interrupt common to elbc devices

> -Original Message- > From: Anton Vorontsov [mailto:cbouatmai...@gmail.com] > Sent: Monday, September 06, 2010 17:44 PM > To: Zang Roy-R61911 > Cc: linux-...@lists.infradead.org; Lan Chunhe-B25806; linuxppc-...@ozlabs.org; > a...@linux-foundation.org; Gala Kumar-B11780; Wood Scott-B07421

Re: [PATCH 1/3][MTD] P4080/eLBC: Make Freescale elbc interrupt common to elbc devices

On Mon, Sep 06, 2010 at 05:24:35PM +0800, Zang Roy-R61911 wrote: [..] > > mxmr = &fsl_lbc_ctrl_dev->regs->mcmr; > That makes sense. A global or local variable for fsl_lbc_ctrl_dev->regs? > Which one is better? The less global variables, the better. So, I'd vote for a local one. > > [...] > > >

RE: [PATCH 1/3][MTD] P4080/eLBC: Make Freescale elbc interrupt common to elbc devices

> -Original Message- > From: Anton Vorontsov [mailto:cbouatmai...@gmail.com] > Sent: Monday, September 06, 2010 16:22 PM > To: Zang Roy-R61911 > Cc: linux-...@lists.infradead.org; Lan Chunhe-B25806; linuxppc-...@ozlabs.org; > a...@linux-foundation.org; Gala Kumar-B11780; Wood Scott-B07421

RE: [PATCH 2/3][MTD] P4080/nand: Only make elbc nand driver detect nand flash partitions

> -Original Message- > From: Anton Vorontsov [mailto:cbouatmai...@gmail.com] > Sent: Monday, September 06, 2010 16:10 PM > To: Zang Roy-R61911 > Cc: linux-...@lists.infradead.org; Lan Chunhe-B25806; linuxppc-...@ozlabs.org; > a...@linux-foundation.org; Gala Kumar-B11780; Wood Scott-B07421

Re: [PATCH 1/3][MTD] P4080/eLBC: Make Freescale elbc interrupt common to elbc devices

On Mon, Sep 06, 2010 at 11:38:09AM +0800, Zang Roy-R61911 wrote: [...] > > > switch (br & BR_MSEL) { > > > case BR_MS_UPMA: > > > - upm->mxmr = &fsl_lbc_regs->mamr; > > > + upm->mxmr = &fsl_lbc_ctrl_dev->regs->mamr; > > > > Ditto, a very repetitive stuff, desires a variable for

Re: [PATCH 2/3][MTD] P4080/nand: Only make elbc nand driver detect nand flash partitions

On Mon, Sep 06, 2010 at 12:49:17PM +0800, Zang Roy-R61911 wrote: > > On Fri, Aug 06, 2010 at 10:51:35AM +0800, Roy Zang wrote: > > [...] > > > > > > +static struct fsl_elbc_fcm_ctrl *elbc_fcm_ctrl; > > > + > > > > Are you sure that you want it as a global var? A bit scary change. > > > > Oh, you