Re: [RFC PATCH] PCI-E broken on PPC (regression)

2010-01-25 Thread Kenji Kaneshige
Jesse Barnes wrote: On Mon, 25 Jan 2010 12:38:49 -0800 Jesse Barnes wrote: On Mon, 25 Jan 2010 11:42:29 -0200 Breno Leitao wrote: Hello, I found that qlge is broken on PPC, and it got broken after commit 06a1cbafb253c4c60d6a54a994887f5fbceabcc0. It happens because dev->pcie is not set on

Re: [RFC PATCH] PCI-E broken on PPC (regression)

2010-01-25 Thread Kenji Kaneshige
Breno Leitao wrote: Hello, I found that qlge is broken on PPC, and it got broken after commit 06a1cbafb253c4c60d6a54a994887f5fbceabcc0. It happens because dev->pcie is not set on PPC, because the function set_pcie_port_type(), who sets dev->pcie, is not being called on PPC PCI code. Hi Bren

Re: [PATCH 03/11] powerpc/mpc5121: Add machine restart support

2010-01-25 Thread Anatolij Gustschin
On Wed, 20 Jan 2010 12:28:43 +0100 Wolfram Sang wrote: > > +static void __iomem *reset_module_base; > > type here also? Ok. > > + > > +static int __init mpc512x_restart_init(void) > > +{ > > + struct device_node *np; > > + > > + np = of_find_compatible_node(NULL, NULL, "fsl,mpc5121-reset")

Re: [PATCH/RFC 2/2] 5200: improve i2c bus error recovery

2010-01-25 Thread Wolfgang Grandegger
Albrecht Dreß wrote: > Am 25.01.10 08:55 schrieb(en) Wolfgang Grandegger: >> Albrecht Dreß wrote: >>> Make the I2C adapter timeout configurable through a Device Tree >>> property which gives the timeout in microseconds. >> >> My understanding is that software properties should not be defined via >>

Re: [PATCH 4/4] powerpc/mcu_mpc8349emitx: Remove OF GPIO handling stuff

2010-01-25 Thread David Brownell
On Monday 25 January 2010, Anton Vorontsov wrote: > With the new OF GPIO infrastructure it's much easier to handle I2C > GPIO controllers, i.e. now drivers don't have to deal with the > OF-specific bits. Good, that's how it should have been done in the first place. :) Of course, there's still th

Re: [PATCH 1/4] gpiolib: Introduce chip addition/removal notifier

2010-01-25 Thread David Brownell
On Monday 25 January 2010, Anton Vorontsov wrote: > > +config GPIOLIB_NOTIFIER > +   bool > +   help > +     This symbol is selected by subsystems that need to handle GPIO > +     chips addition and removal. E.g., this is used for the > +     OpenFirmware bindings. > + I'm no

Re: [PATCH 2/4] of/gpio: Add support for two-stage registration for the of_gpio_chips

2010-01-25 Thread David Brownell
On Monday 25 January 2010, Anton Vorontsov wrote: > With this patch there are two ways to register OF GPIO controllers: > > 1. Allocating the of_gpio_chip structure and passing the >    &of_gc->gc pointer to the gpiochip_add. (Can use container_of >    to convert the gpio_chip to the of_gpio_chip.

Re: [PATCH 2/2] powerpc: implement arch_scale_smt_power for Power7

2010-01-25 Thread Benjamin Herrenschmidt
On Mon, 2010-01-25 at 11:50 -0600, Joel Schopp wrote: > > Look at the cputhreads.h implementation ... Today we only support > > power-of-two numbers of threads. > > > I've run 3 threads using cpu hotplug to offline 1 of the 4. It's > certainly a stupid idea, but there you go. Oh, you mean yo

Re: [RFC PATCH] PCI-E broken on PPC (regression)

2010-01-25 Thread Benjamin Herrenschmidt
On Mon, 2010-01-25 at 17:50 -0800, Jesse Barnes wrote: > > You mean dev->is_pcie? > > > > Why isn't pci_scan_device calling pci_setup_device for you? That > > should do the proper PCIe init depending on the device, along with > > extracting other device info... > > Cc'ing Ben for PPC. Ben, shou

Re: [RFC PATCH] PCI-E broken on PPC (regression)

2010-01-25 Thread Jesse Barnes
On Mon, 25 Jan 2010 12:38:49 -0800 Jesse Barnes wrote: > On Mon, 25 Jan 2010 11:42:29 -0200 > Breno Leitao wrote: > > > Hello, > > > > I found that qlge is broken on PPC, and it got broken after commit > > 06a1cbafb253c4c60d6a54a994887f5fbceabcc0. It happens because > > dev->pcie is not set

Re: [PATCH 2/3] i2c-mpc: add support for the MPC512x processors from Freescale

2010-01-25 Thread Wolfram Sang
> I just sent v2. Hope it's OK now. Thanks, will check tomorrow. -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital signature ___

Re: [PATCH 2/3] i2c-mpc: add support for the MPC512x processors from Freescale

2010-01-25 Thread Wolfgang Grandegger
Wolfram Sang wrote: >> overkill to me. I will have a closer look, though. At a minimum I will >> replace "-1" with "MPC_I2C_PRESERVE_CLOCK". > > Might be also an idea to define it with ~0 (clock is still unsigned). If > possible, the code checking for those two cases (0 and "-1") should be close >

[PATCH v2 2/3] i2c-mpc: add support for the MPC512x processors from Freescale

2010-01-25 Thread Wolfgang Grandegger
From: Wolfgang Grandegger The "setclock" initialization functions have been renamed to "setup" because I2C interrupts must be enabled for the MPC512x. This requires to handle "fsl,preserve-clocking" in a slighly different way. Also, the old settings are now reported calling dev_dbg(). For the MPC

[PATCH v2 1/3] i2c-mpc: use __devinit[data] for initialization functions and data

2010-01-25 Thread Wolfgang Grandegger
From: Wolfgang Grandegger "__devinit[data]" has not yet been used for all initialization functions and data. To avoid truncating lines, the struct mpc_i2c_match_data has been renamed to mpc_i2c_data, which is even the better name. Signed-off-by: Wolfgang Grandegger --- drivers/i2c/busses/i2c-m

[PATCH v2 3/3] powerpc: doc/dts-bindings: update doc of FSL I2C bindings

2010-01-25 Thread Wolfgang Grandegger
From: Wolfgang Grandegger This patch adds the MPC5121 to the list of supported devices, enhances the doc of the "clock-frequency" property and removes the obsolete "cell-index" property from the example nodes. Furthermore and example for the MPC5121 has been added. Signed-off-by: Wolfgang Grande

[PATCH v2 0/3] i2c-mpc: add support for the Freescale MPC512x and other fixes

2010-01-25 Thread Wolfgang Grandegger
From: Wolfgang Grandegger This patch series adds support for the MPC512x from Freescale to the i2c-mpc driver. At that occasion, issues with __devinit[data] have been fixed and the doc of the FSL I2C dts bindings updated. It has been tested on a MPC5121ADS, TQM5200 and TQM8560 board Changes sin

Re: [PATCH 2/3] i2c-mpc: add support for the MPC512x processors from Freescale

2010-01-25 Thread Wolfram Sang
> overkill to me. I will have a closer look, though. At a minimum I will > replace "-1" with "MPC_I2C_PRESERVE_CLOCK". Might be also an idea to define it with ~0 (clock is still unsigned). If possible, the code checking for those two cases (0 and "-1") should be close together. That could be a com

Re: [RFC PATCH] PCI-E broken on PPC (regression)

2010-01-25 Thread Jesse Barnes
On Mon, 25 Jan 2010 11:42:29 -0200 Breno Leitao wrote: > Hello, > > I found that qlge is broken on PPC, and it got broken after commit > 06a1cbafb253c4c60d6a54a994887f5fbceabcc0. It happens because > dev->pcie is not set on PPC, because the function > set_pcie_port_type(), who sets dev->pcie,

Re: [PATCH/RFC 2/2] 5200: improve i2c bus error recovery

2010-01-25 Thread Albrecht Dreß
Am 25.01.10 08:55 schrieb(en) Wolfgang Grandegger: Albrecht Dreß wrote: Make the I2C adapter timeout configurable through a Device Tree property which gives the timeout in microseconds. My understanding is that software properties should not be defined via the device tree. I think a sysfs en

Re: [PATCH/RFC 1/2] 5200: improve i2c bus error recovery

2010-01-25 Thread Albrecht Dreß
Am 25.01.10 05:06 schrieb(en) Ben Dooks: On Fri, Jan 22, 2010 at 09:17:55PM +0100, Albrecht Dreß wrote: Improve the recovery of the MPC5200B's I2C bus from errors like bus hangs. This is very sparse comapred to the large comment below the --- line, maybe some more description should be livin

spi_mpc8xxx: Setting cs_change at the last transfer of a message

2010-01-25 Thread Torsten Fleischer
As stated in spi.h (at struct spi_transfer) the driver can keep the chip select of the last device active if cs_change is set at the last transfer of a message. The spi_mpc8xxx driver always deactivates the chip select after completing the message regardless of cs_change is set or not. I'd like

NAND (UPM) / NOR Flash(GPCM) existence MPC832x any issue

2010-01-25 Thread nanda
Thanks for the information. Based on your input, I could successfully update the dts file and gpio controller configuration. I verified from the GPIO chip intialized and added properly. But, still Iam getting the message as "No NAND device found!!!". In our system we have two flash NOR connec

Re: [PATCH 2/3] i2c-mpc: add support for the MPC512x processors from Freescale

2010-01-25 Thread Wolfgang Grandegger
Wolfram Sang wrote: -static void __devinit mpc_i2c_setclock_52xx(struct device_node *node, - struct mpc_i2c *i2c, - u32 clock, u32 prescaler) +static void __devinit mpc_i2c_setup_52xx(struct device_

[PATCH 4/4] powerpc/mcu_mpc8349emitx: Remove OF GPIO handling stuff

2010-01-25 Thread Anton Vorontsov
With the new OF GPIO infrastructure it's much easier to handle I2C GPIO controllers, i.e. now drivers don't have to deal with the OF-specific bits. Signed-off-by: Anton Vorontsov --- arch/powerpc/platforms/83xx/mcu_mpc8349emitx.c | 68 +--- 1 files changed, 14 insertions(+)

[PATCH 3/4] of/gpio: Implement GPIOLIB notifier hooks

2010-01-25 Thread Anton Vorontsov
This patch implements GPIOLIB notifier hooks, and thus makes device-enabled GPIO chips (i.e. the ones that have gpio_chip->dev specified) automatically attached to the OpenFirmware subsystem. Which means that now we can handle I2C and SPI GPIO chips almost* transparently. * "Almost" because some c

[PATCH 2/4] of/gpio: Add support for two-stage registration for the of_gpio_chips

2010-01-25 Thread Anton Vorontsov
With this patch there are two ways to register OF GPIO controllers: 1. Allocating the of_gpio_chip structure and passing the &of_gc->gc pointer to the gpiochip_add. (Can use container_of to convert the gpio_chip to the of_gpio_chip.) 2. Allocating and registering the gpio_chip structure sep

[PATCH 1/4] gpiolib: Introduce chip addition/removal notifier

2010-01-25 Thread Anton Vorontsov
Some platforms (e.g. OpenFirmware) want to know when a particular chip added or removed, so that the platforms could add their specifics for non-platform devices, like I2C or SPI GPIO chips. This patch implements the notifier for chip addition and removal events. Signed-off-by: Anton Vorontsov -

[PATCH 0/4] OF GPIO integration for I2C/SPI GPIO chips

2010-01-25 Thread Anton Vorontsov
Hi all, Currently it's a burden to make I2C or SPI GPIO chips work with the OF GPIO infrastructure. I've posted several approaches to solve the issue before, and others have tried too. Here is another try. This patch set is used to make things much easier, and completely seamless for GPIO chips t

Re: [PATCH 2/2] powerpc: implement arch_scale_smt_power for Power7

2010-01-25 Thread Joel Schopp
Benjamin Herrenschmidt wrote: On Wed, 2010-01-20 at 16:09 -0600, Joel Schopp wrote: I can turn that into a conditional branch (case statement) with a shift for the common 1,2,4 cases which should cover all procs available today falling back to a divide for any theoretical future processors t

Re: Large physical address support on e500 platform

2010-01-25 Thread Kumar Gala
On Jan 25, 2010, at 11:06 AM, Aaron Pace wrote: >> >> Is a simple "hello world" module sufficient to show the issue? I'll look >> into it this week. >> >> - k > > It wasn't in my situation, unfortunately. To duplicate this, I had > one relatively large kernel module, and then one simple 'he

Re: [PATCH 1/4] edac: Remove unused mpc85xx debug code

2010-01-25 Thread Peter Tyser
On Thu, 2009-11-19 at 18:42 -0600, Peter Tyser wrote: > Some unused, unsupported debug code existed in the mpc85xx EDAC driver > that resulted in a build failure when CONFIG_EDAC_DEBUG was defined: > > drivers/edac/mpc85xx_edac.c: In function 'mpc85xx_mc_err_probe': > drivers/edac/mpc85xx_edac

Re: Large physical address support on e500 platform

2010-01-25 Thread Aaron Pace
> > Is a simple "hello world" module sufficient to show the issue?  I'll look > into it this week. > > - k It wasn't in my situation, unfortunately. To duplicate this, I had one relatively large kernel module, and then one simple 'hello world' module that did nothing more than call an exported f

Re: [PATCH 08/11] powerpc/mpc5121: add USB host support

2010-01-25 Thread Anatolij Gustschin
On Thu, 21 Jan 2010 10:43:34 -0700 Grant Likely wrote: > > diff --git a/Documentation/powerpc/dts-bindings/fsl/usb.txt > > b/Documentation/powerpc/dts-bindings/fsl/usb.txt > > index b001524..9050154 100644 > > --- a/Documentation/powerpc/dts-bindings/fsl/usb.txt > > +++ b/Documentation/powerpc/d

Re: [PATCH] powerpc/85xx: Fix SMP when "cpu-release-addr" is in lowmem

2010-01-25 Thread Kumar Gala
On Dec 18, 2009, at 4:50 PM, Peter Tyser wrote: > Recent U-Boot commit 5ccd29c3679b3669b0bde5c501c1aa0f325a7acb caused > the "cpu-release-addr" device tree property to contain the physical RAM > location that secondary cores were spinning at. Previously, the > "cpu-release-addr" property contain

Re: [PATCH] powerpc/85xx: Fix oops during MSI driver probe on MPC85xxMDS boards

2010-01-25 Thread Kumar Gala
On Dec 15, 2009, at 4:58 PM, Anton Vorontsov wrote: > MPC85xx chips report the wrong value in feature reporting register, > and that causes the following oops: > > Unable to handle kernel paging request for data at address 0x0c00 > Faulting instruction address: 0xc0019294 > Oops: Kernel acce

Re: [PATCH] powerpc/85xx: Fix SMP when "cpu-release-addr" is in lowmem

2010-01-25 Thread Kumar Gala
On Jan 21, 2010, at 4:28 PM, Peter Tyser wrote: > On Fri, 2009-12-18 at 16:50 -0600, Peter Tyser wrote: >> Recent U-Boot commit 5ccd29c3679b3669b0bde5c501c1aa0f325a7acb caused >> the "cpu-release-addr" device tree property to contain the physical RAM >> location that secondary cores were spinning

Re: Large physical address support on e500 platform

2010-01-25 Thread Kumar Gala
On Jan 22, 2010, at 12:27 AM, Aaron Pace wrote: >>> >>> Its possible that we've broken module/vmalloc support with >>> "Large physical addressing".? Its not something I've >>> tried in a while.? What kernel/git SHA are you using. >>> > >> I'm just pulling in from the main kernel tree git. >> M

Re: [PATCH 06/11] mtd: Add MPC5121 NAND Flash Controller driver

2010-01-25 Thread Anatolij Gustschin
Hi Wolfram, Wolfram Sang wrote: > Please include a logfile with changes since the last version. This really > helps. Ok. > > +static int __init mpc5121_nfc_probe(struct of_device *op, > > + const struct of_device_id *match) > > [...] > > > +{ > > + /* Supp

Re: [PATCH 2/3] i2c-mpc: add support for the MPC512x processors from Freescale

2010-01-25 Thread Wolfram Sang
> >> > >> -static void __devinit mpc_i2c_setclock_52xx(struct device_node *node, > >> - struct mpc_i2c *i2c, > >> - u32 clock, u32 prescaler) > >> +static void __devinit mpc_i2c_setup_52xx(struct device_node *node, > >> +

[RFC PATCH] PCI-E broken on PPC (regression)

2010-01-25 Thread Breno Leitao
Hello, I found that qlge is broken on PPC, and it got broken after commit 06a1cbafb253c4c60d6a54a994887f5fbceabcc0. It happens because dev->pcie is not set on PPC, because the function set_pcie_port_type(), who sets dev->pcie, is not being called on PPC PCI code. So, I have two ideas to fix it

Re: [PATCH 2/3] i2c-mpc: add support for the MPC512x processors from Freescale

2010-01-25 Thread Wolfgang Grandegger
Hi Wolfram, Wolfram Sang wrote: > Hi Wolfgang, > > On Mon, Jan 25, 2010 at 09:27:08AM +0100, Wolfgang Grandegger wrote: >> From: Wolfgang Grandegger >> >> The "setclock" initialization functions have been renamed to "setup" >> because I2C interrupts must be enabled for the MPC512x. This requires

Re: [PATCH 0/3] i2c-mpc: add support for the Freescale MPC512x and other fixes

2010-01-25 Thread Wolfram Sang
On Mon, Jan 25, 2010 at 09:27:06AM +0100, Wolfgang Grandegger wrote: > This patch series adds support for the MPC512x from Freescale to the > i2c-mpc driver. At that occasion, issues with __devinit[data] have > been fixed and the doc of the FSL I2C dts bindings updated. It has > been tested on a

Re: [PATCH 3/3] powerpc: doc/dts-bindings: update doc of FSL I2C bindings

2010-01-25 Thread Wolfgang Grandegger
Wolfram Sang wrote: > On Mon, Jan 25, 2010 at 09:27:09AM +0100, Wolfgang Grandegger wrote: >> From: Wolfgang Grandegger >> >> This patch adds the MPC5121 to the list of supported devices, >> enhances the doc of the "clock-frequency" property and removes >> the obsolete "cell-index" property from t

Re: [PATCH 3/3] powerpc: doc/dts-bindings: update doc of FSL I2C bindings

2010-01-25 Thread Wolfram Sang
On Mon, Jan 25, 2010 at 09:27:09AM +0100, Wolfgang Grandegger wrote: > From: Wolfgang Grandegger > > This patch adds the MPC5121 to the list of supported devices, > enhances the doc of the "clock-frequency" property and removes > the obsolete "cell-index" property from the example nodes. I think

Re: [PATCH 2/3] i2c-mpc: add support for the MPC512x processors from Freescale

2010-01-25 Thread Wolfram Sang
Hi Wolfgang, On Mon, Jan 25, 2010 at 09:27:08AM +0100, Wolfgang Grandegger wrote: > From: Wolfgang Grandegger > > The "setclock" initialization functions have been renamed to "setup" > because I2C interrupts must be enabled for the MPC512x. This requires > to handle "fsl,preserve-clocking" in a

Re: mount ramdisk rootfs /etc directory to jffs2 filesystem.

2010-01-25 Thread Chris Simmonds
Johnny Hung wrote: 2010/1/22 Marco Stornelli : 2010/1/22 Johnny Hung : 2010/1/20 Marco Stornelli : 2010/1/20 Johnny Hung : 2010/1/19 Matthias Kaehlcke : El Tue, Jan 19, 2010 at 02:17:22PM +0100 Ricard Wanderlof ha dit: I consider to use ramdisk as rootfs because worry about wrong operation

Re: mount ramdisk rootfs /etc directory to jffs2 filesystem.

2010-01-25 Thread Johnny Hung
2010/1/25 Chris Simmonds : > Johnny Hung wrote: >> >> 2010/1/22 Marco Stornelli : >>> >>> 2010/1/22 Johnny Hung : 2010/1/20 Marco Stornelli : > > 2010/1/20 Johnny Hung : >> >> 2010/1/19 Matthias Kaehlcke : >>> >>> El Tue, Jan 19, 2010 at 02:17:22PM +0100 Ricard Wan

[PATCH 3/3] powerpc: doc/dts-bindings: update doc of FSL I2C bindings

2010-01-25 Thread Wolfgang Grandegger
From: Wolfgang Grandegger This patch adds the MPC5121 to the list of supported devices, enhances the doc of the "clock-frequency" property and removes the obsolete "cell-index" property from the example nodes. Signed-off-by: Wolfgang Grandegger --- Documentation/powerpc/dts-bindings/fsl/i2c.tx

[PATCH 2/3] i2c-mpc: add support for the MPC512x processors from Freescale

2010-01-25 Thread Wolfgang Grandegger
From: Wolfgang Grandegger The "setclock" initialization functions have been renamed to "setup" because I2C interrupts must be enabled for the MPC512x. This requires to handle "fsl,preserve-clocking" in a slighly different way. Also, the old settings are now reported calling dev_dbg(). For the MPC

[PATCH 1/3] i2c-mpc: use __devinit[data] for initialization functions and data

2010-01-25 Thread Wolfgang Grandegger
From: Wolfgang Grandegger "__devinit[data]" has not yet been used for all initialization functions and data. To avoid truncating lines, the struct mpc_i2c_match_data has been renamed to mpc_i2c_data, which is even the better name. Signed-off-by: Wolfgang Grandegger --- drivers/i2c/busses/i2c-m

[PATCH 0/3] i2c-mpc: add support for the Freescale MPC512x and other fixes

2010-01-25 Thread Wolfgang Grandegger
This patch series adds support for the MPC512x from Freescale to the i2c-mpc driver. At that occasion, issues with __devinit[data] have been fixed and the doc of the FSL I2C dts bindings updated. It has been tested on a MPC5121ADS, TQM5200 and TQM8560 board Wolfgang Wolfgang Grandegger (3): i2

Re: [PATCH]: powerpc: Fix build breakage due to incorrect location of autoconf.h

2010-01-25 Thread Joakim Tjernlund
Benjamin Herrenschmidt wrote on 2010/01/14 09:57:11: > > > > Seen it now as it is in Linus tree: > > > > 1) IMHO it would have been nicer to use #ifdef __KERNEL__ > >instead of CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS > >as then arches that don't define CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS