[PATCH v3] powerpc: gpio driver for mpc8349/8572/8610 and compatible with OF bindings

2008-09-21 Thread Peter Korsgaard
Structured similar to the existing QE GPIO support. Signed-off-by: Peter Korsgaard <[EMAIL PROTECTED]> --- Changes since v2: - Clarified documentation as requested by Kumar. Changes since v1: Incorporated feedback from Anton and Kumar: - Core is also used on 8572/8610 so s/83xx/8xxx/ - Use

Re: [PATCH v2] powerpc: gpio driver for mpc8349/8572/8610 and compatible

2008-09-21 Thread Peter Korsgaard
> "Kumar" == Kumar Gala <[EMAIL PROTECTED]> writes: Kumar> On Sep 21, 2008, at 2:46 PM, Peter Korsgaard wrote: >> +GPIO controllers on MPC8xxx SoCs >> + >> +Every GPIO controller node must have #gpio-cells property defined, >> +this information will be used to translate gpio-specifiers.

Re: [PATCH v2] powerpc: gpio driver for mpc8349/8572/8610 and compatible

2008-09-21 Thread Peter Korsgaard
> "Kumar" == Kumar Gala <[EMAIL PROTECTED]> writes: Hi, Kumar> Also, any plans to follow this up with .dts updates to add the Kumar> GPIO block into the various files we have? Yes, but I wanted to get the driver/dts bindings in the tree first. -- Bye, Peter Korsgaard

Re: mpc8541 pci1 ioport allocation address space problem

2008-09-21 Thread Benjamin Herrenschmidt
On Sat, 2008-09-20 at 19:16 +0800, Wang Jian wrote: > Hi, > > Here I have a 8541 dev board, with 2 e1000 attached to pci0 and a > homebrewed addon board inserted into pci1. I am trying to make it work > under 2.6.26-rc8 (2.6.26 broken so I am working at rc8). > > The ioports allocation reads > >

Re: ioremap and vmalloc

2008-09-21 Thread Benjamin Herrenschmidt
On Fri, 2008-09-19 at 18:45 +0200, Sébastien Chrétien wrote: > if I write : > ioremap(0x2000,0x4) and ioremap(0x2000,0x5) > > Will it crash ? To give you a rough idea, unless you tweak things like TASK_SIZE, KERNELBASE, CONFIG_LOWMEM_SIZE, etc... and depending on what CPU you use,

Re: solution to printk() blocking interrupts?

2008-09-21 Thread Benjamin Herrenschmidt
On Sun, 2008-09-21 at 19:34 -0400, Jon Smirl wrote: > On Sun, Sep 21, 2008 at 6:21 PM, Sergei Shtylyov > <[EMAIL PROTECTED]> wrote: > > Implementing the poll_controller() method in the network driver is usually > > staightforward. > > Good tip, the simple implementation worked. > > What controls

[PATCH] powerpc: iSeries: remove unused variable in viodasd.c

2008-09-21 Thread Johann Felix Soden
From: Johann Felix Soden <[EMAIL PROTECTED]> The variable statindex in send_request is never read, so remove it. Signed-off-by: Johann Felix Soden <[EMAIL PROTECTED]> CC: Stephen Rothwell <[EMAIL PROTECTED]> --- drivers/block/viodasd.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-)

Re: [PATCH v2] powerpc: gpio driver for mpc8349/8572/8610 and compatible

2008-09-21 Thread Kumar Gala
On Sep 21, 2008, at 2:46 PM, Peter Korsgaard wrote: Structured similar to the existing QE GPIO support. Signed-off-by: Peter Korsgaard <[EMAIL PROTECTED]> --- Also, any plans to follow this up with .dts updates to add the GPIO block into the various files we have? - k ___

Re: [PATCH v2] powerpc: gpio driver for mpc8349/8572/8610 and compatible

2008-09-21 Thread Kumar Gala
On Sep 21, 2008, at 2:46 PM, Peter Korsgaard wrote: +GPIO controllers on MPC8xxx SoCs + +Every GPIO controller node must have #gpio-cells property defined, +this information will be used to translate gpio-specifiers. + Can we add a comment about this being the non-QE/CPM/GUTs GPIO support.

Re: [PATCH] arch/powerpc/platforms/powermac/pic.c: move of_node_put

2008-09-21 Thread Benjamin Herrenschmidt
On Sun, 2008-09-21 at 13:01 +0200, Julia Lawall wrote: > From: Julia Lawall <[EMAIL PROTECTED]> > > It seems better to dereference master before decrementing the reference > count rather than afterwards. > > The problem was found using the following semantic match: > (http://www.emn.fr/x-info/coc

Re: solution to printk() blocking interrupts?

2008-09-21 Thread Jon Smirl
On Sun, Sep 21, 2008 at 6:21 PM, Sergei Shtylyov <[EMAIL PROTECTED]> wrote: > Implementing the poll_controller() method in the network driver is usually > staightforward. Good tip, the simple implementation worked. What controls this? "carrier detect appears untrustworthy, waiting 4 seconds" Get

Re: solution to printk() blocking interrupts?

2008-09-21 Thread Sergei Shtylyov
Hello. Jon Smirl wrote: On Sun, Sep 21, 2008 at 4:53 PM, Jon Smirl <[EMAIL PROTECTED]> wrote: Does anyone have a solution to the problem of printk() to a serial console blocking interrupts for too long? I'm losing interrupts I need because my hardware is getting overrun. netconsole is

Re: solution to printk() blocking interrupts?

2008-09-21 Thread Jon Smirl
On Sun, Sep 21, 2008 at 4:53 PM, Jon Smirl <[EMAIL PROTECTED]> wrote: > Does anyone have a solution to the problem of printk() to a serial > console blocking interrupts for too long? I'm losing interrupts I need > because my hardware is getting overrun. netconsole is not an option on mpc5200

solution to printk() blocking interrupts?

2008-09-21 Thread Jon Smirl
Does anyone have a solution to the problem of printk() to a serial console blocking interrupts for too long? I'm losing interrupts I need because my hardware is getting overrun. -- Jon Smirl [EMAIL PROTECTED] ___ Linuxppc-dev mailing list Linuxppc-dev@o

[PATCH v2] powerpc: gpio driver for mpc8349/8572/8610 and compatible

2008-09-21 Thread Peter Korsgaard
Structured similar to the existing QE GPIO support. Signed-off-by: Peter Korsgaard <[EMAIL PROTECTED]> --- Changes since v1: Incorporated feedback from Anton and Kumar: - Core is also used on 8572/8610 so s/83xx/8xxx/ - Use fsl,mpc8572-gpio / fsl,mpc8610-gpio for 85xx/86xx as compatible - Us

Re: [PATCH v2] powerpc: implement support for MPC8349-compatible SOC GPIOs

2008-09-21 Thread Peter Korsgaard
> "Kumar" == Kumar Gala <[EMAIL PROTECTED]> writes: Hi, Kumar> This way the compatiable binding in the code just lists something like Kumar> "fsl,mpc8349-gpio", "fsl,mpc8610-gpio", "fsl,mpc8572-gpio". Kumar> Does that make sense? Yes, sounds fine - I'll adapt the patch and resend. -- B

Re: [PATCH] powerpc: gpio driver for mpc831x/834x/837x with OF bindings

2008-09-21 Thread Peter Korsgaard
> "Kumar" == Kumar Gala <[EMAIL PROTECTED]> writes: Hi, >> create mode 100644 arch/powerpc/sysdev/mpc83xx_gpio.c Kumar> So we need to make this mpc8xxx_gpio.c 83xx, 8610, 85xx all have the Kumar> same GPIO hw. Ok. I'm not really familiar with the other 8xxx SoCs, but from looking at the

[PATCH] arch/powerpc/platforms/powermac/pic.c: move of_node_put

2008-09-21 Thread Julia Lawall
From: Julia Lawall <[EMAIL PROTECTED]> It seems better to dereference master before decrementing the reference count rather than afterwards. The problem was found using the following semantic match: (http://www.emn.fr/x-info/coccinelle/) // @r exists@ expression n,E; identifier fld; iterator I;

Re: [PATCH] powerpc/fsl: Refactor device bindings

2008-09-21 Thread Trent Piepho
On Wed, 9 Jul 2008, Kumar Gala wrote: > Moved Freescale SoC related bindings out of booting-without-of.txt and into > their own files. > > Signed-off-by: Kumar Gala > --- > > We need to resolve some conflicts in cpm.txt and qe.txt but that will be a > followup patch. > > - k > > Documentation/po