Re: [PATCH v2] powerpc: Add irqtrace support for 32-bit powerpc

2008-04-04 Thread Dale Farnsworth
On Sat, Apr 05, 2008 at 04:14:56PM +1100, Benjamin Herrenschmidt wrote: > > On Sat, 2008-04-05 at 01:31 +0200, Johannes Berg wrote: > > > This version takes care to save and restore *all* the volatile registers > > > around the call to trace_hardirqs_off in transfer_to_handler, and should > > > fi

Re: [PATCH v2] powerpc: Add irqtrace support for 32-bit powerpc

2008-04-04 Thread Benjamin Herrenschmidt
On Sat, 2008-04-05 at 01:31 +0200, Johannes Berg wrote: > > This version takes care to save and restore *all* the volatile registers > > around the call to trace_hardirqs_off in transfer_to_handler, and should > > fix the anomalies seen by Johannes Berg. I've tested on 7447- and 8548- > > based b

Re: [PATCH] [v4] Add idle wait support for 44x platforms

2008-04-04 Thread Josh Boyer
On Fri, 04 Apr 2008 11:28:27 -0500 Jerone Young <[EMAIL PROTECTED]> wrote: > 2 files changed, 87 insertions(+), 1 deletion(-) > arch/powerpc/platforms/44x/Makefile |2 > arch/powerpc/platforms/44x/idle.c | 86 +++ > > > - adds MSR_DE to MSRs to enable while

Re: [PATCH v2] powerpc: Add irqtrace support for 32-bit powerpc

2008-04-04 Thread Johannes Berg
> This version takes care to save and restore *all* the volatile registers > around the call to trace_hardirqs_off in transfer_to_handler, and should > fix the anomalies seen by Johannes Berg. I've tested on 7447- and 8548- > based boards. Still has problems on my machine. Maybe to do with non-m

Re: [PATCH v2] powerpc: Add irqtrace support for 32-bit powerpc

2008-04-04 Thread Benjamin Herrenschmidt
> Right, it's not needed on 4xx/BookE, but I didn't think it worth > optimizing at this point, since it will split the code into 4xx/BookE > and classic versions. Let's get it working solid first. Yup, it's just that I spotted it while reading the code. > That's what I originally thought and had

Re: [PATCH v2] powerpc: Add irqtrace support for 32-bit powerpc

2008-04-04 Thread Dale Farnsworth
On Sat, Apr 05, 2008 at 09:07:31AM +1100, Benjamin Herrenschmidt wrote: > > diff --git a/arch/powerpc/kernel/entry_32.S b/arch/powerpc/kernel/entry_32.S > > index 69a91bd..bd3ce0f 100644 > > --- a/arch/powerpc/kernel/entry_32.S > > +++ b/arch/powerpc/kernel/entry_32.S > > @@ -144,6 +144,47 @@ trans

RE: [PATCH 1/5] [v2][POWERPC] refactor dcr code

2008-04-04 Thread Benjamin Herrenschmidt
On Fri, 2008-04-04 at 15:02 -0700, Stephen Neuendorffer wrote: > Ben, > > Any thoughts about device tree bindings for indirect DCR? No, not really. For 44x PCI-E, I've just used something like an "sdr-base" property to provide the base SDR for the port, simple but not necessarily the nicest way t

Re: [RFC/PATCH] powerpc: Add irqtrace support to 32-bit powerpc

2008-04-04 Thread Benjamin Herrenschmidt
On Fri, 2008-04-04 at 14:29 -0700, Dale Farnsworth wrote: > On Fri, Apr 04, 2008 at 09:33:18PM +0200, Johannes Berg wrote: > > On Wed, 2008-04-02 at 16:15 +0200, Johannes Berg wrote: > > > On Fri, 2008-02-01 at 12:50 -0700, Dale Farnsworth wrote: > > > > This adds the low level irq tracing hooks f

Re: [PATCH v2] powerpc: Add irqtrace support for 32-bit powerpc

2008-04-04 Thread Benjamin Herrenschmidt
> config LOCKDEP_SUPPORT > diff --git a/arch/powerpc/kernel/entry_32.S b/arch/powerpc/kernel/entry_32.S > index 69a91bd..bd3ce0f 100644 > --- a/arch/powerpc/kernel/entry_32.S > +++ b/arch/powerpc/kernel/entry_32.S > @@ -144,6 +144,47 @@ transfer_to_handler: > .globl transfer_to_handler_cont

RE: [PATCH 1/5] [v2][POWERPC] refactor dcr code

2008-04-04 Thread Stephen Neuendorffer
Ben, Any thoughts about device tree bindings for indirect DCR? Steve > -Original Message- > From: Benjamin Herrenschmidt [mailto:[EMAIL PROTECTED] > Sent: Sunday, March 30, 2008 3:03 PM > To: Stephen Neuendorffer > Cc: linuxppc-dev@ozlabs.org > Subject: Re: [PATCH 1/5] [v2][POWERPC] refa

[PATCH v2] powerpc: Add irqtrace support for 32-bit powerpc

2008-04-04 Thread Dale Farnsworth
Add the low level irq tracing hooks for 32-bit powerpc needed to enable full lockdep functionality. Dale Farnsworth <[EMAIL PROTECTED]> --- This patch applies on top of Benjamin Herrenschmidt's lockdep patch for 64-bit powerpc. (http://patchwork.ozlabs.org/linuxppc/patch?id=17673) This version t

Re: [RFC/PATCH] powerpc: Add irqtrace support to 32-bit powerpc

2008-04-04 Thread Johannes Berg
> My apologies, Johannes. I made some unwarranted assumptions about > register usage in the lowest-level exception handlers. While it worked > on my 7447 board, I saw similar random failures on the 85xx (booke) system > I tried. No harm done, just wanted to give it a try and let you know it fai

Re: [RFC/PATCH] powerpc: Add irqtrace support to 32-bit powerpc

2008-04-04 Thread Dale Farnsworth
On Fri, Apr 04, 2008 at 09:33:18PM +0200, Johannes Berg wrote: > On Wed, 2008-04-02 at 16:15 +0200, Johannes Berg wrote: > > On Fri, 2008-02-01 at 12:50 -0700, Dale Farnsworth wrote: > > > This adds the low level irq tracing hooks for 32-bit powerpc. > > > This patch applies on top of Benjamin Herr

Re: [PATCH/RFC] via-pmu: remove mdelays from suspend/resume code

2008-04-04 Thread Benjamin Herrenschmidt
On Fri, 2008-04-04 at 21:21 +0200, Johannes Berg wrote: > On Fri, 2008-04-04 at 10:20 -0700, Brad Boyer wrote: > > On Thu, Apr 03, 2008 at 05:44:44PM +0200, Johannes Berg wrote: > > > I don't see a reason for either of those mdelay()s, is there any? Works > > > fine for me without them... > > > >

Re: [PATCH/RFC] via-pmu: remove mdelays from suspend/resume code

2008-04-04 Thread Brad Boyer
On Thu, Apr 03, 2008 at 05:44:44PM +0200, Johannes Berg wrote: > I don't see a reason for either of those mdelay()s, is there any? Works > fine for me without them... Which hardware revisions did you test? I suspect the mdelay calls were added to work around timing issues in one of the older PMU c

Re: [RFC/PATCH] powerpc: Add irqtrace support to 32-bit powerpc

2008-04-04 Thread Johannes Berg
On Wed, 2008-04-02 at 16:15 +0200, Johannes Berg wrote: > On Fri, 2008-02-01 at 12:50 -0700, Dale Farnsworth wrote: > > This adds the low level irq tracing hooks for 32-bit powerpc. > > This patch applies on top of Benjamin Herrenschmidt's patch that > > provides similar support for 64-bit powerpc

Re: [PATCH] PowerPC: MPIC ack interrupts at mpic_teardown_this_cpu()

2008-04-04 Thread Olof Johansson
On Fri, Apr 04, 2008 at 08:55:01PM +0200, Segher Boessenkool wrote: >>> platforms/maple/setup.c and platforms/powermac/pic.c use >>> MPIC_WANTS_RESET. >>> Is there a reason why we don't do that on every MPIC? If there is >>> such >>> a reason, the default should be to reset, only pseries and chr

Re: [PATCH/RFC] via-pmu: remove mdelays from suspend/resume code

2008-04-04 Thread Johannes Berg
On Fri, 2008-04-04 at 10:20 -0700, Brad Boyer wrote: > On Thu, Apr 03, 2008 at 05:44:44PM +0200, Johannes Berg wrote: > > I don't see a reason for either of those mdelay()s, is there any? Works > > fine for me without them... > > Which hardware revisions did you test? I suspect the mdelay calls w

Re: [PATCH] PowerPC: MPIC ack interrupts at mpic_teardown_this_cpu()

2008-04-04 Thread Segher Boessenkool
platforms/maple/setup.c and platforms/powermac/pic.c use MPIC_WANTS_RESET. Is there a reason why we don't do that on every MPIC? If there is such a reason, the default should be to reset, only pseries and chrp and cell and now pasemi do not use it. It's the only sane way to get an MPIC into a

Re: [PATCH] PowerPC 44x: use machine_device_initcall() instead of device_initcall() for warp_nand

2008-04-04 Thread Grant Likely
On Fri, Apr 4, 2008 at 12:24 PM, Valentine Barshak <[EMAIL PROTECTED]> wrote: > With a multiplatform kernel, once built we always have > warp_setup_nand_flash() called > and NDFC probed, no matter what machine we actually run on. This potentially > can cause > problems (such as kernel crash), s

Re: [kvm-ppc-devel] [PATCH] [v2] Add idle wait support for 44x platforms

2008-04-04 Thread Segher Boessenkool
+ msr_save = mfmsr(); + /* set wait state MSR */ + mtmsr(msr_save|MSR_WE|MSR_EE|MSR_CE); Did we decide to drop MSR_DE? + /* return to initial state */ + mtmsr(msr_save); It may be my paranoia but I'm pretty sure you need the isync() after _both_ mtmsr()s Certain

[PATCH] PowerPC 44x: use machine_device_initcall() instead of device_initcall() for warp_nand

2008-04-04 Thread Valentine Barshak
With a multiplatform kernel, once built we always have warp_setup_nand_flash() called and NDFC probed, no matter what machine we actually run on. This potentially can cause problems (such as kernel crash), since NDFC is probed at a warp-predefined address. Using machine_device_initcall() NAND de

[PATCH] [POWERPC] pasemi: Minor cleanups of iommu code

2008-04-04 Thread Olof Johansson
Clean up the pwrficient iommu code a bit. It was using u32 *-based offsets for registers, which can be confusing when comparing to the manual. Generated binaries from the code is unchanged from before. --- This will be pushed to for-2.6.26 of pasemi.git, so no signed-off here. diff --git

Re: [PATCH] PowerPC: MPIC ack interrupts at mpic_teardown_this_cpu()

2008-04-04 Thread Olof Johansson
On Fri, Apr 04, 2008 at 07:38:27PM +0200, Segher Boessenkool wrote: We really need to ack interrupts at mpic_teardown, since not all platforms reset mpic at kernel start-up. For example, kexec'ed kernel hangs on P.A. Semi if mpic_eoi() isn't called. Signed-off-by: Valentine

Re: [PATCH] PowerPC: MPIC ack interrupts at mpic_teardown_this_cpu()

2008-04-04 Thread Segher Boessenkool
We really need to ack interrupts at mpic_teardown, since not all platforms reset mpic at kernel start-up. For example, kexec'ed kernel hangs on P.A. Semi if mpic_eoi() isn't called. Signed-off-by: Valentine Barshak <[EMAIL PROTECTED]> --- Would be interesting to find out why it hangs tho... it

Re: Please pull linux-2.6-mpc52xx.git

2008-04-04 Thread Grant Likely
On Fri, Apr 4, 2008 at 11:15 AM, Josh Boyer > > I really like the idea. It would probably make sense to organize it in > > the same way as the platforms are done today, i.e. per processor/platform > > family. And then have shared/merged configs in the main config directory. > > Yes. I was thin

Re: Please pull linux-2.6-mpc52xx.git

2008-04-04 Thread Josh Boyer
On Fri, 2008-04-04 at 11:38 -0500, Olof Johansson wrote: > On Fri, Apr 04, 2008 at 10:14:34AM -0600, Grant Likely wrote: > > On Fri, Apr 4, 2008 at 10:11 AM, Grant Likely <[EMAIL PROTECTED]> wrote: > > > > > > I'm thinking 'optimized' defconfigs should go into a subdirectory. > > > > > > > > > >

Re: Please pull linux-2.6-mpc52xx.git

2008-04-04 Thread Olof Johansson
On Fri, Apr 04, 2008 at 10:14:34AM -0600, Grant Likely wrote: > On Fri, Apr 4, 2008 at 10:11 AM, Grant Likely <[EMAIL PROTECTED]> wrote: > > > > > I'm thinking 'optimized' defconfigs should go into a subdirectory. > > > > > > > > This requires a change to the top-level Makefile and shepherding th

[PATCH] [v4] Add idle wait support for 44x platforms

2008-04-04 Thread Jerone Young
2 files changed, 87 insertions(+), 1 deletion(-) arch/powerpc/platforms/44x/Makefile |2 arch/powerpc/platforms/44x/idle.c | 86 +++ - adds MSR_DE to MSRs to enable while in wait state This patch adds the ability for the CPU to go into wait state while in c

Re: Please pull linux-2.6-mpc52xx.git

2008-04-04 Thread Grant Likely
On Fri, Apr 4, 2008 at 10:11 AM, Grant Likely <[EMAIL PROTECTED]> wrote: > > > > I'm thinking 'optimized' defconfigs should go into a subdirectory. > > > > > > This requires a change to the top-level Makefile and shepherding this > > > change upstream. Could we perhaps try to avoid this by havin

Re: Please pull linux-2.6-mpc52xx.git

2008-04-04 Thread Grant Likely
On Fri, Apr 4, 2008 at 5:13 AM, Bartlomiej Sieka <[EMAIL PROTECTED]> wrote: > > Bartlomiej Sieka wrote: > > > Hi Grant, > > > > Grant Likely wrote: > > > I'm thinking 'optimized' defconfigs should go into a subdirectory. > > > > This requires a change to the top-level Makefile and shepherding this

Re: [kvm-ppc-devel] [PATCH] [v2] Add idle wait support for 44x platforms

2008-04-04 Thread Hollis Blanchard
On Friday 04 April 2008 10:42:41 Jerone Young wrote: > > > +{ > > > +   unsigned long msr_save; > > > + > > > +   msr_save = mfmsr(); > > > +   /* set wait state MSR */ > > > +   mtmsr(msr_save|MSR_WE|MSR_EE|MSR_CE); > > > > Did we decide to drop MSR_DE? > > Hollis argued it down on an earlier emai

[PATCH] [v3] Add idle wait support for 44x platforms

2008-04-04 Thread Jerone Young
2 files changed, 87 insertions(+), 1 deletion(-) arch/powerpc/platforms/44x/Makefile |2 arch/powerpc/platforms/44x/idle.c | 86 +++ This patch adds the ability for the CPU to go into wait state while in cpu_idle loop. This helps virtulization solutions kno

Re: [kvm-ppc-devel] [PATCH] [v2] Add idle wait support for 44x platforms

2008-04-04 Thread Jerone Young
On Fri, 2008-04-04 at 08:36 -0400, Jimi Xenidis wrote: > On Apr 4, 2008, at 3:06 AM, Jerone Young wrote: > > > # HG changeset patch > > # User Jerone Young <[EMAIL PROTECTED]> > > # Date 1207292108 18000 > > # Node ID afed3e5de82ab6c0ac8d6ceeb0292b6c41ece1ed > > # Parent a5b2aebbc6ebd2439c655f1c0

Re: cpu_clock confusion (was: printk time confusion?)

2008-04-04 Thread Ingo Molnar
* Johannes Berg <[EMAIL PROTECTED]> wrote: > Hi, > > > > Not sure whether the lockdep patches or something else is causing this > > > as I haven't checked w/o the patches yet, but I seem to be having some > > > confusion of printk timestamps: > > > > Tried reverting the patches ? > > That didn

Re: [kvm-ppc-devel] [PATCH] Add idle wait support for 44x platforms

2008-04-04 Thread Hollis Blanchard
On Friday 04 April 2008 00:59:59 Jerone Young wrote: > On Thu, 2008-04-03 at 21:00 -0500, Josh Boyer wrote: > > On Thu, 03 Apr 2008 17:43:02 -0500 > > > > Jerone Young <[EMAIL PROTECTED]> wrote: > > > # HG changeset patch > > > # User Jerone Young <[EMAIL PROTECTED]> > > > # Date 1207262487 18000 >

cpu_clock confusion (was: printk time confusion?)

2008-04-04 Thread Johannes Berg
Hi, > > Not sure whether the lockdep patches or something else is causing this > > as I haven't checked w/o the patches yet, but I seem to be having some > > confusion of printk timestamps: > > Tried reverting the patches ? That didn't help, so it's not the lockdep patches causing it. I'm still

[PATCH/RFC] via-pmu: remove mdelays from suspend/resume code

2008-04-04 Thread Johannes Berg
I don't see a reason for either of those mdelay()s, is there any? Works fine for me without them... johannes --- drivers/macintosh/via-pmu.c | 20 +++- 1 file changed, 3 insertions(+), 17 deletions(-) --- everything.orig/drivers/macintosh/via-pmu.c 2008-04-03 17:27:29.0

Oops MPC8343 @ 2.6.25-rc7

2008-04-04 Thread Andre Schwarz
All, I'm having trouble booting a MPC8343 into a recent 2.6.25-rc7 kernel. Kernel config has been reduced to a minimum : no PCI, no netwoking, i2c, spi ... dts has been reduced to the CPU, soc and ipic nodes. U-Boot fills out dtb correctly - as far as I can see. Kernel crashes on various "o

[PATCH] ehea: Fix DLPAR memory add support

2008-04-04 Thread Thomas Klein
This patch fixes two weaknesses in send/receive packet handling which may lead to kernel panics during DLPAR memory add operations. Signed-off-by: Thomas Klein <[EMAIL PROTECTED]> --- diff -Nurp -X dontdiff linux-2.6.25-rc8/drivers/net/ehea/ehea.h patched_kernel/drivers/net/ehea/ehea.h --- linux

Re: [kvm-ppc-devel] [PATCH] [v2] Add idle wait support for 44x platforms

2008-04-04 Thread Jimi Xenidis
On Apr 4, 2008, at 3:06 AM, Jerone Young wrote: # HG changeset patch # User Jerone Young <[EMAIL PROTECTED]> # Date 1207292108 18000 # Node ID afed3e5de82ab6c0ac8d6ceeb0292b6c41ece1ed # Parent a5b2aebbc6ebd2439c655f1c047ed7e3c1991ec1 [v2] Add idle wait support for 44x platforms This patch add

Re: [PATCH] Add idle wait support for 44x platforms

2008-04-04 Thread Josh Boyer
On Fri, 04 Apr 2008 01:12:38 -0500 Jerone Young <[EMAIL PROTECTED]> wrote: > > > > > +static int current_mode = 0; > > > > Leave this as: static int current_mode;, so it'll end up in the bss > > The problem here is that this defines the default case. Is there really > a benefit having this in b

Re: Please pull linux-2.6-mpc52xx.git

2008-04-04 Thread Bartlomiej Sieka
Bartlomiej Sieka wrote: Hi Grant, Grant Likely wrote: On Tue, Mar 25, 2008 at 11:38 AM, Bartlomiej Sieka <[EMAIL PROTECTED]> wrote: Grant Likely wrote: > The one part that I have a really strong opinion on is that there > should be a full featured mpc5200 defconfig for build testing. Beyon

Re: [BUG] 2.6.25-rc8-mm1 kernel panic while bootup on powerpc

2008-04-04 Thread Andy Whitcroft
On Tue, Apr 01, 2008 at 11:39:09PM -0700, Andrew Morton wrote: > On Wed, 02 Apr 2008 11:55:36 +0530 Kamalesh Babulal <[EMAIL PROTECTED]> wrote: > > > Hi Andrew, > > > > The 2.6.25-rc8-mm1 kernel panic's while bootup on the power machine(s). > > > > [0.00] [ cut here ]

Re: [Cbe-oss-dev] [PATCH] RTAS - adapt procfs interface

2008-04-04 Thread Christoph Hellwig
On Fri, Apr 04, 2008 at 07:39:29AM +0200, Arnd Bergmann wrote: > Well we still have the regression against 2.6.23 and I'd like to > get that fixed in 2.6.25 if it's not already release by the time > we get there. > > Would you prefer using Nathan's proper patch for 2.6.25, or do > that for 2.6.26

Carol Dann is out of the office.

2008-04-04 Thread Sheau-Jiuan Dann
I will be out of the office starting 04/04/2008 and will not return until 04/07/2008. Should you need any assistance on RS6000/AIX/TSM , please contact : Mr. Obaid Farghani at 201-413-8028 ([EMAIL PROTECTED]), Mr. Paul Giglio at 201-413-8280 ([EMAIL PROTECTED]) or Mr. Gary Fatone at 201-413-895

Re: [PATCH 2/11] cell: generalize io-workarounds code

2008-04-04 Thread Benjamin Herrenschmidt
On Fri, 2008-04-04 at 15:42 +0900, Ishizaki Kou wrote: > > As you pointed, spider I/O functions in Cell blades need 2 step > indirections by our patch. Shall I make another one for Cell blades > whose spider I/O functions need one step indirection? > (But you will need 2 step indirections when yo

[PATCH] [v2] Add idle wait support for 44x platforms

2008-04-04 Thread Jerone Young
# HG changeset patch # User Jerone Young <[EMAIL PROTECTED]> # Date 1207292108 18000 # Node ID afed3e5de82ab6c0ac8d6ceeb0292b6c41ece1ed # Parent a5b2aebbc6ebd2439c655f1c047ed7e3c1991ec1 [v2] Add idle wait support for 44x platforms This patch adds the ability for the CPU to go into wait state whil