On Fri, Apr 4, 2008 at 12:24 PM, Valentine Barshak <[EMAIL PROTECTED]> wrote: > With a multiplatform kernel, once built we always have > warp_setup_nand_flash() called > and NDFC probed, no matter what machine we actually run on. This potentially > can cause > problems (such as kernel crash), since NDFC is probed at a warp-predefined > address. > Using machine_device_initcall() NAND devices are registered if we run on a > warp only. > > Signed-off-by: Valentine Barshak <[EMAIL PROTECTED]> Acked-by: Grant Likely <[EMAIL PROTECTED]>
> --- > arch/powerpc/platforms/44x/warp-nand.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletion(-) > > --- linux-2.6.orig/arch/powerpc/platforms/44x/warp-nand.c 2008-03-06 > 14:39:46.000000000 +0300 > +++ linux-2.6.bld/arch/powerpc/platforms/44x/warp-nand.c 2008-04-04 > 22:03:36.000000000 +0400 > @@ -11,6 +11,7 @@ > #include <linux/mtd/partitions.h> > #include <linux/mtd/nand.h> > #include <linux/mtd/ndfc.h> > +#include <asm/machdep.h> > > #ifdef CONFIG_MTD_NAND_NDFC > > @@ -100,6 +101,6 @@ static int warp_setup_nand_flash(void) > > return 0; > } > -device_initcall(warp_setup_nand_flash); > +machine_device_initcall(warp, warp_setup_nand_flash); > > #endif > _______________________________________________ > Linuxppc-dev mailing list > Linuxppc-dev@ozlabs.org > https://ozlabs.org/mailman/listinfo/linuxppc-dev > -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev