Re: [PATCH] Bugfix to commit 4f9a58d75bfe82ab2b8ba5b8506dfb190a267834

2007-10-22 Thread Olaf Hering
On Mon, Oct 22, Grant Likely wrote: > Olaf, do I have the correct solution here? Sure. ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: IB/ehca: Fix sg_page() fallout

2007-10-22 Thread Olof Johansson
More fallout from sg_page changes: drivers/infiniband/hw/ehca/ehca_mrmw.c: In function 'ehca_set_pagebuf_user1': drivers/infiniband/hw/ehca/ehca_mrmw.c:1779: error: 'struct scatterlist' has no member named 'page' drivers/infiniband/hw/ehca/ehca_mrmw.c: In function 'ehca_check_kpages_per_ate': dr

Re: IB/ehca: Fix sg_page() fallout

2007-10-22 Thread Jens Axboe
On Mon, Oct 22 2007, Olof Johansson wrote: > More fallout from sg_page changes, found with powerpc allyesconfig: > > drivers/infiniband/hw/ehca/ehca_mrmw.c: In function 'ehca_set_pagebuf_user1': > drivers/infiniband/hw/ehca/ehca_mrmw.c:1779: error: 'struct scatterlist' has > no member named 'page

Re: Problems with allyesconfig kernel build

2007-10-22 Thread Stephen Rothwell
On Mon, 22 Oct 2007 21:18:36 -0700 Andrew Morton <[EMAIL PROTECTED]> wrote: > > On Tue, 23 Oct 2007 14:02:31 +1000 Stephen Rothwell <[EMAIL PROTECTED]> wrote: > > > This was first noted with the -mm tree, but has now migrated into Linus' > > tree. > > Yeah, sorry, I didn't know what to do about t

Re: [microblaze-uclinux] Re: [microblaze-uclinux] RE: [PATCH v3] Device tree bindings for Xilinx devices

2007-10-22 Thread David Gibson
On Tue, Oct 23, 2007 at 06:07:56AM +0200, Michal Simek wrote: > >> In my opinion will be better generate only parameters which > >> you want not all. > >> That smells with unusable parameters. > > > >In the long term, this may be true. In the short term: > >1) dtb size is not the key problem > Ye

[PATCH 4/4] Uartlite: speed up console output

2007-10-22 Thread Grant Likely
From: Grant Likely <[EMAIL PROTECTED]> Change the wait_tx routine to call cpu_relax() instead of udelay() to reduce console output latency and test for the TXFULL bit instead of TXEMPTY. That way the FIFO doesn't need to by 100% flushed before writing the next character. Signed-off-by: Grant Lik

[PATCH 0/4] Misc patches for the 2.6.24 merge window

2007-10-22 Thread Grant Likely
Paulus, Here is the last set of patches that I'd like to get in before Linus slams the merge window shut. They're pretty minor changes. The wrapper patches make it easier to debug and catch errors and David has already okayed them. There's a speedup on the uartlite driver, and then a chunk of d

[PATCH 2/4] bootwrapper: Bail from script if any command fails

2007-10-22 Thread Grant Likely
From: Grant Likely <[EMAIL PROTECTED]> Add the 'set -e' command to the wrapper script so that if any command fails then the script will automatically exit Signed-off-by: Grant Likely <[EMAIL PROTECTED]> Acked-by: David Gibson <[EMAIL PROTECTED]> --- arch/powerpc/boot/wrapper | 27 ++--

[PATCH 3/4] Device tree bindings for Xilinx devices

2007-10-22 Thread Grant Likely
From: Grant Likely <[EMAIL PROTECTED]> Signed-off-by: Grant Likely <[EMAIL PROTECTED]> Acked-by: Stephen Neuendorffer <[EMAIL PROTECTED]> --- Documentation/powerpc/booting-without-of.txt | 261 ++ 1 files changed, 261 insertions(+), 0 deletions(-) diff --git a/Documenta

[PATCH 1/4] bootwrapper: Allow wrapper script to execute verbosely

2007-10-22 Thread Grant Likely
From: Grant Likely <[EMAIL PROTECTED]> Allow wrapper script to print verbose progress when the V is set in the environment. Signed-off-by: Grant Likely <[EMAIL PROTECTED]> Acked-by: David Gibson <[EMAIL PROTECTED]> --- arch/powerpc/boot/wrapper |5 + 1 files changed, 5 insertions(+), 0

IB/ehca: Fix sg_page() fallout

2007-10-22 Thread Olof Johansson
More fallout from sg_page changes, found with powerpc allyesconfig: drivers/infiniband/hw/ehca/ehca_mrmw.c: In function 'ehca_set_pagebuf_user1': drivers/infiniband/hw/ehca/ehca_mrmw.c:1779: error: 'struct scatterlist' has no member named 'page' drivers/infiniband/hw/ehca/ehca_mrmw.c: In function

[PATCH] Read back MSI message in rtas_setup_msi_irqs() so restore works

2007-10-22 Thread Michael Ellerman
There are plans afoot to use pci_restore_msi_state() to restore MSI state after a device reset. In order for this to work for the RTAS MSI backend, we need to read back the MSI message from config space after it has been setup by firmware. This should be sufficient for restoring the MSI state afte

Please pull powerpc.git merge branch

2007-10-22 Thread Paul Mackerras
Linus, Please do git pull \ git://git.kernel.org/pub/scm/linux/kernel/git/paulus/powerpc.git merge to get a commit that adds Vitaly Bordug as a maintainer for the powerpc embedded 8xx processors. This is something that Marcelo asked me to push ages ago, but it kept falling through the cracks.

Re: [PATCH 5/7] pci: Export the pci_restore_msi_state() function

2007-10-22 Thread Michael Ellerman
On Mon, 2007-10-22 at 13:13 -0500, Linas Vepstas wrote: > On Mon, Oct 22, 2007 at 11:49:24AM +1000, Michael Ellerman wrote: > > > > On pseries there's a chance it will work for PCI error recovery, but if > > so it's just lucky that firmware has left everything configured the same > > way. > > ?

Re: Problems with allyesconfig kernel build

2007-10-22 Thread Andrew Morton
On Tue, 23 Oct 2007 14:02:31 +1000 Stephen Rothwell <[EMAIL PROTECTED]> wrote: > This was first noted with the -mm tree, but has now migrated into Linus' > tree. Yeah, sorry, I didn't know what to do about that. I'm not even sure which patch caused it. > An allyesconfig build dies in the link

[PATCH] Allow sysfs_remove_group() to be called on non-added groups

2007-10-22 Thread Michael Ellerman
It would be nice to be able to do: for_each_thing(thing) { error = sysfs_create_group(&thing->kobj, attrs); if (error) { for_each_thing(thing) sysfs_remove_group(&thing->kobj, attrs); return error; } } But there's a B

Re: Problems with allyesconfig kernel build

2007-10-22 Thread Stephen Rothwell
On Tue, 23 Oct 2007 14:02:31 +1000 Stephen Rothwell <[EMAIL PROTECTED]> wrote: > > We link .text.init.refok immediately after .text, but with > allyesconfig, .text ends up very large. Just to give you some idea of what "very large" means, this is an allyesconfig built vmlinux from August: $ ls -l

RE: [microblaze-uclinux] Re: [microblaze-uclinux] RE: [PATCH v3] Device tree bindings for Xilinx devices

2007-10-22 Thread Michal Simek
>> In my opinion will be better generate only parameters which >> you want not all. >> That smells with unusable parameters. > >In the long term, this may be true. In the short term: >1) dtb size is not the key problem Yes of course >2) making sure that everything works is a key problem. >3) The

powerpc: Fix fallout from sg_page() changes

2007-10-22 Thread Olof Johansson
Fix fallout from 18dabf473e15850c0dbc8ff13ac1e2806d542c15: In file included from include/linux/dma-mapping.h:52, from drivers/base/dma-mapping.c:10: include/asm/dma-mapping.h: In function 'dma_map_sg': include/asm/dma-mapping.h:288: error: 'struct scatterlist' has no member named

Problems with allyesconfig kernel build

2007-10-22 Thread Stephen Rothwell
This was first noted with the -mm tree, but has now migrated into Linus' tree. An allyesconfig build dies in the link stage like this: /usr/bin/ld: arch/powerpc/kernel/head_64.o(.text+0x80c8): sibling call optimization to `.text.init.refok' does not allow automatic multiple TOCs; recompile with

Re: Audio codec device tree entries

2007-10-22 Thread Grant Likely
On 10/22/07, Jon Smirl <[EMAIL PROTECTED]> wrote: > Is this what the device tree entries should look like? > > First example is ac97 audio: > > [EMAIL PROTECTED] { // PSC1 > device_type = "sound"; > compatible = "mpc5200b-psc-ac97\0mpc5200-psc-ac97"; This format is so, like.

RE: [PATCH] [POWERPC] ucc_geth: Eliminate compile warnings

2007-10-22 Thread Li Yang-r58472
> -Original Message- > From: Medve Emilian-EMMEDVE1 > Sent: Monday, October 22, 2007 9:48 PM > To: David Miller > Cc: [EMAIL PROTECTED]; Li Yang-r58472; > [EMAIL PROTECTED]; linuxppc-dev@ozlabs.org > Subject: RE: [PATCH] [POWERPC] ucc_geth: Eliminate compile warnings > > Hello David, >

[IRQ]: Fix synchronize_irq races with IRQ handler

2007-10-22 Thread Herbert Xu
On Mon, Oct 22, 2007 at 07:10:05AM +1000, Benjamin Herrenschmidt wrote: > > Hrm... not on yet. Herbert, care to resend, looks like it fell down the > wrong hole in Linus mailbox :-) Thanks for the reminder Ben. Here it is again: [IRQ]: Fix synchronize_irq races with IRQ handler As it is some ca

Re: Device trees and audio codecs

2007-10-22 Thread Grant Likely
On 10/21/07, Jon Smirl <[EMAIL PROTECTED]> wrote: > I have received conflicting opinions as to whether a codec hooked to > an ac97 bus should get a chip specific codec entry in the device tree. > Without the codec specific entry only generic ac97 features can be > used. The Efika has a STA9766. Loo

Re: [PATCH] Allow sysfs_remove_group() to be called on non-added groups

2007-10-22 Thread Greg KH
On Tue, Oct 23, 2007 at 12:02:39PM +1000, Michael Ellerman wrote: > On 9/13/07, Michael Ellerman <[EMAIL PROTECTED]> wrote: > > It would be nice to be able to do: > > > > for_each_thing(thing) { > > error = sysfs_create_group(&thing->kobj, attrs); > > if (error) { > >

Re: libfdt: Make fdt_string() return a const pointer

2007-10-22 Thread David Gibson
On Mon, Oct 22, 2007 at 11:37:43AM -0500, Jon Loeliger wrote: > So, like, the other day David Gibson mumbled: > > Currently, fdt_string() returns a (non-const) char *, despite taking a > > const void *fdt. This is inconsistent with all the other read-only > > functions which all return const point

Re: Audio codec device tree entries

2007-10-22 Thread David Gibson
On Mon, Oct 22, 2007 at 09:59:00PM -0400, Jon Smirl wrote: > Is this what the device tree entries should look like? > > First example is ac97 audio: > > [EMAIL PROTECTED] { // PSC1 > device_type = "sound"; Kill all these device_type values. > compatible = "mpc5200b-psc-ac9

Re: [PATCH] DTC: Remove the need for the GLR Parser.

2007-10-22 Thread David Gibson
On Mon, Oct 22, 2007 at 04:13:54PM -0500, Jon Loeliger wrote: > Previously, there were a few shift/reduce and reduce/reduce > errors in the grammar that were being handled by the not-so-popular > GLR Parser technique. I haven't actually heard anyone whinge about glr-parser... > Flip a right-recur

Re: [PATCH] Allow sysfs_remove_group() to be called on non-added groups

2007-10-22 Thread Michael Ellerman
On 9/13/07, Michael Ellerman <[EMAIL PROTECTED]> wrote: > It would be nice to be able to do: > > for_each_thing(thing) { > error = sysfs_create_group(&thing->kobj, attrs); > if (error) { > for_each_thing(thing) > sysfs_remove_group(&thing->kob

Audio codec device tree entries

2007-10-22 Thread Jon Smirl
Is this what the device tree entries should look like? First example is ac97 audio: [EMAIL PROTECTED] { // PSC1 device_type = "sound"; compatible = "mpc5200b-psc-ac97\0mpc5200-psc-ac97"; cell-index = <0>; reg = <2000 100>; interrupts = <2 1 0>; interr

Re: [PATCH 3/4] DTC: Appease the printf() format $Gods with a correct type.

2007-10-22 Thread Segher Boessenkool
> Yes, I think %z is preferable. It used to be a glibc (et al) > extension, but I think it's now specified in C99 (we should double > check that). It is. Segher ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo

Re: [PATCH 4/4] DTC: Begin the path to sane literals and expressions.

2007-10-22 Thread Segher Boessenkool
Property names have been limited to start with characters from the set [a-zA-Z,._#?]. That is, the digits and the expression symbols have been removed. >>> >>> This cannot work; many property names start with a digit, >>> for example. >> >> Are any of those property names in use in

Re: [PATCH] DTC: Rewrite the propdata and propdataprefix rules.

2007-10-22 Thread David Gibson
On Mon, Oct 22, 2007 at 05:37:57PM -0500, Jon Loeliger wrote: > So, like, the other day Jon Loeliger mumbled: > > > > After staring at these two rules for a bit, and not quite > > groking them, I rewrote them into something I think is a > > bit clearer. With any luck, it's the same language still

Re: [PATCH] DTC: Remove an unneeded %token definition.

2007-10-22 Thread David Gibson
On Mon, Oct 22, 2007 at 05:00:34PM -0500, Jon Loeliger wrote: > Signed-off-by: Jon Loeliger <[EMAIL PROTECTED]> Oops. Can't even remeber what that one was ever there for. Acked-by: David Gibson <[EMAIL PROTECTED]> -- David Gibson| I'll have my music baroque, and my code dav

Re: [PATCH] DTC: Minor grammar rule shuffle.

2007-10-22 Thread David Gibson
On Mon, Oct 22, 2007 at 04:59:45PM -0500, Jon Loeliger wrote: > I like to see the basis cases established early in > the rule sets, so place "empty" reduction first. > Purely cosmetic. > > Signed-off-by: Jon Loeliger <[EMAIL PROTECTED]> As with the change of { } formatting, I don't really care m

Re: [PATCH 3/4] DTC: Appease the printf() format $Gods with a correct type.

2007-10-22 Thread David Gibson
On Mon, Oct 22, 2007 at 11:55:11AM -0500, Josh Boyer wrote: > On Mon, 22 Oct 2007 11:50:52 -0500 > Jon Loeliger <[EMAIL PROTECTED]> wrote: > > > So, like, the other day David Gibson mumbled: > > > On Sat, Oct 20, 2007 at 10:51:29AM +0200, Andreas Schwab wrote: > > > > David Gibson <[EMAIL PROTECTE

Re: [PATCH 4/4] DTC: Begin the path to sane literals and expressions.

2007-10-22 Thread David Gibson
On Mon, Oct 22, 2007 at 07:36:57AM -0500, Jon Loeliger wrote: > So, like, the other day Segher Boessenkool mumbled: > > > Property names have been limited to start with > > > characters from the set [a-zA-Z,._#?]. That is, the > > > digits and the expression symbols have been removed. > > > > Thi

Re: [BUG] powerpc does not save msi state [was Re: [PATCH 5/7] pci: Export the pci_restore_msi_state() function

2007-10-22 Thread Benjamin Herrenschmidt
On Mon, 2007-10-22 at 17:23 -0700, David Miller wrote: > From: [EMAIL PROTECTED] (Linas Vepstas) > Date: Mon, 22 Oct 2007 14:54:52 -0500 > > > As discussed in the other thread, I'll try to set up a patch > > for an arch callback for restoring msi state. >From what it looks like at this stage, pS

Re: [PATCH 5/7] pci: Export the pci_restore_msi_state() function

2007-10-22 Thread Benjamin Herrenschmidt
> > I don't know why you keep talking about powerpc laptops here ... > > Well, there are Apple laptops, right? Aren't those the "powermac" > platform? Now, I don't know if they support MSI, but if they do, > I get the impression that they might not restore msi state correctly, > after being p

Re: [BUG] powerpc does not save msi state [was Re: [PATCH 5/7] pci: Export the pci_restore_msi_state() function

2007-10-22 Thread David Miller
From: [EMAIL PROTECTED] (Linas Vepstas) Date: Mon, 22 Oct 2007 14:54:52 -0500 > As discussed in the other thread, I'll try to set up a patch > for an arch callback for restoring msi state. Thank you. ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org

Please pull powerpc.git master branch

2007-10-22 Thread Paul Mackerras
Linus, Please do git pull \ git://git.kernel.org/pub/scm/linux/kernel/git/paulus/powerpc.git master to get five more commits that fix some bugs for systems using the Freescale embedded 52xx processors and enable them to restart properly. Thanks, Paul. .../powerpc/mpc52xx-device-tree-bindings.

Re: [PATCH 5/7] pci: Export the pci_restore_msi_state() function

2007-10-22 Thread Linas Vepstas
On Tue, Oct 23, 2007 at 07:24:27AM +1000, Benjamin Herrenschmidt wrote: > > On Mon, 2007-10-22 at 13:13 -0500, Linas Vepstas wrote: > > On Mon, Oct 22, 2007 at 11:49:24AM +1000, Michael Ellerman wrote: > > > > > > On pseries there's a chance it will work for PCI error recovery, but if > > > so it

[PATCH] Bugfix to commit 4f9a58d75bfe82ab2b8ba5b8506dfb190a267834

2007-10-22 Thread Grant Likely
From: Grant Likely <[EMAIL PROTECTED]> Commit 4f9a58d75bfe82ab2b8ba5b8506dfb190a267834 changes the size of AT_VECTOR_SIZE from hard coded '44' to a calculation based on the value of AT_VECTOR_SIZE_ARCH and AT_VECTOR_SIZE_BASE. The change works for arch/powerpc, but it breaks arch/ppc because the

Re: [PATCH] DTC: Rewrite the propdata and propdataprefix rules.

2007-10-22 Thread Jon Loeliger
So, like, the other day Jon Loeliger mumbled: > > After staring at these two rules for a bit, and not quite > groking them, I rewrote them into something I think is a > bit clearer. With any luck, it's the same language still. > > Signed-off-by: Jon Loeliger <[EMAIL PROTECTED]> > --- > > You be

[PATCH] DTC: Rewrite the propdata and propdataprefix rules.

2007-10-22 Thread Jon Loeliger
After staring at these two rules for a bit, and not quite groking them, I rewrote them into something I think is a bit clearer. With any luck, it's the same language still. Signed-off-by: Jon Loeliger <[EMAIL PROTECTED]> --- You be the judge too! dtc-parser.y | 31 ++

[PATCH] DTC: Remove an unneeded %token definition.

2007-10-22 Thread Jon Loeliger
Signed-off-by: Jon Loeliger <[EMAIL PROTECTED]> --- dtc-parser.y |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/dtc-parser.y b/dtc-parser.y index c213526..61ed250 100644 --- a/dtc-parser.y +++ b/dtc-parser.y @@ -55,7 +55,6 @@ extern struct boot_info *the_boot_info; %toke

[PATCH] DTC: Minor grammar rule shuffle.

2007-10-22 Thread Jon Loeliger
I like to see the basis cases established early in the rule sets, so place "empty" reduction first. Purely cosmetic. Signed-off-by: Jon Loeliger <[EMAIL PROTECTED]> --- dtc-parser.y | 62 +- 1 files changed, 31 insertions(+), 31 deletions

Re: [PATCH 5/7] pci: Export the pci_restore_msi_state() function

2007-10-22 Thread Benjamin Herrenschmidt
On Mon, 2007-10-22 at 13:13 -0500, Linas Vepstas wrote: > On Mon, Oct 22, 2007 at 11:49:24AM +1000, Michael Ellerman wrote: > > > > On pseries there's a chance it will work for PCI error recovery, but if > > so it's just lucky that firmware has left everything configured the same > > way. > > ?

[PATCH] DTC: Remove the need for the GLR Parser.

2007-10-22 Thread Jon Loeliger
Previously, there were a few shift/reduce and reduce/reduce errors in the grammar that were being handled by the not-so-popular GLR Parser technique. Flip a right-recursive stack-abusing rule into a left-recursive stack-friendly rule and clear up three messes in one shot: No more conflicts, no nee

Re: request_irq fails to get interrupt 12

2007-10-22 Thread Benjamin Herrenschmidt
On Mon, 2007-10-22 at 13:55 -0600, Alan Bennett wrote: > Ok, so what does it take to expose an interrupt vector on a pq2 PIC?? > -Alan Also, if it's the default PIC or if you happen to have the PIC struct irq_host pointer at hand, a quickish way for internal device interrupts is to directly call

Re: [RFC/PATCH 2/2] powerpc: irqtrace support to 64-bit powerpc

2007-10-22 Thread Benjamin Herrenschmidt
On Mon, 2007-10-22 at 15:35 +0200, Johannes Berg wrote: > On Mon, 2007-10-15 at 17:28 +1000, Benjamin Herrenschmidt wrote: > > This adds the low level irq tracing hooks to the powerpc architecture > > needed to enable full lockdep functionality > > > > Some rework from Johannes initial version, r

Re: request_irq fails to get interrupt 12

2007-10-22 Thread Alan Bennett
Ok, so what does it take to expose an interrupt vector on a pq2 PIC?? -Alan Current: / localbus{ ... fundevice1 { interrupts = ; interrupt-parent = <&PIC>; }; ... [EMA

Re: [BUG] powerpc does not save msi state [was Re: [PATCH 5/7] pci: Export the pci_restore_msi_state() function

2007-10-22 Thread Linas Vepstas
On Fri, Oct 19, 2007 at 05:53:08PM -0700, David Miller wrote: > From: [EMAIL PROTECTED] (Linas Vepstas) > Date: Fri, 19 Oct 2007 19:46:10 -0500 > > > FWIW, it looks like not all that many arches do this; the output > > for grep -r address_hi * is pretty thin. Then, looking at > > i386/kernel/io_ap

Re: Device trees and audio codecs

2007-10-22 Thread Segher Boessenkool
It seems to me there are four issues here: 1) How to describe the audio transport controller; 2) How to describe the codecs; 3) How the various parts are connected together in the device tree; 4) How to describe the "layout". >>> How do we want to be consistent with the Efika which uses an AC97 >

Re: [PATCH 5/7] pci: Export the pci_restore_msi_state() function

2007-10-22 Thread Linas Vepstas
On Mon, Oct 22, 2007 at 11:49:24AM +1000, Michael Ellerman wrote: > > On pseries there's a chance it will work for PCI error recovery, but if > so it's just lucky that firmware has left everything configured the same > way. ? The papr is quite clear that i is up to the OS to restore the msi stat

RE: [microblaze-uclinux] Re: [microblaze-uclinux] RE: [PATCH v3] Device tree bindings for Xilinx devices

2007-10-22 Thread Stephen Neuendorffer
> -Original Message- > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED] On Behalf Of > Michal Simek > Sent: Friday, October 19, 2007 7:28 PM > To: [EMAIL PROTECTED] > Cc: Stephen Neuendorffer; Grant Likely; Leonid; Arnd > Bergmann; linuxppc-dev@ozlabs.org; Wolfgang Reissnegger > Subje

Re: request_irq fails to get interrupt 12

2007-10-22 Thread S. Fricke
Hello, > Freescale experts. Why on earth can't I request the IRQ for Timer1? Please consule my question on [1] and the answers. [1] http://ozlabs.org/pipermail/linuxppc-dev/2007-September/042061.html bye Silvio Fricke -- -- S. Fricke - MAILTO:[EMAIL PROTECTED] --

Re: [PATCH 3/4] DTC: Appease the printf() format $Gods with a correct type.

2007-10-22 Thread Josh Boyer
On Mon, 22 Oct 2007 11:50:52 -0500 Jon Loeliger <[EMAIL PROTECTED]> wrote: > So, like, the other day David Gibson mumbled: > > On Sat, Oct 20, 2007 at 10:51:29AM +0200, Andreas Schwab wrote: > > > David Gibson <[EMAIL PROTECTED]> writes: > > > > > > > What compiler/platform is this? I can't off

Re: [PATCH 3/4] DTC: Appease the printf() format $Gods with a correct type.

2007-10-22 Thread Jon Loeliger
So, like, the other day David Gibson mumbled: > On Sat, Oct 20, 2007 at 10:51:29AM +0200, Andreas Schwab wrote: > > David Gibson <[EMAIL PROTECTED]> writes: > > > > > What compiler/platform is this? I can't off the top of my head think > > > of one where size_t shouldn't be promoted to int automa

request_irq fails to get interrupt 12

2007-10-22 Thread Alan Bennett
Freescale experts. Why on earth can't I request the IRQ for Timer1? static int __init dvr_ph_init(void) { u32 rv; int k; //rv = driver_register(&dvr_ph_driver); for (k=0;k<64;k++) { rv = request_irq(k,dvrph_isr , 0, "dvr_ph", NULL);

Re: [PATCH 1/4] DTC: Reformat grammar rules to not mix language syntax and yacc syntax.

2007-10-22 Thread Jon Loeliger
So, like, the other day David Gibson mumbled: > On Fri, Oct 19, 2007 at 12:42:32PM -0500, Jon Loeliger wrote: > > > > Use consistent indenting on all rule actions. > > > > Signed-off-by: Jon Loeliger <[EMAIL PROTECTED]> > > Meh, I kind of did it that way to keep the simple rules less bulky, > bu

Re: dtc: data.c doesn't need to include dtc-parser.tab.h

2007-10-22 Thread Jon Loeliger
So, like, the other day David Gibson mumbled: > Presumably we used this #include once, but it's certainly not > necessary now. > > Signed-off-by: David Gibson <[EMAIL PROTECTED]> Applied. jdl ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https:

Re: dtc: Disable semantic checks by default

2007-10-22 Thread Jon Loeliger
So, like, the other day David Gibson mumbled: > At present, dtc makes a lot of semantic checks on the device tree by > default, and will refuse to produce output if they fail. This means > people tend to need -f to force output despite failing semantic checks > rather a lot. > > This patch splits

Re: libfdt: Add missing RW_CHECK_HEADER to fdt_del_node()

2007-10-22 Thread Jon Loeliger
So, like, the other day David Gibson mumbled: > fdt_del_node(), unlike most of the rw functions does not check the > fdt's header with RW_CHECK_HEADER. However, it could make a mess of > things if the conditions in RW_CHECK_HEADER aren't met. So, this > patch adds the omitted check. > > Signed-o

Re: dtc: Make helper macros in trees.S more flexible

2007-10-22 Thread Jon Loeliger
So, like, the other day David Gibson mumbled: > This patch makes the helper macros in trees.S use separate labels for > the end of each dt subblock, rather than using only start labels. > This means that the macros can now be used to create trees with the > subblocks in non-standard orders. > > In

Re: libfdt: Make fdt_string() return a const pointer

2007-10-22 Thread Jon Loeliger
So, like, the other day David Gibson mumbled: > Currently, fdt_string() returns a (non-const) char *, despite taking a > const void *fdt. This is inconsistent with all the other read-only > functions which all return const pointers into the blob. > > This patch fixes that. > > Signed-off-by: Dav

Re: [PATCH] ppc44x: support for 256K PAGE_SIZE

2007-10-22 Thread Yuri Tikhonov
On Friday 19 October 2007 17:24, Kumar Gala wrote: > > On Oct 18, 2007, at 6:21 PM, Paul Mackerras wrote: > > > Yuri Tikhonov writes: > > > >> The following patch adds support for 256KB PAGE_SIZE on ppc44x- > >> based boards. > >> The applications to be run on the kernel with 256KB PAGE_SIZE hav

Re: Device trees and audio codecs

2007-10-22 Thread Timur Tabi
Jon Smirl wrote: > I meant an ac97 bus. ac97 is conceptually the same as i2s with the > control signals also routed over it. ac97 and i2s are handled in the > same PSC on the 5200. > > I have received conflicting opinions as to whether a codec hooked to > an ac97 bus should get a chip specific co

Re: [RFC/PATCH 2/2] powerpc: irqtrace support to 64-bit powerpc

2007-10-22 Thread Johannes Berg
On Mon, 2007-10-15 at 17:28 +1000, Benjamin Herrenschmidt wrote: > This adds the low level irq tracing hooks to the powerpc architecture > needed to enable full lockdep functionality > > Some rework from Johannes initial version, removing the asm trampoline that > isn't needed (thus improving perf

Re: [bug] block subsystem related crash on Legacy iSeries viodasd.c

2007-10-22 Thread Will Schmidt
On Sun, 2007-10-21 at 14:44 +0200, Jens Axboe wrote: > On Fri, Oct 19 2007, Will Schmidt wrote: > > Hi Jens, Stephen, and Everyone else. ... > You need this, will remember to fix that up for the new branch as well. > > diff --git a/drivers/block/viodasd.c b/drivers/block/viodasd.c > index e824b67.

RE: [PATCH] [POWERPC] ucc_geth: Eliminate compile warnings

2007-10-22 Thread Medve Emilian-EMMEDVE1
Hello David, > No piece of code in the kernel should live in a vacuum. > > In order to improve overall code quality, every piece of > driver code should avoid assuming things about pointer > sizes and things of this nature. I'm afraid we might be talking about orthogonal issues here. I actively

Re: Device trees and audio codecs

2007-10-22 Thread Timur Tabi
Jon Smirl wrote: > Doing it that way will make the kernel specific to the target device. > Currently I can load the same mpc5200 kernel on several different > target devices since the platform specific code is triggered in the > probe machine phase. Maybe I need to take a look at your code, but t

Re: [PATCH 4/4] DTC: Begin the path to sane literals and expressions.

2007-10-22 Thread Jon Loeliger
So, like, the other day Segher Boessenkool mumbled: > > Property names have been limited to start with > > characters from the set [a-zA-Z,._#?]. That is, the > > digits and the expression symbols have been removed. > > This cannot work; many property names start with a digit, > for example. Are

Re: ppc manual paging question

2007-10-22 Thread Benjamin Herrenschmidt
> Yup, I've found how does the kernel handle tlbs, I think the most important > thing is I forgot read/write the SPRN_SPRG3 register as _switch does. SPRG3 is for use by the operating system for whatever you want... if you are copying linux code, then you probably indeed want to get that right b

Re: [Rtlinuxgpl] ppc manual paging question

2007-10-22 Thread Nicholas Mc Guire
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 > OK, Shall I look for the DataTLBError code in head.S? I realized that I've got > DataTLBError sometimes via BDI2000/kgdb (the fault address is within > DataTLBError), Shall I should also look for arch/ppc/mm/fault.c? > if you end up in fault.c (via c

Re: ppc manual paging question

2007-10-22 Thread Wang, Baojun
On Monday 22 October 2007 15:34:24, Benjamin Herrenschmidt wrote: > > Sorry I didn't realized that. I've finished looking pem64b.pdf, but it's > > almost nothing like in ppc 4xx/44x. > > You'll have to get yourself a 44x manual :-) > > > > It's a software loaded TLB, you'll have to put translations

Re: ppc manual paging question

2007-10-22 Thread Benjamin Herrenschmidt
> Sorry I didn't realized that. I've finished looking pem64b.pdf, but it's > almost nothing like in ppc 4xx/44x. You'll have to get yourself a 44x manual :-) > > It's a software loaded TLB, you'll have to put translations in the TLB > > yourself. You'll need to design your own data structures f